Preparing report...

Report for github.com/persistenceOne/persistenceSDK

A+    Excellent!    Found 345 issues across 892 files

Tweet

gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint62%

Golint is a linter for Go source code.

    • persistenceSDK/schema/traits/base/hasImmutables.go
    • Line 15: warning: exported type HasImmutables should have comment or be unexported (golint)
    • Line 21: warning: exported method HasImmutables.GetImmutableProperties should have comment or be unexported (golint)
    • Line 24: warning: exported method HasImmutables.GenerateHashID should have comment or be unexported (golint)
    • persistenceSDK/modules/splits/internal/simulator/constants.go
    • Line 8: warning: exported const OpWeightSubmitTextProposal should have comment or be unexported (golint)
    • Line 9: warning: exported const DefaultWeightTextProposal should have comment or be unexported (golint)
    • Line 11: warning: exported const OpWeightMsg should have comment or be unexported (golint)
    • Line 12: warning: exported const DefaultWeightMsg should have comment or be unexported (golint)
    • persistenceSDK/modules/splits/internal/key/utilities.go
    • Line 40: warning: exported function ReadOwnableID should have comment or be unexported (golint)
    • Line 44: warning: exported function ReadOwnerID should have comment or be unexported (golint)
    • Line 48: warning: exported function FromID should have comment or be unexported (golint)
    • Line 52: warning: exported function ToID should have comment or be unexported (golint)
    • persistenceSDK/schema/traits/base/hasMutables.go
    • Line 13: warning: exported type HasMutables should have comment or be unexported (golint)
    • Line 19: warning: exported method HasMutables.GetMutableProperties should have comment or be unexported (golint)
    • Line 22: warning: exported method HasMutables.Mutate should have comment or be unexported (golint)
    • persistenceSDK/utilities/cuckoo/filter.go
    • Line 7: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 22: warning: exported type Cuckoo should have comment or be unexported (golint)
    • Line 30: warning: exported function NewCuckoo should have comment or be unexported (golint)
    • persistenceSDK/schema/applications/base/simulationApplication.go
    • Line 41: warning: exported type SimulationApplication should have comment or be unexported (golint)
    • Line 64: warning: exported method SimulationApplication.Codec should have comment or be unexported (golint)
    • Line 68: warning: exported method SimulationApplication.BeginBlocker should have comment or be unexported (golint)
    • Line 72: warning: exported method SimulationApplication.EndBlocker should have comment or be unexported (golint)
    • Line 76: warning: exported method SimulationApplication.InitChainer should have comment or be unexported (golint)
    • Line 84: warning: exported method SimulationApplication.ExportAppStateAndValidators should have comment or be unexported (golint)
    • Line 88: warning: exported method SimulationApplication.ModuleAccountAddrs should have comment or be unexported (golint)
    • Line 92: warning: exported method SimulationApplication.SimulationManager should have comment or be unexported (golint)
    • Line 96: warning: exported method SimulationApplication.ModuleManager should have comment or be unexported (golint)
    • Line 100: warning: exported method SimulationApplication.GetBaseApp should have comment or be unexported (golint)
    • Line 104: warning: exported method SimulationApplication.GetKey should have comment or be unexported (golint)
    • Line 108: warning: exported method SimulationApplication.GetTKey should have comment or be unexported (golint)
    • Line 112: warning: exported method SimulationApplication.GetSubspace should have comment or be unexported (golint)
    • Line 116: warning: exported method SimulationApplication.GetModuleAccountPermissions should have comment or be unexported (golint)
    • Line 120: warning: exported method SimulationApplication.GetBlackListedAddresses should have comment or be unexported (golint)
    • Line 129: warning: exported method SimulationApplication.CheckBalance should have comment or be unexported (golint)
    • Line 136: warning: exported method SimulationApplication.AddTestAddresses should have comment or be unexported (golint)
    • Line 160: warning: exported method SimulationApplication.Setup should have comment or be unexported (golint)
    • Line 185: warning: exported method SimulationApplication.SetupWithGenesisAccounts should have comment or be unexported (golint)
    • Line 215: warning: exported method SimulationApplication.NewTestApplication should have comment or be unexported (golint)
    • Line 222: warning: exported function NewSimulationApplication should have comment or be unexported (golint)
    • persistenceSDK/modules/orders/internal/key/utilities.go
    • Line 57: warning: exported function ReadClassificationID should have comment or be unexported (golint)
    • Line 61: warning: exported function ReadRateID should have comment or be unexported (golint)
    • Line 65: warning: exported function ReadCreationID should have comment or be unexported (golint)
    • Line 69: warning: exported function ReadMakerOwnableID should have comment or be unexported (golint)
    • Line 73: warning: exported function ReadTakerOwnableID should have comment or be unexported (golint)
    • Line 77: warning: exported function ReadMakerID should have comment or be unexported (golint)
    • Line 81: warning: exported function FromID should have comment or be unexported (golint)
    • persistenceSDK/modules/identities/internal/simulator/constants.go
    • Line 8: warning: exported const OpWeightSubmitTextProposal should have comment or be unexported (golint)
    • Line 9: warning: exported const DefaultWeightTextProposal should have comment or be unexported (golint)
    • Line 11: warning: exported const OpWeightMsg should have comment or be unexported (golint)
    • Line 12: warning: exported const DefaultWeightMsg should have comment or be unexported (golint)
    • persistenceSDK/modules/orders/internal/simulator/constants.go
    • Line 8: warning: exported const OpWeightSubmitTextProposal should have comment or be unexported (golint)
    • Line 9: warning: exported const DefaultWeightTextProposal should have comment or be unexported (golint)
    • Line 11: warning: exported const OpWeightMsg should have comment or be unexported (golint)
    • Line 12: warning: exported const DefaultWeightMsg should have comment or be unexported (golint)
    • persistenceSDK/simulation/schema/types/base/id.go
    • Line 19: warning: exported function GenerateRandomID should have comment or be unexported (golint)
    • Line 23: warning: exported function GenerateRandomIDWithDec should have comment or be unexported (golint)
    • Line 27: warning: exported function GenerateRandomIDWithInt64 should have comment or be unexported (golint)
    • persistenceSDK/utilities/test/schema/helpers/base/query.go
    • Line 16: warning: exported type TestQueryKeeper should have comment or be unexported (golint)
    • Line 22: warning: exported method TestQueryKeeper.Help should have comment or be unexported (golint)
    • Line 26: warning: exported method TestQueryKeeper.Initialize should have comment or be unexported (golint)
    • Line 30: warning: exported method TestQueryKeeper.Enquire should have comment or be unexported (golint)
    • Line 34: warning: exported function TestQueryKeeperPrototype should have comment or be unexported (golint)
    • Line 66: warning: exported function TestQueryRequestPrototype should have comment or be unexported (golint)
    • Line 95: warning: exported function TestQueryResponsePrototype should have comment or be unexported (golint)
    • persistenceSDK/modules/maintainers/internal/simulator/constants.go
    • Line 8: warning: exported const OpWeightSubmitTextProposal should have comment or be unexported (golint)
    • Line 9: warning: exported const DefaultWeightTextProposal should have comment or be unexported (golint)
    • Line 11: warning: exported const OpWeightMsg should have comment or be unexported (golint)
    • Line 12: warning: exported const DefaultWeightMsg should have comment or be unexported (golint)
    • persistenceSDK/utilities/test/schema/helpers/base/mapper.go
    • Line 24: warning: exported function SetupTest should have comment or be unexported (golint)
    • Line 44: warning: exported function MakeCodec should have comment or be unexported (golint)
    • Line 79: warning: exported function NewKey should have comment or be unexported (golint)
    • Line 83: warning: exported function KeyPrototype should have comment or be unexported (golint)
    • Line 103: warning: exported function NewMappable should have comment or be unexported (golint)
    • Line 107: warning: exported function MappablePrototype should have comment or be unexported (golint)
    • persistenceSDK/utilities/test/schema/helpers/base/message.go
    • Line 24: warning: exported function NewTestMessage should have comment or be unexported (golint)
    • Line 30: warning: exported method TestMessage.Route should have comment or be unexported (golint)
    • Line 31: warning: exported method TestMessage.Type should have comment or be unexported (golint)
    • Line 32: warning: exported method TestMessage.GetSignBytes should have comment or be unexported (golint)
    • Line 40: warning: exported method TestMessage.ValidateBasic should have comment or be unexported (golint)
    • Line 41: warning: exported method TestMessage.GetSigners should have comment or be unexported (golint)
    • Line 44: warning: exported method TestMessage.RegisterCodec should have comment or be unexported (golint)
    • Line 48: warning: exported function TestMessagePrototype should have comment or be unexported (golint)
    • persistenceSDK/modules/assets/internal/simulator/constants.go
    • Line 8: warning: exported const OpWeightSubmitTextProposal should have comment or be unexported (golint)
    • Line 9: warning: exported const DefaultWeightTextProposal should have comment or be unexported (golint)
    • Line 11: warning: exported const OpWeightMsg should have comment or be unexported (golint)
    • Line 12: warning: exported const DefaultWeightMsg should have comment or be unexported (golint)
    • persistenceSDK/utilities/test/schema/helpers/base/transaction.go
    • Line 19: warning: exported type TransactionRequest should have comment or be unexported (golint)
    • Line 26: warning: exported method TransactionRequest.Validate should have comment or be unexported (golint)
    • Line 29: warning: exported method TransactionRequest.FromCLI should have comment or be unexported (golint)
    • Line 32: warning: exported method TransactionRequest.FromJSON should have comment or be unexported (golint)
    • Line 39: warning: exported method TransactionRequest.GetBaseReq should have comment or be unexported (golint)
    • Line 42: warning: exported method TransactionRequest.MakeMsg should have comment or be unexported (golint)
    • Line 45: warning: exported method TransactionRequest.RegisterCodec should have comment or be unexported (golint)
    • Line 48: warning: exported function TestTransactionRequestPrototype should have comment or be unexported (golint)
    • Line 81: warning: exported function TestTransactionKeeperPrototype should have comment or be unexported (golint)
    • persistenceSDK/constants/project.go
    • Line 8: warning: exported const ProjectName should have comment or be unexported (golint)
    • Line 9: warning: exported const ProjectRoute should have comment or be unexported (golint)
    • Line 11: warning: exported const IDSeparator should have comment or be unexported (golint)
    • Line 12: warning: exported const FirstOrderCompositeIDSeparator should have comment or be unexported (golint)
    • Line 13: warning: exported const SecondOrderCompositeIDSeparator should have comment or be unexported (golint)
    • Line 14: warning: exported const PropertiesSeparator should have comment or be unexported (golint)
    • Line 15: warning: exported const ListDataStringSeparator should have comment or be unexported (golint)
    • Line 16: warning: exported const PropertyIDAndDataSeparator should have comment or be unexported (golint)
    • Line 17: warning: exported const DataTypeAndValueSeparator should have comment or be unexported (golint)
    • Line 18: warning: exported const ToHashSeparator should have comment or be unexported (golint)
    • Line 20: warning: exported const MaxPropertyCount should have comment or be unexported (golint)
    • persistenceSDK/modules/metas/internal/simulator/constants.go
    • Line 8: warning: exported const OpWeightSubmitTextProposal should have comment or be unexported (golint)
    • Line 9: warning: exported const DefaultWeightTextProposal should have comment or be unexported (golint)
    • Line 11: warning: exported const OpWeightMsg should have comment or be unexported (golint)
    • Line 12: warning: exported const DefaultWeightMsg should have comment or be unexported (golint)

gocyclo99%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!