Preparing report...

Report for github.com/pipeproxy/pipe-xds

A    Great!    Found 264 issues across 268 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint1%

Golint is a linter for Go source code.

    • pipe-xds/internal/proxy/proxy.go
    • Line 23: warning: exported type Config should have comment or be unexported (golint)
    • Line 31: warning: exported type Proxy should have comment or be unexported (golint)
    • Line 39: warning: exported function NewProxy should have comment or be unexported (golint)
    • Line 50: warning: exported method Proxy.ConfigCtx should have comment or be unexported (golint)
    • Line 54: warning: exported method Proxy.ADSC should have comment or be unexported (golint)
    • Line 58: warning: exported method Proxy.Run should have comment or be unexported (golint)
    • Line 170: warning: exported method Proxy.Ready should have comment or be unexported (golint)
    • pipe-xds/internal/config/config.go
    • Line 22: warning: exported type ConfigCtx should have comment or be unexported (golint)
    • Line 35: warning: exported function NewConfigCtx should have comment or be unexported (golint)
    • Line 50: warning: exported method ConfigCtx.Update should have comment or be unexported (golint)
    • Line 57: warning: exported method ConfigCtx.RegisterCDS should have comment or be unexported (golint)
    • Line 72: warning: exported method ConfigCtx.CDS should have comment or be unexported (golint)
    • Line 79: warning: exported method ConfigCtx.RegisterEDS should have comment or be unexported (golint)
    • Line 94: warning: exported method ConfigCtx.EDS should have comment or be unexported (golint)
    • Line 101: warning: exported method ConfigCtx.RegisterLDS should have comment or be unexported (golint)
    • Line 116: warning: exported method ConfigCtx.LDS should have comment or be unexported (golint)
    • Line 123: warning: exported method ConfigCtx.RegisterRDS should have comment or be unexported (golint)
    • Line 138: warning: exported method ConfigCtx.RDS should have comment or be unexported (golint)
    • Line 145: warning: exported method ConfigCtx.RegisterSDS should have comment or be unexported (golint)
    • Line 160: warning: exported method ConfigCtx.SDS should have comment or be unexported (golint)
    • Line 167: warning: exported method ConfigCtx.Save should have comment or be unexported (golint)
    • Line 256: warning: exported method ConfigCtx.Watch should have comment or be unexported (golint)
    • pipe-xds/internal/convert/xds_config_accesslog_v3_accesslog.go
    • Line 14: warning: exported function Convert_config_accesslog_v3_AccessLog_StreamHandler should have comment or be unexported (golint)
    • Line 14: warning: don't use underscores in Go names; func Convert_config_accesslog_v3_AccessLog_StreamHandler should be ConvertConfigAccesslogV3AccessLogStreamHandler (golint)
    • Line 46: warning: exported function Convert_config_accesslog_v3_AccessLog_HTTPHandler should have comment or be unexported (golint)
    • Line 46: warning: don't use underscores in Go names; func Convert_config_accesslog_v3_AccessLog_HTTPHandler should be ConvertConfigAccesslogV3AccessLogHTTPHandler (golint)
    • pipe-xds/internal/convert/xds_config_bootstrap_v3_admin.go
    • Line 12: warning: exported function Convert_config_bootstrap_v3_Admin should have comment or be unexported (golint)
    • Line 12: warning: don't use underscores in Go names; func Convert_config_bootstrap_v3_Admin should be ConvertConfigBootstrapV3Admin (golint)
    • Line 35: warning: exported function BuildAdminWithHTTPHandler should have comment or be unexported (golint)
    • pipe-xds/internal/convert/xds_config_listener_v3_listener.go
    • Line 13: warning: exported function Convert_config_listener_v3_Listener should have comment or be unexported (golint)
    • Line 13: warning: don't use underscores in Go names; func Convert_config_listener_v3_Listener should be ConvertConfigListenerV3Listener (golint)
    • Line 79: warning: exported function SelectFilterChain should have comment or be unexported (golint)
    • pipe-xds/internal/proxy/adapter/adapter.go
    • Line 13: warning: exported const XDS should have comment (or a comment on this block) or be unexported (golint)
    • Line 17: warning: exported type Config should have comment or be unexported (golint)
    • Line 22: warning: exported function NewAdapter should have comment or be unexported (golint)
    • pipe-xds/internal/pipe/pipe.go
    • Line 18: warning: exported const ConfigFile should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: exported type Pipe should have comment or be unexported (golint)
    • Line 27: warning: exported function NewPipe should have comment or be unexported (golint)
    • Line 39: warning: exported method Pipe.Run should have comment or be unexported (golint)
    • Line 70: warning: exported method Pipe.Signal should have comment or be unexported (golint)
    • pipe-xds/internal/adsc/xds.go
    • Line 91: warning: exported method XDSClient.Start should have comment or be unexported (golint)
    • Line 206: warning: exported method XDSClient.Node should have comment or be unexported (golint)
    • Line 210: warning: exported method XDSClient.Send should have comment or be unexported (golint)
    • Line 215: warning: exported method XDSClient.SendRsc should have comment or be unexported (golint)
    • pipe-xds/internal/adsc/adsc.go
    • Line 22: warning: exported type ADSC should have comment or be unexported (golint)
    • Line 66: warning: exported function NewADSC should have comment or be unexported (golint)
    • Line 80: warning: exported method ADSC.Run should have comment or be unexported (golint)
    • pipe-xds/internal/encoding/marshal.go
    • Line 30: warning: exported function Marshal should have comment or be unexported (golint)
    • Line 39: warning: exported function Unmarshal should have comment or be unexported (golint)
    • Line 45: warning: exported function UnmarshalAny should have comment or be unexported (golint)
    • Line 57: warning: exported function UnmarshalBootstrap should have comment or be unexported (golint)
    • Line 72: warning: exported function MarshalBootstrap should have comment or be unexported (golint)
    • pipe-xds/internal/adsc/resource.go
    • Line 16: warning: exported const ClusterType should have comment (or a comment on this block) or be unexported (golint)
    • Line 36: warning: exported function GetSDSName should have comment or be unexported (golint)
    • Line 63: warning: exported function Convert_extensions_transport_sockets_tls_v3_CommonTlsContext should have comment or be unexported (golint)
    • Line 63: warning: don't use underscores in Go names; func Convert_extensions_transport_sockets_tls_v3_CommonTlsContext should be ConvertExtensionsTransportSocketsTLSV3CommonTLSContext (golint)
    • Line 85: warning: exported function SelectFilterChain should have comment or be unexported (golint)
    • pipe-xds/internal/adsc/sds.go
    • Line 82: warning: exported method SDSClient.Start should have comment or be unexported (golint)
    • Line 169: warning: exported method SDSClient.Node should have comment or be unexported (golint)
    • Line 173: warning: exported method SDSClient.Send should have comment or be unexported (golint)
    • Line 178: warning: exported method SDSClient.SendRsc should have comment or be unexported (golint)
    • pipe-xds/internal/adsc/tls.go
    • Line 10: warning: exported function TlsConfigFromDir should have comment or be unexported (golint)
    • Line 29: warning: exported function TlsConfig should have comment or be unexported (golint)
    • Line 49: warning: exported function CaConfigFromFile should have comment or be unexported (golint)
    • Line 58: warning: exported function CAConfig should have comment or be unexported (golint)
    • pipe-xds/internal/convert/xds_config_route_v3_routematch.go
    • Line 13: warning: exported function Convert_config_route_v3_RouteMatch should have comment or be unexported (golint)
    • Line 13: warning: don't use underscores in Go names; func Convert_config_route_v3_RouteMatch should be ConvertConfigRouteV3RouteMatch (golint)
    • Line 19: warning: exported function Convert_config_route_v3_RouteMatch_Path should have comment or be unexported (golint)
    • Line 19: warning: don't use underscores in Go names; func Convert_config_route_v3_RouteMatch_Path should be ConvertConfigRouteV3RouteMatchPath (golint)
    • Line 34: warning: exported function Convert_config_route_v3_RouteMatch_Header should have comment or be unexported (golint)
    • Line 34: warning: don't use underscores in Go names; func Convert_config_route_v3_RouteMatch_Header should be ConvertConfigRouteV3RouteMatchHeader (golint)
    • Line 79: warning: exported function Convert_config_route_v3_RouteMatch_Query should have comment or be unexported (golint)
    • Line 79: warning: don't use underscores in Go names; func Convert_config_route_v3_RouteMatch_Query should be ConvertConfigRouteV3RouteMatchQuery (golint)

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!