Report for github.com/plesk/pleskapp
A+ Excellent! Found 28 issues across 52 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo98%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
pleskapp/upload/ftp.go
- Line 100: warning: cyclomatic complexity 16 of function (*ftpConnection).UploadFile() is high (> 15) (gocyclo)
golint46%
Golint is a linter for Go source code.
-
-
pleskapp/api/json/databases.go
- Line 33: warning: exported function NewDatabases should have comment or be unexported (golint)
-
-
pleskapp/actions/ftp.go
- Line 12: warning: exported function FindCachedFtpUser should have comment or be unexported (golint)
- Line 19: warning: exported function FtpUserCreate should have comment or be unexported (golint)
-
-
pleskapp/cmd/servers/servers.go
- Line 10: warning: exported var ServersCmd should have comment or be unexported (golint)
-
-
pleskapp/cmd/apps/apps.go
- Line 10: warning: exported var AppsCmd should have comment or be unexported (golint)
-
-
pleskapp/actions/servers.go
- Line 20: warning: exported const AdminUser should have comment or be unexported (golint)
- Line 55: warning: exported function ServerAdd should have comment or be unexported (golint)
- Line 90: warning: exported function ServerLogin should have comment or be unexported (golint)
- Line 110: warning: exported function ServerSSH should have comment or be unexported (golint)
- Line 120: warning: exported function ServerList should have comment or be unexported (golint)
- Line 165: warning: exported function ServerReauth should have comment or be unexported (golint)
- Line 191: warning: exported function ServerRemove should have comment or be unexported (golint)
-
-
pleskapp/cmd/servers/login.go
- Line 12: warning: exported var ServerLoginCmd should have comment or be unexported (golint)
-
-
pleskapp/actions/domains.go
- Line 42: warning: exported function DomainAdd should have comment or be unexported (golint)
- Line 69: warning: exported function DomainList should have comment or be unexported (golint)
- Line 77: warning: exported function DomainReload should have comment or be unexported (golint)
- Line 108: warning: exported function DomainDelete should have comment or be unexported (golint)
-
-
pleskapp/types/types.go
- Line 7: warning: exported type Server should have comment or be unexported (golint)
- Line 17: warning: exported method Server.GetServerAuth should have comment or be unexported (golint)
- Line 27: warning: exported method Server.GetDatabaseServer should have comment or be unexported (golint)
- Line 36: warning: exported method Server.GetDatabaseServerByType should have comment or be unexported (golint)
- Line 49: warning: exported type ServerInfo should have comment or be unexported (golint)
- Line 55: warning: exported type ServerIPAddresses should have comment or be unexported (golint)
- Line 60: warning: exported type Domain should have comment or be unexported (golint)
- Line 68: warning: exported type App should have comment or be unexported (golint)
- Line 75: warning: exported type Config should have comment or be unexported (golint)
- Line 79: warning: exported type FtpUser should have comment or be unexported (golint)
- Line 84: warning: exported type Database should have comment or be unexported (golint)
- Line 91: warning: exported type NewDatabase should have comment or be unexported (golint)
- Line 98: warning: exported type DatabaseUser should have comment or be unexported (golint)
- Line 105: warning: exported type NewDatabaseUser should have comment or be unexported (golint)
- Line 113: warning: exported type DatabaseServer should have comment or be unexported (golint)
- Line 122: warning: exported type ServerAuth should have comment or be unexported (golint)
-
-
pleskapp/api/json/info.go
- Line 35: warning: exported function NewInfo should have comment or be unexported (golint)
-
-
pleskapp/upload/ftp.go
- Line 26: warning: exported function Connect should have comment or be unexported (golint)
-
-
pleskapp/cmd/servers/ssh.go
- Line 12: warning: exported var SSHCmd should have comment or be unexported (golint)
-
-
pleskapp/features/features.go
- Line 13: warning: exported type Feature should have comment or be unexported (golint)
- Line 16: warning: exported const Php70 should have comment (or a comment on this block) or be unexported (golint)
- Line 25: warning: exported type FeatureProvider should have comment or be unexported (golint)
- Line 29: warning: exported function GetFeatureByString should have comment or be unexported (golint)
- Line 57: warning: exported method FeatureProvider.GetFeaturePackage should have comment or be unexported (golint)
-
-
pleskapp/actions/databases.go
- Line 15: warning: exported function DatabaseFindNonLocal should have comment or be unexported (golint)
- Line 38: warning: exported function DatabaseAdd should have comment or be unexported (golint)
- Line 56: warning: exported function DatabaseList should have comment or be unexported (golint)
- Line 69: warning: exported function DatabaseDeploy should have comment or be unexported (golint)
- Line 111: warning: exported function DatabaseDelete should have comment or be unexported (golint)
-
-
pleskapp/actions/upload.go
- Line 45: warning: exported function UploadFileToRoot should have comment or be unexported (golint)
- Line 60: warning: exported function UploadFile should have comment or be unexported (golint)
- Line 75: warning: exported function UploadDirectory should have comment or be unexported (golint)
-
-
pleskapp/cmd/root.go
- Line 22: warning: exported function Execute should have comment or be unexported (golint)
-
-
pleskapp/api/types.go
- Line 7: warning: exported type DomainManagement should have comment or be unexported (golint)
- Line 15: warning: exported type DomainInfo should have comment or be unexported (golint)
- Line 25: warning: exported type FTPManagement should have comment or be unexported (golint)
- Line 32: warning: exported type FTPUserInfo should have comment or be unexported (golint)
- Line 39: warning: exported type DatabaseManagement should have comment or be unexported (golint)
- Line 48: warning: exported type DatabaseInfo should have comment or be unexported (golint)
- Line 56: warning: exported type DatabaseServerInfo should have comment or be unexported (golint)
- Line 66: warning: exported type DatabaseUserManagement should have comment or be unexported (golint)
- Line 72: warning: exported type DatabaseUserInfo should have comment or be unexported (golint)
- Line 78: warning: exported type Authentication should have comment or be unexported (golint)
- Line 84: warning: exported type Server should have comment or be unexported (golint)
- Line 89: warning: exported type ServerInfo should have comment or be unexported (golint)
- Line 94: warning: exported type AuthClient should have comment or be unexported (golint)
- Line 98: warning: exported type Auth should have comment or be unexported (golint)
-
-
pleskapp/api/json/auth.go
- Line 29: warning: exported function NewAuth should have comment or be unexported (golint)
- Line 114: warning: exported method Auth.GetLoginLink should have comment or be unexported (golint)
-
-
pleskapp/api/json/domains.go
- Line 41: warning: exported function NewDomains should have comment or be unexported (golint)
-
-
pleskapp/api/json/ftp.go
- Line 38: warning: exported function NewFTP should have comment or be unexported (golint)
-
-
pleskapp/utils/utils.go
- Line 18: warning: exported function FilterDomains should have comment or be unexported (golint)
- Line 33: warning: exported function FilterDatabases should have comment or be unexported (golint)
- Line 48: warning: exported function FilterServers should have comment or be unexported (golint)
- Line 63: warning: exported function GeneratePassword should have comment or be unexported (golint)
- Line 83: warning: exported function GenerateUsername should have comment or be unexported (golint)
- Line 98: warning: exported function RequestPassword should have comment or be unexported (golint)
- Line 119: warning: exported function StrSplitRN should have comment or be unexported (golint)
- Line 131: warning: exported function GetClientRootName should have comment or be unexported (golint)
-
-
pleskapp/api/factory/factory.go
- Line 43: warning: exported function GetDomainManagement should have comment or be unexported (golint)
- Line 47: warning: exported function GetFTPUserManagement should have comment or be unexported (golint)
- Line 51: warning: exported function GetDatabaseManagement should have comment or be unexported (golint)
- Line 55: warning: exported function GetDatabaseUserManagement should have comment or be unexported (golint)
- Line 59: warning: exported function GetAuthentication should have comment or be unexported (golint)
- Line 63: warning: exported function GetServerInfo should have comment or be unexported (golint)
-
-
pleskapp/types/errors.go
- Line 7: warning: exported type ObjectNotFound should have comment or be unexported (golint)
- Line 21: warning: exported type ServerNotFound should have comment or be unexported (golint)
- Line 29: warning: exported type DomainNotFound should have comment or be unexported (golint)
- Line 38: warning: exported type DatabaseNotFound should have comment or be unexported (golint)
- Line 47: warning: exported type DatabaseServerNotFound should have comment or be unexported (golint)
-
-
pleskapp/actions/apps.go
- Line 16: warning: exported function AppAdd should have comment or be unexported (golint)
- Line 56: warning: exported function AppDeploy should have comment or be unexported (golint)
-
-
pleskapp/cmd/sync/sync.go
- Line 16: warning: exported var SyncCmd should have comment or be unexported (golint)
-
-
pleskapp/cmd/databases/databases.go
- Line 10: warning: exported var DatabasesCmd should have comment or be unexported (golint)
-
-
pleskapp/cmd/domains/domains.go
- Line 10: warning: exported var DomainsCmd should have comment or be unexported (golint)
-
-
pleskapp/config/global.go
- Line 26: warning: exported function New should have comment or be unexported (golint)
- Line 45: warning: exported function Save should have comment or be unexported (golint)
- Line 62: warning: exported function GetServer should have comment or be unexported (golint)
- Line 85: warning: exported function GetServerByArgs should have comment or be unexported (golint)
- Line 100: warning: exported function DefaultServer should have comment or be unexported (golint)
- Line 112: warning: exported function GetServers should have comment or be unexported (golint)
- Line 118: warning: exported function GetDomain should have comment or be unexported (golint)
- Line 127: warning: exported function GetDatabase should have comment or be unexported (golint)
- Line 137: warning: exported function DeleteDatabase should have comment or be unexported (golint)
- Line 153: warning: exported function SetServers should have comment or be unexported (golint)
- Line 159: warning: exported function SetDomains should have comment or be unexported (golint)
- Line 165: warning: exported function SetDomain should have comment or be unexported (golint)
-
-
pleskapp/utils/logger.go
- Line 12: warning: exported var Log should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!