Go Report Card

Preparing report...

Report for github.com/prism-river/killy

A+    Excellent!    Found 11 issues across 16 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint31%

Golint is a linter for Go source code.

    • killy/internal/lg/lg.go
    • Line 1: warning: package comment should be of the form "Package lg ..." (golint)
    • Line 9: warning: exported type LogLevel should have comment or be unexported (golint)
    • Line 12: warning: exported const DEBUG should have comment (or a comment on this block) or be unexported (golint)
    • Line 19: warning: exported type AppLogFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type Logger should have comment or be unexported (golint)
    • Line 25: warning: exported type NilLogger should have comment or be unexported (golint)
    • Line 27: warning: exported method NilLogger.Output should have comment or be unexported (golint)
    • Line 47: warning: exported function ParseLogLevel should have comment or be unexported (golint)
    • Line 70: warning: exported function Logf should have comment or be unexported (golint)
    • killy/internal/util/client.go
    • Line 11: warning: exported type Collect should have comment or be unexported (golint)
    • Line 15: warning: exported function NewCollect should have comment or be unexported (golint)
    • Line 21: warning: exported method Collect.Query should have comment or be unexported (golint)
    • killy/collectors/builtin_pd.go
    • Line 9: warning: exported type PdConnection should have comment or be unexported (golint)
    • Line 25: warning: exported function GetPdConn should have comment or be unexported (golint)
    • Line 65: warning: exported method PdConnection.Start should have comment or be unexported (golint)
    • killy/collectors/builtin_tikv.go
    • Line 12: warning: exported type PdTikvConnection should have comment or be unexported (golint)
    • Line 19: warning: exported type TikvStore should have comment or be unexported (golint)
    • Line 48: warning: exported function GetPdTikvConn should have comment or be unexported (golint)
    • Line 115: warning: exported method PdTikvConnection.Start should have comment or be unexported (golint)
    • killy/killyd/channel.go
    • Line 11: warning: exported type Consumer should have comment or be unexported (golint)
    • Line 19: warning: exported type Channel should have comment or be unexported (golint)
    • Line 30: warning: exported function NewChannel should have comment or be unexported (golint)
    • Line 61: warning: exported method Channel.StartChannel should have comment or be unexported (golint)
    • Line 87: warning: exported method Channel.StartTikvChannel should have comment or be unexported (golint)
    • Line 116: warning: exported method Channel.Close should have comment or be unexported (golint)
    • killy/killyd/killdy.go
    • Line 19: warning: exported type KILLYD should have comment or be unexported (golint)
    • Line 30: warning: exported function New should have comment or be unexported (golint)
    • Line 56: warning: exported method KILLYD.Loadmeta should have comment or be unexported (golint)
    • Line 66: warning: exported method KILLYD.Main should have comment or be unexported (golint)
    • Line 76: warning: exported method KILLYD.Exit should have comment or be unexported (golint)
    • Line 146: warning: exported method KILLYD.ToMinecraft should have comment or be unexported (golint)
    • killy/collectors/builtin_tidb.go
    • Line 9: warning: exported type TidbConnection should have comment or be unexported (golint)
    • Line 20: warning: exported function GetTidbConn should have comment or be unexported (golint)
    • Line 55: warning: exported method TidbConnection.Start should have comment or be unexported (golint)
    • killy/internal/version/buildversion.go
    • Line 10: warning: exported var GitCommit should have comment or be unexported (golint)
    • Line 22: warning: exported type VersionOptions should have comment or be unexported (golint)
    • Line 31: warning: exported function String should have comment or be unexported (golint)
    • killy/killyd/daemon.go
    • Line 57: warning: exported type Daemon should have comment or be unexported (golint)
    • Line 71: warning: exported type Config should have comment or be unexported (golint)
    • Line 81: warning: exported function NewDaemon should have comment or be unexported (golint)
    • Line 87: warning: exported method Daemon.Init should have comment or be unexported (golint)
    • Line 107: warning: exported method Daemon.Exit should have comment or be unexported (golint)
    • Line 111: warning: exported method Daemon.Serve should have comment or be unexported (golint)
    • Line 289: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 308: warning: exported method Daemon.ConversionMinecraft should have comment or be unexported (golint)
    • Line 360: warning: exported method Daemon.StartMonitoringEvents should have comment or be unexported (golint)
    • killy/killyd/logger.go
    • Line 7: warning: exported type Logger should have comment or be unexported (golint)
    • Line 10: warning: exported const LOG_DEBUG should have comment (or a comment on this block) or be unexported (golint)
    • killy/killyd/options.go
    • Line 8: warning: exported type Meta should have comment or be unexported (golint)
    • Line 12: warning: exported type Channels should have comment or be unexported (golint)
    • Line 14: warning: exported type ChannelsMeta should have comment or be unexported (golint)
    • Line 26: warning: exported type Options should have comment or be unexported (golint)
    • Line 38: warning: exported function NewOptions should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign93%

IneffAssign detects ineffectual assignments in Go code.

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!