Report for github.com/progrium/qtalk-go
A+ Excellent! Found 21 issues across 44 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo95%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
qtalk-go/fn/handler_test.go
- Line 23: warning: cyclomatic complexity 16 of function TestHandlerFromFunc() is high (> 15) (gocyclo)
-
-
qtalk-go/rpc/rpc_test.go
- Line 195: warning: cyclomatic complexity 26 of function TestRPC() is high (> 15) (gocyclo)
golint61%
Golint is a linter for Go source code.
-
-
qtalk-go/fn/handler.go
- Line 57: warning: don't use underscores in Go names; func parameter fn_ should be fn (golint)
- Line 57: warning: don't use underscores in Go names; func parameter rcvr_ should be rcvr (golint)
-
-
qtalk-go/mux/frame/message_open.go
- Line 9: warning: exported type OpenMessage should have comment or be unexported (golint)
- Line 20: warning: exported method OpenMessage.Channel should have comment or be unexported (golint)
- Line 24: warning: exported method OpenMessage.Bytes should have comment or be unexported (golint)
-
-
qtalk-go/mux/frame/encoder.go
- Line 15: warning: exported function NewEncoder should have comment or be unexported (golint)
- Line 19: warning: exported method Encoder.Encode should have comment or be unexported (golint)
-
-
qtalk-go/mux/frame/message.go
- Line 13: warning: exported type Message should have comment or be unexported (golint)
-
-
qtalk-go/mux/frame/message_data.go
- Line 8: warning: exported type DataMessage should have comment or be unexported (golint)
- Line 19: warning: exported method DataMessage.Channel should have comment or be unexported (golint)
- Line 23: warning: exported method DataMessage.Bytes should have comment or be unexported (golint)
-
-
qtalk-go/mux/frame/message_openconfirm.go
- Line 9: warning: exported type OpenConfirmMessage should have comment or be unexported (golint)
- Line 21: warning: exported method OpenConfirmMessage.Channel should have comment or be unexported (golint)
- Line 25: warning: exported method OpenConfirmMessage.Bytes should have comment or be unexported (golint)
-
-
qtalk-go/mux/session.go
- Line 44: warning: comment on exported function New should be of the form "New ..." (golint)
-
-
qtalk-go/codec/codec.go
- Line 7: warning: exported type Encoder should have comment or be unexported (golint)
- Line 12: warning: exported type Decoder should have comment or be unexported (golint)
-
-
qtalk-go/mux/frame/message_close.go
- Line 9: warning: exported type CloseMessage should have comment or be unexported (golint)
- Line 17: warning: exported method CloseMessage.Channel should have comment or be unexported (golint)
- Line 21: warning: exported method CloseMessage.Bytes should have comment or be unexported (golint)
-
-
qtalk-go/mux/frame/message_eof.go
- Line 9: warning: exported type EOFMessage should have comment or be unexported (golint)
- Line 17: warning: exported method EOFMessage.Channel should have comment or be unexported (golint)
- Line 21: warning: exported method EOFMessage.Bytes should have comment or be unexported (golint)
-
-
qtalk-go/mux/frame/message_openfailure.go
- Line 9: warning: exported type OpenFailureMessage should have comment or be unexported (golint)
- Line 17: warning: exported method OpenFailureMessage.Channel should have comment or be unexported (golint)
- Line 21: warning: exported method OpenFailureMessage.Bytes should have comment or be unexported (golint)
-
-
qtalk-go/rpc/rpc.go
- Line 113: warning: don't use underscores in Go names; method parameter continue_ should be continue (golint)
-
-
qtalk-go/mux/channel.go
- Line 121: warning: receiver name c should be consistent with previous receiver name ch for Channel (golint)
- Line 154: warning: receiver name c should be consistent with previous receiver name ch for Channel (golint)
- Line 166: warning: receiver name c should be consistent with previous receiver name ch for Channel (golint)
-
-
qtalk-go/mux/dial_io.go
- Line 13: warning: comment on exported function DialStdio should be of the form "DialStdio ..." (golint)
-
-
qtalk-go/mux/listen_net.go
- Line 31: warning: exported function ListenerFrom should have comment or be unexported (golint)
- Line 44: warning: comment on exported function ListenUnix should be of the form "ListenUnix ..." (golint)
-
-
qtalk-go/mux/frame/decoder.go
- Line 19: warning: exported function NewDecoder should have comment or be unexported (golint)
- Line 23: warning: exported method Decoder.Decode should have comment or be unexported (golint)
-
-
qtalk-go/mux/frame/message_windowadjust.go
- Line 9: warning: exported type WindowAdjustMessage should have comment or be unexported (golint)
- Line 19: warning: exported method WindowAdjustMessage.Channel should have comment or be unexported (golint)
- Line 23: warning: exported method WindowAdjustMessage.Bytes should have comment or be unexported (golint)
ineffassign97%
IneffAssign detects ineffectual assignments in Go code.
-
-
qtalk-go/mux/session_test.go
- Line 38: warning: ineffectual assignment to err (ineffassign)
misspell97%
Misspell Finds commonly misspelled English words
-
-
qtalk-go/mux/listen_io.go
- Line 38: warning: "seperate" is a misspelling of "separate" (misspell)