gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• system/pkg/controllers/streaming/gateway_reconciler_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo98%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• system/pkg/apis/streaming/v1alpha1/processor_validation.go
  • Line 61: warning: cyclomatic complexity 19 of function (*ProcessorSpec).Validate() is high (> 15) (gocyclo)

• system/cmd/managers/streaming/main.go
  • Line 55: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• system/pkg/controllers/streaming/processor_reconciler.go
  • Line 245: warning: cyclomatic complexity 22 of function ProcessorChildDeploymentReconciler() is high (> 15) (gocyclo)

golint48%

Golint is a linter for Go source code.

• system/pkg/apis/thirdparty/kpack/build/v1alpha1/image_types.go
  • Line 57: warning: exported type ImageBuilder should have comment or be unexported (golint)
  • Line 62: warning: exported type ImageTaggingStrategy should have comment or be unexported (golint)
  • Line 65: warning: exported const None should have comment (or a comment on this block) or be unexported (golint)
  • Line 69: warning: exported type ImageBuild should have comment or be unexported (golint)
  • Line 76: warning: exported type Image should have comment or be unexported (golint)

• system/pkg/authn/secrets_keychain.go
  • Line 11: warning: exported type DockerSecretsKeychain should have comment or be unexported (golint)
  • Line 15: warning: exported const DockerSecretAnnotation should have comment or be unexported (golint)
  • Line 17: warning: exported function NewSecretsKeychain should have comment or be unexported (golint)
  • Line 36: warning: exported method DockerSecretsKeychain.Resolve should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/doc.go
  • Line 17: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• system/pkg/apis/streaming/v1alpha1/processor_types.go
  • Line 33: warning: exported var ProcessorLabelKey should have comment or be unexported (golint)
  • Line 62: warning: exported type Build should have comment or be unexported (golint)
  • Line 70: warning: exported type OutputStreamBinding should have comment or be unexported (golint)
  • Line 80: warning: exported const Earliest should have comment (or a comment on this block) or be unexported (golint)
  • Line 84: warning: exported type InputStreamBinding should have comment or be unexported (golint)
  • Line 125: warning: exported method Processor.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 129: warning: exported method Processor.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/bindings/v1alpha1/shared_types.go
  • Line 23: warning: exported type Reference should have comment or be unexported (golint)

• system/pkg/apis/duck/v1/addressable_types.go
  • Line 32: warning: exported method Addressable.Parse should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/function_lifecycle.go
  • Line 27: warning: exported const FunctionConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported method FunctionStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 41: warning: exported method FunctionStatus.IsReady should have comment or be unexported (golint)
  • Line 45: warning: exported method FunctionStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 49: warning: exported method FunctionStatus.GetCondition should have comment or be unexported (golint)
  • Line 53: warning: exported method FunctionStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 57: warning: exported method FunctionStatus.MarkBuildNotUsed should have comment or be unexported (golint)
  • Line 63: warning: exported method FunctionStatus.MarkImageDefaultPrefixMissing should have comment or be unexported (golint)
  • Line 67: warning: exported method FunctionStatus.MarkImageInvalid should have comment or be unexported (golint)
  • Line 71: warning: exported method FunctionStatus.MarkImageResolved should have comment or be unexported (golint)
  • Line 75: warning: exported method FunctionStatus.PropagateKpackImageStatus should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/groupversion_info.go
  • Line 37: warning: comment on exported var SchemeGroupVersion should be of the form "SchemeGroupVersion ..." (golint)

• system/pkg/apis/streaming/v1alpha1/inmemorygateway_lifecycle.go
  • Line 25: warning: exported const InMemoryGatewayConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 33: warning: exported method InMemoryGatewayStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 37: warning: exported method InMemoryGatewayStatus.IsReady should have comment or be unexported (golint)
  • Line 41: warning: exported method InMemoryGatewayStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 45: warning: exported method InMemoryGatewayStatus.GetCondition should have comment or be unexported (golint)
  • Line 49: warning: exported method InMemoryGatewayStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 53: warning: exported method InMemoryGatewayStatus.PropagateGatewayStatus should have comment or be unexported (golint)
  • Line 68: warning: exported method InMemoryGatewayStatus.MarkGatewayNotOwned should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/stream_lifecycle.go
  • Line 24: warning: exported const StreamConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported method StreamStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 38: warning: exported method StreamStatus.IsReady should have comment or be unexported (golint)
  • Line 42: warning: exported method StreamStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 46: warning: exported method StreamStatus.GetCondition should have comment or be unexported (golint)
  • Line 50: warning: exported method StreamStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 54: warning: exported method StreamStatus.MarkStreamProvisioned should have comment or be unexported (golint)
  • Line 58: warning: exported method StreamStatus.MarkStreamProvisionFailed should have comment or be unexported (golint)
  • Line 62: warning: exported method StreamStatus.MarkBindingReady should have comment or be unexported (golint)
  • Line 66: warning: exported method StreamStatus.MarkBindingNotReady should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/knative_configuration.go
  • Line 38: warning: exported function KnativeConfiguration should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/kpack/build/v1alpha1/groupversion_info.go
  • Line 23: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• system/pkg/apis/knative/v1alpha1/deployer_defaults.go
  • Line 33: warning: exported method DeployerSpec.Default should have comment or be unexported (golint)

• system/pkg/controllers/build/application_reconciler.go
  • Line 38: warning: exported function ApplicationReconciler should have comment or be unexported (golint)
  • Line 52: warning: exported function ApplicationTargetImageReconciler should have comment or be unexported (golint)
  • Line 75: warning: exported function ApplicationChildImageReconciler should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/knative_route.go
  • Line 38: warning: exported function KnativeRoute should have comment or be unexported (golint)

• system/pkg/controllers/streaming/pulsargateway_reconciler.go
  • Line 44: warning: exported function PulsarGatewayReconciler should have comment or be unexported (golint)
  • Line 58: warning: exported function PulsarGatewaySyncConfigReconciler should have comment or be unexported (golint)
  • Line 86: warning: exported function PulsarGatewayChildGatewayReconciler should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/knative/serving/v1/configuration_types.go
  • Line 74: warning: exported method ConfigurationStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 78: warning: exported method ConfigurationStatus.IsReady should have comment or be unexported (golint)
  • Line 82: warning: exported method ConfigurationStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 86: warning: exported method ConfigurationStatus.GetCondition should have comment or be unexported (golint)
  • Line 105: warning: exported method Configuration.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 109: warning: exported method Configuration.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/core/v1alpha1/deployer_types.go
  • Line 34: warning: exported var DeployerLabelKey should have comment or be unexported (golint)
  • Line 61: warning: exported type Build should have comment or be unexported (golint)
  • Line 79: warning: exported const IngressPolicyClusterLocal should have comment (or a comment on this block) or be unexported (golint)
  • Line 122: warning: exported method Deployer.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 126: warning: exported method Deployer.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/application_types.go
  • Line 32: warning: exported var ApplicationLabelKey should have comment or be unexported (golint)
  • Line 95: warning: exported method Application.GetImage should have comment or be unexported (golint)
  • Line 99: warning: exported method Application.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 103: warning: exported method Application.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/gateway_lifecycle.go
  • Line 26: warning: exported const GatewayConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported method GatewayStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 40: warning: exported method GatewayStatus.IsReady should have comment or be unexported (golint)
  • Line 44: warning: exported method GatewayStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 48: warning: exported method GatewayStatus.GetCondition should have comment or be unexported (golint)
  • Line 52: warning: exported method GatewayStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 56: warning: exported method GatewayStatus.PropagateDeploymentStatus should have comment or be unexported (golint)
  • Line 84: warning: exported method GatewayStatus.PropagateServiceStatus should have comment or be unexported (golint)

• system/pkg/apis/core/v1alpha1/deployer_defaults.go
  • Line 33: warning: exported method DeployerSpec.Default should have comment or be unexported (golint)

• system/pkg/apis/core/v1alpha1/deployer_lifecycle.go
  • Line 27: warning: exported const DeployerConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 39: warning: exported method DeployerStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 43: warning: exported method DeployerStatus.IsReady should have comment or be unexported (golint)
  • Line 47: warning: exported method DeployerStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 51: warning: exported method DeployerStatus.GetCondition should have comment or be unexported (golint)
  • Line 55: warning: exported method DeployerStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 59: warning: exported method DeployerStatus.PropagateDeploymentStatus should have comment or be unexported (golint)
  • Line 87: warning: exported method DeployerStatus.PropagateServiceStatus should have comment or be unexported (golint)
  • Line 92: warning: exported method DeployerStatus.MarkServiceNotOwned should have comment or be unexported (golint)
  • Line 103: warning: exported method DeployerStatus.MarkIngressNotRequired should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/gateway_validation.go
  • Line 49: warning: exported method Gateway.Validate should have comment or be unexported (golint)
  • Line 57: warning: exported method GatewaySpec.Validate should have comment or be unexported (golint)

• system/pkg/controllers/streaming/kafkagateway_reconciler.go
  • Line 44: warning: exported function KafkaGatewayReconciler should have comment or be unexported (golint)
  • Line 58: warning: exported function KafkaGatewaySyncConfigReconciler should have comment or be unexported (golint)
  • Line 86: warning: exported function KafkaGatewayChildGatewayReconciler should have comment or be unexported (golint)

• system/pkg/apis/knative/v1alpha1/adapter_types.go
  • Line 31: warning: exported var AdapterLabelKey should have comment or be unexported (golint)
  • Line 52: warning: exported type AdapterTarget should have comment or be unexported (golint)
  • Line 89: warning: exported method Adapter.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 93: warning: exported method Adapter.GetStatus should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/container.go
  • Line 37: warning: exported function Container should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/knative/serving/v1/revision_types.go
  • Line 88: warning: exported method RevisionStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 92: warning: exported method RevisionStatus.IsReady should have comment or be unexported (golint)
  • Line 96: warning: exported method RevisionStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 100: warning: exported method RevisionStatus.GetCondition should have comment or be unexported (golint)
  • Line 129: warning: exported method Revision.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 133: warning: exported method Revision.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/application_lifecycle.go
  • Line 27: warning: exported const ApplicationConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported method ApplicationStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 41: warning: exported method ApplicationStatus.IsReady should have comment or be unexported (golint)
  • Line 45: warning: exported method ApplicationStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 49: warning: exported method ApplicationStatus.GetCondition should have comment or be unexported (golint)
  • Line 53: warning: exported method ApplicationStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 57: warning: exported method ApplicationStatus.MarkBuildNotUsed should have comment or be unexported (golint)
  • Line 63: warning: exported method ApplicationStatus.MarkImageDefaultPrefixMissing should have comment or be unexported (golint)
  • Line 67: warning: exported method ApplicationStatus.MarkImageInvalid should have comment or be unexported (golint)
  • Line 71: warning: exported method ApplicationStatus.MarkImageResolved should have comment or be unexported (golint)
  • Line 75: warning: exported method ApplicationStatus.PropagateKpackImageStatus should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/processor_validation.go
  • Line 53: warning: exported method Processor.Validate should have comment or be unexported (golint)
  • Line 61: warning: exported method ProcessorSpec.Validate should have comment or be unexported (golint)
  • Line 158: warning: exported method Build.Validate should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/deployer_knative.go
  • Line 40: warning: exported function DeployerKnative should have comment or be unexported (golint)

• system/pkg/controllers/streaming/gateway_reconciler.go
  • Line 40: warning: exported function GatewayReconciler should have comment or be unexported (golint)
  • Line 54: warning: exported function GatewayChildServiceReconciler should have comment or be unexported (golint)
  • Line 115: warning: exported function GatewayChildDeploymentReconciler should have comment or be unexported (golint)

• system/pkg/apis/bindings/v1alpha1/doc.go
  • Line 20: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• system/pkg/apis/bindings/v1alpha1/image_binding_types.go
  • Line 27: warning: exported type ImageBinding should have comment or be unexported (golint)
  • Line 35: warning: exported type ImageBindingSpec should have comment or be unexported (golint)
  • Line 41: warning: exported type ImageBindingStatus should have comment or be unexported (golint)
  • Line 47: warning: exported type ImageBindingList should have comment or be unexported (golint)

• system/pkg/apis/knative/v1alpha1/shared_types.go
  • Line 19: warning: exported type Build should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/deployer_core.go
  • Line 40: warning: exported function DeployerCore should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/kpack_image.go
  • Line 40: warning: exported function KpackImage should have comment or be unexported (golint)

• system/pkg/apis/bindings/v1alpha1/groupversion_info.go
  • Line 17: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
  • Line 37: warning: comment on exported var SchemeGroupVersion should be of the form "SchemeGroupVersion ..." (golint)

• system/pkg/apis/streaming/v1alpha1/pulsargateway_lifecycle.go
  • Line 25: warning: exported const PulsarGatewayConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 33: warning: exported method PulsarGatewayStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 37: warning: exported method PulsarGatewayStatus.IsReady should have comment or be unexported (golint)
  • Line 41: warning: exported method PulsarGatewayStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 45: warning: exported method PulsarGatewayStatus.GetCondition should have comment or be unexported (golint)
  • Line 49: warning: exported method PulsarGatewayStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 53: warning: exported method PulsarGatewayStatus.PropagateGatewayStatus should have comment or be unexported (golint)
  • Line 68: warning: exported method PulsarGatewayStatus.MarkGatewayNotOwned should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/stream.go
  • Line 38: warning: exported function Stream should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/container_validation.go
  • Line 49: warning: exported method Container.Validate should have comment or be unexported (golint)
  • Line 57: warning: exported method ContainerSpec.Validate should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/pulsargateway_defaults.go
  • Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
  • Line 29: warning: exported method PulsarGatewaySpec.Default should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/pulsargateway_types.go
  • Line 33: warning: exported var PulsarGatewayLabelKey should have comment or be unexported (golint)
  • Line 80: warning: exported method PulsarGateway.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 84: warning: exported method PulsarGateway.GetStatus should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/knative_service.go
  • Line 38: warning: exported function KnativeService should have comment or be unexported (golint)

• system/pkg/controllers/knative/adapter_reconciler.go
  • Line 42: warning: exported function AdapterReconciler should have comment or be unexported (golint)
  • Line 56: warning: exported function AdapterBuildRefReconciler should have comment or be unexported (golint)
  • Line 141: warning: exported function AdapterTargetRefReconciler should have comment or be unexported (golint)

• system/pkg/apis/knative/v1alpha1/deployer_lifecycle.go
  • Line 27: warning: exported const DeployerConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported method DeployerStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 41: warning: exported method DeployerStatus.IsReady should have comment or be unexported (golint)
  • Line 45: warning: exported method DeployerStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 49: warning: exported method DeployerStatus.GetCondition should have comment or be unexported (golint)
  • Line 53: warning: exported method DeployerStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 57: warning: exported method DeployerStatus.PropagateConfigurationStatus should have comment or be unexported (golint)
  • Line 72: warning: exported method DeployerStatus.PropagateRouteStatus should have comment or be unexported (golint)
  • Line 90: warning: exported method DeployerStatus.MarkRouteNotOwned should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/application.go
  • Line 39: warning: exported function Application should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/knative/serving/v1/service_types.go
  • Line 77: warning: exported method ServiceStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 81: warning: exported method ServiceStatus.IsReady should have comment or be unexported (golint)
  • Line 85: warning: exported method ServiceStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 89: warning: exported method ServiceStatus.GetCondition should have comment or be unexported (golint)
  • Line 115: warning: exported method Service.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 119: warning: exported method Service.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/kpack/build/v1alpha1/source_types.go
  • Line 23: warning: exported type SourceConfig should have comment or be unexported (golint)
  • Line 30: warning: exported type Git should have comment or be unexported (golint)
  • Line 35: warning: exported type Blob should have comment or be unexported (golint)
  • Line 39: warning: exported type Registry should have comment or be unexported (golint)
  • Line 44: warning: exported type ResolvedSourceConfig should have comment or be unexported (golint)
  • Line 50: warning: exported type GitSourceKind should have comment or be unexported (golint)
  • Line 53: warning: exported const Unknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 59: warning: exported type ResolvedGitSource should have comment or be unexported (golint)
  • Line 66: warning: exported type ResolvedBlobSource should have comment or be unexported (golint)
  • Line 71: warning: exported type ResolvedRegistrySource should have comment or be unexported (golint)

• system/pkg/refs/typed.go
  • Line 27: warning: exported function NewTypedLocalObjectReference should have comment or be unexported (golint)
  • Line 42: warning: exported function NewTypedLocalObjectReferenceForObject should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/container_defaults.go
  • Line 30: warning: exported method ContainerSpec.Default should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/kafkagateway_lifecycle.go
  • Line 25: warning: exported const KafkaGatewayConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 33: warning: exported method KafkaGatewayStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 37: warning: exported method KafkaGatewayStatus.IsReady should have comment or be unexported (golint)
  • Line 41: warning: exported method KafkaGatewayStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 45: warning: exported method KafkaGatewayStatus.GetCondition should have comment or be unexported (golint)
  • Line 49: warning: exported method KafkaGatewayStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 53: warning: exported method KafkaGatewayStatus.PropagateGatewayStatus should have comment or be unexported (golint)
  • Line 68: warning: exported method KafkaGatewayStatus.MarkGatewayNotOwned should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/kpack/build/v1alpha1/cluster_builder_types.go
  • Line 28: warning: exported type ClusterBuilder should have comment or be unexported (golint)

• system/pkg/apis/knative/v1alpha1/adapter_validation.go
  • Line 49: warning: exported method Adapter.Validate should have comment or be unexported (golint)
  • Line 57: warning: exported method AdapterSpec.Validate should have comment or be unexported (golint)
  • Line 70: warning: exported method AdapterTarget.Validate should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/doc.go
  • Line 17: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• system/pkg/controllers/testing/factories/processor.go
  • Line 39: warning: exported function Processor should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/keda/v1alpha1/triggerauthentication_types.go
  • Line 52: warning: exported const PodIdentityProviderNone should have comment (or a comment on this block) or be unexported (golint)

• system/pkg/apis/knative/v1alpha1/deployer_validation.go
  • Line 38: warning: exported const MaxContainerConcurrency should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: exported method Deployer.Validate should have comment or be unexported (golint)
  • Line 57: warning: receiver name c should be consistent with previous receiver name r for Deployer (golint)
  • Line 65: warning: exported method DeployerSpec.Validate should have comment or be unexported (golint)
  • Line 115: warning: exported method Scale.Validate should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/pulsargateway.go
  • Line 39: warning: exported function PulsarGateway should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/knative/serving/v1/route_types.go
  • Line 62: warning: exported method RouteStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 66: warning: exported method RouteStatus.IsReady should have comment or be unexported (golint)
  • Line 70: warning: exported method RouteStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 74: warning: exported method RouteStatus.GetCondition should have comment or be unexported (golint)
  • Line 161: warning: exported method Route.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 165: warning: exported method Route.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/kpack/build/v1alpha1/build_types.go
  • Line 55: warning: exported type BuilderImage should have comment or be unexported (golint)
  • Line 62: warning: exported type Build should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/inmemorygateway_types.go
  • Line 33: warning: exported var InMemoryGatewayLabelKey should have comment or be unexported (golint)
  • Line 76: warning: exported method InMemoryGateway.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 80: warning: exported method InMemoryGateway.GetStatus should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/kafkagateway.go
  • Line 39: warning: exported function KafkaGateway should have comment or be unexported (golint)

• system/pkg/apis/core/v1alpha1/groupversion_info.go
  • Line 37: warning: comment on exported var SchemeGroupVersion should be of the form "SchemeGroupVersion ..." (golint)

• system/pkg/apis/build/v1alpha1/function_validation.go
  • Line 49: warning: exported method Function.Validate should have comment or be unexported (golint)
  • Line 57: warning: exported method FunctionSpec.Validate should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/inmemorygateway_defaults.go
  • Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
  • Line 29: warning: exported method InMemoryGatewaySpec.Default should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/kpack_clusterbuilder.go
  • Line 37: warning: exported function KpackClusterBuilder should have comment or be unexported (golint)

• system/pkg/controllers/streaming/stream_provisioner_client.go
  • Line 31: warning: exported type StreamProvisionerClient should have comment or be unexported (golint)
  • Line 35: warning: exported type StreamAddress should have comment or be unexported (golint)
  • Line 45: warning: exported function NewStreamProvisionerClient should have comment or be unexported (golint)

• system/pkg/controllers/streaming/stream_reconciler.go
  • Line 42: warning: exported function StreamReconciler should have comment or be unexported (golint)
  • Line 58: warning: exported function StreamProvisionReconciler should have comment or be unexported (golint)
  • Line 105: warning: exported function StreamChildBindingMetadataReconciler should have comment or be unexported (golint)
  • Line 173: warning: exported function StreamChildBindingSecretReconciler should have comment or be unexported (golint)
  • Line 236: warning: exported function StreamSyncBindingCondition should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/kpack/build/v1alpha1/builder_types.go
  • Line 46: warning: exported type BuilderUpdatePolicy should have comment or be unexported (golint)
  • Line 49: warning: exported const Polling should have comment (or a comment on this block) or be unexported (golint)
  • Line 55: warning: exported type Builder should have comment or be unexported (golint)

• system/pkg/controllers/build/credential_controller.go
  • Line 56: warning: exported method CredentialReconciler.Reconcile should have comment or be unexported (golint)
  • Line 198: warning: exported method MatchingLabels.ApplyToList should have comment or be unexported (golint)
  • Line 203: warning: exported method CredentialReconciler.SetupWithManager should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/groupversion_info.go
  • Line 37: warning: comment on exported var SchemeGroupVersion should be of the form "SchemeGroupVersion ..." (golint)

• system/pkg/controllers/testing/factories/aliases.go
  • Line 23: warning: exported type ConditionFactory should have comment or be unexported (golint)
  • Line 24: warning: exported type ObjectMeta should have comment or be unexported (golint)
  • Line 25: warning: exported type PodTemplateSpec should have comment or be unexported (golint)
  • Line 28: warning: exported var Condition should have comment or be unexported (golint)
  • Line 34: warning: exported var ConfigMap should have comment or be unexported (golint)

• system/pkg/apis/bindings/v1alpha1/service_binding_types.go
  • Line 28: warning: exported type ServiceBinding should have comment or be unexported (golint)
  • Line 36: warning: exported type ServiceBindingSpec should have comment or be unexported (golint)
  • Line 41: warning: exported type ServiceCredentialProvider should have comment or be unexported (golint)
  • Line 48: warning: exported type ServiceCredentialReference should have comment or be unexported (golint)
  • Line 53: warning: exported type ServiceBindingMode should have comment or be unexported (golint)
  • Line 56: warning: exported const MetadataServiceBinding should have comment (or a comment on this block) or be unexported (golint)
  • Line 60: warning: exported type ServiceBindingStatus should have comment or be unexported (golint)
  • Line 66: warning: exported type ServiceBindingList should have comment or be unexported (golint)

• system/pkg/controllers/core/deployer_reconciler.go
  • Line 50: warning: exported function DeployerReconciler should have comment or be unexported (golint)
  • Line 66: warning: exported function DeployerBuildRefReconciler should have comment or be unexported (golint)
  • Line 150: warning: exported function DeployerChildDeploymentReconciler should have comment or be unexported (golint)
  • Line 238: warning: exported function DeployerChildServiceReconciler should have comment or be unexported (golint)
  • Line 311: warning: exported function DeployerChildIngressReconciler should have comment or be unexported (golint)

• system/pkg/apis/knative/v1alpha1/doc.go
  • Line 17: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• system/pkg/apis/build/v1alpha1/aliases.go
  • Line 23: warning: comment on exported type Source should be of the form "Source ..." (with optional leading article) (golint)
  • Line 26: warning: comment on exported type Git should be of the form "Git ..." (with optional leading article) (golint)
  • Line 29: warning: comment on exported type Blob should be of the form "Blob ..." (with optional leading article) (golint)
  • Line 32: warning: comment on exported type Registry should be of the form "Registry ..." (with optional leading article) (golint)
  • Line 35: warning: exported type ImageTaggingStrategy should have comment or be unexported (golint)
  • Line 37: warning: exported const None should have comment or be unexported (golint)
  • Line 38: warning: exported const BuildNumber should have comment or be unexported (golint)
  • Line 40: warning: comment on exported type ImageBuild should be of the form "ImageBuild ..." (with optional leading article) (golint)

• system/pkg/controllers/testing/factories/function.go
  • Line 39: warning: exported function Function should have comment or be unexported (golint)

• system/pkg/controllers/streaming/processor_reconciler.go
  • Line 49: warning: exported const ProcessorImagesStashKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 64: warning: exported function ProcessorReconciler should have comment or be unexported (golint)
  • Line 81: warning: exported function ProcessorSyncProcessorImages should have comment or be unexported (golint)
  • Line 108: warning: exported function ProcessorBuildRefReconciler should have comment or be unexported (golint)
  • Line 173: warning: exported function ProcessorResolveStreamsReconciler should have comment or be unexported (golint)
  • Line 245: warning: exported function ProcessorChildDeploymentReconciler should have comment or be unexported (golint)
  • Line 482: warning: exported function ProcessorChildScaledObjectReconciler should have comment or be unexported (golint)

• system/pkg/apis/interfaces.go
  • Line 25: warning: exported type Resource should have comment or be unexported (golint)
  • Line 31: warning: exported type ResourceStatus should have comment or be unexported (golint)

• system/pkg/apis/knative/v1alpha1/adapter_defaults.go
  • Line 30: warning: exported method AdapterSpec.Default should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/keda_scaledobject.go
  • Line 36: warning: exported function KedaScaledObject should have comment or be unexported (golint)

• system/pkg/apis/knative/v1alpha1/deployer_types.go
  • Line 34: warning: exported var DeployerLabelKey should have comment or be unexported (golint)
  • Line 73: warning: exported const IngressPolicyClusterLocal should have comment (or a comment on this block) or be unexported (golint)
  • Line 77: warning: exported type Scale should have comment or be unexported (golint)
  • Line 125: warning: exported method Deployer.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 129: warning: exported method Deployer.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/function_types.go
  • Line 32: warning: exported var FunctionLabelKey should have comment or be unexported (golint)
  • Line 107: warning: exported method Function.GetImage should have comment or be unexported (golint)
  • Line 111: warning: exported method Function.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 115: warning: exported method Function.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/inmemorygateway_validation.go
  • Line 48: warning: exported method InMemoryGateway.Validate should have comment or be unexported (golint)
  • Line 56: warning: exported method InMemoryGatewaySpec.Validate should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/gateway.go
  • Line 40: warning: exported function Gateway should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/keda/v1alpha1/groupversion_info.go
  • Line 17: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• system/pkg/apis/knative/v1alpha1/groupversion_info.go
  • Line 37: warning: comment on exported var SchemeGroupVersion should be of the form "SchemeGroupVersion ..." (golint)

• system/pkg/controllers/testing/factories/inmemorygateway.go
  • Line 39: warning: exported function InMemoryGateway should have comment or be unexported (golint)

• system/pkg/apis/core/v1alpha1/deployer_validation.go
  • Line 53: warning: exported method Deployer.Validate should have comment or be unexported (golint)
  • Line 61: warning: exported method DeployerSpec.Validate should have comment or be unexported (golint)
  • Line 99: warning: exported method Build.Validate should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/function_defaults.go
  • Line 30: warning: exported method FunctionSpec.Default should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/shared_types.go
  • Line 29: warning: comment on exported var CredentialLabelKey should be of the form "CredentialLabelKey ..." (golint)
  • Line 31: warning: exported var CredentialsAnnotationKey should have comment or be unexported (golint)
  • Line 34: warning: exported type BuildStatus should have comment or be unexported (golint)
  • Line 50: warning: comment on exported type ImageResource should be of the form "ImageResource ..." (with optional leading article) (golint)

• system/pkg/apis/streaming/v1alpha1/kafkagateway_defaults.go
  • Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
  • Line 29: warning: exported method KafkaGatewaySpec.Default should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/container_lifecycle.go
  • Line 24: warning: exported const ContainerConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported method ContainerStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 36: warning: exported method ContainerStatus.IsReady should have comment or be unexported (golint)
  • Line 40: warning: exported method ContainerStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 44: warning: exported method ContainerStatus.GetCondition should have comment or be unexported (golint)
  • Line 48: warning: exported method ContainerStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 52: warning: exported method ContainerStatus.MarkImageDefaultPrefixMissing should have comment or be unexported (golint)
  • Line 56: warning: exported method ContainerStatus.MarkImageInvalid should have comment or be unexported (golint)
  • Line 60: warning: exported method ContainerStatus.MarkImageResolved should have comment or be unexported (golint)

• system/pkg/controllers/build/clusterbuilder_reconciler.go
  • Line 56: warning: exported method ClusterBuilderReconciler.Reconcile should have comment or be unexported (golint)
  • Line 146: warning: exported method ClusterBuilderReconciler.SetupWithManager should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/kpack/build/v1alpha1/shared_validation.go
  • Line 24: warning: exported method SourceConfig.Validate should have comment or be unexported (golint)
  • Line 63: warning: exported method Git.Validate should have comment or be unexported (golint)
  • Line 81: warning: exported method Blob.Validate should have comment or be unexported (golint)
  • Line 96: warning: exported method Registry.Validate should have comment or be unexported (golint)

• system/pkg/apis/knative/v1alpha1/adapter_lifecycle.go
  • Line 24: warning: exported const AdapterConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported method AdapterStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 38: warning: exported method AdapterStatus.IsReady should have comment or be unexported (golint)
  • Line 42: warning: exported method AdapterStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 46: warning: exported method AdapterStatus.GetCondition should have comment or be unexported (golint)
  • Line 50: warning: exported method AdapterStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 54: warning: exported method AdapterStatus.MarkBuildNotFound should have comment or be unexported (golint)
  • Line 59: warning: exported method AdapterStatus.MarkBuildLatestImageMissing should have comment or be unexported (golint)
  • Line 64: warning: exported method AdapterStatus.MarkBuildReady should have comment or be unexported (golint)
  • Line 68: warning: exported method AdapterStatus.MarkTargetNotFound should have comment or be unexported (golint)
  • Line 73: warning: exported method AdapterStatus.MarkTargetInvalid should have comment or be unexported (golint)
  • Line 78: warning: exported method AdapterStatus.MarkTargetFound should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/application_defaults.go
  • Line 30: warning: exported method ApplicationSpec.Default should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/processor_defaults.go
  • Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
  • Line 32: warning: exported method ProcessorSpec.Default should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/stream_defaults.go
  • Line 32: warning: exported method StreamSpec.Default should have comment or be unexported (golint)

• system/pkg/apis/core/v1alpha1/doc.go
  • Line 17: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• system/pkg/apis/build/v1alpha1/container_types.go
  • Line 31: warning: exported var ContainerLabelKey should have comment or be unexported (golint)
  • Line 76: warning: exported method Container.GetImage should have comment or be unexported (golint)
  • Line 80: warning: exported method Container.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 84: warning: exported method Container.GetStatus should have comment or be unexported (golint)

• system/pkg/controllers/build/function_reconciler.go
  • Line 39: warning: exported function FunctionReconciler should have comment or be unexported (golint)
  • Line 53: warning: exported function FunctionTargetImageReconciler should have comment or be unexported (golint)
  • Line 76: warning: exported function FunctionChildImageReconciler should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/processor_lifecycle.go
  • Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
  • Line 27: warning: exported const ProcessorConditionReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 39: warning: exported method ProcessorStatus.GetObservedGeneration should have comment or be unexported (golint)
  • Line 43: warning: exported method ProcessorStatus.IsReady should have comment or be unexported (golint)
  • Line 47: warning: exported method ProcessorStatus.GetReadyConditionType should have comment or be unexported (golint)
  • Line 51: warning: exported method ProcessorStatus.GetCondition should have comment or be unexported (golint)
  • Line 55: warning: exported method ProcessorStatus.InitializeConditions should have comment or be unexported (golint)
  • Line 59: warning: exported method ProcessorStatus.MarkStreamsReady should have comment or be unexported (golint)
  • Line 63: warning: exported method ProcessorStatus.MarkStreamsNotReady should have comment or be unexported (golint)
  • Line 67: warning: exported method ProcessorStatus.PropagateDeploymentStatus should have comment or be unexported (golint)
  • Line 95: warning: exported method ProcessorStatus.PropagateScaledObjectStatus should have comment or be unexported (golint)

• system/pkg/controllers/testing/factories/adapter_knative.go
  • Line 37: warning: exported function AdapterKnative should have comment or be unexported (golint)

• system/pkg/controllers/streaming/inmemorygateway_reconciler.go
  • Line 44: warning: exported function InMemoryGatewayReconciler should have comment or be unexported (golint)
  • Line 58: warning: exported function InMemoryGatewaySyncConfigReconciler should have comment or be unexported (golint)
  • Line 86: warning: exported function InMemoryGatewayChildGatewayReconciler should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/keda/v1alpha1/scaled_object_types.go
  • Line 65: warning: exported type ScaleTriggers should have comment or be unexported (golint)

• system/pkg/apis/build/v1alpha1/application_validation.go
  • Line 49: warning: exported method Application.Validate should have comment or be unexported (golint)
  • Line 57: warning: exported method ApplicationSpec.Validate should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/kafkagateway_validation.go
  • Line 49: warning: exported method KafkaGateway.Validate should have comment or be unexported (golint)
  • Line 57: warning: exported method KafkaGatewaySpec.Validate should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/pulsargateway_validation.go
  • Line 52: warning: exported method PulsarGateway.Validate should have comment or be unexported (golint)
  • Line 60: warning: exported method PulsarGatewaySpec.Validate should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/stream_types.go
  • Line 32: warning: exported var StreamLabelKey should have comment or be unexported (golint)
  • Line 58: warning: exported type BindingReference should have comment or be unexported (golint)
  • Line 85: warning: exported method Stream.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 89: warning: exported method Stream.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/knative/serving/v1/groupversion_info.go
  • Line 23: warning: package comment should be of the form "Package v1 ..." (golint)

• system/pkg/apis/thirdparty/kpack/build/v1alpha1/buildpack_metadata.go
  • Line 19: warning: exported type BuildpackMetadataList should have comment or be unexported (golint)
  • Line 21: warning: exported type BuildpackMetadata should have comment or be unexported (golint)

• system/pkg/apis/knative/v1alpha1/shared_validation.go
  • Line 24: warning: exported method Build.Validate should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/stream_validation.go
  • Line 49: warning: exported method Stream.Validate should have comment or be unexported (golint)
  • Line 57: warning: exported method StreamSpec.Validate should have comment or be unexported (golint)

• system/pkg/apis/thirdparty/kpack/build/v1alpha1/source_resolver_types.go
  • Line 47: warning: exported type SourceResolver should have comment or be unexported (golint)

• system/pkg/controllers/knative/deployer_reconciler.go
  • Line 43: warning: exported function DeployerReconciler should have comment or be unexported (golint)
  • Line 58: warning: exported function DeployerBuildRefReconciler should have comment or be unexported (golint)
  • Line 142: warning: exported function DeployerChildConfigurationReconciler should have comment or be unexported (golint)
  • Line 225: warning: exported function DeployerChildRouteReconciler should have comment or be unexported (golint)

• system/pkg/controllers/build/container_reconciler.go
  • Line 62: warning: exported method ContainerReconciler.Reconcile should have comment or be unexported (golint)
  • Line 205: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 218: warning: context.Context should be the first parameter of a function (golint)
  • Line 236: warning: exported method ContainerReconciler.SetupWithManager should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/gateway_types.go
  • Line 34: warning: exported var GatewayLabelKey should have comment or be unexported (golint)
  • Line 81: warning: exported method Gateway.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 85: warning: exported method Gateway.GetStatus should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/gateway_defaults.go
  • Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
  • Line 29: warning: exported method GatewaySpec.Default should have comment or be unexported (golint)

• system/pkg/apis/streaming/v1alpha1/kafkagateway_types.go
  • Line 33: warning: exported var KafkaGatewayLabelKey should have comment or be unexported (golint)
  • Line 84: warning: exported method KafkaGateway.GetGroupVersionKind should have comment or be unexported (golint)
  • Line 88: warning: exported method KafkaGateway.GetStatus should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!