Go Report Card

Preparing report...

Report for github.com/pydio/cells-sync

B    Not bad!    Found 62 issues across 92 files

Tweet
Last refresh:

Refresh now

gofmt56%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • cells-sync/control/syncer.go
    • Line 270: warning: cyclomatic complexity 41 of function (*Syncer).dispatchBus() is high (> 15) (gocyclo)
    • Line 155: warning: cyclomatic complexity 19 of function (*Syncer).dispatchStatus() is high (> 15) (gocyclo)
    • Line 66: warning: cyclomatic complexity 17 of function NewSyncer() is high (> 15) (gocyclo)

golint63%

Golint is a linter for Go source code.

    • cells-sync/config/defaults.go
    • Line 32: warning: exported const UpdateDefaultChannel should have comment (or a comment on this block) or be unexported (golint)
    • Line 54: warning: comment on exported type Task should be of the form "Task ..." (with optional leading article) (golint)
    • Line 187: warning: exported method Global.UpdateTaskPaused should have comment or be unexported (golint)
    • Line 231: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • cells-sync/i18n/i18n.go
    • Line 47: warning: exported function T should have comment or be unexported (golint)
    • Line 50: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 55: warning: exported function JsonLang should have comment or be unexported (golint)
    • cells-sync/control/updater.go
    • Line 164: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 251: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • cells-sync/config/oidc-token.go
    • Line 41: warning: exported type RefreshStatus should have comment or be unexported (golint)
    • Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • cells-sync/app/tray/client.go
    • Line 23: warning: exported const StatusConnected should have comment (or a comment on this block) or be unexported (golint)
    • Line 94: warning: exported method Client.Poll should have comment or be unexported (golint)
    • cells-sync/control/pubsub.go
    • Line 33: warning: exported const TopicGlobal should have comment (or a comment on this block) or be unexported (golint)
    • Line 35: warning: don't use underscores in Go names; const TopicSync_ should be TopicSync (golint)
    • Line 37: warning: don't use underscores in Go names; const TopicStore_ should be TopicStore (golint)
    • Line 41: warning: exported type CommandMessage should have comment or be unexported (golint)
    • Line 44: warning: exported const MessageHalt should have comment (or a comment on this block) or be unexported (golint)
    • cells-sync/app/ux/init.go
    • Line 10: warning: exported var Box should have comment or be unexported (golint)
    • Line 13: warning: comment on exported type GinBox should be of the form "GinBox ..." (with optional leading article) (golint)
    • Line 18: warning: exported method GinBox.Exists should have comment or be unexported (golint)
    • cells-sync/common/common.go
    • Line 37: warning: exported var Version should have comment or be unexported (golint)
    • Line 107: warning: comment on exported type UpdateMessage should be of the form "UpdateMessage ..." (with optional leading article) (golint)
    • Line 147: warning: comment on exported method UpdateCheckRequest.UpdateMessage should be of the form "UpdateMessage ..." (golint)
    • Line 149: warning: exported method UpdateCheckStatus.UpdateMessage should have comment or be unexported (golint)
    • Line 150: warning: exported method UpdateApplyRequest.UpdateMessage should have comment or be unexported (golint)
    • Line 151: warning: exported method UpdateApplyStatus.UpdateMessage should have comment or be unexported (golint)
    • Line 211: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • cells-sync/config/file.go
    • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • cells-sync/config/service.go
    • Line 28: warning: exported type ServiceCmd should have comment or be unexported (golint)
    • Line 30: warning: exported const ServiceCmdStart should have comment or be unexported (golint)
    • Line 31: warning: exported const ServiceCmdStop should have comment or be unexported (golint)
    • Line 32: warning: exported const ServiceCmdRestart should have comment or be unexported (golint)
    • Line 33: warning: exported const ServiceCmdInstall should have comment or be unexported (golint)
    • Line 34: warning: exported const ServiceCmdUninstall should have comment or be unexported (golint)
    • Line 38: warning: exported type ServiceProgram should have comment or be unexported (golint)
    • Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 83: warning: exported function SetMacService should have comment or be unexported (golint)
    • Line 87: warning: comment on exported function RunningAsService should be of the form "RunningAsService ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell98%

Misspell Finds commonly misspelled English words