gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• pkg/base/signal_unix.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/base/signal_windows.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• pkg/rtprtcp/rtp_unpacker_avc_hevc.go
  • Line 42: warning: cyclomatic complexity 22 of function (*RtpUnpackerAvcHevc).TryUnpackOne() is high (> 15) (gocyclo)

• pkg/rtmp/amf0.go
  • Line 250: warning: cyclomatic complexity 18 of function (amf0).ReadObject() is high (> 15) (gocyclo)
  • Line 319: warning: cyclomatic complexity 16 of function (amf0).ReadArray() is high (> 15) (gocyclo)

• app/demo/calcrtmpdelay/calcrtmpdelay.go
  • Line 51: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• pkg/remux/avpacket2rtmp.go
  • Line 118: warning: cyclomatic complexity 28 of function (*AvPacket2RtmpRemuxer).FeedAvPacket() is high (> 15) (gocyclo)

• app/demo/analyseflv/analyseflv.go
  • Line 75: warning: cyclomatic complexity 21 of function main() is high (> 15) (gocyclo)
  • Line 187: warning: cyclomatic complexity 16 of function analysisVideoTag() is high (> 15) (gocyclo)

• pkg/rtmp/chunk_composer.go
  • Line 55: warning: cyclomatic complexity 36 of function (*ChunkComposer).RunLoop() is high (> 15) (gocyclo)

• pkg/logic/config.go
  • Line 161: warning: cyclomatic complexity 35 of function LoadConfAndInitLog() is high (> 15) (gocyclo)

• pkg/hls/streamer.go
  • Line 97: warning: cyclomatic complexity 35 of function (*Streamer).feedVideo() is high (> 15) (gocyclo)

• pkg/rtmp/chunk_divider.go
  • Line 37: warning: cyclomatic complexity 16 of function calcHeader() is high (> 15) (gocyclo)

• pkg/rtsp/client_command_session.go
  • Line 246: warning: cyclomatic complexity 16 of function (*ClientCommandSession).runReadLoop() is high (> 15) (gocyclo)

• pkg/avc/beta.go
  • Line 149: warning: cyclomatic complexity 46 of function parseSpsGamma() is high (> 15) (gocyclo)

• pkg/hevc/hevc.go
  • Line 359: warning: cyclomatic complexity 34 of function ParseSps() is high (> 15) (gocyclo)
  • Line 168: warning: cyclomatic complexity 21 of function ParseVpsSpsPpsFromSeqHeaderWithoutMalloc() is high (> 15) (gocyclo)
  • Line 493: warning: cyclomatic complexity 21 of function parsePtl() is high (> 15) (gocyclo)

• pkg/logic/server_manager.go
  • Line 126: warning: cyclomatic complexity 30 of function (*ServerManager).RunLoop() is high (> 15) (gocyclo)
  • Line 59: warning: cyclomatic complexity 17 of function NewServerManager() is high (> 15) (gocyclo)

• app/demo/pullrtmp2pushrtmp/tunnel.go
  • Line 81: warning: cyclomatic complexity 24 of function (*Tunnel).Start() is high (> 15) (gocyclo)

• pkg/logic/group.go
  • Line 999: warning: cyclomatic complexity 57 of function (*Group).broadcastByRtmpMsg() is high (> 15) (gocyclo)
  • Line 163: warning: cyclomatic complexity 24 of function (*Group).Tick() is high (> 15) (gocyclo)

golint31%

Golint is a linter for Go source code.

• pkg/mpegts/pack.go
  • Line 11: warning: exported type Frame should have comment or be unexported (golint)
  • Line 35: warning: comment on exported type OnTsPacket should be of the form "OnTsPacket ..." (with optional leading article) (golint)
  • Line 39: warning: comment on exported function PackTsPacket should be of the form "PackTsPacket ..." (golint)

• pkg/rtsp/base_in_session.go
  • Line 32: warning: comment on exported type BaseInSessionObserver should be of the form "BaseInSessionObserver ..." (with optional leading article) (golint)
  • Line 52: warning: exported type BaseInSession should have comment or be unexported (golint)
  • Line 95: warning: exported function NewBaseInSession should have comment or be unexported (golint)
  • Line 111: warning: exported function NewBaseInSessionWithObserver should have comment or be unexported (golint)
  • Line 117: warning: exported method BaseInSession.InitWithSdp should have comment or be unexported (golint)
  • Line 147: warning: comment on exported method BaseInSession.SetObserver should be of the form "SetObserver ..." (golint)
  • Line 157: warning: exported method BaseInSession.SetupWithConn should have comment or be unexported (golint)
  • Line 174: warning: exported method BaseInSession.SetupWithChannel should have comment or be unexported (golint)
  • Line 207: warning: exported method BaseInSession.GetSdp should have comment or be unexported (golint)
  • Line 213: warning: exported method BaseInSession.HandleInterleavedPacket should have comment or be unexported (golint)
  • Line 228: warning: comment on exported method BaseInSession.WriteRtpRtcpDummy should be of the form "WriteRtpRtcpDummy ..." (golint)
  • Line 244: warning: exported method BaseInSession.GetStat should have comment or be unexported (golint)
  • Line 250: warning: exported method BaseInSession.UpdateStat should have comment or be unexported (golint)
  • Line 262: warning: exported method BaseInSession.IsAlive should have comment or be unexported (golint)
  • Line 279: warning: exported method BaseInSession.UniqueKey should have comment or be unexported (golint)

• pkg/base/merge_writer.go
  • Line 31: warning: exported type OnWritev should have comment or be unexported (golint)
  • Line 33: warning: comment on exported function NewMergeWriter should be of the form "NewMergeWriter ..." (golint)

• pkg/base/rtmp_t.go
  • Line 12: warning: comment on exported const RtmpTypeIdAudio should be of the form "RtmpTypeIdAudio ..." (golint)
  • Line 15: warning: exported const RtmpTypeIdVideo should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: comment on exported const RtmpFrameTypeKey should be of the form "RtmpFrameTypeKey ..." (golint)
  • Line 66: warning: comment on exported const RtmpSoundFormatAac should be of the form "RtmpSoundFormatAac ..." (golint)
  • Line 81: warning: exported type RtmpHeader should have comment or be unexported (golint)
  • Line 89: warning: exported type RtmpMsg should have comment or be unexported (golint)
  • Line 94: warning: exported method RtmpMsg.IsAvcKeySeqHeader should have comment or be unexported (golint)
  • Line 98: warning: exported method RtmpMsg.IsHevcKeySeqHeader should have comment or be unexported (golint)
  • Line 102: warning: exported method RtmpMsg.IsVideoKeySeqHeader should have comment or be unexported (golint)
  • Line 106: warning: exported method RtmpMsg.IsAvcKeyNalu should have comment or be unexported (golint)
  • Line 110: warning: exported method RtmpMsg.IsHevcKeyNalu should have comment or be unexported (golint)
  • Line 114: warning: exported method RtmpMsg.IsVideoKeyNalu should have comment or be unexported (golint)
  • Line 118: warning: exported method RtmpMsg.IsAacSeqHeader should have comment or be unexported (golint)
  • Line 122: warning: exported method RtmpMsg.Clone should have comment or be unexported (golint)

• pkg/rtmp/chunk_composer.go
  • Line 24: warning: exported type ChunkComposer should have comment or be unexported (golint)
  • Line 29: warning: exported function NewChunkComposer should have comment or be unexported (golint)
  • Line 36: warning: exported method ChunkComposer.SetPeerChunkSize should have comment or be unexported (golint)
  • Line 40: warning: exported type OnCompleteMessage should have comment or be unexported (golint)

• pkg/base/rtprtcp_t.go
  • Line 12: warning: comment on exported const RtpPacketTypeAvcOrHevc should be of the form "RtpPacketTypeAvcOrHevc ..." (golint)
  • Line 17: warning: exported const RtpPacketTypeAac should have comment (or a comment on this block) or be unexported (golint)

• pkg/hls/streamer.go
  • Line 24: warning: exported type StreamerObserver should have comment or be unexported (golint)
  • Line 37: warning: comment on exported type Streamer should be of the form "Streamer ..." (with optional leading article) (golint)
  • Line 52: warning: exported function NewStreamer should have comment or be unexported (golint)
  • Line 65: warning: comment on exported method Streamer.FeedRtmpMessage should be of the form "FeedRtmpMessage ..." (golint)
  • Line 72: warning: exported method Streamer.OnPatPmt should have comment or be unexported (golint)
  • Line 76: warning: exported method Streamer.OnPop should have comment or be unexported (golint)
  • Line 85: warning: exported method Streamer.AudioSeqHeaderCached should have comment or be unexported (golint)
  • Line 89: warning: exported method Streamer.VideoSeqHeaderCached should have comment or be unexported (golint)
  • Line 93: warning: exported method Streamer.AudioCacheEmpty should have comment or be unexported (golint)
  • Line 272: warning: comment on exported method Streamer.FlushAudio should be of the form "FlushAudio ..." (golint)

• pkg/sdp/pack.go
  • Line 24: warning: exported function Pack should have comment or be unexported (golint)

• pkg/base/websocket.go
  • Line 19: warning: comment on exported type WsOpcode should be of the form "WsOpcode ..." (with optional leading article) (golint)
  • Line 59: warning: don't use underscores in Go names; const Wso_Continuous should be WsoContinuous (golint)
  • Line 59: warning: exported const Wso_Continuous should have comment (or a comment on this block) or be unexported (golint)
  • Line 60: warning: don't use underscores in Go names; const Wso_Text should be WsoText (golint)
  • Line 61: warning: don't use underscores in Go names; const Wso_Binary should be WsoBinary (golint)
  • Line 62: warning: comment on exported const Wso_Rsv3 should be of the form "Wso_Rsv3 ..." (golint)
  • Line 63: warning: don't use underscores in Go names; const Wso_Rsv3 should be WsoRsv3 (golint)
  • Line 64: warning: don't use underscores in Go names; const Wso_Rsv4 should be WsoRsv4 (golint)
  • Line 65: warning: don't use underscores in Go names; const Wso_Rsv5 should be WsoRsv5 (golint)
  • Line 66: warning: don't use underscores in Go names; const Wso_Rsv6 should be WsoRsv6 (golint)
  • Line 67: warning: don't use underscores in Go names; const Wso_Rsv7 should be WsoRsv7 (golint)
  • Line 68: warning: don't use underscores in Go names; const Wso_Close should be WsoClose (golint)
  • Line 69: warning: don't use underscores in Go names; const Wso_Ping should be WsoPing (golint)
  • Line 70: warning: don't use underscores in Go names; const Wso_Pong should be WsoPong (golint)
  • Line 71: warning: comment on exported const Wso_RsvB should be of the form "Wso_RsvB ..." (golint)
  • Line 72: warning: don't use underscores in Go names; const Wso_RsvB should be WsoRsvB (golint)
  • Line 73: warning: don't use underscores in Go names; const Wso_RsvC should be WsoRsvC (golint)
  • Line 74: warning: don't use underscores in Go names; const Wso_RsvD should be WsoRsvD (golint)
  • Line 75: warning: don't use underscores in Go names; const Wso_RsvE should be WsoRsvE (golint)
  • Line 76: warning: don't use underscores in Go names; const Wso_RsvF should be WsoRsvF (golint)
  • Line 79: warning: exported type WsHeader should have comment or be unexported (golint)
  • Line 92: warning: exported const WsMagicStr should have comment or be unexported (golint)
  • Line 94: warning: exported function MakeWsFrameHeader should have comment or be unexported (golint)
  • Line 140: warning: exported function UpdateWebSocketHeader should have comment or be unexported (golint)

• app/demo/dispatch/datamanager/data_interface.go
  • Line 14: warning: exported type DataManger should have comment or be unexported (golint)
  • Line 24: warning: exported type DataManagerType should have comment or be unexported (golint)
  • Line 27: warning: exported const DmtMemory should have comment (or a comment on this block) or be unexported (golint)
  • Line 30: warning: comment on exported function NewDataManager should be of the form "NewDataManager ..." (golint)

• app/demo/pullrtmp2pushrtmp/tunnel.go
  • Line 27: warning: exported var ErrClosedByCaller should have comment or be unexported (golint)
  • Line 29: warning: exported type Tunnel should have comment or be unexported (golint)
  • Line 45: warning: exported type ErrorCode should have comment or be unexported (golint)
  • Line 50: warning: comment on exported function NewTunnel should be of the form "NewTunnel ..." (golint)
  • Line 79: warning: comment on exported method Tunnel.Start should be of the form "Start ..." (golint)
  • Line 237: warning: comment on exported method Tunnel.Wait should be of the form "Wait ..." (golint)
  • Line 243: warning: comment on exported method Tunnel.Close should be of the form "Close ..." (golint)
  • Line 295: warning: exported method ErrorCode.Stringify should have comment or be unexported (golint)

• pkg/hls/muxer.go
  • Line 27: warning: exported type MuxerObserver should have comment or be unexported (golint)
  • Line 36: warning: exported type MuxerConfig should have comment or be unexported (golint)
  • Line 52: warning: exported const CleanupModeNever should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: comment on exported type Muxer should be of the form "Muxer ..." (with optional leading article) (golint)
  • Line 95: warning: comment on exported function NewMuxer should be of the form "NewMuxer ..." (golint)
  • Line 124: warning: exported method Muxer.Start should have comment or be unexported (golint)
  • Line 129: warning: exported method Muxer.Dispose should have comment or be unexported (golint)
  • Line 137: warning: comment on exported method Muxer.FeedRtmpMessage should be of the form "FeedRtmpMessage ..." (golint)
  • Line 143: warning: exported method Muxer.OnPatPmt should have comment or be unexported (golint)
  • Line 150: warning: exported method Muxer.OnFrame should have comment or be unexported (golint)
  • Line 206: warning: exported method Muxer.OutPath should have comment or be unexported (golint)

• pkg/remux/dummy_audio_filter.go
  • Line 25: warning: exported type DummyAudioFilter should have comment or be unexported (golint)
  • Line 54: warning: exported method DummyAudioFilter.OnReadRtmpAvMsg should have comment or be unexported (golint)
  • Line 58: warning: exported method DummyAudioFilter.Feed should have comment or be unexported (golint)

• pkg/rtsp/server_pub_session.go
  • Line 21: warning: exported type PubSessionObserver should have comment or be unexported (golint)
  • Line 25: warning: exported type PubSession should have comment or be unexported (golint)
  • Line 34: warning: exported function NewPubSession should have comment or be unexported (golint)
  • Line 47: warning: exported method PubSession.InitWithSdp should have comment or be unexported (golint)
  • Line 51: warning: exported method PubSession.SetObserver should have comment or be unexported (golint)
  • Line 55: warning: exported method PubSession.SetupWithConn should have comment or be unexported (golint)
  • Line 59: warning: exported method PubSession.SetupWithChannel should have comment or be unexported (golint)
  • Line 63: warning: exported method PubSession.Dispose should have comment or be unexported (golint)
  • Line 70: warning: exported method PubSession.GetSdp should have comment or be unexported (golint)
  • Line 74: warning: exported method PubSession.HandleInterleavedPacket should have comment or be unexported (golint)
  • Line 78: warning: exported method PubSession.Url should have comment or be unexported (golint)
  • Line 82: warning: exported method PubSession.AppName should have comment or be unexported (golint)
  • Line 86: warning: exported method PubSession.StreamName should have comment or be unexported (golint)
  • Line 90: warning: exported method PubSession.RawQuery should have comment or be unexported (golint)
  • Line 94: warning: exported method PubSession.UniqueKey should have comment or be unexported (golint)
  • Line 98: warning: exported method PubSession.GetStat should have comment or be unexported (golint)
  • Line 104: warning: exported method PubSession.UpdateStat should have comment or be unexported (golint)
  • Line 108: warning: exported method PubSession.IsAlive should have comment or be unexported (golint)
  • Line 112: warning: comment on exported method PubSession.WriteInterleavedPacket should be of the form "WriteInterleavedPacket ..." (golint)

• pkg/rtmp/amf0.go
  • Line 27: warning: exported const Amf0TypeMarkerNumber should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: exported var Amf0TypeMarkerObjectEndBytes should have comment or be unexported (golint)
  • Line 50: warning: exported type ObjectPair should have comment or be unexported (golint)
  • Line 55: warning: exported type ObjectPairArray should have comment or be unexported (golint)
  • Line 57: warning: exported method ObjectPairArray.Find should have comment or be unexported (golint)
  • Line 66: warning: exported method ObjectPairArray.FindString should have comment or be unexported (golint)
  • Line 77: warning: exported method ObjectPairArray.FindNumber should have comment or be unexported (golint)
  • Line 90: warning: exported var Amf0 should have comment or be unexported (golint)

• pkg/rtmp/server_session.go
  • Line 29: warning: exported type ServerSessionObserver should have comment or be unexported (golint)
  • Line 43: warning: exported type PubSessionObserver should have comment or be unexported (golint)
  • Line 48: warning: exported method ServerSession.SetPubSessionObserver should have comment or be unexported (golint)
  • Line 52: warning: exported type ServerSessionType should have comment or be unexported (golint)
  • Line 55: warning: exported const ServerSessionTypeUnknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 60: warning: exported type ServerSession should have comment or be unexported (golint)
  • Line 92: warning: exported function NewServerSession should have comment or be unexported (golint)
  • Line 116: warning: exported method ServerSession.RunLoop should have comment or be unexported (golint)
  • Line 133: warning: exported method ServerSession.Writev should have comment or be unexported (golint)
  • Line 138: warning: exported method ServerSession.Flush should have comment or be unexported (golint)
  • Line 142: warning: exported method ServerSession.Dispose should have comment or be unexported (golint)
  • Line 146: warning: exported method ServerSession.Url should have comment or be unexported (golint)
  • Line 150: warning: exported method ServerSession.AppName should have comment or be unexported (golint)
  • Line 154: warning: exported method ServerSession.StreamName should have comment or be unexported (golint)
  • Line 158: warning: exported method ServerSession.RawQuery should have comment or be unexported (golint)
  • Line 162: warning: exported method ServerSession.UniqueKey should have comment or be unexported (golint)
  • Line 166: warning: exported method ServerSession.UpdateStat should have comment or be unexported (golint)
  • Line 181: warning: exported method ServerSession.GetStat should have comment or be unexported (golint)
  • Line 188: warning: exported method ServerSession.IsAlive should have comment or be unexported (golint)

• pkg/rtprtcp/rtcp_pack.go
  • Line 13: warning: exported type Rr should have comment or be unexported (golint)
  • Line 25: warning: exported method Rr.Pack should have comment or be unexported (golint)

• pkg/remux/flv2rtmp.go
  • Line 17: warning: exported function FlvTagHeader2RtmpHeader should have comment or be unexported (golint)
  • Line 33: warning: comment on exported function FlvTag2RtmpMsg should be of the form "FlvTag2RtmpMsg ..." (golint)
  • Line 41: warning: comment on exported function FlvTag2RtmpChunks should be of the form "FlvTag2RtmpChunks ..." (golint)

• pkg/rtsp/rtsp.go
  • Line 33: warning: exported const MethodOptions should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: comment on exported const HeaderAccept should be of the form "HeaderAccept ..." (golint)
  • Line 46: warning: exported const HeaderUserAgent should have comment (or a comment on this block) or be unexported (golint)
  • Line 56: warning: comment on exported const HeaderAcceptApplicationSdp should be of the form "HeaderAcceptApplicationSdp ..." (golint)
  • Line 64: warning: comment on exported const HeaderTransportServerRecordTmpl should be of the form "HeaderTransportServerRecordTmpl ..." (golint)
  • Line 70: warning: exported const TransportFieldClientPort should have comment (or a comment on this block) or be unexported (golint)
  • Line 76: warning: exported const Interleaved should have comment (or a comment on this block) or be unexported (golint)
  • Line 102: warning: exported type IInterleavedPacketWriter should have comment or be unexported (golint)

• pkg/rtsp/server.go
  • Line 17: warning: exported type ServerObserver should have comment or be unexported (golint)
  • Line 54: warning: exported type Server should have comment or be unexported (golint)
  • Line 61: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 68: warning: exported method Server.Listen should have comment or be unexported (golint)
  • Line 77: warning: exported method Server.RunLoop should have comment or be unexported (golint)
  • Line 87: warning: exported method Server.Dispose should have comment or be unexported (golint)
  • Line 98: warning: exported method Server.OnNewRtspPubSession should have comment or be unexported (golint)
  • Line 102: warning: exported method Server.OnNewRtspSubSessionDescribe should have comment or be unexported (golint)
  • Line 106: warning: exported method Server.OnNewRtspSubSessionPlay should have comment or be unexported (golint)
  • Line 110: warning: exported method Server.OnDelRtspPubSession should have comment or be unexported (golint)
  • Line 114: warning: exported method Server.OnDelRtspSubSession should have comment or be unexported (golint)

• pkg/avc/beta.go
  • Line 24: warning: exported function ParseSps should have comment or be unexported (golint)
  • Line 49: warning: comment on exported function TryParsePps should be of the form "TryParsePps ..." (golint)
  • Line 58: warning: comment on exported function TryParseSeqHeader should be of the form "TryParseSeqHeader ..." (golint)

• pkg/rtprtcp/rtp_unpacker_avc_hevc.go
  • Line 19: warning: exported type RtpUnpackerAvcHevc should have comment or be unexported (golint)
  • Line 25: warning: exported function NewRtpUnpackerAvcHevc should have comment or be unexported (golint)
  • Line 33: warning: exported method RtpUnpackerAvcHevc.CalcPositionIfNeeded should have comment or be unexported (golint)
  • Line 42: warning: exported method RtpUnpackerAvcHevc.TryUnpackOne should have comment or be unexported (golint)

• pkg/aac/seqheader.go
  • Line 20: warning: comment on exported type SequenceHeaderContext should be of the form "SequenceHeaderContext ..." (with optional leading article) (golint)
  • Line 38: warning: comment on exported method SequenceHeaderContext.Unpack should be of the form "Unpack ..." (golint)
  • Line 52: warning: comment on exported function MakeAudioDataSeqHeaderWithAsc should be of the form "MakeAudioDataSeqHeaderWithAsc ..." (golint)
  • Line 71: warning: comment on exported function MakeAudioDataSeqHeaderWithAdtsHeader should be of the form "MakeAudioDataSeqHeaderWithAdtsHeader ..." (golint)

• pkg/avc/avc.go
  • Line 36: warning: exported var NaluStartCode3 should have comment or be unexported (golint)
  • Line 39: warning: comment on exported var AudNalu should be of the form "AudNalu ..." (golint)
  • Line 43: warning: comment on exported var NaluTypeMapping should be of the form "NaluTypeMapping ..." (golint)
  • Line 58: warning: exported var SliceTypeMapping should have comment or be unexported (golint)
  • Line 72: warning: exported const NaluTypeSlice should have comment (or a comment on this block) or be unexported (golint)
  • Line 82: warning: exported const SliceTypeP should have comment (or a comment on this block) or be unexported (golint)
  • Line 89: warning: exported type Context should have comment or be unexported (golint)
  • Line 96: warning: comment on exported type DecoderConfigurationRecord should be of the form "DecoderConfigurationRecord ..." (with optional leading article) (golint)
  • Line 113: warning: comment on exported type Sps should be of the form "Sps ..." (with optional leading article) (golint)
  • Line 157: warning: exported function ParseNaluType should have comment or be unexported (golint)
  • Line 161: warning: exported function ParseSliceType should have comment or be unexported (golint)
  • Line 189: warning: exported function ParseNaluTypeReadable should have comment or be unexported (golint)
  • Line 198: warning: exported function ParseSliceTypeReadable should have comment or be unexported (golint)
  • Line 222: warning: comment on exported function SpsPpsSeqHeader2Annexb should be of the form "SpsPpsSeqHeader2Annexb ..." (golint)
  • Line 244: warning: comment on exported function ParseSpsPpsFromSeqHeader should be of the form "ParseSpsPpsFromSeqHeader ..." (golint)
  • Line 260: warning: comment on exported function ParseSpsPpsFromSeqHeaderWithoutMalloc should be of the form "ParseSpsPpsFromSeqHeaderWithoutMalloc ..." (golint)
  • Line 313: warning: comment on exported function BuildSeqHeaderFromSpsPps should be of the form "BuildSeqHeaderFromSpsPps ..." (golint)
  • Line 360: warning: comment on exported function CaptureAvcc2Annexb should be of the form "CaptureAvcc2Annexb ..." (golint)
  • Line 391: warning: comment on exported function IterateNaluStartCode should be of the form "IterateNaluStartCode ..." (golint)
  • Line 422: warning: comment on exported function SplitNaluAnnexb should be of the form "SplitNaluAnnexb ..." (golint)
  • Line 435: warning: comment on exported function SplitNaluAvcc should be of the form "SplitNaluAvcc ..." (golint)
  • Line 449: warning: exported function IterateNaluAnnexb should have comment or be unexported (golint)
  • Line 466: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 481: warning: exported function IterateNaluAvcc should have comment or be unexported (golint)

• pkg/sdp/parse_raw.go
  • Line 19: warning: exported type RawContext should have comment or be unexported (golint)
  • Line 23: warning: exported type MediaDesc should have comment or be unexported (golint)
  • Line 30: warning: exported type M should have comment or be unexported (golint)
  • Line 34: warning: exported type ARtpMap should have comment or be unexported (golint)
  • Line 41: warning: exported type AFmtPBase should have comment or be unexported (golint)
  • Line 46: warning: exported type AControl should have comment or be unexported (golint)
  • Line 85: warning: exported function ParseM should have comment or be unexported (golint)
  • Line 95: warning: comment on exported function ParseARtpMap should be of the form "ParseARtpMap ..." (golint)
  • Line 134: warning: comment on exported function ParseAFmtPBase should be of the form "ParseAFmtPBase ..." (golint)
  • Line 179: warning: exported function ParseAControl should have comment or be unexported (golint)

• pkg/rtprtcp/rtp_unpacker.go
  • Line 26: warning: exported type IRtpUnpacker should have comment or be unexported (golint)
  • Line 30: warning: exported type IRtpUnpackContainer should have comment or be unexported (golint)
  • Line 34: warning: exported type IRtpUnpackerProtocol should have comment or be unexported (golint)
  • Line 50: warning: comment on exported type OnAvPacket should be of the form "OnAvPacket ..." (with optional leading article) (golint)
  • Line 63: warning: comment on exported function DefaultRtpUnpackerFactory should be of the form "DefaultRtpUnpackerFactory ..." (golint)

• pkg/httpflv/client_pull_session.go
  • Line 28: warning: exported type PullSessionOption should have comment or be unexported (golint)
  • Line 41: warning: exported type PullSession should have comment or be unexported (golint)
  • Line 55: warning: exported type ModPullSessionOption should have comment or be unexported (golint)
  • Line 57: warning: exported function NewPullSession should have comment or be unexported (golint)
  • Line 72: warning: comment on exported type OnReadFlvTag should be of the form "OnReadFlvTag ..." (with optional leading article) (golint)
  • Line 119: warning: comment on exported method PullSession.Url should be of the form "Url ..." (golint)
  • Line 124: warning: comment on exported method PullSession.AppName should be of the form "AppName ..." (golint)
  • Line 129: warning: comment on exported method PullSession.StreamName should be of the form "StreamName ..." (golint)
  • Line 134: warning: comment on exported method PullSession.RawQuery should be of the form "RawQuery ..." (golint)
  • Line 139: warning: comment on exported method PullSession.UniqueKey should be of the form "UniqueKey ..." (golint)
  • Line 144: warning: comment on exported method PullSession.UpdateStat should be of the form "UpdateStat ..." (golint)
  • Line 155: warning: comment on exported method PullSession.GetStat should be of the form "GetStat ..." (golint)
  • Line 163: warning: comment on exported method PullSession.IsAlive should be of the form "IsAlive ..." (golint)

• pkg/base/unique.go
  • Line 14: warning: exported const UkPreRtmpServerSession should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: exported function GenUkRtmpServerSession should have comment or be unexported (golint)
  • Line 39: warning: exported function GenUkRtmpPushSession should have comment or be unexported (golint)
  • Line 43: warning: exported function GenUkRtmpPullSession should have comment or be unexported (golint)
  • Line 47: warning: exported function GenUkRtspServerCommandSession should have comment or be unexported (golint)
  • Line 51: warning: exported function GenUkRtspPubSession should have comment or be unexported (golint)
  • Line 55: warning: exported function GenUkRtspSubSession should have comment or be unexported (golint)
  • Line 59: warning: exported function GenUkRtspPushSession should have comment or be unexported (golint)
  • Line 63: warning: exported function GenUkRtspPullSession should have comment or be unexported (golint)
  • Line 67: warning: exported function GenUkFlvSubSession should have comment or be unexported (golint)
  • Line 71: warning: exported function GenUkTsSubSession should have comment or be unexported (golint)
  • Line 75: warning: exported function GenUkFlvPullSession should have comment or be unexported (golint)
  • Line 79: warning: exported function GenUkGroup should have comment or be unexported (golint)
  • Line 83: warning: exported function GenUkHlsMuxer should have comment or be unexported (golint)
  • Line 87: warning: exported function GenUkStreamer should have comment or be unexported (golint)

• pkg/rtsp/base_out_session.go
  • Line 30: warning: comment on exported type BaseOutSession should be of the form "BaseOutSession ..." (with optional leading article) (golint)
  • Line 63: warning: exported function NewBaseOutSession should have comment or be unexported (golint)
  • Line 81: warning: exported method BaseOutSession.InitWithSdp should have comment or be unexported (golint)
  • Line 85: warning: exported method BaseOutSession.SetupWithConn should have comment or be unexported (golint)
  • Line 102: warning: exported method BaseOutSession.SetupWithChannel should have comment or be unexported (golint)
  • Line 136: warning: exported method BaseOutSession.HandleInterleavedPacket should have comment or be unexported (golint)
  • Line 151: warning: exported method BaseOutSession.WriteRtpPacket should have comment or be unexported (golint)
  • Line 191: warning: exported method BaseOutSession.GetStat should have comment or be unexported (golint)
  • Line 197: warning: exported method BaseOutSession.UpdateStat should have comment or be unexported (golint)
  • Line 209: warning: exported method BaseOutSession.IsAlive should have comment or be unexported (golint)
  • Line 226: warning: exported method BaseOutSession.UniqueKey should have comment or be unexported (golint)

• pkg/base/avpacket.go
  • Line 11: warning: exported type AvPacketPt should have comment or be unexported (golint)
  • Line 14: warning: exported const AvPacketPtUnknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: comment on exported type AvPacket should be of the form "AvPacket ..." (with optional leading article) (golint)
  • Line 31: warning: exported method AvPacketPt.ReadableString should have comment or be unexported (golint)

• pkg/base/http_notify_t.go
  • Line 13: warning: exported const HttpNotifyVersion should have comment or be unexported (golint)
  • Line 15: warning: exported type SessionEventCommonInfo should have comment or be unexported (golint)
  • Line 28: warning: exported type UpdateInfo should have comment or be unexported (golint)
  • Line 33: warning: exported type PubStartInfo should have comment or be unexported (golint)
  • Line 37: warning: exported type PubStopInfo should have comment or be unexported (golint)
  • Line 41: warning: exported type SubStartInfo should have comment or be unexported (golint)
  • Line 45: warning: exported type SubStopInfo should have comment or be unexported (golint)
  • Line 49: warning: exported type RtmpConnectInfo should have comment or be unexported (golint)

• pkg/remux/rtmp2rtsp.go
  • Line 33: warning: comment on exported type Rtmp2RtspRemuxer should be of the form "Rtmp2RtspRemuxer ..." (with optional leading article) (golint)
  • Line 50: warning: exported type OnSdp should have comment or be unexported (golint)
  • Line 51: warning: exported type OnRtpPacket should have comment or be unexported (golint)
  • Line 53: warning: comment on exported function NewRtmp2RtspRemuxer should be of the form "NewRtmp2RtspRemuxer ..." (golint)
  • Line 65: warning: comment on exported method Rtmp2RtspRemuxer.FeedRtmpMsg should be of the form "FeedRtmpMsg ..." (golint)

• pkg/base/http_server.go
  • Line 25: warning: exported const NetworkTcp should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type LocalAddrCtx should have comment or be unexported (golint)
  • Line 37: warning: exported type HttpServerManager should have comment or be unexported (golint)
  • Line 41: warning: exported type ServerCtx should have comment or be unexported (golint)
  • Line 49: warning: exported function NewHttpServerManager should have comment or be unexported (golint)
  • Line 55: warning: exported type Handler should have comment or be unexported (golint)
  • Line 57: warning: comment on exported method HttpServerManager.AddListen should be of the form "AddListen ..." (golint)
  • Line 109: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 119: warning: exported method HttpServerManager.RunLoop should have comment or be unexported (golint)
  • Line 134: warning: exported method HttpServerManager.Dispose should have comment or be unexported (golint)

• pkg/hevc/hevc.go
  • Line 36: warning: exported var NaluStartCode4 should have comment or be unexported (golint)
  • Line 42: warning: exported var NaluTypeMapping should have comment or be unexported (golint)
  • Line 79: warning: exported type Context should have comment or be unexported (golint)
  • Line 102: warning: exported function ParseNaluTypeReadable should have comment or be unexported (golint)
  • Line 110: warning: comment on exported function ParseNaluType should be of the form "ParseNaluType ..." (golint)
  • Line 121: warning: comment on exported function VpsSpsPpsSeqHeader2Annexb should be of the form "VpsSpsPpsSeqHeader2Annexb ..." (golint)
  • Line 142: warning: comment on exported function ParseVpsSpsPpsFromSeqHeader should be of the form "ParseVpsSpsPpsFromSeqHeader ..." (golint)
  • Line 159: warning: comment on exported function ParseVpsSpsPpsFromSeqHeaderWithoutMalloc should be of the form "ParseVpsSpsPpsFromSeqHeaderWithoutMalloc ..." (golint)
  • Line 237: warning: comment on exported function BuildSeqHeaderFromVpsSpsPps should be of the form "BuildSeqHeaderFromVpsSpsPps ..." (golint)
  • Line 325: warning: exported function ParseVps should have comment or be unexported (golint)
  • Line 359: warning: exported function ParseSps should have comment or be unexported (golint)

• pkg/httpflv/flv_file_writer.go
  • Line 19: warning: exported type FlvFileWriter should have comment or be unexported (golint)
  • Line 23: warning: exported method FlvFileWriter.Open should have comment or be unexported (golint)
  • Line 28: warning: exported method FlvFileWriter.WriteRaw should have comment or be unexported (golint)
  • Line 36: warning: exported method FlvFileWriter.WriteFlvHeader should have comment or be unexported (golint)
  • Line 44: warning: exported method FlvFileWriter.WriteTag should have comment or be unexported (golint)
  • Line 52: warning: exported method FlvFileWriter.Dispose should have comment or be unexported (golint)
  • Line 59: warning: exported method FlvFileWriter.Name should have comment or be unexported (golint)

• pkg/logic/http_api.go
  • Line 22: warning: exported type HttpApiServer should have comment or be unexported (golint)
  • Line 29: warning: exported function NewHttpApiServer should have comment or be unexported (golint)
  • Line 36: warning: exported method HttpApiServer.Listen should have comment or be unexported (golint)
  • Line 44: warning: exported method HttpApiServer.RunLoop should have comment or be unexported (golint)

• pkg/base/version.go
  • Line 18: warning: comment on exported const LalVersion should be of the form "LalVersion ..." (golint)
  • Line 22: warning: exported var LalLibraryName should have comment or be unexported (golint)
  • Line 27: warning: comment on exported var LalFullInfo should be of the form "LalFullInfo ..." (golint)
  • Line 30: warning: comment on exported var LalVersionDot should be of the form "LalVersionDot ..." (golint)
  • Line 33: warning: comment on exported var LalVersionComma should be of the form "LalVersionComma ..." (golint)
  • Line 38: warning: comment on exported var LalRtmpHandshakeWaterMark should be of the form "LalRtmpHandshakeWaterMark ..." (golint)
  • Line 42: warning: comment on exported var LalRtmpConnectResultVersion should be of the form "LalRtmpConnectResultVersion ..." (golint)
  • Line 47: warning: comment on exported var LalRtmpPushSessionConnectVersion should be of the form "LalRtmpPushSessionConnectVersion ..." (golint)
  • Line 50: warning: comment on exported var LalRtmpBuildMetadataEncoder should be of the form "LalRtmpBuildMetadataEncoder ..." (golint)
  • Line 53: warning: comment on exported var LalHttpflvPullSessionUa should be of the form "LalHttpflvPullSessionUa ..." (golint)
  • Line 56: warning: comment on exported var LalHttpflvSubSessionServer should be of the form "LalHttpflvSubSessionServer ..." (golint)
  • Line 59: warning: comment on exported var LalHlsM3u8Server should be of the form "LalHlsM3u8Server ..." (golint)
  • Line 62: warning: comment on exported var LalHlsTsServer should be of the form "LalHlsTsServer ..." (golint)
  • Line 65: warning: comment on exported var LalRtspOptionsResponseServer should be of the form "LalRtspOptionsResponseServer ..." (golint)
  • Line 68: warning: comment on exported var LalHttptsSubSessionServer should be of the form "LalHttptsSubSessionServer ..." (golint)
  • Line 71: warning: comment on exported var LalHttpApiServer should be of the form "LalHttpApiServer ..." (golint)
  • Line 74: warning: comment on exported var LalRtspPullSessionUa should be of the form "LalRtspPullSessionUa ..." (golint)
  • Line 77: warning: comment on exported var LalPackSdp should be of the form "LalPackSdp ..." (golint)

• pkg/hls/filesystemlayer.go
  • Line 22: warning: exported function SetUseMemoryAsDiskFlag should have comment or be unexported (golint)
  • Line 36: warning: exported function ReadFile should have comment or be unexported (golint)
  • Line 40: warning: exported function RemoveAll should have comment or be unexported (golint)

• pkg/rtmp/handshake.go
  • Line 77: warning: exported type IHandshakeClient should have comment or be unexported (golint)
  • Line 84: warning: exported type HandshakeClientSimple should have comment or be unexported (golint)
  • Line 88: warning: exported type HandshakeClientComplex should have comment or be unexported (golint)
  • Line 92: warning: exported type HandshakeServer should have comment or be unexported (golint)
  • Line 97: warning: exported method HandshakeClientSimple.WriteC0C1 should have comment or be unexported (golint)
  • Line 108: warning: exported method HandshakeClientSimple.ReadS0S1 should have comment or be unexported (golint)
  • Line 113: warning: exported method HandshakeClientSimple.WriteC2 should have comment or be unexported (golint)
  • Line 119: warning: exported method HandshakeClientSimple.ReadS2 should have comment or be unexported (golint)
  • Line 124: warning: exported method HandshakeClientComplex.WriteC0C1 should have comment or be unexported (golint)
  • Line 141: warning: exported method HandshakeClientComplex.ReadS0S1 should have comment or be unexported (golint)
  • Line 163: warning: exported method HandshakeClientComplex.WriteC2 should have comment or be unexported (golint)
  • Line 168: warning: exported method HandshakeClientComplex.ReadS2 should have comment or be unexported (golint)
  • Line 173: warning: exported method HandshakeServer.ReadC0C1 should have comment or be unexported (golint)
  • Line 216: warning: exported method HandshakeServer.WriteS0S1S2 should have comment or be unexported (golint)
  • Line 221: warning: exported method HandshakeServer.ReadC2 should have comment or be unexported (golint)

• pkg/rtmp/metadata.go
  • Line 17: warning: exported function ParseMetadata should have comment or be unexported (golint)
  • Line 35: warning: comment on exported function BuildMetadata should be of the form "BuildMetadata ..." (golint)

• pkg/base/http_sub_session.go
  • Line 19: warning: exported type HttpSubSession should have comment or be unexported (golint)
  • Line 29: warning: exported type HttpSubSessionOption should have comment or be unexported (golint)
  • Line 39: warning: exported function NewHttpSubSession should have comment or be unexported (golint)
  • Line 57: warning: exported method HttpSubSession.RunLoop should have comment or be unexported (golint)
  • Line 63: warning: exported method HttpSubSession.Dispose should have comment or be unexported (golint)
  • Line 69: warning: exported method HttpSubSession.WriteHttpResponseHeader should have comment or be unexported (golint)
  • Line 97: warning: exported method HttpSubSession.UniqueKey should have comment or be unexported (golint)
  • Line 105: warning: exported method HttpSubSession.Url should have comment or be unexported (golint)
  • Line 109: warning: exported method HttpSubSession.AppName should have comment or be unexported (golint)
  • Line 113: warning: exported method HttpSubSession.StreamName should have comment or be unexported (golint)
  • Line 126: warning: exported method HttpSubSession.RawQuery should have comment or be unexported (golint)
  • Line 134: warning: exported method HttpSubSession.GetStat should have comment or be unexported (golint)
  • Line 141: warning: exported method HttpSubSession.UpdateStat should have comment or be unexported (golint)
  • Line 151: warning: exported method HttpSubSession.IsAlive should have comment or be unexported (golint)

• pkg/rtprtcp/rtp.go
  • Line 27: warning: exported const NaluTypeAvcSingleMax should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: comment on exported const NaluTypeHevcFua should be of the form "NaluTypeHevcFua ..." (golint)
  • Line 35: warning: comment on exported function CompareSeq should be of the form "CompareSeq ..." (golint)
  • Line 59: warning: comment on exported function SubSeq should be of the form "SubSeq ..." (golint)

• pkg/rtprtcp/rtp_packer.go
  • Line 18: warning: exported type RtpPacker should have comment or be unexported (golint)
  • Line 27: warning: exported type RtpPackerOption should have comment or be unexported (golint)
  • Line 36: warning: exported type ModRtpPackerOption should have comment or be unexported (golint)
  • Line 38: warning: exported function NewRtpPacker should have comment or be unexported (golint)
  • Line 55: warning: comment on exported method RtpPacker.Pack should be of the form "Pack ..." (golint)

• pkg/hls/var.go
  • Line 14: warning: exported var PathStrategy should have comment or be unexported (golint)

• pkg/mpegts/pes.go
  • Line 15: warning: comment on exported type Pes should be of the form "Pes ..." (with optional leading article) (golint)
  • Line 50: warning: exported function ParsePes should have comment or be unexported (golint)

• pkg/logic/config.go
  • Line 24: warning: exported const ConfVersion should have comment or be unexported (golint)
  • Line 33: warning: exported type Config should have comment or be unexported (golint)
  • Line 54: warning: exported type RtmpConfig should have comment or be unexported (golint)
  • Line 63: warning: exported type DefaultHttpConfig should have comment or be unexported (golint)
  • Line 67: warning: exported type HttpflvConfig should have comment or be unexported (golint)
  • Line 73: warning: exported type HttptsConfig should have comment or be unexported (golint)
  • Line 77: warning: exported type HlsConfig should have comment or be unexported (golint)
  • Line 84: warning: exported type RtspConfig should have comment or be unexported (golint)
  • Line 89: warning: exported type RecordConfig should have comment or be unexported (golint)
  • Line 96: warning: exported type RelayPushConfig should have comment or be unexported (golint)
  • Line 101: warning: exported type RelayPullConfig should have comment or be unexported (golint)
  • Line 106: warning: exported type HttpApiConfig should have comment or be unexported (golint)
  • Line 111: warning: exported type HttpNotifyConfig should have comment or be unexported (golint)
  • Line 123: warning: exported type SimpleAuthConfig should have comment or be unexported (golint)
  • Line 135: warning: exported type PprofConfig should have comment or be unexported (golint)
  • Line 140: warning: exported type DebugConfig should have comment or be unexported (golint)
  • Line 146: warning: exported type CommonHttpServerConfig should have comment or be unexported (golint)
  • Line 154: warning: exported type CommonHttpAddrConfig should have comment or be unexported (golint)
  • Line 161: warning: exported function LoadConfAndInitLog should have comment or be unexported (golint)

• pkg/base/url.go
  • Line 25: warning: exported const DefaultRtmpPort should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: exported type UrlPathContext should have comment or be unexported (golint)
  • Line 39: warning: exported type UrlContext should have comment or be unexported (golint)
  • Line 63: warning: exported method UrlContext.GetFilenameWithoutType should have comment or be unexported (golint)
  • Line 68: warning: exported method UrlContext.GetFileType should have comment or be unexported (golint)
  • Line 85: warning: comment on exported function ParseUrl should be of the form "ParseUrl ..." (golint)
  • Line 158: warning: exported function ParseRtmpUrl should have comment or be unexported (golint)
  • Line 178: warning: exported function ParseRtspUrl should have comment or be unexported (golint)
  • Line 190: warning: exported function ParseHttpflvUrl should have comment or be unexported (golint)
  • Line 196: warning: comment on exported function ParseHttpRequest should be of the form "ParseHttpRequest ..." (golint)

• pkg/rtmp/client_pull_session.go
  • Line 15: warning: exported type OnReadRtmpAvMsg should have comment or be unexported (golint)
  • Line 17: warning: exported type PullSession should have comment or be unexported (golint)
  • Line 21: warning: exported type PullSessionOption should have comment or be unexported (golint)
  • Line 38: warning: exported type ModPullSessionOption should have comment or be unexported (golint)
  • Line 40: warning: exported function NewPullSession should have comment or be unexported (golint)
  • Line 56: warning: comment on exported method PullSession.Pull should be of the form "Pull ..." (golint)
  • Line 86: warning: comment on exported method PullSession.Url should be of the form "Url ..." (golint)
  • Line 91: warning: comment on exported method PullSession.AppName should be of the form "AppName ..." (golint)
  • Line 96: warning: comment on exported method PullSession.StreamName should be of the form "StreamName ..." (golint)
  • Line 101: warning: comment on exported method PullSession.RawQuery should be of the form "RawQuery ..." (golint)
  • Line 106: warning: comment on exported method PullSession.UniqueKey should be of the form "UniqueKey ..." (golint)
  • Line 111: warning: comment on exported method PullSession.GetStat should be of the form "GetStat ..." (golint)
  • Line 116: warning: comment on exported method PullSession.UpdateStat should be of the form "UpdateStat ..." (golint)
  • Line 121: warning: comment on exported method PullSession.IsAlive should be of the form "IsAlive ..." (golint)

• pkg/rtprtcp/ntp.go
  • Line 14: warning: comment on exported function Ntp2UnixNano should be of the form "Ntp2UnixNano ..." (golint)
  • Line 21: warning: comment on exported function MswLsw2UnixNano should be of the form "MswLsw2UnixNano ..." (golint)
  • Line 26: warning: comment on exported function MswLsw2Ntp should be of the form "MswLsw2Ntp ..." (golint)

• pkg/rtprtcp/rtp_packer_payload_aac.go
  • Line 13: warning: exported type RtpPackerPayloadAac should have comment or be unexported (golint)
  • Line 16: warning: exported function NewRtpPackerPayloadAac should have comment or be unexported (golint)
  • Line 20: warning: exported method RtpPackerPayloadAac.Pack should have comment or be unexported (golint)

• pkg/remux/rtmp.go
  • Line 16: warning: exported function MakeDefaultRtmpHeader should have comment or be unexported (golint)
  • Line 42: warning: exported method LazyRtmpChunkDivider.Init should have comment or be unexported (golint)
  • Line 47: warning: exported method LazyRtmpChunkDivider.Get should have comment or be unexported (golint)

• pkg/httpflv/flv_file_pump.go
  • Line 19: warning: exported var Clock should have comment or be unexported (golint)
  • Line 21: warning: comment on exported type FlvFilePumpOption should be of the form "FlvFilePumpOption ..." (with optional leading article) (golint)
  • Line 33: warning: exported type FlvFilePump should have comment or be unexported (golint)
  • Line 37: warning: exported type ModFlvFilePumpOption should have comment or be unexported (golint)
  • Line 39: warning: exported function NewFlvFilePump should have comment or be unexported (golint)
  • Line 48: warning: exported type OnPumpFlvTag should have comment or be unexported (golint)
  • Line 50: warning: comment on exported method FlvFilePump.Pump should be of the form "Pump ..." (golint)
  • Line 64: warning: comment on exported method FlvFilePump.PumpWithTags should be of the form "PumpWithTags ..." (golint)

• pkg/rtsp/client_push_session.go
  • Line 22: warning: exported type PushSessionOption should have comment or be unexported (golint)
  • Line 32: warning: exported type PushSession should have comment or be unexported (golint)
  • Line 41: warning: exported type ModPushSessionOption should have comment or be unexported (golint)
  • Line 43: warning: exported function NewPushSession should have comment or be unexported (golint)
  • Line 118: warning: exported method PushSession.WriteRtpPacket should have comment or be unexported (golint)
  • Line 140: warning: comment on exported method PushSession.Url should be of the form "Url ..." (golint)
  • Line 145: warning: comment on exported method PushSession.AppName should be of the form "AppName ..." (golint)
  • Line 150: warning: comment on exported method PushSession.StreamName should be of the form "StreamName ..." (golint)
  • Line 155: warning: comment on exported method PushSession.RawQuery should be of the form "RawQuery ..." (golint)
  • Line 160: warning: comment on exported method PushSession.UniqueKey should be of the form "UniqueKey ..." (golint)
  • Line 165: warning: comment on exported method PushSession.GetStat should be of the form "GetStat ..." (golint)
  • Line 172: warning: comment on exported method PushSession.UpdateStat should be of the form "UpdateStat ..." (golint)
  • Line 177: warning: comment on exported method PushSession.IsAlive should be of the form "IsAlive ..." (golint)
  • Line 182: warning: comment on exported method PushSession.OnConnectResult should be of the form "OnConnectResult ..." (golint)
  • Line 187: warning: comment on exported method PushSession.OnDescribeResponse should be of the form "OnDescribeResponse ..." (golint)
  • Line 192: warning: comment on exported method PushSession.OnSetupWithConn should be of the form "OnSetupWithConn ..." (golint)
  • Line 197: warning: comment on exported method PushSession.OnSetupWithChannel should be of the form "OnSetupWithChannel ..." (golint)
  • Line 202: warning: comment on exported method PushSession.OnSetupResult should be of the form "OnSetupResult ..." (golint)
  • Line 207: warning: comment on exported method PushSession.OnInterleavedPacket should be of the form "OnInterleavedPacket ..." (golint)
  • Line 212: warning: comment on exported method PushSession.WriteInterleavedPacket should be of the form "WriteInterleavedPacket ..." (golint)

• pkg/rtsp/pack.go
  • Line 20: warning: comment on exported var ResponseOptionsTmpl should be of the form "ResponseOptionsTmpl ..." (golint)
  • Line 30: warning: comment on exported var ResponseAnnounceTmpl should be of the form "ResponseAnnounceTmpl ..." (golint)
  • Line 37: warning: comment on exported var ResponseDescribeTmpl should be of the form "ResponseDescribeTmpl ..." (golint)
  • Line 46: warning: comment on exported var ResponseSetupTmpl should be of the form "ResponseSetupTmpl ..." (golint)
  • Line 58: warning: comment on exported var ResponseRecordTmpl should be of the form "ResponseRecordTmpl ..." (golint)
  • Line 66: warning: comment on exported var ResponsePlayTmpl should be of the form "ResponsePlayTmpl ..." (golint)
  • Line 75: warning: comment on exported var ResponseTeardownTmpl should be of the form "ResponseTeardownTmpl ..." (golint)
  • Line 80: warning: exported function PackResponseOptions should have comment or be unexported (golint)
  • Line 84: warning: exported function PackResponseAnnounce should have comment or be unexported (golint)
  • Line 88: warning: exported function PackResponseDescribe should have comment or be unexported (golint)
  • Line 93: warning: exported function PackResponseSetup should have comment or be unexported (golint)
  • Line 99: warning: exported function PackResponseRecord should have comment or be unexported (golint)
  • Line 103: warning: exported function PackResponsePlay should have comment or be unexported (golint)
  • Line 108: warning: exported function PackResponseTeardown should have comment or be unexported (golint)
  • Line 112: warning: comment on exported function PackRequest should be of the form "PackRequest ..." (golint)

• pkg/rtsp/server_sub_session.go
  • Line 21: warning: exported type SubSession should have comment or be unexported (golint)
  • Line 30: warning: exported function NewSubSession should have comment or be unexported (golint)
  • Line 45: warning: exported method SubSession.InitWithSdp should have comment or be unexported (golint)
  • Line 49: warning: exported method SubSession.SetupWithConn should have comment or be unexported (golint)
  • Line 53: warning: exported method SubSession.SetupWithChannel should have comment or be unexported (golint)
  • Line 57: warning: exported method SubSession.WriteRtpPacket should have comment or be unexported (golint)
  • Line 61: warning: exported method SubSession.Dispose should have comment or be unexported (golint)
  • Line 68: warning: exported method SubSession.HandleInterleavedPacket should have comment or be unexported (golint)
  • Line 72: warning: exported method SubSession.Url should have comment or be unexported (golint)
  • Line 76: warning: exported method SubSession.AppName should have comment or be unexported (golint)
  • Line 80: warning: exported method SubSession.StreamName should have comment or be unexported (golint)
  • Line 84: warning: exported method SubSession.RawQuery should have comment or be unexported (golint)
  • Line 88: warning: exported method SubSession.UniqueKey should have comment or be unexported (golint)
  • Line 92: warning: exported method SubSession.GetStat should have comment or be unexported (golint)
  • Line 98: warning: exported method SubSession.UpdateStat should have comment or be unexported (golint)
  • Line 102: warning: exported method SubSession.IsAlive should have comment or be unexported (golint)
  • Line 106: warning: comment on exported method SubSession.WriteInterleavedPacket should be of the form "WriteInterleavedPacket ..." (golint)

• pkg/rtmp/rtmp.go
  • Line 12: warning: exported const CsidAmf should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: comment on exported const Msid1 should be of the form "Msid1 ..." (golint)

• pkg/rtprtcp/rtp_packer_payload.go
  • Line 11: warning: exported type IRtpPackerPayload should have comment or be unexported (golint)

• pkg/rtprtcp/rtp_packet.go
  • Line 37: warning: exported const RtpFixedHeaderLength should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported const PositionTypeSingle should have comment (or a comment on this block) or be unexported (golint)
  • Line 50: warning: exported type RtpHeader should have comment or be unexported (golint)
  • Line 64: warning: exported type RtpPacket should have comment or be unexported (golint)
  • Line 71: warning: exported method RtpHeader.PackTo should have comment or be unexported (golint)
  • Line 79: warning: exported function MakeDefaultRtpHeader should have comment or be unexported (golint)
  • Line 89: warning: exported function MakeRtpPacket should have comment or be unexported (golint)
  • Line 97: warning: exported function ParseRtpHeader should have comment or be unexported (golint)
  • Line 117: warning: comment on exported function ParseRtpPacket should be of the form "ParseRtpPacket ..." (golint)
  • Line 128: warning: exported method RtpPacket.Body should have comment or be unexported (golint)
  • Line 136: warning: comment on exported function IsAvcHevcBoundary should be of the form "IsAvcHevcBoundary ..." (golint)
  • Line 148: warning: exported function IsAvcBoundary should have comment or be unexported (golint)
  • Line 181: warning: exported function IsHevcBoundary should have comment or be unexported (golint)

• pkg/rtmp/message_packer.go
  • Line 28: warning: comment on exported type MessagePacker should be of the form "MessagePacker ..." (with optional leading article) (golint)
  • Line 34: warning: exported function NewMessagePacker should have comment or be unexported (golint)
  • Line 59: warning: exported method MessagePacker.ChunkAndWrite should have comment or be unexported (golint)
  • Line 280: warning: exported type Buffer should have comment or be unexported (golint)
  • Line 286: warning: exported function NewBuffer should have comment or be unexported (golint)
  • Line 294: warning: exported method Buffer.Bytes should have comment or be unexported (golint)
  • Line 298: warning: exported method Buffer.Len should have comment or be unexported (golint)
  • Line 302: warning: exported method Buffer.Reset should have comment or be unexported (golint)
  • Line 315: warning: exported method Buffer.WriteByte should have comment or be unexported (golint)
  • Line 322: warning: exported method Buffer.WriteTo should have comment or be unexported (golint)
  • Line 341: warning: exported method Buffer.ModWritePos should have comment or be unexported (golint)

• pkg/httpts/var.go
  • Line 12: warning: exported var SubSessionWriteChanSize should have comment or be unexported (golint)

• pkg/sdp/sdp.go
  • Line 14: warning: exported const ARtpMapEncodingNameH265 should have comment (or a comment on this block) or be unexported (golint)

• pkg/rtsp/client_command_session.go
  • Line 31: warning: exported type ClientCommandSessionType should have comment or be unexported (golint)
  • Line 39: warning: exported const CcstPullSession should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported type ClientCommandSessionOption should have comment or be unexported (golint)
  • Line 53: warning: exported type ClientCommandSessionObserver should have comment or be unexported (golint)
  • Line 66: warning: comment on exported type ClientCommandSession should be of the form "ClientCommandSession ..." (with optional leading article) (golint)
  • Line 90: warning: exported type ModClientCommandSessionOption should have comment or be unexported (golint)
  • Line 92: warning: exported function NewClientCommandSession should have comment or be unexported (golint)
  • Line 107: warning: comment on exported method ClientCommandSession.InitWithSdp should be of the form "InitWithSdp ..." (golint)
  • Line 112: warning: exported method ClientCommandSession.Do should have comment or be unexported (golint)
  • Line 144: warning: exported method ClientCommandSession.WriteInterleavedPacket should have comment or be unexported (golint)
  • Line 152: warning: exported method ClientCommandSession.RemoteAddr should have comment or be unexported (golint)
  • Line 159: warning: exported method ClientCommandSession.Url should have comment or be unexported (golint)
  • Line 163: warning: exported method ClientCommandSession.AppName should have comment or be unexported (golint)
  • Line 167: warning: exported method ClientCommandSession.StreamName should have comment or be unexported (golint)
  • Line 171: warning: exported method ClientCommandSession.RawQuery should have comment or be unexported (golint)
  • Line 175: warning: exported method ClientCommandSession.UniqueKey should have comment or be unexported (golint)

• pkg/rtmp/stream.go
  • Line 23: warning: exported type Stream should have comment or be unexported (golint)
  • Line 30: warning: exported function NewStream should have comment or be unexported (golint)
  • Line 57: warning: exported type StreamMsg should have comment or be unexported (golint)
  • Line 61: warning: comment on exported method StreamMsg.Grow should be of the form "Grow ..." (golint)
  • Line 66: warning: exported method StreamMsg.Len should have comment or be unexported (golint)
  • Line 70: warning: exported method StreamMsg.Flush should have comment or be unexported (golint)
  • Line 74: warning: exported method StreamMsg.Skip should have comment or be unexported (golint)
  • Line 78: warning: exported method StreamMsg.Reset should have comment or be unexported (golint)

• pkg/hls/fragment.go
  • Line 15: warning: exported type Fragment should have comment or be unexported (golint)
  • Line 19: warning: exported method Fragment.OpenFile should have comment or be unexported (golint)
  • Line 27: warning: exported method Fragment.WriteFile should have comment or be unexported (golint)
  • Line 32: warning: exported method Fragment.CloseFile should have comment or be unexported (golint)

• pkg/sdp/avconfig.go
  • Line 21: warning: exported function ParseAsc should have comment or be unexported (golint)
  • Line 36: warning: exported function ParseVpsSpsPps should have comment or be unexported (golint)
  • Line 64: warning: comment on exported function ParseSpsPps should be of the form "ParseSpsPps ..." (golint)

• pkg/rtprtcp/rtprtcp.go
  • Line 11: warning: exported const MaxRtpRtcpPacketSize should have comment or be unexported (golint)

• pkg/innertest/innertest.go
  • Line 83: warning: exported type RtspPullObserver should have comment or be unexported (golint)
  • Line 86: warning: exported method RtspPullObserver.OnSdp should have comment or be unexported (golint)
  • Line 90: warning: exported method RtspPullObserver.OnRtpPacket should have comment or be unexported (golint)
  • Line 93: warning: exported method RtspPullObserver.OnAvPacket should have comment or be unexported (golint)
  • Line 97: warning: exported function Entry should have comment or be unexported (golint)

• pkg/logic/http_notify.go
  • Line 27: warning: exported type PostTask should have comment or be unexported (golint)
  • Line 32: warning: exported type HttpNotify should have comment or be unexported (golint)
  • Line 38: warning: exported function NewHttpNotify should have comment or be unexported (golint)
  • Line 55: warning: exported method HttpNotify.NotifyServerStart should have comment or be unexported (golint)
  • Line 59: warning: exported method HttpNotify.NotifyUpdate should have comment or be unexported (golint)
  • Line 63: warning: exported method HttpNotify.NotifyPubStart should have comment or be unexported (golint)
  • Line 67: warning: exported method HttpNotify.NotifyPubStop should have comment or be unexported (golint)
  • Line 71: warning: exported method HttpNotify.NotifySubStart should have comment or be unexported (golint)
  • Line 75: warning: exported method HttpNotify.NotifySubStop should have comment or be unexported (golint)
  • Line 79: warning: exported method HttpNotify.NotifyRtmpConnect should have comment or be unexported (golint)
  • Line 85: warning: exported method HttpNotify.OnServerStart should have comment or be unexported (golint)
  • Line 89: warning: exported method HttpNotify.OnUpdate should have comment or be unexported (golint)
  • Line 93: warning: exported method HttpNotify.OnPubStart should have comment or be unexported (golint)
  • Line 97: warning: exported method HttpNotify.OnPubStop should have comment or be unexported (golint)
  • Line 101: warning: exported method HttpNotify.OnSubStart should have comment or be unexported (golint)
  • Line 105: warning: exported method HttpNotify.OnSubStop should have comment or be unexported (golint)
  • Line 109: warning: exported method HttpNotify.OnRtmpConnect should have comment or be unexported (golint)
  • Line 115: warning: exported method HttpNotify.RunLoop should have comment or be unexported (golint)

• app/lalserver/main.go
  • Line 67: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• app/demo/dispatch/config.go
  • Line 11: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
  • Line 26: warning: comment on exported type Server should be of the form "Server ..." (with optional leading article) (golint)

• pkg/mpegts/file_writer.go
  • Line 17: warning: exported type FileWriter should have comment or be unexported (golint)
  • Line 21: warning: exported method FileWriter.Create should have comment or be unexported (golint)
  • Line 34: warning: exported method FileWriter.Dispose should have comment or be unexported (golint)
  • Line 41: warning: exported method FileWriter.Name should have comment or be unexported (golint)

• pkg/httpflv/util.go
  • Line 13: warning: exported function ReadAllTagsFromFlvFile should have comment or be unexported (golint)
  • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• pkg/httpflv/var.go
  • Line 12: warning: exported var SubSessionWriteChanSize should have comment or be unexported (golint)

• pkg/rtsp/auth.go
  • Line 22: warning: exported const AuthTypeDigest should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported type Auth should have comment or be unexported (golint)
  • Line 37: warning: exported method Auth.FeedWwwAuthenticate should have comment or be unexported (golint)
  • Line 78: warning: comment on exported method Auth.MakeAuthorization should be of the form "MakeAuthorization ..." (golint)

• pkg/logic/group_manager.go
  • Line 13: warning: exported type IGroupCreator should have comment or be unexported (golint)
  • Line 17: warning: comment on exported type IGroupManager should be of the form "IGroupManager ..." (with optional leading article) (golint)
  • Line 56: warning: exported function NewSimpleGroupManager should have comment or be unexported (golint)
  • Line 63: warning: exported method SimpleGroupManager.GetOrCreateGroup should have comment or be unexported (golint)
  • Line 73: warning: exported method SimpleGroupManager.GetGroup should have comment or be unexported (golint)
  • Line 81: warning: exported method SimpleGroupManager.Iterate should have comment or be unexported (golint)
  • Line 89: warning: exported method SimpleGroupManager.Len should have comment or be unexported (golint)
  • Line 95: warning: comment on exported type ComplexGroupManager should be of the form "ComplexGroupManager ..." (with optional leading article) (golint)
  • Line 132: warning: exported function NewComplexGroupManager should have comment or be unexported (golint)
  • Line 140: warning: exported method ComplexGroupManager.GetOrCreateGroup should have comment or be unexported (golint)
  • Line 144: warning: exported method ComplexGroupManager.GetGroup should have comment or be unexported (golint)
  • Line 172: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 200: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 206: warning: exported method ComplexGroupManager.Iterate should have comment or be unexported (golint)
  • Line 225: warning: exported method ComplexGroupManager.Len should have comment or be unexported (golint)

• app/demo/analyseflv/analyseflv.go
  • Line 245: warning: comment on exported function SeiDelayMs should be of the form "SeiDelayMs ..." (golint)

• pkg/aac/aac.go
  • Line 32: warning: exported const AdtsHeaderLength should have comment (or a comment on this block) or be unexported (golint)
  • Line 42: warning: comment on exported type AscContext should be of the form "AscContext ..." (with optional leading article) (golint)
  • Line 60: warning: exported function NewAscContext should have comment or be unexported (golint)
  • Line 68: warning: comment on exported method AscContext.Unpack should be of the form "Unpack ..." (golint)
  • Line 86: warning: comment on exported method AscContext.Pack should be of the form "Pack ..." (golint)
  • Line 99: warning: comment on exported method AscContext.PackAdtsHeader should be of the form "PackAdtsHeader ..." (golint)
  • Line 114: warning: comment on exported method AscContext.PackToAdtsHeader should be of the form "PackToAdtsHeader ..." (golint)
  • Line 170: warning: exported method AscContext.GetSamplingFrequency should have comment or be unexported (golint)
  • Line 180: warning: exported type AdtsHeaderContext should have comment or be unexported (golint)
  • Line 186: warning: exported function NewAdtsHeaderContext should have comment or be unexported (golint)
  • Line 194: warning: comment on exported method AdtsHeaderContext.Unpack should be of the form "Unpack ..." (golint)
  • Line 215: warning: comment on exported function MakeAscWithAdtsHeader should be of the form "MakeAscWithAdtsHeader ..." (golint)

• pkg/base/http_api_t.go
  • Line 13: warning: exported const HttpApiVersion should have comment or be unexported (golint)
  • Line 16: warning: exported const ErrorCodeSucc should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported type HttpResponseBasic should have comment or be unexported (golint)
  • Line 31: warning: exported type LalInfo should have comment or be unexported (golint)
  • Line 40: warning: exported type ApiStatLalInfo should have comment or be unexported (golint)
  • Line 45: warning: exported type ApiStatAllGroup should have comment or be unexported (golint)
  • Line 52: warning: exported type ApiStatGroup should have comment or be unexported (golint)
  • Line 57: warning: exported type ApiCtrlStartPullReq should have comment or be unexported (golint)
  • Line 65: warning: exported type ApiCtrlKickOutSession should have comment or be unexported (golint)

• pkg/mpegts/pat.go
  • Line 15: warning: comment on exported type Pat should be of the form "Pat ..." (with optional leading article) (golint)
  • Line 49: warning: exported type PatProgramElement should have comment or be unexported (golint)
  • Line 54: warning: exported function ParsePat should have comment or be unexported (golint)
  • Line 82: warning: exported method Pat.SearchPid should have comment or be unexported (golint)

• pkg/remux/avpacket2rtmp.go
  • Line 23: warning: comment on exported type AvPacket2RtmpRemuxer should be of the form "AvPacket2RtmpRemuxer ..." (with optional leading article) (golint)
  • Line 38: warning: exported function NewAvPacket2RtmpRemuxer should have comment or be unexported (golint)
  • Line 46: warning: comment on exported method AvPacket2RtmpRemuxer.OnRtpPacket should be of the form "OnRtpPacket ..." (golint)
  • Line 50: warning: exported method AvPacket2RtmpRemuxer.OnSdp should have comment or be unexported (golint)
  • Line 53: warning: exported method AvPacket2RtmpRemuxer.OnAvPacket should have comment or be unexported (golint)
  • Line 57: warning: comment on exported method AvPacket2RtmpRemuxer.InitWithAvConfig should be of the form "InitWithAvConfig ..." (golint)
  • Line 116: warning: comment on exported method AvPacket2RtmpRemuxer.FeedAvPacket should be of the form "FeedAvPacket ..." (golint)

• app/demo/dispatch/dispatch.go
  • Line 52: warning: exported function OnPubStartHandler should have comment or be unexported (golint)
  • Line 91: warning: exported function OnPubStopHandler should have comment or be unexported (golint)
  • Line 110: warning: exported function OnSubStartHandler should have comment or be unexported (golint)
  • Line 164: warning: exported function OnSubStopHandler should have comment or be unexported (golint)
  • Line 175: warning: exported function OnUpdateHandler should have comment or be unexported (golint)

• pkg/rtsp/server_command_session.go
  • Line 27: warning: exported type ServerCommandSessionObserver should have comment or be unexported (golint)
  • Line 51: warning: exported type ServerCommandSession should have comment or be unexported (golint)
  • Line 63: warning: exported function NewServerCommandSession should have comment or be unexported (golint)
  • Line 77: warning: exported method ServerCommandSession.RunLoop should have comment or be unexported (golint)
  • Line 81: warning: exported method ServerCommandSession.Dispose should have comment or be unexported (golint)
  • Line 86: warning: exported method ServerCommandSession.FeedSdp should have comment or be unexported (golint)
  • Line 90: warning: comment on exported method ServerCommandSession.WriteInterleavedPacket should be of the form "WriteInterleavedPacket ..." (golint)
  • Line 99: warning: exported method ServerCommandSession.RemoteAddr should have comment or be unexported (golint)
  • Line 105: warning: exported method ServerCommandSession.UpdateStat should have comment or be unexported (golint)
  • Line 114: warning: exported method ServerCommandSession.GetStat should have comment or be unexported (golint)
  • Line 121: warning: exported method ServerCommandSession.IsAlive should have comment or be unexported (golint)
  • Line 137: warning: exported method ServerCommandSession.UniqueKey should have comment or be unexported (golint)

• pkg/base/error.go
  • Line 19: warning: exported var ErrShortBuffer should have comment or be unexported (golint)
  • Line 25: warning: exported var ErrSamplingFrequencyIndex should have comment or be unexported (golint)
  • Line 29: warning: exported var ErrAvc should have comment or be unexported (golint)
  • Line 34: warning: exported var ErrAddrEmpty should have comment or be unexported (golint)
  • Line 44: warning: exported var ErrHevc should have comment or be unexported (golint)
  • Line 48: warning: exported var ErrHls should have comment or be unexported (golint)
  • Line 53: warning: exported var ErrAmfInvalidType should have comment or be unexported (golint)
  • Line 63: warning: exported var ErrRtpRtcpShortBuffer should have comment or be unexported (golint)
  • Line 68: warning: exported var ErrRtsp should have comment or be unexported (golint)
  • Line 74: warning: exported var ErrSdp should have comment or be unexported (golint)
  • Line 79: warning: exported var ErrDupInStream should have comment or be unexported (golint)
  • Line 87: warning: exported function NewErrAmfInvalidType should have comment or be unexported (golint)
  • Line 91: warning: exported function NewErrRtmpShortBuffer should have comment or be unexported (golint)

• pkg/httpflv/server_sub_session.go
  • Line 23: warning: exported type SubSession should have comment or be unexported (golint)
  • Line 29: warning: exported function NewSubSession should have comment or be unexported (golint)
  • Line 55: warning: exported method SubSession.RunLoop should have comment or be unexported (golint)
  • Line 59: warning: exported method SubSession.Dispose should have comment or be unexported (golint)
  • Line 66: warning: exported method SubSession.WriteHttpResponseHeader should have comment or be unexported (golint)
  • Line 71: warning: exported method SubSession.WriteFlvHeader should have comment or be unexported (golint)
  • Line 76: warning: exported method SubSession.WriteTag should have comment or be unexported (golint)
  • Line 88: warning: exported method SubSession.UniqueKey should have comment or be unexported (golint)
  • Line 96: warning: exported method SubSession.Url should have comment or be unexported (golint)
  • Line 100: warning: exported method SubSession.AppName should have comment or be unexported (golint)
  • Line 104: warning: exported method SubSession.StreamName should have comment or be unexported (golint)
  • Line 108: warning: exported method SubSession.RawQuery should have comment or be unexported (golint)
  • Line 116: warning: exported method SubSession.UpdateStat should have comment or be unexported (golint)
  • Line 120: warning: exported method SubSession.GetStat should have comment or be unexported (golint)
  • Line 124: warning: exported method SubSession.IsAlive should have comment or be unexported (golint)

• pkg/rtsp/client_pull_session.go
  • Line 21: warning: exported type PullSessionObserver should have comment or be unexported (golint)
  • Line 25: warning: exported type PullSessionOption should have comment or be unexported (golint)
  • Line 38: warning: exported type PullSession should have comment or be unexported (golint)
  • Line 47: warning: exported type ModPullSessionOption should have comment or be unexported (golint)
  • Line 49: warning: exported function NewPullSession should have comment or be unexported (golint)
  • Line 125: warning: exported method PullSession.GetSdp should have comment or be unexported (golint)
  • Line 147: warning: comment on exported method PullSession.Url should be of the form "Url ..." (golint)
  • Line 152: warning: comment on exported method PullSession.AppName should be of the form "AppName ..." (golint)
  • Line 157: warning: comment on exported method PullSession.StreamName should be of the form "StreamName ..." (golint)
  • Line 162: warning: comment on exported method PullSession.RawQuery should be of the form "RawQuery ..." (golint)
  • Line 167: warning: comment on exported method PullSession.UniqueKey should be of the form "UniqueKey ..." (golint)
  • Line 172: warning: comment on exported method PullSession.GetStat should be of the form "GetStat ..." (golint)
  • Line 179: warning: comment on exported method PullSession.UpdateStat should be of the form "UpdateStat ..." (golint)
  • Line 184: warning: comment on exported method PullSession.IsAlive should be of the form "IsAlive ..." (golint)
  • Line 189: warning: comment on exported method PullSession.OnConnectResult should be of the form "OnConnectResult ..." (golint)
  • Line 194: warning: comment on exported method PullSession.OnDescribeResponse should be of the form "OnDescribeResponse ..." (golint)
  • Line 199: warning: comment on exported method PullSession.OnSetupWithConn should be of the form "OnSetupWithConn ..." (golint)
  • Line 204: warning: comment on exported method PullSession.OnSetupWithChannel should be of the form "OnSetupWithChannel ..." (golint)
  • Line 209: warning: comment on exported method PullSession.OnSetupResult should be of the form "OnSetupResult ..." (golint)
  • Line 214: warning: comment on exported method PullSession.OnInterleavedPacket should be of the form "OnInterleavedPacket ..." (golint)
  • Line 219: warning: comment on exported method PullSession.WriteInterleavedPacket should be of the form "WriteInterleavedPacket ..." (golint)

• pkg/rtmp/client_push_session.go
  • Line 13: warning: exported type PushSession should have comment or be unexported (golint)
  • Line 19: warning: exported type PushSessionOption should have comment or be unexported (golint)
  • Line 38: warning: exported type ModPushSessionOption should have comment or be unexported (golint)
  • Line 40: warning: exported function NewPushSession should have comment or be unexported (golint)
  • Line 57: warning: comment on exported method PushSession.Push should be of the form "Push ..." (golint)
  • Line 68: warning: comment on exported method PushSession.Flush should be of the form "Flush ..." (golint)
  • Line 92: warning: comment on exported method PushSession.Url should be of the form "Url ..." (golint)
  • Line 97: warning: comment on exported method PushSession.AppName should be of the form "AppName ..." (golint)
  • Line 102: warning: comment on exported method PushSession.StreamName should be of the form "StreamName ..." (golint)
  • Line 107: warning: comment on exported method PushSession.RawQuery should be of the form "RawQuery ..." (golint)
  • Line 112: warning: comment on exported method PushSession.UniqueKey should be of the form "UniqueKey ..." (golint)
  • Line 117: warning: comment on exported method PushSession.GetStat should be of the form "GetStat ..." (golint)
  • Line 122: warning: comment on exported method PushSession.UpdateStat should be of the form "UpdateStat ..." (golint)
  • Line 127: warning: comment on exported method PushSession.IsAlive should be of the form "IsAlive ..." (golint)

• pkg/logic/logic.go
  • Line 13: warning: exported type ILalServer should have comment or be unexported (golint)
  • Line 60: warning: exported type Option should have comment or be unexported (golint)
  • Line 68: warning: exported type ModOption should have comment or be unexported (golint)

• pkg/base/osexit.go
  • Line 18: warning: exported function OsExitAndWaitPressIfWindows should have comment or be unexported (golint)

• pkg/base/session.go
  • Line 27: warning: exported type IClientSession should have comment or be unexported (golint)
  • Line 41: warning: exported type IServerSession should have comment or be unexported (golint)
  • Line 50: warning: exported type IClientSessionLifecycle should have comment or be unexported (golint)
  • Line 81: warning: exported type IServerSessionLifecycle should have comment or be unexported (golint)
  • Line 93: warning: comment on exported type ISessionStat should be of the form "ISessionStat ..." (with optional leading article) (golint)
  • Line 137: warning: exported type IObject should have comment or be unexported (golint)

• app/demo/dispatch/datamanager/data.go
  • Line 18: warning: exported type DataManagerMemory should have comment or be unexported (golint)
  • Line 25: warning: exported function NewDataManagerMemory should have comment or be unexported (golint)
  • Line 61: warning: exported method DataManagerMemory.AddPub should have comment or be unexported (golint)
  • Line 71: warning: exported method DataManagerMemory.DelPub should have comment or be unexported (golint)
  • Line 81: warning: exported method DataManagerMemory.QueryPub should have comment or be unexported (golint)
  • Line 87: warning: exported method DataManagerMemory.UpdatePub should have comment or be unexported (golint)

• pkg/httpts/server_sub_session.go
  • Line 21: warning: exported type SubSession should have comment or be unexported (golint)
  • Line 26: warning: exported function NewSubSession should have comment or be unexported (golint)
  • Line 51: warning: exported method SubSession.RunLoop should have comment or be unexported (golint)
  • Line 55: warning: exported method SubSession.Dispose should have comment or be unexported (golint)
  • Line 62: warning: exported method SubSession.WriteHttpResponseHeader should have comment or be unexported (golint)
  • Line 75: warning: exported method SubSession.UniqueKey should have comment or be unexported (golint)
  • Line 83: warning: exported method SubSession.Url should have comment or be unexported (golint)
  • Line 87: warning: exported method SubSession.AppName should have comment or be unexported (golint)
  • Line 91: warning: exported method SubSession.StreamName should have comment or be unexported (golint)
  • Line 95: warning: exported method SubSession.RawQuery should have comment or be unexported (golint)
  • Line 103: warning: exported method SubSession.UpdateStat should have comment or be unexported (golint)
  • Line 107: warning: exported method SubSession.GetStat should have comment or be unexported (golint)
  • Line 111: warning: exported method SubSession.IsAlive should have comment or be unexported (golint)

• pkg/rtprtcp/rtcp.go
  • Line 86: warning: exported const RtcpPacketTypeSr should have comment (or a comment on this block) or be unexported (golint)
  • Line 95: warning: exported type RtcpHeader should have comment or be unexported (golint)
  • Line 103: warning: exported type Sr should have comment or be unexported (golint)
  • Line 112: warning: exported function ParseRtcpHeader should have comment or be unexported (golint)
  • Line 122: warning: comment on exported function ParseSr should be of the form "ParseSr ..." (golint)
  • Line 136: warning: comment on exported method RtcpHeader.PackTo should be of the form "PackTo ..." (golint)
  • Line 143: warning: exported method Sr.GetMiddleNtp should have comment or be unexported (golint)

• pkg/rtprtcp/rtcp_rr_producer.go
  • Line 15: warning: exported type RrProducer should have comment or be unexported (golint)
  • Line 34: warning: exported function NewRrProducer should have comment or be unexported (golint)
  • Line 43: warning: comment on exported method RrProducer.FeedRtpPacket should be of the form "FeedRtpPacket ..." (golint)
  • Line 65: warning: comment on exported method RrProducer.Produce should be of the form "Produce ..." (golint)

• pkg/rtmp/server.go
  • Line 17: warning: exported type ServerObserver should have comment or be unexported (golint)
  • Line 38: warning: exported type Server should have comment or be unexported (golint)
  • Line 44: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 51: warning: exported method Server.Listen should have comment or be unexported (golint)
  • Line 59: warning: exported method Server.RunLoop should have comment or be unexported (golint)
  • Line 69: warning: exported method Server.Dispose should have comment or be unexported (golint)
  • Line 98: warning: exported method Server.OnRtmpConnect should have comment or be unexported (golint)
  • Line 102: warning: exported method Server.OnNewRtmpPubSession should have comment or be unexported (golint)
  • Line 106: warning: exported method Server.OnNewRtmpSubSession should have comment or be unexported (golint)

• pkg/logic/group.go
  • Line 44: warning: exported type GroupObserver should have comment or be unexported (golint)
  • Line 48: warning: exported type Group should have comment or be unexported (golint)
  • Line 107: warning: exported function NewGroup should have comment or be unexported (golint)
  • Line 157: warning: exported method Group.RunLoop should have comment or be unexported (golint)
  • Line 161: warning: comment on exported method Group.Tick should be of the form "Tick ..." (golint)
  • Line 257: warning: comment on exported method Group.Dispose should be of the form "Dispose ..." (golint)
  • Line 308: warning: exported method Group.AddRtmpPubSession should have comment or be unexported (golint)
  • Line 344: warning: comment on exported method Group.AddRtspPubSession should be of the form "AddRtspPubSession ..." (golint)
  • Line 367: warning: exported method Group.AddRtmpPullSession should have comment or be unexported (golint)
  • Line 386: warning: exported method Group.DelRtmpPubSession should have comment or be unexported (golint)
  • Line 392: warning: exported method Group.DelRtspPubSession should have comment or be unexported (golint)
  • Line 398: warning: exported method Group.DelRtmpPullSession should have comment or be unexported (golint)
  • Line 406: warning: exported method Group.AddRtmpSubSession should have comment or be unexported (golint)
  • Line 423: warning: exported method Group.AddHttpflvSubSession should have comment or be unexported (golint)
  • Line 439: warning: comment on exported method Group.AddHttptsSubSession should be of the form "AddHttptsSubSession ..." (golint)
  • Line 453: warning: exported method Group.HandleNewRtspSubSessionDescribe should have comment or be unexported (golint)
  • Line 466: warning: exported method Group.HandleNewRtspSubSessionPlay should have comment or be unexported (golint)
  • Line 479: warning: exported method Group.AddRtmpPushSession should have comment or be unexported (golint)
  • Line 488: warning: exported method Group.DelRtmpSubSession should have comment or be unexported (golint)
  • Line 494: warning: exported method Group.DelHttpflvSubSession should have comment or be unexported (golint)
  • Line 500: warning: exported method Group.DelHttptsSubSession should have comment or be unexported (golint)
  • Line 506: warning: exported method Group.DelRtspSubSession should have comment or be unexported (golint)
  • Line 513: warning: exported method Group.DelRtmpPushSession should have comment or be unexported (golint)
  • Line 525: warning: exported method Group.IsTotalEmpty should have comment or be unexported (golint)
  • Line 531: warning: exported method Group.HasInSession should have comment or be unexported (golint)
  • Line 537: warning: exported method Group.HasOutSession should have comment or be unexported (golint)
  • Line 543: warning: exported method Group.IsHlsMuxerAlive should have comment or be unexported (golint)
  • Line 549: warning: exported method Group.StringifyDebugStats should have comment or be unexported (golint)
  • Line 554: warning: exported method Group.GetStat should have comment or be unexported (golint)
  • Line 606: warning: exported method Group.KickOutSession should have comment or be unexported (golint)
  • Line 648: warning: comment on exported method Group.StartPull should be of the form "StartPull ..." (golint)
  • Line 926: warning: comment on exported method Group.OnReadRtmpAvMsg should be of the form "OnReadRtmpAvMsg ..." (golint)
  • Line 933: warning: comment on exported method Group.OnRtpPacket should be of the form "OnRtpPacket ..." (golint)
  • Line 941: warning: comment on exported method Group.OnSdp should be of the form "OnSdp ..." (golint)
  • Line 950: warning: comment on exported method Group.OnAvPacket should be of the form "OnAvPacket ..." (golint)
  • Line 959: warning: comment on exported method Group.OnPatPmt should be of the form "OnPatPmt ..." (golint)
  • Line 970: warning: comment on exported method Group.OnTsPackets should be of the form "OnTsPackets ..." (golint)

• pkg/logic/server_manager.go
  • Line 31: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 39: warning: exported type ServerManager should have comment or be unexported (golint)
  • Line 59: warning: exported function NewServerManager should have comment or be unexported (golint)
  • Line 126: warning: exported method ServerManager.RunLoop should have comment or be unexported (golint)
  • Line 277: warning: exported method ServerManager.Dispose should have comment or be unexported (golint)
  • Line 299: warning: exported method ServerManager.StatLalInfo should have comment or be unexported (golint)
  • Line 310: warning: exported method ServerManager.StatAllGroup should have comment or be unexported (golint)
  • Line 320: warning: exported method ServerManager.StatGroup should have comment or be unexported (golint)
  • Line 332: warning: exported method ServerManager.CtrlStartPull should have comment or be unexported (golint)
  • Line 348: warning: exported method ServerManager.CtrlKickOutSession should have comment or be unexported (golint)
  • Line 372: warning: exported method ServerManager.OnRtmpConnect should have comment or be unexported (golint)
  • Line 392: warning: exported method ServerManager.OnNewRtmpPubSession should have comment or be unexported (golint)
  • Line 424: warning: exported method ServerManager.OnDelRtmpPubSession should have comment or be unexported (golint)
  • Line 448: warning: exported method ServerManager.OnNewRtmpSubSession should have comment or be unexported (golint)
  • Line 476: warning: exported method ServerManager.OnDelRtmpSubSession should have comment or be unexported (golint)
  • Line 501: warning: exported method ServerManager.OnNewHttpflvSubSession should have comment or be unexported (golint)
  • Line 529: warning: exported method ServerManager.OnDelHttpflvSubSession should have comment or be unexported (golint)
  • Line 553: warning: exported method ServerManager.OnNewHttptsSubSession should have comment or be unexported (golint)
  • Line 583: warning: exported method ServerManager.OnDelHttptsSubSession should have comment or be unexported (golint)
  • Line 609: warning: exported method ServerManager.OnNewRtspSessionConnect should have comment or be unexported (golint)
  • Line 613: warning: exported method ServerManager.OnDelRtspSession should have comment or be unexported (golint)
  • Line 617: warning: exported method ServerManager.OnNewRtspPubSession should have comment or be unexported (golint)
  • Line 647: warning: exported method ServerManager.OnDelRtspPubSession should have comment or be unexported (golint)
  • Line 672: warning: exported method ServerManager.OnNewRtspSubSessionDescribe should have comment or be unexported (golint)
  • Line 679: warning: exported method ServerManager.OnNewRtspSubSessionPlay should have comment or be unexported (golint)
  • Line 707: warning: exported method ServerManager.OnDelRtspSubSession should have comment or be unexported (golint)
  • Line 733: warning: exported method ServerManager.CreateGroup should have comment or be unexported (golint)
  • Line 739: warning: exported method ServerManager.CleanupHlsIfNeeded should have comment or be unexported (golint)
  • Line 770: warning: exported method ServerManager.Config should have comment or be unexported (golint)
  • Line 774: warning: exported method ServerManager.GetGroup should have comment or be unexported (golint)

• app/demo/calcrtmpdelay/calcrtmpdelay.go
  • Line 29: warning: exported type PullType should have comment or be unexported (golint)
  • Line 32: warning: exported const PullTypeUnknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported method PullType.Readable should have comment or be unexported (golint)

• pkg/remux/gop_cache.go
  • Line 16: warning: comment on exported type GopCache should be of the form "GopCache ..." (with optional leading article) (golint)
  • Line 69: warning: comment on exported function NewGopCache should be of the form "NewGopCache ..." (golint)
  • Line 84: warning: exported type LazyGet should have comment or be unexported (golint)
  • Line 86: warning: exported method GopCache.Feed should have comment or be unexported (golint)
  • Line 115: warning: comment on exported method GopCache.GetGopCount should be of the form "GetGopCount ..." (golint)
  • Line 120: warning: exported method GopCache.GetGopDataAt should have comment or be unexported (golint)
  • Line 127: warning: exported method GopCache.Clear should have comment or be unexported (golint)
  • Line 161: warning: exported type Gop should have comment or be unexported (golint)
  • Line 165: warning: exported method Gop.Feed should have comment or be unexported (golint)
  • Line 169: warning: exported method Gop.Clear should have comment or be unexported (golint)

• pkg/httpflv/httpflv.go
  • Line 12: warning: exported const TagHeaderSize should have comment (or a comment on this block) or be unexported (golint)
  • Line 19: warning: exported const TagTypeMetadata should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: exported const AvcKeyFrame should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported const AvcPacketTypeSeqHeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 54: warning: exported const SoundFormatAac should have comment (or a comment on this block) or be unexported (golint)

• pkg/httpflv/tag.go
  • Line 17: warning: exported type TagHeader should have comment or be unexported (golint)
  • Line 24: warning: exported type Tag should have comment or be unexported (golint)
  • Line 29: warning: comment on exported method Tag.Payload should be of the form "Payload ..." (golint)
  • Line 35: warning: exported method Tag.IsMetadata should have comment or be unexported (golint)
  • Line 39: warning: exported method Tag.IsAvc should have comment or be unexported (golint)
  • Line 43: warning: exported method Tag.IsHevc should have comment or be unexported (golint)
  • Line 47: warning: exported method Tag.IsAvcKeySeqHeader should have comment or be unexported (golint)
  • Line 51: warning: exported method Tag.IsHevcKeySeqHeader should have comment or be unexported (golint)
  • Line 55: warning: comment on exported method Tag.IsVideoKeySeqHeader should be of the form "IsVideoKeySeqHeader ..." (golint)
  • Line 60: warning: exported method Tag.IsAvcKeyNalu should have comment or be unexported (golint)
  • Line 64: warning: exported method Tag.IsHevcKeyNalu should have comment or be unexported (golint)
  • Line 68: warning: comment on exported method Tag.IsVideoKeyNalu should be of the form "IsVideoKeyNalu ..." (golint)
  • Line 73: warning: exported method Tag.IsAacSeqHeader should have comment or be unexported (golint)
  • Line 83: warning: exported method Tag.ModTagTimestamp should have comment or be unexported (golint)
  • Line 90: warning: comment on exported function PackHttpflvTag should be of the form "PackHttpflvTag ..." (golint)

• pkg/hls/server_handler.go
  • Line 19: warning: exported type ServerHandler should have comment or be unexported (golint)
  • Line 23: warning: exported function NewServerHandler should have comment or be unexported (golint)
  • Line 38: warning: exported method ServerHandler.ServeHTTPWithUrlCtx should have comment or be unexported (golint)

• pkg/httpflv/flv_file_reader.go
  • Line 15: warning: exported type FlvFileReader should have comment or be unexported (golint)
  • Line 20: warning: exported method FlvFileReader.Open should have comment or be unexported (golint)
  • Line 25: warning: exported method FlvFileReader.ReadFlvHeader should have comment or be unexported (golint)
  • Line 33: warning: exported method FlvFileReader.ReadTag should have comment or be unexported (golint)
  • Line 42: warning: exported method FlvFileReader.Dispose should have comment or be unexported (golint)

• app/demo/pullrtmp2pushrtmp/stream_exist.go
  • Line 19: warning: comment on exported function StreamExist should be of the form "StreamExist ..." (golint)

• pkg/mpegts/mpegts.go
  • Line 13: warning: comment on exported var FixedFragmentHeader should be of the form "FixedFragmentHeader ..." (golint)
  • Line 73: warning: comment on exported var FixedFragmentHeaderHevc should be of the form "FixedFragmentHeaderHevc ..." (golint)

• pkg/base/stat.go
  • Line 12: warning: comment on exported const AudioCodecAac should be of the form "AudioCodecAac ..." (golint)
  • Line 15: warning: comment on exported const VideoCodecAvc should be of the form "VideoCodecAvc ..." (golint)
  • Line 17: warning: exported const VideoCodecHevc should have comment (or a comment on this block) or be unexported (golint)
  • Line 19: warning: comment on exported const ProtocolRtmp should be of the form "ProtocolRtmp ..." (golint)
  • Line 26: warning: exported type StatGroup should have comment or be unexported (golint)
  • Line 37: warning: exported type StatPub should have comment or be unexported (golint)
  • Line 41: warning: exported type StatSub should have comment or be unexported (golint)
  • Line 45: warning: exported type StatPull should have comment or be unexported (golint)
  • Line 49: warning: exported type StatSession should have comment or be unexported (golint)
  • Line 62: warning: exported function StatSession2Pub should have comment or be unexported (golint)
  • Line 75: warning: exported function StatSession2Sub should have comment or be unexported (golint)
  • Line 88: warning: exported function StatSession2Pull should have comment or be unexported (golint)

• pkg/base/var.go
  • Line 14: warning: exported var Logger should have comment or be unexported (golint)

• pkg/logic/simple_auth.go
  • Line 19: warning: exported function SimpleAuthCalcSecret should have comment or be unexported (golint)
  • Line 29: warning: exported type SimpleAuthCtx should have comment or be unexported (golint)
  • Line 33: warning: exported function NewSimpleAuthCtx should have comment or be unexported (golint)
  • Line 39: warning: exported method SimpleAuthCtx.OnPubStart should have comment or be unexported (golint)
  • Line 47: warning: exported method SimpleAuthCtx.OnSubStart should have comment or be unexported (golint)
  • Line 57: warning: exported method SimpleAuthCtx.OnHls should have comment or be unexported (golint)

• pkg/hls/hls.go
  • Line 41: warning: exported function SplitFragment2TsPackets should have comment or be unexported (golint)

• pkg/hls/path_strategy.go
  • Line 23: warning: exported type RequestInfo should have comment or be unexported (golint)
  • Line 28: warning: exported type IPathStrategy should have comment or be unexported (golint)
  • Line 33: warning: comment on exported type IPathRequestStrategy should be of the form "IPathRequestStrategy ..." (with optional leading article) (golint)
  • Line 46: warning: comment on exported type IPathWriteStrategy should be of the form "IPathWriteStrategy ..." (with optional leading article) (golint)
  • Line 80: warning: comment on exported type DefaultPathStrategy should be of the form "DefaultPathStrategy ..." (with optional leading article) (golint)
  • Line 107: warning: comment on exported method DefaultPathStrategy.GetRequestInfo should be of the form "GetRequestInfo ..." (golint)
  • Line 139: warning: comment on exported method DefaultPathStrategy.GetMuxerOutPath should be of the form "GetMuxerOutPath ..." (golint)
  • Line 144: warning: exported method DefaultPathStrategy.GetLiveM3u8FileName should have comment or be unexported (golint)
  • Line 148: warning: exported method DefaultPathStrategy.GetRecordM3u8FileName should have comment or be unexported (golint)
  • Line 152: warning: exported method DefaultPathStrategy.GetTsFileNameWithPath should have comment or be unexported (golint)
  • Line 156: warning: exported method DefaultPathStrategy.GetTsFileName should have comment or be unexported (golint)

• pkg/hls/queue.go
  • Line 16: warning: comment on exported type Queue should be of the form "Queue ..." (with optional leading article) (golint)
  • Line 28: warning: exported type IQueueObserver should have comment or be unexported (golint)
  • Line 36: warning: comment on exported function NewQueue should be of the form "NewQueue ..." (golint)
  • Line 48: warning: comment on exported method Queue.Push should be of the form "Push ..." (golint)

• pkg/mpegts/ts_packet_header.go
  • Line 15: warning: comment on exported type TsPacketHeader should be of the form "TsPacketHeader ..." (with optional leading article) (golint)
  • Line 37: warning: comment on exported type TsPacketAdaptation should be of the form "TsPacketAdaptation ..." (with optional leading article) (golint)
  • Line 57: warning: comment on exported function ParseTsPacketHeader should be of the form "ParseTsPacketHeader ..." (golint)
  • Line 72: warning: comment on exported function ParseTsPacketAdaptation should be of the form "ParseTsPacketAdaptation ..." (golint)

• pkg/rtprtcp/rtp_unpacker_aac.go
  • Line 16: warning: exported type RtpUnpackerAac should have comment or be unexported (golint)
  • Line 22: warning: exported function NewRtpUnpackerAac should have comment or be unexported (golint)
  • Line 30: warning: exported method RtpUnpackerAac.CalcPositionIfNeeded should have comment or be unexported (golint)
  • Line 34: warning: exported method RtpUnpackerAac.TryUnpackOne should have comment or be unexported (golint)

• pkg/rtmp/chunk_divider.go
  • Line 18: warning: exported type ChunkDivider should have comment or be unexported (golint)
  • Line 26: warning: comment on exported function Message2Chunks should be of the form "Message2Chunks ..." (golint)
  • Line 31: warning: comment on exported method ChunkDivider.Message2Chunks should be of the form "Message2Chunks ..." (golint)

• pkg/rtmp/client_session.go
  • Line 26: warning: comment on exported type ClientSession should be of the form "ClientSession ..." (with optional leading article) (golint)
  • Line 56: warning: exported type ClientSessionType should have comment or be unexported (golint)
  • Line 59: warning: exported const CstPullSession should have comment (or a comment on this block) or be unexported (golint)
  • Line 63: warning: exported type ClientSessionOption should have comment or be unexported (golint)
  • Line 86: warning: exported type ModClientSessionOption should have comment or be unexported (golint)
  • Line 88: warning: comment on exported function NewClientSession should be of the form "NewClientSession ..." (golint)
  • Line 129: warning: comment on exported method ClientSession.Do should be of the form "Do ..." (golint)
  • Line 154: warning: exported method ClientSession.Flush should have comment or be unexported (golint)
  • Line 179: warning: exported method ClientSession.Url should have comment or be unexported (golint)
  • Line 183: warning: exported method ClientSession.AppName should have comment or be unexported (golint)
  • Line 187: warning: exported method ClientSession.StreamName should have comment or be unexported (golint)
  • Line 191: warning: exported method ClientSession.RawQuery should have comment or be unexported (golint)
  • Line 195: warning: exported method ClientSession.UniqueKey should have comment or be unexported (golint)
  • Line 199: warning: exported method ClientSession.GetStat should have comment or be unexported (golint)
  • Line 206: warning: exported method ClientSession.UpdateStat should have comment or be unexported (golint)
  • Line 221: warning: exported method ClientSession.IsAlive should have comment or be unexported (golint)

• pkg/rtprtcp/rtp_packer_payload_avc_hevc.go
  • Line 17: warning: exported type RtpPackerPayloadAvcHevcType should have comment or be unexported (golint)
  • Line 20: warning: exported const RtpPackerPayloadAvcHevcTypeNalu should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported type RtpPackerPayloadAvcHevcOption should have comment or be unexported (golint)
  • Line 33: warning: exported type RtpPackerPayloadAvcHevc should have comment or be unexported (golint)
  • Line 38: warning: exported type ModRtpPackerPayloadAvcHevcOption should have comment or be unexported (golint)
  • Line 40: warning: exported function NewRtpPackerPayloadAvc should have comment or be unexported (golint)
  • Line 44: warning: exported function NewRtpPackerPayloadHevc should have comment or be unexported (golint)
  • Line 48: warning: exported function NewRtpPackerPayloadAvcHevc should have comment or be unexported (golint)
  • Line 59: warning: comment on exported method RtpPackerPayloadAvcHevc.Pack should be of the form "Pack ..." (golint)
  • Line 101: warning: exported method RtpPackerPayloadAvcHevc.PackNal should have comment or be unexported (golint)

• pkg/rtsp/avpacket_queue.go
  • Line 25: warning: exported type OnAvPacket should have comment or be unexported (golint)
  • Line 27: warning: exported type AvPacketQueue should have comment or be unexported (golint)
  • Line 35: warning: exported function NewAvPacketQueue should have comment or be unexported (golint)
  • Line 45: warning: comment on exported method AvPacketQueue.Feed should be of the form "Feed ..." (golint)
  • Line 113: warning: exported method AvPacketQueue.PopAllByForce should have comment or be unexported (golint)

• pkg/hls/m3u8.go
  • Line 62: warning: comment on exported function CalcM3u8Duration should be of the form "CalcM3u8Duration ..." (golint)

• pkg/mpegts/pmt.go
  • Line 16: warning: comment on exported type Pmt should be of the form "Pmt ..." (with optional leading article) (golint)
  • Line 58: warning: exported type PmtProgramElement should have comment or be unexported (golint)
  • Line 64: warning: exported function ParsePmt should have comment or be unexported (golint)
  • Line 103: warning: exported method Pmt.SearchPid should have comment or be unexported (golint)

• pkg/sdp/parse_logic.go
  • Line 20: warning: exported type LogicContext should have comment or be unexported (golint)
  • Line 44: warning: exported method LogicContext.IsAudioPayloadTypeOrigin should have comment or be unexported (golint)
  • Line 48: warning: exported method LogicContext.IsVideoPayloadTypeOrigin should have comment or be unexported (golint)
  • Line 52: warning: exported method LogicContext.IsPayloadTypeOrigin should have comment or be unexported (golint)
  • Line 56: warning: exported method LogicContext.IsAudioUnpackable should have comment or be unexported (golint)
  • Line 60: warning: exported method LogicContext.IsVideoUnpackable should have comment or be unexported (golint)
  • Line 65: warning: exported method LogicContext.IsAudioUri should have comment or be unexported (golint)
  • Line 69: warning: exported method LogicContext.IsVideoUri should have comment or be unexported (golint)
  • Line 73: warning: exported method LogicContext.HasAudioAControl should have comment or be unexported (golint)
  • Line 77: warning: exported method LogicContext.HasVideoAControl should have comment or be unexported (golint)
  • Line 81: warning: exported method LogicContext.MakeAudioSetupUri should have comment or be unexported (golint)
  • Line 85: warning: exported method LogicContext.MakeVideoSetupUri should have comment or be unexported (golint)
  • Line 89: warning: exported method LogicContext.GetAudioPayloadTypeBase should have comment or be unexported (golint)
  • Line 93: warning: exported method LogicContext.GetVideoPayloadTypeBase should have comment or be unexported (golint)
  • Line 104: warning: exported function ParseSdp2LogicContext should have comment or be unexported (golint)

• app/demo/pullrtsp2pushrtsp/pullrtsp2pushrtsp.go
  • Line 29: warning: exported type RtspTunnel should have comment or be unexported (golint)
  • Line 46: warning: exported function NewRtspTunnel should have comment or be unexported (golint)
  • Line 135: warning: exported method RtspTunnel.OnRtpPacket should have comment or be unexported (golint)
  • Line 139: warning: exported method RtspTunnel.OnSdp should have comment or be unexported (golint)
  • Line 143: warning: exported method RtspTunnel.OnAvPacket should have comment or be unexported (golint)

• pkg/rtprtcp/rtp_unpack_container.go
  • Line 11: warning: exported type RtpPacketListItem should have comment or be unexported (golint)
  • Line 16: warning: exported type RtpPacketList should have comment or be unexported (golint)
  • Line 21: warning: exported type RtpUnpackContainer should have comment or be unexported (golint)
  • Line 31: warning: exported function NewRtpUnpackContainer should have comment or be unexported (golint)
  • Line 38: warning: comment on exported method RtpUnpackContainer.Feed should be of the form "Feed ..." (golint)

• pkg/remux/rtmp2flv.go
  • Line 16: warning: comment on exported function RtmpMsg2FlvTag should be of the form "RtmpMsg2FlvTag ..." (golint)
  • Line 35: warning: exported method LazyRtmpMsg2FlvTag.Init should have comment or be unexported (golint)
  • Line 39: warning: exported method LazyRtmpMsg2FlvTag.Get should have comment or be unexported (golint)

• pkg/logic/http_server_handler.go
  • Line 21: warning: exported type HttpServerHandlerObserver should have comment or be unexported (golint)
  • Line 35: warning: exported type HttpServerHandler should have comment or be unexported (golint)
  • Line 39: warning: exported function NewHttpServerHandler should have comment or be unexported (golint)
  • Line 45: warning: exported method HttpServerHandler.ServeSubSession should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!