Report for github.com/qiniu/hdq
A+ Excellent! Found 2 issues across 3 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint33%
Golint is a linter for Go source code.
-
-
hdq/hdq.go
- Line 25: warning: exported var ErrNotFound should have comment or be unexported (golint)
- Line 40: warning: exported type NodeEnum should have comment or be unexported (golint)
- Line 48: warning: exported type NodeSet should have comment or be unexported (golint)
- Line 53: warning: exported method NodeSet.Ok should have comment or be unexported (golint)
- Line 57: warning: exported method NodeSet.CachedLen should have comment or be unexported (golint)
- Line 64: warning: exported method NodeSet.Cache should have comment or be unexported (golint)
- Line 75: warning: exported method NodeSet.ForEach should have comment or be unexported (golint)
- Line 99: warning: exported function Source should have comment or be unexported (golint)
- Line 125: warning: exported function Nodes should have comment or be unexported (golint)
- Line 158: warning: exported method NodeSet.Any should have comment or be unexported (golint)
- Line 212: warning: exported method NodeSet.Child should have comment or be unexported (golint)
- Line 216: warning: exported method NodeSet.ChildN should have comment or be unexported (golint)
- Line 226: warning: exported method NodeSet.Parent should have comment or be unexported (golint)
- Line 230: warning: exported method NodeSet.ParentN should have comment or be unexported (golint)
- Line 234: warning: exported method NodeSet.One should have comment or be unexported (golint)
- Line 274: warning: exported method NodeSet.NextSibling should have comment or be unexported (golint)
- Line 281: warning: exported method NodeSet.PrevSibling should have comment or be unexported (golint)
- Line 302: warning: exported method NodeSet.PrevSiblings should have comment or be unexported (golint)
- Line 326: warning: exported method NodeSet.NextSiblings should have comment or be unexported (golint)
- Line 350: warning: exported method NodeSet.FirstChild should have comment or be unexported (golint)
- Line 357: warning: exported method NodeSet.FirstTextChild should have comment or be unexported (golint)
- Line 361: warning: exported method NodeSet.FirstElementChild should have comment or be unexported (golint)
- Line 382: warning: exported method NodeSet.LastChild should have comment or be unexported (golint)
- Line 389: warning: exported method NodeSet.LastTextChild should have comment or be unexported (golint)
- Line 393: warning: exported method NodeSet.LastElementChild should have comment or be unexported (golint)
- Line 413: warning: exported method NodeSet.Match should have comment or be unexported (golint)
- Line 442: warning: exported method NodeSet.ChildrenAsText should have comment or be unexported (golint)
- Line 451: warning: exported method NodeSet.CollectOne should have comment or be unexported (golint)
- Line 474: warning: exported method NodeSet.Collect should have comment or be unexported (golint)
-
-
hdq/hdq_helper.go
- Line 32: warning: exported var ReqHeaderProc should have comment or be unexported (golint)
- Line 386: warning: exported method NodeSet.Attr__0 should have comment or be unexported (golint)
- Line 386: warning: don't use underscores in Go names; method Attr__0 should be Attr0 (golint)
- Line 390: warning: exported method NodeSet.Attr__1 should have comment or be unexported (golint)
- Line 390: warning: don't use underscores in Go names; method Attr__1 should be Attr1 (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!