Report for github.com/qiniu/qshell
A Great! Found 38 issues across 45 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint17%
Golint is a linter for Go source code.
-
-
qshell/cmd/qupload2.go
- Line 62: warning: comment on exported function QiniuUpload2 should be of the form "QiniuUpload2 ..." (golint)
-
-
qshell/cmd/root.go
- Line 20: warning: comment on exported var DebugFlag should be of the form "DebugFlag ..." (golint)
- Line 22: warning: exported var DeepDebugInfo should have comment or be unexported (golint)
- Line 24: warning: comment on exported var VersionFlag should be of the form "VersionFlag ..." (golint)
- Line 31: warning: don't use underscores in Go names; const bash_completion_func should be bashCompletionFunc (golint)
- Line 61: warning: comment on exported var RootCmd should be of the form "RootCmd ..." (golint)
- Line 71: warning: exported function OnInitialize should have comment or be unexported (golint)
-
-
qshell/cmd/version.go
- Line 25: warning: comment on exported function UserAgent should be of the form "UserAgent ..." (golint)
-
-
qshell/iqshell/list_bucket.go
- Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 53: warning: comment on exported method BucketManager.ListFiles should be of the form "ListFiles ..." (golint)
- Line 64: warning: exported method BucketManager.ListBucket2 should have comment or be unexported (golint)
-
-
qshell/iqshell/m3u8.go
- Line 19: warning: exported method BucketManager.M3u8FileList should have comment or be unexported (golint)
- Line 79: warning: exported method BucketManager.DownloadLink should have comment or be unexported (golint)
- Line 116: warning: comment on exported method BucketManager.M3u8ReplaceDomain should be of the form "M3u8ReplaceDomain ..." (golint)
-
-
qshell/iqshell/qupload.go
- Line 58: warning: exported const DEFAULT_PUT_THRESHOLD should have comment (or a comment on this block) or be unexported (golint)
- Line 63: warning: exported type UploadInfo should have comment or be unexported (golint)
- Line 67: warning: exported type UploadConfig should have comment or be unexported (golint)
- Line 114: warning: exported method UploadConfig.Check should have comment or be unexported (golint)
- Line 125: warning: exported method UploadConfig.GetUpHost should have comment or be unexported (golint)
- Line 132: warning: exported method UploadConfig.JobId should have comment or be unexported (golint)
- Line 137: warning: exported method UploadConfig.GetLogLevel should have comment or be unexported (golint)
- Line 156: warning: exported method UploadConfig.GetLogRotate should have comment or be unexported (golint)
- Line 164: warning: exported method UploadConfig.HitByPathPrefixes should have comment or be unexported (golint)
- Line 184: warning: exported method UploadConfig.HitByFilePrefixes should have comment or be unexported (golint)
- Line 204: warning: exported method UploadConfig.HitByFixesString should have comment or be unexported (golint)
- Line 224: warning: exported method UploadConfig.HitBySuffixes should have comment or be unexported (golint)
- Line 242: warning: exported method UploadConfig.CacheFileNameAndCount should have comment or be unexported (golint)
- Line 262: warning: exported method UploadConfig.DefaultLogFile should have comment or be unexported (golint)
- Line 273: warning: exported method UploadConfig.PrepareLogger should have comment or be unexported (golint)
- Line 306: warning: exported method UploadConfig.UploadToken should have comment or be unexported (golint)
- Line 332: warning: comment on exported type FileExporter should be of the form "FileExporter ..." (with optional leading article) (golint)
- Line 345: warning: exported function NewFileExporter should have comment or be unexported (golint)
- Line 387: warning: exported method FileExporter.WriteToFailedWriter should have comment or be unexported (golint)
- Line 396: warning: exported method FileExporter.WriteToSuccessWriter should have comment or be unexported (golint)
- Line 405: warning: exported method FileExporter.WriteToOverwriter should have comment or be unexported (golint)
- Line 414: warning: exported method FileExporter.Close should have comment or be unexported (golint)
- Line 420: warning: exported method FileExporter.FlushWriter should have comment or be unexported (golint)
- Line 444: warning: comment on exported function QiniuUpload should be of the form "QiniuUpload ..." (golint)
-
-
qshell/cmd/ip.go
- Line 13: warning: comment on exported const TAOBAO_IP_QUERY should be of the form "TAOBAO_IP_QUERY ..." (golint)
- Line 17: warning: comment on exported type IpInfo should be of the form "IpInfo ..." (with optional leading article) (golint)
- Line 23: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 27: warning: comment on exported type IpData should be of the form "IpData ..." (with optional leading article) (golint)
- Line 44: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 60: warning: comment on exported function IpQuery should be of the form "IpQuery ..." (golint)
-
-
qshell/iqshell/config.go
- Line 10: warning: comment on exported const STATUS_OK should be of the form "STATUS_OK ..." (golint)
- Line 12: warning: comment on exported const STATUS_ERROR should be of the form "STATUS_ERROR ..." (golint)
- Line 14: warning: comment on exported const STATUS_HALT should be of the form "STATUS_HALT ..." (golint)
- Line 19: warning: comment on exported const BLOCK_BITS should be of the form "BLOCK_BITS ..." (golint)
- Line 22: warning: comment on exported const BLOCK_SIZE should be of the form "BLOCK_SIZE ..." (golint)
- Line 27: warning: comment on exported var PATH_ROOT should be of the form "PATH_ROOT ..." (golint)
- Line 30: warning: comment on exported var PATH_ACCDB should be of the form "PATH_ACCDB ..." (golint)
- Line 33: warning: comment on exported var PATH_ACC should be of the form "PATH_ACC ..." (golint)
- Line 36: warning: comment on exported var HOST_UP should be of the form "HOST_UP ..." (golint)
- Line 39: warning: comment on exported var HOST_RS should be of the form "HOST_RS ..." (golint)
- Line 42: warning: comment on exported var HOST_RSF should be of the form "HOST_RSF ..." (golint)
- Line 45: warning: comment on exported var HOST_IO should be of the form "HOST_IO ..." (golint)
- Line 48: warning: comment on exported var HOST_API should be of the form "HOST_API ..." (golint)
- Line 51: warning: comment on exported var HOST_UC should be of the form "HOST_UC ..." (golint)
- Line 54: warning: comment on exported var ACCESS_KEY should be of the form "ACCESS_KEY ..." (golint)
- Line 56: warning: exported var SECRET_KEY should have comment or be unexported (golint)
- Line 59: warning: exported function UpHostBindPFlag should have comment or be unexported (golint)
- Line 65: warning: comment on exported function AccessKey should be of the form "AccessKey ..." (golint)
- Line 70: warning: comment on exported function SecretKey should be of the form "SecretKey ..." (golint)
- Line 75: warning: comment on exported function RootPath should be of the form "RootPath ..." (golint)
- Line 84: warning: comment on exported function SetRootPath should be of the form "SetRootPath ..." (golint)
- Line 91: warning: comment on exported function AccDBPath should be of the form "AccDBPath ..." (golint)
- Line 100: warning: comment on exported function SetAccDBPath should be of the form "SetAccDBPath ..." (golint)
- Line 107: warning: comment on exported function SetDefaultAccDBPath should be of the form "SetDefaultAccDBPath ..." (golint)
- Line 114: warning: exported function AccPath should have comment or be unexported (golint)
- Line 122: warning: exported function SetAccPath should have comment or be unexported (golint)
- Line 128: warning: exported function SetDefaultAccPath should have comment or be unexported (golint)
- Line 134: warning: exported function OldAccPath should have comment or be unexported (golint)
- Line 135: warning: don't use underscores in Go names; var acc_path should be accPath (golint)
- Line 142: warning: exported function UpHost should have comment or be unexported (golint)
- Line 150: warning: exported function SetUpHost should have comment or be unexported (golint)
- Line 156: warning: exported function SetDefaultUpHost should have comment or be unexported (golint)
- Line 162: warning: exported function RsHost should have comment or be unexported (golint)
- Line 170: warning: exported function SetRsHost should have comment or be unexported (golint)
- Line 176: warning: exported function SetDefaultRsHost should have comment or be unexported (golint)
- Line 182: warning: exported function RsfHost should have comment or be unexported (golint)
- Line 190: warning: exported function SetRsfHost should have comment or be unexported (golint)
- Line 196: warning: exported function SetDefaultRsfHost should have comment or be unexported (golint)
- Line 202: warning: exported function IoHost should have comment or be unexported (golint)
- Line 210: warning: exported function SetIoHost should have comment or be unexported (golint)
- Line 216: warning: exported function SetDefaultIoHost should have comment or be unexported (golint)
- Line 222: warning: exported function ApiHost should have comment or be unexported (golint)
- Line 230: warning: exported function SetApiHost should have comment or be unexported (golint)
- Line 236: warning: exported function SetDefaultApiHost should have comment or be unexported (golint)
- Line 242: warning: exported function UcHost should have comment or be unexported (golint)
- Line 250: warning: exported function SetUcHost should have comment or be unexported (golint)
- Line 256: warning: exported function SetDefaultUcHost should have comment or be unexported (golint)
- Line 262: warning: comment on exported type FetchItem should be of the form "FetchItem ..." (with optional leading article) (golint)
-
-
qshell/cmd/user.go
- Line 60: warning: comment on exported function ChUser should be of the form "ChUser ..." (golint)
- Line 77: warning: comment on exported function ListUser should be of the form "ListUser ..." (golint)
- Line 87: warning: comment on exported function CleanUser should be of the form "CleanUser ..." (golint)
- Line 97: warning: comment on exported function RmUser should be of the form "RmUser ..." (golint)
- Line 108: warning: comment on exported function LookUp should be of the form "LookUp ..." (golint)
-
-
qshell/iqshell/alioss_list_bucket.go
- Line 11: warning: comment on exported type AliListBucket should be of the form "AliListBucket ..." (with optional leading article) (golint)
- Line 20: warning: comment on exported method AliListBucket.ListBucket should be of the form "ListBucket ..." (golint)
- Line 21: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
-
-
qshell/iqshell/cdn.go
- Line 11: warning: comment on exported function GetCdnManager should be of the form "GetCdnManager ..." (golint)
-
-
qshell/iqshell/dir_cache.go
- Line 15: warning: comment on exported function DirCache should be of the form "DirCache ..." (golint)
-
-
qshell/iqshell/log.go
- Line 7: warning: exported type BeeLogConfig should have comment or be unexported (golint)
- Line 14: warning: exported method BeeLogConfig.ToJson should have comment or be unexported (golint)
-
-
qshell/cmd/rsbatch.go
- Line 20: warning: exported const BATCH_ALLOW_MAX should have comment (or a comment on this block) or be unexported (golint)
- Line 243: warning: comment on exported function BatchFetch should be of the form "BatchFetch ..." (golint)
- Line 361: warning: comment on exported function BatchStat should be of the form "BatchStat ..." (golint)
- Line 434: warning: comment on exported function BatchDelete should be of the form "BatchDelete ..." (golint)
- Line 559: warning: comment on exported function BatchChgm should be of the form "BatchChgm ..." (golint)
- Line 681: warning: comment on exported function BatchChtype should be of the form "BatchChtype ..." (golint)
- Line 814: warning: comment on exported function BatchDeleteAfterDays should be of the form "BatchDeleteAfterDays ..." (golint)
- Line 930: warning: comment on exported function BatchRename should be of the form "BatchRename ..." (golint)
- Line 1058: warning: comment on exported function BatchMove should be of the form "BatchMove ..." (golint)
- Line 1196: warning: comment on exported function BatchCopy should be of the form "BatchCopy ..." (golint)
- Line 1336: warning: comment on exported function BatchSign should be of the form "BatchSign ..." (golint)
-
-
qshell/cmd/fop.go
- Line 40: warning: comment on exported function Prefop should be of the form "Prefop ..." (golint)
- Line 53: warning: comment on exported function Fop should be of the form "Fop ..." (golint)
-
-
qshell/cmd/putfile.go
- Line 41: warning: exported var RePutCmd should have comment or be unexported (golint)
- Line 70: warning: comment on exported type PutRet should be of the form "PutRet ..." (with optional leading article) (golint)
- Line 78: warning: comment on exported function FormPut should be of the form "FormPut ..." (golint)
- Line 193: warning: comment on exported function ResumablePut should be of the form "ResumablePut ..." (golint)
- Line 254: warning: don't use underscores in Go names; var resume_uploader should be resumeUploader (golint)
- Line 267: warning: don't use underscores in Go names; var resume_uploader should be resumeUploader (golint)
-
-
qshell/iqshell/bucket.go
- Line 24: warning: comment on exported type GetRet should be of the form "GetRet ..." (with optional leading article) (golint)
- Line 34: warning: exported type EntryPath should have comment or be unexported (golint)
- Line 39: warning: comment on exported type ChgmEntryPath should be of the form "ChgmEntryPath ..." (with optional leading article) (golint)
- Line 45: warning: comment on exported type ChtypeEntryPath should be of the form "ChtypeEntryPath ..." (with optional leading article) (golint)
- Line 51: warning: comment on exported type DeleteAfterDaysEntryPath should be of the form "DeleteAfterDaysEntryPath ..." (with optional leading article) (golint)
- Line 57: warning: exported type RenameEntryPath should have comment or be unexported (golint)
- Line 59: warning: exported type MoveEntryPath should have comment or be unexported (golint)
- Line 65: warning: exported type CopyEntryPath should have comment or be unexported (golint)
- Line 67: warning: exported type BucketManager should have comment or be unexported (golint)
- Line 71: warning: exported type BucketDomainsRet should have comment or be unexported (golint)
- Line 77: warning: comment on exported method BucketManager.DomainsOfBucket should be of the form "DomainsOfBucket ..." (golint)
- Line 96: warning: comment on exported method BucketManager.MakePublicDownloadLink should be of the form "MakePublicDownloadLink ..." (golint)
- Line 106: warning: comment on exported method BucketManager.MakePrivateDownloadLink should be of the form "MakePrivateDownloadLink ..." (golint)
- Line 120: warning: comment on exported method BucketManager.PrivateUrl should be of the form "PrivateUrl ..." (golint)
- Line 144: warning: exported method BucketManager.GetMac should have comment or be unexported (golint)
- Line 158: warning: comment on exported method BucketManager.Get should be of the form "Get ..." (golint)
- Line 215: warning: exported method BucketManager.Saveas should have comment or be unexported (golint)
- Line 232: warning: exported method BucketManager.BatchStat should have comment or be unexported (golint)
- Line 240: warning: exported method BucketManager.BatchDelete should have comment or be unexported (golint)
- Line 248: warning: exported method BucketManager.BatchCopy should have comment or be unexported (golint)
- Line 256: warning: exported method BucketManager.BatchMove should have comment or be unexported (golint)
- Line 264: warning: exported method BucketManager.BatchRename should have comment or be unexported (golint)
- Line 272: warning: exported method BucketManager.BatchChgm should have comment or be unexported (golint)
- Line 280: warning: exported method BucketManager.BatchChtype should have comment or be unexported (golint)
- Line 288: warning: exported method BucketManager.CheckAsyncFetchStatus should have comment or be unexported (golint)
- Line 302: warning: comment on exported method BucketManager.ChStatus should be of the form "ChStatus ..." (golint)
- Line 324: warning: exported method BucketManager.BatchDeleteAfterDays should have comment or be unexported (golint)
- Line 332: warning: exported method BucketManager.BatchSign should have comment or be unexported (golint)
- Line 361: warning: comment on exported function GetBucketManagerWithConfig should be of the form "GetBucketManagerWithConfig ..." (golint)
- Line 372: warning: exported function GetBucketManager should have comment or be unexported (golint)
- Line 391: warning: exported function GetUpHost should have comment or be unexported (golint)
- Line 400: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
qshell/iqshell/sync.go
- Line 24: warning: exported const ResumableAPIV2MaxPartCount should have comment (or a comment on this block) or be unexported (golint)
- Line 30: warning: exported type ProgressRecorder should have comment or be unexported (golint)
- Line 41: warning: exported function NewProgressRecorder should have comment or be unexported (golint)
- Line 49: warning: exported function ProgressFileFromUrl should have comment or be unexported (golint)
- Line 71: warning: exported method ProgressRecorder.Recover should have comment or be unexported (golint)
- Line 89: warning: exported method ProgressRecorder.RecoverFromUrl should have comment or be unexported (golint)
- Line 100: warning: exported method ProgressRecorder.Reset should have comment or be unexported (golint)
- Line 107: warning: exported method ProgressRecorder.CheckValid should have comment or be unexported (golint)
- Line 183: warning: exported method ProgressRecorder.RecordProgress should have comment or be unexported (golint)
- Line 205: warning: exported method BucketManager.CheckExists should have comment or be unexported (golint)
- Line 211: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 215: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 227: warning: exported type SputRet should have comment or be unexported (golint)
- Line 234: warning: exported method BucketManager.Sync should have comment or be unexported (golint)
-
-
qshell/cmd/bucket.go
- Line 35: warning: comment on exported function GetBuckets should be of the form "GetBuckets ..." (golint)
- Line 54: warning: comment on exported function GetDomainsOfBucket should be of the form "GetDomainsOfBucket ..." (golint)
-
-
qshell/cmd/autocompletion.go
- Line 29: warning: don't use underscores in Go names; var zsh_head should be zshHead (golint)
- Line 33: warning: don't use underscores in Go names; var zsh_initialization should be zshInitialization (golint)
- Line 164: warning: don't use underscores in Go names; var zsh_tail should be zshTail (golint)
-
-
qshell/cmd/qupload.go
- Line 70: warning: comment on exported function QiniuUpload should be of the form "QiniuUpload ..." (golint)
-
-
qshell/cmd/rs.go
- Line 179: warning: comment on exported function ChStatus should be of the form "ChStatus ..." (golint)
- Line 194: warning: comment on exported function DirCache should be of the form "DirCache ..." (golint)
- Line 209: warning: comment on exported function ListBucket2 should be of the form "ListBucket2 ..." (golint)
- Line 258: warning: comment on exported function ListBucket should be of the form "ListBucket ..." (golint)
- Line 269: warning: comment on exported function Get should be of the form "Get ..." (golint)
- Line 288: warning: comment on exported function Stat should be of the form "Stat ..." (golint)
- Line 303: warning: comment on exported function Delete should be of the form "Delete ..." (golint)
- Line 316: warning: comment on exported function Move should be of the form "Move ..." (golint)
- Line 334: warning: comment on exported function Copy should be of the form "Copy ..." (golint)
- Line 351: warning: comment on exported function Chgm should be of the form "Chgm ..." (golint)
- Line 365: warning: comment on exported function Chtype should be of the form "Chtype ..." (golint)
- Line 385: warning: comment on exported function DeleteAfterDays should be of the form "DeleteAfterDays ..." (golint)
- Line 405: warning: comment on exported function Fetch should be of the form "Fetch ..." (golint)
- Line 432: warning: comment on exported function Prefetch should be of the form "Prefetch ..." (golint)
- Line 445: warning: comment on exported function Saveas should be of the form "Saveas ..." (golint)
- Line 461: warning: comment on exported function M3u8Delete should be of the form "M3u8Delete ..." (golint)
- Line 497: warning: comment on exported function M3u8Replace should be of the form "M3u8Replace ..." (golint)
- Line 513: warning: comment on exported function PrivateUrl should be of the form "PrivateUrl ..." (golint)
-
-
qshell/cmd/sync.go
- Line 32: warning: comment on exported function Sync should be of the form "Sync ..." (golint)
-
-
qshell/cmd/token.go
- Line 105: warning: comment on exported function QBoxToken should be of the form "QBoxToken ..." (golint)
- Line 120: warning: comment on exported function QiniuToken should be of the form "QiniuToken ..." (golint)
- Line 136: warning: comment on exported function UploadToken should be of the form "UploadToken ..." (golint)
-
-
qshell/iqshell/qdownload.go
- Line 33: warning: exported const MIN_DOWNLOAD_THREAD_COUNT should have comment (or a comment on this block) or be unexported (golint)
- Line 37: warning: comment on exported type DownloadConfig should be of the form "DownloadConfig ..." (with optional leading article) (golint)
- Line 66: warning: comment on exported method DownloadConfig.DomainOfBucket should be of the form "DomainOfBucket ..." (golint)
- Line 89: warning: comment on exported method DownloadConfig.DownloadDomain should be of the form "DownloadDomain ..." (golint)
- Line 168: warning: comment on exported function QiniuDownload should be of the form "QiniuDownload ..." (golint)
-
-
qshell/iqshell/qetag.go
- Line 11: warning: exported function BlockCount should have comment or be unexported (golint)
- Line 15: warning: exported function CalSha1 should have comment or be unexported (golint)
- Line 24: warning: exported function GetEtag should have comment or be unexported (golint)
-
-
qshell/cmd/account.go
- Line 32: warning: comment on exported function Account should be of the form "Account ..." (golint)
-
-
qshell/iqshell/unzip.go
- Line 32: warning: exported function Unzip should have comment or be unexported (golint)
-
-
qshell/iqshell/uploader.go
- Line 12: warning: exported type ResumeUploader should have comment or be unexported (golint)
- Line 16: warning: exported method ResumeUploader.UpHost should have comment or be unexported (golint)
- Line 28: warning: exported type IResumeUploader should have comment or be unexported (golint)
-
-
qshell/cmd/utils.go
- Line 20: warning: comment on exported const ALPHA_LIST should be of the form "ALPHA_LIST ..." (golint)
- Line 25: warning: exported const KB should have comment (or a comment on this block) or be unexported (golint)
- Line 132: warning: comment on exported function FormatFsize should be of the form "FormatFsize ..." (golint)
- Line 149: warning: exported function RpcDecode should have comment or be unexported (golint)
- Line 165: warning: exported function RpcEncode should have comment or be unexported (golint)
- Line 172: warning: comment on exported function Base64Encode should be of the form "Base64Encode ..." (golint)
- Line 184: warning: comment on exported function Base64Decode should be of the form "Base64Decode ..." (golint)
- Line 206: warning: comment on exported function Timestamp2Date should be of the form "Timestamp2Date ..." (golint)
- Line 217: warning: comment on exported function TimestampNano2Date should be of the form "TimestampNano2Date ..." (golint)
- Line 228: warning: comment on exported function TimestampMilli2Date should be of the form "TimestampMilli2Date ..." (golint)
- Line 239: warning: comment on exported function Date2Timestamp should be of the form "Date2Timestamp ..." (golint)
- Line 251: warning: exported function Urlencode should have comment or be unexported (golint)
- Line 257: warning: exported function Urldecode should have comment or be unexported (golint)
- Line 267: warning: comment on exported function Qetag should be of the form "Qetag ..." (golint)
- Line 278: warning: comment on exported function Unzip should be of the form "Unzip ..." (golint)
- Line 300: warning: comment on exported function ReqId should be of the form "ReqId ..." (golint)
- Line 325: warning: comment on exported function CreateRandString should be of the form "CreateRandString ..." (golint)
- Line 347: warning: exported function ParseLine should have comment or be unexported (golint)
-
-
qshell/cmd/qdownload.go
- Line 35: warning: comment on exported function QiniuDownload should be of the form "QiniuDownload ..." (golint)
-
-
qshell/iqshell/crypto.go
- Line 11: warning: comment on exported function Md5Hex should be of the form "Md5Hex ..." (golint)
- Line 18: warning: comment on exported function AesEncrypt should be of the form "AesEncrypt ..." (golint)
- Line 32: warning: comment on exported function AesDecrypt should be of the form "AesDecrypt ..." (golint)
- Line 47: warning: comment on exported function PKCS5Padding should be of the form "PKCS5Padding ..." (golint)
- Line 54: warning: comment on exported function PKCS5UnPadding should be of the form "PKCS5UnPadding ..." (golint)
-
-
qshell/iqshell/rs_fop.go
- Line 7: warning: exported function Prefop should have comment or be unexported (golint)
- Line 17: warning: exported function Pfop should have comment or be unexported (golint)
-
-
qshell/iqshell/utils.go
- Line 135: warning: comment on exported function GetLineCount should be of the form "GetLineCount ..." (golint)
- Line 144: warning: comment on exported function GetFileLineCount should be of the form "GetFileLineCount ..." (golint)
- Line 155: warning: comment on exported function Encode should be of the form "Encode ..." (golint)
- Line 178: warning: comment on exported function Decode should be of the form "Decode ..." (golint)
- Line 227: warning: comment on exported function KeyFromUrl should be of the form "KeyFromUrl ..." (golint)
- Line 243: warning: comment on exported type ByteSize should be of the form "ByteSize ..." (with optional leading article) (golint)
- Line 247: warning: exported const KB should have comment (or a comment on this block) or be unexported (golint)
- Line 273: warning: comment on exported function BytesToReadable should be of the form "BytesToReadable ..." (golint)
- Line 280: warning: exported function SimpleUnescape should have comment or be unexported (golint)
-
-
qshell/cmd/cdn.go
- Line 18: warning: comment on exported const BATCH_CDN_REFRESH_URLS_ALLOW_MAX should be of the form "BATCH_CDN_REFRESH_URLS_ALLOW_MAX ..." (golint)
- Line 21: warning: comment on exported const BATCH_CDN_REFRESH_DIRS_ALLOW_MAX should be of the form "BATCH_CDN_REFRESH_DIRS_ALLOW_MAX ..." (golint)
- Line 24: warning: comment on exported const BATCH_CDN_PREFETCH_ALLOW_MAX should be of the form "BATCH_CDN_PREFETCH_ALLOW_MAX ..." (golint)
- Line 82: warning: comment on exported function CdnRefresh should be of the form "CdnRefresh ..." (golint)
- Line 163: warning: comment on exported function CdnPrefetch should be of the form "CdnPrefetch ..." (golint)
-
-
qshell/iqshell/account.go
- Line 17: warning: comment on exported type Account should be of the form "Account ..." (with optional leading article) (golint)
- Line 24: warning: comment on exported method Account.Mac should be of the form "Mac ..." (golint)
- Line 31: warning: comment on exported method Account.Encrypt should be of the form "Encrypt ..." (golint)
- Line 42: warning: comment on exported method Account.Value should be of the form "Value ..." (golint)
- Line 53: warning: comment on exported function Encrypt should be of the form "Encrypt ..." (golint)
- Line 62: warning: comment on exported function Decrypt should be of the form "Decrypt ..." (golint)
- Line 85: warning: comment on exported function EncryptSecretKey should be of the form "EncryptSecretKey ..." (golint)
- Line 96: warning: comment on exported function DecryptSecretKey should be of the form "DecryptSecretKey ..." (golint)
- Line 152: warning: comment on exported function SetAccount2 should be of the form "SetAccount2 ..." (golint)
- Line 170: warning: comment on exported function SetAccount should be of the form "SetAccount ..." (golint)
- Line 248: warning: comment on exported function GetOldAccount should be of the form "GetOldAccount ..." (golint)
- Line 260: warning: comment on exported function GetAccount should be of the form "GetAccount ..." (golint)
- Line 278: warning: comment on exported function GetMac should be of the form "GetMac ..." (golint)
- Line 287: warning: comment on exported function ChUser should be of the form "ChUser ..." (golint)
- Line 325: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 356: warning: comment on exported function GetUsers should be of the form "GetUsers ..." (golint)
- Line 389: warning: comment on exported function ListUser should be of the form "ListUser ..." (golint)
- Line 429: warning: comment on exported function CleanUser should be of the form "CleanUser ..." (golint)
- Line 439: warning: comment on exported function RmUser should be of the form "RmUser ..." (golint)
- Line 457: warning: comment on exported function LookUp should be of the form "LookUp ..." (golint)
-
-
qshell/cmd/alilistbucket.go
- Line 20: warning: comment on exported function AliListBucket should be of the form "AliListBucket ..." (golint)
gocyclo77%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
qshell/iqshell/qdownload.go
- Line 169: warning: cyclomatic complexity 45 of function QiniuDownload() is high (> 15) (gocyclo)
-
-
qshell/iqshell/sync.go
- Line 234: warning: cyclomatic complexity 30 of function (*BucketManager).Sync() is high (> 15) (gocyclo)
- Line 107: warning: cyclomatic complexity 23 of function (*ProgressRecorder).CheckValid() is high (> 15) (gocyclo)
-
-
qshell/cmd/asyncfetch.go
- Line 144: warning: cyclomatic complexity 17 of function (*asyncFetchOptions).Run() is high (> 15) (gocyclo)
-
-
qshell/cmd/rsbatch.go
- Line 1197: warning: cyclomatic complexity 17 of function BatchCopy() is high (> 15) (gocyclo)
- Line 1059: warning: cyclomatic complexity 17 of function BatchMove() is high (> 15) (gocyclo)
-
-
qshell/cmd/qupload2.go
- Line 63: warning: cyclomatic complexity 17 of function QiniuUpload2() is high (> 15) (gocyclo)
-
-
qshell/cmd/cdn.go
- Line 83: warning: cyclomatic complexity 17 of function CdnRefresh() is high (> 15) (gocyclo)
-
-
qshell/iqshell/list_bucket.go
- Line 64: warning: cyclomatic complexity 29 of function (*BucketManager).ListBucket2() is high (> 15) (gocyclo)
-
-
qshell/iqshell/qupload.go
- Line 445: warning: cyclomatic complexity 22 of function QiniuUpload() is high (> 15) (gocyclo)
- Line 702: warning: cyclomatic complexity 17 of function checkFileNeedToUpload() is high (> 15) (gocyclo)
-
-
qshell/cmd/qupload.go
- Line 72: warning: cyclomatic complexity 23 of function QiniuUpload() is high (> 15) (gocyclo)
-
-
qshell/cmd/putfile.go
- Line 79: warning: cyclomatic complexity 21 of function FormPut() is high (> 15) (gocyclo)
- Line 195: warning: cyclomatic complexity 17 of function ResumablePut() is high (> 15) (gocyclo)
ineffassign95%
IneffAssign detects ineffectual assignments in Go code.
-
-
qshell/iqshell/qdownload.go
- Line 189: warning: ineffectual assignment to logLevel (ineffassign)
-
-
qshell/iqshell/qupload.go
- Line 140: warning: ineffectual assignment to logLevel (ineffassign)
- Line 642: warning: ineffectual assignment to rescanLocalDir (ineffassign)