gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• radon/src/plugins/privilege/privilege.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• radon/src/router/compute.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• radon/src/backend/txn_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• radon/src/backend/txnz_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• radon/src/backend/xa_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• radon/src/config/mock.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• radon/src/planner/insert_plan.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• radon/src/router/mock.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• radon/src/backend/xacheck_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• radon/src/proxy/admin_attach.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• radon/src/planner/builder/from_test.go
  • Line 21: warning: cyclomatic complexity 21 of function TestScanTableExprs() is high (> 15) (gocyclo)
  • Line 350: warning: cyclomatic complexity 21 of function TestScanTableExprsList() is high (> 15) (gocyclo)

• radon/src/ctl/v1/shard.go
  • Line 275: warning: cyclomatic complexity 16 of function shardMigrateHandler() is high (> 15) (gocyclo)

• radon/src/plugins/privilege/privilege.go
  • Line 109: warning: cyclomatic complexity 33 of function (*Privilege).CheckPrivilege() is high (> 15) (gocyclo)

• radon/src/backend/txn.go
  • Line 564: warning: cyclomatic complexity 22 of function (*Txn).ExecuteStreamFetch() is high (> 15) (gocyclo)
  • Line 465: warning: cyclomatic complexity 17 of function (*Txn).execute() is high (> 15) (gocyclo)

• radon/src/backend/xacheck.go
  • Line 183: warning: cyclomatic complexity 18 of function (*XaCheck).commitRetryBackends() is high (> 15) (gocyclo)

• radon/src/planner/select_plan.go
  • Line 80: warning: cyclomatic complexity 16 of function (*SelectPlan).JSON() is high (> 15) (gocyclo)

• radon/src/planner/ddl_plan.go
  • Line 68: warning: cyclomatic complexity 16 of function (*DDLPlan).checkUnsupportedOperations() is high (> 15) (gocyclo)

• radon/src/planner/builder/expr.go
  • Line 35: warning: cyclomatic complexity 24 of function parseWhereOrJoinExprs() is high (> 15) (gocyclo)

• radon/src/planner/builder/aggregate_plan.go
  • Line 69: warning: cyclomatic complexity 16 of function (*AggregatePlan).analyze() is high (> 15) (gocyclo)

• radon/src/proxy/set.go
  • Line 26: warning: cyclomatic complexity 23 of function (*Spanner).handleSet() is high (> 15) (gocyclo)

• radon/src/executor/engine/merge_join.go
  • Line 136: warning: cyclomatic complexity 38 of function concatLeftAndRight() is high (> 15) (gocyclo)

• radon/src/planner/others_plan.go
  • Line 67: warning: cyclomatic complexity 17 of function (*OthersPlan).Build() is high (> 15) (gocyclo)

• radon/src/planner/builder/from.go
  • Line 164: warning: cyclomatic complexity 23 of function join() is high (> 15) (gocyclo)

• radon/src/proxy/radon.go
  • Line 21: warning: cyclomatic complexity 18 of function (*Spanner).handleRadon() is high (> 15) (gocyclo)

• radon/src/executor/engine/join_engine.go
  • Line 96: warning: cyclomatic complexity 19 of function (*JoinEngine).execBindVars() is high (> 15) (gocyclo)

• radon/src/planner/builder/project.go
  • Line 321: warning: cyclomatic complexity 20 of function checkGroupBy() is high (> 15) (gocyclo)
  • Line 43: warning: cyclomatic complexity 17 of function parseSelectExpr() is high (> 15) (gocyclo)

• radon/src/proxy/ddl.go
  • Line 140: warning: cyclomatic complexity 65 of function (*Spanner).handleDDL() is high (> 15) (gocyclo)

• radon/src/proxy/admin_attach.go
  • Line 133: warning: cyclomatic complexity 21 of function (*Attach).addAttachHandler() is high (> 15) (gocyclo)
  • Line 250: warning: cyclomatic complexity 16 of function (*Attach).detachHandler() is high (> 15) (gocyclo)

• radon/src/proxy/admin_rebalance.go
  • Line 48: warning: cyclomatic complexity 19 of function ShardBalanceAdvice() is high (> 15) (gocyclo)

• radon/src/executor/executor.go
  • Line 51: warning: cyclomatic complexity 19 of function (*Tree).Execute() is high (> 15) (gocyclo)

• radon/src/backend/xa.go
  • Line 66: warning: cyclomatic complexity 21 of function (*Txn).executeXA() is high (> 15) (gocyclo)

• radon/src/planner/insert_plan.go
  • Line 67: warning: cyclomatic complexity 23 of function (*InsertPlan).Build() is high (> 15) (gocyclo)

• radon/src/planner/builder/builder.go
  • Line 42: warning: cyclomatic complexity 18 of function processSelect() is high (> 15) (gocyclo)
  • Line 154: warning: cyclomatic complexity 16 of function union() is high (> 15) (gocyclo)

• radon/src/planner/builder/join_node.go
  • Line 541: warning: cyclomatic complexity 18 of function (*JoinNode).pushOtherFilters() is high (> 15) (gocyclo)
  • Line 374: warning: cyclomatic complexity 16 of function (*JoinNode).pushEqualCmprs() is high (> 15) (gocyclo)

• radon/src/proxy/query.go
  • Line 40: warning: cyclomatic complexity 98 of function (*Spanner).ComQuery() is high (> 15) (gocyclo)
  • Line 456: warning: cyclomatic complexity 17 of function queryStat() is high (> 15) (gocyclo)

• radon/src/proxy/show.go
  • Line 77: warning: cyclomatic complexity 20 of function (*Spanner).handleShowTableStatus() is high (> 15) (gocyclo)

golint90%

Golint is a linter for Go source code.

• radon/src/config/config.go
  • Line 21: warning: exported const NormalBackend should have comment (or a comment on this block) or be unexported (golint)

• radon/src/proxy/manager.go
  • Line 22: warning: exported type Manager should have comment or be unexported (golint)

• radon/src/proxy/admin_xa.go
  • Line 21: warning: exported type AdminXA should have comment or be unexported (golint)
  • Line 28: warning: exported function NewAdminXA should have comment or be unexported (golint)

• radon/src/proxy/execute.go
  • Line 221: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• radon/src/plugins/shiftmanager/handler.go
  • Line 73: warning: exported type ShiftMgrHandler should have comment or be unexported (golint)

• radon/src/plugins/shiftmanager/shiftmanager_test.go
  • Line 242: warning: don't use underscores in Go names; var keyOK_1 should be keyOK1 (golint)
  • Line 243: warning: don't use underscores in Go names; var keyOK_2 should be keyOK2 (golint)
  • Line 261: warning: don't use underscores in Go names; var shift_1 should be shift1 (golint)
  • Line 267: warning: don't use underscores in Go names; var shift_2 should be shift2 (golint)
  • Line 295: warning: don't use underscores in Go names; var keyOK_1 should be keyOK1 (golint)
  • Line 296: warning: don't use underscores in Go names; var keyOK_2 should be keyOK2 (golint)
  • Line 314: warning: don't use underscores in Go names; var shift_1 should be shift1 (golint)
  • Line 320: warning: don't use underscores in Go names; var shift_2 should be shift2 (golint)
  • Line 348: warning: don't use underscores in Go names; var keyOK_1 should be keyOK1 (golint)
  • Line 349: warning: don't use underscores in Go names; var keyOK_2 should be keyOK2 (golint)
  • Line 367: warning: don't use underscores in Go names; var shift_1 should be shift1 (golint)
  • Line 373: warning: don't use underscores in Go names; var shift_2 should be shift2 (golint)

• radon/src/backend/xacheck.go
  • Line 260: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• radon/src/planner/insert_plan.go
  • Line 177: warning: should omit 2nd value from range; this loop is equivalent to `for partTable := range ...` (golint)

• radon/src/router/single.go
  • Line 97: warning: exported method Single.GetSegment should have comment or be unexported (golint)

• radon/src/router/types.go
  • Line 15: warning: comment on exported const MethodTypeHash should be of the form "MethodTypeHash ..." (golint)
  • Line 17: warning: exported const MethodTypeGlobal should have comment (or a comment on this block) or be unexported (golint)

• radon/src/config/mock.go
  • Line 91: warning: comment on exported var MockAutoIncrment should be of the form "MockAutoIncrment ..." (golint)

• radon/src/ctl/admin.go
  • Line 15: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• radon/src/router/hash.go
  • Line 192: warning: exported method Hash.GetSegment should have comment or be unexported (golint)

• radon/src/proxy/admin_attach.go
  • Line 29: warning: exported const AttachDatabaseCheckTable should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: exported type Attach should have comment or be unexported (golint)
  • Line 60: warning: exported method Attach.Attach should have comment or be unexported (golint)
  • Line 84: warning: exported method Attach.Detach should have comment or be unexported (golint)
  • Line 98: warning: exported method Attach.ListAttach should have comment or be unexported (golint)
  • Line 172: warning: should omit 2nd value from range; this loop is equivalent to `for db := range ...` (golint)

• radon/src/proxy/sessions.go
  • Line 315: warning: comment on exported method Sessions.SnapshotUser should be of the form "SnapshotUser ..." (golint)

• radon/src/router/frm.go
  • Line 26: warning: exported const TableTypeSingle should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported const NAME_CHAR_LEN should have comment (or a comment on this block) or be unexported (golint)
  • Line 125: warning: exported method Router.CreateDatabase should have comment or be unexported (golint)

• radon/src/proxy/set.go
  • Line 21: warning: don't use underscores in Go names; const var_mysql_autocommit should be varMysqlAutocommit (golint)
  • Line 22: warning: don't use underscores in Go names; const var_radon_streaming_fetch should be varRadonStreamingFetch (golint)

• radon/src/proxy/show.go
  • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 45: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• radon/src/fuzz/sqlparser/fuzz.go
  • Line 37: warning: exported function Fuzz should have comment or be unexported (golint)

• radon/src/plugins/privilege/handler.go
  • Line 15: warning: exported type PrivilegeHandler should have comment or be unexported (golint)

• radon/src/plugins/privilege/mock.go
  • Line 11: warning: exported var UserRs should have comment or be unexported (golint)

• radon/src/backend/scatter.go
  • Line 216: warning: exported method Scatter.CheckBackend should have comment or be unexported (golint)

• radon/src/proxy/session.go
  • Line 26: warning: don't use underscores in Go names; const cap_streaming_fetch should be capStreamingFetch (golint)

• radon/src/plugins/autoincrement/handler.go
  • Line 25: warning: exported type AutoIncrementHandler should have comment or be unexported (golint)
  • Line 39: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• radon/src/plugins/privilege/privilege.go
  • Line 108: warning: comment on exported method Privilege.CheckPrivilege should be of the form "CheckPrivilege ..." (golint)
  • Line 214: warning: should omit 2nd value from range; this loop is equivalent to `for db := range ...` (golint)

• radon/src/router/global.go
  • Line 98: warning: exported method Global.GetSegment should have comment or be unexported (golint)

• radon/src/proxy/admin_rebalance.go
  • Line 40: warning: exported type BackendSize should have comment or be unexported (golint)
  • Line 48: warning: exported function ShardBalanceAdvice should have comment or be unexported (golint)
  • Line 146: warning: exported function RebalanceMigrate should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• radon/src/proxy/spanner.go
  • Line 136: warning: ineffectual assignment to err (ineffassign)

• radon/src/executor/ddl_executor_test.go
  • Line 38: warning: ineffectual assignment to err (ineffassign)

• radon/src/executor/engine/join_engine.go
  • Line 154: warning: ineffectual assignment to wantfields (ineffassign)

• radon/src/plugins/shiftmanager/shiftmanager_test.go
  • Line 456: warning: ineffectual assignment to err (ineffassign)

• radon/src/router/frm_test.go
  • Line 480: warning: ineffectual assignment to err (ineffassign)
  • Line 481: warning: ineffectual assignment to err (ineffassign)
  • Line 484: warning: ineffectual assignment to err (ineffassign)

• radon/src/proxy/admin_attach_test.go
  • Line 155: warning: ineffectual assignment to node (ineffassign)
  • Line 161: warning: ineffectual assignment to node (ineffassign)

• radon/src/proxy/ddl.go
  • Line 212: warning: ineffectual assignment to tableType (ineffassign)
  • Line 380: warning: ineffectual assignment to r (ineffassign)

• radon/src/proxy/show_test.go
  • Line 1198: warning: ineffectual assignment to clients (ineffassign)

misspell98%

Misspell Finds commonly misspelled English words

• radon/src/proxy/admin_reshard_test.go
  • Line 207: warning: "successfull" is a misspelling of "successful" (misspell)

• radon/src/proxy/ddl_test.go
  • Line 946: warning: "unkown" is a misspelling of "unknown" (misspell)

• radon/src/proxy/mock.go
  • Line 239: warning: "multipe" is a misspelling of "multiple" (misspell)

• radon/src/backend/queryz_test.go
  • Line 68: warning: "funciton" is a misspelling of "function" (misspell)

• radon/src/ctl/v1/shard.go
  • Line 46: warning: "transfered" is a misspelling of "transferred" (misspell)