Report for github.com/realzhangliu/socks5-go
A+ Excellent! Found 5 issues across 8 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint37%
Golint is a linter for Go source code.
-
-
socks5-go/tcp-handler.go
- Line 12: warning: comment on exported method TCPConn.HandleBIND should be of the form "HandleBIND ..." (golint)
- Line 36: warning: comment on exported method TCPConn.HandleCONNECT should be of the form "HandleCONNECT ..." (golint)
- Line 54: warning: comment on exported method TCPConn.TCPTransport should be of the form "TCPTransport ..." (golint)
-
-
socks5-go/auth.go
- Line 3: warning: exported type Socks5Auth should have comment or be unexported (golint)
- Line 35: warning: exported type VerifyUser should have comment or be unexported (golint)
- Line 37: warning: comment on exported method VerifyUser.Authenticate should be of the form "Authenticate ..." (golint)
-
-
socks5-go/config.go
- Line 8: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
-
-
socks5-go/model.go
- Line 15: warning: exported type Server should have comment or be unexported (golint)
- Line 24: warning: exported var DNSAddrs should have comment or be unexported (golint)
- Line 31: warning: comment on exported function NewSocks5Server should be of the form "NewSocks5Server ..." (golint)
- Line 61: warning: comment on exported method Server.Listen should be of the form "Listen ..." (golint)
- Line 106: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 115: warning: exported type TCPConn should have comment or be unexported (golint)
- Line 146: warning: exported method TCPConn.DialTCP should have comment or be unexported (golint)
- Line 153: warning: exported var DEFAULT_TCP_DIALER should have comment or be unexported (golint)
- Line 157: warning: exported method TCPConn.ID should have comment or be unexported (golint)
- Line 166: warning: exported type Socks5UDPserver should have comment or be unexported (golint)
- Line 181: warning: exported type TCPRequest should have comment or be unexported (golint)
-
-
socks5-go/socks5.go
- Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 22: warning: exported const SOCKS5VERSION should have comment (or a comment on this block) or be unexported (golint)
- Line 31: warning: error var ERR_READ_USR_PWD should have name of the form ErrFoo (golint)
- Line 31: warning: exported var ERR_READ_USR_PWD should have comment or be unexported (golint)
- Line 32: warning: error var ERR_METHOD should have name of the form ErrFoo (golint)
- Line 33: warning: error var ERR_VERSION should have name of the form ErrFoo (golint)
- Line 34: warning: error var ERR_READ_FAILED should have name of the form ErrFoo (golint)
- Line 35: warning: error var ERR_ADDRESS_TYPE should have name of the form ErrFoo (golint)
- Line 36: warning: error var ERR_AUTH_FAILED should have name of the form ErrFoo (golint)
- Line 38: warning: exported var ErrMethod should have comment or be unexported (golint)
- Line 123: warning: exported method TCPConn.ServConn should have comment or be unexported (golint)
- Line 191: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!