gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• ship/pkg/lifecycle/daemon/headless/daemon.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ship/pkg/lifecycle/unfork/unforker_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ship/pkg/lifecycle/kustomize/kustomizer_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ship/pkg/lifecycle/kustomize/post_kustomize_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ship/pkg/lifecycle/kustomize/pre_kustomize_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ship/pkg/lifecycle/daemon/routes_navcycle_getstep_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ship/contracts/replicatedapp/get_license_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ship/pkg/api/lifecycle.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• ship/pkg/helm/template.go
  • Line 118: warning: cyclomatic complexity 27 of function (*templateCmd).run() is high (> 15) (gocyclo)

• ship/pkg/lifecycle/kustomize/daemonless.go
  • Line 46: warning: cyclomatic complexity 16 of function (*Kustomizer).Execute() is high (> 15) (gocyclo)

• ship/pkg/lifecycle/unfork/unforker.go
  • Line 249: warning: cyclomatic complexity 21 of function (*Unforker).generatePatchesAndExcludeBases() is high (> 15) (gocyclo)

• ship/pkg/state/upstream_files.go
  • Line 72: warning: cyclomatic complexity 16 of function readUpstreamFiles() is high (> 15) (gocyclo)

• ship/pkg/lifecycle/kustomize/patch.go
  • Line 51: warning: cyclomatic complexity 22 of function (*Kustomizer).generateTillerPatches() is high (> 15) (gocyclo)

• ship/pkg/lifecycle/render/docker/step.go
  • Line 68: warning: cyclomatic complexity 18 of function (*DefaultStep).Execute() is high (> 15) (gocyclo)

• ship/pkg/lifecycle/render/planner/build.go
  • Line 24: warning: cyclomatic complexity 37 of function (*CLIPlanner).Build() is high (> 15) (gocyclo)

• ship/pkg/helm/dependency.go
  • Line 164: warning: cyclomatic complexity 19 of function (*dependencyListCmd).dependencyStatus() is high (> 15) (gocyclo)

• ship/pkg/helm/init.go
  • Line 108: warning: cyclomatic complexity 19 of function (*initCmd).run() is high (> 15) (gocyclo)

• ship/pkg/specs/githubclient/client.go
  • Line 94: warning: cyclomatic complexity 16 of function (*GithubClient).downloadAndExtractFiles() is high (> 15) (gocyclo)

• ship/pkg/state/manager_test.go
  • Line 552: warning: cyclomatic complexity 22 of function TestMManager_ParallelUpdates() is high (> 15) (gocyclo)

• ship/pkg/lifecycle/render/render.go
  • Line 41: warning: cyclomatic complexity 19 of function (*headlessrenderer).Execute() is high (> 15) (gocyclo)

• ship/pkg/lifecycle/daemon/routes_navcycle_completestep_test.go
  • Line 43: warning: cyclomatic complexity 16 of function TestV2CompleteStep() is high (> 15) (gocyclo)

• ship/pkg/lifecycle/render/helm/template.go
  • Line 317: warning: cyclomatic complexity 20 of function (*LocalTemplater).cleanUpAndOutputRenderedFiles() is high (> 15) (gocyclo)
  • Line 82: warning: cyclomatic complexity 20 of function (*LocalTemplater).Template() is high (> 15) (gocyclo)

• ship/pkg/ship/kustomize.go
  • Line 27: warning: cyclomatic complexity 20 of function (*Ship).Init() is high (> 15) (gocyclo)

• ship/pkg/util/multidoc_yaml.go
  • Line 49: warning: cyclomatic complexity 22 of function splitKustomizeDir() is high (> 15) (gocyclo)

golint52%

Golint is a linter for Go source code.

• ship/pkg/lifecycle/message/cli.go
  • Line 20: warning: exported type CLIMessenger should have comment or be unexported (golint)
  • Line 29: warning: exported method CLIMessenger.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/render.go
  • Line 23: warning: exported var ProgressRead should have comment or be unexported (golint)
  • Line 141: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ship/pkg/specs/patch.go
  • Line 12: warning: exported function NewIDPatcher should have comment or be unexported (golint)
  • Line 18: warning: exported type IDPatcher should have comment or be unexported (golint)
  • Line 34: warning: exported method IDPatcher.EnsureAllStepsHaveUniqueIDs should have comment or be unexported (golint)

• ship/pkg/lifecycle/kustomizeintro/kustomizeIntro.go
  • Line 12: warning: exported function NewKustomizeIntro should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/amazoneks/render.go
  • Line 42: warning: exported function NewRenderer should have comment or be unexported (golint)
  • Line 56: warning: exported method LocalRenderer.Execute should have comment or be unexported (golint)

• ship/pkg/filetree/api.go
  • Line 3: warning: exported type Node should have comment or be unexported (golint)

• ship/pkg/ship/kustomize.go
  • Line 19: warning: exported method Ship.InitAndMaybeExit should have comment or be unexported (golint)
  • Line 27: warning: exported method Ship.Init should have comment or be unexported (golint)

• ship/pkg/lifecycle/kubectl/daemonless.go
  • Line 21: warning: exported type DaemonlessKubectl should have comment or be unexported (golint)
  • Line 28: warning: exported function NewDaemonlessKubectl should have comment or be unexported (golint)
  • Line 40: warning: exported method DaemonlessKubectl.WithStatusReceiver should have comment or be unexported (golint)
  • Line 49: warning: comment on exported method DaemonlessKubectl.Execute should be of the form "Execute ..." (golint)

• ship/pkg/specs/replicatedapp/graphql.go
  • Line 21: warning: exported const ShipRelease should have comment or be unexported (golint)
  • Line 76: warning: exported const GetAppspecQuery should have comment or be unexported (golint)
  • Line 83: warning: exported const GetSlugAppSpecQuery should have comment or be unexported (golint)
  • Line 90: warning: exported const GetLicenseQuery should have comment or be unexported (golint)
  • Line 101: warning: exported const RegisterInstallQuery should have comment or be unexported (golint)
  • Line 129: warning: comment on exported type GQLGetLicenseResponse should be of the form "GQLGetLicenseResponse ..." (with optional leading article) (golint)
  • Line 147: warning: comment on exported type LicenseWrapper should be of the form "LicenseWrapper ..." (with optional leading article) (golint)
  • Line 308: warning: exported method GraphQLClient.GetLicense should have comment or be unexported (golint)
  • Line 340: warning: exported method GraphQLClient.RegisterInstall should have comment or be unexported (golint)

• ship/pkg/helpers/flags/flags.go
  • Line 7: warning: exported function GetCurrentOrDeprecatedString should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/routes_navcycle_completestep.go
  • Line 110: warning: exported type V2Executor should have comment or be unexported (golint)

• ship/pkg/ship/unfork.go
  • Line 12: warning: exported method Ship.UnforkAndMaybeExit should have comment or be unexported (golint)
  • Line 20: warning: exported method Ship.Unfork should have comment or be unexported (golint)

• ship/pkg/util/filesystem.go
  • Line 50: warning: exported function BackupIfPresent should have comment or be unexported (golint)
  • Line 86: warning: exported function RecursiveCopy should have comment or be unexported (golint)

• ship/pkg/util/http_upload.go
  • Line 15: warning: exported type AssetUploader should have comment or be unexported (golint)
  • Line 25: warning: exported function NewAssetUploader should have comment or be unexported (golint)

• ship/pkg/cli/update.go
  • Line 11: warning: exported function Update should have comment or be unexported (golint)

• ship/pkg/lifecycle/unfork/daemonless.go
  • Line 19: warning: exported type Unforker should have comment or be unexported (golint)
  • Line 26: warning: exported function NewDaemonlessUnforker should have comment or be unexported (golint)
  • Line 35: warning: exported method Unforker.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/unfork/unforker.go
  • Line 30: warning: exported function NewDaemonUnforker should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/inline/render.go
  • Line 40: warning: exported function NewRenderer should have comment or be unexported (golint)
  • Line 52: warning: exported method LocalRenderer.Execute should have comment or be unexported (golint)

• ship/pkg/templates/installation_context.go
  • Line 15: warning: exported type InstallationContext should have comment or be unexported (golint)
  • Line 74: warning: exported method InstallationContext.FuncMap should have comment or be unexported (golint)

• ship/pkg/ship/dig.go
  • Line 221: warning: exported function Get should have comment or be unexported (golint)

• ship/pkg/lifecycle/helmValues/daemonless.go
  • Line 1: warning: don't use MixedCaps in package name; helmValues should be helmvalues (golint)
  • Line 10: warning: exported function NewDaemonlessHelmValues should have comment or be unexported (golint)

• ship/pkg/specs/content.go
  • Line 32: warning: exported type ContentProcessor should have comment or be unexported (golint)
  • Line 43: warning: exported function NewContentProcessor should have comment or be unexported (golint)
  • Line 83: warning: exported method Resolver.NewContentProcessor should have comment or be unexported (golint)
  • Line 138: warning: comment on exported method ContentProcessor.ReadContentSHAForWatch should be of the form "ReadContentSHAForWatch ..." (golint)
  • Line 235: warning: exported method ContentProcessor.RemoveAll should have comment or be unexported (golint)

• ship/pkg/util/kubernetes_resource.go
  • Line 14: warning: exported function NewKubernetesResource should have comment or be unexported (golint)
  • Line 27: warning: exported function NewKubernetesResources should have comment or be unexported (golint)
  • Line 38: warning: exported function ResIDs should have comment or be unexported (golint)
  • Line 45: warning: exported function ToGroupVersionKind should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/planner/planner.go
  • Line 30: warning: comment on exported type Step should be of the form "Step ..." (with optional leading article) (golint)
  • Line 54: warning: exported type Factory should have comment or be unexported (golint)
  • Line 56: warning: exported method Factory.WithStatusReceiver should have comment or be unexported (golint)
  • Line 84: warning: exported method Factory.Build should have comment or be unexported (golint)
  • Line 95: warning: exported method Factory.Execute should have comment or be unexported (golint)
  • Line 122: warning: comment on exported function NewFactory should be of the form "NewFactory ..." (golint)

• ship/pkg/lifecycle/daemon/daemontypes/types.go
  • Line 10: warning: exported type StatusReceiver should have comment or be unexported (golint)
  • Line 43: warning: exported const StepNameMessage should have comment or be unexported (golint)
  • Line 44: warning: exported const StepNameConfig should have comment or be unexported (golint)
  • Line 45: warning: exported const StepNameHelmIntro should have comment or be unexported (golint)
  • Line 46: warning: exported const StepNameHelmValues should have comment or be unexported (golint)
  • Line 47: warning: exported const StepNameStream should have comment or be unexported (golint)
  • Line 51: warning: exported const StepNamePlan should have comment or be unexported (golint)
  • Line 52: warning: exported const StepNameApply should have comment or be unexported (golint)
  • Line 53: warning: exported const StepNameReport should have comment or be unexported (golint)
  • Line 55: warning: exported const StepNameKustomize should have comment or be unexported (golint)
  • Line 56: warning: exported const StepNameUnfork should have comment or be unexported (golint)
  • Line 58: warning: comment on exported type Step should be of the form "Step ..." (with optional leading article) (golint)
  • Line 72: warning: comment on exported function NewStep should be of the form "NewStep ..." (golint)
  • Line 109: warning: exported type Message should have comment or be unexported (golint)
  • Line 115: warning: exported type Render should have comment or be unexported (golint)
  • Line 117: warning: exported type StepResponse should have comment or be unexported (golint)
  • Line 124: warning: exported type ActionRequest should have comment or be unexported (golint)
  • Line 130: warning: exported type Action should have comment or be unexported (golint)
  • Line 138: warning: exported type HelmIntro should have comment or be unexported (golint)
  • Line 142: warning: exported type HelmValues should have comment or be unexported (golint)
  • Line 152: warning: exported type Kustomize should have comment or be unexported (golint)
  • Line 157: warning: exported type KustomizeIntro should have comment or be unexported (golint)
  • Line 160: warning: exported type Unfork should have comment or be unexported (golint)
  • Line 163: warning: exported type Config should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/config/daemonresolver.go
  • Line 14: warning: exported type DaemonResolver should have comment or be unexported (golint)
  • Line 19: warning: exported method DaemonResolver.ResolveConfig should have comment or be unexported (golint)

• ship/pkg/util/kubernetes_is_k8s_yaml.go
  • Line 13: warning: exported function ShouldAddFileToBase should have comment or be unexported (golint)
  • Line 34: warning: exported function IsK8sYaml should have comment or be unexported (golint)

• ship/pkg/lifecycle/interfaces.go
  • Line 11: warning: exported type DoWithProgress should have comment or be unexported (golint)
  • Line 12: warning: exported type DoWithMessage should have comment or be unexported (golint)
  • Line 14: warning: exported type Messenger should have comment or be unexported (golint)
  • Line 18: warning: exported type Renderer should have comment or be unexported (golint)
  • Line 24: warning: exported type Terraformer should have comment or be unexported (golint)
  • Line 29: warning: exported type HelmIntro should have comment or be unexported (golint)
  • Line 33: warning: exported type HelmValues should have comment or be unexported (golint)
  • Line 37: warning: exported type Kustomizer should have comment or be unexported (golint)
  • Line 42: warning: exported type KustomizeIntro should have comment or be unexported (golint)
  • Line 46: warning: exported type Unforker should have comment or be unexported (golint)
  • Line 51: warning: exported type KubectlApply should have comment or be unexported (golint)

• ship/pkg/lifecycle/message/api.go
  • Line 19: warning: exported type DaemonMessenger should have comment or be unexported (golint)
  • Line 28: warning: exported method DaemonMessenger.Execute should have comment or be unexported (golint)

• ship/pkg/util/certs.go
  • Line 20: warning: exported type CertType should have comment or be unexported (golint)
  • Line 25: warning: exported type CAType should have comment or be unexported (golint)
  • Line 59: warning: exported function MakeCert should have comment or be unexported (golint)
  • Line 103: warning: exported function MakeCA should have comment or be unexported (golint)

• ship/pkg/e2e/vendor_client.go
  • Line 17: warning: comment on exported type GraphQLClient should be of the form "GraphQLClient ..." (with optional leading article) (golint)
  • Line 44: warning: exported type ShipReleaseResult should have comment or be unexported (golint)
  • Line 48: warning: comment on exported type GraphQLResponseCreateChannel should be of the form "GraphQLResponseCreateChannel ..." (with optional leading article) (golint)
  • Line 54: warning: exported type ShipCustomer should have comment or be unexported (golint)
  • Line 59: warning: exported type ShipChannel should have comment or be unexported (golint)
  • Line 65: warning: exported type ShipCreateChannelResult should have comment or be unexported (golint)
  • Line 69: warning: exported type ShipAssignCustomerResult should have comment or be unexported (golint)
  • Line 73: warning: exported type ShipChannelListResult should have comment or be unexported (golint)
  • Line 77: warning: exported type GraphQLResponseListChannel should have comment or be unexported (golint)
  • Line 82: warning: exported type GraphQLResponseAssignCustomer should have comment or be unexported (golint)
  • Line 87: warning: exported method GraphQLResponseListChannel.GraphQLError should have comment or be unexported (golint)
  • Line 90: warning: exported method GraphQLResponseCreateChannel.GraphQLError should have comment or be unexported (golint)
  • Line 93: warning: exported method GraphQLResponsePromoteRelease.GraphQLError should have comment or be unexported (golint)
  • Line 97: warning: exported method GraphQLResponseAssignCustomer.GraphQLError should have comment or be unexported (golint)
  • Line 101: warning: exported type Errer should have comment or be unexported (golint)
  • Line 105: warning: exported method GraphQLClient.GetOrCreateChannel should have comment or be unexported (golint)
  • Line 133: warning: exported method GraphQLClient.PromoteRelease should have comment or be unexported (golint)
  • Line 170: warning: exported method GraphQLClient.CreateChannel should have comment or be unexported (golint)
  • Line 195: warning: exported method GraphQLClient.EnsureCustomerOnChannel should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/azureaks/render.go
  • Line 35: warning: comment on exported type LocalRenderer should be of the form "LocalRenderer ..." (with optional leading article) (golint)
  • Line 45: warning: exported function NewRenderer should have comment or be unexported (golint)
  • Line 59: warning: exported method LocalRenderer.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/kustomize/pre_kustomize.go
  • Line 18: warning: exported method Kustomizer.PreExecute should have comment or be unexported (golint)

• ship/pkg/ship/watch.go
  • Line 14: warning: exported method Ship.WatchAndExit should have comment or be unexported (golint)
  • Line 22: warning: exported method Ship.Watch should have comment or be unexported (golint)

• ship/pkg/specs/replicatedapp/local.go
  • Line 1: warning: package comment should be of the form "Package replicatedapp ..." (golint)

• ship/pkg/api/lifecycle.go
  • Line 34: warning: exported type StepDetails should have comment or be unexported (golint)
  • Line 39: warning: exported method Step.GetStep should have comment or be unexported (golint)
  • Line 64: warning: exported method Step.Shared should have comment or be unexported (golint)
  • Line 65: warning: exported method Step.ShortName should have comment or be unexported (golint)
  • Line 67: warning: exported type StepShared should have comment or be unexported (golint)
  • Line 81: warning: exported method Message.Shared should have comment or be unexported (golint)
  • Line 82: warning: exported method Message.ShortName should have comment or be unexported (golint)
  • Line 91: warning: exported method Render.Shared should have comment or be unexported (golint)
  • Line 93: warning: exported method Render.ShortName should have comment or be unexported (golint)
  • Line 94: warning: exported method Render.RenderRoot should have comment or be unexported (golint)
  • Line 108: warning: exported method Terraform.Shared should have comment or be unexported (golint)
  • Line 109: warning: exported method Terraform.ShortName should have comment or be unexported (golint)
  • Line 121: warning: exported method Unfork.OverlayPath should have comment or be unexported (golint)
  • Line 128: warning: exported method Unfork.Shared should have comment or be unexported (golint)
  • Line 128: warning: receiver name u should be consistent with previous receiver name k for Unfork (golint)
  • Line 129: warning: exported method Unfork.ShortName should have comment or be unexported (golint)
  • Line 140: warning: exported method Kustomize.OverlayPath should have comment or be unexported (golint)
  • Line 147: warning: exported method Kustomize.Shared should have comment or be unexported (golint)
  • Line 148: warning: exported method Kustomize.ShortName should have comment or be unexported (golint)
  • Line 149: warning: exported method Kustomize.TempRenderPath should have comment or be unexported (golint)
  • Line 156: warning: exported method KustomizeIntro.Shared should have comment or be unexported (golint)
  • Line 157: warning: exported method KustomizeIntro.ShortName should have comment or be unexported (golint)
  • Line 165: warning: exported method HelmIntro.Shared should have comment or be unexported (golint)
  • Line 166: warning: exported method HelmIntro.ShortName should have comment or be unexported (golint)
  • Line 184: warning: exported method HelmValues.Shared should have comment or be unexported (golint)
  • Line 185: warning: exported method HelmValues.ShortName should have comment or be unexported (golint)
  • Line 187: warning: exported type ConfigStep should have comment or be unexported (golint)
  • Line 191: warning: exported method ConfigStep.Shared should have comment or be unexported (golint)
  • Line 195: warning: exported method ConfigStep.ShortName should have comment or be unexported (golint)
  • Line 206: warning: exported method KubectlApply.Shared should have comment or be unexported (golint)
  • Line 207: warning: exported method KubectlApply.ShortName should have comment or be unexported (golint)

• ship/pkg/images/image.go
  • Line 15: warning: exported type PullURLResolver should have comment or be unexported (golint)
  • Line 21: warning: exported type URLResolver should have comment or be unexported (golint)
  • Line 25: warning: exported function URLResolverFromViper should have comment or be unexported (golint)
  • Line 31: warning: exported method URLResolver.ResolvePullURL should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/local/render.go
  • Line 16: warning: exported type Renderer should have comment or be unexported (golint)
  • Line 27: warning: exported type LocalRenderer should have comment or be unexported (golint)
  • Line 32: warning: exported function NewRenderer should have comment or be unexported (golint)
  • Line 42: warning: exported method LocalRenderer.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/helm/render.go
  • Line 43: warning: exported method LocalRenderer.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/routes_v1_config.go
  • Line 3: warning: exported method V1Routes.MessageConfirmedChan should have comment or be unexported (golint)
  • Line 7: warning: exported method V1Routes.ConfigSavedChan should have comment or be unexported (golint)
  • Line 11: warning: exported method V1Routes.GetCurrentConfig should have comment or be unexported (golint)

• ship/pkg/lifecycle/kubectl/kubectl.go
  • Line 22: warning: exported type ForkKubectl should have comment or be unexported (golint)
  • Line 28: warning: exported function NewKubectl should have comment or be unexported (golint)
  • Line 49: warning: exported method ForkKubectl.Execute should have comment or be unexported (golint)

• ship/pkg/version/version.go
  • Line 22: warning: exported type BuildDependencies should have comment or be unexported (golint)
  • Line 28: warning: exported type GoInfo should have comment or be unexported (golint)

• ship/pkg/templates/random.go
  • Line 15: warning: exported const DefaultCharset should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: comment on exported method StaticCtx.RandomString should be of the form "RandomString ..." (golint)

• ship/pkg/filetree/loader.go
  • Line 18: warning: exported const CustomResourceDefinition should have comment (or a comment on this block) or be unexported (golint)
  • Line 194: warning: exported function IsSupported should have comment or be unexported (golint)

• ship/pkg/helm/repo_add.go
  • Line 53: warning: exported function RepoAdd should have comment or be unexported (golint)

• ship/pkg/state/manager.go
  • Line 19: warning: exported type Manager should have comment or be unexported (golint)
  • Line 71: warning: exported method MManager.Save should have comment or be unexported (golint)
  • Line 86: warning: exported function GetSingleton should have comment or be unexported (golint)
  • Line 114: warning: comment on exported function NewDisposableManager should be of the form "NewDisposableManager ..." (golint)
  • Line 128: warning: exported type Update should have comment or be unexported (golint)
  • Line 130: warning: exported method MManager.ReloadFile should have comment or be unexported (golint)
  • Line 141: warning: comment on exported method MManager.StateUpdate should be of the form "StateUpdate ..." (golint)
  • Line 288: warning: comment on exported method MManager.SerializeUpstreamContents should be of the form "SerializeUpstreamContents ..." (golint)
  • Line 329: warning: exported method MManager.CommitState should have comment or be unexported (golint)
  • Line 375: warning: exported method MManager.SaveKustomize should have comment or be unexported (golint)
  • Line 440: warning: exported method MManager.AddCert should have comment or be unexported (golint)
  • Line 455: warning: exported method MManager.AddCA should have comment or be unexported (golint)
  • Line 475: warning: exported method MManager.UpdateVersion should have comment or be unexported (golint)

• ship/pkg/lifecycle/unfork/pre_unfork.go
  • Line 10: warning: exported type ListK8sYaml should have comment or be unexported (golint)
  • Line 16: warning: exported method Unforker.PreExecute should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/actions.go
  • Line 7: warning: exported function MessageActions should have comment or be unexported (golint)
  • Line 22: warning: exported function HelmIntroActions should have comment or be unexported (golint)
  • Line 37: warning: exported function HelmValuesActions should have comment or be unexported (golint)

• ship/pkg/specs/chart.go
  • Line 23: warning: exported method Resolver.DefaultHelmUnforkRelease should have comment or be unexported (golint)
  • Line 87: warning: exported method Resolver.DefaultHelmRelease should have comment or be unexported (golint)
  • Line 198: warning: exported method Resolver.DefaultRawRelease should have comment or be unexported (golint)

• ship/pkg/util/kubernetes_name.go
  • Line 8: warning: exported type MinimalK8sYaml should have comment or be unexported (golint)
  • Line 13: warning: exported type MinimalK8sMetadata should have comment or be unexported (golint)
  • Line 18: warning: exported function GenerateNameFromMetadata should have comment or be unexported (golint)

• ship/pkg/images/save.go
  • Line 35: warning: exported type SaveOpts should have comment or be unexported (golint)
  • Line 45: warning: exported type DestinationParams should have comment or be unexported (golint)
  • Line 58: warning: exported function NewImageSaver should have comment or be unexported (golint)
  • Line 64: warning: exported method CLISaver.SaveImage should have comment or be unexported (golint)

• ship/pkg/util/github.go
  • Line 10: warning: exported type GithubURL should have comment or be unexported (golint)
  • Line 22: warning: exported function ParseGithubURL should have comment or be unexported (golint)
  • Line 50: warning: comment on exported function IsGithubURL should be of the form "IsGithubURL ..." (golint)
  • Line 55: warning: exported method GithubURL.URL should have comment or be unexported (golint)

• ship/pkg/testing/matchers/matchers.go
  • Line 12: warning: exported type StartsWith should have comment or be unexported (golint)
  • Line 19: warning: exported method StartsWith.Matches should have comment or be unexported (golint)
  • Line 26: warning: exported type Is should have comment or be unexported (golint)
  • Line 34: warning: exported method Is.Matches should have comment or be unexported (golint)
  • Line 40: warning: exported type Contains should have comment or be unexported (golint)
  • Line 47: warning: exported method Contains.Matches should have comment or be unexported (golint)

• ship/pkg/ui/ui.go
  • Line 10: warning: exported function FromViper should have comment or be unexported (golint)

• ship/pkg/specs/interface.go
  • Line 21: warning: exported method Resolver.ResolveUnforkRelease should have comment or be unexported (golint)
  • Line 135: warning: comment on exported method Resolver.ResolveRelease should be of the form "ResolveRelease ..." (golint)

• ship/pkg/util/multidoc_yaml.go
  • Line 16: warning: comment on exported function MaybeSplitMultidocYaml should be of the form "MaybeSplitMultidocYaml ..." (golint)

• ship/pkg/api/asset.go
  • Line 102: warning: exported type ValuesFrom should have comment or be unexported (golint)
  • Line 109: warning: exported type ValuesFromLifecycle should have comment or be unexported (golint)
  • Line 117: warning: exported type HelmFetch should have comment or be unexported (golint)
  • Line 123: warning: comment on exported type TerraformAsset should be of the form "TerraformAsset ..." (with optional leading article) (golint)
  • Line 132: warning: comment on exported type EKSAsset should be of the form "EKSAsset ..." (with optional leading article) (golint)
  • Line 144: warning: comment on exported type GKEAsset should be of the form "GKEAsset ..." (with optional leading article) (golint)
  • Line 159: warning: exported type GCPProvider should have comment or be unexported (golint)
  • Line 165: warning: comment on exported type AKSAsset should be of the form "AKSAsset ..." (with optional leading article) (golint)
  • Line 178: warning: exported type Azure should have comment or be unexported (golint)

• ship/pkg/images/progress.go
  • Line 16: warning: exported type Progress should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/terraform/render.go
  • Line 27: warning: comment on exported type LocalRenderer should be of the form "LocalRenderer ..." (with optional leading article) (golint)
  • Line 36: warning: exported function NewRenderer should have comment or be unexported (golint)
  • Line 48: warning: exported method LocalRenderer.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/routes_v1.go
  • Line 28: warning: exported type V1Routes should have comment or be unexported (golint)
  • Line 63: warning: exported method V1Routes.Register should have comment or be unexported (golint)
  • Line 78: warning: exported method V1Routes.SetProgress should have comment or be unexported (golint)
  • Line 83: warning: exported method V1Routes.ClearProgress should have comment or be unexported (golint)
  • Line 88: warning: exported type SaveValuesRequest should have comment or be unexported (golint)

• ship/pkg/ship/ship.go
  • Line 30: warning: comment on exported type Ship should be of the form "Ship ..." (with optional leading article) (golint)
  • Line 106: warning: exported method Ship.Shutdown should have comment or be unexported (golint)
  • Line 133: warning: exported method Ship.Execute should have comment or be unexported (golint)

• ship/pkg/templates/util.go
  • Line 11: warning: exported function BuildDir should have comment or be unexported (golint)

• ship/pkg/util/exclude_kubernetes.go
  • Line 17: warning: comment on exported function ExcludeKubernetesResources should be of the form "ExcludeKubernetesResources ..." (golint)
  • Line 34: warning: comment on exported function ExcludeKubernetesResource should be of the form "ExcludeKubernetesResource ..." (golint)
  • Line 109: warning: comment on exported function ExcludeKubernetesPatch should be of the form "ExcludeKubernetesPatch ..." (golint)

• ship/pkg/util/marshalIndent.go
  • Line 10: warning: exported function MarshalIndent should have comment or be unexported (golint)

• ship/pkg/lifecycle/helmIntro/helmIntro.go
  • Line 1: warning: don't use MixedCaps in package name; helmIntro should be helmintro (golint)
  • Line 18: warning: exported type HelmIntro should have comment or be unexported (golint)
  • Line 23: warning: exported type DaemonlessHelmIntro should have comment or be unexported (golint)
  • Line 28: warning: exported method DaemonlessHelmIntro.Execute should have comment or be unexported (golint)
  • Line 33: warning: exported function NewHelmIntro should have comment or be unexported (golint)
  • Line 45: warning: exported method HelmIntro.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/googlegke/render.go
  • Line 42: warning: exported function NewRenderer should have comment or be unexported (golint)
  • Line 56: warning: exported method LocalRenderer.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/config/resolve/api.go
  • Line 19: warning: exported function NewRenderer should have comment or be unexported (golint)
  • Line 31: warning: exported const MissingRequiredValue should have comment or be unexported (golint)
  • Line 40: warning: exported type ValidationError should have comment or be unexported (golint)

• ship/pkg/helm/fetch.go
  • Line 65: warning: exported function Fetch should have comment or be unexported (golint)

• ship/pkg/templates/ship_context.go
  • Line 23: warning: exported method BuilderBuilder.NewShipContext should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/root/fs.go
  • Line 15: warning: exported method Fs.TempDir should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/routes_v1_kustomize.go
  • Line 11: warning: exported method V1Routes.KustomizeSavedChan should have comment or be unexported (golint)
  • Line 15: warning: exported method V1Routes.PushKustomizeStep should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/dockerlayer/layer.go
  • Line 20: warning: comment on exported type Unpacker should be of the form "Unpacker ..." (with optional leading article) (golint)
  • Line 29: warning: exported function TarArchiver should have comment or be unexported (golint)
  • Line 33: warning: exported function NewUnpacker should have comment or be unexported (golint)
  • Line 50: warning: exported method Unpacker.Execute should have comment or be unexported (golint)

• ship/pkg/specs/gogetter/go_getter.go
  • Line 20: warning: exported type GoGetter should have comment or be unexported (golint)
  • Line 27: warning: comment on exported method GoGetter.GetFiles should be of the form "GetFiles ..." (golint)
  • Line 90: warning: exported function IsGoGettable should have comment or be unexported (golint)
  • Line 95: warning: comment on exported function UntreeGithub should be of the form "UntreeGithub ..." (golint)
  • Line 107: warning: exported function IsShipYaml should have comment or be unexported (golint)

• ship/pkg/specs/apptype/determine_type.go
  • Line 27: warning: exported type LocalAppCopy should have comment or be unexported (golint)
  • Line 33: warning: exported type Inspector should have comment or be unexported (golint)
  • Line 42: warning: exported function NewInspector should have comment or be unexported (golint)
  • Line 68: warning: exported type FileFetcher should have comment or be unexported (golint)
  • Line 197: warning: exported function NewLocalAppCopy should have comment or be unexported (golint)

• ship/pkg/lifecycle/terraform/daemonless.go
  • Line 24: warning: exported type DaemonlessTerraformer should have comment or be unexported (golint)
  • Line 40: warning: exported function NewDaemonlessTerraformer should have comment or be unexported (golint)
  • Line 65: warning: exported method DaemonlessTerraformer.WithStatusReceiver should have comment or be unexported (golint)
  • Line 82: warning: exported method DaemonlessTerraformer.Execute should have comment or be unexported (golint)

• ship/pkg/templates/config_context.go
  • Line 13: warning: exported method BuilderBuilder.NewConfigContext should have comment or be unexported (golint)

• ship/pkg/lifecycle/message/daemonless.go
  • Line 12: warning: exported function NewDaemonlessMessenger should have comment or be unexported (golint)
  • Line 20: warning: exported type DaemonlessMessenger should have comment or be unexported (golint)
  • Line 25: warning: exported method DaemonlessMessenger.Execute should have comment or be unexported (golint)

• ship/pkg/util/filesystem_test.go
  • Line 318: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ship/pkg/lifecycle/daemon/daemontypes/progress.go
  • Line 9: warning: exported type Progress should have comment or be unexported (golint)
  • Line 35: warning: exported function StringProgress should have comment or be unexported (golint)
  • Line 41: warning: exported function JSONProgress should have comment or be unexported (golint)
  • Line 51: warning: exported function MessageProgress should have comment or be unexported (golint)
  • Line 61: warning: comment on exported type ProgressMap should be of the form "ProgressMap ..." (with optional leading article) (golint)
  • Line 66: warning: exported method ProgressMap.Load should have comment or be unexported (golint)
  • Line 81: warning: exported method ProgressMap.Store should have comment or be unexported (golint)
  • Line 85: warning: exported method ProgressMap.Delete should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/routes_v1_unfork.go
  • Line 11: warning: exported method V1Routes.UnforkSavedChan should have comment or be unexported (golint)
  • Line 15: warning: exported method V1Routes.PushUnforkStep should have comment or be unexported (golint)

• ship/pkg/version/run.go
  • Line 8: warning: exported var RunAt should have comment or be unexported (golint)
  • Line 9: warning: exported var RunAtEpoch should have comment or be unexported (golint)

• ship/pkg/patch/kustomize.go
  • Line 15: warning: exported method ShipPatcher.RunKustomize should have comment or be unexported (golint)

• ship/pkg/specs/replicatedapp/resolver.go
  • Line 84: warning: exported type Resolver should have comment or be unexported (golint)

• ship/pkg/templates/static_context.go
  • Line 33: warning: exported method BuilderBuilder.NewStaticContext should have comment or be unexported (golint)
  • Line 39: warning: comment on exported function NewStaticContext should be of the form "NewStaticContext ..." (golint)
  • Line 47: warning: exported type Ctx should have comment or be unexported (golint)
  • Line 51: warning: exported type StaticCtx should have comment or be unexported (golint)
  • Line 55: warning: exported method StaticCtx.FuncMap should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/constructors.go
  • Line 20: warning: exported type OptionalRoutes should have comment or be unexported (golint)
  • Line 26: warning: exported function NewHeadedDaemon should have comment or be unexported (golint)
  • Line 42: warning: exported function NewV2Router should have comment or be unexported (golint)
  • Line 88: warning: exported function NewV1Router should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/daemon.go
  • Line 30: warning: comment on exported type ShipDaemon should be of the form "ShipDaemon ..." (with optional leading article) (golint)
  • Line 43: warning: exported method ShipDaemon.AwaitShutdown should have comment or be unexported (golint)
  • Line 47: warning: comment on exported method ShipDaemon.EnsureStarted should be of the form "EnsureStarted ..." (golint)

• ship/pkg/util/warnings/warn.go
  • Line 13: warning: exported var WarnCannotRemoveState should have comment or be unexported (golint)
  • Line 21: warning: exported function WarnFileNotFound should have comment or be unexported (golint)
  • Line 33: warning: exported function IsWarning should have comment or be unexported (golint)
  • Line 39: warning: exported function StripStackIfWarning should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/config/resolver.go
  • Line 16: warning: exported type NoOpResolver should have comment or be unexported (golint)
  • Line 19: warning: exported method NoOpResolver.ResolveConfig should have comment or be unexported (golint)
  • Line 24: warning: exported function NewNoOpResolver should have comment or be unexported (golint)
  • Line 27: warning: exported function NewResolver should have comment or be unexported (golint)

• ship/pkg/cli/init.go
  • Line 17: warning: exported function Init should have comment or be unexported (golint)

• ship/pkg/process/process.go
  • Line 12: warning: exported type Process should have comment or be unexported (golint)
  • Line 16: warning: exported method Process.Fork should have comment or be unexported (golint)

• ship/pkg/specs/stategetter/client.go
  • Line 14: warning: exported type StateGetter should have comment or be unexported (golint)
  • Line 20: warning: exported function NewStateGetter should have comment or be unexported (golint)
  • Line 28: warning: exported method StateGetter.GetFiles should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/routes_v1_state.go
  • Line 35: warning: exported method V1Routes.CleanPreviousStep should have comment or be unexported (golint)
  • Line 41: warning: exported method V1Routes.PushMessageStep should have comment or be unexported (golint)
  • Line 55: warning: exported method V1Routes.PushStreamStep should have comment or be unexported (golint)
  • Line 72: warning: exported method V1Routes.TerraformConfirmedChan should have comment or be unexported (golint)
  • Line 76: warning: exported method V1Routes.PushRenderStep should have comment or be unexported (golint)
  • Line 88: warning: exported method V1Routes.PushHelmIntroStep should have comment or be unexported (golint)
  • Line 102: warning: exported method V1Routes.PushHelmValuesStep should have comment or be unexported (golint)
  • Line 116: warning: exported method V1Routes.SetStepName should have comment or be unexported (golint)
  • Line 122: warning: exported method V1Routes.AllStepsDone should have comment or be unexported (golint)

• ship/pkg/cli/version.go
  • Line 11: warning: exported function Version should have comment or be unexported (golint)

• ship/pkg/cli/edit.go
  • Line 11: warning: exported function Edit should have comment or be unexported (golint)

• ship/pkg/lifecycle/step.go
  • Line 13: warning: exported type StepExecutor should have comment or be unexported (golint)
  • Line 27: warning: exported method StepExecutor.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/statusonly/daemon.go
  • Line 16: warning: exported type StatusReceiver should have comment or be unexported (golint)
  • Line 22: warning: exported method StatusReceiver.SetStepName should have comment or be unexported (golint)
  • Line 26: warning: exported method StatusReceiver.SetProgress should have comment or be unexported (golint)
  • Line 30: warning: exported method StatusReceiver.ClearProgress should have comment or be unexported (golint)
  • Line 34: warning: exported method StatusReceiver.PushStreamStep should have comment or be unexported (golint)
  • Line 45: warning: exported method StatusReceiver.PushMessageStep should have comment or be unexported (golint)

• ship/pkg/state/models.go
  • Line 17: warning: exported type State should have comment or be unexported (golint)
  • Line 21: warning: exported method State.IsEmpty should have comment or be unexported (golint)
  • Line 25: warning: exported type V1 should have comment or be unexported (golint)
  • Line 50: warning: exported type License should have comment or be unexported (golint)
  • Line 58: warning: exported type Metadata should have comment or be unexported (golint)
  • Line 72: warning: exported type UpstreamContents should have comment or be unexported (golint)
  • Line 77: warning: exported type UpstreamFile should have comment or be unexported (golint)
  • Line 82: warning: exported type StepsCompleted should have comment or be unexported (golint)
  • Line 93: warning: exported type Lifeycle should have comment or be unexported (golint)
  • Line 97: warning: exported method Lifeycle.WithCompletedStep should have comment or be unexported (golint)
  • Line 110: warning: exported type Overlay should have comment or be unexported (golint)
  • Line 117: warning: exported function NewOverlay should have comment or be unexported (golint)
  • Line 125: warning: exported type Kustomize should have comment or be unexported (golint)
  • Line 129: warning: exported method Kustomize.Ship should have comment or be unexported (golint)
  • Line 140: warning: exported method State.CurrentKustomize should have comment or be unexported (golint)
  • Line 147: warning: exported method State.CurrentKustomizeOverlay should have comment or be unexported (golint)
  • Line 177: warning: exported type Terraform should have comment or be unexported (golint)
  • Line 182: warning: exported method State.CurrentConfig should have comment or be unexported (golint)
  • Line 201: warning: exported method State.CurrentHelmValues should have comment or be unexported (golint)
  • Line 208: warning: exported method State.CurrentHelmValuesDefaults should have comment or be unexported (golint)
  • Line 215: warning: exported method State.CurrentReleaseName should have comment or be unexported (golint)
  • Line 222: warning: exported method State.CurrentNamespace should have comment or be unexported (golint)
  • Line 229: warning: exported method State.Upstream should have comment or be unexported (golint)
  • Line 239: warning: exported method State.Versioned should have comment or be unexported (golint)
  • Line 246: warning: exported method State.WithCompletedStep should have comment or be unexported (golint)
  • Line 259: warning: exported method State.CurrentCAs should have comment or be unexported (golint)
  • Line 266: warning: exported method State.CurrentCerts should have comment or be unexported (golint)
  • Line 273: warning: exported method State.UpstreamContents should have comment or be unexported (golint)
  • Line 283: warning: exported type Image should have comment or be unexported (golint)
  • Line 290: warning: exported type GithubFile should have comment or be unexported (golint)
  • Line 298: warning: exported type GithubContent should have comment or be unexported (golint)
  • Line 374: warning: exported method State.ReleaseMetadata should have comment or be unexported (golint)

• ship/pkg/testing/logger/logger.go
  • Line 9: warning: exported type TestingT should have comment or be unexported (golint)
  • Line 13: warning: exported type TestLogger should have comment or be unexported (golint)
  • Line 17: warning: exported method TestLogger.Log should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/web/step.go
  • Line 22: warning: exported type Renderer should have comment or be unexported (golint)
  • Line 34: warning: exported type DefaultStep should have comment or be unexported (golint)
  • Line 42: warning: exported function NewStep should have comment or be unexported (golint)
  • Line 57: warning: exported type Built should have comment or be unexported (golint)
  • Line 66: warning: exported method DefaultStep.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/routes_navcycle_config.go
  • Line 12: warning: exported type ConfigOption should have comment or be unexported (golint)

• ship/pkg/api/amazoneks/types.go
  • Line 3: warning: exported type EKSCreatedVPC should have comment or be unexported (golint)
  • Line 10: warning: exported type EKSExistingVPC should have comment or be unexported (golint)
  • Line 16: warning: exported type EKSAutoscalingGroup should have comment or be unexported (golint)

• ship/integration/lib.go
  • Line 12: warning: should not use dot imports (golint)
  • Line 204: warning: exported function RecursiveCopy should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/helm/fetch.go
  • Line 40: warning: exported method ClientFetcher.FetchChart should have comment or be unexported (golint)

• ship/pkg/specs/constructor.go
  • Line 34: warning: exported function NewResolver should have comment or be unexported (golint)

• ship/pkg/templates/builder.go
  • Line 26: warning: exported type Builder should have comment or be unexported (golint)
  • Line 32: warning: exported type BuilderBuilder should have comment or be unexported (golint)
  • Line 38: warning: exported function NewBuilderBuilder should have comment or be unexported (golint)
  • Line 45: warning: exported method BuilderBuilder.BaseBuilder should have comment or be unexported (golint)
  • Line 55: warning: exported method BuilderBuilder.FullBuilder should have comment or be unexported (golint)
  • Line 78: warning: exported method BuilderBuilder.NewBuilder should have comment or be unexported (golint)
  • Line 89: warning: exported method Builder.AddCtx should have comment or be unexported (golint)
  • Line 100: warning: exported method Builder.Bool should have comment or be unexported (golint)
  • Line 126: warning: exported method Builder.Int should have comment or be unexported (golint)
  • Line 152: warning: exported method Builder.Uint should have comment or be unexported (golint)
  • Line 178: warning: exported method Builder.Float64 should have comment or be unexported (golint)
  • Line 204: warning: exported method Builder.BuildFuncMap should have comment or be unexported (golint)
  • Line 218: warning: exported method Builder.GetTemplate should have comment or be unexported (golint)
  • Line 229: warning: exported method Builder.RenderTemplate should have comment or be unexported (golint)

• ship/pkg/cli/unfork.go
  • Line 13: warning: exported function Unfork should have comment or be unexported (golint)

• ship/pkg/specs/replicatedapp/selector.go
  • Line 42: warning: comment on exported method Selector.UnmarshalFrom should be of the form "UnmarshalFrom ..." (golint)
  • Line 75: warning: exported method Selector.GetBasicAuthUsername should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/headless/daemon.go
  • Line 23: warning: exported type HeadlessDaemon should have comment or be unexported (golint)
  • Line 34: warning: exported method HeadlessDaemon.AwaitShutdown should have comment or be unexported (golint)
  • Line 38: warning: exported function NewHeadlessDaemon should have comment or be unexported (golint)
  • Line 56: warning: exported method HeadlessDaemon.PushKustomizeStep should have comment or be unexported (golint)
  • Line 57: warning: exported method HeadlessDaemon.PushMessageStep should have comment or be unexported (golint)
  • Line 58: warning: exported method HeadlessDaemon.PushRenderStep should have comment or be unexported (golint)
  • Line 60: warning: exported method HeadlessDaemon.KustomizeSavedChan should have comment or be unexported (golint)
  • Line 67: warning: exported method HeadlessDaemon.UnforkSavedChan should have comment or be unexported (golint)
  • Line 73: warning: exported method HeadlessDaemon.PushHelmIntroStep should have comment or be unexported (golint)
  • Line 76: warning: exported method HeadlessDaemon.PushHelmValuesStep should have comment or be unexported (golint)
  • Line 94: warning: exported method HeadlessDaemon.HeadlessSaveHelmValues should have comment or be unexported (golint)
  • Line 105: warning: exported method HeadlessDaemon.PushStreamStep should have comment or be unexported (golint)
  • Line 107: warning: exported method HeadlessDaemon.CleanPreviousStep should have comment or be unexported (golint)
  • Line 109: warning: exported method HeadlessDaemon.TerraformConfirmedChan should have comment or be unexported (golint)
  • Line 123: warning: exported method HeadlessDaemon.EnsureStarted should have comment or be unexported (golint)
  • Line 139: warning: exported method HeadlessDaemon.SetStepName should have comment or be unexported (golint)
  • Line 141: warning: exported method HeadlessDaemon.AllStepsDone should have comment or be unexported (golint)
  • Line 143: warning: exported method HeadlessDaemon.MessageConfirmedChan should have comment or be unexported (golint)
  • Line 149: warning: exported method HeadlessDaemon.ConfigSavedChan should have comment or be unexported (golint)
  • Line 155: warning: exported method HeadlessDaemon.GetCurrentConfig should have comment or be unexported (golint)
  • Line 176: warning: exported method HeadlessDaemon.HeadlessResolve should have comment or be unexported (golint)
  • Line 215: warning: exported method HeadlessDaemon.SetProgress should have comment or be unexported (golint)
  • Line 221: warning: exported method HeadlessDaemon.ClearProgress should have comment or be unexported (golint)

• ship/pkg/lifecycle/terraform/terraformer.go
  • Line 29: warning: exported type ForkTerraformer should have comment or be unexported (golint)
  • Line 42: warning: exported function NewTerraformer should have comment or be unexported (golint)
  • Line 84: warning: exported method ForkTerraformer.Execute should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/ui.go
  • Line 1: warning: package comment should be of the form "Package daemon ..." (golint)
  • Line 39: warning: exported type WebUIBuilder should have comment or be unexported (golint)
  • Line 41: warning: exported function WebUIFactoryFactory should have comment or be unexported (golint)

• ship/pkg/ship/update.go
  • Line 13: warning: exported method Ship.UpdateAndMaybeExit should have comment or be unexported (golint)
  • Line 21: warning: exported method Ship.Update should have comment or be unexported (golint)

• ship/pkg/specs/githubclient/client.go
  • Line 26: warning: exported type GitHubFetcher should have comment or be unexported (golint)
  • Line 33: warning: exported type GithubClient should have comment or be unexported (golint)
  • Line 39: warning: exported function NewGithubClient should have comment or be unexported (golint)
  • Line 56: warning: exported method GithubClient.GetFiles should have comment or be unexported (golint)
  • Line 222: warning: exported method GithubClient.ResolveReleaseNotes should have comment or be unexported (golint)
  • Line 258: warning: exported method GithubClient.ResolveLatestRelease should have comment or be unexported (golint)

• ship/pkg/lifecycle/terraform/tfplan/daemon_plan.go
  • Line 14: warning: exported type PlanConfirmer should have comment or be unexported (golint)
  • Line 24: warning: exported function NewPlanner should have comment or be unexported (golint)

• ship/pkg/lifecycle/terraform/tfplan/daemonless.go
  • Line 13: warning: exported type DaemonlessPlanner should have comment or be unexported (golint)
  • Line 18: warning: exported function NewDaemonlessPlanner should have comment or be unexported (golint)
  • Line 26: warning: exported method DaemonlessPlanner.WithStatusReceiver should have comment or be unexported (golint)
  • Line 33: warning: exported method DaemonlessPlanner.ConfirmPlan should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/github/render.go
  • Line 53: warning: exported function NewRenderer should have comment or be unexported (golint)
  • Line 69: warning: comment on exported method LocalRenderer.Execute should be of the form "Execute ..." (golint)

• ship/pkg/lifecycle/render/helm/template.go
  • Line 82: warning: exported method LocalTemplater.Template should have comment or be unexported (golint)

• ship/pkg/specs/upstream.go
  • Line 13: warning: exported const UpstreamVersionToken should have comment (or a comment on this block) or be unexported (golint)

• ship/pkg/lifecycle/render/factory.go
  • Line 24: warning: exported method Factory.Execute should have comment or be unexported (golint)
  • Line 29: warning: exported method Factory.WithPlanner should have comment or be unexported (golint)
  • Line 45: warning: exported method Factory.WithStatusReceiver should have comment or be unexported (golint)
  • Line 61: warning: exported function NewFactory should have comment or be unexported (golint)

• ship/pkg/api/spec.go
  • Line 21: warning: comment on exported type Image should be of the form "Image ..." (with optional leading article) (golint)
  • Line 29: warning: exported type GithubContent should have comment or be unexported (golint)
  • Line 49: warning: comment on exported type GithubFile should be of the form "GithubFile ..." (with optional leading article) (golint)
  • Line 64: warning: exported type ShipAppMetadata should have comment or be unexported (golint)
  • Line 75: warning: exported type License should have comment or be unexported (golint)
  • Line 83: warning: comment on exported type ReleaseMetadata should be of the form "ReleaseMetadata ..." (with optional leading article) (golint)
  • Line 111: warning: exported method ReleaseMetadata.ReleaseName should have comment or be unexported (golint)
  • Line 134: warning: comment on exported type Release should be of the form "Release ..." (with optional leading article) (golint)
  • Line 140: warning: exported method Release.FindRenderStep should have comment or be unexported (golint)
  • Line 149: warning: exported method Release.FindRenderRoot should have comment or be unexported (golint)

• ship/pkg/lifecycle/kustomize/daemonless.go
  • Line 23: warning: exported type Kustomizer should have comment or be unexported (golint)
  • Line 32: warning: exported function NewDaemonlessKustomizer should have comment or be unexported (golint)
  • Line 46: warning: exported method Kustomizer.Execute should have comment or be unexported (golint)

• ship/pkg/cli/watch.go
  • Line 12: warning: exported function Watch should have comment or be unexported (golint)

• ship/pkg/specs/localgetter/local_getter.go
  • Line 14: warning: exported type LocalGetter should have comment or be unexported (golint)
  • Line 19: warning: exported method LocalGetter.GetFiles should have comment or be unexported (golint)
  • Line 90: warning: exported function IsLocalFile should have comment or be unexported (golint)

• ship/pkg/lifecycle/daemon/routes_navcycle_kustomize.go
  • Line 17: warning: exported type SaveOverlayRequest should have comment or be unexported (golint)

• ship/pkg/lifecycle/render/noconfig.go
  • Line 24: warning: exported function NoConfigRenderer should have comment or be unexported (golint)

• ship/pkg/cli/app.go
  • Line 12: warning: exported function App should have comment or be unexported (golint)

• ship/pkg/helm/init.go
  • Line 83: warning: exported function Init should have comment or be unexported (golint)

• ship/pkg/lifecycle/helmValues/helmValues.go
  • Line 1: warning: don't use MixedCaps in package name; helmValues should be helmvalues (golint)
  • Line 28: warning: exported function NewHelmValues should have comment or be unexported (golint)

• ship/pkg/util/kubernetes_rebuild.go
  • Line 12: warning: exported type PostKustomizeFile should have comment or be unexported (golint)
  • Line 18: warning: exported type PostKustomizeFileCollection should have comment or be unexported (golint)
  • Line 32: warning: exported type ListK8sYaml should have comment or be unexported (golint)
  • Line 38: warning: exported function WritePostKustomizeFiles should have comment or be unexported (golint)

• ship/pkg/constants/filepaths.go
  • Line 45: warning: comment on exported var KustomizeRenderPath should be of the form "KustomizeRenderPath ..." (golint)
  • Line 47: warning: comment on exported var HelmValuesPath should be of the form "HelmValuesPath ..." (golint)
  • Line 49: warning: comment on exported var UpstreamContentsPath should be of the form "UpstreamContentsPath ..." (golint)
  • Line 51: warning: comment on exported var UpstreamAppReleasePath should be of the form "UpstreamAppReleasePath ..." (golint)
  • Line 55: warning: exported function SetShipRootDir should have comment or be unexported (golint)

• ship/pkg/lifecycle/kustomize/kustomizer.go
  • Line 27: warning: exported function NewDaemonKustomizer should have comment or be unexported (golint)

• ship/pkg/testing/tmpfs/tmp.go
  • Line 1: warning: package comment should be of the form "Package tmpfs ..." (golint)
  • Line 13: warning: exported function Tmpdir should have comment or be unexported (golint)
  • Line 24: warning: exported function Tmpfs should have comment or be unexported (golint)

• ship/pkg/patch/patcher.go
  • Line 24: warning: exported const PATCH_TOKEN should have comment or be unexported (golint)
  • Line 26: warning: exported const TempYamlPath should have comment or be unexported (golint)
  • Line 28: warning: exported type Patcher should have comment or be unexported (golint)
  • Line 36: warning: exported type ShipPatcher should have comment or be unexported (golint)
  • Line 41: warning: exported function NewShipPatcher should have comment or be unexported (golint)
  • Line 89: warning: exported method ShipPatcher.CreateTwoWayMergePatch should have comment or be unexported (golint)
  • Line 133: warning: exported method ShipPatcher.MergePatches should have comment or be unexported (golint)
  • Line 163: warning: exported method ShipPatcher.ApplyPatch should have comment or be unexported (golint)
  • Line 226: warning: exported method ShipPatcher.ModifyField should have comment or be unexported (golint)

• ship/pkg/lifecycle/runner.go
  • Line 19: warning: exported function NewRunner should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!