Preparing report...

Report for github.com/resin-io/edge-node-manager

A+    Excellent!    Found 16 issues across 21 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint23%

Golint is a linter for Go source code.

    • edge-node-manager/micro/nrf51822/nrf51822.go
    • Line 23: warning: exported const Success should have comment (or a comment on this block) or be unexported (golint)
    • Line 45: warning: exported type FIRMWARE should have comment or be unexported (golint)
    • Line 59: warning: exported method Nrf51822.InitialiseRadio should have comment or be unexported (golint)
    • Line 63: warning: exported method Nrf51822.CleanupRadio should have comment or be unexported (golint)
    • Line 67: warning: exported method Nrf51822.ExtractFirmware should have comment or be unexported (golint)
    • Line 99: warning: exported method Nrf51822.Update should have comment or be unexported (golint)
    • edge-node-manager/board/nrf51822dk/nrf51822dk.go
    • Line 15: warning: exported type Nrf51822dk should have comment or be unexported (golint)
    • Line 25: warning: exported method Nrf51822dk.InitialiseRadio should have comment or be unexported (golint)
    • Line 29: warning: exported method Nrf51822dk.CleanupRadio should have comment or be unexported (golint)
    • Line 33: warning: exported method Nrf51822dk.Update should have comment or be unexported (golint)
    • Line 82: warning: exported method Nrf51822dk.Scan should have comment or be unexported (golint)
    • Line 86: warning: exported method Nrf51822dk.Online should have comment or be unexported (golint)
    • Line 90: warning: exported method Nrf51822dk.Restart should have comment or be unexported (golint)
    • Line 95: warning: exported method Nrf51822dk.Identify should have comment or be unexported (golint)
    • Line 100: warning: exported method Nrf51822dk.UpdateConfig should have comment or be unexported (golint)
    • Line 107: warning: exported method Nrf51822dk.UpdateEnvironment should have comment or be unexported (golint)
    • edge-node-manager/supervisor/supervisor.go
    • Line 25: warning: exported function WaitUntilReady should have comment or be unexported (golint)
    • Line 47: warning: exported function DependentApplicationsList should have comment or be unexported (golint)
    • Line 120: warning: exported function DependentDeviceLog should have comment or be unexported (golint)
    • Line 156: warning: exported function DependentDeviceInfoUpdateWithOnlineState should have comment or be unexported (golint)
    • Line 196: warning: exported function DependentDeviceInfoUpdateWithoutOnlineState should have comment or be unexported (golint)
    • Line 234: warning: exported function DependentDeviceInfo should have comment or be unexported (golint)
    • Line 258: warning: exported function DependentDeviceProvision should have comment or be unexported (golint)
    • Line 309: warning: exported function DependentDevicesList should have comment or be unexported (golint)
    • edge-node-manager/api/handlers.go
    • Line 18: warning: exported function DependentDeviceUpdate should have comment or be unexported (golint)
    • Line 42: warning: exported function DependentDeviceDelete should have comment or be unexported (golint)
    • Line 51: warning: exported function DependentDeviceRestart should have comment or be unexported (golint)
    • Line 60: warning: exported function DependentDevicesQuery should have comment or be unexported (golint)
    • Line 98: warning: exported function DependentDeviceQuery should have comment or be unexported (golint)
    • Line 147: warning: exported function SetStatus should have comment or be unexported (golint)
    • Line 171: warning: exported function GetStatus should have comment or be unexported (golint)
    • edge-node-manager/radio/bluetooth/bluetooth.go
    • Line 29: warning: exported function Initialise should have comment or be unexported (golint)
    • Line 64: warning: exported function Cleanup should have comment or be unexported (golint)
    • Line 68: warning: exported function Connect should have comment or be unexported (golint)
    • Line 87: warning: exported function Disconnect should have comment or be unexported (golint)
    • Line 100: warning: exported function WriteCharacteristic should have comment or be unexported (golint)
    • Line 114: warning: exported function ReadCharacteristic should have comment or be unexported (golint)
    • Line 136: warning: exported function WriteDescriptor should have comment or be unexported (golint)
    • Line 150: warning: exported function Scan should have comment or be unexported (golint)
    • Line 177: warning: exported function Online should have comment or be unexported (golint)
    • Line 205: warning: exported function GetName should have comment or be unexported (golint)
    • Line 223: warning: exported function GetCharacteristic should have comment or be unexported (golint)
    • Line 237: warning: exported function GetDescriptor should have comment or be unexported (golint)
    • edge-node-manager/board/board.go
    • Line 3: warning: exported type Type should have comment or be unexported (golint)
    • Line 6: warning: exported const MICROBIT should have comment (or a comment on this block) or be unexported (golint)
    • Line 11: warning: exported type Interface should have comment or be unexported (golint)
    • edge-node-manager/board/microbit/microbit.go
    • Line 15: warning: exported type Microbit should have comment or be unexported (golint)
    • Line 25: warning: exported method Microbit.InitialiseRadio should have comment or be unexported (golint)
    • Line 29: warning: exported method Microbit.CleanupRadio should have comment or be unexported (golint)
    • Line 33: warning: exported method Microbit.Update should have comment or be unexported (golint)
    • Line 78: warning: exported method Microbit.Scan should have comment or be unexported (golint)
    • Line 83: warning: exported method Microbit.Online should have comment or be unexported (golint)
    • Line 87: warning: exported method Microbit.Restart should have comment or be unexported (golint)
    • Line 92: warning: exported method Microbit.Identify should have comment or be unexported (golint)
    • Line 97: warning: exported method Microbit.UpdateConfig should have comment or be unexported (golint)
    • Line 104: warning: exported method Microbit.UpdateEnvironment should have comment or be unexported (golint)
    • edge-node-manager/board/esp8266/esp8266.go
    • Line 12: warning: exported type Esp8266 should have comment or be unexported (golint)
    • Line 17: warning: exported method Esp8266.InitialiseRadio should have comment or be unexported (golint)
    • Line 21: warning: exported method Esp8266.CleanupRadio should have comment or be unexported (golint)
    • Line 25: warning: exported method Esp8266.Update should have comment or be unexported (golint)
    • Line 42: warning: exported method Esp8266.Scan should have comment or be unexported (golint)
    • Line 46: warning: exported method Esp8266.Online should have comment or be unexported (golint)
    • Line 50: warning: exported method Esp8266.Restart should have comment or be unexported (golint)
    • Line 55: warning: exported method Esp8266.Identify should have comment or be unexported (golint)
    • Line 60: warning: exported method Esp8266.UpdateConfig should have comment or be unexported (golint)
    • Line 67: warning: exported method Esp8266.UpdateEnvironment should have comment or be unexported (golint)
    • edge-node-manager/radio/wifi/wifi.go
    • Line 22: warning: exported type Host should have comment or be unexported (golint)
    • Line 29: warning: exported function Initialise should have comment or be unexported (golint)
    • Line 47: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 80: warning: exported function Cleanup should have comment or be unexported (golint)
    • Line 85: warning: exported function Scan should have comment or be unexported (golint)
    • Line 102: warning: exported function Online should have comment or be unexported (golint)
    • Line 117: warning: exported function GetIP should have comment or be unexported (golint)
    • Line 132: warning: exported function PostForm should have comment or be unexported (golint)
    • edge-node-manager/device/device.go
    • Line 17: warning: exported type Device should have comment or be unexported (golint)
    • Line 67: warning: exported function New should have comment or be unexported (golint)
    • Line 80: warning: exported method Device.PopulateBoard should have comment or be unexported (golint)
    • edge-node-manager/device/hook/hook.go
    • Line 12: warning: exported type Hook should have comment or be unexported (golint)
    • Line 16: warning: exported method Hook.Fire should have comment or be unexported (golint)
    • Line 24: warning: exported method Hook.Levels should have comment or be unexported (golint)
    • Line 35: warning: exported function Create should have comment or be unexported (golint)
    • edge-node-manager/radio/wifi/nm.go
    • Line 9: warning: exported type NmDeviceState should have comment or be unexported (golint)
    • Line 12: warning: exported const NmDeviceStateUnknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 18: warning: don't use underscores in Go names; const NmDeviceStateNeed_auth should be NmDeviceStateNeedAuth (golint)
    • Line 19: warning: don't use underscores in Go names; const NmDeviceStateIp_config should be NmDeviceStateIPConfig (golint)
    • Line 20: warning: don't use underscores in Go names; const NmDeviceStateIp_check should be NmDeviceStateIPCheck (golint)
    • Line 27: warning: exported type NmDeviceType should have comment or be unexported (golint)
    • Line 30: warning: exported const NmDeviceTypeUnknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 48: warning: exported type NmActiveConnectionState should have comment or be unexported (golint)
    • Line 51: warning: exported const NmActiveConnectionStateUnknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 58: warning: exported type NmDevice should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!