Preparing report...

Report for github.com/rome314/quickfix

(v1.0.0)

A+    Excellent!    Found 13 issues across 113 files

Tweet

gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint94%

Golint is a linter for Go source code.

    • acceptor.go
    • Line 133: warning: comment on exported method Acceptor.RemoteAddr should be of the form "RemoteAddr ..." (golint)
    • fix_utc_timestamp.go
    • Line 11: warning: exported const Seconds should have comment (or a comment on this block) or be unexported (golint)
    • store_test.go
    • Line 116: warning: receiver name suite should be consistent with previous receiver name s for MessageStoreTestSuite (golint)
    • Line 125: warning: receiver name suite should be consistent with previous receiver name s for MessageStoreTestSuite (golint)
    • internal/event_timer.go
    • Line 8: warning: exported type EventTimer should have comment or be unexported (golint)
    • Line 15: warning: exported function NewEventTimer should have comment or be unexported (golint)
    • Line 43: warning: exported method EventTimer.Stop should have comment or be unexported (golint)
    • Line 52: warning: exported method EventTimer.Reset should have comment or be unexported (golint)

gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • session_factory.go
    • Line 67: warning: cyclomatic complexity 63 of function (sessionFactory).newSession() is high (> 15) (gocyclo)
    • validation.go
    • Line 313: warning: cyclomatic complexity 35 of function validateField() is high (> 15) (gocyclo)
    • acceptor.go
    • Line 205: warning: cyclomatic complexity 26 of function (*Acceptor).handleConnection() is high (> 15) (gocyclo)
    • Line 46: warning: cyclomatic complexity 18 of function (*Acceptor).Start() is high (> 15) (gocyclo)
    • tls.go
    • Line 12: warning: cyclomatic complexity 20 of function loadTLSConfig() is high (> 15) (gocyclo)
    • message.go
    • Line 139: warning: cyclomatic complexity 19 of function ParseMessageWithDataDictionary() is high (> 15) (gocyclo)
    • session.go
    • Line 397: warning: cyclomatic complexity 17 of function (*session).handleLogon() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell99%

Misspell Finds commonly misspelled English words