Last refresh: 3 years ago

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint76%

Golint is a linter for Go source code.

- Line 80: warning: exported type Config should have comment or be unexported (golint)

- Line 55: warning: exported method MonStore.SetIfChanged should have comment or be unexported (golint)

- Line 21: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 42: warning: exported type Param should have comment or be unexported (golint)
- Line 80: warning: exported var CSIParam should have comment or be unexported (golint)
- Line 87: warning: comment on exported var CephFSDriverName should be of the form "CephFSDriverName ..." (golint)
- Line 91: warning: comment on exported var ConfigName should be of the form "ConfigName ..." (golint)
- Line 131: warning: exported const KubeMinMajor should have comment (or a comment on this block) or be unexported (golint)
- Line 164: warning: comment on exported const DefaultKubeletDirPath should be of the form "DefaultKubeletDirPath ..." (golint)
- Line 167: warning: comment on exported const DefaultCephFSGRPCMerticsPort should be of the form "DefaultCephFSGRPCMerticsPort ..." (golint)
- Line 190: warning: exported function CSIEnabled should have comment or be unexported (golint)

- Line 3: warning: exported type FakeQuota should have comment or be unexported (golint)
- Line 5: warning: exported function NewFakeProjectQuota should have comment or be unexported (golint)
- Line 9: warning: exported method FakeQuota.CreateProjectQuota should have comment or be unexported (golint)
- Line 13: warning: exported method FakeQuota.RemoveProjectQuota should have comment or be unexported (golint)
- Line 17: warning: exported method FakeQuota.RestoreProjectQuota should have comment or be unexported (golint)

- Line 115: warning: error should be the last type when returning multiple items (golint)
- Line 210: warning: don't use underscores in Go names; var device_list should be deviceList (golint)

- Line 72: warning: exported function BackendVersion should have comment or be unexported (golint)

- Line 51: warning: comment on exported function GerMemberServicesForRack should be of the form "GerMemberServicesForRack ..." (golint)
- Line 133: warning: comment on exported function IsPodUnschedulable should be of the form "IsPodUnschedulable ..." (golint)

- Line 39: warning: exported function NewS3Agent should have comment or be unexported (golint)
- Line 43: warning: exported function NewTestOnlyS3Agent should have comment or be unexported (golint)
- Line 89: warning: comment on exported method S3Agent.CreateBucketNoInfoLogging should be of the form "CreateBucketNoInfoLogging ..." (golint)
- Line 205: warning: exported function BuildTransportTLS should have comment or be unexported (golint)

- Line 32: warning: exported function WriteFile should have comment or be unexported (golint)
- Line 44: warning: exported function WriteFileToLog should have comment or be unexported (golint)

- Line 53: warning: exported method FakeVolumeManager.Expand should have comment or be unexported (golint)

- Line 72: warning: context.Context should be the first parameter of a function (golint)

- Line 41: warning: exported function NewPatcher should have comment or be unexported (golint)
- Line 75: warning: exported method Patcher.Patch should have comment or be unexported (golint)

- Line 217: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 311: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

- Line 26: warning: exported function TestLabelsApply should have comment or be unexported (golint)
- Line 80: warning: exported function TestLabelsMerge should have comment or be unexported (golint)

- Line 19: warning: exported type MockFlexvolumeController should have comment or be unexported (golint)
- Line 28: warning: exported method MockFlexvolumeController.Attach should have comment or be unexported (golint)
- Line 35: warning: exported method MockFlexvolumeController.Detach should have comment or be unexported (golint)
- Line 42: warning: exported method MockFlexvolumeController.DetachForce should have comment or be unexported (golint)
- Line 49: warning: exported method MockFlexvolumeController.RemoveAttachmentObject should have comment or be unexported (golint)
- Line 56: warning: exported method MockFlexvolumeController.Log should have comment or be unexported (golint)
- Line 63: warning: exported method MockFlexvolumeController.GetAttachInfoFromMountDir should have comment or be unexported (golint)

- Line 24: warning: exported type NFSManifests should have comment or be unexported (golint)

- Line 32: warning: exported const CrushRootConfigKey should have comment (or a comment on this block) or be unexported (golint)
- Line 158: warning: comment on exported function GetCrushRootFromSpec should be of the form "GetCrushRootFromSpec ..." (golint)

- Line 31: warning: exported function StatefulSetNameForRack should have comment or be unexported (golint)
- Line 35: warning: exported function ServiceAccountNameForMembers should have comment or be unexported (golint)
- Line 39: warning: exported function HeadlessServiceNameForCluster should have comment or be unexported (golint)
- Line 43: warning: exported function ImageForCluster should have comment or be unexported (golint)
- Line 60: warning: exported function StatefulSetForRack should have comment or be unexported (golint)

- Line 38: warning: exported const MachineFencingLabelKey should have comment (or a comment on this block) or be unexported (golint)
- Line 44: warning: exported type ReconcileMachineLabel should have comment or be unexported (golint)

- Line 83: warning: don't use underscores in Go names; var memory_value should be memoryValue (golint)
- Line 86: warning: don't use underscores in Go names; var test_resource should be testResource (golint)

- Line 30: warning: exported type ConfigMapKVStore should have comment or be unexported (golint)
- Line 36: warning: exported function NewConfigMapKVStore should have comment or be unexported (golint)
- Line 44: warning: exported method ConfigMapKVStore.GetValue should have comment or be unexported (golint)
- Line 59: warning: exported method ConfigMapKVStore.SetValue should have comment or be unexported (golint)
- Line 63: warning: exported method ConfigMapKVStore.SetValueWithLabels should have comment or be unexported (golint)
- Line 102: warning: exported method ConfigMapKVStore.GetStore should have comment or be unexported (golint)
- Line 112: warning: exported method ConfigMapKVStore.ClearStore should have comment or be unexported (golint)

- Line 31: warning: exported function CephMgrMap should have comment or be unexported (golint)
- Line 49: warning: exported function CephMgrStat should have comment or be unexported (golint)

- Line 53: warning: exported const AppName should have comment (or a comment on this block) or be unexported (golint)

- Line 633: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 1: warning: package comment should be of the form "Package v1alpha2 ..." (golint)
- Line 25: warning: exported const Version should have comment (or a comment on this block) or be unexported (golint)
- Line 41: warning: exported var AddToScheme should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package version ..." (golint)

- Line 113: warning: exported function GetNodeHostNameLabel should have comment or be unexported (golint)

- Line 28: warning: exported method AnnotationsSpec.All should have comment or be unexported (golint)

- Line 53: warning: exported method TestCephSettings.ApplyEnvVars should have comment or be unexported (golint)

- Line 32: warning: exported type NFSInstaller should have comment or be unexported (golint)
- Line 38: warning: exported function NewNFSInstaller should have comment or be unexported (golint)

- Line 24: warning: exported var Cmd should have comment or be unexported (golint)

- Line 66: warning: exported const MinVersionForCronV1 should have comment (or a comment on this block) or be unexported (golint)

- Line 124: warning: comment on exported function AddUnreachableNodeToleration should be of the form "AddUnreachableNodeToleration ..." (golint)
- Line 257: warning: comment on exported function GetPodLog should be of the form "GetPodLog ..." (golint)
- Line 350: warning: exported function ForceDeletePodIfStuck should have comment or be unexported (golint)
- Line 377: warning: exported function RemoveDuplicateEnvVars should have comment or be unexported (golint)
- Line 401: warning: exported function IsPodScheduled should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package client ..." (golint)
- Line 44: warning: exported type CephStatus should have comment or be unexported (golint)
- Line 59: warning: exported type HealthStatus should have comment or be unexported (golint)
- Line 64: warning: exported type CheckMessage should have comment or be unexported (golint)
- Line 69: warning: exported type Summary should have comment or be unexported (golint)
- Line 73: warning: exported type MonMap should have comment or be unexported (golint)
- Line 81: warning: exported type MgrStat should have comment or be unexported (golint)
- Line 88: warning: exported type MgrMap should have comment or be unexported (golint)
- Line 97: warning: exported type MgrStandby should have comment or be unexported (golint)
- Line 102: warning: exported type OsdMap should have comment or be unexported (golint)
- Line 112: warning: exported type PgMap should have comment or be unexported (golint)
- Line 132: warning: exported type PgStateEntry should have comment or be unexported (golint)
- Line 154: warning: exported function Status should have comment or be unexported (golint)
- Line 170: warning: exported function StatusWithUser should have comment or be unexported (golint)

- Line 74: warning: exported function FlexDriverEnabled should have comment or be unexported (golint)
- Line 80: warning: exported function DiscoveryDaemonEnabled should have comment or be unexported (golint)

- Line 17: warning: package comment should be of the form "Package zonegroup ..." (golint)
- Line 212: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 282: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

- Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
- Line 27: warning: exported const CustomResourceGroup should have comment (or a comment on this block) or be unexported (golint)
- Line 43: warning: exported var AddToScheme should have comment or be unexported (golint)

- Line 44: warning: exported const UnixSocketName should have comment (or a comment on this block) or be unexported (golint)
- Line 173: warning: comment on exported function LoadFlexSettings should be of the form "LoadFlexSettings ..." (golint)

- Line 38: warning: exported const PgAutoscaleModeProperty should have comment (or a comment on this block) or be unexported (golint)
- Line 42: warning: exported type CephStoragePoolSummary should have comment or be unexported (golint)
- Line 47: warning: exported type CephStoragePoolDetails should have comment or be unexported (golint)
- Line 60: warning: exported type CephStoragePoolStats should have comment or be unexported (golint)
- Line 78: warning: exported type PoolStatistics should have comment or be unexported (golint)
- Line 91: warning: exported function ListPoolSummaries should have comment or be unexported (golint)
- Line 107: warning: exported function GetPoolNamesByID should have comment or be unexported (golint)
- Line 153: warning: exported function CreatePoolWithProfile should have comment or be unexported (golint)
- Line 344: warning: exported function GetErasureCodeProfileForPool should have comment or be unexported (golint)
- Line 348: warning: exported function CreateECPoolForApp should have comment or be unexported (golint)
- Line 369: warning: exported function CreateReplicatedPoolForApp should have comment or be unexported (golint)
- Line 611: warning: exported function GetPoolStats should have comment or be unexported (golint)
- Line 626: warning: exported function GetPoolStatistics should have comment or be unexported (golint)

- Line 79: warning: comment on exported function PatchClusterStatus should be of the form "PatchClusterStatus ..." (golint)

- Line 62: warning: don't use underscores in Go names; const access_key should be accessKey (golint)

- Line 27: warning: comment on exported const Version1_6 should be of the form "Version1_6 ..." (golint)
- Line 36: warning: exported method CephManifestsV1_6.Settings should have comment or be unexported (golint)
- Line 40: warning: exported method CephManifestsV1_6.GetCRDs should have comment or be unexported (golint)
- Line 47: warning: comment on exported method CephManifestsV1_6.GetOperator should be of the form "GetOperator ..." (golint)
- Line 63: warning: comment on exported method CephManifestsV1_6.GetToolbox should be of the form "GetToolbox ..." (golint)
- Line 72: warning: exported method CephManifestsV1_6.GetCommonExternal should have comment or be unexported (golint)
- Line 84: warning: comment on exported method CephManifestsV1_6.GetCephCluster should be of the form "GetCephCluster ..." (golint)
- Line 191: warning: exported method CephManifestsV1_6.GetBlockSnapshotClass should have comment or be unexported (golint)
- Line 207: warning: exported method CephManifestsV1_6.GetFileStorageSnapshotClass should have comment or be unexported (golint)
- Line 223: warning: exported method CephManifestsV1_6.GetBlockPool should have comment or be unexported (golint)
- Line 247: warning: exported method CephManifestsV1_6.GetBlockStorageClass should have comment or be unexported (golint)
- Line 281: warning: exported method CephManifestsV1_6.GetFileStorageClass should have comment or be unexported (golint)
- Line 324: warning: comment on exported method CephManifestsV1_6.GetNFS should be of the form "GetNFS ..." (golint)
- Line 339: warning: exported method CephManifestsV1_6.GetObjectStore should have comment or be unexported (golint)
- Line 366: warning: exported method CephManifestsV1_6.GetObjectStoreUser should have comment or be unexported (golint)
- Line 408: warning: exported method CephManifestsV1_6.GetClient should have comment or be unexported (golint)
- Line 424: warning: exported method CephManifestsV1_6.GetExternalCephCluster should have comment or be unexported (golint)

- Line 333: warning: comment on exported function CreateRBDMirrorBootstrapPeerWithoutPool should be of the form "CreateRBDMirrorBootstrapPeerWithoutPool ..." (golint)

- Line 165: warning: exported method VolumeManager.Expand should have comment or be unexported (golint)

- Line 124: warning: don't use underscores in Go names; var ceph_fsid should be cephFsid (golint)

- Line 25: warning: exported const WalSizeMBKey should have comment (or a comment on this block) or be unexported (golint)
- Line 85: warning: exported function MetadataDevice should have comment or be unexported (golint)

- Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 1: warning: package comment should be of the form "Package nfsrookio ..." (golint)
- Line 19: warning: exported const CustomResourceGroupName should have comment (or a comment on this block) or be unexported (golint)

- Line 34: warning: exported type Volume should have comment or be unexported (golint)
- Line 40: warning: exported type Attachment should have comment or be unexported (golint)
- Line 51: warning: exported type VolumeList should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package v1alpha2 ..." (golint)

- Line 53: warning: exported const ServiceServingCertCAFile should have comment (or a comment on this block) or be unexported (golint)

- Line 28: warning: exported function NewSimpleCluster should have comment or be unexported (golint)

- Line 375: warning: don't use underscores in Go names; var dev_sda should be devSda (golint)
- Line 376: warning: don't use underscores in Go names; var dev_sdb should be devSdb (golint)

- Line 39: warning: exported method BucketOperation.CreateBucketStorageClass should have comment or be unexported (golint)
- Line 43: warning: exported method BucketOperation.DeleteBucketStorageClass should have comment or be unexported (golint)
- Line 48: warning: exported method BucketOperation.CreateObc should have comment or be unexported (golint)
- Line 52: warning: exported method BucketOperation.DeleteObc should have comment or be unexported (golint)
- Line 56: warning: exported method BucketOperation.UpdateObc should have comment or be unexported (golint)
- Line 60: warning: comment on exported method BucketOperation.CheckOBC should be of the form "CheckOBC ..." (golint)
- Line 109: warning: comment on exported method BucketOperation.GetAccessKey should be of the form "GetAccessKey ..." (golint)
- Line 120: warning: exported method BucketOperation.GetSecretKey should have comment or be unexported (golint)
- Line 131: warning: comment on exported method BucketOperation.CheckOBMaxObject should be of the form "CheckOBMaxObject ..." (golint)

- Line 89: warning: exported method FilesystemOperation.DeletePVC should have comment or be unexported (golint)
- Line 95: warning: exported method FilesystemOperation.DeleteStorageClass should have comment or be unexported (golint)
- Line 106: warning: exported method FilesystemOperation.CreatePVC should have comment or be unexported (golint)
- Line 110: warning: exported method FilesystemOperation.CreatePod should have comment or be unexported (golint)
- Line 114: warning: exported method FilesystemOperation.DeleteSnapshotClass should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package client ..." (golint)
- Line 27: warning: exported type CephErasureCodeProfile should have comment or be unexported (golint)
- Line 36: warning: exported function ListErasureCodeProfiles should have comment or be unexported (golint)
- Line 52: warning: exported function GetErasureCodeProfileDetails should have comment or be unexported (golint)
- Line 68: warning: exported function CreateErasureCodeProfile should have comment or be unexported (golint)
- Line 102: warning: exported function DeleteErasureCodeProfile should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package client ..." (golint)
- Line 28: warning: exported type OSDUsage should have comment or be unexported (golint)
- Line 38: warning: exported type OSDNodeUsage should have comment or be unexported (golint)
- Line 52: warning: exported type OSDPerfStats should have comment or be unexported (golint)
- Line 62: warning: exported type OSDDump should have comment or be unexported (golint)
- Line 140: warning: exported type SafeToDestroyStatus should have comment or be unexported (golint)
- Line 204: warning: exported function GetOSDUsage should have comment or be unexported (golint)
- Line 219: warning: exported function GetOSDPerfStats should have comment or be unexported (golint)
- Line 234: warning: exported function GetOSDDump should have comment or be unexported (golint)
- Line 250: warning: exported function OSDOut should have comment or be unexported (golint)
- Line 256: warning: exported function OsdSafeToDestroy should have comment or be unexported (golint)

- Line 24: warning: exported const KeyAll should have comment (or a comment on this block) or be unexported (golint)

- Line 29: warning: exported const ServiceServingCertKey should have comment or be unexported (golint)
- Line 31: warning: exported method ObjectStoreSpec.IsMultisite should have comment or be unexported (golint)
- Line 35: warning: exported method ObjectStoreSpec.IsTLSEnabled should have comment or be unexported (golint)
- Line 39: warning: exported method ObjectStoreSpec.GetPort should have comment or be unexported (golint)
- Line 48: warning: exported method ObjectStoreSpec.IsExternal should have comment or be unexported (golint)
- Line 52: warning: exported method ObjectRealmSpec.IsPullRealm should have comment or be unexported (golint)
- Line 56: warning: exported method CephObjectStore.ValidateCreate should have comment or be unexported (golint)
- Line 82: warning: exported method CephObjectStore.ValidateUpdate should have comment or be unexported (golint)
- Line 91: warning: exported method CephObjectStore.ValidateDelete should have comment or be unexported (golint)
- Line 95: warning: exported method ObjectStoreSpec.GetServiceServingCert should have comment or be unexported (golint)
- Line 102: warning: exported method CephObjectStore.GetStatusConditions should have comment or be unexported (golint)
- Line 102: warning: receiver name c should be consistent with previous receiver name o for CephObjectStore (golint)

- Line 456: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

- Line 1: warning: package comment should be of the form "Package sys ..." (golint)
- Line 23: warning: comment on exported function Grep should be of the form "Grep ..." (golint)

- Line 30: warning: exported const OperatorChartName should have comment (or a comment on this block) or be unexported (golint)

- Line 47: warning: exported const RookEnvVarPrefix should have comment (or a comment on this block) or be unexported (golint)
- Line 51: warning: exported var RootCmd should have comment or be unexported (golint)
- Line 59: warning: exported var Cfg should have comment or be unexported (golint)
- Line 63: warning: exported type Config should have comment or be unexported (golint)
- Line 178: warning: exported function GetOperatorImage should have comment or be unexported (golint)
- Line 196: warning: exported function GetOperatorServiceAccount should have comment or be unexported (golint)
- Line 210: warning: exported function CheckOperatorResources should have comment or be unexported (golint)

- Line 48: warning: exported const AgentMountSecurityModeEnv should have comment (or a comment on this block) or be unexported (golint)

- Line 29: warning: exported const All should have comment (or a comment on this block) or be unexported (golint)
- Line 123: warning: comment on exported type PolicyStatement should be of the form "PolicyStatement ..." (with optional leading article) (golint)
- Line 182: warning: exported method S3Agent.GetBucketPolicy should have comment or be unexported (golint)
- Line 216: warning: exported method BucketPolicy.DropPolicyStatements should have comment or be unexported (golint)
- Line 228: warning: exported method BucketPolicy.EjectPrincipals should have comment or be unexported (golint)
- Line 250: warning: exported method PolicyStatement.WithSID should have comment or be unexported (golint)
- Line 311: warning: exported method PolicyStatement.EjectPrincipals should have comment or be unexported (golint)

- Line 287: warning: exported function GetDiskDeviceClass should have comment or be unexported (golint)

- Line 29: warning: exported function CreateConfigDir should have comment or be unexported (golint)

- Line 128: warning: exported function MergeResourceRequirements should have comment or be unexported (golint)
- Line 165: warning: exported function SetOwnerRefsWithoutBlockOwner should have comment or be unexported (golint)
- Line 184: warning: exported type ContainerResource should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package client ..." (golint)

- Line 24: warning: exported method FSMirroringSpec.SnapShotScheduleEnabled should have comment or be unexported (golint)

- Line 1078: warning: comment on exported type FilesystemMirroringInfoSpec should be of the form "FilesystemMirroringInfoSpec ..." (with optional leading article) (golint)
- Line 1159: warning: comment on exported type FilesystemMirroringInfo should be of the form "FilesystemMirroringInfo ..." (with optional leading article) (golint)
- Line 1198: warning: exported type PeerRemoteSpec should have comment or be unexported (golint)
- Line 1898: warning: exported type StorageScopeSpec should have comment or be unexported (golint)
- Line 1944: warning: exported type Selection should have comment or be unexported (golint)

- Line 45: warning: exported function LoggingFlags should have comment or be unexported (golint)

- Line 368: warning: exported method Cluster.DeleteMdsCephObjects should have comment or be unexported (golint)

- Line 44: warning: exported method PoolOperation.Create should have comment or be unexported (golint)
- Line 48: warning: exported method PoolOperation.Update should have comment or be unexported (golint)
- Line 56: warning: exported method PoolOperation.ListCephPools should have comment or be unexported (golint)
- Line 65: warning: exported method PoolOperation.GetCephPoolDetails should have comment or be unexported (golint)
- Line 74: warning: exported method PoolOperation.ListPoolCRDs should have comment or be unexported (golint)
- Line 87: warning: exported method PoolOperation.PoolCRDExists should have comment or be unexported (golint)
- Line 99: warning: exported method PoolOperation.CephPoolExists should have comment or be unexported (golint)

- Line 37: warning: exported const PVCNameEnvVarName should have comment (or a comment on this block) or be unexported (golint)

- Line 55: warning: exported const DaemonIDLabel should have comment (or a comment on this block) or be unexported (golint)
- Line 339: warning: exported function NetworkBindingFlags should have comment or be unexported (golint)
- Line 670: warning: exported function ConfigureExternalMetricsEndpoint should have comment or be unexported (golint)

- Line 85: warning: don't use underscores in Go names; var discovery_parameters should be discoveryParameters (golint)

- Line 17: warning: package comment should be of the form "Package k8sutil ..." (golint)

- Line 211: warning: exported function UsePDBV1Beta1Version should have comment or be unexported (golint)

- Line 36: warning: comment on exported const VaultFileName should be of the form "VaultFileName ..." (golint)

- Line 27: warning: exported const APIVersion should have comment (or a comment on this block) or be unexported (golint)
- Line 29: warning: comment on exported const ConditionTrue should be of the form "ConditionTrue ..." (golint)
- Line 52: warning: exported type Cluster should have comment or be unexported (golint)
- Line 63: warning: exported type ClusterList should have comment or be unexported (golint)
- Line 94: warning: exported type ClusterMode should have comment or be unexported (golint)
- Line 97: warning: exported const ClusterModeCassandra should have comment (or a comment on this block) or be unexported (golint)
- Line 169: warning: exported type RackConditionType should have comment or be unexported (golint)
- Line 172: warning: exported const RackConditionTypeMemberLeaving should have comment (or a comment on this block) or be unexported (golint)
- Line 175: warning: exported type ConditionStatus should have comment or be unexported (golint)
- Line 177: warning: exported type StorageScopeSpec should have comment or be unexported (golint)

- Line 22: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)

- Line 30: warning: exported function ValidateAndConfigureDrivers should have comment or be unexported (golint)

- Line 41: warning: exported const DoNotReconcileLabelName should have comment (or a comment on this block) or be unexported (golint)
- Line 668: warning: exported function IsDoNotReconcile should have comment or be unexported (golint)

- Line 30: warning: exported const RGWErrorNone should have comment (or a comment on this block) or be unexported (golint)
- Line 142: warning: exported function ListUserBuckets should have comment or be unexported (golint)

- Line 23: warning: exported type MockAttachment should have comment or be unexported (golint)
- Line 31: warning: exported method MockAttachment.Create should have comment or be unexported (golint)
- Line 37: warning: exported method MockAttachment.Get should have comment or be unexported (golint)
- Line 44: warning: exported method MockAttachment.List should have comment or be unexported (golint)
- Line 51: warning: exported method MockAttachment.Update should have comment or be unexported (golint)
- Line 58: warning: exported method MockAttachment.Delete should have comment or be unexported (golint)

- Line 22: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)

- Line 17: warning: package comment should be of the form "Package realm ..." (golint)

- Line 27: warning: exported type CephManifests should have comment or be unexported (golint)
- Line 67: warning: exported method CephManifestsMaster.Settings should have comment or be unexported (golint)
- Line 71: warning: exported method CephManifestsMaster.GetCRDs should have comment or be unexported (golint)
- Line 78: warning: exported method CephManifestsMaster.GetOperator should have comment or be unexported (golint)
- Line 88: warning: exported method CephManifestsMaster.GetCommonExternal should have comment or be unexported (golint)
- Line 92: warning: exported method CephManifestsMaster.GetCommon should have comment or be unexported (golint)
- Line 96: warning: exported method CephManifestsMaster.GetToolbox should have comment or be unexported (golint)
- Line 113: warning: exported method CephManifestsMaster.GetCephCluster should have comment or be unexported (golint)
- Line 235: warning: exported method CephManifestsMaster.GetBlockSnapshotClass should have comment or be unexported (golint)
- Line 251: warning: exported method CephManifestsMaster.GetFileStorageSnapshotClass should have comment or be unexported (golint)
- Line 267: warning: exported method CephManifestsMaster.GetBlockPool should have comment or be unexported (golint)
- Line 291: warning: exported method CephManifestsMaster.GetBlockStorageClass should have comment or be unexported (golint)
- Line 325: warning: exported method CephManifestsMaster.GetFileStorageClass should have comment or be unexported (golint)
- Line 368: warning: comment on exported method CephManifestsMaster.GetNFS should be of the form "GetNFS ..." (golint)
- Line 383: warning: exported method CephManifestsMaster.GetObjectStore should have comment or be unexported (golint)
- Line 436: warning: exported method CephManifestsMaster.GetObjectStoreUser should have comment or be unexported (golint)
- Line 478: warning: exported method CephManifestsMaster.GetClient should have comment or be unexported (golint)
- Line 494: warning: exported method CephManifestsMaster.GetExternalCephCluster should have comment or be unexported (golint)

- Line 26: warning: exported type CassandraManifests should have comment or be unexported (golint)
- Line 28: warning: exported method CassandraManifests.GetCassandraCRDs should have comment or be unexported (golint)
- Line 33: warning: exported method CassandraManifests.GetCassandraOperator should have comment or be unexported (golint)
- Line 40: warning: exported method CassandraManifests.GetCassandraCluster should have comment or be unexported (golint)

- Line 26: warning: exported var VaultTLSConnectionDetails should have comment or be unexported (golint)

- Line 27: warning: exported method MemberController.Sync should have comment or be unexported (golint)

- Line 88: warning: exported function GetMultusNamespace should have comment or be unexported (golint)

- Line 192: warning: comment on exported function GetPodAntiAffinity should be of the form "GetPodAntiAffinity ..." (golint)

- Line 34: warning: exported type ObjectBucketMetadata should have comment or be unexported (golint)
- Line 39: warning: exported type ObjectBucketStats should have comment or be unexported (golint)
- Line 44: warning: exported type ObjectBucket should have comment or be unexported (golint)
- Line 58: warning: exported type ObjectBuckets should have comment or be unexported (golint)
- Line 81: warning: exported function GetBucketStats should have comment or be unexported (golint)
- Line 91: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 106: warning: exported function GetBucketsStats should have comment or be unexported (golint)
- Line 176: warning: exported function GetBucket should have comment or be unexported (golint)

- Line 29: warning: exported const CustomResourceName should have comment (or a comment on this block) or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package v1 ..." (golint)
- Line 22: warning: exported method PlacementSpec.All should have comment or be unexported (golint)

- Line 46: warning: exported function NewBucketController should have comment or be unexported (golint)
- Line 119: warning: exported function MaxObjectQuota should have comment or be unexported (golint)
- Line 123: warning: exported function MaxSizeQuota should have comment or be unexported (golint)

- Line 17: warning: package comment should be of the form "Package osd ..." (golint)
- Line 31: warning: comment on exported var KubernetesTopologyLabels should be of the form "KubernetesTopologyLabels ..." (golint)
- Line 35: warning: comment on exported var CRUSHTopologyLabels should be of the form "CRUSHTopologyLabels ..." (golint)
- Line 39: warning: comment on exported var CRUSHMapLevelsOrdered should be of the form "CRUSHMapLevelsOrdered ..." (golint)
- Line 47: warning: comment on exported function ExtractOSDTopologyFromLabels should be of the form "ExtractOSDTopologyFromLabels ..." (golint)

- Line 4: warning: exported const CustomResourceGroupName should have comment (or a comment on this block) or be unexported (golint)

- Line 28: warning: exported const CustomResourceGroup should have comment (or a comment on this block) or be unexported (golint)
- Line 44: warning: exported var AddToScheme should have comment or be unexported (golint)

- Line 28: warning: exported function DeletionBlockedDueToDependentsCondition should have comment or be unexported (golint)

- Line 50: warning: exported const AccessKeyName should have comment (or a comment on this block) or be unexported (golint)
- Line 66: warning: comment on exported var DashboardUser should be of the form "DashboardUser ..." (golint)
- Line 290: warning: exported function DecodeSecret should have comment or be unexported (golint)
- Line 300: warning: exported function GetRealmKeyArgs should have comment or be unexported (golint)
- Line 578: warning: exported function DecodeZoneGroupConfig should have comment or be unexported (golint)
- Line 703: warning: exported function CreatePools should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package sys ..." (golint)
- Line 38: warning: exported function IsBuiltinKernelModule should have comment or be unexported (golint)
- Line 54: warning: exported function LoadKernelModule should have comment or be unexported (golint)
- Line 68: warning: exported function CheckKernelModuleParam should have comment or be unexported (golint)

- Line 32: warning: exported method ClusterSpec.IsStretchCluster should have comment or be unexported (golint)
- Line 36: warning: exported method CephCluster.ValidateCreate should have comment or be unexported (golint)
- Line 47: warning: exported method CephCluster.ValidateUpdate should have comment or be unexported (golint)
- Line 53: warning: exported method CephCluster.ValidateDelete should have comment or be unexported (golint)
- Line 83: warning: exported method CephCluster.GetStatusConditions should have comment or be unexported (golint)

- Line 26: warning: exported method LabelsSpec.All should have comment or be unexported (golint)

- Line 33: warning: exported method PoolSpec.IsReplicated should have comment or be unexported (golint)
- Line 37: warning: exported method PoolSpec.IsErasureCoded should have comment or be unexported (golint)
- Line 41: warning: exported method PoolSpec.IsHybridStoragePool should have comment or be unexported (golint)
- Line 45: warning: exported method PoolSpec.IsCompressionEnabled should have comment or be unexported (golint)
- Line 49: warning: exported method ReplicatedSpec.IsTargetRatioEnabled should have comment or be unexported (golint)
- Line 53: warning: exported method CephBlockPool.ValidateCreate should have comment or be unexported (golint)
- Line 89: warning: exported method CephBlockPool.ValidateUpdate should have comment or be unexported (golint)
- Line 110: warning: exported method CephBlockPool.ValidateDelete should have comment or be unexported (golint)

- Line 17: warning: package comment should be of the form "Package reporting ..." (golint)

- Line 91: warning: exported function AddCephVersionLabelToObjectMeta should have comment or be unexported (golint)

- Line 42: warning: comment on exported method ObjectOperation.Create should be of the form "Create ..." (golint)
- Line 60: warning: exported method ObjectOperation.Delete should have comment or be unexported (golint)
- Line 73: warning: comment on exported method ObjectOperation.GetEndPointUrl should be of the form "GetEndPointUrl ..." (golint)

- Line 44: warning: exported const MDBCephClusterNamespaceLabelKey should have comment (or a comment on this block) or be unexported (golint)

- Line 40: warning: exported var CephCommandsTimeout should have comment or be unexported (golint)

- Line 27: warning: exported const CustomResourceGroup should have comment (or a comment on this block) or be unexported (golint)
- Line 43: warning: exported var AddToScheme should have comment or be unexported (golint)

- Line 55: warning: exported function GetLivenessProbeWithDefaults should have comment or be unexported (golint)

- Line 50: warning: exported function CreateBootstrapPeerSecret should have comment or be unexported (golint)
- Line 165: warning: exported function GenerateStatusInfo should have comment or be unexported (golint)
- Line 178: warning: exported function ValidatePeerToken should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package sys ..." (golint)

- Line 17: warning: package comment should be of the form "Package nfs ..." (golint)

- Line 1: warning: package comment should be of the form "Package client ..." (golint)
- Line 34: warning: exported const ImageMinSize should have comment (or a comment on this block) or be unexported (golint)
- Line 37: warning: exported type CephBlockImage should have comment or be unexported (golint)
- Line 44: warning: exported function ListImages should have comment or be unexported (golint)
- Line 119: warning: exported function DeleteImage should have comment or be unexported (golint)
- Line 132: warning: exported function ExpandImage should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package v1 ..." (golint)
- Line 52: warning: comment on exported method StorageScopeSpec.ResolveNode should be of the form "ResolveNode ..." (golint)

- Line 76: warning: exported function StretchFailureDomainLabel should have comment or be unexported (golint)

- Line 110: warning: exported function NewMultisiteContext should have comment or be unexported (golint)
- Line 144: warning: exported function NewMultisiteAdminOpsContext should have comment or be unexported (golint)
- Line 295: warning: exported function GetAdminOPSUserCredentials should have comment or be unexported (golint)

- Line 30: warning: exported type MDSDump should have comment or be unexported (golint)
- Line 35: warning: exported type MDSStandBy should have comment or be unexported (golint)
- Line 186: warning: comment on exported function FailAllStandbyReplayMDS should be of the form "FailAllStandbyReplayMDS ..." (golint)
- Line 371: warning: exported function GetMDSDump should have comment or be unexported (golint)

- Line 65: warning: exported function NewClusterInfo should have comment or be unexported (golint)
- Line 69: warning: exported method ClusterInfo.SetName should have comment or be unexported (golint)
- Line 73: warning: exported method ClusterInfo.NamespacedName should have comment or be unexported (golint)
- Line 80: warning: comment on exported function AdminClusterInfo should be of the form "AdminClusterInfo ..." (golint)
- Line 135: warning: exported function NewMinimumOwnerInfo should have comment or be unexported (golint)
- Line 143: warning: exported function NewMinimumOwnerInfoWithOwnerRef should have comment or be unexported (golint)

- Line 133: warning: exported method RemotePodCommandExecutor.ExecCommandInContainerWithFullOutputWithTimeout should have comment or be unexported (golint)

- Line 119: warning: exported function WaitForDeploymentToStart should have comment or be unexported (golint)
- Line 168: warning: exported type Failure should have comment or be unexported (golint)
- Line 173: warning: exported type Failures should have comment or be unexported (golint)
- Line 175: warning: exported method Failures.CollatedErrors should have comment or be unexported (golint)
- Line 304: warning: exported function UpdateMultipleDeploymentsAndWait should have comment or be unexported (golint)
- Line 448: warning: exported function AddRookVersionLabelToObjectMeta should have comment or be unexported (golint)
- Line 455: warning: exported function AddLabelToDeployment should have comment or be unexported (golint)
- Line 465: warning: exported function AddLabelToPod should have comment or be unexported (golint)
- Line 475: warning: exported function AddLabelToJob should have comment or be unexported (golint)
- Line 502: warning: exported function CreateOrUpdateDeployment should have comment or be unexported (golint)

- Line 220: warning: exported function CreateTempPasswordFile should have comment or be unexported (golint)
- Line 311: warning: exported function GeneratePassword should have comment or be unexported (golint)

- Line 29: warning: exported function PredicateMonEndpointChanges should have comment or be unexported (golint)

- Line 324: warning: comment on exported function GetTlsCaCert should be of the form "GetTlsCaCert ..." (golint)
- Line 352: warning: exported function GenObjectStoreHTTPClient should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package flags ..." (golint)
- Line 34: warning: exported function VerifyRequiredFlags should have comment or be unexported (golint)
- Line 58: warning: exported function SetLoggingFlags should have comment or be unexported (golint)
- Line 70: warning: exported function SetFlagsFromEnv should have comment or be unexported (golint)

- Line 50: warning: exported type NFSServerReconciler should have comment or be unexported (golint)
- Line 58: warning: exported method NFSServerReconciler.Reconcile should have comment or be unexported (golint)

- Line 25: warning: exported type Webhook should have comment or be unexported (golint)
- Line 30: warning: exported function NewWebhook should have comment or be unexported (golint)
- Line 37: warning: exported method Webhook.Run should have comment or be unexported (golint)

- Line 1: warning: package comment should be of the form "Package client ..." (golint)
- Line 69: warning: exported type MonDumpEntry should have comment or be unexported (golint)

- Line 51: warning: exported type Provisioner should have comment or be unexported (golint)
- Line 73: warning: comment on exported method Provisioner.Provision should be of the form "Provision ..." (golint)
- Line 167: warning: exported method Provisioner.Delete should have comment or be unexported (golint)

- Line 26: warning: comment on exported function YamlToTolerations should be of the form "YamlToTolerations ..." (golint)

- Line 32: warning: exported const RBDSysBusPathDefault should have comment (or a comment on this block) or be unexported (golint)

- Line 123: warning: exported method K8sHelper.VersionAtLeast should have comment or be unexported (golint)
- Line 128: warning: exported method K8sHelper.VersionMinorMatches should have comment or be unexported (golint)
- Line 135: warning: exported method K8sHelper.MakeContext should have comment or be unexported (golint)
- Line 139: warning: exported method K8sHelper.GetDockerImage should have comment or be unexported (golint)
- Line 205: warning: exported method K8sHelper.Exec should have comment or be unexported (golint)
- Line 209: warning: exported method K8sHelper.ExecRemote should have comment or be unexported (golint)
- Line 336: warning: comment on exported method K8sHelper.DeleteResourceAndWait should be of the form "DeleteResourceAndWait ..." (golint)
- Line 360: warning: exported method K8sHelper.CreateNamespace should have comment or be unexported (golint)
- Line 371: warning: exported method K8sHelper.CountPodsWithLabel should have comment or be unexported (golint)
- Line 490: warning: exported method K8sHelper.GetPodDescribeFromNamespace should have comment or be unexported (golint)
- Line 510: warning: exported method K8sHelper.GetEventsFromNamespace should have comment or be unexported (golint)
- Line 541: warning: exported method K8sHelper.PrintPodDescribe should have comment or be unexported (golint)
- Line 559: warning: exported method K8sHelper.PrintEventsForNamespace should have comment or be unexported (golint)
- Line 689: warning: exported method K8sHelper.ReadFromPod should have comment or be unexported (golint)
- Line 693: warning: exported method K8sHelper.ReadFromPodRetry should have comment or be unexported (golint)
- Line 822: warning: exported method K8sHelper.PrintPVs should have comment or be unexported (golint)
- Line 844: warning: exported method K8sHelper.PrintPVCs should have comment or be unexported (golint)
- Line 866: warning: exported method K8sHelper.PrintResources should have comment or be unexported (golint)
- Line 876: warning: exported method K8sHelper.PrintStorageClasses should have comment or be unexported (golint)
- Line 924: warning: exported method K8sHelper.GetPodNamesForApp should have comment or be unexported (golint)
- Line 1032: warning: exported method K8sHelper.IsDefaultStorageClassPresent should have comment or be unexported (golint)
- Line 1048: warning: comment on exported method K8sHelper.CheckPvcCountAndStatus should be of the form "CheckPvcCountAndStatus ..." (golint)
- Line 1292: warning: exported method K8sHelper.WaitUntilPVCIsDeleted should have comment or be unexported (golint)
- Line 1307: warning: exported method K8sHelper.DeletePvcWithLabel should have comment or be unexported (golint)
- Line 1379: warning: exported method K8sHelper.GetRGWServiceURL should have comment or be unexported (golint)
- Line 1386: warning: comment on exported method K8sHelper.GetInternalRGWServiceURL should be of the form "GetInternalRGWServiceURL ..." (golint)
- Line 1399: warning: comment on exported method K8sHelper.GetExternalRGWServiceURL should be of the form "GetExternalRGWServiceURL ..." (golint)
- Line 1603: warning: exported method K8sHelper.DeleteRoleAndBindings should have comment or be unexported (golint)
- Line 1617: warning: exported method K8sHelper.DeleteRoleBinding should have comment or be unexported (golint)
- Line 1622: warning: exported method K8sHelper.ScaleStatefulSet should have comment or be unexported (golint)
- Line 1628: warning: exported function IsKubectlErrorNotFound should have comment or be unexported (golint)
- Line 1705: warning: exported method K8sHelper.WaitForCronJob should have comment or be unexported (golint)
- Line 1734: warning: exported method K8sHelper.GetResourceStatus should have comment or be unexported (golint)
- Line 1738: warning: exported method K8sHelper.WaitUntilResourceIsDeleted should have comment or be unexported (golint)

- Line 43: warning: exported type Provisioner should have comment or be unexported (golint)
- Line 64: warning: exported function NewProvisioner should have comment or be unexported (golint)
- Line 294: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 1: warning: package comment should be of the form "Package exec ..." (golint)

- Line 1: warning: package comment should be of the form "Package test ..." (golint)
- Line 25: warning: exported function MonInQuorumResponse should have comment or be unexported (golint)
- Line 38: warning: exported function MonInQuorumResponseFromMons should have comment or be unexported (golint)
- Line 54: warning: exported function MonInQuorumResponseMany should have comment or be unexported (golint)

- Line 56: warning: comment on exported const ImageKey should be of the form "ImageKey ..." (golint)
- Line 58: warning: comment on exported const DataBlockPoolKey should be of the form "DataBlockPoolKey ..." (golint)

- Line 23: warning: exported function GetPodWithVolume should have comment or be unexported (golint)
- Line 48: warning: exported function GetPVC should have comment or be unexported (golint)
- Line 63: warning: exported function GetPVCRestore should have comment or be unexported (golint)
- Line 82: warning: exported function GetPVCClone should have comment or be unexported (golint)
- Line 100: warning: exported function GetSnapshot should have comment or be unexported (golint)

- Line 31: warning: comment on exported function CreateHostPathPVs should be of the form "CreateHostPathPVs ..." (golint)
- Line 102: warning: exported function DeleteHostPathPVs should have comment or be unexported (golint)

- Line 34: warning: exported type VolumeController should have comment or be unexported (golint)
- Line 43: warning: exported type AttachOptions should have comment or be unexported (golint)
- Line 64: warning: exported type ExpandOptions should have comment or be unexported (golint)
- Line 75: warning: exported type ExpandArgs should have comment or be unexported (golint)
- Line 80: warning: exported type LogMessage should have comment or be unexported (golint)
- Line 85: warning: exported type GlobalMountPathInput should have comment or be unexported (golint)

- Line 181: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 246: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
- Line 30: warning: exported const Finalizer should have comment (or a comment on this block) or be unexported (golint)
- Line 34: warning: exported const EventCreated should have comment (or a comment on this block) or be unexported (golint)
- Line 39: warning: exported type NFSServerState should have comment or be unexported (golint)
- Line 42: warning: exported const StateInitializing should have comment (or a comment on this block) or be unexported (golint)

- Line 34: warning: exported type CassandraInstaller should have comment or be unexported (golint)
- Line 40: warning: exported function NewCassandraInstaller should have comment or be unexported (golint)
- Line 44: warning: exported method CassandraInstaller.InstallCassandra should have comment or be unexported (golint)
- Line 72: warning: exported method CassandraInstaller.CreateCassandraOperator should have comment or be unexported (golint)
- Line 99: warning: exported method CassandraInstaller.CreateCassandraCluster should have comment or be unexported (golint)
- Line 123: warning: exported method CassandraInstaller.DeleteCassandraCluster should have comment or be unexported (golint)
- Line 143: warning: exported method CassandraInstaller.UninstallCassandra should have comment or be unexported (golint)
- Line 167: warning: exported method CassandraInstaller.GatherAllCassandraLogs should have comment or be unexported (golint)

- Line 44: warning: exported function StorageClassName should have comment or be unexported (golint)
- Line 48: warning: exported function UsePVC should have comment or be unexported (golint)

- Line 159: warning: exported type SchedulingResult should have comment or be unexported (golint)
- Line 341: warning: exported method Cluster.ConfigureArbiter should have comment or be unexported (golint)

- Line 36: warning: exported type BlockImage should have comment or be unexported (golint)
- Line 49: warning: comment on exported method BlockOperation.Create should be of the form "Create ..." (golint)
- Line 65: warning: exported method BlockOperation.CreateStorageClassAndPVC should have comment or be unexported (golint)
- Line 75: warning: exported method BlockOperation.CreatePVC should have comment or be unexported (golint)
- Line 79: warning: exported method BlockOperation.CreatePod should have comment or be unexported (golint)
- Line 83: warning: exported method BlockOperation.CreateStorageClass should have comment or be unexported (golint)
- Line 87: warning: exported method BlockOperation.DeletePVC should have comment or be unexported (golint)
- Line 93: warning: exported method BlockOperation.CreatePVCRestore should have comment or be unexported (golint)
- Line 97: warning: exported method BlockOperation.CreatePVCClone should have comment or be unexported (golint)
- Line 101: warning: exported method BlockOperation.CreateSnapshotClass should have comment or be unexported (golint)
- Line 105: warning: exported method BlockOperation.DeleteSnapshotClass should have comment or be unexported (golint)
- Line 109: warning: exported method BlockOperation.CreateSnapshot should have comment or be unexported (golint)
- Line 113: warning: exported method BlockOperation.DeleteSnapshot should have comment or be unexported (golint)
- Line 117: warning: exported method BlockOperation.DeleteStorageClass should have comment or be unexported (golint)
- Line 128: warning: comment on exported method BlockOperation.DeleteBlock should be of the form "DeleteBlock ..." (golint)
- Line 143: warning: comment on exported method BlockOperation.ListAllImages should be of the form "ListAllImages ..." (golint)
- Line 163: warning: comment on exported method BlockOperation.ListImagesInPool should be of the form "ListImagesInPool ..." (golint)

- Line 44: warning: comment on exported function New should be of the form "New ..." (golint)

- Line 34: warning: comment on exported const CassandraTestSuite should be of the form "CassandraTestSuite ..." (golint)
- Line 36: warning: exported const CephTestSuite should have comment (or a comment on this block) or be unexported (golint)
- Line 48: warning: exported function SkipTestSuite should have comment or be unexported (golint)
- Line 63: warning: exported function SystemNamespace should have comment or be unexported (golint)

- Line 92: warning: exported type CephToolCommand should have comment or be unexported (golint)
- Line 112: warning: exported function NewCephCommand should have comment or be unexported (golint)
- Line 116: warning: exported function NewRBDCommand should have comment or be unexported (golint)
- Line 162: warning: exported method CephToolCommand.Run should have comment or be unexported (golint)
- Line 167: warning: exported method CephToolCommand.RunWithTimeout should have comment or be unexported (golint)
- Line 181: warning: exported function ExecuteCephCommandWithRetry should have comment or be unexported (golint)

- Line 31: warning: exported type BootstrapPeerToken should have comment or be unexported (golint)
- Line 93: warning: exported function AddSnapshotSchedule should have comment or be unexported (golint)
- Line 118: warning: exported function AddSnapshotScheduleRetention should have comment or be unexported (golint)
- Line 140: warning: exported function GetSnapshotScheduleStatus should have comment or be unexported (golint)

- Line 17: warning: package comment should be of the form "Package controller ..." (golint)

- Line 91: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 30: warning: exported const BinariesMountPath should have comment (or a comment on this block) or be unexported (golint)
- Line 83: warning: exported function BinariesMountInfo should have comment or be unexported (golint)

- Line 34: warning: exported const MessageRackCreated should have comment (or a comment on this block) or be unexported (golint)
- Line 39: warning: comment on exported const MessageHeadlessServiceSyncFailed should be of the form "MessageHeadlessServiceSyncFailed ..." (golint)

- Line 42: warning: comment on exported method ObjectUserOperation.GetUser should be of the form "GetUser ..." (golint)
- Line 76: warning: comment on exported method ObjectUserOperation.Create should be of the form "Create ..." (golint)
- Line 86: warning: exported method ObjectUserOperation.Delete should have comment or be unexported (golint)

- Line 18: warning: exported type Quotaer should have comment or be unexported (golint)
- Line 24: warning: exported type Quota should have comment or be unexported (golint)
- Line 29: warning: exported function NewProjectQuota should have comment or be unexported (golint)
- Line 119: warning: exported method Quota.CreateProjectQuota should have comment or be unexported (golint)
- Line 170: warning: exported method Quota.RemoveProjectQuota should have comment or be unexported (golint)
- Line 174: warning: exported method Quota.RestoreProjectQuota should have comment or be unexported (golint)

- Line 67: warning: exported var NautilusVersion should have comment or be unexported (golint)
- Line 157: warning: exported method CephInstaller.WaitForToolbox should have comment or be unexported (golint)
- Line 188: warning: error should be the last type when returning multiple items (golint)
- Line 481: warning: exported method CephInstaller.InstallRook should have comment or be unexported (golint)
- Line 839: warning: exported method CephInstaller.CollectOperatorLog should have comment or be unexported (golint)
- Line 847: warning: exported method CephInstaller.GatherAllRookLogs should have comment or be unexported (golint)

- Line 129: warning: exported function FindRookRoot should have comment or be unexported (golint)

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

- Line 98: warning: cyclomatic complexity 62 of function fsExecutor() is high (> 15) (gocyclo)
- Line 384: warning: cyclomatic complexity 29 of function TestUpgradeFilesystem() is high (> 15) (gocyclo)
- Line 255: warning: cyclomatic complexity 17 of function TestCreateFilesystem() is high (> 15) (gocyclo)

- Line 133: warning: cyclomatic complexity 33 of function (*Cluster).checkHealth() is high (> 15) (gocyclo)

- Line 617: warning: cyclomatic complexity 38 of function (*OsdAgent).initializeDevicesLVMMode() is high (> 15) (gocyclo)
- Line 268: warning: cyclomatic complexity 28 of function (*OsdAgent).initializeBlockPVC() is high (> 15) (gocyclo)
- Line 122: warning: cyclomatic complexity 24 of function (*OsdAgent).configureCVDevices() is high (> 15) (gocyclo)
- Line 964: warning: cyclomatic complexity 19 of function GetCephVolumeRawOSDs() is high (> 15) (gocyclo)

- Line 49: warning: cyclomatic complexity 62 of function WatchControllerPredicate() is high (> 15) (gocyclo)

- Line 216: warning: cyclomatic complexity 16 of function (*Filesystem).doFilesystemCreate() is high (> 15) (gocyclo)

- Line 40: warning: cyclomatic complexity 19 of function (*ClusterController).configureExternalCephCluster() is high (> 15) (gocyclo)

- Line 135: warning: cyclomatic complexity 19 of function (*ReconcileObjectStoreUser).reconcile() is high (> 15) (gocyclo)

- Line 75: warning: cyclomatic complexity 18 of function (*updateConfig).updateExistingOSDs() is high (> 15) (gocyclo)

- Line 100: warning: cyclomatic complexity 19 of function deleteStore() is high (> 15) (gocyclo)

- Line 369: warning: cyclomatic complexity 28 of function GetAvailableDevices() is high (> 15) (gocyclo)

- Line 154: warning: cyclomatic complexity 19 of function (*cluster).validateCephVersion() is high (> 15) (gocyclo)

- Line 152: warning: cyclomatic complexity 16 of function ValidateConnectionDetails() is high (> 15) (gocyclo)

- Line 194: warning: cyclomatic complexity 17 of function (*Cluster).provisionOSDContainer() is high (> 15) (gocyclo)

- Line 175: warning: cyclomatic complexity 30 of function TestAvailableDevices() is high (> 15) (gocyclo)

- Line 177: warning: cyclomatic complexity 21 of function testObjectStoreOperations() is high (> 15) (gocyclo)

- Line 63: warning: cyclomatic complexity 16 of function validatePoolSpec() is high (> 15) (gocyclo)

- Line 259: warning: cyclomatic complexity 21 of function (*cluster).notifyChildControllerOfUpgrade() is high (> 15) (gocyclo)
- Line 348: warning: cyclomatic complexity 18 of function preClusterStartValidation() is high (> 15) (gocyclo)

- Line 335: warning: cyclomatic complexity 54 of function (*Cluster).makeDeployment() is high (> 15) (gocyclo)

- Line 90: warning: cyclomatic complexity 26 of function (*ReconcileNode).reconcile() is high (> 15) (gocyclo)

- Line 1192: warning: cyclomatic complexity 22 of function (*Cluster).startMon() is high (> 15) (gocyclo)
- Line 218: warning: cyclomatic complexity 20 of function (*Cluster).startMons() is high (> 15) (gocyclo)
- Line 908: warning: cyclomatic complexity 17 of function (*Cluster).startDeployments() is high (> 15) (gocyclo)

- Line 43: warning: cyclomatic complexity 45 of function ValidatePoolSpec() is high (> 15) (gocyclo)

- Line 168: warning: cyclomatic complexity 29 of function (*ReconcileCephFilesystem).reconcile() is high (> 15) (gocyclo)

- Line 115: warning: cyclomatic complexity 17 of function PopulateDeviceInfo() is high (> 15) (gocyclo)

- Line 668: warning: cyclomatic complexity 17 of function (Provisioner).updateAdditionalSettings() is high (> 15) (gocyclo)

- Line 205: warning: cyclomatic complexity 17 of function mountCephFS() is high (> 15) (gocyclo)

- Line 211: warning: cyclomatic complexity 83 of function startDrivers() is high (> 15) (gocyclo)

- Line 311: warning: cyclomatic complexity 26 of function (*ReconcileClusterDisruption).reconcilePDBsForOSDs() is high (> 15) (gocyclo)

- Line 457: warning: cyclomatic complexity 27 of function (*Cluster).getOSDInfo() is high (> 15) (gocyclo)

- Line 56: warning: cyclomatic complexity 16 of function (*sharedInformerFactory).ForResource() is high (> 15) (gocyclo)

- Line 44: warning: cyclomatic complexity 20 of function Add() is high (> 15) (gocyclo)

- Line 91: warning: cyclomatic complexity 21 of function (*Controller).Attach() is high (> 15) (gocyclo)

- Line 278: warning: cyclomatic complexity 18 of function TestCephObjectStoreController() is high (> 15) (gocyclo)

- Line 136: warning: cyclomatic complexity 17 of function (*ReconcileCephNFS).reconcile() is high (> 15) (gocyclo)

- Line 326: warning: cyclomatic complexity 18 of function testCreatePoolWithReplicasPerFailureDomain() is high (> 15) (gocyclo)

- Line 70: warning: cyclomatic complexity 19 of function removeOSD() is high (> 15) (gocyclo)

- Line 240: warning: cyclomatic complexity 28 of function setCommonPoolProperties() is high (> 15) (gocyclo)

- Line 78: warning: cyclomatic complexity 18 of function (*Agent).createAgentDaemonSet() is high (> 15) (gocyclo)

- Line 71: warning: cyclomatic complexity 20 of function setParams() is high (> 15) (gocyclo)

- Line 668: warning: cyclomatic complexity 75 of function TestInitializeBlock() is high (> 15) (gocyclo)
- Line 313: warning: cyclomatic complexity 52 of function TestConfigureCVDevices() is high (> 15) (gocyclo)
- Line 1061: warning: cyclomatic complexity 17 of function TestInitializeBlockPVCWithMetadata() is high (> 15) (gocyclo)

- Line 70: warning: cyclomatic complexity 17 of function (*MachineDisruptionReconciler).reconcile() is high (> 15) (gocyclo)

- Line 401: warning: cyclomatic complexity 17 of function (*CephDaemonsVersions).DeepCopyInto() is high (> 15) (gocyclo)

- Line 130: warning: cyclomatic complexity 16 of function GetDevicePartitions() is high (> 15) (gocyclo)

- Line 213: warning: cyclomatic complexity 17 of function (*NFSServerReconciler).reconcileNFSServer() is high (> 15) (gocyclo)

- Line 114: warning: cyclomatic complexity 20 of function (*Cluster).Start() is high (> 15) (gocyclo)

- Line 68: warning: cyclomatic complexity 17 of function (*ReconcileMachineLabel).reconcile() is high (> 15) (gocyclo)

- Line 98: warning: cyclomatic complexity 30 of function testOSDIntegration() is high (> 15) (gocyclo)

- Line 128: warning: cyclomatic complexity 16 of function (*ReconcileCephClient).reconcile() is high (> 15) (gocyclo)

- Line 123: warning: cyclomatic complexity 22 of function TestAddRemoveNode() is high (> 15) (gocyclo)

- Line 572: warning: cyclomatic complexity 33 of function (*CephInstaller).UninstallRookFromMultipleNS() is high (> 15) (gocyclo)
- Line 481: warning: cyclomatic complexity 18 of function (*CephInstaller).InstallRook() is high (> 15) (gocyclo)

- Line 286: warning: cyclomatic complexity 48 of function getAvailableDevices() is high (> 15) (gocyclo)
- Line 166: warning: cyclomatic complexity 18 of function Provision() is high (> 15) (gocyclo)

- Line 171: warning: cyclomatic complexity 31 of function (*ReconcileCephObjectStore).reconcile() is high (> 15) (gocyclo)
- Line 344: warning: cyclomatic complexity 16 of function (*ReconcileCephObjectStore).reconcileCreateObjectStore() is high (> 15) (gocyclo)

- Line 63: warning: cyclomatic complexity 17 of function add() is high (> 15) (gocyclo)

- Line 80: warning: cyclomatic complexity 16 of function (*ReconcileClusterDisruption).reconcile() is high (> 15) (gocyclo)

- Line 127: warning: cyclomatic complexity 18 of function (*Cluster).startProvisioningOverPVCs() is high (> 15) (gocyclo)

- Line 312: warning: cyclomatic complexity 21 of function TestGetMdsIdByRank() is high (> 15) (gocyclo)
- Line 168: warning: cyclomatic complexity 16 of function TestFailAllStandbyReplayMDS() is high (> 15) (gocyclo)

- Line 140: warning: cyclomatic complexity 33 of function (*ReconcileCephBlockPool).reconcile() is high (> 15) (gocyclo)

- Line 82: warning: cyclomatic complexity 24 of function (*clusterConfig).startRGWPods() is high (> 15) (gocyclo)

- Line 43: warning: cyclomatic complexity 21 of function TestCephObjectStoreDependents() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!

Go Report Card

Preparing report...

Report for github.com/rook/cassandra

gofmt100%

go_vet100%

golint76%

gocyclo91%

license100%

ineffassign100%

misspell100%