Preparing report...

Report for github.com/rupor-github/win-gpg-agent

(v1.6.0)

A+    Excellent!    Found 7 issues across 44 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • agent/connector.go
    • Line 161: warning: cyclomatic complexity 16 of function (*Connector).handleAssuanRequest() is high (> 15) (gocyclo)

golint93%

Golint is a linter for Go source code.

    • util/xagent.go
    • Line 30: warning: exported function XAgentCookieString should have comment or be unexported (golint)
    • Line 61: warning: exported type XAgentAdvertiser should have comment or be unexported (golint)
    • Line 86: warning: comment on exported function AdvertiseXAgent should be of the form "AdvertiseXAgent ..." (golint)
    • wincred/sys.go
    • Line 3: warning: package comment should be of the form "Package wincred ..." (golint)
    • Line 44: warning: don't use underscores in Go names; type sysCREDENTIAL_ATTRIBUTE should be sysCREDENTIALATTRIBUTE (golint)
    • Line 52: warning: don't use underscores in Go names; type sysCRED_TYPE should be sysCREDTYPE (golint)
    • Line 55: warning: don't use underscores in Go names; const sysCRED_TYPE_GENERIC should be sysCREDTYPEGENERIC (golint)
    • Line 56: warning: don't use underscores in Go names; const sysCRED_TYPE_DOMAIN_PASSWORD should be sysCREDTYPEDOMAINPASSWORD (golint)
    • Line 57: warning: don't use underscores in Go names; const sysCRED_TYPE_DOMAIN_CERTIFICATE should be sysCREDTYPEDOMAINCERTIFICATE (golint)
    • Line 58: warning: don't use underscores in Go names; const sysCRED_TYPE_DOMAIN_VISIBLE_PASSWORD should be sysCREDTYPEDOMAINVISIBLEPASSWORD (golint)
    • Line 59: warning: don't use underscores in Go names; const sysCRED_TYPE_GENERIC_CERTIFICATE should be sysCREDTYPEGENERICCERTIFICATE (golint)
    • Line 60: warning: don't use underscores in Go names; const sysCRED_TYPE_DOMAIN_EXTENDED should be sysCREDTYPEDOMAINEXTENDED (golint)
    • Line 63: warning: don't use underscores in Go names; const sysERROR_NOT_FOUND should be sysERRORNOTFOUND (golint)
    • Line 64: warning: don't use underscores in Go names; const sysERROR_INVALID_PARAMETER should be sysERRORINVALIDPARAMETER (golint)
    • util/credui.go
    • Line 24: warning: exported type DlgDetails should have comment or be unexported (golint)
    • Line 86: warning: exported const CREDUI_MAX_CAPTION_LENGTH should have comment (or a comment on this block) or be unexported (golint)
    • Line 210: warning: exported function PromptForConfirmaion should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!