Preparing report...

Report for github.com/sapcc/kubernikus

A+    Excellent!    Found 222 issues across 299 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • kubernikus/pkg/controller/ground.go
    • Line 169: warning: cyclomatic complexity 44 of function (*GroundControl).handler() is high (> 15) (gocyclo)
    • Line 785: warning: cyclomatic complexity 26 of function (*GroundControl).discoverOpenstackInfo() is high (> 15) (gocyclo)
    • Line 500: warning: cyclomatic complexity 17 of function (*GroundControl).createKluster() is high (> 15) (gocyclo)

golint26%

Golint is a linter for Go source code.

    • kubernikus/pkg/apis/kubernikus/v1/secret.go
    • Line 10: warning: exported type Secret should have comment or be unexported (golint)
    • Line 24: warning: exported function NewSecret should have comment or be unexported (golint)
    • Line 40: warning: exported method Secret.ToData should have comment or be unexported (golint)
    • Line 52: warning: exported method Secret.ToStringData should have comment or be unexported (golint)
    • Line 65: warning: exported type Openstack should have comment or be unexported (golint)
    • Line 75: warning: exported type Certificates should have comment or be unexported (golint)
    • Line 129: warning: exported method Certificates.ToStringData should have comment or be unexported (golint)
    • kubernikus/pkg/controller/hammertime/hammertime.go
    • Line 36: warning: exported const HammertimeDisableAnnotation should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: exported function New should have comment or be unexported (golint)
    • Line 113: warning: don't use underscores in Go names; var timeout_exeeded should be timeoutExeeded (golint)
    • kubernikus/pkg/controller/ground/bootstrap/util.go
    • Line 18: warning: exported function RenderManifest should have comment or be unexported (golint)
    • Line 31: warning: exported function CreateOrUpdateServiceAccount should have comment or be unexported (golint)
    • Line 40: warning: exported function CreateOrUpdateDeployment should have comment or be unexported (golint)
    • Line 53: warning: exported function CreateOrUpdateDeployment116 should have comment or be unexported (golint)
    • Line 66: warning: exported function CreateOrUpdateService should have comment or be unexported (golint)
    • Line 80: warning: exported function CreateOrUpdateConfigMap should have comment or be unexported (golint)
    • Line 93: warning: exported function CreateOrUpdateDaemonset should have comment or be unexported (golint)
    • Line 106: warning: exported function CreateOrUpdateClusterRoleBinding should have comment or be unexported (golint)
    • Line 119: warning: exported function CreateOrUpdateClusterRoleBindingV1 should have comment or be unexported (golint)
    • Line 132: warning: exported function CreateOrUpdateRoleBinding should have comment or be unexported (golint)
    • Line 145: warning: exported function CreateOrUpdateRoleBindingV1 should have comment or be unexported (golint)
    • Line 158: warning: exported function CreateOrUpdateRole should have comment or be unexported (golint)
    • Line 171: warning: exported function CreateOrUpdateClusterRole should have comment or be unexported (golint)
    • Line 184: warning: exported function CreateOrUpdateClusterRoleV1 should have comment or be unexported (golint)
    • Line 197: warning: exported function CreateOrUpdateStatefulSet should have comment or be unexported (golint)
    • Line 210: warning: exported function CreateOrUpdateSecret should have comment or be unexported (golint)
    • kubernikus/pkg/util/helm/helm.go
    • Line 21: warning: exported var ETCDBackupAnnotation should have comment or be unexported (golint)
    • Line 25: warning: exported type OpenstackOptions should have comment or be unexported (golint)
    • Line 122: warning: exported function KlusterToHelmValues should have comment or be unexported (golint)
    • kubernikus/pkg/controller/config/config.go
    • Line 19: warning: exported type Controller should have comment or be unexported (golint)
    • Line 23: warning: exported type OpenstackConfig should have comment or be unexported (golint)
    • Line 32: warning: exported type HelmConfig should have comment or be unexported (golint)
    • Line 36: warning: exported type KubernikusConfig should have comment or be unexported (golint)
    • Line 44: warning: exported type Config should have comment or be unexported (golint)
    • Line 51: warning: exported type Clients should have comment or be unexported (golint)
    • Line 60: warning: exported type Factories should have comment or be unexported (golint)
    • kubernikus/pkg/controller/flight/controller.go
    • Line 62: warning: exported type FlightController should have comment or be unexported (golint)
    • Line 67: warning: exported function NewController should have comment or be unexported (golint)
    • Line 78: warning: exported method FlightController.Reconcile should have comment or be unexported (golint)
    • kubernikus/pkg/version/images.go
    • Line 13: warning: exported type ImageVersion should have comment or be unexported (golint)
    • Line 25: warning: exported type KlusterVersion should have comment or be unexported (golint)
    • Line 53: warning: exported type ImageRegistry should have comment or be unexported (golint)
    • Line 58: warning: exported function NewImageRegistry should have comment or be unexported (golint)
    • kubernikus/test/e2e/framework/kubernikus.go
    • Line 22: warning: exported type Kubernikus should have comment or be unexported (golint)
    • Line 27: warning: exported function NewKubernikusFramework should have comment or be unexported (golint)
    • Line 57: warning: exported method Kubernikus.WaitForKlusterPhase should have comment or be unexported (golint)
    • Line 82: warning: receiver name k should be consistent with previous receiver name f for Kubernikus (golint)
    • Line 97: warning: exported method Kubernikus.WaitForKlusterToBeDeleted should have comment or be unexported (golint)
    • Line 97: warning: receiver name k should be consistent with previous receiver name f for Kubernikus (golint)
    • Line 117: warning: exported method Kubernikus.WaitForKlusters should have comment or be unexported (golint)
    • Line 117: warning: receiver name k should be consistent with previous receiver name f for Kubernikus (golint)
    • kubernikus/pkg/util/log/middleware.go
    • Line 19: warning: exported const KubernikusRequestID should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: exported function RequestIDHandler should have comment or be unexported (golint)
    • Line 31: warning: exported function LoggingHandler should have comment or be unexported (golint)
    • Line 32: warning: don't use underscores in Go names; var ingress_logger should be ingressLogger (golint)
    • Line 36: warning: don't use underscores in Go names; var inner_logger should be innerLogger (golint)
    • Line 42: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 63: warning: don't use underscores in Go names; var source_ip should be sourceIP (golint)
    • Line 74: warning: don't use underscores in Go names; var host_port should be hostPort (golint)
    • kubernikus/pkg/util/strings.go
    • Line 3: warning: exported function DisabledValue should have comment or be unexported (golint)
    • Line 12: warning: exported function EnabledValue should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/wormhole/server.go
    • Line 19: warning: exported function NewServerCommand should have comment or be unexported (golint)
    • Line 37: warning: exported type ServerOptions should have comment or be unexported (golint)
    • Line 42: warning: exported function NewServerOptions should have comment or be unexported (golint)
    • Line 47: warning: exported method ServerOptions.BindFlags should have comment or be unexported (golint)
    • Line 58: warning: exported method ServerOptions.Validate should have comment or be unexported (golint)
    • Line 65: warning: exported method ServerOptions.Complete should have comment or be unexported (golint)
    • Line 69: warning: exported method ServerOptions.Run should have comment or be unexported (golint)
    • kubernikus/pkg/util/certificates.go
    • Line 31: warning: exported const AdditionalApiserverSANsAnnotation should have comment (or a comment on this block) or be unexported (golint)
    • Line 35: warning: exported type Bundle should have comment or be unexported (golint)
    • Line 40: warning: exported function NewBundle should have comment or be unexported (golint)
    • Line 60: warning: exported type Config should have comment or be unexported (golint)
    • Line 71: warning: exported type AltNames should have comment or be unexported (golint)
    • Line 76: warning: exported method Bundle.Sign should have comment or be unexported (golint)
    • Line 112: warning: exported type CertificateFactory should have comment or be unexported (golint)
    • Line 118: warning: exported type CertUpdates should have comment or be unexported (golint)
    • Line 124: warning: exported function NewCertificateFactory should have comment or be unexported (golint)
    • Line 128: warning: exported method CertificateFactory.Ensure should have comment or be unexported (golint)
    • Line 318: warning: exported method CertificateFactory.UserCert should have comment or be unexported (golint)
    • Line 504: warning: exported function StringSliceDiff should have comment or be unexported (golint)
    • Line 516: warning: exported function IPSliceDiff should have comment or be unexported (golint)
    • Line 528: warning: exported function SliceDiff should have comment or be unexported (golint)
    • kubernikus/pkg/controller/ground.go
    • Line 41: warning: exported const KLUSTER_RECHECK_INTERVAL should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: comment on exported const ConfigurationError should be of the form "ConfigurationError ..." (golint)
    • Line 53: warning: exported type GroundControl should have comment or be unexported (golint)
    • Line 67: warning: exported function NewGroundController should have comment or be unexported (golint)
    • Line 101: warning: exported method GroundControl.Run should have comment or be unexported (golint)
    • Line 885: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • kubernikus/test/e2e/framework/kubernetes.go
    • Line 21: warning: exported const PodListTimeout should have comment (or a comment on this block) or be unexported (golint)
    • Line 26: warning: exported type Kubernetes should have comment or be unexported (golint)
    • Line 31: warning: exported function NewKubernetesFramework should have comment or be unexported (golint)
    • Line 61: warning: exported method Kubernetes.WaitForDefaultServiceAccountInNamespace should have comment or be unexported (golint)
    • Line 73: warning: exported method Kubernetes.WaitForPodsWithLabelRunningReady should have comment or be unexported (golint)
    • Line 98: warning: exported method Kubernetes.WaitForPodsWithLabel should have comment or be unexported (golint)
    • Line 118: warning: exported method Kubernetes.WaitForServiceEndpointsWithLabelNum should have comment or be unexported (golint)
    • kubernikus/pkg/util/generator/namegenerator.go
    • Line 10: warning: exported type NameGenerator should have comment or be unexported (golint)
    • Line 29: warning: comment on exported const MaxNameLength should be of the form "MaxNameLength ..." (golint)
    • Line 31: warning: exported const RandomLength should have comment (or a comment on this block) or be unexported (golint)
    • kubernikus/pkg/util/icmp/icmp.go
    • Line 15: warning: exported const ProtocolIP should have comment (or a comment on this block) or be unexported (golint)
    • Line 19: warning: don't use underscores in Go names; const sysIP_STRIPHDR should be sysIPSTRIPHDR (golint)
    • Line 24: warning: exported type Message should have comment or be unexported (golint)
    • Line 29: warning: exported type Listener should have comment or be unexported (golint)
    • Line 38: warning: exported function NewListener should have comment or be unexported (golint)
    • Line 52: warning: exported method Listener.SetReadDeadline should have comment or be unexported (golint)
    • Line 79: warning: exported method Listener.SendEcho should have comment or be unexported (golint)
    • Line 96: warning: exported method Listener.Close should have comment or be unexported (golint)
    • kubernikus/pkg/controller/launch/logging.go
    • Line 9: warning: exported type LoggingPoolManager should have comment or be unexported (golint)
    • Line 14: warning: exported method LoggingPoolManager.GetStatus should have comment or be unexported (golint)
    • Line 31: warning: exported method LoggingPoolManager.SetStatus should have comment or be unexported (golint)
    • Line 48: warning: exported method LoggingPoolManager.CreateNode should have comment or be unexported (golint)
    • Line 60: warning: exported method LoggingPoolManager.DeleteNode should have comment or be unexported (golint)
    • Line 72: warning: exported method LoggingPoolManager.DeletePool should have comment or be unexported (golint)
    • kubernikus/pkg/client/openstack/kluster/logging.go
    • Line 12: warning: exported type LoggingClient should have comment or be unexported (golint)
    • Line 17: warning: exported method LoggingClient.DeleteNode should have comment or be unexported (golint)
    • Line 31: warning: exported method LoggingClient.RebootNode should have comment or be unexported (golint)
    • Line 45: warning: exported method LoggingClient.CreateNode should have comment or be unexported (golint)
    • Line 60: warning: exported method LoggingClient.ListNodes should have comment or be unexported (golint)
    • Line 74: warning: exported method LoggingClient.SetSecurityGroup should have comment or be unexported (golint)
    • Line 89: warning: exported method LoggingClient.EnsureKubernikusRuleInSecurityGroup should have comment or be unexported (golint)
    • Line 104: warning: exported method LoggingClient.DeleteServerGroup should have comment or be unexported (golint)
    • Line 118: warning: exported method LoggingClient.EnsureServerGroup should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikusctl/delete/common.go
    • Line 16: warning: exported type DeleteOptions should have comment or be unexported (golint)
    • Line 23: warning: exported method DeleteOptions.PersistentPreRun should have comment or be unexported (golint)
    • Line 30: warning: exported method DeleteOptions.BindFlags should have comment or be unexported (golint)
    • Line 37: warning: exported method DeleteOptions.SetupKubernikusClient should have comment or be unexported (golint)
    • kubernikus/pkg/controller/ground/bootstrap/gpu/manifest.go
    • Line 4: warning: don't use underscores in Go names; const NVIDIADevicePlugin_v20180808 should be NVIDIADevicePluginV20180808 (golint)
    • Line 4: warning: exported const NVIDIADevicePlugin_v20180808 should have comment (or a comment on this block) or be unexported (golint)
    • Line 70: warning: don't use underscores in Go names; const NVIDIADriverInstaller_v20180808 should be NVIDIADriverInstallerV20180808 (golint)
    • kubernikus/pkg/cmd/kubernikusctl/common/kubecontext.go
    • Line 17: warning: exported function NewKubernikusContext should have comment or be unexported (golint)
    • Line 32: warning: exported type KubernikusContext should have comment or be unexported (golint)
    • Line 40: warning: exported method KubernikusContext.IsKubernikusContext should have comment or be unexported (golint)
    • Line 54: warning: exported method KubernikusContext.UserCertificateValid should have comment or be unexported (golint)
    • Line 63: warning: exported method KubernikusContext.Username should have comment or be unexported (golint)
    • Line 76: warning: exported method KubernikusContext.UserDomainname should have comment or be unexported (golint)
    • Line 89: warning: exported method KubernikusContext.KubernikusURL should have comment or be unexported (golint)
    • Line 101: warning: exported method KubernikusContext.AuthURL should have comment or be unexported (golint)
    • Line 112: warning: exported method KubernikusContext.ProjectID should have comment or be unexported (golint)
    • Line 123: warning: exported method KubernikusContext.MergeAndPersist should have comment or be unexported (golint)
    • kubernikus/pkg/controller/base/polling_controller.go
    • Line 15: warning: exported type PollingReconciler should have comment or be unexported (golint)
    • Line 27: warning: exported function NewPollingController should have comment or be unexported (golint)
    • Line 73: warning: receiver name p should be consistent with previous receiver name pc for pollingController (golint)
    • kubernikus/pkg/client/kubernetes/client.go
    • Line 17: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 25: warning: exported function NewConfig should have comment or be unexported (golint)
    • Line 40: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 60: warning: exported function NewClientConfigV1 should have comment or be unexported (golint)
    • Line 96: warning: exported function NewClientConfigV1OIDC should have comment or be unexported (golint)
    • Line 138: warning: exported function EnsureCRD should have comment or be unexported (golint)
    • Line 192: warning: exported function WaitForServer should have comment or be unexported (golint)
    • kubernikus/pkg/api/models/kluster_print.go
    • Line 11: warning: exported method Kluster.GetFormats should have comment or be unexported (golint)
    • Line 19: warning: exported method Kluster.Print should have comment or be unexported (golint)
    • Line 60: warning: exported method NodePool.GetFormats should have comment or be unexported (golint)
    • Line 68: warning: exported method NodePool.Print should have comment or be unexported (golint)
    • kubernikus/pkg/apis/kubernikus/v1/kluster.go
    • Line 13: warning: exported var TerminationProtectionAnnotationKey should have comment or be unexported (golint)
    • Line 18: warning: exported type Kluster should have comment or be unexported (golint)
    • Line 27: warning: exported type KlusterList should have comment or be unexported (golint)
    • Line 33: warning: exported method Kluster.Account should have comment or be unexported (golint)
    • Line 37: warning: exported method Kluster.ApiServiceIP should have comment or be unexported (golint)
    • Line 50: warning: exported method Kluster.NeedsFinalizer should have comment or be unexported (golint)
    • Line 50: warning: receiver name k should be consistent with previous receiver name spec for Kluster (golint)
    • Line 66: warning: exported method Kluster.HasFinalizer should have comment or be unexported (golint)
    • Line 66: warning: receiver name k should be consistent with previous receiver name spec for Kluster (golint)
    • Line 82: warning: exported method Kluster.AddFinalizer should have comment or be unexported (golint)
    • Line 82: warning: receiver name k should be consistent with previous receiver name spec for Kluster (golint)
    • Line 88: warning: exported method Kluster.RemoveFinalizer should have comment or be unexported (golint)
    • Line 88: warning: receiver name k should be consistent with previous receiver name spec for Kluster (golint)
    • Line 99: warning: exported method Kluster.Disabled should have comment or be unexported (golint)
    • Line 99: warning: receiver name k should be consistent with previous receiver name spec for Kluster (golint)
    • Line 103: warning: exported method Kluster.TerminationProtection should have comment or be unexported (golint)
    • Line 103: warning: receiver name k should be consistent with previous receiver name spec for Kluster (golint)
    • Line 107: warning: exported method Kluster.ClusterCIDR should have comment or be unexported (golint)
    • Line 107: warning: receiver name k should be consistent with previous receiver name spec for Kluster (golint)
    • kubernikus/pkg/cmd/kubernikus/helm.go
    • Line 21: warning: exported function NewHelmCommand should have comment or be unexported (golint)
    • Line 39: warning: exported type HelmOptions should have comment or be unexported (golint)
    • Line 52: warning: exported function NewHelmOptions should have comment or be unexported (golint)
    • Line 62: warning: exported method HelmOptions.BindFlags should have comment or be unexported (golint)
    • Line 74: warning: exported method HelmOptions.Validate should have comment or be unexported (golint)
    • Line 96: warning: exported method HelmOptions.Complete should have comment or be unexported (golint)
    • Line 101: warning: exported method HelmOptions.Run should have comment or be unexported (golint)
    • kubernikus/pkg/controller/servicing/coreos/testing.go
    • Line 13: warning: exported function NewFakeVersion should have comment or be unexported (golint)
    • Line 20: warning: exported function NewFakeRelease should have comment or be unexported (golint)
    • Line 39: warning: exported function NewTestClient should have comment or be unexported (golint)
    • Line 57: warning: exported type RoundTripFunc should have comment or be unexported (golint)
    • Line 59: warning: exported method RoundTripFunc.RoundTrip should have comment or be unexported (golint)
    • kubernikus/pkg/util/etcd/etcd.go
    • Line 10: warning: exported const BackupStorageContainerBase should have comment (or a comment on this block) or be unexported (golint)
    • Line 13: warning: exported function DefaultStorageContainer should have comment or be unexported (golint)
    • kubernikus/pkg/controller/deorbit/controller.go
    • Line 31: warning: exported const DeorbiterFinalizer should have comment (or a comment on this block) or be unexported (golint)
    • Line 33: warning: comment on exported const UnblockWorkerTimeout should be of the form "UnblockWorkerTimeout ..." (golint)
    • Line 40: warning: exported type DeorbitReconciler should have comment or be unexported (golint)
    • Line 49: warning: exported function NewController should have comment or be unexported (golint)
    • Line 66: warning: exported method DeorbitReconciler.Reconcile should have comment or be unexported (golint)
    • kubernikus/pkg/util/retry.go
    • Line 15: warning: error var KlusterNotUpdated should have name of the form ErrFoo (golint)
    • Line 15: warning: exported var KlusterNotUpdated should have comment or be unexported (golint)
    • kubernikus/pkg/api/auth/oauth.go
    • Line 38: warning: exported function OAuthEnabled should have comment or be unexported (golint)
    • Line 42: warning: exported function OAuthConfig should have comment or be unexported (golint)
    • Line 67: warning: exported function OAuth should have comment or be unexported (golint)
    • Line 94: warning: exported function NewAuthLogin should have comment or be unexported (golint)
    • Line 116: warning: exported function NewAuthCallback should have comment or be unexported (golint)
    • kubernikus/deps/deps.go
    • Line 1: warning: package comment should be of the form "Package extra_dependencies ..." (golint)
    • Line 4: warning: don't use an underscore in package name (golint)
    • Line 7: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • kubernikus/pkg/controller/nodeobservatory/controller.go
    • Line 24: warning: exported const BaseDelay should have comment (or a comment on this block) or be unexported (golint)
    • Line 30: warning: exported type AddFunc should have comment or be unexported (golint)
    • Line 31: warning: exported type UpdateFunc should have comment or be unexported (golint)
    • Line 32: warning: exported type DeleteFunc should have comment or be unexported (golint)
    • Line 34: warning: exported type NodeEventHandlerFuncs should have comment or be unexported (golint)
    • Line 40: warning: exported type NodeObservatory should have comment or be unexported (golint)
    • Line 56: warning: exported function NewController should have comment or be unexported (golint)
    • Line 80: warning: exported method NodeObservatory.Run should have comment or be unexported (golint)
    • Line 326: warning: comment on exported method NodeObservatory.GetListerForKluster should be of the form "GetListerForKluster ..." (golint)
    • kubernikus/pkg/controller/flight/logging.go
    • Line 10: warning: exported type LoggingFlightReconciler should have comment or be unexported (golint)
    • Line 15: warning: exported method LoggingFlightReconciler.EnsureInstanceSecurityGroupAssignment should have comment or be unexported (golint)
    • Line 27: warning: exported method LoggingFlightReconciler.DeleteIncompletelySpawnedInstances should have comment or be unexported (golint)
    • Line 39: warning: exported method LoggingFlightReconciler.DeleteErroredInstances should have comment or be unexported (golint)
    • Line 51: warning: exported method LoggingFlightReconciler.EnsureKubernikusRuleInSecurityGroup should have comment or be unexported (golint)
    • Line 62: warning: exported method LoggingFlightReconciler.EnsureServiceUserRoles should have comment or be unexported (golint)
    • kubernikus/pkg/controller/deorbit/deorbiter.go
    • Line 18: warning: exported type SelfDestructReason should have comment or be unexported (golint)
    • Line 21: warning: exported const APIUnavailable should have comment (or a comment on this block) or be unexported (golint)
    • Line 24: warning: comment on exported const APIUnavailableTimeout should be of the form "APIUnavailableTimeout ..." (golint)
    • Line 29: warning: comment on exported const DeorbitHangingTimeout should be of the form "DeorbitHangingTimeout ..." (golint)
    • Line 34: warning: comment on exported const ServiceDeletionGracePeriod should be of the form "ServiceDeletionGracePeriod ..." (golint)
    • Line 41: warning: comment on exported const PollInterval should be of the form "PollInterval ..." (golint)
    • Line 45: warning: exported type Deorbiter should have comment or be unexported (golint)
    • Line 55: warning: exported type ConcreteDeorbiter should have comment or be unexported (golint)
    • Line 62: warning: exported function NewDeorbiter should have comment or be unexported (golint)
    • Line 83: warning: exported method ConcreteDeorbiter.DeletePersistentVolumeClaims should have comment or be unexported (golint)
    • Line 115: warning: exported method ConcreteDeorbiter.DeleteServices should have comment or be unexported (golint)
    • Line 138: warning: exported method ConcreteDeorbiter.WaitForPersistentVolumeCleanup should have comment or be unexported (golint)
    • Line 151: warning: exported method ConcreteDeorbiter.WaitForServiceCleanup should have comment or be unexported (golint)
    • Line 164: warning: exported method ConcreteDeorbiter.SelfDestruct should have comment or be unexported (golint)
    • Line 169: warning: exported method ConcreteDeorbiter.IsAPIUnavailableTimeout should have comment or be unexported (golint)
    • Line 173: warning: exported method ConcreteDeorbiter.IsDeorbitHangingTimeout should have comment or be unexported (golint)
    • kubernikus/pkg/wormhole/server/server.go
    • Line 16: warning: exported const DEFAULT_RECONCILIATION should have comment (or a comment on this block) or be unexported (golint)
    • Line 19: warning: exported type Server should have comment or be unexported (golint)
    • Line 28: warning: exported function New should have comment or be unexported (golint)
    • Line 47: warning: exported method Server.Run should have comment or be unexported (golint)
    • kubernikus/pkg/apis/kubernikus/factory.go
    • Line 17: warning: comment on exported var DEFAULT_CLUSTER_CIDR should be of the form "DEFAULT_CLUSTER_CIDR ..." (golint)
    • Line 19: warning: exported var DEFAULT_SERVICE_CIDR should have comment or be unexported (golint)
    • Line 25: warning: exported type KlusterFactory should have comment or be unexported (golint)
    • Line 32: warning: exported function NewKlusterFactory should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikusctl/create/common.go
    • Line 16: warning: exported type CreateOptions should have comment or be unexported (golint)
    • Line 24: warning: exported method CreateOptions.PersistentPreRun should have comment or be unexported (golint)
    • Line 31: warning: exported method CreateOptions.BindFlags should have comment or be unexported (golint)
    • Line 38: warning: exported method CreateOptions.SetupKubernikusClient should have comment or be unexported (golint)
    • kubernikus/pkg/controller/launch/eventing.go
    • Line 11: warning: exported type EventingPoolManager should have comment or be unexported (golint)
    • Line 17: warning: exported method EventingPoolManager.GetStatus should have comment or be unexported (golint)
    • Line 21: warning: exported method EventingPoolManager.SetStatus should have comment or be unexported (golint)
    • Line 25: warning: exported method EventingPoolManager.CreateNode should have comment or be unexported (golint)
    • Line 37: warning: exported method EventingPoolManager.DeleteNode should have comment or be unexported (golint)
    • Line 48: warning: exported method EventingPoolManager.DeletePool should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikus/certificates/files.go
    • Line 16: warning: exported function NewFilesCommand should have comment or be unexported (golint)
    • Line 34: warning: exported type FilesOptions should have comment or be unexported (golint)
    • Line 38: warning: exported function NewFilesOptions should have comment or be unexported (golint)
    • Line 42: warning: exported method FilesOptions.BindFlags should have comment or be unexported (golint)
    • Line 45: warning: exported method FilesOptions.Validate should have comment or be unexported (golint)
    • Line 53: warning: exported method FilesOptions.Complete should have comment or be unexported (golint)
    • Line 58: warning: exported method FilesOptions.Run should have comment or be unexported (golint)
    • kubernikus/test/e2e/framework/exec.go
    • Line 87: warning: exported method Kubernetes.ExecShellInContainer should have comment or be unexported (golint)
    • Line 91: warning: exported method Kubernetes.ExecCommandInPod should have comment or be unexported (golint)
    • Line 99: warning: exported method Kubernetes.ExecCommandInPodWithFullOutput should have comment or be unexported (golint)
    • Line 107: warning: exported method Kubernetes.ExecShellInPod should have comment or be unexported (golint)
    • Line 111: warning: exported method Kubernetes.ExecShellInPodWithFullOutput should have comment or be unexported (golint)
    • kubernikus/pkg/util/ip_or_dnsname.go
    • Line 9: warning: exported type IPOrDNSName should have comment or be unexported (golint)
    • Line 15: warning: exported type IPOrDNSNameType should have comment or be unexported (golint)
    • Line 18: warning: exported const IPType should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: exported method IPOrDNSName.UnmarshalJSON should have comment or be unexported (golint)
    • kubernikus/test/e2e/volume_test.go
    • Line 47: warning: receiver name p should be consistent with previous receiver name v for VolumeTests (golint)
    • Line 52: warning: receiver name p should be consistent with previous receiver name v for VolumeTests (golint)
    • Line 57: warning: receiver name p should be consistent with previous receiver name v for VolumeTests (golint)
    • Line 62: warning: receiver name p should be consistent with previous receiver name v for VolumeTests (golint)
    • Line 99: warning: receiver name p should be consistent with previous receiver name v for VolumeTests (golint)
    • Line 105: warning: receiver name p should be consistent with previous receiver name v for VolumeTests (golint)
    • Line 125: warning: receiver name p should be consistent with previous receiver name v for VolumeTests (golint)
    • kubernikus/pkg/migration/migration.go
    • Line 45: warning: exported method Registry.Latest should have comment or be unexported (golint)
    • Line 49: warning: exported method Registry.MigrationsPending should have comment or be unexported (golint)
    • Line 53: warning: exported method Registry.Migrate should have comment or be unexported (golint)
    • kubernikus/pkg/controller/base/controller.go
    • Line 19: warning: exported const BASE_DELAY should have comment (or a comment on this block) or be unexported (golint)
    • Line 24: warning: exported var ErrUnkownKluster should have comment or be unexported (golint)
    • Line 26: warning: exported type Controller should have comment or be unexported (golint)
    • Line 30: warning: exported type Reconciler should have comment or be unexported (golint)
    • Line 44: warning: exported function NewController should have comment or be unexported (golint)
    • kubernikus/pkg/client/openstack/kluster/node.go
    • Line 9: warning: exported type Node should have comment or be unexported (golint)
    • Line 14: warning: exported method Node.Starting should have comment or be unexported (golint)
    • Line 31: warning: exported method Node.Stopping should have comment or be unexported (golint)
    • Line 43: warning: exported method Node.Running should have comment or be unexported (golint)
    • Line 77: warning: exported method Node.Erroring should have comment or be unexported (golint)
    • Line 85: warning: exported method Node.GetID should have comment or be unexported (golint)
    • Line 89: warning: exported method Node.GetName should have comment or be unexported (golint)
    • Line 93: warning: exported method Node.GetCreated should have comment or be unexported (golint)
    • Line 97: warning: exported method Node.GetSecurityGroupNames should have comment or be unexported (golint)
    • Line 107: warning: exported type StateExt should have comment or be unexported (golint)
    • Line 113: warning: exported method StateExt.UnmarshalJSON should have comment or be unexported (golint)
    • kubernikus/pkg/util/kluster.go
    • Line 23: warning: exported function EnsureFinalizerCreated should have comment or be unexported (golint)
    • Line 33: warning: exported function EnsureFinalizerRemoved should have comment or be unexported (golint)
    • Line 43: warning: exported function UpdateKlusterMigrationStatus should have comment or be unexported (golint)
    • Line 60: warning: exported function UpdateKlusterPhase should have comment or be unexported (golint)
    • Line 76: warning: exported function EnsureKlusterSecret should have comment or be unexported (golint)
    • Line 96: warning: comment on exported function UpdateKlusterSecret should be of the form "UpdateKlusterSecret ..." (golint)
    • Line 98: warning: don't use underscores in Go names; var api_secret should be apiSecret (golint)
    • Line 111: warning: exported function DeleteKlusterSecret should have comment or be unexported (golint)
    • Line 123: warning: exported function KlusterSecret should have comment or be unexported (golint)
    • Line 131: warning: exported function KlusterVersionConstraint should have comment or be unexported (golint)
    • Line 143: warning: exported function KlusterPodsReadyCount should have comment or be unexported (golint)
    • kubernikus/pkg/controller/base/logging.go
    • Line 11: warning: exported var RECONCILLIATION_COUNTER should have comment or be unexported (golint)
    • Line 13: warning: exported type LoggingReconciler should have comment or be unexported (golint)
    • Line 18: warning: exported method LoggingReconciler.Reconcile should have comment or be unexported (golint)
    • kubernikus/pkg/controller/launch/controller.go
    • Line 22: warning: exported const LaunchctlFinalizer should have comment (or a comment on this block) or be unexported (golint)
    • Line 25: warning: exported type LaunchReconciler should have comment or be unexported (golint)
    • Line 37: warning: exported function NewController should have comment or be unexported (golint)
    • Line 76: warning: exported method LaunchReconciler.Reconcile should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikusctl/common/openstack.go
    • Line 21: warning: exported type OpenstackClient should have comment or be unexported (golint)
    • Line 27: warning: exported function NewOpenstackClient should have comment or be unexported (golint)
    • Line 37: warning: exported method OpenstackClient.BindFlags should have comment or be unexported (golint)
    • Line 54: warning: exported method OpenstackClient.Validate should have comment or be unexported (golint)
    • Line 64: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 139: warning: exported method OpenstackClient.Complete should have comment or be unexported (golint)
    • Line 147: warning: exported method OpenstackClient.Setup should have comment or be unexported (golint)
    • Line 182: warning: exported method OpenstackClient.PrintAuthInfo should have comment or be unexported (golint)
    • Line 214: warning: exported method OpenstackClient.PrintDebugAuthInfo should have comment or be unexported (golint)
    • Line 247: warning: exported method OpenstackClient.Authenticate should have comment or be unexported (golint)
    • Line 256: warning: exported method OpenstackClient.DefaultKubernikusURL should have comment or be unexported (golint)
    • kubernikus/pkg/util/iptables/iptables.go
    • Line 24: warning: exported type RulePosition should have comment or be unexported (golint)
    • Line 27: warning: exported const Prepend should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: comment on exported type Interface should be of the form "Interface ..." (with optional leading article) (golint)
    • Line 63: warning: exported type Protocol should have comment or be unexported (golint)
    • Line 66: warning: exported const ProtocolIpv4 should have comment (or a comment on this block) or be unexported (golint)
    • Line 70: warning: exported type Table should have comment or be unexported (golint)
    • Line 73: warning: exported const TableNAT should have comment (or a comment on this block) or be unexported (golint)
    • Line 77: warning: exported type Chain should have comment or be unexported (golint)
    • Line 80: warning: exported const ChainPostrouting should have comment (or a comment on this block) or be unexported (golint)
    • Line 93: warning: comment on exported type RestoreCountersFlag should be of the form "RestoreCountersFlag ..." (with optional leading article) (golint)
    • Line 96: warning: exported const RestoreCounters should have comment or be unexported (golint)
    • Line 97: warning: exported const NoRestoreCounters should have comment or be unexported (golint)
    • Line 99: warning: comment on exported type FlushFlag should be of the form "FlushFlag ..." (with optional leading article) (golint)
    • Line 102: warning: exported const FlushTables should have comment or be unexported (golint)
    • Line 103: warning: exported const NoFlushTables should have comment or be unexported (golint)
    • Line 105: warning: comment on exported const MinCheckVersion should be of the form "MinCheckVersion ..." (golint)
    • Line 109: warning: comment on exported const MinWaitVersion should be of the form "MinWaitVersion ..." (golint)
    • Line 111: warning: exported const MinWait2Version should have comment or be unexported (golint)
    • Line 113: warning: exported const LockfilePath16x should have comment or be unexported (golint)
    • Line 353: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 377: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 528: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • kubernikus/pkg/util/wait/wait.go
    • Line 13: warning: error var DoesNotExist should have name of the form ErrFoo (golint)
    • Line 13: warning: exported var DoesNotExist should have comment or be unexported (golint)
    • Line 15: warning: exported function WaitForKluster should have comment or be unexported (golint)
    • Line 33: warning: exported function WaitForKlusterDeletion should have comment or be unexported (golint)
    • kubernikus/pkg/controller/deorbit/logs.go
    • Line 12: warning: exported type LoggingDeorbiter should have comment or be unexported (golint)
    • Line 17: warning: exported method LoggingDeorbiter.DeleteServices should have comment or be unexported (golint)
    • Line 34: warning: exported method LoggingDeorbiter.DeletePersistentVolumeClaims should have comment or be unexported (golint)
    • Line 51: warning: exported method LoggingDeorbiter.WaitForPersistentVolumeCleanup should have comment or be unexported (golint)
    • Line 62: warning: exported method LoggingDeorbiter.WaitForServiceCleanup should have comment or be unexported (golint)
    • Line 73: warning: exported method LoggingDeorbiter.SelfDestruct should have comment or be unexported (golint)
    • Line 85: warning: exported method LoggingDeorbiter.IsAPIUnavailableTimeout should have comment or be unexported (golint)
    • Line 89: warning: exported method LoggingDeorbiter.IsDeorbitHangingTimeout should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikusctl/auth/init.go
    • Line 20: warning: exported type InitOptions should have comment or be unexported (golint)
    • Line 31: warning: exported function NewInitCommand should have comment or be unexported (golint)
    • Line 54: warning: exported method InitOptions.BindFlags should have comment or be unexported (golint)
    • Line 63: warning: exported method InitOptions.Validate should have comment or be unexported (golint)
    • Line 72: warning: exported method InitOptions.Complete should have comment or be unexported (golint)
    • Line 80: warning: exported method InitOptions.Run should have comment or be unexported (golint)
    • Line 86: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 105: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 147: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • kubernikus/pkg/controller/metrics/controller.go
    • Line 14: warning: exported var ControllerOperationsLatency should have comment or be unexported (golint)
    • Line 23: warning: exported var ControllerOperationsTotal should have comment or be unexported (golint)
    • Line 31: warning: exported var ControllerSuccessfulOperationsTotal should have comment or be unexported (golint)
    • Line 39: warning: exported var ControllerFailedOperationsTotal should have comment or be unexported (golint)
    • kubernikus/pkg/util/workqueue/prometheus/prometheus.go
    • Line 34: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 45: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 56: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 67: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 78: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • kubernikus/pkg/controller/metrics/deorbit.go
    • Line 5: warning: exported var DeorbitOperationsLatency should have comment or be unexported (golint)
    • Line 14: warning: exported var DeorbitOperationsTotal should have comment or be unexported (golint)
    • Line 22: warning: exported var DeorbitSuccessfulOperationsTotal should have comment or be unexported (golint)
    • Line 30: warning: exported var DeorbitFailedOperationsTotal should have comment or be unexported (golint)
    • kubernikus/pkg/client/kubernetes/shared_client_factory.go
    • Line 21: warning: exported type SharedClientFactory should have comment or be unexported (golint)
    • Line 32: warning: exported function NewSharedClientFactory should have comment or be unexported (golint)
    • Line 181: warning: exported type MockSharedClientFactory should have comment or be unexported (golint)
    • Line 186: warning: exported method MockSharedClientFactory.ClientFor should have comment or be unexported (golint)
    • Line 190: warning: exported method MockSharedClientFactory.DynamicClientFor should have comment or be unexported (golint)
    • kubernikus/pkg/controller/migration/controller.go
    • Line 17: warning: exported const MigrationFailed should have comment (or a comment on this block) or be unexported (golint)
    • Line 20: warning: exported type MigrationReconciler should have comment or be unexported (golint)
    • Line 27: warning: exported function NewController should have comment or be unexported (golint)
    • Line 37: warning: exported method MigrationReconciler.Reconcile should have comment or be unexported (golint)
    • kubernikus/pkg/util/node.go
    • Line 21: warning: exported const NODE_COREOS_PREFIX should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: comment on exported function IsNodeReady should be of the form "IsNodeReady ..." (golint)
    • Line 102: warning: exported function GetMachineID should have comment or be unexported (golint)
    • Line 116: warning: exported function AddNodeAnnotation should have comment or be unexported (golint)
    • Line 127: warning: exported function RemoveNodeAnnotation should have comment or be unexported (golint)
    • Line 138: warning: exported function IsCoreOSNode should have comment or be unexported (golint)
    • Line 142: warning: exported function IsFlatcarNode should have comment or be unexported (golint)
    • Line 146: warning: exported function IsCoreOSNodePool should have comment or be unexported (golint)
    • Line 150: warning: exported function IsFlatcarNodePool should have comment or be unexported (golint)
    • Line 154: warning: exported function NodeVersionConstraint should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikus/certificates/io.go
    • Line 11: warning: exported type ConfigPersister should have comment or be unexported (golint)
    • Line 15: warning: exported type FilePersister should have comment or be unexported (golint)
    • Line 19: warning: exported function NewFilePersister should have comment or be unexported (golint)
    • Line 25: warning: exported method FilePersister.WriteConfig should have comment or be unexported (golint)
    • Line 45: warning: exported type PlainPersister should have comment or be unexported (golint)
    • Line 47: warning: exported function NewPlainPersister should have comment or be unexported (golint)
    • Line 51: warning: exported method PlainPersister.WriteConfig should have comment or be unexported (golint)
    • kubernikus/pkg/wormhole/server/tunnel.go
    • Line 16: warning: exported type Tunnel should have comment or be unexported (golint)
    • Line 22: warning: exported function NewTunnel should have comment or be unexported (golint)
    • Line 61: warning: exported method Tunnel.Run should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/wormhole/client.go
    • Line 13: warning: exported function NewClientCommand should have comment or be unexported (golint)
    • Line 31: warning: exported type ClientOptions should have comment or be unexported (golint)
    • Line 41: warning: exported function NewClientOptions should have comment or be unexported (golint)
    • Line 48: warning: exported method ClientOptions.BindFlags should have comment or be unexported (golint)
    • Line 58: warning: exported method ClientOptions.Validate should have comment or be unexported (golint)
    • Line 62: warning: exported method ClientOptions.Complete should have comment or be unexported (golint)
    • Line 66: warning: exported method ClientOptions.Run should have comment or be unexported (golint)
    • kubernikus/pkg/client/openstack/admin/logging.go
    • Line 10: warning: exported type LoggingClient should have comment or be unexported (golint)
    • Line 15: warning: exported method LoggingClient.CreateKlusterServiceUser should have comment or be unexported (golint)
    • Line 30: warning: exported method LoggingClient.DeleteUser should have comment or be unexported (golint)
    • Line 44: warning: exported method LoggingClient.GetKubernikusCatalogEntry should have comment or be unexported (golint)
    • Line 57: warning: exported method LoggingClient.GetRegion should have comment or be unexported (golint)
    • Line 70: warning: exported method LoggingClient.CreateStorageContainer should have comment or be unexported (golint)
    • Line 86: warning: exported method LoggingClient.AssignUserRoles should have comment or be unexported (golint)
    • Line 102: warning: exported method LoggingClient.GetUserRoles should have comment or be unexported (golint)
    • Line 118: warning: exported method LoggingClient.GetDomainNameByProject should have comment or be unexported (golint)
    • Line 131: warning: exported method LoggingClient.GetDefaultServiceUserRoles should have comment or be unexported (golint)
    • kubernikus/test/e2e/framework/conditions.go
    • Line 14: warning: exported function ServiceAccountHasSecrets should have comment or be unexported (golint)
    • Line 26: warning: exported function PodRunningReady should have comment or be unexported (golint)
    • Line 40: warning: exported function IsRetryableAPIError should have comment or be unexported (golint)
    • Line 44: warning: exported function IsPodReady should have comment or be unexported (golint)
    • Line 75: warning: exported function CountEndpointsNum should have comment or be unexported (golint)
    • Line 83: warning: exported function IsAllNodesOfPoolReady should have comment or be unexported (golint)
    • Line 89: warning: exported function IsAllNodePoolsOfKlusterReady should have comment or be unexported (golint)
    • Line 103: warning: exported function IsPVCBound should have comment or be unexported (golint)
    • kubernikus/pkg/controller/ground/bootstrap/dns/kubedns.go
    • Line 17: warning: exported const SERVICE_ACCOUNT should have comment (or a comment on this block) or be unexported (golint)
    • Line 21: warning: comment on exported const DEFAULT_VERSION should be of the form "DEFAULT_VERSION ..." (golint)
    • Line 31: warning: exported var DEFAULT_DOMAIN should have comment or be unexported (golint)
    • Line 34: warning: exported type DeploymentOptions should have comment or be unexported (golint)
    • Line 40: warning: exported type ServiceOptions should have comment or be unexported (golint)
    • Line 44: warning: exported function SeedKubeDNS should have comment or be unexported (golint)
    • Line 174: warning: don't use underscores in Go names; const KubeDNSDeployment_v20171016 should be KubeDNSDeploymentV20171016 (golint)
    • Line 174: warning: exported const KubeDNSDeployment_v20171016 should have comment (or a comment on this block) or be unexported (golint)
    • Line 340: warning: comment on exported const KubeDNSService_v20171016 should be of the form "KubeDNSService_v20171016 ..." (golint)
    • Line 341: warning: don't use underscores in Go names; const KubeDNSService_v20171016 should be KubeDNSServiceV20171016 (golint)
    • kubernikus/pkg/controller/metrics/metrics.go
    • Line 65: warning: comment on exported function SetMetricKlusterStatusPhase should be of the form "SetMetricKlusterStatusPhase ..." (golint)
    • Line 83: warning: exported function SetMetricKlusterTerminated should have comment or be unexported (golint)
    • Line 105: warning: comment on exported function SetMetricNodePoolStatus should be of the form "SetMetricNodePoolStatus ..." (golint)
    • Line 123: warning: exported function SetMetricBootDurationSummary should have comment or be unexported (golint)
    • Line 159: warning: exported function ExposeMetrics should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikusctl/auth/refresh.go
    • Line 18: warning: exported type RefreshOptions should have comment or be unexported (golint)
    • Line 29: warning: exported function NewRefreshCommand should have comment or be unexported (golint)
    • Line 49: warning: exported method RefreshOptions.BindFlags should have comment or be unexported (golint)
    • Line 58: warning: exported method RefreshOptions.Validate should have comment or be unexported (golint)
    • Line 62: warning: exported method RefreshOptions.Complete should have comment or be unexported (golint)
    • Line 70: warning: exported method RefreshOptions.Run should have comment or be unexported (golint)
    • Line 84: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 136: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • kubernikus/pkg/controller/ground/bootstrap.go
    • Line 24: warning: exported function SeedKluster should have comment or be unexported (golint)
    • Line 106: warning: exported function SeedCinderStorageClasses should have comment or be unexported (golint)
    • Line 175: warning: exported function DeleteCinderStorageClasses should have comment or be unexported (golint)
    • Line 200: warning: exported function SeedKubernikusAdmin should have comment or be unexported (golint)
    • Line 219: warning: exported function SeedKubernikusMember should have comment or be unexported (golint)
    • Line 239: warning: exported function SeedAllowBootstrapTokensToPostCSRs should have comment or be unexported (golint)
    • Line 258: warning: exported function SeedAllowApiserverToAccessKubeletAPI should have comment or be unexported (golint)
    • Line 277: warning: exported function SeedAutoApproveNodeBootstrapTokens should have comment or be unexported (golint)
    • Line 312: warning: exported function SeedAutoRenewalNodeCertificates should have comment or be unexported (golint)
    • Line 348: warning: exported function SeedOpenStackClusterRoleBindings should have comment or be unexported (golint)
    • kubernikus/pkg/wormhole/client/health.go
    • Line 28: warning: exported const NodeRouteBroken should have comment or be unexported (golint)
    • Line 38: warning: exported function NewHealthChecker should have comment or be unexported (golint)
    • Line 187: warning: exported function IsNodeRouteBroken should have comment or be unexported (golint)
    • kubernikus/pkg/controller/deorbit/fake.go
    • Line 10: warning: exported type FakeDeorbiter should have comment or be unexported (golint)
    • Line 26: warning: exported method FakeDeorbiter.DeletePersistentVolumeClaims should have comment or be unexported (golint)
    • Line 45: warning: exported method FakeDeorbiter.DeleteServices should have comment or be unexported (golint)
    • Line 64: warning: exported method FakeDeorbiter.WaitForPersistentVolumeCleanup should have comment or be unexported (golint)
    • Line 70: warning: exported method FakeDeorbiter.WaitForServiceCleanup should have comment or be unexported (golint)
    • Line 76: warning: exported method FakeDeorbiter.SelfDestruct should have comment or be unexported (golint)
    • Line 82: warning: exported method FakeDeorbiter.IsAPIUnavailableTimeout should have comment or be unexported (golint)
    • Line 86: warning: exported method FakeDeorbiter.IsDeorbitHangingTimeout should have comment or be unexported (golint)
    • kubernikus/pkg/controller/deorbit/metrics.go
    • Line 10: warning: exported type InstrumentingDeorbiter should have comment or be unexported (golint)
    • Line 19: warning: exported method InstrumentingDeorbiter.DeletePersistentVolumeClaims should have comment or be unexported (golint)
    • Line 24: warning: exported method InstrumentingDeorbiter.DeleteServices should have comment or be unexported (golint)
    • Line 29: warning: exported method InstrumentingDeorbiter.WaitForPersistentVolumeCleanup should have comment or be unexported (golint)
    • Line 34: warning: exported method InstrumentingDeorbiter.WaitForServiceCleanup should have comment or be unexported (golint)
    • Line 39: warning: exported method InstrumentingDeorbiter.SelfDestruct should have comment or be unexported (golint)
    • Line 55: warning: exported method InstrumentingDeorbiter.IsAPIUnavailableTimeout should have comment or be unexported (golint)
    • Line 59: warning: exported method InstrumentingDeorbiter.IsDeorbitHangingTimeout should have comment or be unexported (golint)
    • kubernikus/pkg/util/icmp/redirect.go
    • Line 13: warning: exported type Redirect should have comment or be unexported (golint)
    • Line 19: warning: exported method Redirect.Len should have comment or be unexported (golint)
    • Line 26: warning: exported method Redirect.Marshal should have comment or be unexported (golint)
    • kubernikus/pkg/api/auth/authorizer.go
    • Line 22: warning: exported var DefaultPolicyFile should have comment or be unexported (golint)
    • Line 35: warning: exported function LoadPolicy should have comment or be unexported (golint)
    • Line 49: warning: exported function NewOsloPolicyAuthorizer should have comment or be unexported (golint)
    • kubernikus/pkg/util/pod/pod.go
    • Line 12: warning: comment on exported function IsPodReadyConditionTrue should be of the form "IsPodReadyConditionTrue ..." (golint)
    • Line 18: warning: comment on exported function GetPodReadyCondition should be of the form "GetPodReadyCondition ..." (golint)
    • kubernikus/pkg/client/openstack/project/client.go
    • Line 18: warning: exported type ProjectClient should have comment or be unexported (golint)
    • Line 30: warning: exported function NewProjectClient should have comment or be unexported (golint)
    • Line 79: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • kubernikus/pkg/controller/deorbit/events.go
    • Line 13: warning: exported type EventingDeorbiter should have comment or be unexported (golint)
    • Line 19: warning: exported method EventingDeorbiter.DeletePersistentVolumeClaims should have comment or be unexported (golint)
    • Line 33: warning: exported method EventingDeorbiter.DeleteServices should have comment or be unexported (golint)
    • Line 47: warning: exported method EventingDeorbiter.WaitForPersistentVolumeCleanup should have comment or be unexported (golint)
    • Line 61: warning: exported method EventingDeorbiter.WaitForServiceCleanup should have comment or be unexported (golint)
    • Line 75: warning: exported method EventingDeorbiter.SelfDestruct should have comment or be unexported (golint)
    • Line 87: warning: exported method EventingDeorbiter.IsAPIUnavailableTimeout should have comment or be unexported (golint)
    • Line 91: warning: exported method EventingDeorbiter.IsDeorbitHangingTimeout should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikus/operator.go
    • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 24: warning: exported function NewOperatorCommand should have comment or be unexported (golint)
    • Line 41: warning: exported type Options should have comment or be unexported (golint)
    • Line 45: warning: exported function NewOperatorOptions should have comment or be unexported (golint)
    • Line 59: warning: exported method Options.BindFlags should have comment or be unexported (golint)
    • Line 80: warning: exported method Options.Validate should have comment or be unexported (golint)
    • Line 93: warning: exported method Options.Run should have comment or be unexported (golint)
    • kubernikus/pkg/apis/kubernikus/v1/zz_generated.deepcopy.go
    • Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 85: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • kubernikus/pkg/cmd/printers/printable.go
    • Line 7: warning: exported type PrintFormat should have comment or be unexported (golint)
    • Line 10: warning: exported const Human should have comment (or a comment on this block) or be unexported (golint)
    • Line 14: warning: exported type PrintOptions should have comment or be unexported (golint)
    • Line 18: warning: exported type Printable should have comment or be unexported (golint)
    • Line 23: warning: exported function PrintTable should have comment or be unexported (golint)
    • kubernikus/pkg/controller/flight/factory.go
    • Line 15: warning: exported type FlightReconcilerFactory should have comment or be unexported (golint)
    • Line 27: warning: exported function NewFlightReconcilerFactory should have comment or be unexported (golint)
    • Line 63: warning: receiver name d should be consistent with previous receiver name f for flightReconcilerFactory (golint)
    • Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • kubernikus/pkg/cmd/kubernikusctl/common/kubernikus.go
    • Line 15: warning: exported type KubernikusClient should have comment or be unexported (golint)
    • Line 20: warning: exported function NewKubernikusClient should have comment or be unexported (golint)
    • Line 40: warning: exported method KubernikusClient.GetCredentials should have comment or be unexported (golint)
    • Line 59: warning: exported method KubernikusClient.CreateCluster should have comment or be unexported (golint)
    • Line 72: warning: exported method KubernikusClient.DeleteCluster should have comment or be unexported (golint)
    • Line 85: warning: exported method KubernikusClient.ShowCluster should have comment or be unexported (golint)
    • Line 99: warning: exported method KubernikusClient.GetClusterValues should have comment or be unexported (golint)
    • Line 115: warning: exported method KubernikusClient.ListAllClusters should have comment or be unexported (golint)
    • Line 133: warning: exported method KubernikusClient.ListNodePools should have comment or be unexported (golint)
    • Line 141: warning: exported method KubernikusClient.ShowNodePool should have comment or be unexported (golint)
    • Line 154: warning: exported method KubernikusClient.GetDefaultCluster should have comment or be unexported (golint)
    • kubernikus/pkg/controller/operator.go
    • Line 34: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 38: warning: exported type KubernikusOperatorOptions should have comment or be unexported (golint)
    • Line 61: warning: exported type KubernikusOperator should have comment or be unexported (golint)
    • Line 69: warning: exported const DEFAULT_RECONCILIATION should have comment (or a comment on this block) or be unexported (golint)
    • Line 72: warning: exported function NewKubernikusOperator should have comment or be unexported (golint)
    • Line 206: warning: exported method KubernikusOperator.Run should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikus/certificates/plain.go
    • Line 15: warning: exported function NewPlainCommand should have comment or be unexported (golint)
    • Line 31: warning: exported type PlainOptions should have comment or be unexported (golint)
    • Line 35: warning: exported function NewPlainOptions should have comment or be unexported (golint)
    • Line 39: warning: exported method PlainOptions.Validate should have comment or be unexported (golint)
    • Line 47: warning: exported method PlainOptions.Complete should have comment or be unexported (golint)
    • Line 52: warning: exported method PlainOptions.Run should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikusctl/get/common.go
    • Line 16: warning: exported type GetOptions should have comment or be unexported (golint)
    • Line 23: warning: exported method GetOptions.BindFlags should have comment or be unexported (golint)
    • Line 29: warning: exported method GetOptions.PersistentPreRun should have comment or be unexported (golint)
    • Line 36: warning: exported method GetOptions.SetupKubernikusClient should have comment or be unexported (golint)
    • kubernikus/pkg/wormhole/server/controller.go
    • Line 25: warning: exported const KUBERNIKUS_TUNNELS should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: exported type Controller should have comment or be unexported (golint)
    • Line 45: warning: exported function NewController should have comment or be unexported (golint)
    • Line 88: warning: exported method Controller.Run should have comment or be unexported (golint)
    • Line 350: warning: exported function GetNodeHostIP should have comment or be unexported (golint)
    • kubernikus/pkg/api/spec/document.go
    • Line 23: warning: exported function MustDefaultString should have comment or be unexported (golint)
    • Line 31: warning: exported function DefaultString should have comment or be unexported (golint)
    • Line 43: warning: exported function MustDefaultInt64 should have comment or be unexported (golint)
    • Line 51: warning: exported function DefaultInt64 should have comment or be unexported (golint)
    • kubernikus/pkg/controller/servicing/flatcar/testing.go
    • Line 13: warning: exported function NewFakeVersion should have comment or be unexported (golint)
    • Line 20: warning: exported function NewFakeRelease should have comment or be unexported (golint)
    • Line 34: warning: exported function NewTestClient should have comment or be unexported (golint)
    • Line 52: warning: exported type RoundTripFunc should have comment or be unexported (golint)
    • Line 54: warning: exported method RoundTripFunc.RoundTrip should have comment or be unexported (golint)
    • kubernikus/pkg/controller/launch/pool_manager.go
    • Line 24: warning: exported type PoolManager should have comment or be unexported (golint)
    • Line 32: warning: exported type PoolStatus should have comment or be unexported (golint)
    • Line 43: warning: exported type ConcretePoolManager should have comment or be unexported (golint)
    • Line 81: warning: exported method ConcretePoolManager.GetStatus should have comment or be unexported (golint)
    • Line 128: warning: exported method ConcretePoolManager.SetStatus should have comment or be unexported (golint)
    • Line 189: warning: exported method ConcretePoolManager.CreateNode should have comment or be unexported (golint)
    • Line 219: warning: exported method ConcretePoolManager.DeleteNode should have comment or be unexported (golint)
    • Line 226: warning: exported method ConcretePoolManager.DeletePool should have comment or be unexported (golint)
    • kubernikus/pkg/controller/metrics/launch.go
    • Line 19: warning: exported var LaunchOperationsLatency should have comment or be unexported (golint)
    • Line 28: warning: exported var LaunchOperationsTotal should have comment or be unexported (golint)
    • Line 36: warning: exported var LaunchSuccessfulOperationsTotal should have comment or be unexported (golint)
    • Line 44: warning: exported var LaunchFailedOperationsTotal should have comment or be unexported (golint)
    • kubernikus/pkg/controller/launch/instrumenting.go
    • Line 9: warning: exported type InstrumentingPoolManager should have comment or be unexported (golint)
    • Line 18: warning: exported method InstrumentingPoolManager.GetStatus should have comment or be unexported (golint)
    • Line 45: warning: exported method InstrumentingPoolManager.SetStatus should have comment or be unexported (golint)
    • Line 72: warning: exported method InstrumentingPoolManager.CreateNode should have comment or be unexported (golint)
    • Line 100: warning: exported method InstrumentingPoolManager.DeleteNode should have comment or be unexported (golint)
    • Line 128: warning: exported method InstrumentingPoolManager.DeletePool should have comment or be unexported (golint)
    • kubernikus/pkg/controller/nodeobservatory/factory.go
    • Line 12: warning: exported function NewInformerFactory should have comment or be unexported (golint)
    • Line 20: warning: exported type InformerFactory should have comment or be unexported (golint)
    • Line 28: warning: exported method InformerFactory.Start should have comment or be unexported (golint)
    • Line 36: warning: exported method InformerFactory.NodeInformer should have comment or be unexported (golint)
    • kubernikus/pkg/cmd/kubernikus/seed/dns.go
    • Line 15: warning: exported function NewKubeDNSCommand should have comment or be unexported (golint)
    • Line 33: warning: exported type KubeDNSOptions should have comment or be unexported (golint)
    • Line 43: warning: exported function NewKubeDNSOptions should have comment or be unexported (golint)
    • Line 51: warning: exported method KubeDNSOptions.BindFlags should have comment or be unexported (golint)
    • Line 61: warning: exported method KubeDNSOptions.Validate should have comment or be unexported (golint)
    • Line 68: warning: exported method KubeDNSOptions.Complete should have comment or be unexported (golint)
    • Line 72: warning: exported method KubeDNSOptions.Run should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!