Preparing report...

Report for github.com/scipipe/scipipe

A    Great!    Found 29 issues across 61 files

Tweet

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • scipipe/workflow.go
    • Line 343: warning: cyclomatic complexity 17 of function (*Workflow).reconnectDeadEndConnections() is high (> 15) (gocyclo)
    • scipipe/process.go
    • Line 66: warning: cyclomatic complexity 16 of function (*Process).initPortsFromCmdPattern() is high (> 15) (gocyclo)
    • scipipe/task.go
    • Line 89: warning: cyclomatic complexity 22 of function (*Task).formatCommand() is high (> 15) (gocyclo)

golint55%

Golint is a linter for Go source code.

    • scipipe/examples/custom_execution_function/funchook.go
    • Line 6: warning: should not use dot imports (golint)
    • Line 26: warning: exported type Fooer should have comment or be unexported (golint)
    • Line 31: warning: exported function NewFooer should have comment or be unexported (golint)
    • Line 49: warning: exported method Fooer.OutFoo should have comment or be unexported (golint)
    • Line 53: warning: exported type Foo2Barer should have comment or be unexported (golint)
    • Line 58: warning: exported function NewFoo2Barer should have comment or be unexported (golint)
    • Line 76: warning: exported method Foo2Barer.InFoo should have comment or be unexported (golint)
    • Line 77: warning: exported method Foo2Barer.OutBar should have comment or be unexported (golint)
    • scipipe/examples/subworkflow/subworkflow.go
    • Line 22: warning: exported type FooBarSubWorkflow should have comment or be unexported (golint)
    • Line 28: warning: exported function NewFooBarSubWorkflow should have comment or be unexported (golint)
    • Line 48: warning: exported method FooBarSubWorkflow.Name should have comment or be unexported (golint)
    • Line 52: warning: exported method FooBarSubWorkflow.Run should have comment or be unexported (golint)
    • Line 58: warning: exported method FooBarSubWorkflow.Ready should have comment or be unexported (golint)
    • scipipe/ip.go
    • Line 70: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 413: warning: exported method FileIP.Failf should have comment or be unexported (golint)
    • Line 417: warning: exported method FileIP.Fail should have comment or be unexported (golint)
    • scipipe/workflow.go
    • Line 426: warning: exported method Workflow.Auditf should have comment or be unexported (golint)
    • Line 430: warning: exported method Workflow.Failf should have comment or be unexported (golint)
    • Line 434: warning: exported method Workflow.Fail should have comment or be unexported (golint)
    • scipipe/examples/wrapper_procs/wrap.go
    • Line 27: warning: exported type Fooer should have comment or be unexported (golint)
    • Line 32: warning: exported function NewFooer should have comment or be unexported (golint)
    • Line 40: warning: exported method Fooer.OutFoo should have comment or be unexported (golint)
    • Line 47: warning: exported type Foo2Barer should have comment or be unexported (golint)
    • Line 52: warning: exported function NewFoo2Barer should have comment or be unexported (golint)
    • Line 60: warning: exported method Foo2Barer.InFoo should have comment or be unexported (golint)
    • Line 64: warning: exported method Foo2Barer.OutBar should have comment or be unexported (golint)
    • scipipe/sink.go
    • Line 63: warning: exported method Sink.Failf should have comment or be unexported (golint)
    • Line 67: warning: exported method Sink.Fail should have comment or be unexported (golint)
    • scipipe/examples/param_channels/params.go
    • Line 35: warning: exported type CombinatoricsGen should have comment or be unexported (golint)
    • Line 39: warning: exported function NewCombinatoricsGen should have comment or be unexported (golint)
    • Line 50: warning: exported method CombinatoricsGen.A should have comment or be unexported (golint)
    • Line 51: warning: exported method CombinatoricsGen.B should have comment or be unexported (golint)
    • Line 52: warning: exported method CombinatoricsGen.C should have comment or be unexported (golint)
    • Line 54: warning: exported method CombinatoricsGen.Run should have comment or be unexported (golint)
    • Line 68: warning: exported method CombinatoricsGen.Failf should have comment or be unexported (golint)
    • Line 72: warning: exported method CombinatoricsGen.Fail should have comment or be unexported (golint)
    • scipipe/components/file_splitter.go
    • Line 122: warning: exported method FileSplitter.Failf should have comment or be unexported (golint)
    • Line 126: warning: exported method FileSplitter.Fail should have comment or be unexported (golint)
    • Line 130: warning: exported method FileSplitter.Auditf should have comment or be unexported (golint)
    • Line 134: warning: exported method FileSplitter.Audit should have comment or be unexported (golint)
    • scipipe/process.go
    • Line 418: warning: exported method Process.Failf should have comment or be unexported (golint)
    • Line 422: warning: exported method Process.Fail should have comment or be unexported (golint)
    • scipipe/task.go
    • Line 339: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 405: warning: exported method Task.Auditf should have comment or be unexported (golint)
    • Line 409: warning: exported method Task.Audit should have comment or be unexported (golint)
    • Line 413: warning: exported method Task.Failf should have comment or be unexported (golint)
    • Line 417: warning: exported method Task.Fail should have comment or be unexported (golint)
    • Line 444: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 453: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign0%

IneffAssign detects ineffectual assignments in Go code.

An error occurred while running this test (exit status 3)


misspell0%

Misspell Finds commonly misspelled English words

An error occurred while running this test (exit status 2)