Preparing report...

Report for github.com/scottdware/go-bigip

A    Great!    Found 8 issues across 15 files

Tweet

gofmt86%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint66%

Golint is a linter for Go source code.

    • go-bigip/cm.go
    • Line 65: warning: exported type ConfigSync should have comment or be unexported (golint)
    • Line 114: warning: comment on exported method BigIP.UploadSoftwareImage should be of the form "UploadSoftwareImage ..." (golint)
    • go-bigip/ltm.go
    • Line 137: warning: exported type TcpProfile should have comment or be unexported (golint)
    • Line 159: warning: don't use underscores in Go names; struct field FinWait_2Timeout should be FinWait2Timeout (golint)
    • Line 227: warning: exported type UdpProfile should have comment or be unexported (golint)
    • Line 248: warning: exported type HttpProfiles should have comment or be unexported (golint)
    • Line 252: warning: exported type HttpProfile should have comment or be unexported (golint)
    • Line 282: warning: exported type OneconnectProfiles should have comment or be unexported (golint)
    • Line 286: warning: exported type OneconnectProfile should have comment or be unexported (golint)
    • Line 301: warning: exported type HttpCompressionProfiles should have comment or be unexported (golint)
    • Line 305: warning: exported type HttpCompressionProfile should have comment or be unexported (golint)
    • Line 306: warning: don't use underscores in Go names; struct field AllowHttp_10 should be AllowHTTP10 (golint)
    • Line 367: warning: comment on exported type DataGroup should be of the form "DataGroup ..." (with optional leading article) (golint)
    • Line 377: warning: exported type DataGroupRecord should have comment or be unexported (golint)
    • Line 394: warning: exported method DataGroup.MarshalJSON should have comment or be unexported (golint)
    • Line 400: warning: exported method DataGroup.UnmarshalJSON should have comment or be unexported (golint)
    • Line 462: warning: comment on exported type PoolMembers should be of the form "PoolMembers ..." (with optional leading article) (golint)
    • Line 477: warning: comment on exported type PoolMember should be of the form "PoolMember ..." (with optional leading article) (golint)
    • Line 601: warning: exported type Policies should have comment or be unexported (golint)
    • Line 605: warning: exported type Policy should have comment or be unexported (golint)
    • Line 627: warning: exported method Policy.MarshalJSON should have comment or be unexported (golint)
    • Line 641: warning: exported method Policy.UnmarshalJSON should have comment or be unexported (golint)
    • Line 659: warning: exported type PolicyRules should have comment or be unexported (golint)
    • Line 663: warning: exported type PolicyRule should have comment or be unexported (golint)
    • Line 684: warning: exported method PolicyRule.MarshalJSON should have comment or be unexported (golint)
    • Line 698: warning: exported method PolicyRule.UnmarshalJSON should have comment or be unexported (golint)
    • Line 714: warning: exported type PolicyRuleActions should have comment or be unexported (golint)
    • Line 718: warning: exported type PolicyRuleAction should have comment or be unexported (golint)
    • Line 824: warning: exported type PolicyRuleConditions should have comment or be unexported (golint)
    • Line 828: warning: exported type PolicyRuleCondition should have comment or be unexported (golint)
    • Line 874: warning: don't use underscores in Go names; struct field Last_15secs should be Last15secs (golint)
    • Line 875: warning: don't use underscores in Go names; struct field Last_1min should be Last1min (golint)
    • Line 876: warning: don't use underscores in Go names; struct field Last_5mins should be Last5mins (golint)
    • Line 923: warning: exported method VirtualAddress.MarshalJSON should have comment or be unexported (golint)
    • Line 929: warning: exported method VirtualAddress.UnmarshalJSON should have comment or be unexported (golint)
    • Line 1002: warning: exported method Monitor.MarshalJSON should have comment or be unexported (golint)
    • Line 1011: warning: exported method Monitor.UnmarshalJSON should have comment or be unexported (golint)
    • Line 1020: warning: exported type Profiles should have comment or be unexported (golint)
    • Line 1024: warning: exported type Profile should have comment or be unexported (golint)
    • Line 1031: warning: exported type IRules should have comment or be unexported (golint)
    • Line 1035: warning: exported type IRule should have comment or be unexported (golint)
    • Line 1207: warning: exported method BigIP.GetTcpProfile should have comment or be unexported (golint)
    • Line 1231: warning: exported method BigIP.AddTcpProfile should have comment or be unexported (golint)
    • Line 1257: warning: exported method BigIP.GetUdpProfile should have comment or be unexported (golint)
    • Line 1281: warning: exported method BigIP.AddUdpProfile should have comment or be unexported (golint)
    • Line 1307: warning: exported method BigIP.GetHttpProfile should have comment or be unexported (golint)
    • Line 1331: warning: exported method BigIP.AddHttpProfile should have comment or be unexported (golint)
    • Line 1357: warning: exported method BigIP.GetOneconnectProfile should have comment or be unexported (golint)
    • Line 1381: warning: exported method BigIP.AddOneconnectProfile should have comment or be unexported (golint)
    • Line 1407: warning: exported method BigIP.GetHttpCompressionProfile should have comment or be unexported (golint)
    • Line 1431: warning: exported method BigIP.AddHttpCompressionProfile should have comment or be unexported (golint)
    • Line 1471: warning: comment on exported method BigIP.CreateNodeAdv should be of the form "CreateNodeAdv ..." (golint)
    • Line 1486: warning: don't use underscores in Go names; method parameter rate_limit should be rateLimit (golint)
    • Line 1486: warning: don't use underscores in Go names; method parameter connection_limit should be connectionLimit (golint)
    • Line 1486: warning: don't use underscores in Go names; method parameter dynamic_ratio should be dynamicRatio (golint)
    • Line 1499: warning: comment on exported method BigIP.GetNode should be of the form "GetNode ..." (golint)
    • Line 1555: warning: exported method BigIP.GetInternalDataGroup should have comment or be unexported (golint)
    • Line 1570: warning: comment on exported method BigIP.CreateInternalDataGroup should be of the form "CreateInternalDataGroup ..." (golint)
    • Line 1580: warning: exported method BigIP.AddInternalDataGroup should have comment or be unexported (golint)
    • Line 1584: warning: exported method BigIP.DeleteInternalDataGroup should have comment or be unexported (golint)
    • Line 1588: warning: comment on exported method BigIP.ModifyInternalDataGroupRecords should be of the form "ModifyInternalDataGroupRecords ..." (golint)
    • Line 1596: warning: comment on exported method BigIP.GetInternalDataGroupRecords should be of the form "GetInternalDataGroupRecords ..." (golint)
    • Line 1737: warning: comment on exported method BigIP.GetPool should be of the form "GetPool ..." (golint)
    • Line 1815: warning: don't use underscores in Go names; var policy_names should be policyNames (golint)
    • Line 1855: warning: comment on exported method BigIP.VirtualServerPolicyNames should be of the form "VirtualServerPolicyNames ..." (golint)
    • Line 1889: warning: exported method BigIP.CreateVirtualAddress should have comment or be unexported (golint)
    • Line 1914: warning: exported method BigIP.DeleteVirtualAddress should have comment or be unexported (golint)
    • Line 1963: warning: comment on exported method BigIP.AddMonitor should be of the form "AddMonitor ..." (golint)
    • Line 1972: warning: comment on exported method BigIP.GetMonitor should be of the form "GetMonitor ..." (golint)
    • Line 2061: warning: exported method BigIP.Policies should have comment or be unexported (golint)
    • Line 2071: warning: comment on exported method BigIP.GetPolicy should be of the form "GetPolicy ..." (golint)
    • Line 2089: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
    • Line 2110: warning: should omit 2nd value from range; this loop is equivalent to `for ri := range ...` (golint)
    • Line 2112: warning: should omit 2nd value from range; this loop is equivalent to `for ai := range ...` (golint)
    • Line 2115: warning: should omit 2nd value from range; this loop is equivalent to `for ci := range ...` (golint)
    • Line 2121: warning: comment on exported method BigIP.CreatePolicy should be of the form "CreatePolicy ..." (golint)
    • Line 2127: warning: comment on exported method BigIP.UpdatePolicy should be of the form "UpdatePolicy ..." (golint)
    • Line 2133: warning: comment on exported method BigIP.DeletePolicy should be of the form "DeletePolicy ..." (golint)
    • Line 2147: warning: comment on exported method BigIP.PublishDraftPolicy should be of the form "PublishDraftPolicy ..." (golint)
    • Line 2158: warning: comment on exported method BigIP.AddRuleToPolicy should be of the form "AddRuleToPolicy ..." (golint)
    • Line 2163: warning: comment on exported method BigIP.ModifyPolicyRule should be of the form "ModifyPolicyRule ..." (golint)
    • Line 2168: warning: comment on exported method BigIP.RemoveRuleFromPolicy should be of the form "RemoveRuleFromPolicy ..." (golint)
    • go-bigip/shared.go
    • Line 42: warning: exported const ENABLED should have comment (or a comment on this block) or be unexported (golint)
    • Line 115: warning: comment on exported type Activation should be of the form "Activation ..." (with optional leading article) (golint)
    • Line 126: warning: comment on exported type LicenseState should be of the form "LicenseState ..." (with optional leading article) (golint)
    • Line 153: warning: comment on exported type LicenseFeatureFlag should be of the form "LicenseFeatureFlag ..." (with optional leading article) (golint)
    • Line 159: warning: comment on exported method BigIP.GetActivationStatus should be of the form "GetActivationStatus ..." (golint)
    • Line 170: warning: comment on exported method BigIP.Activate should be of the form "Activate ..." (golint)
    • Line 176: warning: comment on exported method BigIP.GetLicenseState should be of the form "GetLicenseState ..." (golint)
    • Line 186: warning: comment on exported method BigIP.InstallLicense should be of the form "InstallLicense ..." (golint)
    • Line 192: warning: comment on exported method BigIP.AutoLicense should be of the form "AutoLicense ..." (golint)
    • Line 262: warning: comment on exported method BigIP.UploadFile should be of the form "UploadFile ..." (golint)
    • Line 275: warning: comment on exported method BigIP.UploadBytes should be of the form "UploadBytes ..." (golint)
    • go-bigip/sys.go
    • Line 24: warning: exported type Volumes should have comment or be unexported (golint)
    • Line 28: warning: exported type Volume should have comment or be unexported (golint)
    • Line 52: warning: exported type ManagementIP should have comment or be unexported (golint)
    • Line 56: warning: exported type ManagementIPAddress should have comment or be unexported (golint)
    • Line 63: warning: exported method BigIP.ManagementIPs should have comment or be unexported (golint)
    • Line 73: warning: exported type SyslogRemoteServer should have comment or be unexported (golint)
    • Line 80: warning: exported type Syslog should have comment or be unexported (golint)
    • Line 85: warning: exported method BigIP.Syslog should have comment or be unexported (golint)
    • Line 96: warning: exported method BigIP.SetSyslog should have comment or be unexported (golint)
    • Line 127: warning: exported type Folder should have comment or be unexported (golint)
    • Line 147: warning: exported method Folder.MarshalJSON should have comment or be unexported (golint)
    • Line 153: warning: exported method Folder.UnmarshalJSON should have comment or be unexported (golint)
    • Line 365: warning: exported type SysConfig should have comment or be unexported (golint)
    • go-bigip/bigip.go
    • Line 27: warning: exported type ConfigOptions should have comment or be unexported (golint)
    • Line 243: warning: error should be the last type when returning multiple items (golint)
    • Line 300: warning: comment on exported function Bool should be of the form "Bool ..." (golint)

gocyclo86%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


ineffassign93%

IneffAssign detects ineffectual assignments in Go code.


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell93%

Misspell Finds commonly misspelled English words