gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• workflow-controller/test/e2e/e2e.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• workflow-controller/pkg/controller/daemonsetjob.go
  • Line 287: warning: cyclomatic complexity 27 of function (*DaemonSetJobController).manageDaemonSetJob() is high (> 15) (gocyclo)

• workflow-controller/pkg/controller/daemonsetjob_test.go
  • Line 320: warning: cyclomatic complexity 23 of function TestDaemonSetJobController_sync() is high (> 15) (gocyclo)

• workflow-controller/pkg/controller/workflow_test.go
  • Line 114: warning: cyclomatic complexity 16 of function TestControllerSyncWorkflow() is high (> 15) (gocyclo)

golint61%

Golint is a linter for Go source code.

• workflow-controller/pkg/client/clientset/versioned/typed/daemonsetjob/v1/fake/fake_daemonsetjob_client.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)
  • Line 27: warning: exported type FakeDaemonsetjobV1 should have comment or be unexported (golint)
  • Line 31: warning: exported method FakeDaemonsetjobV1.DaemonSetJobs should have comment or be unexported (golint)

• workflow-controller/test/e2e/daemonsetjobs.go
  • Line 6: warning: should not use dot imports (golint)
  • Line 7: warning: should not use dot imports (golint)

• workflow-controller/pkg/api/cronworkflow/v1/zz_generated.deepcopy.go
  • Line 86: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 120: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• workflow-controller/pkg/util/util.go
  • Line 41: warning: exported function CopyMap should have comment or be unexported (golint)
  • Line 49: warning: exported function GetWorkflowSpecFromWorkflowTemplate should have comment or be unexported (golint)

• workflow-controller/pkg/client/clientset/versioned/doc.go
  • Line 18: warning: package comment should be of the form "Package versioned ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/cronworkflow/v1/fake/doc.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/cronworkflow/v1/fake/fake_cronworkflow.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/workflow/v1/workflow_client.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)
  • Line 28: warning: exported type WorkflowV1Interface should have comment or be unexported (golint)
  • Line 38: warning: exported method WorkflowV1Client.Workflows should have comment or be unexported (golint)

• workflow-controller/pkg/controller/cronworkflow.go
  • Line 30: warning: exported const CronWorkflowLabelKey should have comment (or a comment on this block) or be unexported (golint)

• workflow-controller/pkg/client/informers/externalversions/internalinterfaces/factory_interfaces.go
  • Line 32: warning: exported type NewInformerFunc should have comment or be unexported (golint)
  • Line 40: warning: exported type TweakListOptionsFunc should have comment or be unexported (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/cronworkflow/v1/fake/fake_cronworkflow_client.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)
  • Line 27: warning: exported type FakeCronworkflowV1 should have comment or be unexported (golint)
  • Line 31: warning: exported method FakeCronworkflowV1.CronWorkflows should have comment or be unexported (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/cronworkflow/v1/doc.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/workflow/v1/workflow.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/daemonsetjob/v1/fake/fake_daemonsetjob.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)

• workflow-controller/test/e2e/workflows.go
  • Line 11: warning: should not use dot imports (golint)
  • Line 12: warning: should not use dot imports (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/daemonsetjob/v1/daemonsetjob_client.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)
  • Line 28: warning: exported type DaemonsetjobV1Interface should have comment or be unexported (golint)
  • Line 38: warning: exported method DaemonsetjobV1Client.DaemonSetJobs should have comment or be unexported (golint)

• workflow-controller/test/e2e/framework/workflows_utils.go
  • Line 7: warning: should not use dot imports (golint)

• workflow-controller/pkg/api/daemonsetjob/v1/register.go
  • Line 12: warning: exported var SchemeBuilder should have comment or be unexported (golint)
  • Line 21: warning: comment on exported const ResourceKind should be of the form "ResourceKind ..." (golint)
  • Line 23: warning: comment on exported const ResourceVersion should be of the form "ResourceVersion ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/fake/doc.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)

• workflow-controller/pkg/garbagecollector/daemonsetjob_gc.go
  • Line 32: warning: comment on exported function NewDaemonSetJobGarbageCollector should be of the form "NewDaemonSetJobGarbageCollector ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/workflow/v1/doc.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/workflow/v1/fake/fake_workflow_client.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)
  • Line 27: warning: exported type FakeWorkflowV1 should have comment or be unexported (golint)
  • Line 31: warning: exported method FakeWorkflowV1.Workflows should have comment or be unexported (golint)

• workflow-controller/pkg/api/common/default.go
  • Line 8: warning: don't use underscores in Go names; func SetDefaults_Job should be SetDefaultsJob (golint)

• workflow-controller/pkg/client/clientset/versioned/clientset.go
  • Line 18: warning: package comment should be of the form "Package versioned ..." (golint)
  • Line 31: warning: exported type Interface should have comment or be unexported (golint)
  • Line 58: warning: comment on exported method Clientset.Cronworkflow should be of the form "Cronworkflow ..." (golint)
  • Line 69: warning: comment on exported method Clientset.Daemonsetjob should be of the form "Daemonsetjob ..." (golint)
  • Line 80: warning: comment on exported method Clientset.Workflow should be of the form "Workflow ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/scheme/doc.go
  • Line 18: warning: package comment should be of the form "Package scheme ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/cronworkflow/v1/cronworkflow_client.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)
  • Line 28: warning: exported type CronworkflowV1Interface should have comment or be unexported (golint)
  • Line 38: warning: exported method CronworkflowV1Client.CronWorkflows should have comment or be unexported (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/cronworkflow/v1/generated_expansion.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)
  • Line 21: warning: exported type CronWorkflowExpansion should have comment or be unexported (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/daemonsetjob/v1/generated_expansion.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)
  • Line 21: warning: exported type DaemonSetJobExpansion should have comment or be unexported (golint)

• workflow-controller/pkg/api/workflow/v1/validation.go
  • Line 172: warning: exported function ValidateWorkflowUpdateStatus should have comment or be unexported (golint)
  • Line 178: warning: exported function ValidateWorkflowSpecUpdate should have comment or be unexported (golint)
  • Line 261: warning: exported function ValidateJobTemplateSpec should have comment or be unexported (golint)

• workflow-controller/pkg/api/daemonsetjob/v1/zz_generated.deepcopy.go
  • Line 90: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 142: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• workflow-controller/pkg/client/clientset/versioned/fake/clientset_generated.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)
  • Line 63: warning: exported method Clientset.Discovery should have comment or be unexported (golint)

• workflow-controller/pkg/client/clientset/versioned/fake/register.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/workflow/v1/fake/fake_workflow.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)

• workflow-controller/test/e2e/e2e.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• workflow-controller/pkg/api/workflow/v1/zz_generated.deepcopy.go
  • Line 95: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 147: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• workflow-controller/pkg/client/clientset/versioned/scheme/register.go
  • Line 18: warning: package comment should be of the form "Package scheme ..." (golint)
  • Line 31: warning: exported var Scheme should have comment or be unexported (golint)
  • Line 32: warning: exported var Codecs should have comment or be unexported (golint)
  • Line 33: warning: exported var ParameterCodec should have comment or be unexported (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/cronworkflow/v1/cronworkflow.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/workflow/v1/generated_expansion.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)
  • Line 21: warning: exported type WorkflowExpansion should have comment or be unexported (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/daemonsetjob/v1/fake/doc.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/workflow/v1/fake/doc.go
  • Line 18: warning: package comment should be of the form "Package fake ..." (golint)

• workflow-controller/test/e2e/cronworkflows.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/daemonsetjob/v1/daemonsetjob.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)

• workflow-controller/pkg/client/clientset/versioned/typed/daemonsetjob/v1/doc.go
  • Line 18: warning: package comment should be of the form "Package v1 ..." (golint)

• workflow-controller/pkg/api/workflow/validation/validation.go
  • Line 175: warning: exported function ValidateWorkflowUpdateStatus should have comment or be unexported (golint)
  • Line 181: warning: exported function ValidateWorkflowSpecUpdate should have comment or be unexported (golint)
  • Line 264: warning: exported function ValidateJobTemplateSpec should have comment or be unexported (golint)

• workflow-controller/pkg/api/workflow/v1/register.go
  • Line 12: warning: exported var SchemeBuilder should have comment or be unexported (golint)
  • Line 21: warning: comment on exported const ResourceKind should be of the form "ResourceKind ..." (golint)
  • Line 23: warning: comment on exported const ResourceVersion should be of the form "ResourceVersion ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

• workflow-controller/kubectl-plugin/cmd/workflow/workflow.go
  • Line 111: warning: ineffectual assignment to currentJobName (ineffassign)

• workflow-controller/pkg/controller/daemonsetjob.go
  • Line 299: warning: ineffectual assignment to err (ineffassign)

misspell97%

Misspell Finds commonly misspelled English words

• workflow-controller/kubectl-plugin/utils/utils.go
  • Line 52: warning: "ouput" is a misspelling of "output" (misspell)

• workflow-controller/pkg/api/workflow/v1/types.go
  • Line 66: warning: "identifiy" is a misspelling of "identify" (misspell)

• workflow-controller/pkg/garbagecollector/common.go
  • Line 8: warning: "Garabge" is a misspelling of "Garbage" (misspell)