gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• drago/drago/structs/connection.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint61%

Golint is a linter for Go source code.

• drago/drago/acl_token.go
  • Line 12: warning: exported const ACLTokenList should have comment (or a comment on this block) or be unexported (golint)

• drago/command/agent.go
  • Line 51: warning: exported method AgentCommand.FlagSet should have comment or be unexported (golint)

• drago/command/interface_list.go
  • Line 28: warning: exported method InterfaceListCommand.FlagSet should have comment or be unexported (golint)

• drago/command/network_delete.go
  • Line 23: warning: exported method NetworkDeleteCommand.FlagSet should have comment or be unexported (golint)

• drago/drago/structs/structs.go
  • Line 10: warning: exported type Filters should have comment or be unexported (golint)
  • Line 12: warning: exported method Filters.Get should have comment or be unexported (golint)
  • Line 19: warning: exported method Filters.Add should have comment or be unexported (golint)

• drago/pkg/cli/command.go
  • Line 6: warning: exported const CommandReturnCodeHelp should have comment (or a comment on this block) or be unexported (golint)

• drago/pkg/cli/config.go
  • Line 8: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
  • Line 35: warning: comment on exported function DefaultConfig should be of the form "DefaultConfig ..." (golint)
  • Line 47: warning: exported method Config.Merge should have comment or be unexported (golint)

• drago/command/connection_list.go
  • Line 26: warning: exported method ConnectionListCommand.FlagSet should have comment or be unexported (golint)

• drago/pkg/uuid/uuid.go
  • Line 8: warning: exported function Generate should have comment or be unexported (golint)

• drago/pkg/cli/ui.go
  • Line 35: warning: comment on exported type SimpleUI should be of the form "SimpleUI ..." (with optional leading article) (golint)
  • Line 50: warning: exported method SimpleUI.Info should have comment or be unexported (golint)
  • Line 54: warning: exported method SimpleUI.Output should have comment or be unexported (golint)
  • Line 58: warning: exported method SimpleUI.Warn should have comment or be unexported (golint)

• drago/command/node_status.go
  • Line 27: warning: exported method NodeStatusCommand.FlagSet should have comment or be unexported (golint)

• drago/pkg/concurrent/map.go
  • Line 14: warning: exported function NewMap should have comment or be unexported (golint)
  • Line 20: warning: comment on exported type MapItem should be of the form "MapItem ..." (with optional leading article) (golint)
  • Line 26: warning: comment on exported method Map.Set should be of the form "Set ..." (golint)
  • Line 34: warning: comment on exported method Map.Get should be of the form "Get ..." (golint)
  • Line 42: warning: comment on exported method Map.Len should be of the form "Len ..." (golint)
  • Line 49: warning: comment on exported method Map.Delete should be of the form "Delete ..." (golint)
  • Line 56: warning: comment on exported method Map.Iter should be of the form "Iter ..." (golint)

• drago/drago/structs/node.go
  • Line 9: warning: exported const NodeStatusInit should have comment (or a comment on this block) or be unexported (golint)

• drago/api/error.go
  • Line 5: warning: exported type CodedError should have comment or be unexported (golint)

• drago/client/client.go
  • Line 91: warning: exported method Client.Node should have comment or be unexported (golint)
  • Line 466: warning: exported method Client.RPC should have comment or be unexported (golint)

• drago/pkg/cli/command_mock.go
  • Line 16: warning: exported method MockCommand.Help should have comment or be unexported (golint)
  • Line 20: warning: exported method MockCommand.Run should have comment or be unexported (golint)
  • Line 26: warning: exported method MockCommand.Synopsis should have comment or be unexported (golint)

• drago/agent/adapter/http/agent.go
  • Line 10: warning: exported type AgentAdapter should have comment or be unexported (golint)

• drago/command/acl_token_info.go
  • Line 26: warning: exported method ACLTokenInfoCommand.FlagSet should have comment or be unexported (golint)

• drago/command/interface_update.go
  • Line 23: warning: exported method InterfaceUpdateCommand.FlagSet should have comment or be unexported (golint)

• drago/command/network_info.go
  • Line 27: warning: exported method NetworkInfoCommand.FlagSet should have comment or be unexported (golint)

• drago/pkg/log/logrus/logrus.go
  • Line 11: warning: exported const Info should have comment (or a comment on this block) or be unexported (golint)

• drago/drago/connection.go
  • Line 16: warning: exported const ConnectionList should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported type ConnectionService should have comment or be unexported (golint)

• drago/command/acl_policy_upsert.go
  • Line 23: warning: exported method ACLPolicyUpsertCommand.FlagSet should have comment or be unexported (golint)

• drago/command/network_create.go
  • Line 24: warning: exported method NetworkCreateCommand.FlagSet should have comment or be unexported (golint)

• drago/drago/state/etcd/etcd.go
  • Line 32: warning: exported type Config should have comment or be unexported (golint)
  • Line 80: warning: comment on exported method StateRepository.Transaction should be of the form "Transaction ..." (golint)

• drago/client/util.go
  • Line 11: warning: exported type Diff should have comment or be unexported (golint)

• drago/command/acl_token_list.go
  • Line 26: warning: exported method ACLTokenListCommand.FlagSet should have comment or be unexported (golint)

• drago/command/acl_token_self.go
  • Line 26: warning: exported method ACLTokenSelfCommand.FlagSet should have comment or be unexported (golint)

• drago/command/node_leave.go
  • Line 22: warning: exported method NodeLeaveCommand.FlagSet should have comment or be unexported (golint)

• drago/agent/conn/conn.go
  • Line 17: warning: exported var ErrNoServers should have comment or be unexported (golint)
  • Line 20: warning: exported type RPCConnection should have comment or be unexported (golint)
  • Line 31: warning: exported function NewRPCConnection should have comment or be unexported (golint)

• drago/pkg/log/zap/zap.go
  • Line 12: warning: exported const Info should have comment (or a comment on this block) or be unexported (golint)

• drago/drago/node.go
  • Line 19: warning: exported const NodeList should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported type NodeService should have comment or be unexported (golint)
  • Line 105: warning: exported method NodeService.Register should have comment or be unexported (golint)
  • Line 157: warning: exported method NodeService.UpdateStatus should have comment or be unexported (golint)

• drago/version/version.go
  • Line 9: warning: comment on exported var GitCommit should be of the form "GitCommit ..." (golint)
  • Line 11: warning: exported var GitDescribe should have comment or be unexported (golint)
  • Line 13: warning: comment on exported var Version should be of the form "Version ..." (golint)
  • Line 16: warning: comment on exported var VersionPrerelease should be of the form "VersionPrerelease ..." (golint)
  • Line 53: warning: comment on exported method VersionInfo.VersionNumber should be of the form "VersionNumber ..." (golint)

• drago/client/state/inmem/inmem.go
  • Line 10: warning: exported type Repository should have comment or be unexported (golint)
  • Line 19: warning: exported function NewRepository should have comment or be unexported (golint)
  • Line 26: warning: exported method Repository.Name should have comment or be unexported (golint)
  • Line 30: warning: exported method Repository.Interfaces should have comment or be unexported (golint)
  • Line 42: warning: exported method Repository.UpsertInterface should have comment or be unexported (golint)
  • Line 49: warning: exported method Repository.DeleteInterfaces should have comment or be unexported (golint)

• drago/drago/structs/acl_token.go
  • Line 27: warning: exported method ACLToken.Validate should have comment or be unexported (golint)

• drago/drago/acl_policy.go
  • Line 11: warning: exported const ACLPolicyList should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: exported method ACLService.GetPolicy should have comment or be unexported (golint)
  • Line 41: warning: exported method ACLService.UpsertPolicy should have comment or be unexported (golint)
  • Line 78: warning: exported method ACLService.DeletePolicies should have comment or be unexported (golint)
  • Line 99: warning: exported method ACLService.ListPolicies should have comment or be unexported (golint)

• drago/command/agent_info.go
  • Line 25: warning: exported method AgentInfoCommand.FlagSet should have comment or be unexported (golint)

• drago/pkg/log/log.go
  • Line 6: warning: comment on exported type LoggerOptions should be of the form "LoggerOptions ..." (with optional leading article) (golint)

• drago/client/nic/nic.go
  • Line 17: warning: exported type PrivateKeyStore should have comment or be unexported (golint)
  • Line 23: warning: exported type PrivateKey should have comment or be unexported (golint)

• drago/plugin/plugin.go
  • Line 3: warning: exported type Plugin should have comment or be unexported (golint)

• drago/api/acl_policy.go
  • Line 24: warning: comment on exported method ACLPolicies.Upsert should be of the form "Upsert ..." (golint)

• drago/command/acl_token_delete.go
  • Line 19: warning: exported method ACLTokenDeleteCommand.FlagSet should have comment or be unexported (golint)

• drago/command/network_list.go
  • Line 26: warning: exported method NetworkListCommand.FlagSet should have comment or be unexported (golint)

• drago/command/node_info.go
  • Line 27: warning: exported method NodeInfoCommand.FlagSet should have comment or be unexported (golint)

• drago/drago/interface.go
  • Line 15: warning: exported const InterfaceList should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported type InterfaceService should have comment or be unexported (golint)

• drago/command/acl_token_create.go
  • Line 28: warning: exported method ACLTokenCreateCommand.FlagSet should have comment or be unexported (golint)

• drago/client/state/boltdb/boltdb.go
  • Line 110: warning: exported method StateRepository.KeyByID should have comment or be unexported (golint)
  • Line 128: warning: exported method StateRepository.UpsertKey should have comment or be unexported (golint)
  • Line 136: warning: exported method StateRepository.DeleteKey should have comment or be unexported (golint)

• drago/drago/structs/acl_policy.go
  • Line 16: warning: exported method ACLPolicy.Validate should have comment or be unexported (golint)
  • Line 20: warning: exported method ACLPolicy.Merge should have comment or be unexported (golint)

• drago/pkg/validator/validator.go
  • Line 16: warning: exported type Validator should have comment or be unexported (golint)
  • Line 20: warning: exported function New should have comment or be unexported (golint)
  • Line 29: warning: exported method Validator.Validate should have comment or be unexported (golint)

• drago/drago/state/etcd/node.go
  • Line 58: warning: comment on exported method StateRepository.NodeBySecretID should be of the form "NodeBySecretID ..." (golint)

• drago/drago/network.go
  • Line 15: warning: exported const NetworkList should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported type NetworkService should have comment or be unexported (golint)

• drago/pkg/rpc/config.go
  • Line 9: warning: exported type ServerConfig should have comment or be unexported (golint)
  • Line 20: warning: exported function DefaultConfig should have comment or be unexported (golint)
  • Line 27: warning: exported method ServerConfig.Merge should have comment or be unexported (golint)
  • Line 41: warning: exported type ClientConfig should have comment or be unexported (golint)
  • Line 52: warning: exported function DefaultClientConfig should have comment or be unexported (golint)
  • Line 59: warning: exported method ClientConfig.Merge should have comment or be unexported (golint)

• drago/command/acl_policy_list.go
  • Line 26: warning: exported method ACLPolicyListCommand.FlagSet should have comment or be unexported (golint)

• drago/command/node_join.go
  • Line 22: warning: exported method NodeJoinCommand.FlagSet should have comment or be unexported (golint)

• drago/command/node_list.go
  • Line 28: warning: exported method NodeListCommand.FlagSet should have comment or be unexported (golint)

• drago/pkg/log/simple/simple.go
  • Line 10: warning: exported const Info should have comment (or a comment on this block) or be unexported (golint)

• drago/drago/structs/errors.go
  • Line 59: warning: exported function NewInternalError should have comment or be unexported (golint)
  • Line 63: warning: exported function NewInvalidInputError should have comment or be unexported (golint)

• drago/drago/structs/interface.go
  • Line 7: warning: exported type Interface should have comment or be unexported (golint)
  • Line 174: warning: exported type Peer should have comment or be unexported (golint)

• drago/command/acl_policy_info.go
  • Line 26: warning: exported method ACLPolicyInfoCommand.FlagSet should have comment or be unexported (golint)

• drago/pkg/util/util.go
  • Line 3: warning: exported function StrToPtr should have comment or be unexported (golint)
  • Line 7: warning: exported function BoolToPtr should have comment or be unexported (golint)
  • Line 11: warning: exported function IntToPtr should have comment or be unexported (golint)
  • Line 15: warning: exported function Uint16ToPtr should have comment or be unexported (golint)

• drago/agent/adapter/http/errors.go
  • Line 8: warning: exported const ErrNotFound should have comment (or a comment on this block) or be unexported (golint)

• drago/command/acl_policy_delete.go
  • Line 21: warning: exported method ACLPolicyDeleteCommand.FlagSet should have comment or be unexported (golint)

• drago/drago/structs/connection.go
  • Line 36: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)

• drago/api/acl.go
  • Line 18: warning: comment on exported method Client.ACL should be of the form "ACL ..." (golint)
  • Line 23: warning: comment on exported method ACL.Bootstrap should be of the form "Bootstrap ..." (golint)

• drago/agent/adapter/http/spa.go
  • Line 32: warning: exported method SinglePageApplicationHandler.Handle should have comment or be unexported (golint)

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• drago/agent/config.go
  • Line 67: warning: cyclomatic complexity 25 of function (*Config).Merge() is high (> 15) (gocyclo)

• drago/pkg/acl/acl_test.go
  • Line 166: warning: cyclomatic complexity 19 of function TestACL() is high (> 15) (gocyclo)

• drago/pkg/acl/resolver.go
  • Line 64: warning: cyclomatic complexity 17 of function (*Resolver).ResolveSecret() is high (> 15) (gocyclo)

• drago/pkg/cli/cli.go
  • Line 143: warning: cyclomatic complexity 22 of function (*CLI).parseArgs() is high (> 15) (gocyclo)

• drago/drago/connection.go
  • Line 112: warning: cyclomatic complexity 25 of function (*ConnectionService).UpsertConnection() is high (> 15) (gocyclo)
  • Line 61: warning: cyclomatic complexity 16 of function (*ConnectionService).ListConnections() is high (> 15) (gocyclo)
  • Line 233: warning: cyclomatic complexity 16 of function (*ConnectionService).DeleteConnection() is high (> 15) (gocyclo)

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

• drago/drago/test/acl_test.go
  • Line 19: warning: ineffectual assignment to ctx (ineffassign)
  • Line 165: warning: ineffectual assignment to p (ineffassign)

• drago/pkg/http/http.go
  • Line 86: warning: ineffectual assignment to code (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell0%

Misspell Finds commonly misspelled English words

An error occurred while running this test (exit status 2)