Go Report Card

Preparing report...

Report for github.com/seatgeek/resec

A+    Excellent!    Found 12 issues across 17 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint29%

Golint is a linter for Go source code.

    • resec/resec/reconciler/reconciler.go
    • Line 20: warning: exported const ResultConsulNotHealthy should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: comment on exported type Reconciler should be of the form "Reconciler ..." (with optional leading article) (golint)
    • Line 438: warning: comment on exported method Reconciler.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • resec/resec/state/redis.go
    • Line 16: warning: comment on exported method Redis.IsRedisMaster should be of the form "IsRedisMaster ..." (golint)
    • Line 22: warning: exported method Redis.IsUnhealthy should have comment or be unexported (golint)
    • Line 26: warning: exported type RedisStatus should have comment or be unexported (golint)
    • Line 36: warning: comment on exported method RedisStatus.Changed should be of the form "Changed ..." (golint)
    • resec/resec/redis/commands.go
    • Line 6: warning: exported const StartCommand should have comment (or a comment on this block) or be unexported (golint)
    • Line 12: warning: exported type CommandName should have comment or be unexported (golint)
    • Line 14: warning: exported type Command should have comment or be unexported (golint)
    • Line 19: warning: exported method Command.Name should have comment or be unexported (golint)
    • Line 27: warning: exported function NewCommand should have comment or be unexported (golint)
    • resec/resec/consul/manager.go
    • Line 383: warning: exported method Manager.CommandRunner should have comment or be unexported (golint)
    • Line 422: warning: exported method Manager.GetStateReader should have comment or be unexported (golint)
    • Line 426: warning: exported method Manager.GetCommandWriter should have comment or be unexported (golint)
    • resec/resec/state/consul.go
    • Line 18: warning: exported method Consul.IsUnhealhy should have comment or be unexported (golint)
    • Line 22: warning: comment on exported method Consul.IsMaster should be of the form "IsMaster ..." (golint)
    • Line 28: warning: comment on exported method Consul.IsSlave should be of the form "IsSlave ..." (golint)
    • resec/main.go
    • Line 15: warning: exported var Version should have comment or be unexported (golint)
    • resec/resec/redis/manager.go
    • Line 62: warning: exported method Manager.CommandRunner should have comment or be unexported (golint)
    • Line 163: warning: exported method Manager.Config should have comment or be unexported (golint)
    • Line 167: warning: exported method Manager.StateChReader should have comment or be unexported (golint)
    • Line 171: warning: exported method Manager.CommandChWriter should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!