Preparing report...

Report for github.com/secrethub/secrethub-cli

A+    Excellent!    Found 37 issues across 207 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint87%

Golint is a linter for Go source code.

    • secrethub-cli/internals/secrethub/migrate_config_k8s.go
    • Line 13: warning: exported method MigrateConfigK8sCommand.Run should have comment or be unexported (golint)
    • Line 80: warning: exported type MigrateConfigK8sCommand should have comment or be unexported (golint)
    • Line 88: warning: exported function NewMigrateConfigK8sCommand should have comment or be unexported (golint)
    • Line 94: warning: exported method MigrateConfigK8sCommand.Register should have comment or be unexported (golint)
    • secrethub-cli/internals/cli/ui/fakeui/testing.go
    • Line 66: warning: comment on exported method FakeIO.Input should be of the form "Input ..." (golint)
    • Line 71: warning: comment on exported method FakeIO.Output should be of the form "Output ..." (golint)
    • Line 76: warning: exported method FakeIO.Stdin should have comment or be unexported (golint)
    • Line 80: warning: exported method FakeIO.Stdout should have comment or be unexported (golint)
    • Line 84: warning: exported method FakeIO.ReadStdout should have comment or be unexported (golint)
    • Line 93: warning: exported method FakeIO.IsInputPiped should have comment or be unexported (golint)
    • Line 97: warning: exported method FakeIO.IsOutputPiped should have comment or be unexported (golint)
    • Line 101: warning: exported method FakeIO.ReadSecret should have comment or be unexported (golint)
    • secrethub-cli/internals/cli/app.go
    • Line 251: warning: exported method CommandClause.HelpLong should have comment or be unexported (golint)
    • Line 255: warning: exported method CommandClause.Alias should have comment or be unexported (golint)
    • Line 299: warning: exported method CommandClause.Flags should have comment or be unexported (golint)
    • Line 330: warning: exported method CommandClause.BindAction should have comment or be unexported (golint)
    • secrethub-cli/internals/secrethub/migrate_config.go
    • Line 8: warning: exported type MigrateConfigCommand should have comment or be unexported (golint)
    • Line 12: warning: exported function NewMigrateConfigCommand should have comment or be unexported (golint)
    • Line 18: warning: exported method MigrateConfigCommand.Register should have comment or be unexported (golint)
    • secrethub-cli/internals/secrethub/config_upgrade.go
    • Line 10: warning: exported type ConfigUpgradeCommand should have comment or be unexported (golint)
    • Line 12: warning: exported function NewConfigUpgradeCommand should have comment or be unexported (golint)
    • Line 16: warning: exported method ConfigUpgradeCommand.Register should have comment or be unexported (golint)
    • Line 22: warning: exported method ConfigUpgradeCommand.Run should have comment or be unexported (golint)
    • secrethub-cli/internals/secrethub/migrate.go
    • Line 165: warning: exported method MigratePlanCommand.Run should have comment or be unexported (golint)
    • Line 396: warning: exported method MigrateApplyCommand.Run should have comment or be unexported (golint)
    • Line 509: warning: exported type MigrateCommand should have comment or be unexported (golint)
    • Line 514: warning: exported function NewMigrateCommand should have comment or be unexported (golint)
    • Line 521: warning: exported method MigrateCommand.Register should have comment or be unexported (golint)
    • Line 531: warning: exported type MigratePlanCommand should have comment or be unexported (golint)
    • Line 540: warning: exported function NewMigratePlanCommand should have comment or be unexported (golint)
    • Line 549: warning: exported method MigratePlanCommand.Register should have comment or be unexported (golint)
    • Line 564: warning: exported type MigrateApplyCommand should have comment or be unexported (golint)
    • Line 572: warning: exported function NewMigrateApplyCommand should have comment or be unexported (golint)
    • Line 579: warning: exported method MigrateApplyCommand.Register should have comment or be unexported (golint)
    • secrethub-cli/internals/secrethub/service_gcp_link.go
    • Line 35: warning: exported method ServiceGCPLinkCommand.Run should have comment or be unexported (golint)
    • Line 53: warning: exported method ServiceGCPLinkCommand.Register should have comment or be unexported (golint)
    • Line 86: warning: exported function NewServiceGCPListLinksCommand should have comment or be unexported (golint)
    • Line 93: warning: exported method ServiceGCPListLinksCommand.Run should have comment or be unexported (golint)
    • Line 126: warning: exported method ServiceGCPListLinksCommand.Register should have comment or be unexported (golint)
    • Line 142: warning: exported function NewServiceGCPDeleteLinkCommand should have comment or be unexported (golint)
    • Line 149: warning: exported method ServiceGCPDeleteLinkCommand.Register should have comment or be unexported (golint)
    • Line 160: warning: exported method ServiceGCPDeleteLinkCommand.Run should have comment or be unexported (golint)
    • secrethub-cli/internals/onepassword/onepassword.go
    • Line 17: warning: exported function CreateVault should have comment or be unexported (golint)
    • Line 25: warning: exported function CreateItem should have comment or be unexported (golint)
    • Line 37: warning: exported function NewItemTemplate should have comment or be unexported (golint)
    • Line 48: warning: exported type ItemTemplate should have comment or be unexported (golint)
    • Line 58: warning: exported method ItemTemplate.AddField should have comment or be unexported (golint)
    • Line 93: warning: exported function EnsureSignedIn should have comment or be unexported (golint)
    • Line 143: warning: exported function GetSignInAddress should have comment or be unexported (golint)
    • Line 175: warning: exported function ExistsVault should have comment or be unexported (golint)
    • Line 200: warning: exported function ExistsItemInVault should have comment or be unexported (golint)
    • secrethub-cli/internals/cli/ui/ask.go
    • Line 266: warning: exported type Option should have comment or be unexported (golint)
    • Line 275: warning: exported function ChooseDynamicOptionsValidate should have comment or be unexported (golint)
    • Line 297: warning: exported function ChooseDynamicOptions should have comment or be unexported (golint)
    • secrethub-cli/internals/cli/argument.go
    • Line 7: warning: exported type Argument should have comment or be unexported (golint)
    • Line 16: warning: exported type ArgValue should have comment or be unexported (golint)
    • Line 20: warning: exported function ArgumentRegister should have comment or be unexported (golint)
    • Line 30: warning: exported function ArgumentArrRegister should have comment or be unexported (golint)
    • Line 40: warning: exported type StringValue should have comment or be unexported (golint)
    • Line 44: warning: exported method StringValue.Set should have comment or be unexported (golint)
    • Line 49: warning: exported type StringListValue should have comment or be unexported (golint)
    • Line 51: warning: exported method StringListValue.Set should have comment or be unexported (golint)
    • Line 56: warning: exported type URLValue should have comment or be unexported (golint)
    • Line 60: warning: exported method URLValue.Set should have comment or be unexported (golint)
    • Line 73: warning: exported type ByteValue should have comment or be unexported (golint)
    • Line 75: warning: exported method ByteValue.Set should have comment or be unexported (golint)
    • secrethub-cli/internals/cli/flag.go
    • Line 13: warning: exported type FlagSet should have comment or be unexported (golint)
    • Line 18: warning: exported method FlagSet.Bool should have comment or be unexported (golint)
    • Line 23: warning: exported method FlagSet.BoolP should have comment or be unexported (golint)
    • Line 28: warning: exported method FlagSet.BoolVarP should have comment or be unexported (golint)
    • Line 33: warning: exported method FlagSet.IntVarP should have comment or be unexported (golint)
    • Line 39: warning: exported method FlagSet.StringVarP should have comment or be unexported (golint)
    • Line 45: warning: exported method FlagSet.DurationVarP should have comment or be unexported (golint)
    • Line 51: warning: exported method FlagSet.BoolVar should have comment or be unexported (golint)
    • Line 56: warning: exported method FlagSet.IntVar should have comment or be unexported (golint)
    • Line 62: warning: exported method FlagSet.StringVar should have comment or be unexported (golint)
    • Line 68: warning: exported method FlagSet.DurationVar should have comment or be unexported (golint)
    • Line 74: warning: exported method FlagSet.VarP should have comment or be unexported (golint)
    • Line 79: warning: exported method FlagSet.Var should have comment or be unexported (golint)
    • Line 85: warning: exported method FlagSet.VarPF should have comment or be unexported (golint)
    • Line 113: warning: exported method Flag.HasEnvarValue should have comment or be unexported (golint)
    • Line 117: warning: exported method Flag.NoEnvar should have comment or be unexported (golint)
    • Line 125: warning: exported method Flag.Hidden should have comment or be unexported (golint)
    • Line 130: warning: exported method Flag.Changed should have comment or be unexported (golint)

gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!