Report for github.com/sendgrid/go-solr
A Great! Found 12 issues across 19 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint36%
Golint is a linter for Go source code.
-
-
go-solr/roundRobinRouter.go
- Line 8: warning: exported type Router should have comment or be unexported (golint)
- Line 40: warning: exported function NewRoundRobinRouter should have comment or be unexported (golint)
-
-
go-solr/schemas.go
- Line 13: warning: exported type SolrZK should have comment or be unexported (golint)
- Line 23: warning: exported type SolrLocator should have comment or be unexported (golint)
- Line 31: warning: exported type SolrHTTP should have comment or be unexported (golint)
- Line 37: warning: exported type Logger should have comment or be unexported (golint)
- Line 44: warning: exported type SolrLogger should have comment or be unexported (golint)
- Line 51: warning: exported method SolrLogger.Info should have comment or be unexported (golint)
- Line 54: warning: exported method SolrLogger.Debug should have comment or be unexported (golint)
- Line 57: warning: exported method SolrLogger.Printf should have comment or be unexported (golint)
- Line 61: warning: exported type HTTPer should have comment or be unexported (golint)
- Line 65: warning: exported type CompositeKey should have comment or be unexported (golint)
- Line 71: warning: exported type HashRange should have comment or be unexported (golint)
- Line 76: warning: exported function NewCompositeKey should have comment or be unexported (golint)
- Line 105: warning: exported type ClusterProps should have comment or be unexported (golint)
-
-
go-solr/solrHttp.go
- Line 38: warning: exported function NewSolrHTTP should have comment or be unexported (golint)
- Line 231: warning: exported function DeleteStreamBody should have comment or be unexported (golint)
- Line 237: warning: exported function Query should have comment or be unexported (golint)
- Line 243: warning: exported function ClusterStateVersion should have comment or be unexported (golint)
- Line 249: warning: comment on exported function FilterQuery should be of the form "FilterQuery ..." (golint)
- Line 256: warning: exported function Rows should have comment or be unexported (golint)
- Line 262: warning: exported function Route should have comment or be unexported (golint)
- Line 270: warning: exported function PreferLocalShards should have comment or be unexported (golint)
- Line 278: warning: exported function Start should have comment or be unexported (golint)
- Line 284: warning: exported function Sort should have comment or be unexported (golint)
- Line 290: warning: exported function Commit should have comment or be unexported (golint)
- Line 300: warning: exported function Cursor should have comment or be unexported (golint)
- Line 306: warning: exported function UrlVals should have comment or be unexported (golint)
- Line 378: warning: comment on exported function Cert should be of the form "Cert ..." (golint)
- Line 385: warning: exported function User should have comment or be unexported (golint)
- Line 391: warning: exported function Password should have comment or be unexported (golint)
- Line 397: warning: exported function QueryRouter should have comment or be unexported (golint)
- Line 403: warning: exported function MinRF should have comment or be unexported (golint)
- Line 409: warning: exported function WriteTimeout should have comment or be unexported (golint)
- Line 415: warning: exported function ReadTimeout should have comment or be unexported (golint)
- Line 421: warning: exported function ConnectionTimeout should have comment or be unexported (golint)
- Line 427: warning: exported function InsecureSkipVerify should have comment or be unexported (golint)
- Line 433: warning: exported function HttpLogger should have comment or be unexported (golint)
-
-
go-solr/cmd/solrRunner.go
- Line 11: warning: should not use dot imports (golint)
-
-
go-solr/adaptiveRouter.go
- Line 110: warning: exported function NewAdaptiveRouter should have comment or be unexported (golint)
-
-
go-solr/clusterState.go
- Line 3: warning: exported type ClusterState should have comment or be unexported (golint)
- Line 9: warning: exported type Collection should have comment or be unexported (golint)
- Line 14: warning: exported type Shard should have comment or be unexported (golint)
- Line 21: warning: exported type Replica should have comment or be unexported (golint)
- Line 29: warning: exported type SolrHealthcheckResponse should have comment or be unexported (golint)
-
-
go-solr/errors.go
- Line 7: warning: exported var ErrNotFound should have comment or be unexported (golint)
- Line 9: warning: exported type SolrError should have comment or be unexported (golint)
- Line 17: warning: exported function NewSolrError should have comment or be unexported (golint)
- Line 21: warning: exported function NewSolrRFError should have comment or be unexported (golint)
- Line 25: warning: exported type SolrMinRFError should have comment or be unexported (golint)
- Line 30: warning: exported type SolrInternalError should have comment or be unexported (golint)
- Line 34: warning: exported function NewSolrInternalError should have comment or be unexported (golint)
- Line 38: warning: exported type SolrLeaderError should have comment or be unexported (golint)
- Line 42: warning: exported function NewSolrLeaderError should have comment or be unexported (golint)
- Line 46: warning: exported type SolrBatchError should have comment or be unexported (golint)
- Line 50: warning: exported function NewSolrBatchError should have comment or be unexported (golint)
- Line 54: warning: exported type SolrParseError should have comment or be unexported (golint)
- Line 58: warning: exported function NewSolrParseError should have comment or be unexported (golint)
- Line 62: warning: exported type SolrMapParseError should have comment or be unexported (golint)
- Line 72: warning: exported function NewSolrMapParseError should have comment or be unexported (golint)
- Line 76: warning: exported type NotFoundError should have comment or be unexported (golint)
- Line 84: warning: exported function NewNotFoundError should have comment or be unexported (golint)
-
-
go-solr/hash.go
- Line 9: warning: exported function Hash should have comment or be unexported (golint)
- Line 24: warning: exported function ConvertToHashRange should have comment or be unexported (golint)
-
-
go-solr/solrResponse.go
- Line 3: warning: exported type SolrResponse should have comment or be unexported (golint)
- Line 16: warning: exported type Response should have comment or be unexported (golint)
- Line 22: warning: exported function GetDocIdFromDoc should have comment or be unexported (golint)
- Line 29: warning: exported function GetVersionFromDoc should have comment or be unexported (golint)
- Line 42: warning: exported type Adds should have comment or be unexported (golint)
- Line 44: warning: exported type UpdateResponse should have comment or be unexported (golint)
- Line 58: warning: exported type DeleteRequest should have comment or be unexported (golint)
-
-
go-solr/solrZk.go
- Line 24: warning: exported function NewSolrZK should have comment or be unexported (golint)
- Line 45: warning: exported function SleepTimeMS should have comment or be unexported (golint)
- Line 119: warning: exported function SolrZKLogger should have comment or be unexported (golint)
-
-
go-solr/zookeeper.go
- Line 22: warning: exported type Zookeeper should have comment or be unexported (golint)
- Line 37: warning: exported function NewZookeeper should have comment or be unexported (golint)
-
-
go-solr/solrHttpRetry.go
- Line 10: warning: exported type SolrHttpRetrier should have comment or be unexported (golint)
- Line 18: warning: exported function NewSolrHttpRetrier should have comment or be unexported (golint)
- Line 23: warning: exported method SolrHttpRetrier.Select should have comment or be unexported (golint)
- Line 50: warning: exported method SolrHttpRetrier.Update should have comment or be unexported (golint)
- Line 81: warning: exported method SolrHttpRetrier.Logger should have comment or be unexported (golint)
gocyclo0%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
An error occurred while running this test (exit status 2)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!