Report for github.com/sequix/sup
A Great! Found 9 issues across 12 files
gofmt91%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
sup/pkg/process/server.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint25%
Golint is a linter for Go source code.
-
-
sup/pkg/log/log.go
- Line 11: warning: exported function Info should have comment or be unexported (golint)
- Line 15: warning: exported function Warn should have comment or be unexported (golint)
- Line 19: warning: exported function Error should have comment or be unexported (golint)
- Line 23: warning: exported function Fatal should have comment or be unexported (golint)
- Line 28: warning: exported function ErrorFunc should have comment or be unexported (golint)
-
-
sup/pkg/config/types.go
- Line 3: warning: exported type Config should have comment or be unexported (golint)
- Line 8: warning: exported type Sup should have comment or be unexported (golint)
- Line 12: warning: exported type Program should have comment or be unexported (golint)
- Line 17: warning: exported type Process should have comment or be unexported (golint)
- Line 27: warning: comment on exported type ProcessRestartStrategy should be of the form "ProcessRestartStrategy ..." (with optional leading article) (golint)
- Line 31: warning: exported const RestartStrategyAlways should have comment (or a comment on this block) or be unexported (golint)
- Line 36: warning: exported type Log should have comment or be unexported (golint)
-
-
sup/pkg/util/run.go
- Line 7: warning: exported type BroadcastCh should have comment or be unexported (golint)
- Line 9: warning: exported function NewBroadcastCh should have comment or be unexported (golint)
- Line 10: warning: exported method BroadcastCh.Broadcast should have comment or be unexported (golint)
- Line 11: warning: exported method BroadcastCh.Wait should have comment or be unexported (golint)
- Line 13: warning: exported type Runner should have comment or be unexported (golint)
- Line 18: warning: exported method Runner.Stop should have comment or be unexported (golint)
- Line 19: warning: exported method Runner.Wait should have comment or be unexported (golint)
- Line 20: warning: exported method Runner.StopAndWait should have comment or be unexported (golint)
- Line 22: warning: exported type RunFunc should have comment or be unexported (golint)
- Line 24: warning: exported function Run should have comment or be unexported (golint)
-
-
sup/pkg/process/controller.go
- Line 22: warning: exported type Controller should have comment or be unexported (golint)
- Line 43: warning: exported method Controller.Start should have comment or be unexported (golint)
- Line 53: warning: exported method Controller.StartWait should have comment or be unexported (golint)
- Line 61: warning: exported method Controller.Stop should have comment or be unexported (golint)
- Line 71: warning: exported method Controller.StopWait should have comment or be unexported (golint)
- Line 79: warning: exported method Controller.Restart should have comment or be unexported (golint)
- Line 89: warning: exported method Controller.RestartWait should have comment or be unexported (golint)
- Line 97: warning: exported method Controller.Reload should have comment or be unexported (golint)
- Line 105: warning: exported method Controller.Kill should have comment or be unexported (golint)
- Line 113: warning: exported method Controller.Status should have comment or be unexported (golint)
- Line 122: warning: exported method Controller.SupPid should have comment or be unexported (golint)
-
-
sup/pkg/process/server.go
- Line 25: warning: exported function InitServer should have comment or be unexported (golint)
- Line 95: warning: exported function Serve should have comment or be unexported (golint)
-
-
sup/pkg/process/types.go
- Line 3: warning: exported type Request should have comment or be unexported (golint)
- Line 6: warning: exported type Response should have comment or be unexported (golint)
- Line 12: warning: exported const ActionStart should have comment (or a comment on this block) or be unexported (golint)
-
-
sup/pkg/config/config.go
- Line 18: warning: exported var G should have comment or be unexported (golint)
- Line 21: warning: exported function Init should have comment or be unexported (golint)
-
-
sup/pkg/rotate/rotate.go
- Line 25: warning: exported type FileWriter should have comment or be unexported (golint)
- Line 58: warning: exported type Option should have comment or be unexported (golint)
- Line 60: warning: exported function WithFilename should have comment or be unexported (golint)
- Line 66: warning: exported function WithMaxBytes should have comment or be unexported (golint)
- Line 72: warning: exported function WithMaxBackups should have comment or be unexported (golint)
- Line 78: warning: exported function WithCompress should have comment or be unexported (golint)
- Line 84: warning: exported function WithMergeCompressedBackups should have comment or be unexported (golint)
- Line 90: warning: exported function WithMaxAge should have comment or be unexported (golint)
- Line 96: warning: exported function NewFileWriter should have comment or be unexported (golint)
-
-
sup/pkg/process/client.go
- Line 18: warning: exported function InitClient should have comment or be unexported (golint)
- Line 29: warning: exported function ClientClose should have comment or be unexported (golint)
- Line 35: warning: exported function Start should have comment or be unexported (golint)
- Line 39: warning: exported function StartWait should have comment or be unexported (golint)
- Line 43: warning: exported function Stop should have comment or be unexported (golint)
- Line 47: warning: exported function StopWait should have comment or be unexported (golint)
- Line 51: warning: exported function Restart should have comment or be unexported (golint)
- Line 55: warning: exported function RestartWait should have comment or be unexported (golint)
- Line 59: warning: exported function Reload should have comment or be unexported (golint)
- Line 63: warning: exported function Kill should have comment or be unexported (golint)
- Line 67: warning: exported function Status should have comment or be unexported (golint)
- Line 76: warning: exported function Exit should have comment or be unexported (golint)
- Line 91: warning: exported function ExitWait should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!