gofmt93%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• etcd/functional/agent/server.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/rafthttp/util_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/v3_server.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/store/store.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/alarm/alarms.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/api/v2http/client.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/pkg/netutil/netutil.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/rafthttp/stream_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/api/v3rpc/key.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/auth/auth.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/api/v2http/client_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/pkg/testutil/leak.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/rafthttp/stream.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/proxy/httpproxy/reverse_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/store/store_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/compactor/compactor.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/proxy/httpproxy/reverse.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/cluster_util.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/util.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/store/node.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/mvcc/kvstore.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/api/v3rpc/interceptor.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/discovery/discovery.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/api/etcdhttp/peer_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdctl/ctlv3/command/printer.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/apply.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/config_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/raft.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/auth/store.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/membership/member.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdctl/ctlv3/command/migrate_command.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/integration/cluster_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/compactor/compactor_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdmain/config.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdmain/config_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdmain/etcd.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/api/v2http/http_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/api/v2http/metrics.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/proxy/grpcproxy/cache/store.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/rafthttp/util.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/embed/config.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/cluster_util_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/apply_v2.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/membership/cluster.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/metrics.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/integration/v3_watch_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• etcd/etcdserver/api/capability.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint73%

Golint is a linter for Go source code.

• etcd/pkg/testutil/pauseable_handler.go
  • Line 22: warning: exported type PauseableHandler should have comment or be unexported (golint)
  • Line 47: warning: exported method PauseableHandler.Pause should have comment or be unexported (golint)
  • Line 53: warning: exported method PauseableHandler.Resume should have comment or be unexported (golint)

• etcd/wal/util.go
  • Line 26: warning: error var badWalName should have name of the form errFoo (golint)
  • Line 29: warning: exported function Exist should have comment or be unexported (golint)

• etcd/mvcc/util.go
  • Line 24: warning: exported function UpdateConsistentIndex should have comment or be unexported (golint)
  • Line 44: warning: exported function WriteKV should have comment or be unexported (golint)

• etcd/etcdctl/ctlv2/ctl.go
  • Line 28: warning: exported function Start should have comment or be unexported (golint)

• etcd/embed/etcd.go
  • Line 263: warning: exported method Etcd.Err should have comment or be unexported (golint)

• etcd/mvcc/backend/batch_tx.go
  • Line 28: warning: exported type BatchTx should have comment or be unexported (golint)

• etcd/etcdserver/api/v3lock/lock.go
  • Line 29: warning: exported function NewLockServer should have comment or be unexported (golint)

• etcd/pkg/mock/mockwait/wait_recorder.go
  • Line 22: warning: exported type WaitRecorder should have comment or be unexported (golint)
  • Line 31: warning: exported function NewRecorder should have comment or be unexported (golint)
  • Line 35: warning: exported function NewNop should have comment or be unexported (golint)

• etcd/etcdserver/membership/cluster.go
  • Line 58: warning: exported function NewClusterFromURLsMap should have comment or be unexported (golint)
  • Line 74: warning: exported function NewClusterFromMembers should have comment or be unexported (golint)
  • Line 83: warning: exported function NewCluster should have comment or be unexported (golint)
  • Line 91: warning: exported method RaftCluster.ID should have comment or be unexported (golint)
  • Line 93: warning: exported method RaftCluster.Members should have comment or be unexported (golint)
  • Line 104: warning: exported method RaftCluster.Member should have comment or be unexported (golint)
  • Line 127: warning: exported method RaftCluster.MemberIDs should have comment or be unexported (golint)
  • Line 138: warning: exported method RaftCluster.IsIDRemoved should have comment or be unexported (golint)
  • Line 198: warning: exported method RaftCluster.SetID should have comment or be unexported (golint)
  • Line 200: warning: exported method RaftCluster.SetStore should have comment or be unexported (golint)
  • Line 202: warning: exported method RaftCluster.SetBackend should have comment or be unexported (golint)
  • Line 207: warning: exported method RaftCluster.Recover should have comment or be unexported (golint)
  • Line 320: warning: exported method RaftCluster.UpdateAttributes should have comment or be unexported (golint)
  • Line 340: warning: exported method RaftCluster.UpdateRaftAttributes should have comment or be unexported (golint)
  • Line 355: warning: exported method RaftCluster.Version should have comment or be unexported (golint)
  • Line 364: warning: exported method RaftCluster.SetVersion should have comment or be unexported (golint)
  • Line 388: warning: exported method RaftCluster.IsReadyToAddNewMember should have comment or be unexported (golint)
  • Line 416: warning: exported method RaftCluster.IsReadyToRemoveMember should have comment or be unexported (golint)

• etcd/pkg/fileutil/purge.go
  • Line 25: warning: exported function PurgeFile should have comment or be unexported (golint)
  • Line 29: warning: exported function PurgeFileWithDoneNotify should have comment or be unexported (golint)

• etcd/etcdserver/api/v3election/election.go
  • Line 35: warning: exported function NewElectionServer should have comment or be unexported (golint)

• etcd/raft/progress.go
  • Line 20: warning: exported const ProgressStateProbe should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported type ProgressStateType should have comment or be unexported (golint)

• etcd/client/client_test.go
  • Line 475: warning: error var fakeCancelContextError should have name of the form errFoo (golint)

• etcd/etcdserver/membership/errors.go
  • Line 24: warning: exported var ErrIDRemoved should have comment or be unexported (golint)

• etcd/etcdserver/membership/metrics.go
  • Line 20: warning: exported var ClusterVersionMetrics should have comment or be unexported (golint)

• etcd/etcdserver/auth/auth.go
  • Line 76: warning: exported type Store should have comment or be unexported (golint)
  • Line 94: warning: exported type PasswordStore should have comment or be unexported (golint)
  • Line 107: warning: exported type User should have comment or be unexported (golint)
  • Line 115: warning: exported type Role should have comment or be unexported (golint)
  • Line 122: warning: exported type Permissions should have comment or be unexported (golint)
  • Line 126: warning: exported method Permissions.IsEmpty should have comment or be unexported (golint)
  • Line 130: warning: exported type RWPermission should have comment or be unexported (golint)
  • Line 135: warning: exported type Error should have comment or be unexported (golint)
  • Line 141: warning: exported method Error.HTTPStatus should have comment or be unexported (golint)
  • Line 147: warning: exported function NewStore should have comment or be unexported (golint)
  • Line 159: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 164: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 461: warning: exported method Role.HasKeyAccess should have comment or be unexported (golint)
  • Line 468: warning: exported method Role.HasRecursiveAccess should have comment or be unexported (golint)
  • Line 551: warning: exported method RWPermission.HasAccess should have comment or be unexported (golint)
  • Line 567: warning: exported method RWPermission.HasRecursiveAccess should have comment or be unexported (golint)

• etcd/snap/message.go
  • Line 39: warning: exported function NewMessage should have comment or be unexported (golint)
  • Line 55: warning: exported method Message.CloseWithError should have comment or be unexported (golint)

• etcd/snap/snapshotter.go
  • Line 45: warning: exported var ErrNoSnapshot should have comment or be unexported (golint)
  • Line 56: warning: exported type Snapshotter should have comment or be unexported (golint)
  • Line 60: warning: exported function New should have comment or be unexported (golint)
  • Line 66: warning: exported method Snapshotter.SaveSnap should have comment or be unexported (golint)
  • Line 83: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 99: warning: exported method Snapshotter.Load should have comment or be unexported (golint)

• etcd/pkg/idutil/id.go
  • Line 57: warning: exported function NewGenerator should have comment or be unexported (golint)

• etcd/pkg/ioutil/readcloser.go
  • Line 30: warning: exported var ErrShortRead should have comment or be unexported (golint)

• etcd/rafthttp/stream.go
  • Line 302: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 337: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 403: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 414: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 498: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 505: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 511: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)

• etcd/clientv3/kv.go
  • Line 25: warning: exported type CompactResponse should have comment or be unexported (golint)
  • Line 26: warning: exported type PutResponse should have comment or be unexported (golint)
  • Line 27: warning: exported type GetResponse should have comment or be unexported (golint)
  • Line 28: warning: exported type DeleteResponse should have comment or be unexported (golint)
  • Line 29: warning: exported type TxnResponse should have comment or be unexported (golint)
  • Line 32: warning: exported type KV should have comment or be unexported (golint)
  • Line 66: warning: exported type OpResponse should have comment or be unexported (golint)
  • Line 73: warning: exported method OpResponse.Put should have comment or be unexported (golint)
  • Line 74: warning: exported method OpResponse.Get should have comment or be unexported (golint)
  • Line 75: warning: exported method OpResponse.Del should have comment or be unexported (golint)
  • Line 76: warning: exported method OpResponse.Txn should have comment or be unexported (golint)
  • Line 78: warning: exported method PutResponse.OpResponse should have comment or be unexported (golint)
  • Line 81: warning: exported method GetResponse.OpResponse should have comment or be unexported (golint)
  • Line 84: warning: exported method DeleteResponse.OpResponse should have comment or be unexported (golint)
  • Line 87: warning: exported method TxnResponse.OpResponse should have comment or be unexported (golint)
  • Line 96: warning: exported function NewKV should have comment or be unexported (golint)
  • Line 104: warning: exported function NewKVFromKVClient should have comment or be unexported (golint)

• etcd/clientv3/lease.go
  • Line 30: warning: exported type LeaseRevokeResponse should have comment or be unexported (golint)
  • Line 31: warning: exported type LeaseID should have comment or be unexported (golint)
  • Line 101: warning: exported type Lease should have comment or be unexported (golint)
  • Line 162: warning: exported function NewLease should have comment or be unexported (golint)
  • Line 166: warning: exported function NewLeaseFromLeaseClient should have comment or be unexported (golint)
  • Line 287: warning: context.Context should be the first parameter of a function (golint)

• etcd/etcdserver/api/v3rpc/quota.go
  • Line 51: warning: exported function NewQuotaKVServer should have comment or be unexported (golint)
  • Line 84: warning: exported function NewQuotaLeaseServer should have comment or be unexported (golint)

• etcd/pkg/runtime/fds_linux.go
  • Line 23: warning: exported function FDLimit should have comment or be unexported (golint)
  • Line 31: warning: exported function FDUsage should have comment or be unexported (golint)

• etcd/pkg/logutil/merge_logger.go
  • Line 87: warning: exported function NewMergeLogger should have comment or be unexported (golint)
  • Line 96: warning: exported method MergeLogger.MergeInfo should have comment or be unexported (golint)
  • Line 103: warning: exported method MergeLogger.MergeInfof should have comment or be unexported (golint)
  • Line 110: warning: exported method MergeLogger.MergeNotice should have comment or be unexported (golint)
  • Line 117: warning: exported method MergeLogger.MergeNoticef should have comment or be unexported (golint)
  • Line 124: warning: exported method MergeLogger.MergeWarning should have comment or be unexported (golint)
  • Line 131: warning: exported method MergeLogger.MergeWarningf should have comment or be unexported (golint)
  • Line 138: warning: exported method MergeLogger.MergeError should have comment or be unexported (golint)
  • Line 145: warning: exported method MergeLogger.MergeErrorf should have comment or be unexported (golint)

• etcd/store/node.go
  • Line 34: warning: exported var Permanent should have comment or be unexported (golint)

• etcd/store/node_extern.go
  • Line 74: warning: exported method NodeExtern.Clone should have comment or be unexported (golint)
  • Line 102: warning: exported type NodeExterns should have comment or be unexported (golint)

• etcd/etcdctl/ctlv3/command/error.go
  • Line 25: warning: comment on exported const ExitSuccess should be of the form "ExitSuccess ..." (golint)
  • Line 27: warning: exported const ExitError should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported function ExitWithError should have comment or be unexported (golint)

• etcd/clientv3/client.go
  • Line 39: warning: exported var ErrNoAvailableEndpoints should have comment or be unexported (golint)

• etcd/clientv3/watch.go
  • Line 34: warning: exported const EventTypeDelete should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: exported type Event should have comment or be unexported (golint)
  • Line 42: warning: exported type WatchChan should have comment or be unexported (golint)
  • Line 44: warning: exported type Watcher should have comment or be unexported (golint)
  • Line 55: warning: exported type WatchResponse should have comment or be unexported (golint)
  • Line 193: warning: exported function NewWatcher should have comment or be unexported (golint)
  • Line 197: warning: exported function NewWatchFromWatchClient should have comment or be unexported (golint)

• etcd/functional/tester/case_network_delay.go
  • Line 33: warning: don't use underscores in Go names; func inject_DELAY_PEER_PORT_TX_RX should be injectDELAYPEERPORTTXRX (golint)
  • Line 43: warning: don't use underscores in Go names; func recover_DELAY_PEER_PORT_TX_RX should be recoverDELAYPEERPORTTXRX (golint)
  • Line 49: warning: don't use underscores in Go names; func new_Case_DELAY_PEER_PORT_TX_RX_ONE_FOLLOWER should be newCaseDELAYPEERPORTTXRXONEFOLLOWER (golint)
  • Line 67: warning: don't use underscores in Go names; func new_Case_DELAY_PEER_PORT_TX_RX_ONE_FOLLOWER_UNTIL_TRIGGER_SNAPSHOT should be newCaseDELAYPEERPORTTXRXONEFOLLOWERUNTILTRIGGERSNAPSHOT (golint)
  • Line 85: warning: don't use underscores in Go names; func new_Case_DELAY_PEER_PORT_TX_RX_LEADER should be newCaseDELAYPEERPORTTXRXLEADER (golint)
  • Line 103: warning: don't use underscores in Go names; func new_Case_DELAY_PEER_PORT_TX_RX_LEADER_UNTIL_TRIGGER_SNAPSHOT should be newCaseDELAYPEERPORTTXRXLEADERUNTILTRIGGERSNAPSHOT (golint)
  • Line 121: warning: don't use underscores in Go names; func new_Case_DELAY_PEER_PORT_TX_RX_QUORUM should be newCaseDELAYPEERPORTTXRXQUORUM (golint)
  • Line 141: warning: don't use underscores in Go names; func new_Case_DELAY_PEER_PORT_TX_RX_ALL should be newCaseDELAYPEERPORTTXRXALL (golint)

• etcd/etcdctl/ctlv3/command/snapshot_command.go
  • Line 75: warning: exported function NewSnapshotSaveCommand should have comment or be unexported (golint)
  • Line 94: warning: exported function NewSnapshotRestoreCommand should have comment or be unexported (golint)

• etcd/pkg/transport/limit_listen.go
  • Line 27: warning: exported var ErrNotTCP should have comment or be unexported (golint)

• etcd/pkg/fileutil/lock_linux.go
  • Line 58: warning: exported function TryLockFile should have comment or be unexported (golint)
  • Line 79: warning: exported function LockFile should have comment or be unexported (golint)

• etcd/rafthttp/transport.go
  • Line 37: warning: exported type Raft should have comment or be unexported (golint)
  • Line 44: warning: exported type Transporter should have comment or be unexported (golint)
  • Line 129: warning: exported method Transport.Start should have comment or be unexported (golint)
  • Line 146: warning: exported method Transport.Handler should have comment or be unexported (golint)
  • Line 158: warning: exported method Transport.Get should have comment or be unexported (golint)
  • Line 164: warning: exported method Transport.Send should have comment or be unexported (golint)
  • Line 194: warning: exported method Transport.Stop should have comment or be unexported (golint)
  • Line 245: warning: exported method Transport.AddRemote should have comment or be unexported (golint)
  • Line 267: warning: exported method Transport.AddPeer should have comment or be unexported (golint)
  • Line 288: warning: exported method Transport.RemovePeer should have comment or be unexported (golint)
  • Line 294: warning: exported method Transport.RemoveAllPeers should have comment or be unexported (golint)
  • Line 316: warning: exported method Transport.UpdatePeer should have comment or be unexported (golint)
  • Line 336: warning: exported method Transport.ActiveSince should have comment or be unexported (golint)
  • Line 345: warning: exported method Transport.SendSnapshot should have comment or be unexported (golint)
  • Line 362: warning: exported method Transport.Pause should have comment or be unexported (golint)
  • Line 368: warning: exported method Transport.Resume should have comment or be unexported (golint)
  • Line 390: warning: exported function NewNopTransporter should have comment or be unexported (golint)
  • Line 415: warning: exported function NewSnapTransporter should have comment or be unexported (golint)

• etcd/contrib/recipes/barrier.go
  • Line 32: warning: exported function NewBarrier should have comment or be unexported (golint)

• etcd/auth/simple_token_test.go
  • Line 32: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 32: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 51: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 51: warning: should not use basic type string as key in context.WithValue (golint)

• etcd/mvcc/key_index.go
  • Line 26: warning: exported var ErrRevisionNotFound should have comment or be unexported (golint)
  • Line 257: warning: receiver name a should be consistent with previous receiver name ki for keyIndex (golint)
  • Line 261: warning: receiver name a should be consistent with previous receiver name ki for keyIndex (golint)
  • Line 317: warning: receiver name a should be consistent with previous receiver name g for generation (golint)

• etcd/raft/util.go
  • Line 24: warning: exported method StateType.MarshalJSON should have comment or be unexported (golint)
  • Line 49: warning: exported function IsLocalMsg should have comment or be unexported (golint)
  • Line 54: warning: exported function IsResponseMsg should have comment or be unexported (golint)

• etcd/etcdserver/membership/store.go
  • Line 42: warning: exported var StoreMembersPrefix should have comment or be unexported (golint)
  • Line 171: warning: exported function MemberStoreKey should have comment or be unexported (golint)
  • Line 175: warning: exported function StoreClusterVersionKey should have comment or be unexported (golint)
  • Line 179: warning: exported function MemberAttributesStorePath should have comment or be unexported (golint)
  • Line 183: warning: exported function MustParseMemberIDFromKey should have comment or be unexported (golint)
  • Line 191: warning: exported function RemovedMemberStoreKey should have comment or be unexported (golint)

• etcd/functional/tester/case_sigterm.go
  • Line 19: warning: don't use underscores in Go names; func inject_SIGTERM_ETCD should be injectSIGTERMETCD (golint)
  • Line 23: warning: don't use underscores in Go names; func recover_SIGTERM_ETCD should be recoverSIGTERMETCD (golint)
  • Line 27: warning: don't use underscores in Go names; func new_Case_SIGTERM_ONE_FOLLOWER should be newCaseSIGTERMONEFOLLOWER (golint)
  • Line 40: warning: don't use underscores in Go names; func new_Case_SIGTERM_ONE_FOLLOWER_UNTIL_TRIGGER_SNAPSHOT should be newCaseSIGTERMONEFOLLOWERUNTILTRIGGERSNAPSHOT (golint)
  • Line 47: warning: don't use underscores in Go names; func new_Case_SIGTERM_LEADER should be newCaseSIGTERMLEADER (golint)
  • Line 60: warning: don't use underscores in Go names; func new_Case_SIGTERM_LEADER_UNTIL_TRIGGER_SNAPSHOT should be newCaseSIGTERMLEADERUNTILTRIGGERSNAPSHOT (golint)
  • Line 67: warning: don't use underscores in Go names; func new_Case_SIGTERM_QUORUM should be newCaseSIGTERMQUORUM (golint)
  • Line 82: warning: don't use underscores in Go names; func new_Case_SIGTERM_ALL should be newCaseSIGTERMALL (golint)

• etcd/etcdserver/api/v3rpc/auth.go
  • Line 23: warning: exported type AuthServer should have comment or be unexported (golint)
  • Line 27: warning: exported function NewAuthServer should have comment or be unexported (golint)
  • Line 31: warning: exported method AuthServer.AuthEnable should have comment or be unexported (golint)
  • Line 39: warning: exported method AuthServer.AuthDisable should have comment or be unexported (golint)
  • Line 47: warning: exported method AuthServer.Authenticate should have comment or be unexported (golint)
  • Line 55: warning: exported method AuthServer.RoleAdd should have comment or be unexported (golint)
  • Line 63: warning: exported method AuthServer.RoleDelete should have comment or be unexported (golint)
  • Line 71: warning: exported method AuthServer.RoleGet should have comment or be unexported (golint)
  • Line 79: warning: exported method AuthServer.RoleList should have comment or be unexported (golint)
  • Line 87: warning: exported method AuthServer.RoleRevokePermission should have comment or be unexported (golint)
  • Line 95: warning: exported method AuthServer.RoleGrantPermission should have comment or be unexported (golint)
  • Line 103: warning: exported method AuthServer.UserAdd should have comment or be unexported (golint)
  • Line 111: warning: exported method AuthServer.UserDelete should have comment or be unexported (golint)
  • Line 119: warning: exported method AuthServer.UserGet should have comment or be unexported (golint)
  • Line 127: warning: exported method AuthServer.UserList should have comment or be unexported (golint)
  • Line 135: warning: exported method AuthServer.UserGrantRole should have comment or be unexported (golint)
  • Line 143: warning: exported method AuthServer.UserRevokeRole should have comment or be unexported (golint)
  • Line 151: warning: exported method AuthServer.UserChangePassword should have comment or be unexported (golint)

• etcd/pkg/testutil/assert.go
  • Line 23: warning: exported function AssertEqual should have comment or be unexported (golint)
  • Line 38: warning: exported function AssertNil should have comment or be unexported (golint)
  • Line 42: warning: exported function AssertNotNil should have comment or be unexported (golint)
  • Line 48: warning: exported function AssertTrue should have comment or be unexported (golint)
  • Line 52: warning: exported function AssertFalse should have comment or be unexported (golint)

• etcd/store/watcher.go
  • Line 17: warning: exported type Watcher should have comment or be unexported (golint)
  • Line 92: warning: exported function NewNopWatcher should have comment or be unexported (golint)

• etcd/pkg/fileutil/lock.go
  • Line 23: warning: exported var ErrLocked should have comment or be unexported (golint)
  • Line 26: warning: exported type LockedFile should have comment or be unexported (golint)

• etcd/contrib/recipes/queue.go
  • Line 31: warning: exported function NewQueue should have comment or be unexported (golint)
  • Line 35: warning: exported method Queue.Enqueue should have comment or be unexported (golint)

• etcd/clientv3/maintenance.go
  • Line 27: warning: exported type DefragmentResponse should have comment or be unexported (golint)
  • Line 28: warning: exported type AlarmResponse should have comment or be unexported (golint)
  • Line 29: warning: exported type AlarmMember should have comment or be unexported (golint)
  • Line 30: warning: exported type StatusResponse should have comment or be unexported (golint)
  • Line 33: warning: exported type Maintenance should have comment or be unexported (golint)
  • Line 62: warning: exported function NewMaintenance should have comment or be unexported (golint)
  • Line 80: warning: exported function NewMaintenanceFromMaintenanceClient should have comment or be unexported (golint)

• etcd/etcdserver/api/v3rpc/member.go
  • Line 29: warning: exported type ClusterServer should have comment or be unexported (golint)
  • Line 35: warning: exported function NewClusterServer should have comment or be unexported (golint)
  • Line 43: warning: exported method ClusterServer.MemberAdd should have comment or be unexported (golint)
  • Line 63: warning: exported method ClusterServer.MemberRemove should have comment or be unexported (golint)
  • Line 71: warning: exported method ClusterServer.MemberUpdate should have comment or be unexported (golint)
  • Line 83: warning: exported method ClusterServer.MemberList should have comment or be unexported (golint)

• etcd/pkg/types/set.go
  • Line 23: warning: exported type Set should have comment or be unexported (golint)
  • Line 34: warning: exported function NewUnsafeSet should have comment or be unexported (golint)
  • Line 42: warning: exported function NewThreadsafeSet should have comment or be unexported (golint)

• etcd/etcdmain/main.go
  • Line 25: warning: exported function Main should have comment or be unexported (golint)

• etcd/functional/tester/case_sigquit_remove_quorum.go
  • Line 263: warning: don't use underscores in Go names; func new_Case_SIGQUIT_AND_REMOVE_QUORUM_AND_RESTORE_LEADER_SNAPSHOT_FROM_SCRATCH should be newCaseSIGQUITANDREMOVEQUORUMANDRESTORELEADERSNAPSHOTFROMSCRATCH (golint)

• etcd/etcdctl/ctlv2/command/auth_commands.go
  • Line 26: warning: exported function NewAuthCommands should have comment or be unexported (golint)

• etcd/pkg/types/urls.go
  • Line 26: warning: exported type URLs should have comment or be unexported (golint)
  • Line 28: warning: exported function NewURLs should have comment or be unexported (golint)
  • Line 56: warning: exported function MustNewURLs should have comment or be unexported (golint)
  • Line 68: warning: exported method URLs.Sort should have comment or be unexported (golint)
  • Line 75: warning: exported method URLs.StringSlice should have comment or be unexported (golint)

• etcd/pkg/mock/mockstorage/storage_recorder.go
  • Line 28: warning: exported function NewStorageRecorder should have comment or be unexported (golint)
  • Line 32: warning: exported function NewStorageRecorderStream should have comment or be unexported (golint)

• etcd/pkg/cors/cors.go
  • Line 26: warning: exported type CORSInfo should have comment or be unexported (golint)
  • Line 58: warning: receiver name c should be consistent with previous receiver name ci for CORSInfo (golint)
  • Line 62: warning: exported type CORSHandler should have comment or be unexported (golint)

• etcd/alarm/alarms.go
  • Line 32: warning: exported type BackendGetter should have comment or be unexported (golint)
  • Line 46: warning: exported function NewAlarmStore should have comment or be unexported (golint)
  • Line 52: warning: exported method AlarmStore.Activate should have comment or be unexported (golint)
  • Line 74: warning: exported method AlarmStore.Deactivate should have comment or be unexported (golint)
  • Line 103: warning: exported method AlarmStore.Get should have comment or be unexported (golint)

• etcd/store/stats.go
  • Line 23: warning: exported const SetSuccess should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: exported type Stats should have comment or be unexported (golint)
  • Line 113: warning: exported method Stats.Inc should have comment or be unexported (golint)

• etcd/mvcc/watchable_store.go
  • Line 69: warning: exported function New should have comment or be unexported (golint)

• etcd/clientv3/auth.go
  • Line 29: warning: exported type AuthEnableResponse should have comment or be unexported (golint)
  • Line 30: warning: exported type AuthDisableResponse should have comment or be unexported (golint)
  • Line 31: warning: exported type AuthenticateResponse should have comment or be unexported (golint)
  • Line 32: warning: exported type AuthUserAddResponse should have comment or be unexported (golint)
  • Line 33: warning: exported type AuthUserDeleteResponse should have comment or be unexported (golint)
  • Line 34: warning: exported type AuthUserChangePasswordResponse should have comment or be unexported (golint)
  • Line 35: warning: exported type AuthUserGrantRoleResponse should have comment or be unexported (golint)
  • Line 36: warning: exported type AuthUserGetResponse should have comment or be unexported (golint)
  • Line 37: warning: exported type AuthUserRevokeRoleResponse should have comment or be unexported (golint)
  • Line 38: warning: exported type AuthRoleAddResponse should have comment or be unexported (golint)
  • Line 39: warning: exported type AuthRoleGrantPermissionResponse should have comment or be unexported (golint)
  • Line 40: warning: exported type AuthRoleGetResponse should have comment or be unexported (golint)
  • Line 41: warning: exported type AuthRoleRevokePermissionResponse should have comment or be unexported (golint)
  • Line 42: warning: exported type AuthRoleDeleteResponse should have comment or be unexported (golint)
  • Line 43: warning: exported type AuthUserListResponse should have comment or be unexported (golint)
  • Line 44: warning: exported type AuthRoleListResponse should have comment or be unexported (golint)
  • Line 46: warning: exported type PermissionType should have comment or be unexported (golint)
  • Line 47: warning: exported type Permission should have comment or be unexported (golint)
  • Line 51: warning: exported const PermRead should have comment (or a comment on this block) or be unexported (golint)
  • Line 56: warning: exported type Auth should have comment or be unexported (golint)
  • Line 108: warning: exported function NewAuth should have comment or be unexported (golint)
  • Line 196: warning: exported function StrToPermissionType should have comment or be unexported (golint)

• etcd/etcdctl/ctlv2/command/cluster_health.go
  • Line 31: warning: exported function NewClusterHealthCommand should have comment or be unexported (golint)

• etcd/etcdctl/ctlv2/command/member_commands.go
  • Line 25: warning: exported function NewMemberCommand should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/adapter/lock_client_adapter.go
  • Line 26: warning: exported function LockServerToLockClient should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/adapter/maintenance_client_adapter.go
  • Line 26: warning: exported function MaintenanceServerToMaintenanceClient should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/kv.go
  • Line 30: warning: exported function NewKvProxy should have comment or be unexported (golint)
  • Line 174: warning: exported function RangeRequestToOp should have comment or be unexported (golint)
  • Line 202: warning: exported function PutRequestToOp should have comment or be unexported (golint)
  • Line 217: warning: exported function DelRequestToOp should have comment or be unexported (golint)

• etcd/pkg/flags/flag.go
  • Line 39: warning: exported method DeprecatedFlag.Set should have comment or be unexported (golint)
  • Line 59: warning: exported method IgnoredFlag.Set should have comment or be unexported (golint)
  • Line 156: warning: exported function IsSet should have comment or be unexported (golint)

• etcd/pkg/mock/mockstore/store_recorder.go
  • Line 38: warning: exported function NewNop should have comment or be unexported (golint)
  • Line 39: warning: exported function NewRecorder should have comment or be unexported (golint)
  • Line 43: warning: exported function NewRecorderStream should have comment or be unexported (golint)
  • Line 144: warning: exported function NewErrRecorder should have comment or be unexported (golint)

• etcd/etcdserver/api/v3rpc/watch.go
  • Line 41: warning: exported function NewWatchServer should have comment or be unexported (golint)
  • Line 59: warning: exported function GetProgressReportInterval should have comment or be unexported (golint)
  • Line 65: warning: exported function SetProgressReportInterval should have comment or be unexported (golint)
  • Line 434: warning: exported function FiltersFromRequest should have comment or be unexported (golint)

• etcd/etcdserver/apply.go
  • Line 586: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 586: warning: should not use basic type untyped string as key in context.WithValue (golint)

• etcd/pkg/monotime/monotime.go
  • Line 24: warning: exported method Time.Add should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/adapter/cluster_client_adapter.go
  • Line 26: warning: exported function ClusterServerToClusterClient should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/adapter/lease_client_adapter.go
  • Line 28: warning: exported function LeaseServerToLeaseClient should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/watch.go
  • Line 45: warning: exported function NewWatchProxy should have comment or be unexported (golint)

• etcd/pkg/transport/unix_listener.go
  • Line 24: warning: exported function NewUnixListener should have comment or be unexported (golint)

• etcd/store/event.go
  • Line 18: warning: exported const Get should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type Event should have comment or be unexported (golint)
  • Line 49: warning: exported method Event.IsCreated should have comment or be unexported (golint)
  • Line 56: warning: exported method Event.Index should have comment or be unexported (golint)
  • Line 60: warning: exported method Event.Clone should have comment or be unexported (golint)
  • Line 69: warning: exported method Event.SetRefresh should have comment or be unexported (golint)

• etcd/contrib/recipes/watch.go
  • Line 32: warning: exported function WaitPrefixEvents should have comment or be unexported (golint)

• etcd/clientv3/compare.go
  • Line 21: warning: exported type CompareTarget should have comment or be unexported (golint)
  • Line 22: warning: exported type CompareResult should have comment or be unexported (golint)
  • Line 25: warning: exported const CompareVersion should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: exported type Cmp should have comment or be unexported (golint)
  • Line 33: warning: exported function Compare should have comment or be unexported (golint)
  • Line 69: warning: exported function Value should have comment or be unexported (golint)
  • Line 73: warning: exported function Version should have comment or be unexported (golint)
  • Line 77: warning: exported function CreateRevision should have comment or be unexported (golint)
  • Line 81: warning: exported function ModRevision should have comment or be unexported (golint)

• etcd/etcdserver/api/v3rpc/maintenance.go
  • Line 31: warning: exported type KVGetter should have comment or be unexported (golint)
  • Line 35: warning: exported type BackendGetter should have comment or be unexported (golint)
  • Line 39: warning: exported type Alarmer should have comment or be unexported (golint)
  • Line 43: warning: exported type RaftStatusGetter should have comment or be unexported (golint)
  • Line 49: warning: exported type AuthGetter should have comment or be unexported (golint)
  • Line 62: warning: exported function NewMaintenanceServer should have comment or be unexported (golint)

• etcd/functional/runner/error.go
  • Line 25: warning: comment on exported const ExitSuccess should be of the form "ExitSuccess ..." (golint)
  • Line 27: warning: exported const ExitError should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported function ExitWithError should have comment or be unexported (golint)

• etcd/functional/agent/handler.go
  • Line 87: warning: don't use underscores in Go names; method handle_INITIAL_START_ETCD should be handleINITIALSTARTETCD (golint)
  • Line 420: warning: don't use underscores in Go names; method handle_RESTART_ETCD should be handleRESTARTETCD (golint)
  • Line 458: warning: don't use underscores in Go names; method handle_SIGTERM_ETCD should be handleSIGTERMETCD (golint)
  • Line 473: warning: don't use underscores in Go names; method handle_SIGQUIT_ETCD_AND_REMOVE_DATA should be handleSIGQUITETCDANDREMOVEDATA (golint)
  • Line 515: warning: don't use underscores in Go names; method handle_SAVE_SNAPSHOT should be handleSAVESNAPSHOT (golint)
  • Line 527: warning: don't use underscores in Go names; method handle_RESTORE_RESTART_FROM_SNAPSHOT should be handleRESTORERESTARTFROMSNAPSHOT (golint)
  • Line 539: warning: don't use underscores in Go names; method handle_RESTART_FROM_SNAPSHOT should be handleRESTARTFROMSNAPSHOT (golint)
  • Line 569: warning: don't use underscores in Go names; method handle_SIGQUIT_ETCD_AND_ARCHIVE_DATA should be handleSIGQUITETCDANDARCHIVEDATA (golint)
  • Line 609: warning: don't use underscores in Go names; method handle_SIGQUIT_ETCD_AND_REMOVE_DATA_AND_STOP_AGENT should be handleSIGQUITETCDANDREMOVEDATAANDSTOPAGENT (golint)
  • Line 636: warning: don't use underscores in Go names; method handle_BLACKHOLE_PEER_PORT_TX_RX should be handleBLACKHOLEPEERPORTTXRX (golint)
  • Line 649: warning: don't use underscores in Go names; method handle_UNBLACKHOLE_PEER_PORT_TX_RX should be handleUNBLACKHOLEPEERPORTTXRX (golint)
  • Line 662: warning: don't use underscores in Go names; method handle_DELAY_PEER_PORT_TX_RX should be handleDELAYPEERPORTTXRX (golint)
  • Line 687: warning: don't use underscores in Go names; method handle_UNDELAY_PEER_PORT_TX_RX should be handleUNDELAYPEERPORTTXRX (golint)

• etcd/snap/db.go
  • Line 29: warning: exported var ErrNoDBSnapshot should have comment or be unexported (golint)

• etcd/etcdserver/api/v2http/httptypes/errors.go
  • Line 28: warning: exported type HTTPError should have comment or be unexported (golint)
  • Line 38: warning: exported method HTTPError.WriteTo should have comment or be unexported (golint)
  • Line 51: warning: exported function NewHTTPError should have comment or be unexported (golint)

• etcd/etcdctl/ctlv3/command/printer_simple.go
  • Line 87: warning: receiver name p should be consistent with previous receiver name s for simplePrinter (golint)
  • Line 91: warning: receiver name p should be consistent with previous receiver name s for simplePrinter (golint)

• etcd/client/client.go
  • Line 37: warning: exported var ErrNoEndpoints should have comment or be unexported (golint)
  • Line 48: warning: exported var DefaultRequestTimeout should have comment or be unexported (golint)
  • Line 50: warning: exported var DefaultTransport should have comment or be unexported (golint)
  • Line 59: warning: exported type EndpointSelectionMode should have comment or be unexported (golint)
  • Line 69: warning: comment on exported const EndpointSelectionPrioritizeLeader should be of the form "EndpointSelectionPrioritizeLeader ..." (golint)
  • Line 82: warning: exported type Config should have comment or be unexported (golint)
  • Line 167: warning: exported type CheckRedirectFunc should have comment or be unexported (golint)
  • Line 177: warning: exported type Client should have comment or be unexported (golint)
  • Line 213: warning: exported function New should have comment or be unexported (golint)

• etcd/client/members.go
  • Line 35: warning: exported type Member should have comment or be unexported (golint)
  • Line 97: warning: exported type MembersAPI should have comment or be unexported (golint)

• etcd/etcdserver/api/v3rpc/lease.go
  • Line 27: warning: exported type LeaseServer should have comment or be unexported (golint)
  • Line 32: warning: exported function NewLeaseServer should have comment or be unexported (golint)
  • Line 36: warning: exported method LeaseServer.LeaseGrant should have comment or be unexported (golint)
  • Line 46: warning: exported method LeaseServer.LeaseRevoke should have comment or be unexported (golint)
  • Line 55: warning: exported method LeaseServer.LeaseTimeToLive should have comment or be unexported (golint)
  • Line 71: warning: exported method LeaseServer.LeaseKeepAlive should have comment or be unexported (golint)

• etcd/etcdctl/ctlv2/command/error.go
  • Line 27: warning: exported const ExitSuccess should have comment (or a comment on this block) or be unexported (golint)

• etcd/etcdserver/errors.go
  • Line 23: warning: exported var ErrUnknownMethod should have comment or be unexported (golint)
  • Line 39: warning: exported type DiscoveryError should have comment or be unexported (golint)

• etcd/pkg/transport/listener.go
  • Line 36: warning: exported function NewListener should have comment or be unexported (golint)
  • Line 61: warning: exported type TLSInfo should have comment or be unexported (golint)
  • Line 93: warning: exported method TLSInfo.Empty should have comment or be unexported (golint)
  • Line 97: warning: exported function SelfCert should have comment or be unexported (golint)

• etcd/store/event_history.go
  • Line 26: warning: exported type EventHistory should have comment or be unexported (golint)

• etcd/rafthttp/peer.go
  • Line 38: warning: exported const ConnWriteTimeout should have comment (or a comment on this block) or be unexported (golint)
  • Line 55: warning: exported type Peer should have comment or be unexported (golint)

• etcd/raft/node.go
  • Line 24: warning: exported type SnapshotStatus should have comment or be unexported (golint)
  • Line 27: warning: exported const SnapshotFinish should have comment (or a comment on this block) or be unexported (golint)
  • Line 170: warning: exported type Peer should have comment or be unexported (golint)

• etcd/etcdctl/ctlv2/command/user_commands.go
  • Line 27: warning: exported function NewUserCommands should have comment or be unexported (golint)

• etcd/etcdctl/ctlv2/command/util.go
  • Line 38: warning: exported var ErrNoAvailSrc should have comment or be unexported (golint)

• etcd/pkg/osutil/osutil.go
  • Line 32: warning: exported function Unsetenv should have comment or be unexported (golint)

• etcd/store/store.go
  • Line 40: warning: exported type Store should have comment or be unexported (golint)
  • Line 68: warning: exported type TTLOptionSet should have comment or be unexported (golint)
  • Line 218: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• etcd/compactor/compactor.go
  • Line 37: warning: exported type Compactable should have comment or be unexported (golint)
  • Line 41: warning: exported type RevGetter should have comment or be unexported (golint)
  • Line 62: warning: exported function NewPeriodic should have comment or be unexported (golint)
  • Line 71: warning: exported method Periodic.Run should have comment or be unexported (golint)
  • Line 115: warning: exported method Periodic.Stop should have comment or be unexported (golint)
  • Line 119: warning: exported method Periodic.Pause should have comment or be unexported (golint)
  • Line 125: warning: exported method Periodic.Resume should have comment or be unexported (golint)

• etcd/mvcc/kvstore.go
  • Line 40: warning: exported var ErrCompacted should have comment or be unexported (golint)
  • Line 403: warning: receiver name a should be consistent with previous receiver name s for store (golint)

• etcd/etcdserver/stats/stats.go
  • Line 24: warning: exported type Stats should have comment or be unexported (golint)

• etcd/etcdctl/ctlv2/command/backup_command.go
  • Line 33: warning: exported function NewBackupCommand should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/election.go
  • Line 28: warning: exported function NewElectionProxy should have comment or be unexported (golint)

• etcd/pkg/flags/urls.go
  • Line 23: warning: exported type URLsValue should have comment or be unexported (golint)
  • Line 46: warning: exported function NewURLsValue should have comment or be unexported (golint)

• etcd/client/curl.go
  • Line 29: warning: exported function EnablecURLDebug should have comment or be unexported (golint)
  • Line 33: warning: exported function DisablecURLDebug should have comment or be unexported (golint)

• etcd/functional/tester/case_no_fail.go
  • Line 46: warning: don't use underscores in Go names; func new_Case_NO_FAIL_WITH_STRESS should be newCaseNOFAILWITHSTRESS (golint)
  • Line 91: warning: don't use underscores in Go names; func new_Case_NO_FAIL_WITH_NO_STRESS_FOR_LIVENESS should be newCaseNOFAILWITHNOSTRESSFORLIVENESS (golint)

• etcd/functional/tester/cluster.go
  • Line 377: warning: don't use underscores in Go names; method Send_INITIAL_START_ETCD should be SendINITIALSTARTETCD (golint)
  • Line 383: warning: don't use underscores in Go names; method send_SIGQUIT_ETCD_AND_ARCHIVE_DATA should be sendSIGQUITETCDANDARCHIVEDATA (golint)
  • Line 388: warning: don't use underscores in Go names; method send_RESTART_ETCD should be sendRESTARTETCD (golint)
  • Line 566: warning: don't use underscores in Go names; method Send_SIGQUIT_ETCD_AND_REMOVE_DATA_AND_STOP_AGENT should be SendSIGQUITETCDANDREMOVEDATAANDSTOPAGENT (golint)

• etcd/proxy/grpcproxy/lock.go
  • Line 28: warning: exported function NewLockProxy should have comment or be unexported (golint)

• etcd/pkg/transport/transport.go
  • Line 26: warning: exported function NewTransport should have comment or be unexported (golint)

• etcd/client/keys.go
  • Line 35: warning: exported const ErrorCodeKeyNotFound should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: exported type Error should have comment or be unexported (golint)
  • Line 69: warning: exported var ErrInvalidJSON should have comment or be unexported (golint)
  • Line 78: warning: exported const PrevIgnore should have comment (or a comment on this block) or be unexported (golint)
  • Line 103: warning: exported type KeysAPI should have comment or be unexported (golint)
  • Line 133: warning: exported type WatcherOptions should have comment or be unexported (golint)
  • Line 150: warning: exported type CreateInOrderOptions should have comment or be unexported (golint)
  • Line 158: warning: exported type SetOptions should have comment or be unexported (golint)
  • Line 200: warning: exported type GetOptions should have comment or be unexported (golint)
  • Line 218: warning: exported type DeleteOptions should have comment or be unexported (golint)
  • Line 244: warning: exported type Watcher should have comment or be unexported (golint)
  • Line 258: warning: exported type Response should have comment or be unexported (golint)
  • Line 281: warning: exported type Node should have comment or be unexported (golint)
  • Line 319: warning: exported type Nodes should have comment or be unexported (golint)

• etcd/pkg/pbutil/pbutil.go
  • Line 24: warning: exported type Marshaler should have comment or be unexported (golint)
  • Line 28: warning: exported type Unmarshaler should have comment or be unexported (golint)
  • Line 32: warning: exported function MustMarshal should have comment or be unexported (golint)
  • Line 40: warning: exported function MustUnmarshal should have comment or be unexported (golint)
  • Line 46: warning: exported function MaybeUnmarshal should have comment or be unexported (golint)
  • Line 53: warning: exported function GetBool should have comment or be unexported (golint)
  • Line 60: warning: exported function Boolp should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/adapter/kv_client_adapter.go
  • Line 25: warning: exported function KvServerToKvClient should have comment or be unexported (golint)

• etcd/store/metrics.go
  • Line 85: warning: exported const GetRecursive should have comment (or a comment on this block) or be unexported (golint)
  • Line 96: warning: don't use underscores in Go names; func parameter read_action should be readAction (golint)
  • Line 100: warning: don't use underscores in Go names; func parameter read_action should be readAction (golint)
  • Line 105: warning: don't use underscores in Go names; func parameter write_action should be writeAction (golint)
  • Line 109: warning: don't use underscores in Go names; func parameter write_action should be writeAction (golint)

• etcd/clientv3/naming/grpc.go
  • Line 30: warning: exported var ErrWatcherClosed should have comment or be unexported (golint)
  • Line 38: warning: exported method GRPCResolver.Update should have comment or be unexported (golint)
  • Line 54: warning: exported method GRPCResolver.Resolve should have comment or be unexported (golint)

• etcd/auth/store.go
  • Line 50: warning: exported var ErrRootUserNotExist should have comment or be unexported (golint)
  • Line 78: warning: exported type AuthInfo should have comment or be unexported (golint)
  • Line 83: warning: exported type AuthStore should have comment or be unexported (golint)
  • Line 170: warning: exported type TokenProvider should have comment or be unexported (golint)
  • Line 903: warning: exported function NewAuthStore should have comment or be unexported (golint)
  • Line 1059: warning: exported function NewTokenProvider should have comment or be unexported (golint)
  • Line 1084: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 1090: warning: should not use basic type untyped string as key in context.WithValue (golint)

• etcd/embed/config.go
  • Line 40: warning: exported const ClusterStateFlagNew should have comment (or a comment on this block) or be unexported (golint)
  • Line 60: warning: exported var ErrConflictBootstrapFlags should have comment or be unexported (golint)
  • Line 257: warning: exported function ConfigFromFile should have comment or be unexported (golint)
  • Line 435: warning: exported method Config.InitialClusterFromName should have comment or be unexported (golint)
  • Line 449: warning: exported method Config.IsNewCluster should have comment or be unexported (golint)
  • Line 450: warning: exported method Config.ElectionTicks should have comment or be unexported (golint)
  • Line 460: warning: exported method Config.ClientSelfCert should have comment or be unexported (golint)
  • Line 479: warning: exported method Config.PeerSelfCert should have comment or be unexported (golint)

• etcd/functional/tester/case_external.go
  • Line 49: warning: don't use underscores in Go names; func new_Case_EXTERNAL should be newCaseEXTERNAL (golint)

• etcd/pkg/fileutil/fileutil.go
  • Line 96: warning: exported function Exist should have comment or be unexported (golint)

• etcd/rafthttp/http.go
  • Line 45: warning: exported var RaftPrefix should have comment or be unexported (golint)

• etcd/raft/logger.go
  • Line 24: warning: exported type Logger should have comment or be unexported (golint)
  • Line 44: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 62: warning: exported method DefaultLogger.EnableTimestamps should have comment or be unexported (golint)
  • Line 66: warning: exported method DefaultLogger.EnableDebug should have comment or be unexported (golint)
  • Line 70: warning: exported method DefaultLogger.Debug should have comment or be unexported (golint)
  • Line 76: warning: exported method DefaultLogger.Debugf should have comment or be unexported (golint)
  • Line 82: warning: exported method DefaultLogger.Info should have comment or be unexported (golint)
  • Line 86: warning: exported method DefaultLogger.Infof should have comment or be unexported (golint)
  • Line 94: warning: exported method DefaultLogger.Errorf should have comment or be unexported (golint)
  • Line 98: warning: exported method DefaultLogger.Warning should have comment or be unexported (golint)
  • Line 102: warning: exported method DefaultLogger.Warningf should have comment or be unexported (golint)
  • Line 106: warning: exported method DefaultLogger.Fatal should have comment or be unexported (golint)
  • Line 111: warning: exported method DefaultLogger.Fatalf should have comment or be unexported (golint)
  • Line 116: warning: exported method DefaultLogger.Panic should have comment or be unexported (golint)
  • Line 120: warning: exported method DefaultLogger.Panicf should have comment or be unexported (golint)

• etcd/clientv3/config.go
  • Line 25: warning: exported type Config should have comment or be unexported (golint)

• etcd/etcdserver/api/v3rpc/key.go
  • Line 31: warning: comment on exported var MaxOpsPerTxn should be of the form "MaxOpsPerTxn ..." (golint)
  • Line 41: warning: exported function NewKVServer should have comment or be unexported (golint)

• etcd/pkg/report/report.go
  • Line 39: warning: exported method Result.Duration should have comment or be unexported (golint)
  • Line 82: warning: exported function NewReport should have comment or be unexported (golint)
  • Line 93: warning: exported function NewReportSample should have comment or be unexported (golint)
  • Line 164: warning: exported function NewReportRate should have comment or be unexported (golint)

• etcd/pkg/expect/expect.go
  • Line 31: warning: exported type ExpectProcess should have comment or be unexported (golint)
  • Line 171: warning: exported method ExpectProcess.Send should have comment or be unexported (golint)

• etcd/etcdserver/api/capability.go
  • Line 25: warning: exported type Capability should have comment or be unexported (golint)
  • Line 28: warning: exported const AuthCapability should have comment (or a comment on this block) or be unexported (golint)
  • Line 73: warning: exported function IsCapabilityEnabled should have comment or be unexported (golint)
  • Line 82: warning: exported function EnableCapability should have comment or be unexported (golint)

• etcd/etcdctl/ctlv3/command/printer.go
  • Line 67: warning: exported function NewPrinter should have comment or be unexported (golint)

• etcd/client/cluster_error.go
  • Line 19: warning: exported type ClusterError should have comment or be unexported (golint)
  • Line 31: warning: exported method ClusterError.Detail should have comment or be unexported (golint)

• etcd/functional/runner/root.go
  • Line 61: warning: exported function Start should have comment or be unexported (golint)

• etcd/integration/cluster.go
  • Line 65: warning: exported const UrlScheme should have comment (or a comment on this block) or be unexported (golint)
  • Line 93: warning: exported type ClusterConfig should have comment or be unexported (golint)
  • Line 474: warning: exported function NewListenerWithAddr should have comment or be unexported (golint)
  • Line 938: warning: exported function MustNewHTTPClient should have comment or be unexported (golint)
  • Line 960: warning: exported type SortableMemberSliceByPeerURLs should have comment or be unexported (golint)
  • Line 968: warning: exported type ClusterV3 should have comment or be unexported (golint)
  • Line 997: warning: exported method ClusterV3.TakeClient should have comment or be unexported (golint)
  • Line 1003: warning: exported method ClusterV3.Terminate should have comment or be unexported (golint)
  • Line 1017: warning: exported method ClusterV3.RandClient should have comment or be unexported (golint)
  • Line 1021: warning: exported method ClusterV3.Client should have comment or be unexported (golint)

• etcd/pkg/srv/srv.go
  • Line 103: warning: exported type SRVClients should have comment or be unexported (golint)

• etcd/clientv3/concurrency/election.go
  • Line 29: warning: exported var ErrElectionNotLeader should have comment or be unexported (golint)
  • Line 33: warning: exported type Election should have comment or be unexported (golint)

• etcd/functional/tester/case_sigquit_remove.go
  • Line 30: warning: don't use underscores in Go names; func inject_SIGQUIT_ETCD_AND_REMOVE_DATA should be injectSIGQUITETCDANDREMOVEDATA (golint)
  • Line 128: warning: don't use underscores in Go names; func recover_SIGQUIT_ETCD_AND_REMOVE_DATA should be recoverSIGQUITETCDANDREMOVEDATA (golint)
  • Line 177: warning: don't use underscores in Go names; func new_Case_SIGQUIT_AND_REMOVE_ONE_FOLLOWER should be newCaseSIGQUITANDREMOVEONEFOLLOWER (golint)
  • Line 190: warning: don't use underscores in Go names; func new_Case_SIGQUIT_AND_REMOVE_ONE_FOLLOWER_UNTIL_TRIGGER_SNAPSHOT should be newCaseSIGQUITANDREMOVEONEFOLLOWERUNTILTRIGGERSNAPSHOT (golint)
  • Line 197: warning: don't use underscores in Go names; func new_Case_SIGQUIT_AND_REMOVE_LEADER should be newCaseSIGQUITANDREMOVELEADER (golint)
  • Line 210: warning: don't use underscores in Go names; func new_Case_SIGQUIT_AND_REMOVE_LEADER_UNTIL_TRIGGER_SNAPSHOT should be newCaseSIGQUITANDREMOVELEADERUNTILTRIGGERSNAPSHOT (golint)

• etcd/pkg/report/timeseries.go
  • Line 28: warning: exported type DataPoint should have comment or be unexported (golint)
  • Line 36: warning: exported type TimeSeries should have comment or be unexported (golint)
  • Line 121: warning: receiver name ts should be consistent with previous receiver name t for TimeSeries (golint)

• etcd/mvcc/index.go
  • Line 193: warning: receiver name a should be consistent with previous receiver name ti for treeIndex (golint)

• etcd/proxy/grpcproxy/adapter/election_client_adapter.go
  • Line 26: warning: exported function ElectionServerToElectionClient should have comment or be unexported (golint)

• etcd/lease/lessor.go
  • Line 47: warning: exported var ErrNotPrimary should have comment or be unexported (golint)
  • Line 63: warning: exported type LeaseID should have comment or be unexported (golint)
  • Line 155: warning: exported function NewLessor should have comment or be unexported (golint)
  • Line 553: warning: exported type Lease should have comment or be unexported (golint)
  • Line 614: warning: exported type LeaseItem should have comment or be unexported (golint)
  • Line 628: warning: exported method FakeLessor.SetRangeDeleter should have comment or be unexported (golint)
  • Line 630: warning: exported method FakeLessor.Grant should have comment or be unexported (golint)
  • Line 632: warning: exported method FakeLessor.Revoke should have comment or be unexported (golint)
  • Line 634: warning: exported method FakeLessor.Attach should have comment or be unexported (golint)
  • Line 636: warning: exported method FakeLessor.GetLease should have comment or be unexported (golint)
  • Line 637: warning: exported method FakeLessor.Detach should have comment or be unexported (golint)
  • Line 639: warning: exported method FakeLessor.Promote should have comment or be unexported (golint)
  • Line 641: warning: exported method FakeLessor.Demote should have comment or be unexported (golint)
  • Line 643: warning: exported method FakeLessor.Renew should have comment or be unexported (golint)
  • Line 645: warning: exported method FakeLessor.Lookup should have comment or be unexported (golint)
  • Line 645: warning: receiver name le should be consistent with previous receiver name fl for FakeLessor (golint)
  • Line 647: warning: exported method FakeLessor.ExpiredLeasesC should have comment or be unexported (golint)
  • Line 649: warning: exported method FakeLessor.Recover should have comment or be unexported (golint)
  • Line 651: warning: exported method FakeLessor.Stop should have comment or be unexported (golint)

• etcd/pkg/crc/crc.go
  • Line 14: warning: comment on exported const Size should be of the form "Size ..." (golint)

• etcd/mvcc/kv.go
  • Line 23: warning: exported type RangeOptions should have comment or be unexported (golint)
  • Line 29: warning: exported type RangeResult should have comment or be unexported (golint)
  • Line 35: warning: exported type ReadView should have comment or be unexported (golint)
  • Line 63: warning: exported type WriteView should have comment or be unexported (golint)
  • Line 98: warning: exported function NewReadOnlyTxnWrite should have comment or be unexported (golint)
  • Line 100: warning: exported type KV should have comment or be unexported (golint)

• etcd/etcdserver/membership/member.go
  • Line 46: warning: exported type Member should have comment or be unexported (golint)
  • Line 85: warning: exported method Member.Clone should have comment or be unexported (golint)
  • Line 106: warning: exported method Member.IsStarted should have comment or be unexported (golint)

• etcd/etcdserver/v3_server.go
  • Line 41: warning: exported type RaftKV should have comment or be unexported (golint)
  • Line 49: warning: exported type Lessor should have comment or be unexported (golint)
  • Line 63: warning: exported type Authenticator should have comment or be unexported (golint)
  • Line 82: warning: exported method EtcdServer.Range should have comment or be unexported (golint)
  • Line 107: warning: exported method EtcdServer.Put should have comment or be unexported (golint)
  • Line 115: warning: exported method EtcdServer.DeleteRange should have comment or be unexported (golint)
  • Line 123: warning: exported method EtcdServer.Txn should have comment or be unexported (golint)
  • Line 183: warning: exported method EtcdServer.Compact should have comment or be unexported (golint)
  • Line 211: warning: exported method EtcdServer.LeaseGrant should have comment or be unexported (golint)
  • Line 224: warning: exported method EtcdServer.LeaseRevoke should have comment or be unexported (golint)
  • Line 235: warning: exported method EtcdServer.LeaseRenew should have comment or be unexported (golint)
  • Line 264: warning: exported method EtcdServer.LeaseTimeToLive should have comment or be unexported (golint)
  • Line 327: warning: exported method EtcdServer.Alarm should have comment or be unexported (golint)
  • Line 335: warning: exported method EtcdServer.AuthEnable should have comment or be unexported (golint)
  • Line 343: warning: exported method EtcdServer.AuthDisable should have comment or be unexported (golint)
  • Line 351: warning: exported method EtcdServer.Authenticate should have comment or be unexported (golint)
  • Line 390: warning: exported method EtcdServer.UserAdd should have comment or be unexported (golint)
  • Line 398: warning: exported method EtcdServer.UserDelete should have comment or be unexported (golint)
  • Line 406: warning: exported method EtcdServer.UserChangePassword should have comment or be unexported (golint)
  • Line 414: warning: exported method EtcdServer.UserGrantRole should have comment or be unexported (golint)
  • Line 422: warning: exported method EtcdServer.UserGet should have comment or be unexported (golint)
  • Line 430: warning: exported method EtcdServer.UserList should have comment or be unexported (golint)
  • Line 438: warning: exported method EtcdServer.UserRevokeRole should have comment or be unexported (golint)
  • Line 446: warning: exported method EtcdServer.RoleAdd should have comment or be unexported (golint)
  • Line 454: warning: exported method EtcdServer.RoleGrantPermission should have comment or be unexported (golint)
  • Line 462: warning: exported method EtcdServer.RoleGet should have comment or be unexported (golint)
  • Line 470: warning: exported method EtcdServer.RoleList should have comment or be unexported (golint)
  • Line 478: warning: exported method EtcdServer.RoleRevokePermission should have comment or be unexported (golint)
  • Line 486: warning: exported method EtcdServer.RoleDelete should have comment or be unexported (golint)
  • Line 700: warning: exported method EtcdServer.AuthInfoFromCtx should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/cache/store.go
  • Line 30: warning: exported var DefaultMaxEntries should have comment or be unexported (golint)
  • Line 34: warning: exported type Cache should have comment or be unexported (golint)
  • Line 53: warning: exported function NewCache should have comment or be unexported (golint)

• etcd/pkg/testutil/recorder.go
  • Line 24: warning: exported type Action should have comment or be unexported (golint)
  • Line 29: warning: exported type Recorder should have comment or be unexported (golint)
  • Line 47: warning: exported method RecorderBuffered.Record should have comment or be unexported (golint)
  • Line 52: warning: exported method RecorderBuffered.Action should have comment or be unexported (golint)
  • Line 59: warning: exported method RecorderBuffered.Wait should have comment or be unexported (golint)
  • Line 69: warning: exported method RecorderBuffered.Chan should have comment or be unexported (golint)
  • Line 86: warning: exported function NewRecorderStream should have comment or be unexported (golint)

• etcd/proxy/tcpproxy/userspace.go
  • Line 63: warning: exported type TCPProxy should have comment or be unexported (golint)
  • Line 75: warning: exported method TCPProxy.Run should have comment or be unexported (golint)
  • Line 221: warning: exported method TCPProxy.Stop should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/maintenance.go
  • Line 30: warning: exported function NewMaintenanceProxy should have comment or be unexported (golint)

• etcd/pkg/adt/interval_tree.go
  • Line 84: warning: receiver name n should be consistent with previous receiver name x for intervalNode (golint)
  • Line 163: warning: exported type IntervalValue should have comment or be unexported (golint)
  • Line 488: warning: exported type StringComparable should have comment or be unexported (golint)
  • Line 490: warning: exported method StringComparable.Compare should have comment or be unexported (golint)
  • Line 501: warning: exported function NewStringInterval should have comment or be unexported (golint)
  • Line 505: warning: exported function NewStringPoint should have comment or be unexported (golint)
  • Line 512: warning: exported method StringAffineComparable.Compare should have comment or be unexported (golint)
  • Line 534: warning: exported function NewStringAffineInterval should have comment or be unexported (golint)
  • Line 537: warning: exported function NewStringAffinePoint should have comment or be unexported (golint)
  • Line 541: warning: exported function NewInt64Interval should have comment or be unexported (golint)
  • Line 545: warning: exported function NewInt64Point should have comment or be unexported (golint)
  • Line 549: warning: exported type Int64Comparable should have comment or be unexported (golint)
  • Line 551: warning: exported method Int64Comparable.Compare should have comment or be unexported (golint)
  • Line 566: warning: exported method BytesAffineComparable.Compare should have comment or be unexported (golint)
  • Line 582: warning: exported function NewBytesAffineInterval should have comment or be unexported (golint)
  • Line 585: warning: exported function NewBytesAffinePoint should have comment or be unexported (golint)

• etcd/etcdserver/server.go
  • Line 65: warning: exported const DefaultSnapCount should have comment (or a comment on this block) or be unexported (golint)
  • Line 111: warning: exported type Response should have comment or be unexported (golint)
  • Line 117: warning: exported type Server should have comment or be unexported (golint)
  • Line 634: warning: exported method EtcdServer.ID should have comment or be unexported (golint)
  • Line 636: warning: exported method EtcdServer.Cluster should have comment or be unexported (golint)
  • Line 638: warning: exported method EtcdServer.RaftHandler should have comment or be unexported (golint)
  • Line 640: warning: exported method EtcdServer.Lessor should have comment or be unexported (golint)
  • Line 642: warning: exported method EtcdServer.ApplyWait should have comment or be unexported (golint)
  • Line 644: warning: exported method EtcdServer.Process should have comment or be unexported (golint)
  • Line 655: warning: exported method EtcdServer.IsIDRemoved should have comment or be unexported (golint)
  • Line 657: warning: exported method EtcdServer.ReportUnreachable should have comment or be unexported (golint)
  • Line 1077: warning: exported method EtcdServer.SelfStats should have comment or be unexported (golint)
  • Line 1079: warning: exported method EtcdServer.LeaderStats should have comment or be unexported (golint)
  • Line 1087: warning: exported method EtcdServer.StoreStats should have comment or be unexported (golint)
  • Line 1110: warning: exported method EtcdServer.AddMember should have comment or be unexported (golint)
  • Line 1140: warning: exported method EtcdServer.RemoveMember should have comment or be unexported (golint)
  • Line 1183: warning: exported method EtcdServer.UpdateMember should have comment or be unexported (golint)
  • Line 1202: warning: exported method EtcdServer.Index should have comment or be unexported (golint)
  • Line 1204: warning: exported method EtcdServer.Term should have comment or be unexported (golint)
  • Line 1211: warning: exported method EtcdServer.Leader should have comment or be unexported (golint)
  • Line 1554: warning: exported method EtcdServer.PauseSending should have comment or be unexported (golint)
  • Line 1556: warning: exported method EtcdServer.ResumeSending should have comment or be unexported (golint)
  • Line 1558: warning: exported method EtcdServer.ClusterVersion should have comment or be unexported (golint)
  • Line 1669: warning: exported method EtcdServer.KV should have comment or be unexported (golint)
  • Line 1670: warning: exported method EtcdServer.Backend should have comment or be unexported (golint)
  • Line 1676: warning: exported method EtcdServer.AuthStore should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/auth.go
  • Line 24: warning: exported type AuthProxy should have comment or be unexported (golint)
  • Line 28: warning: exported function NewAuthProxy should have comment or be unexported (golint)
  • Line 32: warning: exported method AuthProxy.AuthEnable should have comment or be unexported (golint)
  • Line 37: warning: exported method AuthProxy.AuthDisable should have comment or be unexported (golint)
  • Line 42: warning: exported method AuthProxy.Authenticate should have comment or be unexported (golint)
  • Line 47: warning: exported method AuthProxy.RoleAdd should have comment or be unexported (golint)
  • Line 52: warning: exported method AuthProxy.RoleDelete should have comment or be unexported (golint)
  • Line 57: warning: exported method AuthProxy.RoleGet should have comment or be unexported (golint)
  • Line 62: warning: exported method AuthProxy.RoleList should have comment or be unexported (golint)
  • Line 67: warning: exported method AuthProxy.RoleRevokePermission should have comment or be unexported (golint)
  • Line 72: warning: exported method AuthProxy.RoleGrantPermission should have comment or be unexported (golint)
  • Line 77: warning: exported method AuthProxy.UserAdd should have comment or be unexported (golint)
  • Line 82: warning: exported method AuthProxy.UserDelete should have comment or be unexported (golint)
  • Line 87: warning: exported method AuthProxy.UserGet should have comment or be unexported (golint)
  • Line 92: warning: exported method AuthProxy.UserList should have comment or be unexported (golint)
  • Line 97: warning: exported method AuthProxy.UserGrantRole should have comment or be unexported (golint)
  • Line 102: warning: exported method AuthProxy.UserRevokeRole should have comment or be unexported (golint)
  • Line 107: warning: exported method AuthProxy.UserChangePassword should have comment or be unexported (golint)

• etcd/auth/store_test.go
  • Line 201: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 201: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 212: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 212: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 463: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 463: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 496: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 496: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 644: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 644: warning: should not use basic type untyped string as key in context.WithValue (golint)

• etcd/etcdserver/etcdserverpb/raft_internal_stringer.go
  • Line 81: warning: exported function NewLoggableTxnRequest should have comment or be unexported (golint)
  • Line 166: warning: exported function NewLoggablePutRequest should have comment or be unexported (golint)

• etcd/discovery/discovery.go
  • Line 42: warning: exported var ErrInvalidURL should have comment or be unexported (golint)

• etcd/etcdserver/api/v3rpc/grpc.go
  • Line 42: warning: exported function Server should have comment or be unexported (golint)

• etcd/etcdserver/config.go
  • Line 158: warning: exported method ServerConfig.MemberDir should have comment or be unexported (golint)
  • Line 160: warning: exported method ServerConfig.WALDir should have comment or be unexported (golint)
  • Line 167: warning: exported method ServerConfig.SnapDir should have comment or be unexported (golint)
  • Line 169: warning: exported method ServerConfig.ShouldDiscover should have comment or be unexported (golint)
  • Line 188: warning: exported method ServerConfig.PrintWithInitial should have comment or be unexported (golint)
  • Line 190: warning: exported method ServerConfig.Print should have comment or be unexported (golint)

• etcd/clientv3/cluster.go
  • Line 26: warning: exported type Member should have comment or be unexported (golint)
  • Line 27: warning: exported type MemberListResponse should have comment or be unexported (golint)
  • Line 28: warning: exported type MemberAddResponse should have comment or be unexported (golint)
  • Line 29: warning: exported type MemberRemoveResponse should have comment or be unexported (golint)
  • Line 30: warning: exported type MemberUpdateResponse should have comment or be unexported (golint)
  • Line 33: warning: exported type Cluster should have comment or be unexported (golint)
  • Line 52: warning: exported function NewCluster should have comment or be unexported (golint)
  • Line 60: warning: exported function NewClusterFromClusterClient should have comment or be unexported (golint)

• etcd/pkg/wait/wait_time.go
  • Line 19: warning: exported type WaitTime should have comment or be unexported (golint)
  • Line 38: warning: exported function NewTimeList should have comment or be unexported (golint)

• etcd/mvcc/backend/backend.go
  • Line 49: warning: exported type Backend should have comment or be unexported (golint)
  • Line 66: warning: exported type Snapshot should have comment or be unexported (golint)
  • Line 101: warning: exported type BackendConfig should have comment or be unexported (golint)
  • Line 112: warning: exported function DefaultBackendConfig should have comment or be unexported (golint)
  • Line 120: warning: exported function New should have comment or be unexported (golint)
  • Line 124: warning: exported function NewDefaultBackend should have comment or be unexported (golint)
  • Line 214: warning: exported type IgnoreKey should have comment or be unexported (golint)
  • Line 463: warning: exported function NewDefaultTmpBackend should have comment or be unexported (golint)

• etcd/rafthttp/msg_codec.go
  • Line 47: warning: exported var ErrExceedSizeLimit should have comment or be unexported (golint)

• etcd/mvcc/watcher.go
  • Line 26: warning: exported var ErrWatcherNotExist should have comment or be unexported (golint)
  • Line 29: warning: exported type WatchID should have comment or be unexported (golint)
  • Line 34: warning: exported type WatchStream should have comment or be unexported (golint)
  • Line 68: warning: exported type WatchResponse should have comment or be unexported (golint)

• etcd/etcdctl/ctlv3/ctl_nocov.go
  • Line 21: warning: exported function Start should have comment or be unexported (golint)

• etcd/error/error.go
  • Line 81: warning: exported const EcodeKeyNotFound should have comment (or a comment on this block) or be unexported (golint)
  • Line 119: warning: exported type Error should have comment or be unexported (golint)
  • Line 126: warning: exported function NewRequestError should have comment or be unexported (golint)
  • Line 130: warning: exported function NewError should have comment or be unexported (golint)
  • Line 149: warning: exported method Error.StatusCode should have comment or be unexported (golint)
  • Line 157: warning: exported method Error.WriteTo should have comment or be unexported (golint)

• etcd/client/auth_role.go
  • Line 26: warning: exported type Role should have comment or be unexported (golint)
  • Line 33: warning: exported type Permissions should have comment or be unexported (golint)
  • Line 42: warning: exported type PermissionType should have comment or be unexported (golint)
  • Line 45: warning: exported const ReadPermission should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: exported type AuthRoleAPI should have comment or be unexported (golint)

• etcd/etcdserver/stats/leader.go
  • Line 48: warning: exported method LeaderStats.JSON should have comment or be unexported (golint)
  • Line 60: warning: exported method LeaderStats.Follower should have comment or be unexported (golint)

• etcd/etcdserver/storage.go
  • Line 29: warning: exported type Storage should have comment or be unexported (golint)
  • Line 44: warning: exported function NewStorage should have comment or be unexported (golint)

• etcd/pkg/testutil/testutil.go
  • Line 31: warning: exported function MustNewURLs should have comment or be unexported (golint)
  • Line 43: warning: exported function MustNewURL should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/lease.go
  • Line 50: warning: exported function NewLeaseProxy should have comment or be unexported (golint)

• etcd/clientv3/namespace/kv.go
  • Line 187: warning: receiver name p should be consistent with previous receiver name kv for kvPrefix (golint)

• etcd/etcdctl/ctlv3/command/alarm_command.go
  • Line 37: warning: exported function NewAlarmDisarmCommand should have comment or be unexported (golint)
  • Line 60: warning: exported function NewAlarmListCommand should have comment or be unexported (golint)

• etcd/functional/tester/case_network_blackhole.go
  • Line 19: warning: don't use underscores in Go names; func inject_BLACKHOLE_PEER_PORT_TX_RX should be injectBLACKHOLEPEERPORTTXRX (golint)
  • Line 23: warning: don't use underscores in Go names; func recover_BLACKHOLE_PEER_PORT_TX_RX should be recoverBLACKHOLEPEERPORTTXRX (golint)
  • Line 27: warning: don't use underscores in Go names; func new_Case_BLACKHOLE_PEER_PORT_TX_RX_ONE_FOLLOWER should be newCaseBLACKHOLEPEERPORTTXRXONEFOLLOWER (golint)
  • Line 40: warning: don't use underscores in Go names; func new_Case_BLACKHOLE_PEER_PORT_TX_RX_ONE_FOLLOWER_UNTIL_TRIGGER_SNAPSHOT should be newCaseBLACKHOLEPEERPORTTXRXONEFOLLOWERUNTILTRIGGERSNAPSHOT (golint)
  • Line 53: warning: don't use underscores in Go names; func new_Case_BLACKHOLE_PEER_PORT_TX_RX_LEADER should be newCaseBLACKHOLEPEERPORTTXRXLEADER (golint)
  • Line 66: warning: don't use underscores in Go names; func new_Case_BLACKHOLE_PEER_PORT_TX_RX_LEADER_UNTIL_TRIGGER_SNAPSHOT should be newCaseBLACKHOLEPEERPORTTXRXLEADERUNTILTRIGGERSNAPSHOT (golint)
  • Line 79: warning: don't use underscores in Go names; func new_Case_BLACKHOLE_PEER_PORT_TX_RX_QUORUM should be newCaseBLACKHOLEPEERPORTTXRXQUORUM (golint)
  • Line 94: warning: don't use underscores in Go names; func new_Case_BLACKHOLE_PEER_PORT_TX_RX_ALL should be newCaseBLACKHOLEPEERPORTTXRXALL (golint)

• etcd/pkg/schedule/schedule.go
  • Line 23: warning: exported type Job should have comment or be unexported (golint)

• etcd/pkg/wait/wait.go
  • Line 81: warning: exported function NewWithResponse should have comment or be unexported (golint)

• etcd/wal/wal.go
  • Line 58: warning: exported var ErrMetadataConflict should have comment or be unexported (golint)
  • Line 506: warning: exported method WAL.Close should have comment or be unexported (golint)
  • Line 553: warning: exported method WAL.Save should have comment or be unexported (golint)
  • Line 588: warning: exported method WAL.SaveSnapshot should have comment or be unexported (golint)

• etcd/clientv3/concurrency/mutex.go
  • Line 37: warning: exported function NewMutex should have comment or be unexported (golint)
  • Line 81: warning: exported method Mutex.Unlock should have comment or be unexported (golint)
  • Line 91: warning: exported method Mutex.IsOwner should have comment or be unexported (golint)
  • Line 95: warning: exported method Mutex.Key should have comment or be unexported (golint)

• etcd/etcdserver/raft.go
  • Line 74: warning: exported type RaftTimer should have comment or be unexported (golint)

• etcd/wal/walpb/record.go
  • Line 20: warning: exported var ErrCRCMismatch should have comment or be unexported (golint)
  • Line 23: warning: exported method Record.Validate should have comment or be unexported (golint)

• etcd/pkg/debugutil/pprof.go
  • Line 23: warning: exported const HTTPPrefixPProf should have comment or be unexported (golint)

• etcd/contrib/recipes/double_barrier.go
  • Line 35: warning: exported function NewDoubleBarrier should have comment or be unexported (golint)

• etcd/etcdserver/api/v2http/httptypes/member.go
  • Line 25: warning: exported type Member should have comment or be unexported (golint)
  • Line 32: warning: exported type MemberCreateRequest should have comment or be unexported (golint)
  • Line 36: warning: exported type MemberUpdateRequest should have comment or be unexported (golint)
  • Line 40: warning: exported method MemberCreateRequest.UnmarshalJSON should have comment or be unexported (golint)
  • Line 59: warning: exported type MemberCollection should have comment or be unexported (golint)
  • Line 61: warning: exported method MemberCollection.MarshalJSON should have comment or be unexported (golint)

• etcd/proxy/grpcproxy/adapter/watch_client_adapter.go
  • Line 29: warning: exported function WatchServerToWatchClient should have comment or be unexported (golint)

• etcd/lease/leasehttp/http.go
  • Line 33: warning: exported var LeasePrefix should have comment or be unexported (golint)

• etcd/raft/raft.go
  • Line 44: warning: exported type ReadOnlyOption should have comment or be unexported (golint)

• etcd/raft/raft_test.go
  • Line 1915: warning: don't use underscores in Go names; struct field compact_index should be compactIndex (golint)

• etcd/client/auth_user.go
  • Line 31: warning: exported type User should have comment or be unexported (golint)
  • Line 45: warning: exported type UserRoles should have comment or be unexported (golint)
  • Line 67: warning: exported type AuthAPI should have comment or be unexported (golint)
  • Line 130: warning: exported type AuthUserAPI should have comment or be unexported (golint)

• etcd/clientv3/op.go
  • Line 80: warning: exported method Op.IsTxn should have comment or be unexported (golint)
  • Line 81: warning: exported method Op.Txn should have comment or be unexported (golint)
  • Line 206: warning: exported function OpGet should have comment or be unexported (golint)
  • Line 212: warning: exported function OpDelete should have comment or be unexported (golint)
  • Line 240: warning: exported function OpPut should have comment or be unexported (golint)
  • Line 268: warning: exported function OpTxn should have comment or be unexported (golint)

• etcd/pkg/netutil/netutil.go
  • Line 142: warning: exported function URLStringsEqual should have comment or be unexported (golint)
  • Line 166: warning: exported function IsNetworkTimeoutError should have comment or be unexported (golint)

• etcd/version/version.go
  • Line 29: warning: exported var Version should have comment or be unexported (golint)
  • Line 32: warning: comment on exported var GitSHA should be of the form "GitSHA ..." (golint)
  • Line 43: warning: exported type Versions should have comment or be unexported (golint)

• etcd/contrib/recipes/client.go
  • Line 26: warning: exported var ErrKeyExists should have comment or be unexported (golint)

• etcd/clientv3/sort.go
  • Line 17: warning: exported type SortTarget should have comment or be unexported (golint)
  • Line 18: warning: exported type SortOrder should have comment or be unexported (golint)
  • Line 21: warning: exported const SortNone should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported const SortByKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported type SortOption should have comment or be unexported (golint)

• etcd/etcdserver/stats/server.go
  • Line 33: warning: exported function NewServerStats should have comment or be unexported (golint)
  • Line 74: warning: exported method ServerStats.JSON should have comment or be unexported (golint)
  • Line 130: warning: exported method ServerStats.BecomeLeader should have comment or be unexported (golint)

• etcd/etcdctl/ctlv2/command/ls_command.go
  • Line 24: warning: exported function NewLsCommand should have comment or be unexported (golint)

• etcd/etcdctl/ctlv2/command/role_commands.go
  • Line 28: warning: exported function NewRoleCommands should have comment or be unexported (golint)

• etcd/etcdserver/apply_v2.go
  • Line 39: warning: exported function NewApplierV2 should have comment or be unexported (golint)

• etcd/etcdserver/quota.go
  • Line 58: warning: exported function NewBackendQuota should have comment or be unexported (golint)

• etcd/mvcc/backend/read_tx.go
  • Line 30: warning: exported type ReadTx should have comment or be unexported (golint)

• etcd/contrib/recipes/key.go
  • Line 118: warning: exported method RemoteKV.Key should have comment or be unexported (golint)
  • Line 119: warning: exported method RemoteKV.Revision should have comment or be unexported (golint)
  • Line 120: warning: exported method RemoteKV.Value should have comment or be unexported (golint)
  • Line 122: warning: exported method RemoteKV.Delete should have comment or be unexported (golint)
  • Line 131: warning: exported method RemoteKV.Put should have comment or be unexported (golint)

• etcd/contrib/recipes/rwmutex.go
  • Line 24: warning: exported type RWMutex should have comment or be unexported (golint)
  • Line 32: warning: exported function NewRWMutex should have comment or be unexported (golint)
  • Line 36: warning: exported method RWMutex.RLock should have comment or be unexported (golint)
  • Line 50: warning: exported method RWMutex.Lock should have comment or be unexported (golint)
  • Line 87: warning: exported method RWMutex.RUnlock should have comment or be unexported (golint)
  • Line 88: warning: exported method RWMutex.Unlock should have comment or be unexported (golint)

• etcd/raft/status.go
  • Line 23: warning: exported type Status should have comment or be unexported (golint)

• etcd/etcdserver/api/v3rpc/rpctypes/error.go
  • Line 24: warning: comment on exported var ErrGRPCEmptyKey should be of the form "ErrGRPCEmptyKey ..." (golint)
  • Line 26: warning: exported var ErrGRPCKeyNotFound should have comment or be unexported (golint)
  • Line 120: warning: comment on exported var ErrEmptyKey should be of the form "ErrEmptyKey ..." (golint)
  • Line 185: warning: exported function Error should have comment or be unexported (golint)
  • Line 196: warning: exported function ErrorDesc should have comment or be unexported (golint)

• etcd/etcdserver/api/v3rpc/rpctypes/md.go
  • Line 18: warning: exported var MetadataRequireLeaderKey should have comment or be unexported (golint)

• etcd/etcdserver/auth/auth_test.go
  • Line 31: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 373: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 377: warning: receiver name should not be an underscore, omit the name if it is unused (golint)

gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• etcd/functional/tester/cluster_read_config.go
  • Line 31: warning: cyclomatic complexity 124 of function read() is high (> 15) (gocyclo)

• etcd/etcdserver/apply.go
  • Line 225: warning: cyclomatic complexity 28 of function (*applierV3backend).Range() is high (> 15) (gocyclo)
  • Line 90: warning: cyclomatic complexity 26 of function (*applierV3backend).Apply() is high (> 15) (gocyclo)
  • Line 152: warning: cyclomatic complexity 17 of function (*applierV3backend).Put() is high (> 15) (gocyclo)
  • Line 378: warning: cyclomatic complexity 16 of function applyCompare() is high (> 15) (gocyclo)

• etcd/functional/cmd/etcd-proxy/main.go
  • Line 39: warning: cyclomatic complexity 28 of function main() is high (> 15) (gocyclo)

• etcd/client/client.go
  • Line 525: warning: cyclomatic complexity 17 of function (*simpleHTTPClient).Do() is high (> 15) (gocyclo)

• etcd/e2e/ctl_v3_lock_test.go
  • Line 57: warning: cyclomatic complexity 19 of function testLock() is high (> 15) (gocyclo)

• etcd/integration/v3_double_barrier_test.go
  • Line 25: warning: cyclomatic complexity 17 of function TestDoubleBarrier() is high (> 15) (gocyclo)

• etcd/clientv3/integration/server_shutdown_test.go
  • Line 32: warning: cyclomatic complexity 17 of function TestBalancerUnderServerShutdownWatch() is high (> 15) (gocyclo)

• etcd/functional/tester/cluster_run.go
  • Line 118: warning: cyclomatic complexity 16 of function (*Cluster).doRound() is high (> 15) (gocyclo)

• etcd/pkg/proxy/server_test.go
  • Line 54: warning: cyclomatic complexity 23 of function testServer() is high (> 15) (gocyclo)
  • Line 423: warning: cyclomatic complexity 19 of function testServerHTTP() is high (> 15) (gocyclo)

• etcd/pkg/types/set_test.go
  • Line 40: warning: cyclomatic complexity 19 of function driveSetTests() is high (> 15) (gocyclo)

• etcd/raft/raft.go
  • Line 785: warning: cyclomatic complexity 53 of function stepLeader() is high (> 15) (gocyclo)
  • Line 679: warning: cyclomatic complexity 30 of function (*raft).Step() is high (> 15) (gocyclo)

• etcd/etcdserver/api/v3rpc/util.go
  • Line 32: warning: cyclomatic complexity 36 of function togRPCError() is high (> 15) (gocyclo)

• etcd/e2e/ctl_v3_elect_test.go
  • Line 34: warning: cyclomatic complexity 19 of function testElect() is high (> 15) (gocyclo)

• etcd/etcdserver/server.go
  • Line 254: warning: cyclomatic complexity 51 of function NewServer() is high (> 15) (gocyclo)
  • Line 680: warning: cyclomatic complexity 26 of function (*EtcdServer).run() is high (> 15) (gocyclo)
  • Line 1354: warning: cyclomatic complexity 17 of function (*EtcdServer).applyEntryNormal() is high (> 15) (gocyclo)

• etcd/etcdserver/v3_server.go
  • Line 599: warning: cyclomatic complexity 17 of function (*EtcdServer).linearizableReadLoop() is high (> 15) (gocyclo)

• etcd/snapshot/v3_snapshot.go
  • Line 302: warning: cyclomatic complexity 18 of function (*v3Manager).saveDB() is high (> 15) (gocyclo)

• etcd/wal/wal.go
  • Line 259: warning: cyclomatic complexity 26 of function (*WAL).ReadAll() is high (> 15) (gocyclo)
  • Line 94: warning: cyclomatic complexity 16 of function Create() is high (> 15) (gocyclo)
  • Line 366: warning: cyclomatic complexity 16 of function (*WAL).cut() is high (> 15) (gocyclo)

• etcd/e2e/ctl_v3_txn_test.go
  • Line 99: warning: cyclomatic complexity 17 of function ctlV3Txn() is high (> 15) (gocyclo)

• etcd/functional/runner/election_command.go
  • Line 38: warning: cyclomatic complexity 21 of function runElectionFunc() is high (> 15) (gocyclo)

• etcd/etcdserver/api/v2http/client.go
  • Line 320: warning: cyclomatic complexity 30 of function parseKeyRequest() is high (> 15) (gocyclo)
  • Line 180: warning: cyclomatic complexity 29 of function (*membersHandler).ServeHTTP() is high (> 15) (gocyclo)

• etcd/functional/agent/handler.go
  • Line 255: warning: cyclomatic complexity 25 of function (*Server).saveTLSAssets() is high (> 15) (gocyclo)
  • Line 37: warning: cyclomatic complexity 18 of function (*Server).handleTesterRequest() is high (> 15) (gocyclo)

• etcd/etcdctl/ctlv3/command/get_command.go
  • Line 77: warning: cyclomatic complexity 27 of function getGetOp() is high (> 15) (gocyclo)

• etcd/pkg/adt/interval_tree.go
  • Line 220: warning: cyclomatic complexity 16 of function (*IntervalTree).deleteFixup() is high (> 15) (gocyclo)

• etcd/clientv3/integration/lease_test.go
  • Line 750: warning: cyclomatic complexity 16 of function TestLeaseWithRequireLeader() is high (> 15) (gocyclo)

• etcd/etcdserver/api/v3rpc/watch.go
  • Line 280: warning: cyclomatic complexity 29 of function (*serverWatchStream).sendLoop() is high (> 15) (gocyclo)
  • Line 179: warning: cyclomatic complexity 23 of function (*serverWatchStream).recvLoop() is high (> 15) (gocyclo)

• etcd/e2e/etcd_release_upgrade_test.go
  • Line 31: warning: cyclomatic complexity 16 of function TestReleaseUpgrade() is high (> 15) (gocyclo)

• etcd/rafthttp/msgappv2_codec.go
  • Line 85: warning: cyclomatic complexity 20 of function (*msgAppV2Encoder).encode() is high (> 15) (gocyclo)
  • Line 174: warning: cyclomatic complexity 16 of function (*msgAppV2Decoder).decode() is high (> 15) (gocyclo)

• etcd/embed/etcd.go
  • Line 354: warning: cyclomatic complexity 28 of function startClientListeners() is high (> 15) (gocyclo)

• etcd/e2e/etcd_test.go
  • Line 226: warning: cyclomatic complexity 18 of function (*etcdProcessClusterConfig).etcdProcessConfigs() is high (> 15) (gocyclo)

• etcd/etcdctl/ctlv3/command/check.go
  • Line 98: warning: cyclomatic complexity 16 of function newCheckPerfCommand() is high (> 15) (gocyclo)

• etcd/etcdserver/membership/cluster.go
  • Line 226: warning: cyclomatic complexity 20 of function (*RaftCluster).ValidateConfigurationChange() is high (> 15) (gocyclo)

• etcd/integration/v3_watch_test.go
  • Line 602: warning: cyclomatic complexity 21 of function testV3WatchMultipleWatchers() is high (> 15) (gocyclo)
  • Line 34: warning: cyclomatic complexity 19 of function TestV3WatchFromCurrentRevision() is high (> 15) (gocyclo)
  • Line 463: warning: cyclomatic complexity 16 of function TestV3WatchCurrentPutOverlap() is high (> 15) (gocyclo)

• etcd/rafthttp/stream.go
  • Line 414: warning: cyclomatic complexity 16 of function (*streamReader).dial() is high (> 15) (gocyclo)

• etcd/etcdserver/api/v2http/client_test.go
  • Line 1798: warning: cyclomatic complexity 18 of function TestHandleWatchStreaming() is high (> 15) (gocyclo)

• etcd/pkg/fileutil/purge_test.go
  • Line 93: warning: cyclomatic complexity 22 of function TestPurgeFileHoldingLockFile() is high (> 15) (gocyclo)
  • Line 27: warning: cyclomatic complexity 16 of function TestPurgeFile() is high (> 15) (gocyclo)

• etcd/store/stats.go
  • Line 113: warning: cyclomatic complexity 16 of function (*Stats).Inc() is high (> 15) (gocyclo)

• etcd/integration/v3election_grpc_test.go
  • Line 92: warning: cyclomatic complexity 17 of function TestV3ElectionObserve() is high (> 15) (gocyclo)

• etcd/etcdctl/ctlv3/command/snapshot_command.go
  • Line 305: warning: cyclomatic complexity 18 of function makeDB() is high (> 15) (gocyclo)

• etcd/etcdserver/raft.go
  • Line 163: warning: cyclomatic complexity 27 of function (*raftNode).start() is high (> 15) (gocyclo)

• etcd/mvcc/kv_test.go
  • Line 711: warning: cyclomatic complexity 17 of function TestWatchableKVWatch() is high (> 15) (gocyclo)

• etcd/wal/wal_test.go
  • Line 708: warning: cyclomatic complexity 18 of function TestOpenOnTornWrite() is high (> 15) (gocyclo)
  • Line 394: warning: cyclomatic complexity 16 of function TestRecoverAfterCut() is high (> 15) (gocyclo)

• etcd/e2e/ctl_v3_snapshot_test.go
  • Line 163: warning: cyclomatic complexity 20 of function TestIssue6361() is high (> 15) (gocyclo)

• etcd/lease/leasehttp/http.go
  • Line 49: warning: cyclomatic complexity 19 of function (*leaseHandler).ServeHTTP() is high (> 15) (gocyclo)

• etcd/etcdserver/apply_auth.go
  • Line 161: warning: cyclomatic complexity 17 of function needAdminPermission() is high (> 15) (gocyclo)

• etcd/pkg/proxy/server.go
  • Line 376: warning: cyclomatic complexity 40 of function (*proxyServer).ioCopy() is high (> 15) (gocyclo)
  • Line 252: warning: cyclomatic complexity 31 of function (*proxyServer).listenAndServe() is high (> 15) (gocyclo)

• etcd/raft/raft_test.go
  • Line 470: warning: cyclomatic complexity 18 of function testVoteFromAnyState() is high (> 15) (gocyclo)

• etcd/embed/config.go
  • Line 265: warning: cyclomatic complexity 17 of function (*configYAML).configFromFile() is high (> 15) (gocyclo)

• etcd/clientv3/concurrency/election.go
  • Line 165: warning: cyclomatic complexity 17 of function (*Election).observe() is high (> 15) (gocyclo)

• etcd/clientv3/integration/watch_test.go
  • Line 403: warning: cyclomatic complexity 21 of function TestWatchResumeCompacted() is high (> 15) (gocyclo)
  • Line 73: warning: cyclomatic complexity 21 of function testWatchMultiWatcher() is high (> 15) (gocyclo)
  • Line 583: warning: cyclomatic complexity 16 of function TestWatchEventType() is high (> 15) (gocyclo)

• etcd/clientv3/health_balancer.go
  • Line 306: warning: cyclomatic complexity 21 of function (*healthBalancer).updateNotifyLoop() is high (> 15) (gocyclo)

• etcd/clientv3/yaml/config_test.go
  • Line 33: warning: cyclomatic complexity 17 of function TestConfigFromFile() is high (> 15) (gocyclo)

• etcd/etcdctl/ctlv2/command/cluster_health.go
  • Line 43: warning: cyclomatic complexity 18 of function handleClusterHealth() is high (> 15) (gocyclo)

• etcd/clientv3/client.go
  • Line 386: warning: cyclomatic complexity 22 of function newClient() is high (> 15) (gocyclo)

• etcd/etcdserver/api/v2http/client_auth.go
  • Line 399: warning: cyclomatic complexity 22 of function (*authHandler).forUser() is high (> 15) (gocyclo)
  • Line 243: warning: cyclomatic complexity 17 of function (*authHandler).forRole() is high (> 15) (gocyclo)

• etcd/proxy/grpcproxy/lease.go
  • Line 116: warning: cyclomatic complexity 19 of function (*leaseProxy).LeaseKeepAlive() is high (> 15) (gocyclo)

• etcd/functional/tester/cluster.go
  • Line 151: warning: cyclomatic complexity 36 of function (*Cluster).updateCases() is high (> 15) (gocyclo)
  • Line 446: warning: cyclomatic complexity 18 of function (*Cluster).sendOpWithResp() is high (> 15) (gocyclo)

• etcd/proxy/grpcproxy/watcher.go
  • Line 55: warning: cyclomatic complexity 17 of function (*watcher).send() is high (> 15) (gocyclo)

• etcd/raft/node.go
  • Line 273: warning: cyclomatic complexity 33 of function (*node).run() is high (> 15) (gocyclo)

• etcd/etcdmain/etcd.go
  • Line 57: warning: cyclomatic complexity 28 of function startEtcdOrProxyV2() is high (> 15) (gocyclo)
  • Line 199: warning: cyclomatic complexity 22 of function startProxy() is high (> 15) (gocyclo)

• etcd/etcdserver/api/v3rpc/interceptor.go
  • Line 82: warning: cyclomatic complexity 19 of function logUnaryRequestStats() is high (> 15) (gocyclo)

• etcd/etcdctl/ctlv3/command/make_mirror_command.go
  • Line 82: warning: cyclomatic complexity 21 of function makeMirror() is high (> 15) (gocyclo)

• etcd/wal/repair_test.go
  • Line 44: warning: cyclomatic complexity 19 of function testRepair() is high (> 15) (gocyclo)

• etcd/integration/v3_lock_test.go
  • Line 109: warning: cyclomatic complexity 24 of function TestMutexWaitsOnCurrentHolder() is high (> 15) (gocyclo)
  • Line 238: warning: cyclomatic complexity 16 of function testRWMutex() is high (> 15) (gocyclo)

• etcd/clientv3/watch.go
  • Line 399: warning: cyclomatic complexity 28 of function (*watchGrpcStream).run() is high (> 15) (gocyclo)
  • Line 582: warning: cyclomatic complexity 19 of function (*watchGrpcStream).serveSubstream() is high (> 15) (gocyclo)

• etcd/proxy/grpcproxy/watch.go
  • Line 71: warning: cyclomatic complexity 16 of function (*watchProxy).Watch() is high (> 15) (gocyclo)

• etcd/mvcc/index_test.go
  • Line 196: warning: cyclomatic complexity 17 of function TestIndexCompact() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!