Preparing report...

Report for github.com/skuid/picard

A    Great!    Found 24 issues across 40 files

Tweet

gofmt72%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo87%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • picard/filter.go
    • Line 221: warning: cyclomatic complexity 18 of function (PersistenceORM).FilterModel() is high (> 15) (gocyclo)
    • picard/picard.go
    • Line 930: warning: cyclomatic complexity 30 of function (PersistenceORM).processObject() is high (> 15) (gocyclo)
    • Line 152: warning: cyclomatic complexity 19 of function (PersistenceORM).upsert() is high (> 15) (gocyclo)
    • Line 690: warning: cyclomatic complexity 19 of function (PersistenceORM).performChildUpserts() is high (> 15) (gocyclo)

golint70%

Golint is a linter for Go source code.

    • picard/crypto/crypto.go
    • Line 14: warning: exported function SetEncryptionKey should have comment or be unexported (golint)
    • Line 22: warning: exported function GetEncryptionKey should have comment or be unexported (golint)
    • Line 29: warning: exported function GenerateNewEncryptionKey should have comment or be unexported (golint)
    • Line 38: warning: exported function EncryptBytes should have comment or be unexported (golint)
    • Line 64: warning: exported function DecryptBytes should have comment or be unexported (golint)
    • picard/picard_test/mock.go
    • Line 1: warning: package comment should be of the form "Package picard_test ..." (golint)
    • Line 195: warning: comment on exported method MultiMockORM.Rollback should be of the form "Rollback ..." (golint)
    • picard/tags/tags.go
    • Line 19: warning: comment on exported type Association should be of the form "Association ..." (with optional leading article) (golint)
    • Line 221: warning: comment on exported type FieldFilter should be of the form "FieldFilter ..." (with optional leading article) (golint)
    • picard/doc.go
    • Line 1: warning: package comment should be of the form "Package picard ..." (golint)
    • picard/picard.go
    • Line 61: warning: comment on exported method PersistenceORM.StartTransaction should be of the form "StartTransaction ..." (golint)
    • picard/metadata/metadata.go
    • Line 10: warning: exported type Metadata should have comment or be unexported (golint)
    • Line 14: warning: exported function AddDefinedField should have comment or be unexported (golint)
    • Line 22: warning: exported function HasDefinedFields should have comment or be unexported (golint)
    • Line 30: warning: exported function InitializeDefinedFields should have comment or be unexported (golint)
    • Line 37: warning: exported function GetMetadataValue should have comment or be unexported (golint)
    • Line 50: warning: exported function GetMetadataFromPicardStruct should have comment or be unexported (golint)
    • picard/filter.go
    • Line 15: warning: comment on exported type FilterRequest should be of the form "FilterRequest ..." (with optional leading article) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign95%

IneffAssign detects ineffectual assignments in Go code.


misspell95%

Misspell Finds commonly misspelled English words