Preparing report...

Report for github.com/sm-operator/sapcp-operator

A+    Excellent!    Found 13 issues across 37 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint64%

Golint is a linter for Go source code.

    • sapcp-operator/internal/secrets/resolver.go
    • Line 17: warning: exported const SAPCPOperatorSecretName should have comment (or a comment on this block) or be unexported (golint)
    • Line 20: warning: exported type SecretResolver should have comment or be unexported (golint)
    • Line 27: warning: exported method SecretResolver.GetSecretForResource should have comment or be unexported (golint)
    • sapcp-operator/api/v1alpha1/types.go
    • Line 9: warning: exported type ControllerName should have comment or be unexported (golint)
    • Line 12: warning: exported const ServiceInstanceController should have comment (or a comment on this block) or be unexported (golint)
    • Line 24: warning: comment on exported type SAPCPResource should be of the form "SAPCPResource ..." (with optional leading article) (golint)
    • sapcp-operator/internal/smclient/client.go
    • Line 64: warning: exported type ServiceManagerError should have comment or be unexported (golint)
    • Line 79: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 374: warning: exported function ExtractInstanceID should have comment or be unexported (golint)
    • Line 383: warning: exported function ExtractBindingID should have comment or be unexported (golint)
    • Line 392: warning: exported function BuildOperationURL should have comment or be unexported (golint)
    • sapcp-operator/api/v1alpha1/servicebinding_types.go
    • Line 52: warning: comment on exported type ServiceBindingStatus should be of the form "ServiceBindingStatus ..." (with optional leading article) (golint)
    • Line 96: warning: exported method ServiceBinding.GetConditions should have comment or be unexported (golint)
    • Line 100: warning: exported method ServiceBinding.SetConditions should have comment or be unexported (golint)
    • Line 104: warning: exported method ServiceBinding.GetControllerName should have comment or be unexported (golint)
    • Line 108: warning: exported method ServiceBinding.GetParameters should have comment or be unexported (golint)
    • Line 112: warning: exported method ServiceBinding.GetStatus should have comment or be unexported (golint)
    • Line 116: warning: exported method ServiceBinding.SetStatus should have comment or be unexported (golint)
    • Line 120: warning: exported method ServiceBinding.GetObservedGeneration should have comment or be unexported (golint)
    • Line 124: warning: exported method ServiceBinding.SetObservedGeneration should have comment or be unexported (golint)
    • Line 128: warning: exported method ServiceBinding.DeepClone should have comment or be unexported (golint)
    • sapcp-operator/api/v1alpha1/serviceinstance_types.go
    • Line 93: warning: exported method ServiceInstance.GetConditions should have comment or be unexported (golint)
    • Line 97: warning: exported method ServiceInstance.SetConditions should have comment or be unexported (golint)
    • Line 101: warning: exported method ServiceInstance.GetControllerName should have comment or be unexported (golint)
    • Line 105: warning: exported method ServiceInstance.GetParameters should have comment or be unexported (golint)
    • Line 109: warning: exported method ServiceInstance.GetStatus should have comment or be unexported (golint)
    • Line 113: warning: exported method ServiceInstance.SetStatus should have comment or be unexported (golint)
    • Line 117: warning: exported method ServiceInstance.GetObservedGeneration should have comment or be unexported (golint)
    • Line 121: warning: exported method ServiceInstance.SetObservedGeneration should have comment or be unexported (golint)
    • Line 125: warning: exported method ServiceInstance.DeepClone should have comment or be unexported (golint)
    • sapcp-operator/controllers/servicebinding_controller.go
    • Line 53: warning: exported method ServiceBindingReconciler.Reconcile should have comment or be unexported (golint)
    • Line 371: warning: exported method ServiceBindingReconciler.SetOwner should have comment or be unexported (golint)
    • Line 420: warning: exported method ServiceBindingReconciler.SetupWithManager should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!