gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• asserts/snapasserts/validation_sets.go
  • Line 362: warning: cyclomatic complexity 29 of function (*ValidationSets).CheckInstalledSnaps() is high (> 15) (gocyclo)

• cmd/snap/cmd_routine_file_access.go
  • Line 146: warning: cyclomatic complexity 20 of function (*cmdRoutineFileAccess).checkAccess() is high (> 15) (gocyclo)

• strutil/quantity/quantity.go
  • Line 115: warning: cyclomatic complexity 21 of function FormatDuration() is high (> 15) (gocyclo)

• overlord/configstate/configcore/refresh.go
  • Line 57: warning: cyclomatic complexity 20 of function validateRefreshSchedule() is high (> 15) (gocyclo)

• overlord/patch/patch.go
  • Line 98: warning: cyclomatic complexity 18 of function Apply() is high (> 15) (gocyclo)

• overlord/hookstate/ctlcmd/mount.go
  • Line 77: warning: cyclomatic complexity 18 of function (*mountCommand).matchConnection() is high (> 15) (gocyclo)

• overlord/snapstate/handlers.go
  • Line 1439: warning: cyclomatic complexity 58 of function (*SnapManager).doLinkSnap() is high (> 15) (gocyclo)
  • Line 1863: warning: cyclomatic complexity 45 of function (*SnapManager).undoLinkSnap() is high (> 15) (gocyclo)
  • Line 2867: warning: cyclomatic complexity 25 of function (*SnapManager).undoRefreshAliases() is high (> 15) (gocyclo)
  • Line 2600: warning: cyclomatic complexity 25 of function (*SnapManager).doDiscardSnap() is high (> 15) (gocyclo)
  • Line 1101: warning: cyclomatic complexity 20 of function (*SnapManager).doCopySnapData() is high (> 15) (gocyclo)
  • Line 800: warning: cyclomatic complexity 20 of function (*SnapManager).doMountSnap() is high (> 15) (gocyclo)
  • Line 571: warning: cyclomatic complexity 18 of function (*SnapManager).undoPrepareSnap() is high (> 15) (gocyclo)
  • Line 445: warning: cyclomatic complexity 17 of function (*SnapManager).installPrereqs() is high (> 15) (gocyclo)
  • Line 3182: warning: cyclomatic complexity 17 of function (*SnapManager).doPreferAliases() is high (> 15) (gocyclo)
  • Line 3362: warning: cyclomatic complexity 16 of function (*SnapManager).doCheckReRefresh() is high (> 15) (gocyclo)
  • Line 1208: warning: cyclomatic complexity 16 of function (*SnapManager).undoCopySnapData() is high (> 15) (gocyclo)

• snap/container.go
  • Line 82: warning: cyclomatic complexity 38 of function ValidateContainer() is high (> 15) (gocyclo)

• daemon/api_connections.go
  • Line 105: warning: cyclomatic complexity 25 of function collectConnections() is high (> 15) (gocyclo)

• asserts/gpgkeypairmgr.go
  • Line 166: warning: cyclomatic complexity 20 of function (*GPGKeypairManager).Walk() is high (> 15) (gocyclo)

• overlord/servicestate/service_control_test.go
  • Line 130: warning: cyclomatic complexity 19 of function verifyControlTasks() is high (> 15) (gocyclo)

• boot/seal.go
  • Line 386: warning: cyclomatic complexity 18 of function resealKeyToModeenvSecboot() is high (> 15) (gocyclo)

• overlord/managers_test.go
  • Line 968: warning: cyclomatic complexity 32 of function (*baseMgrsSuite).mockStore() is high (> 15) (gocyclo)
  • Line 6777: warning: cyclomatic complexity 21 of function (*mgrsSuite).testRemodelUC20WithRecoverySystem() is high (> 15) (gocyclo)

• gadget/install/install.go
  • Line 76: warning: cyclomatic complexity 30 of function Run() is high (> 15) (gocyclo)

• cmd/snap-preseed/reset.go
  • Line 34: warning: cyclomatic complexity 24 of function resetPreseededChroot() is high (> 15) (gocyclo)

• overlord/ifacestate/hotplug.go
  • Line 108: warning: cyclomatic complexity 25 of function (*InterfaceManager).hotplugDeviceAdded() is high (> 15) (gocyclo)

• asserts/system_user.go
  • Line 219: warning: cyclomatic complexity 22 of function assembleSystemUser() is high (> 15) (gocyclo)

• store/errors.go
  • Line 179: warning: cyclomatic complexity 21 of function (SnapActionError).Error() is high (> 15) (gocyclo)

• osutil/user.go
  • Line 73: warning: cyclomatic complexity 20 of function EnsureUserGroup() is high (> 15) (gocyclo)
  • Line 182: warning: cyclomatic complexity 16 of function AddUser() is high (> 15) (gocyclo)

• cmd/snap/main.go
  • Line 246: warning: cyclomatic complexity 18 of function registerCommands() is high (> 15) (gocyclo)

• interfaces/utils/path_patterns.go
  • Line 44: warning: cyclomatic complexity 32 of function createRegex() is high (> 15) (gocyclo)

• testutil/syscallschecker.go
  • Line 38: warning: cyclomatic complexity 27 of function (*syscallsEqualChecker).Check() is high (> 15) (gocyclo)

• cmd/snap-repair/runner.go
  • Line 878: warning: cyclomatic complexity 26 of function (*Runner).Applicable() is high (> 15) (gocyclo)
  • Line 109: warning: cyclomatic complexity 18 of function (*Repair).Run() is high (> 15) (gocyclo)
  • Line 337: warning: cyclomatic complexity 16 of function (*Runner).Fetch() is high (> 15) (gocyclo)

• docs/error-kinds.go
  • Line 27: warning: cyclomatic complexity 16 of function main() is high (> 15) (gocyclo)

• daemon/api_aliases.go
  • Line 54: warning: cyclomatic complexity 16 of function changeAliases() is high (> 15) (gocyclo)

• overlord/ifacestate/ifacemgr.go
  • Line 326: warning: cyclomatic complexity 26 of function (*InterfaceManager).ResolveDisconnect() is high (> 15) (gocyclo)

• overlord/servicestate/quota_handlers.go
  • Line 408: warning: cyclomatic complexity 20 of function ensureSnapServicesForGroup() is high (> 15) (gocyclo)

• overlord/assertstate/assertstate_test.go
  • Line 110: warning: cyclomatic complexity 19 of function (*fakeStore).SnapAction() is high (> 15) (gocyclo)

• overlord/hookstate/ctlcmd/health.go
  • Line 82: warning: cyclomatic complexity 16 of function (*healthCommand).Execute() is high (> 15) (gocyclo)

• snap/squashfs/stat.go
  • Line 283: warning: cyclomatic complexity 16 of function (*stat).parseSize() is high (> 15) (gocyclo)

• tests/lib/fakestore/store/store.go
  • Line 624: warning: cyclomatic complexity 16 of function (*Store).snapActionEndpoint() is high (> 15) (gocyclo)

• gadget/update.go
  • Line 226: warning: cyclomatic complexity 51 of function EnsureLayoutCompatibility() is high (> 15) (gocyclo)
  • Line 977: warning: cyclomatic complexity 19 of function applyUpdates() is high (> 15) (gocyclo)
  • Line 527: warning: cyclomatic complexity 17 of function DiskTraitsFromDeviceAndValidate() is high (> 15) (gocyclo)
  • Line 828: warning: cyclomatic complexity 16 of function canUpdateStructure() is high (> 15) (gocyclo)
  • Line 710: warning: cyclomatic complexity 16 of function Update() is high (> 15) (gocyclo)

• cmd/snap/cmd_interfaces.go
  • Line 79: warning: cyclomatic complexity 37 of function (*cmdInterfaces).Execute() is high (> 15) (gocyclo)

• cmd/snap/wait.go
  • Line 52: warning: cyclomatic complexity 22 of function (waitMixin).wait() is high (> 15) (gocyclo)

• overlord/configstate/configcore/services.go
  • Line 146: warning: cyclomatic complexity 17 of function switchDisableService() is high (> 15) (gocyclo)

• overlord/patch/patch6_1.go
  • Line 42: warning: cyclomatic complexity 16 of function processConns() is high (> 15) (gocyclo)

• overlord/devicestate/firstboot.go
  • Line 93: warning: cyclomatic complexity 35 of function populateStateFromSeedImpl() is high (> 15) (gocyclo)

• osutil/disks/mockdisk.go
  • Line 185: warning: cyclomatic complexity 24 of function checkMockDiskMappingsForDuplicates() is high (> 15) (gocyclo)

• polkit/validate/validate.go
  • Line 165: warning: cyclomatic complexity 19 of function validateAction() is high (> 15) (gocyclo)

• overlord/ifacestate/handlers.go
  • Line 389: warning: cyclomatic complexity 32 of function (*InterfaceManager).doConnect() is high (> 15) (gocyclo)
  • Line 1099: warning: cyclomatic complexity 32 of function (*InterfaceManager).doAutoConnect() is high (> 15) (gocyclo)
  • Line 539: warning: cyclomatic complexity 24 of function (*InterfaceManager).doDisconnect() is high (> 15) (gocyclo)
  • Line 1404: warning: cyclomatic complexity 21 of function (*InterfaceManager).doHotplugConnect() is high (> 15) (gocyclo)
  • Line 824: warning: cyclomatic complexity 20 of function checkAutoconnectConflicts() is high (> 15) (gocyclo)
  • Line 726: warning: cyclomatic complexity 18 of function (*InterfaceManager).undoConnect() is high (> 15) (gocyclo)
  • Line 646: warning: cyclomatic complexity 17 of function (*InterfaceManager).undoDisconnect() is high (> 15) (gocyclo)

• osutil/disks/disks_linux_test.go
  • Line 1090: warning: cyclomatic complexity 21 of function (*diskSuite).TestDiskFromMountPointDecryptedDevicePartitionsHappy() is high (> 15) (gocyclo)
  • Line 921: warning: cyclomatic complexity 19 of function (*diskSuite).TestDiskFromMountPointPartitionsHappy() is high (> 15) (gocyclo)

• cmd/snap-bootstrap/triggerwatch/evdev.go
  • Line 90: warning: cyclomatic complexity 19 of function (*evdevKeyboardInputDevice).WaitForTrigger() is high (> 15) (gocyclo)

• daemon/api_snaps.go
  • Line 494: warning: cyclomatic complexity 16 of function snapOpMany() is high (> 15) (gocyclo)

• overlord/snapstate/autorefresh_gating.go
  • Line 440: warning: cyclomatic complexity 41 of function affectedByRefresh() is high (> 15) (gocyclo)

• store/store_download.go
  • Line 217: warning: cyclomatic complexity 32 of function (*Store).Download() is high (> 15) (gocyclo)
  • Line 460: warning: cyclomatic complexity 32 of function downloadImpl() is high (> 15) (gocyclo)

• overlord/ifacestate/helpers.go
  • Line 262: warning: cyclomatic complexity 25 of function (*InterfaceManager).reloadConnections() is high (> 15) (gocyclo)
  • Line 517: warning: cyclomatic complexity 22 of function (*gadgetConnect).addGadgetConnections() is high (> 15) (gocyclo)

• snap/squashfs/squashfs.go
  • Line 304: warning: cyclomatic complexity 19 of function (*Snap).Walk() is high (> 15) (gocyclo)

• overlord/assertstate/bulk.go
  • Line 248: warning: cyclomatic complexity 18 of function resolvePool() is high (> 15) (gocyclo)
  • Line 47: warning: cyclomatic complexity 18 of function bulkRefreshSnapDeclarations() is high (> 15) (gocyclo)

• seed/seedwriter/writer.go
  • Line 873: warning: cyclomatic complexity 18 of function (*Writer).downloaded() is high (> 15) (gocyclo)
  • Line 354: warning: cyclomatic complexity 16 of function (*Writer).SetOptionsSnaps() is high (> 15) (gocyclo)
  • Line 945: warning: cyclomatic complexity 16 of function (*Writer).Downloaded() is high (> 15) (gocyclo)

• daemon/api_snaps_test.go
  • Line 94: warning: cyclomatic complexity 16 of function (*snapsSuite).checkSnapsInfoIntegration() is high (> 15) (gocyclo)

• overlord/snapstate/snapstate_install_test.go
  • Line 63: warning: cyclomatic complexity 16 of function expectedDoInstallTasks() is high (> 15) (gocyclo)

• overlord/devicestate/devicestatetest/devicesvc.go
  • Line 63: warning: cyclomatic complexity 29 of function MockDeviceService() is high (> 15) (gocyclo)

• osutil/kcmdline.go
  • Line 48: warning: cyclomatic complexity 29 of function KernelCommandLineSplit() is high (> 15) (gocyclo)

• overlord/hookstate/hookmgr.go
  • Line 332: warning: cyclomatic complexity 23 of function (*HookManager).runHook() is high (> 15) (gocyclo)

• wrappers/core18.go
  • Line 141: warning: cyclomatic complexity 35 of function AddSnapdSnapServices() is high (> 15) (gocyclo)
  • Line 321: warning: cyclomatic complexity 21 of function undoSnapdServicesOnCore() is high (> 15) (gocyclo)

• overlord/servicestate/service_control.go
  • Line 60: warning: cyclomatic complexity 27 of function (*ServiceManager).doServiceControl() is high (> 15) (gocyclo)

• overlord/devicestate/handlers_systems.go
  • Line 122: warning: cyclomatic complexity 25 of function (*DeviceManager).doCreateRecoverySystem() is high (> 15) (gocyclo)

• overlord/configstate/configcore/journal.go
  • Line 46: warning: cyclomatic complexity 17 of function handleJournalConfiguration() is high (> 15) (gocyclo)

• osutil/synctree.go
  • Line 90: warning: cyclomatic complexity 24 of function EnsureTreeState() is high (> 15) (gocyclo)

• overlord/snapstate/aliasesv2.go
  • Line 447: warning: cyclomatic complexity 19 of function (*SnapManager).ensureAliasesV2() is high (> 15) (gocyclo)
  • Line 151: warning: cyclomatic complexity 16 of function autoAliasesDelta() is high (> 15) (gocyclo)

• metautil/normalize.go
  • Line 29: warning: cyclomatic complexity 17 of function NormalizeValue() is high (> 15) (gocyclo)

• sysconfig/cloudinit.go
  • Line 451: warning: cyclomatic complexity 27 of function configureCloudInit() is high (> 15) (gocyclo)

• overlord/snapstate/snapstate_update_test.go
  • Line 3681: warning: cyclomatic complexity 25 of function (*snapmgrTestSuite).TestUpdateManyAutoAliasesScenarios() is high (> 15) (gocyclo)
  • Line 3831: warning: cyclomatic complexity 21 of function (*snapmgrTestSuite).TestUpdateOneAutoAliasesScenarios() is high (> 15) (gocyclo)
  • Line 7667: warning: cyclomatic complexity 16 of function (*snapmgrTestSuite).TestUpdateBaseKernelSingleRebootHappy() is high (> 15) (gocyclo)

• boot/makebootable.go
  • Line 302: warning: cyclomatic complexity 24 of function MakeRunnableSystem() is high (> 15) (gocyclo)

• daemon/api_apps.go
  • Line 111: warning: cyclomatic complexity 17 of function appInfosFor() is high (> 15) (gocyclo)

• interfaces/udev/backend.go
  • Line 72: warning: cyclomatic complexity 16 of function (*Backend).Setup() is high (> 15) (gocyclo)

• overlord/devicestate/systems.go
  • Line 211: warning: cyclomatic complexity 47 of function createSystemForModelFromValidatedSnaps() is high (> 15) (gocyclo)

• overlord/snapstate/storehelpers.go
  • Line 572: warning: cyclomatic complexity 34 of function refreshCandidates() is high (> 15) (gocyclo)
  • Line 100: warning: cyclomatic complexity 21 of function installSize() is high (> 15) (gocyclo)
  • Line 225: warning: cyclomatic complexity 18 of function installInfo() is high (> 15) (gocyclo)
  • Line 307: warning: cyclomatic complexity 16 of function updateInfo() is high (> 15) (gocyclo)

• overlord/devicestate/handlers_install.go
  • Line 224: warning: cyclomatic complexity 28 of function (*DeviceManager).doSetupRunSystem() is high (> 15) (gocyclo)

• cmd/snap/cmd_routine_portal_info.go
  • Line 66: warning: cyclomatic complexity 20 of function (*cmdRoutinePortalInfo).Execute() is high (> 15) (gocyclo)

• overlord/snapstate/check_snap.go
  • Line 342: warning: cyclomatic complexity 16 of function checkGadgetOrKernel() is high (> 15) (gocyclo)

• cmd/snap/error.go
  • Line 90: warning: cyclomatic complexity 53 of function errorToCmdMessage() is high (> 15) (gocyclo)

• overlord/devicestate/handlers_gadget.go
  • Line 83: warning: cyclomatic complexity 26 of function (*DeviceManager).doUpdateGadgetAssets() is high (> 15) (gocyclo)

• gadget/validate.go
  • Line 176: warning: cyclomatic complexity 21 of function ensureRolesConsistency() is high (> 15) (gocyclo)

• overlord/servicestate/servicestate.go
  • Line 269: warning: cyclomatic complexity 18 of function (*StatusDecorator).DecorateWithStatus() is high (> 15) (gocyclo)
  • Line 166: warning: cyclomatic complexity 17 of function Control() is high (> 15) (gocyclo)
  • Line 75: warning: cyclomatic complexity 16 of function serviceControlTs() is high (> 15) (gocyclo)

• interfaces/builtin/all.go
  • Line 68: warning: cyclomatic complexity 17 of function SanitizePlugsSlots() is high (> 15) (gocyclo)

• asserts/constraint.go
  • Line 426: warning: cyclomatic complexity 16 of function (*DeviceScopeConstraint).Check() is high (> 15) (gocyclo)

• cmd/snap/cmd_model.go
  • Line 107: warning: cyclomatic complexity 58 of function (*cmdModel).Execute() is high (> 15) (gocyclo)

• overlord/assertstate/assertstate.go
  • Line 379: warning: cyclomatic complexity 27 of function RefreshValidationSetAssertions() is high (> 15) (gocyclo)
  • Line 143: warning: cyclomatic complexity 22 of function ValidateRefreshes() is high (> 15) (gocyclo)
  • Line 603: warning: cyclomatic complexity 21 of function validationSetAssertionForEnforce() is high (> 15) (gocyclo)
  • Line 512: warning: cyclomatic complexity 18 of function validationSetAssertionForMonitor() is high (> 15) (gocyclo)

• overlord/snapstate/autorefresh.go
  • Line 269: warning: cyclomatic complexity 22 of function (*autoRefresh).Ensure() is high (> 15) (gocyclo)

• daemon/api_interfaces.go
  • Line 125: warning: cyclomatic complexity 30 of function changeInterfaces() is high (> 15) (gocyclo)

• cmd/snap/cmd_connections.go
  • Line 134: warning: cyclomatic complexity 18 of function (*cmdConnections).Execute() is high (> 15) (gocyclo)

• overlord/state/taskrunner.go
  • Line 350: warning: cyclomatic complexity 22 of function (*TaskRunner).Ensure() is high (> 15) (gocyclo)
  • Line 170: warning: cyclomatic complexity 21 of function (*TaskRunner).run() is high (> 15) (gocyclo)

• overlord/state/state.go
  • Line 370: warning: cyclomatic complexity 17 of function (*State).Prune() is high (> 15) (gocyclo)

• cmd/snap-bootstrap/cmd_initramfs_mounts.go
  • Line 1049: warning: cyclomatic complexity 27 of function generateMountsModeRecover() is high (> 15) (gocyclo)
  • Line 1414: warning: cyclomatic complexity 25 of function generateMountsModeRun() is high (> 15) (gocyclo)
  • Line 611: warning: cyclomatic complexity 16 of function (*recoverModeStateMachine).setUnlockStateWithFallbackKey() is high (> 15) (gocyclo)

• overlord/devicestate/handlers_serial.go
  • Line 649: warning: cyclomatic complexity 20 of function (*DeviceManager).doRequestSerial() is high (> 15) (gocyclo)
  • Line 484: warning: cyclomatic complexity 17 of function getSerial() is high (> 15) (gocyclo)
  • Line 583: warning: cyclomatic complexity 16 of function getSerialRequestConfig() is high (> 15) (gocyclo)
  • Line 314: warning: cyclomatic complexity 16 of function prepareSerialRequest() is high (> 15) (gocyclo)

• snap/snapdir/snapdir.go
  • Line 115: warning: cyclomatic complexity 19 of function (*SnapDir).Walk() is high (> 15) (gocyclo)

• gadget/gadget.go
  • Line 613: warning: cyclomatic complexity 19 of function setImplicitForVolumeStructure() is high (> 15) (gocyclo)
  • Line 506: warning: cyclomatic complexity 19 of function InfoFromGadgetYaml() is high (> 15) (gocyclo)
  • Line 951: warning: cyclomatic complexity 17 of function validateRole() is high (> 15) (gocyclo)
  • Line 888: warning: cyclomatic complexity 16 of function validateStructureType() is high (> 15) (gocyclo)

• cmd/snap-seccomp/main_test.go
  • Line 225: warning: cyclomatic complexity 19 of function (*snapSeccompSuite).runBpf() is high (> 15) (gocyclo)

• overlord/devicestate/devicestate.go
  • Line 543: warning: cyclomatic complexity 47 of function remodelTasks() is high (> 15) (gocyclo)
  • Line 849: warning: cyclomatic complexity 30 of function Remodel() is high (> 15) (gocyclo)
  • Line 420: warning: cyclomatic complexity 22 of function remodelEssentialSnapTasks() is high (> 15) (gocyclo)

• seed/seed16.go
  • Line 214: warning: cyclomatic complexity 31 of function (*seed16).loadEssentialMeta() is high (> 15) (gocyclo)

• store/store.go
  • Line 1174: warning: cyclomatic complexity 27 of function (*Store).Find() is high (> 15) (gocyclo)
  • Line 1495: warning: cyclomatic complexity 16 of function (*Store).Buy() is high (> 15) (gocyclo)

• overlord/configstate/configcore/swap.go
  • Line 79: warning: cyclomatic complexity 16 of function handlesystemSwapConfiguration() is high (> 15) (gocyclo)

• seed/internal/options20.go
  • Line 63: warning: cyclomatic complexity 16 of function ReadOptions20() is high (> 15) (gocyclo)

• daemon/errors.go
  • Line 277: warning: cyclomatic complexity 23 of function errToResponse() is high (> 15) (gocyclo)

• asserts/repair.go
  • Line 125: warning: cyclomatic complexity 21 of function assembleRepair() is high (> 15) (gocyclo)

• overlord/patch/patch6_3.go
  • Line 44: warning: cyclomatic complexity 19 of function patch6_3() is high (> 15) (gocyclo)

• httputil/retry.go
  • Line 107: warning: cyclomatic complexity 19 of function ShouldRetryError() is high (> 15) (gocyclo)

• cmd/snapctl/main.go
  • Line 42: warning: cyclomatic complexity 18 of function main() is high (> 15) (gocyclo)

• snap/validate.go
  • Line 945: warning: cyclomatic complexity 31 of function ValidateLayout() is high (> 15) (gocyclo)
  • Line 702: warning: cyclomatic complexity 29 of function ValidateApp() is high (> 15) (gocyclo)
  • Line 301: warning: cyclomatic complexity 23 of function Validate() is high (> 15) (gocyclo)
  • Line 421: warning: cyclomatic complexity 19 of function ValidateLayoutAll() is high (> 15) (gocyclo)

• interfaces/apparmor/backend.go
  • Line 679: warning: cyclomatic complexity 26 of function addContent() is high (> 15) (gocyclo)
  • Line 384: warning: cyclomatic complexity 25 of function (*Backend).prepareProfiles() is high (> 15) (gocyclo)
  • Line 85: warning: cyclomatic complexity 21 of function (*Backend).Initialize() is high (> 15) (gocyclo)

• cmd/snap/cmd_find.go
  • Line 180: warning: cyclomatic complexity 23 of function (*cmdFind).Execute() is high (> 15) (gocyclo)

• daemon/api_sideload_n_try.go
  • Line 313: warning: cyclomatic complexity 16 of function readForm() is high (> 15) (gocyclo)

• store/details_v2.go
  • Line 178: warning: cyclomatic complexity 26 of function copyNonZeroFrom() is high (> 15) (gocyclo)

• overlord/configstate/configcore/vitality.go
  • Line 46: warning: cyclomatic complexity 23 of function handleVitalityConfiguration() is high (> 15) (gocyclo)

• overlord/devicestate/handlers_remodel.go
  • Line 55: warning: cyclomatic complexity 21 of function (*DeviceManager).doSetModel() is high (> 15) (gocyclo)

• cmd/snap-failure/cmd_snapd.go
  • Line 116: warning: cyclomatic complexity 19 of function (*cmdSnapd).Execute() is high (> 15) (gocyclo)

• store/store_action.go
  • Line 303: warning: cyclomatic complexity 70 of function (*Store).snapAction() is high (> 15) (gocyclo)
  • Line 214: warning: cyclomatic complexity 17 of function (*Store).SnapAction() is high (> 15) (gocyclo)

• overlord/state/taskrunner_test.go
  • Line 150: warning: cyclomatic complexity 47 of function (*taskRunnerSuite).TestSequenceTests() is high (> 15) (gocyclo)

• overlord/servicestate/servicemgr.go
  • Line 78: warning: cyclomatic complexity 26 of function (*ServiceManager).ensureSnapServicesUpdated() is high (> 15) (gocyclo)
  • Line 232: warning: cyclomatic complexity 16 of function restartServicesKilledInSnapdSnapRefresh() is high (> 15) (gocyclo)

• cmd/snap/cmd_debug_state.go
  • Line 282: warning: cyclomatic complexity 18 of function (*cmdDebugState).Execute() is high (> 15) (gocyclo)

• overlord/snapstate/backend_test.go
  • Line 332: warning: cyclomatic complexity 39 of function (*fakeStore).lookupRefresh() is high (> 15) (gocyclo)
  • Line 487: warning: cyclomatic complexity 37 of function (*fakeStore).SnapAction() is high (> 15) (gocyclo)
  • Line 208: warning: cyclomatic complexity 22 of function (*fakeStore).snap() is high (> 15) (gocyclo)
  • Line 841: warning: cyclomatic complexity 18 of function (*fakeSnappyBackend).ReadInfo() is high (> 15) (gocyclo)

• cmd/snap-update-ns/change.go
  • Line 285: warning: cyclomatic complexity 38 of function (*Change).lowLevelPerform() is high (> 15) (gocyclo)
  • Line 490: warning: cyclomatic complexity 20 of function neededChangesOld() is high (> 15) (gocyclo)

• spdx/parser.go
  • Line 72: warning: cyclomatic complexity 25 of function (*parser).validate() is high (> 15) (gocyclo)

• overlord/configstate/configcore/netplan.go
  • Line 159: warning: cyclomatic complexity 21 of function handleNetplanConfiguration() is high (> 15) (gocyclo)

• seed/seedwriter/seed20.go
  • Line 211: warning: cyclomatic complexity 20 of function (*tree20).writeAssertions() is high (> 15) (gocyclo)
  • Line 313: warning: cyclomatic complexity 19 of function (*tree20).writeMeta() is high (> 15) (gocyclo)

• overlord/hookstate/ctlcmd/get.go
  • Line 278: warning: cyclomatic complexity 18 of function (*getCommand).getInterfaceSetting() is high (> 15) (gocyclo)

• testutil/filecontentchecker.go
  • Line 79: warning: cyclomatic complexity 16 of function fileContentCheck() is high (> 15) (gocyclo)

• overlord/hookstate/ctlcmd/is_connected.go
  • Line 90: warning: cyclomatic complexity 28 of function (*isConnectedCommand).Execute() is high (> 15) (gocyclo)

• overlord/patch/patch6_2.go
  • Line 109: warning: cyclomatic complexity 21 of function patch6_2() is high (> 15) (gocyclo)

• snap/info_snap_yaml.go
  • Line 350: warning: cyclomatic complexity 21 of function setAppsFromSnapYaml() is high (> 15) (gocyclo)

• overlord/devicestate/firstboot_preseed_test.go
  • Line 127: warning: cyclomatic complexity 23 of function checkPreseedOrder() is high (> 15) (gocyclo)

• overlord/ifacestate/ifacestate.go
  • Line 99: warning: cyclomatic complexity 22 of function connect() is high (> 15) (gocyclo)

• boot/seal_test.go
  • Line 334: warning: cyclomatic complexity 20 of function (*sealSuite).TestResealKeyToModeenvWithSystemFallback() is high (> 15) (gocyclo)

• cmd/snap/cmd_debug_seeding.go
  • Line 48: warning: cyclomatic complexity 19 of function (*cmdSeeding).Execute() is high (> 15) (gocyclo)

• interfaces/seccomp/backend.go
  • Line 165: warning: cyclomatic complexity 17 of function parallelCompile() is high (> 15) (gocyclo)

• gadget/install/install_test.go
  • Line 105: warning: cyclomatic complexity 31 of function (*installSuite).testInstall() is high (> 15) (gocyclo)

• osutil/mountentry_linux.go
  • Line 75: warning: cyclomatic complexity 27 of function MountOptsToCommonFlags() is high (> 15) (gocyclo)

• systemd/systemd.go
  • Line 606: warning: cyclomatic complexity 25 of function (*systemd).getUnitStatus() is high (> 15) (gocyclo)

• overlord/configstate/config/transaction_test.go
  • Line 361: warning: cyclomatic complexity 27 of function (*transactionSuite).TestSetGet() is high (> 15) (gocyclo)

• overlord/snapshotstate/backend/backend.go
  • Line 381: warning: cyclomatic complexity 24 of function addDirToZip() is high (> 15) (gocyclo)
  • Line 112: warning: cyclomatic complexity 18 of function Iter() is high (> 15) (gocyclo)
  • Line 758: warning: cyclomatic complexity 17 of function unpackVerifySnapshotImport() is high (> 15) (gocyclo)

• daemon/api_users.go
  • Line 294: warning: cyclomatic complexity 23 of function createUser() is high (> 15) (gocyclo)

• daemon/daemon.go
  • Line 460: warning: cyclomatic complexity 17 of function (*Daemon).Stop() is high (> 15) (gocyclo)

• overlord/snapshotstate/backend/backend_test.go
  • Line 1248: warning: cyclomatic complexity 17 of function createTestExportFile() is high (> 15) (gocyclo)

• overlord/snapstate/snapstate.go
  • Line 259: warning: cyclomatic complexity 69 of function doInstall() is high (> 15) (gocyclo)
  • Line 1442: warning: cyclomatic complexity 35 of function doUpdate() is high (> 15) (gocyclo)
  • Line 1934: warning: cyclomatic complexity 33 of function UpdateWithDeviceContext() is high (> 15) (gocyclo)
  • Line 2764: warning: cyclomatic complexity 32 of function removeTasks() is high (> 15) (gocyclo)
  • Line 2150: warning: cyclomatic complexity 28 of function autoRefreshPhase1() is high (> 15) (gocyclo)
  • Line 1667: warning: cyclomatic complexity 23 of function autoAliasesUpdate() is high (> 15) (gocyclo)
  • Line 821: warning: cyclomatic complexity 18 of function validateFeatureFlags() is high (> 15) (gocyclo)
  • Line 654: warning: cyclomatic complexity 18 of function FinishRestart() is high (> 15) (gocyclo)
  • Line 1171: warning: cyclomatic complexity 18 of function InstallMany() is high (> 15) (gocyclo)
  • Line 1025: warning: cyclomatic complexity 17 of function InstallWithDeviceContext() is high (> 15) (gocyclo)
  • Line 914: warning: cyclomatic complexity 16 of function InstallPath() is high (> 15) (gocyclo)

• cmd/snap/cmd_run.go
  • Line 1021: warning: cyclomatic complexity 41 of function (*cmdRun).runSnapConfine() is high (> 15) (gocyclo)
  • Line 571: warning: cyclomatic complexity 23 of function migrateXauthority() is high (> 15) (gocyclo)
  • Line 704: warning: cyclomatic complexity 16 of function activateXdgDocumentPortal() is high (> 15) (gocyclo)

• strutil/shlex/shlex.go
  • Line 187: warning: cyclomatic complexity 32 of function (*Tokenizer).scanStream() is high (> 15) (gocyclo)

• cmd/snap/complete.go
  • Line 300: warning: cyclomatic complexity 35 of function (*interfaceSpec).Complete() is high (> 15) (gocyclo)

• errtracker/errtracker.go
  • Line 390: warning: cyclomatic complexity 21 of function report() is high (> 15) (gocyclo)

• daemon/api_debug_seeding.go
  • Line 66: warning: cyclomatic complexity 20 of function getSeedingInfo() is high (> 15) (gocyclo)

• asserts/findwildcard.go
  • Line 131: warning: cyclomatic complexity 17 of function findWildcardSequence() is high (> 15) (gocyclo)

• overlord/snapshotstate/backend/reader.go
  • Line 200: warning: cyclomatic complexity 40 of function (*Reader).Restore() is high (> 15) (gocyclo)

• asserts/asserts.go
  • Line 974: warning: cyclomatic complexity 26 of function assembleAndSign() is high (> 15) (gocyclo)
  • Line 763: warning: cyclomatic complexity 19 of function (*Decoder).Decode() is high (> 15) (gocyclo)
  • Line 900: warning: cyclomatic complexity 16 of function assemble() is high (> 15) (gocyclo)

• cmd/snap-seccomp/main.go
  • Line 537: warning: cyclomatic complexity 24 of function parseLine() is high (> 15) (gocyclo)

• asserts/snap_asserts.go
  • Line 150: warning: cyclomatic complexity 16 of function snapDeclarationFormatAnalyze() is high (> 15) (gocyclo)

• jsonutil/safejson/safejson.go
  • Line 86: warning: cyclomatic complexity 42 of function unmarshal() is high (> 15) (gocyclo)

• seed/seed20.go
  • Line 76: warning: cyclomatic complexity 21 of function (*seed20).LoadAssertions() is high (> 15) (gocyclo)

• usersession/autostart/autostart.go
  • Line 91: warning: cyclomatic complexity 17 of function loadAutostartDesktopFile() is high (> 15) (gocyclo)

• overlord/devicestate/devicemgr.go
  • Line 433: warning: cyclomatic complexity 28 of function (*DeviceManager).ensureOperational() is high (> 15) (gocyclo)
  • Line 804: warning: cyclomatic complexity 23 of function (*DeviceManager).ensureCloudInitRestricted() is high (> 15) (gocyclo)

• asserts/ifacedecls.go
  • Line 310: warning: cyclomatic complexity 27 of function baseCompileConstraints() is high (> 15) (gocyclo)
  • Line 470: warning: cyclomatic complexity 17 of function baseCompileRule() is high (> 15) (gocyclo)

• daemon/api_find.go
  • Line 47: warning: cyclomatic complexity 23 of function searchStore() is high (> 15) (gocyclo)

• osutil/disks/disks_linux.go
  • Line 410: warning: cyclomatic complexity 22 of function diskFromPartUDevProps() is high (> 15) (gocyclo)
  • Line 596: warning: cyclomatic complexity 18 of function (*disk).populatePartitions() is high (> 15) (gocyclo)

• store/details_v2_test.go
  • Line 339: warning: cyclomatic complexity 17 of function fillStruct() is high (> 15) (gocyclo)

• image/image_linux.go
  • Line 235: warning: cyclomatic complexity 66 of function setupSeed() is high (> 15) (gocyclo)

• asserts/model.go
  • Line 641: warning: cyclomatic complexity 48 of function assembleModel() is high (> 15) (gocyclo)
  • Line 101: warning: cyclomatic complexity 22 of function checkExtendedSnaps() is high (> 15) (gocyclo)
  • Line 193: warning: cyclomatic complexity 17 of function checkModelSnap() is high (> 15) (gocyclo)

• cmd/snap/cmd_snap_op.go
  • Line 331: warning: cyclomatic complexity 38 of function showDone() is high (> 15) (gocyclo)
  • Line 536: warning: cyclomatic complexity 18 of function (*cmdInstall).installMany() is high (> 15) (gocyclo)
  • Line 802: warning: cyclomatic complexity 17 of function (*cmdRefresh).Execute() is high (> 15) (gocyclo)

• cmd/snap/cmd_quota.go
  • Line 126: warning: cyclomatic complexity 17 of function (*cmdSetQuota).Execute() is high (> 15) (gocyclo)

• osutil/syncdir.go
  • Line 110: warning: cyclomatic complexity 16 of function EnsureDirStateGlobs() is high (> 15) (gocyclo)

• boot/model.go
  • Line 36: warning: cyclomatic complexity 17 of function DeviceChange() is high (> 15) (gocyclo)

• sandbox/cgroup/tracking.go
  • Line 41: warning: cyclomatic complexity 17 of function CreateTransientScopeForTracking() is high (> 15) (gocyclo)

• cmd/snap-bootstrap/initramfs_systemd_mount.go
  • Line 83: warning: cyclomatic complexity 20 of function doSystemdMountImpl() is high (> 15) (gocyclo)

• overlord/snapstate/snapmgr.go
  • Line 673: warning: cyclomatic complexity 19 of function (*SnapManager).ensureSnapdSnapTransition() is high (> 15) (gocyclo)

• interfaces/repo.go
  • Line 175: warning: cyclomatic complexity 18 of function (*Repository).Info() is high (> 15) (gocyclo)

• wrappers/services.go
  • Line 429: warning: cyclomatic complexity 45 of function EnsureSnapServices() is high (> 15) (gocyclo)
  • Line 179: warning: cyclomatic complexity 35 of function StartServices() is high (> 15) (gocyclo)
  • Line 1337: warning: cyclomatic complexity 25 of function generateOnCalendarSchedules() is high (> 15) (gocyclo)
  • Line 800: warning: cyclomatic complexity 24 of function RemoveSnapServices() is high (> 15) (gocyclo)
  • Line 908: warning: cyclomatic complexity 22 of function genServiceFile() is high (> 15) (gocyclo)

• cmd/snap-bootstrap/initramfs_systemd_mount_test.go
  • Line 58: warning: cyclomatic complexity 21 of function (*doSystemdMountSuite).TestDoSystemdMount() is high (> 15) (gocyclo)

• cmd/snap/notes.go
  • Line 109: warning: cyclomatic complexity 17 of function (*Notes).String() is high (> 15) (gocyclo)

golint83%

Golint is a linter for Go source code.

• desktop/notification/notificationtest/fdo.go
  • Line 38: warning: exported type FdoNotification should have comment or be unexported (golint)
  • Line 49: warning: exported type FdoServer should have comment or be unexported (golint)
  • Line 58: warning: exported function NewFdoServer should have comment or be unexported (golint)
  • Line 83: warning: exported method FdoServer.Stop should have comment or be unexported (golint)
  • Line 98: warning: exported method FdoServer.Get should have comment or be unexported (golint)
  • Line 105: warning: exported method FdoServer.GetAll should have comment or be unexported (golint)
  • Line 119: warning: exported method FdoServer.Close should have comment or be unexported (golint)
  • Line 130: warning: exported method FdoServer.InvokeAction should have comment or be unexported (golint)

• store/storetest/storetest.go
  • Line 46: warning: exported method Store.EnsureDeviceSession should have comment or be unexported (golint)
  • Line 50: warning: exported method Store.SnapInfo should have comment or be unexported (golint)
  • Line 54: warning: exported method Store.SnapExists should have comment or be unexported (golint)
  • Line 58: warning: exported method Store.Find should have comment or be unexported (golint)
  • Line 62: warning: exported method Store.SnapAction should have comment or be unexported (golint)
  • Line 66: warning: exported method Store.Download should have comment or be unexported (golint)
  • Line 70: warning: exported method Store.DownloadStream should have comment or be unexported (golint)
  • Line 74: warning: exported method Store.SuggestedCurrency should have comment or be unexported (golint)
  • Line 78: warning: exported method Store.Buy should have comment or be unexported (golint)
  • Line 82: warning: exported method Store.ReadyToBuy should have comment or be unexported (golint)
  • Line 86: warning: exported method Store.Sections should have comment or be unexported (golint)
  • Line 90: warning: exported method Store.Assertion should have comment or be unexported (golint)
  • Line 94: warning: exported method Store.SeqFormingAssertion should have comment or be unexported (golint)
  • Line 98: warning: exported method Store.DownloadAssertions should have comment or be unexported (golint)
  • Line 102: warning: exported method Store.WriteCatalogs should have comment or be unexported (golint)
  • Line 106: warning: exported method Store.ConnectivityCheck should have comment or be unexported (golint)
  • Line 110: warning: exported method Store.CreateCohorts should have comment or be unexported (golint)
  • Line 114: warning: exported method Store.LoginUser should have comment or be unexported (golint)
  • Line 118: warning: exported method Store.UserInfo should have comment or be unexported (golint)

• systemd/systemdtest/systemdtest.go
  • Line 28: warning: exported type ServiceState should have comment or be unexported (golint)
  • Line 65: warning: exported type MountUnitInfo should have comment or be unexported (golint)

• wrappers/core18.go
  • Line 46: warning: comment on exported const SnapdToolingMountUnit should be of the form "SnapdToolingMountUnit ..." (golint)
  • Line 518: warning: exported function DeriveSnapdDBusConfig should have comment or be unexported (golint)

• wrappers/services.go
  • Line 382: warning: exported type SnapServiceOptions should have comment or be unexported (golint)
  • Line 1527: warning: exported type RestartServicesFlags should have comment or be unexported (golint)
  • Line 1531: warning: comment on exported function RestartServices should be of the form "RestartServices ..." (golint)

• gadget/layout.go
  • Line 128: warning: exported type ResolvedContent should have comment or be unexported (golint)

• osutil/meminfo.go
  • Line 80: warning: exported function MockProcMeminfo should have comment or be unexported (golint)

• cmd/snap/wait.go
  • Line 50: warning: error var noWait should have name of the form errFoo (golint)

• overlord/hookstate/ctlcmd/ctlcmd.go
  • Line 35: warning: exported type MissingContextError should have comment or be unexported (golint)

• snap/squashfs/squashfs.go
  • Line 59: warning: exported function FileHasSquashfsHeader should have comment or be unexported (golint)
  • Line 202: warning: exported method Snap.Unpack should have comment or be unexported (golint)
  • Line 489: warning: exported type MksquashfsError should have comment or be unexported (golint)
  • Line 497: warning: exported type BuildOpts should have comment or be unexported (golint)

• tests/lib/fakestore/store/store.go
  • Line 118: warning: exported method Store.SnapsDir should have comment or be unexported (golint)

• store/uacontext.go
  • Line 29: warning: comment on exported function WithClientUserAgent should be of the form "WithClientUserAgent ..." (golint)

• overlord/overlord.go
  • Line 52: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 488: warning: exported method Overlord.CanStandby should have comment or be unexported (golint)

• overlord/devicestate/devicemgr.go
  • Line 234: warning: exported type SysExpectation should have comment or be unexported (golint)
  • Line 328: warning: exported method DeviceManager.CanStandby should have comment or be unexported (golint)
  • Line 1397: warning: exported type UnregisterOptions should have comment or be unexported (golint)
  • Line 1467: warning: exported type SystemModeInfo should have comment or be unexported (golint)
  • Line 1513: warning: exported type SystemAction should have comment or be unexported (golint)
  • Line 1518: warning: exported type System should have comment or be unexported (golint)
  • Line 1545: warning: exported var ErrNoSystems should have comment or be unexported (golint)
  • Line 1578: warning: exported var ErrUnsupportedAction should have comment or be unexported (golint)
  • Line 1769: warning: exported method DeviceManager.StoreContextBackend should have comment or be unexported (golint)

• overlord/devicestate/devicestate.go
  • Line 491: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 1060: warning: exported function CreateRecoverySystem should have comment or be unexported (golint)

• boot/flags.go
  • Line 52: warning: exported function IsUnknownBootFlagError should have comment or be unexported (golint)

• overlord/hookstate/context.go
  • Line 272: warning: exported method Context.IsEphemeral should have comment or be unexported (golint)

• cmd/snap-update-ns/common.go
  • Line 31: warning: exported type CommonProfileUpdateContext should have comment or be unexported (golint)
  • Line 97: warning: exported method CommonProfileUpdateContext.Assumptions should have comment or be unexported (golint)

• sandbox/apparmor/apparmor.go
  • Line 76: warning: exported var ConfDir should have comment or be unexported (golint)
  • Line 378: warning: comment on exported function MockLevel should be of the form "MockLevel ..." (golint)
  • Line 401: warning: comment on exported function MockFeatures should be of the form "MockFeatures ..." (golint)

• cmd/snap-repair/runner.go
  • Line 73: warning: exported method Repair.RunDir should have comment or be unexported (golint)
  • Line 325: warning: exported var ErrRepairNotFound should have comment or be unexported (golint)
  • Line 512: warning: exported const RetryStatus should have comment (or a comment on this block) or be unexported (golint)

• store/auth.go
  • Line 38: warning: comment on exported var MacaroonACLAPI should be of the form "MacaroonACLAPI ..." (golint)

• overlord/standby/standby.go
  • Line 33: warning: exported type Opinionator should have comment or be unexported (golint)
  • Line 76: warning: exported function New should have comment or be unexported (golint)
  • Line 94: warning: exported method StandbyOpinions.Start should have comment or be unexported (golint)
  • Line 119: warning: exported method StandbyOpinions.Stop should have comment or be unexported (golint)
  • Line 132: warning: exported method StandbyOpinions.AddOpinion should have comment or be unexported (golint)
  • Line 138: warning: exported function MockStandbyWait should have comment or be unexported (golint)

• overlord/servicestate/quotas.go
  • Line 30: warning: exported var ErrQuotaNotFound should have comment or be unexported (golint)

• client/client.go
  • Line 143: warning: exported method Client.WhoAmI should have comment or be unexported (golint)
  • Line 173: warning: exported type RequestError should have comment or be unexported (golint)
  • Line 179: warning: exported type AuthorizationError should have comment or be unexported (golint)
  • Line 185: warning: exported method AuthorizationError.Is should have comment or be unexported (golint)
  • Line 190: warning: exported type ConnectionError should have comment or be unexported (golint)
  • Line 209: warning: exported type InternalClientError should have comment or be unexported (golint)
  • Line 215: warning: exported method InternalClientError.Is should have comment or be unexported (golint)
  • Line 542: warning: exported type ServerVersion should have comment or be unexported (golint)
  • Line 554: warning: exported method Client.ServerVersion should have comment or be unexported (golint)
  • Line 754: warning: exported method Client.DebugGet should have comment or be unexported (golint)
  • Line 763: warning: exported type SystemRecoveryKeysResponse should have comment or be unexported (golint)
  • Line 768: warning: exported method Client.SystemRecoveryKeys should have comment or be unexported (golint)

• client/quota.go
  • Line 38: warning: exported type QuotaGroupResult should have comment or be unexported (golint)
  • Line 47: warning: exported type QuotaValues should have comment or be unexported (golint)
  • Line 79: warning: exported method Client.GetQuotaGroup should have comment or be unexported (golint)
  • Line 93: warning: exported method Client.RemoveQuotaGroup should have comment or be unexported (golint)
  • Line 114: warning: exported method Client.Quotas should have comment or be unexported (golint)

• bootloader/bootloader.go
  • Line 116: warning: exported type RecoveryAwareBootloader should have comment or be unexported (golint)
  • Line 122: warning: exported type ExtractedRecoveryKernelImageBootloader should have comment or be unexported (golint)
  • Line 166: warning: comment on exported type CommandLineComponents should be of the form "CommandLineComponents ..." (with optional leading article) (golint)
  • Line 184: warning: exported method CommandLineComponents.Validate should have comment or be unexported (golint)
  • Line 422: warning: exported function NewBootFile should have comment or be unexported (golint)

• snap/types.go
  • Line 54: warning: exported method Type.SortsBefore should have comment or be unexported (golint)
  • Line 139: warning: exported type ServiceStopReason should have comment or be unexported (golint)
  • Line 142: warning: exported const StopReasonRefresh should have comment (or a comment on this block) or be unexported (golint)
  • Line 152: warning: exported const SystemDaemon should have comment (or a comment on this block) or be unexported (golint)

• overlord/configstate/configcore/experimental.go
  • Line 88: warning: exported function ExportExperimentalFlags should have comment or be unexported (golint)

• dirs/dirs.go
  • Line 142: warning: comment on exported const CoreLibExecDir should be of the form "CoreLibExecDir ..." (golint)
  • Line 146: warning: exported const CoreSnapMountDir should have comment (or a comment on this block) or be unexported (golint)
  • Line 148: warning: comment on exported const UserHomeSnapDir should be of the form "UserHomeSnapDir ..." (golint)
  • Line 167: warning: exported type SnapDirOptions should have comment or be unexported (golint)
  • Line 277: warning: comment on exported function SnapServicesDirUnder should be of the form "SnapServicesDirUnder ..." (golint)
  • Line 514: warning: exported function CompleteShPath should have comment or be unexported (golint)
  • Line 518: warning: exported function IsCompleteShSymlink should have comment or be unexported (golint)

• cmd/snap/cmd_list.go
  • Line 67: warning: exported var ErrNoMatchingSnaps should have comment or be unexported (golint)
  • Line 107: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• dbusutil/dbustest/dbustest.go
  • Line 224: warning: exported type InjectMessageFunc should have comment or be unexported (golint)

• bootloader/lkenv/lkenv_v1.go
  • Line 26: warning: comment on exported type SnapBootSelect_v1 should be of the form "SnapBootSelect_v1 ..." (with optional leading article) (golint)
  • Line 39: warning: don't use underscores in Go names; type SnapBootSelect_v1 should be SnapBootSelectV1 (golint)
  • Line 46: warning: don't use underscores in Go names; struct field Snap_mode should be SnapMode (golint)
  • Line 48: warning: don't use underscores in Go names; struct field Snap_core should be SnapCore (golint)
  • Line 50: warning: don't use underscores in Go names; struct field Snap_try_core should be SnapTryCore (golint)
  • Line 52: warning: don't use underscores in Go names; struct field Snap_kernel should be SnapKernel (golint)
  • Line 54: warning: don't use underscores in Go names; struct field Snap_try_kernel should be SnapTryKernel (golint)
  • Line 57: warning: don't use underscores in Go names; struct field Gadget_mode should be GadgetMode (golint)
  • Line 59: warning: don't use underscores in Go names; struct field Snap_gadget should be SnapGadget (golint)
  • Line 61: warning: don't use underscores in Go names; struct field Snap_try_gadget should be SnapTryGadget (golint)
  • Line 68: warning: don't use underscores in Go names; struct field Reboot_reason should be RebootReason (golint)
  • Line 103: warning: don't use underscores in Go names; struct field Bootimg_matrix should be BootimgMatrix (golint)
  • Line 109: warning: don't use underscores in Go names; struct field Bootimg_file_name should be BootimgFileName (golint)
  • Line 123: warning: don't use underscores in Go names; struct field Gadget_asset_matrix should be GadgetAssetMatrix (golint)
  • Line 126: warning: don't use underscores in Go names; struct field Unused_key_01 should be UnusedKey01 (golint)
  • Line 127: warning: don't use underscores in Go names; struct field Unused_key_02 should be UnusedKey02 (golint)
  • Line 128: warning: don't use underscores in Go names; struct field Unused_key_03 should be UnusedKey03 (golint)
  • Line 129: warning: don't use underscores in Go names; struct field Unused_key_04 should be UnusedKey04 (golint)
  • Line 130: warning: don't use underscores in Go names; struct field Unused_key_05 should be UnusedKey05 (golint)
  • Line 131: warning: don't use underscores in Go names; struct field Unused_key_06 should be UnusedKey06 (golint)
  • Line 132: warning: don't use underscores in Go names; struct field Unused_key_07 should be UnusedKey07 (golint)
  • Line 133: warning: don't use underscores in Go names; struct field Unused_key_08 should be UnusedKey08 (golint)
  • Line 134: warning: don't use underscores in Go names; struct field Unused_key_09 should be UnusedKey09 (golint)
  • Line 135: warning: don't use underscores in Go names; struct field Unused_key_10 should be UnusedKey10 (golint)
  • Line 136: warning: don't use underscores in Go names; struct field Unused_key_11 should be UnusedKey11 (golint)
  • Line 137: warning: don't use underscores in Go names; struct field Unused_key_12 should be UnusedKey12 (golint)
  • Line 138: warning: don't use underscores in Go names; struct field Unused_key_13 should be UnusedKey13 (golint)
  • Line 139: warning: don't use underscores in Go names; struct field Unused_key_14 should be UnusedKey14 (golint)
  • Line 140: warning: don't use underscores in Go names; struct field Unused_key_15 should be UnusedKey15 (golint)
  • Line 141: warning: don't use underscores in Go names; struct field Unused_key_16 should be UnusedKey16 (golint)
  • Line 142: warning: don't use underscores in Go names; struct field Unused_key_17 should be UnusedKey17 (golint)
  • Line 143: warning: don't use underscores in Go names; struct field Unused_key_18 should be UnusedKey18 (golint)
  • Line 144: warning: don't use underscores in Go names; struct field Unused_key_19 should be UnusedKey19 (golint)
  • Line 145: warning: don't use underscores in Go names; struct field Unused_key_20 should be UnusedKey20 (golint)
  • Line 148: warning: don't use underscores in Go names; struct field Key_value_pairs should be KeyValuePairs (golint)

• overlord/snapstate/backend/locking.go
  • Line 3: warning: package comment should be of the form "Package backend ..." (golint)
  • Line 3: warning: package comment should not have leading space (golint)
  • Line 28: warning: exported method Backend.RunInhibitSnapForUnlink should have comment or be unexported (golint)

• usersession/userd/ui/ui.go
  • Line 43: warning: comment on exported type DialogOptions should be of the form "DialogOptions ..." (with optional leading article) (golint)
  • Line 57: warning: exported function MockHasZenityExecutable should have comment or be unexported (golint)
  • Line 65: warning: exported function MockHasKDialogExecutable should have comment or be unexported (golint)

• interfaces/kmod/spec.go
  • Line 73: warning: comment on exported method Specification.ModuleOptions should be of the form "ModuleOptions ..." (golint)

• client/packages.go
  • Line 85: warning: exported type SnapHealth should have comment or be unexported (golint)
  • Line 93: warning: exported method Snap.MarshalJSON should have comment or be unexported (golint)
  • Line 126: warning: exported type ResultInfo should have comment or be unexported (golint)
  • Line 148: warning: exported var ErrNoSnapsInstalled should have comment or be unexported (golint)
  • Line 150: warning: exported type ListOptions should have comment or be unexported (golint)
  • Line 229: warning: exported method Client.FindOne should have comment or be unexported (golint)

• overlord/configstate/configcore/runwithstate.go
  • Line 112: warning: exported function Run should have comment or be unexported (golint)
  • Line 150: warning: exported function Early should have comment or be unexported (golint)

• httputil/client.go
  • Line 144: warning: exported type ClientOptions should have comment or be unexported (golint)
  • Line 155: warning: comment on exported function NewHTTPClient should be of the form "NewHTTPClient ..." (golint)
  • Line 189: warning: exported function MockResponseHeaderTimeout should have comment or be unexported (golint)

• interfaces/builtin/kubernetes_support.go
  • Line 306: warning: don't use underscores in Go names; var systemd_run_extra should be systemdRunExtra (golint)

• daemon/api_sideload_n_try.go
  • Line 61: warning: exported type FileReference should have comment or be unexported (golint)
  • Line 66: warning: exported method Form.RemoveAllExcept should have comment or be unexported (golint)

• bootloader/androidbootenv/androidbootenv.go
  • Line 33: warning: exported type Env should have comment or be unexported (golint)
  • Line 40: warning: exported function NewEnv should have comment or be unexported (golint)
  • Line 47: warning: exported method Env.Get should have comment or be unexported (golint)
  • Line 51: warning: exported method Env.Set should have comment or be unexported (golint)
  • Line 55: warning: exported method Env.Load should have comment or be unexported (golint)
  • Line 80: warning: exported method Env.Save should have comment or be unexported (golint)

• asserts/gpgkeypairmgr.go
  • Line 127: warning: comment on exported type GPGKeypairManager should be of the form "GPGKeypairManager ..." (with optional leading article) (golint)
  • Line 240: warning: exported method GPGKeypairManager.Put should have comment or be unexported (golint)
  • Line 273: warning: exported method GPGKeypairManager.Get should have comment or be unexported (golint)
  • Line 281: warning: exported method GPGKeypairManager.Delete should have comment or be unexported (golint)
  • Line 398: warning: exported method GPGKeypairManager.List should have comment or be unexported (golint)

• usersession/client/client.go
  • Line 53: warning: exported type Client should have comment or be unexported (golint)
  • Line 58: warning: exported function New should have comment or be unexported (golint)
  • Line 73: warning: exported type Error should have comment or be unexported (golint)
  • Line 207: warning: exported type SessionInfo should have comment or be unexported (golint)
  • Line 211: warning: exported method Client.SessionInfo should have comment or be unexported (golint)
  • Line 237: warning: exported type ServiceFailure should have comment or be unexported (golint)
  • Line 296: warning: exported method Client.ServicesDaemonReload should have comment or be unexported (golint)
  • Line 301: warning: exported method Client.ServicesStart should have comment or be unexported (golint)
  • Line 305: warning: exported method Client.ServicesStop should have comment or be unexported (golint)

• interfaces/mount/ns.go
  • Line 53: warning: comment on exported function DiscardSnapNamespace should be of the form "DiscardSnapNamespace ..." (golint)
  • Line 62: warning: comment on exported function UpdateSnapNamespace should be of the form "UpdateSnapNamespace ..." (golint)

• cmd/snap/cmd_get.go
  • Line 89: warning: exported type ConfigValue should have comment or be unexported (golint)
  • Line 164: warning: receiver name x should be consistent with previous receiver name c for cmdGet (golint)
  • Line 186: warning: receiver name x should be consistent with previous receiver name c for cmdGet (golint)
  • Line 228: warning: receiver name x should be consistent with previous receiver name c for cmdGet (golint)

• cmd/snap/last.go
  • Line 52: warning: error var noChangeFoundOK should have name of the form errFoo (golint)

• bootloader/ubootenv/env.go
  • Line 166: warning: exported method Env.Size should have comment or be unexported (golint)

• overlord/snapstate/backend/link.go
  • Line 167: warning: exported method Backend.StartServices should have comment or be unexported (golint)
  • Line 172: warning: exported method Backend.StopServices should have comment or be unexported (golint)
  • Line 273: warning: exported function GenerateSnapdWrappers should have comment or be unexported (golint)
  • Line 314: warning: exported method Backend.QueryDisabledServices should have comment or be unexported (golint)

• osutil/strace/timing.go
  • Line 76: warning: exported method ExecveTiming.Display should have comment or be unexported (golint)
  • Line 168: warning: exported function TraceExecveTimings should have comment or be unexported (golint)

• overlord/healthstate/healthstate.go
  • Line 51: warning: exported function Hook should have comment or be unexported (golint)
  • Line 64: warning: exported type HealthStatus should have comment or be unexported (golint)
  • Line 67: warning: exported const UnknownStatus should have comment (or a comment on this block) or be unexported (golint)
  • Line 76: warning: exported function StatusLookup should have comment or be unexported (golint)
  • Line 92: warning: exported type HealthState should have comment or be unexported (golint)
  • Line 100: warning: exported function Init should have comment or be unexported (golint)
  • Line 198: warning: exported function All should have comment or be unexported (golint)
  • Line 206: warning: exported function Get should have comment or be unexported (golint)

• desktop/notification/manager.go
  • Line 29: warning: exported type NotificationManager should have comment or be unexported (golint)
  • Line 37: warning: exported function NewNotificationManager should have comment or be unexported (golint)

• overlord/snapshotstate/snapshotstate.go
  • Line 103: warning: exported function EstimateSnapshotSize should have comment or be unexported (golint)
  • Line 128: warning: exported function AutomaticSnapshotExpiration should have comment or be unexported (golint)
  • Line 428: warning: exported function AutomaticSnapshot should have comment or be unexported (golint)

• seed/internal/options20.go
  • Line 59: warning: exported type Options20 should have comment or be unexported (golint)
  • Line 63: warning: exported function ReadOptions20 should have comment or be unexported (golint)

• seed/seedwriter/writer.go
  • Line 20: warning: package comment should be of the form "Package seedwriter ..." (golint)
  • Line 63: warning: exported method OptionsSnap.SnapName should have comment or be unexported (golint)
  • Line 67: warning: exported method OptionsSnap.ID should have comment or be unexported (golint)
  • Line 104: warning: comment on exported type Writer should be of the form "Writer ..." (with optional leading article) (golint)
  • Line 434: warning: exported function IsSytemDirectoryExistsError should have comment or be unexported (golint)

• usersession/agent/session_agent.go
  • Line 45: warning: exported type SessionAgent should have comment or be unexported (golint)
  • Line 174: warning: exported method SessionAgent.Init should have comment or be unexported (golint)
  • Line 195: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 246: warning: exported method SessionAgent.Start should have comment or be unexported (golint)
  • Line 336: warning: exported method SessionAgent.Dying should have comment or be unexported (golint)
  • Line 340: warning: exported function New should have comment or be unexported (golint)

• overlord/devicestate/devicestatetest/devicesvc.go
  • Line 31: warning: should not use dot imports (golint)
  • Line 37: warning: exported type DeviceServiceBehavior should have comment or be unexported (golint)
  • Line 63: warning: exported function MockDeviceService should have comment or be unexported (golint)

• bootloader/lkenv/lkenv.go
  • Line 37: warning: exported const SNAP_BOOTSELECT_VERSION_V1 should have comment (or a comment on this block) or be unexported (golint)
  • Line 41: warning: comment on exported const SNAP_BOOTSELECT_SIGNATURE should be of the form "SNAP_BOOTSELECT_SIGNATURE ..." (golint)
  • Line 45: warning: comment on exported const SNAP_BOOTSELECT_RECOVERY_SIGNATURE should be of the form "SNAP_BOOTSELECT_RECOVERY_SIGNATURE ..." (golint)
  • Line 60: warning: comment on exported const SNAP_RECOVERY_BOOTIMG_PART_NUM should be of the form "SNAP_RECOVERY_BOOTIMG_PART_NUM ..." (golint)
  • Line 67: warning: comment on exported const BOOTIMG_DEFAULT_NAME should be of the form "BOOTIMG_DEFAULT_NAME ..." (golint)
  • Line 80: warning: exported type Version should have comment or be unexported (golint)
  • Line 83: warning: exported const V1 should have comment (or a comment on this block) or be unexported (golint)

• interfaces/utils/path_patterns.go
  • Line 27: warning: exported type PathPattern should have comment or be unexported (golint)
  • Line 34: warning: exported type GlobFlags should have comment or be unexported (golint)
  • Line 163: warning: exported function NewPathPattern should have comment or be unexported (golint)
  • Line 175: warning: exported method PathPattern.Matches should have comment or be unexported (golint)

• gadget/quantity/offset.go
  • Line 48: warning: exported method Offset.UnmarshalYAML should have comment or be unexported (golint)

• cmd/snap/cmd_run.go
  • Line 1071: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• cmd/snap/cmd_routine_file_access.go
  • Line 116: warning: exported type FileAccess should have comment or be unexported (golint)
  • Line 119: warning: exported const FileAccessHidden should have comment (or a comment on this block) or be unexported (golint)

• secboot/secboot.go
  • Line 35: warning: comment on exported const RunObjectPCRPolicyCounterHandle should be of the form "RunObjectPCRPolicyCounterHandle ..." (golint)
  • Line 37: warning: exported const FallbackObjectPCRPolicyCounterHandle should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported type LoadChain should have comment or be unexported (golint)
  • Line 59: warning: exported type SealKeyRequest should have comment or be unexported (golint)
  • Line 79: warning: exported type SealKeyModelParams should have comment or be unexported (golint)
  • Line 89: warning: exported type SealKeysParams should have comment or be unexported (golint)
  • Line 106: warning: exported type SealKeysWithFDESetupHookParams should have comment or be unexported (golint)
  • Line 116: warning: exported type ResealKeysParams should have comment or be unexported (golint)

• strutil/ctrl17.go
  • Line 11: warning: comment on exported var Ctrl should be of the form "Ctrl ..." (golint)

• tests/lib/fakestore/refresh/snap_asserts.go
  • Line 39: warning: exported function NewSnapRevision should have comment or be unexported (golint)
  • Line 71: warning: exported function NewSnapDeclaration should have comment or be unexported (golint)

• osutil/sizer.go
  • Line 22: warning: exported type Sizer should have comment or be unexported (golint)
  • Line 32: warning: exported method Sizer.Reset should have comment or be unexported (golint)
  • Line 36: warning: exported method Sizer.Size should have comment or be unexported (golint)

• usersession/autostart/autostart.go
  • Line 229: warning: exported function MockUserCurrent should have comment or be unexported (golint)

• x11/xauth.go
  • Line 89: warning: comment on exported function ValidateXauthorityFile should be of the form "ValidateXauthorityFile ..." (golint)

• usersession/userd/launcher.go
  • Line 260: warning: exported method Launcher.OpenFile should have comment or be unexported (golint)

• interfaces/polkit/spec.go
  • Line 30: warning: exported type Policy should have comment or be unexported (golint)

• kernel/kernel.go
  • Line 32: warning: exported type Asset should have comment or be unexported (golint)
  • Line 41: warning: exported type Info should have comment or be unexported (golint)

• usersession/userd/settings.go
  • Line 106: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• interfaces/core.go
  • Line 43: warning: exported function BeforeConnectPlug should have comment or be unexported (golint)
  • Line 81: warning: comment on exported function BeforePrepareSlot should be of the form "BeforePrepareSlot ..." (golint)
  • Line 189: warning: comment on exported type ConnPlugSanitizer should be of the form "ConnPlugSanitizer ..." (with optional leading article) (golint)

• progress/progresstest/progresstest.go
  • Line 26: warning: exported type Meter should have comment or be unexported (golint)
  • Line 38: warning: exported method Meter.Start should have comment or be unexported (golint)
  • Line 43: warning: exported method Meter.Set should have comment or be unexported (golint)
  • Line 47: warning: exported method Meter.SetTotal should have comment or be unexported (golint)
  • Line 51: warning: exported method Meter.Finished should have comment or be unexported (golint)
  • Line 55: warning: exported method Meter.Spin should have comment or be unexported (golint)
  • Line 66: warning: exported method Meter.Notify should have comment or be unexported (golint)

• overlord/servicestate/servicemgr.go
  • Line 69: warning: exported function MockEnsuredSnapServices should have comment or be unexported (golint)

• sandbox/seccomp/compiler.go
  • Line 50: warning: exported type Compiler should have comment or be unexported (golint)
  • Line 168: warning: exported method BuildTimeRequirementError.RequirementsString should have comment or be unexported (golint)

• overlord/snapshotstate/backend/helpers.go
  • Line 189: warning: exported function MockUserLookup should have comment or be unexported (golint)

• cmd/snap/keymgr.go
  • Line 33: warning: exported type KeypairManager should have comment or be unexported (golint)

• snap/epoch.go
  • Line 129: warning: exported method Epoch.UnmarshalJSON should have comment or be unexported (golint)
  • Line 135: warning: exported method Epoch.UnmarshalYAML should have comment or be unexported (golint)
  • Line 174: warning: exported method Epoch.Equal should have comment or be unexported (golint)
  • Line 218: warning: exported method Epoch.MarshalJSON should have comment or be unexported (golint)
  • Line 229: warning: exported method Epoch.MarshalYAML should have comment or be unexported (golint)

• osutil/disks/disks_linux.go
  • Line 193: warning: comment on exported function DiskFromDevicePath should be of the form "DiskFromDevicePath ..." (golint)
  • Line 861: warning: exported function AllPhysicalDisks should have comment or be unexported (golint)

• overlord/snapstate/snapstate.go
  • Line 69: warning: exported const BeginEdge should have comment (or a comment on this block) or be unexported (golint)
  • Line 79: warning: exported var ErrNothingToDo should have comment or be unexported (golint)
  • Line 619: warning: exported var Configure should have comment or be unexported (golint)
  • Line 623: warning: exported var SetupInstallHook should have comment or be unexported (golint)
  • Line 627: warning: exported var SetupPreRefreshHook should have comment or be unexported (golint)
  • Line 631: warning: exported var SetupPostRefreshHook should have comment or be unexported (golint)
  • Line 635: warning: exported var SetupRemoveHook should have comment or be unexported (golint)
  • Line 639: warning: exported var CheckHealthHook should have comment or be unexported (golint)
  • Line 643: warning: exported var SetupGateAutoRefreshHook should have comment or be unexported (golint)
  • Line 1101: warning: exported function InstallPathMany should have comment or be unexported (golint)
  • Line 2114: warning: exported var AddCurrentTrackingToValidationSetsStack should have comment or be unexported (golint)
  • Line 2116: warning: exported var RestoreValidationSetsTracking should have comment or be unexported (golint)
  • Line 2483: warning: comment on exported function SwitchToNewGadget should be of the form "SwitchToNewGadget ..." (golint)
  • Line 3038: warning: exported function RevertToRevision should have comment or be unexported (golint)
  • Line 3334: warning: exported function HasSnapOfType should have comment or be unexported (golint)
  • Line 3529: warning: exported function MockOsutilCheckFreeSpace should have comment or be unexported (golint)
  • Line 3535: warning: exported function MockEnforcedValidationSets should have comment or be unexported (golint)

• interfaces/dbus/backend.go
  • Line 231: warning: exported method Backend.NewSpecification should have comment or be unexported (golint)

• cmd/snap-failure/main.go
  • Line 34: warning: exported var Stderr should have comment or be unexported (golint)

• sandbox/apparmor/process.go
  • Line 56: warning: exported function DecodeLabel should have comment or be unexported (golint)
  • Line 70: warning: exported function SnapAppFromPid should have comment or be unexported (golint)

• seed/seedtest/sample.go
  • Line 22: warning: exported var SampleSnapYaml should have comment or be unexported (golint)
  • Line 119: warning: exported function MergeSampleSnapYaml should have comment or be unexported (golint)

• snap/naming/tag.go
  • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sandbox/cgroup/cgroup.go
  • Line 53: warning: comment on exported const Unknown should be of the form "Unknown ..." (golint)
  • Line 55: warning: exported const V1 should have comment (or a comment on this block) or be unexported (golint)

• snap/squashfs/stat.go
  • Line 31: warning: exported type SnapFileOwner should have comment or be unexported (golint)
  • Line 160: warning: receiver name st should be consistent with previous receiver name s for stat (golint)
  • Line 172: warning: receiver name st should be consistent with previous receiver name s for stat (golint)
  • Line 204: warning: receiver name st should be consistent with previous receiver name s for stat (golint)
  • Line 283: warning: receiver name st should be consistent with previous receiver name s for stat (golint)
  • Line 359: warning: receiver name st should be consistent with previous receiver name s for stat (golint)

• timeutil/schedule.go
  • Line 100: warning: exported const EveryWeek should have comment (or a comment on this block) or be unexported (golint)

• polkit/validate/validate.go
  • Line 29: warning: exported type Element should have comment or be unexported (golint)
  • Line 82: warning: exported function ValidatePolicy should have comment or be unexported (golint)

• client/change.go
  • Line 46: warning: exported var ErrNoData should have comment or be unexported (golint)
  • Line 70: warning: exported type TaskProgress should have comment or be unexported (golint)
  • Line 113: warning: exported type ChangeSelector should have comment or be unexported (golint)
  • Line 129: warning: exported const ChangesInProgress should have comment (or a comment on this block) or be unexported (golint)
  • Line 134: warning: exported type ChangesOptions should have comment or be unexported (golint)
  • Line 139: warning: exported method Client.Changes should have comment or be unexported (golint)

• client/snapshot.go
  • Line 43: warning: exported var ErrSnapshotSetNotFound should have comment or be unexported (golint)

• snap/quota/resources.go
  • Line 110: warning: exported function NewResources should have comment or be unexported (golint)

• netutil/metered.go
  • Line 31: warning: comment on exported const NetworkManagerMeteredUnknown should be of the form "NetworkManagerMeteredUnknown ..." (golint)
  • Line 33: warning: exported const NetworkManagerMeteredYes should have comment (or a comment on this block) or be unexported (golint)

• asserts/account_key.go
  • Line 73: warning: exported function IsValidAccountKeyName should have comment or be unexported (golint)

• interfaces/policy/policy.go
  • Line 143: warning: exported method ConnectCandidate.PlugAttr should have comment or be unexported (golint)
  • Line 147: warning: exported method ConnectCandidate.SlotAttr should have comment or be unexported (golint)

• cmd/snap-seccomp/main.go
  • Line 198: warning: comment on exported const ScArgsMaxlength should be of the form "ScArgsMaxlength ..." (golint)
  • Line 461: warning: comment on exported type SeccompData should be of the form "SeccompData ..." (with optional leading article) (golint)
  • Line 464: warning: exported method SeccompData.SetNr should have comment or be unexported (golint)
  • Line 467: warning: exported method SeccompData.SetArch should have comment or be unexported (golint)
  • Line 470: warning: exported method SeccompData.SetArgs should have comment or be unexported (golint)

• interfaces/builtin/kvm.go
  • Line 80: warning: don't use underscores in Go names; var cpu_flags should be cpuFlags (golint)
  • Line 88: warning: don't use underscores in Go names; var cpu_flags should be cpuFlags (golint)

• advisor/backend.go
  • Line 48: warning: exported type CommandDB should have comment or be unexported (golint)

• osutil/udev/netlink/conn.go
  • Line 10: warning: exported type Mode should have comment or be unexported (golint)
  • Line 20: warning: comment on exported type NetlinkConn should be of the form "NetlinkConn ..." (with optional leading article) (golint)
  • Line 26: warning: exported type UEventConn should have comment or be unexported (golint)
  • Line 90: warning: comment on exported method UEventConn.ReadUEvent should be of the form "ReadUEvent ..." (golint)

• osutil/group.go
  • Line 38: warning: exported function MockFindUid should have comment or be unexported (golint)
  • Line 46: warning: exported function MockFindGid should have comment or be unexported (golint)
  • Line 199: warning: exported function IsUnknownUser should have comment or be unexported (golint)
  • Line 204: warning: exported function IsUnknownGroup should have comment or be unexported (golint)

• desktop/portal/launcher.go
  • Line 39: warning: exported type ResponseError should have comment or be unexported (golint)
  • Line 45: warning: exported method ResponseError.Is should have comment or be unexported (golint)
  • Line 50: warning: exported function MakeResponseError should have comment or be unexported (golint)
  • Line 151: warning: exported function OpenFile should have comment or be unexported (golint)
  • Line 174: warning: exported function OpenURI should have comment or be unexported (golint)

• cmd/snap-repair/main.go
  • Line 37: warning: exported var Stdout should have comment or be unexported (golint)

• snap/errors.go
  • Line 24: warning: exported type AlreadyInstalledError should have comment or be unexported (golint)
  • Line 32: warning: exported type NotInstalledError should have comment or be unexported (golint)
  • Line 44: warning: exported type NotSnapError should have comment or be unexported (golint)

• interfaces/backends/backends.go
  • Line 37: warning: exported var All should have comment or be unexported (golint)

• overlord/ifacestate/helpers.go
  • Line 1236: warning: exported type HotplugSlotInfo should have comment or be unexported (golint)

• timeout/timeout.go
  • Line 55: warning: exported method Timeout.UnmarshalYAML should have comment or be unexported (golint)

• gadget/mountedfilesystem.go
  • Line 25: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 258: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 494: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 783: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• osutil/mountprofile_linux.go
  • Line 56: warning: exported function SaveMountProfileText should have comment or be unexported (golint)

• overlord/servicestate/servicestatetest/quotas.go
  • Line 36: warning: exported function MockQuotaInState should have comment or be unexported (golint)

• snap/restartcond.go
  • Line 40: warning: exported var RestartMap should have comment or be unexported (golint)

• overlord/auth/auth.go
  • Line 179: warning: exported var ErrInvalidUser should have comment or be unexported (golint)
  • Line 220: warning: exported function Users should have comment or be unexported (golint)
  • Line 292: warning: exported var ErrInvalidAuth should have comment or be unexported (golint)

• store/userinfo.go
  • Line 37: warning: exported type User should have comment or be unexported (golint)
  • Line 43: warning: exported method Store.UserInfo should have comment or be unexported (golint)

• interfaces/connection.go
  • Line 178: warning: exported method ConnectedPlug.Lookup should have comment or be unexported (golint)
  • Line 251: warning: exported method ConnectedSlot.Lookup should have comment or be unexported (golint)

• sandbox/cgroup/process.go
  • Line 63: warning: exported function SnapNameFromPid should have comment or be unexported (golint)

• interfaces/polkit/backend.go
  • Line 113: warning: exported method Backend.NewSpecification should have comment or be unexported (golint)

• interfaces/ifacetest/backendtest.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 34: warning: exported type BackendSuite should have comment or be unexported (golint)
  • Line 45: warning: exported method BackendSuite.SetUpTest should have comment or be unexported (golint)
  • Line 65: warning: exported method BackendSuite.TearDownTest should have comment or be unexported (golint)
  • Line 70: warning: comment on exported const SambaYamlV1 should be of the form "SambaYamlV1 ..." (golint)
  • Line 81: warning: exported const SambaYamlV1WithNmbd should have comment or be unexported (golint)
  • Line 92: warning: exported const SambaYamlV1NoSlot should have comment or be unexported (golint)
  • Line 99: warning: exported const SambaYamlV1WithNmbdNoSlot should have comment or be unexported (golint)
  • Line 107: warning: exported const SambaYamlV2 should have comment or be unexported (golint)
  • Line 117: warning: exported const SambaYamlWithHook should have comment or be unexported (golint)
  • Line 133: warning: exported const HookYaml should have comment or be unexported (golint)
  • Line 143: warning: exported const PlugNoAppsYaml should have comment or be unexported (golint)
  • Line 151: warning: exported const SlotNoAppsYaml should have comment or be unexported (golint)
  • Line 160: warning: exported const SomeSnapYamlV1 should have comment or be unexported (golint)

• gadget/update.go
  • Line 34: warning: exported var ErrNoUpdate should have comment or be unexported (golint)
  • Line 38: warning: comment on exported var DefaultConstraints should be of the form "DefaultConstraints ..." (golint)
  • Line 80: warning: exported type ContentOperation should have comment or be unexported (golint)
  • Line 81: warning: exported type ContentChangeAction should have comment or be unexported (golint)
  • Line 84: warning: exported const ContentWrite should have comment (or a comment on this block) or be unexported (golint)
  • Line 226: warning: exported function EnsureLayoutCompatibility should have comment or be unexported (golint)
  • Line 497: warning: comment on exported const EncryptionLUKS should be of the form "EncryptionLUKS ..." (golint)
  • Line 500: warning: comment on exported const EncryptionICE should be of the form "EncryptionICE ..." (golint)
  • Line 965: warning: exported type Updater should have comment or be unexported (golint)

• overlord/snapstate/autorefresh_gating.go
  • Line 41: warning: comment on exported type GateAutoRefreshAction should be of the form "GateAutoRefreshAction ..." (with optional leading article) (golint)
  • Line 47: warning: exported const GateAutoRefreshProceed should have comment (or a comment on this block) or be unexported (golint)
  • Line 396: warning: exported type AffectedSnapInfo should have comment or be unexported (golint)

• overlord/snapstate/snapstatetest/devicectx.go
  • Line 29: warning: exported type TrivialDeviceContext should have comment or be unexported (golint)
  • Line 38: warning: exported method TrivialDeviceContext.Model should have comment or be unexported (golint)
  • Line 42: warning: exported method TrivialDeviceContext.GroundContext should have comment or be unexported (golint)
  • Line 57: warning: exported method TrivialDeviceContext.Classic should have comment or be unexported (golint)
  • Line 61: warning: exported method TrivialDeviceContext.Kernel should have comment or be unexported (golint)
  • Line 65: warning: exported method TrivialDeviceContext.Base should have comment or be unexported (golint)
  • Line 69: warning: exported method TrivialDeviceContext.HasModeenv should have comment or be unexported (golint)
  • Line 73: warning: exported method TrivialDeviceContext.RunMode should have comment or be unexported (golint)
  • Line 77: warning: exported method TrivialDeviceContext.Store should have comment or be unexported (golint)
  • Line 84: warning: exported method TrivialDeviceContext.ForRemodeling should have comment or be unexported (golint)
  • Line 88: warning: exported method TrivialDeviceContext.SystemMode should have comment or be unexported (golint)
  • Line 96: warning: exported function MockDeviceModel should have comment or be unexported (golint)
  • Line 104: warning: exported function MockDeviceModelAndMode should have comment or be unexported (golint)
  • Line 109: warning: exported function MockDeviceContext should have comment or be unexported (golint)
  • Line 135: warning: exported function ReplaceDeviceCtxHook should have comment or be unexported (golint)
  • Line 143: warning: exported function UseFallbackDeviceModel should have comment or be unexported (golint)
  • Line 147: warning: exported function ReplaceRemodelingHook should have comment or be unexported (golint)

• sandbox/selinux/selinux.go
  • Line 30: warning: comment on exported const Unsupported should be of the form "Unsupported ..." (golint)
  • Line 32: warning: comment on exported const Permissive should be of the form "Permissive ..." (golint)
  • Line 34: warning: comment on exported const Enforcing should be of the form "Enforcing ..." (golint)

• snap/helpers.go
  • Line 36: warning: exported function IsSnapd should have comment or be unexported (golint)

• kernel/fde/fde.go
  • Line 20: warning: package comment should be of the form "Package fde ..." (golint)
  • Line 85: warning: comment on exported type SetupRequest should be of the form "SetupRequest ..." (with optional leading article) (golint)
  • Line 115: warning: comment on exported type InitialSetupResult should be of the form "InitialSetupResult ..." (with optional leading article) (golint)

• overlord/configstate/config/helpers.go
  • Line 37: warning: exported function ParseKey should have comment or be unexported (golint)
  • Line 85: warning: exported function PatchConfig should have comment or be unexported (golint)
  • Line 128: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• gadget/gadget.go
  • Line 56: warning: exported const SystemBoot should have comment (or a comment on this block) or be unexported (golint)
  • Line 97: warning: exported type Info should have comment or be unexported (golint)
  • Line 207: warning: exported type VolumeUpdate should have comment or be unexported (golint)
  • Line 407: warning: comment on exported type Connection should be of the form "Connection ..." (with optional leading article) (golint)
  • Line 421: warning: exported type ConnectionPlug should have comment or be unexported (golint)
  • Line 426: warning: exported method ConnectionPlug.Empty should have comment or be unexported (golint)
  • Line 430: warning: exported method ConnectionPlug.UnmarshalYAML should have comment or be unexported (golint)
  • Line 444: warning: exported type ConnectionSlot should have comment or be unexported (golint)
  • Line 449: warning: exported method ConnectionSlot.Empty should have comment or be unexported (golint)
  • Line 453: warning: exported method ConnectionSlot.UnmarshalYAML should have comment or be unexported (golint)
  • Line 1091: warning: exported method RelativeOffset.UnmarshalYAML should have comment or be unexported (golint)
  • Line 1091: warning: receiver name s should be consistent with previous receiver name r for RelativeOffset (golint)
  • Line 1245: warning: exported var ErrNoKernelCommandline should have comment or be unexported (golint)

• overlord/ifacestate/handlers.go
  • Line 291: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• snap/naming/snapref.go
  • Line 31: warning: exported method Snap.SnapName should have comment or be unexported (golint)
  • Line 35: warning: exported method Snap.ID should have comment or be unexported (golint)

• store/store_action.go
  • Line 38: warning: exported type RefreshOptions should have comment or be unexported (golint)
  • Line 49: warning: exported type CurrentSnap should have comment or be unexported (golint)
  • Line 63: warning: exported type AssertionQuery should have comment or be unexported (golint)
  • Line 84: warning: exported type SnapActionFlags should have comment or be unexported (golint)
  • Line 87: warning: exported const SnapActionIgnoreValidation should have comment (or a comment on this block) or be unexported (golint)
  • Line 91: warning: exported type SnapAction should have comment or be unexported (golint)

• gadget/gadgettest/gadgettest.go
  • Line 51: warning: exported function WriteGadgetYaml should have comment or be unexported (golint)
  • Line 105: warning: exported type ModelCharacteristics should have comment or be unexported (golint)
  • Line 110: warning: exported method ModelCharacteristics.Classic should have comment or be unexported (golint)
  • Line 114: warning: exported method ModelCharacteristics.Grade should have comment or be unexported (golint)

• overlord/snapstate/aliasesv2.go
  • Line 243: warning: exported type AliasConflictError should have comment or be unexported (golint)

• kernel/fde/reveal_key.go
  • Line 184: warning: exported function MockRunFDERevealKey should have comment or be unexported (golint)
  • Line 192: warning: exported function LockSealedKeys should have comment or be unexported (golint)

• testutil/dbustest.go
  • Line 31: warning: should not use dot imports (golint)
  • Line 66: warning: exported method DBusTest.SetUpSuite should have comment or be unexported (golint)
  • Line 97: warning: exported method DBusTest.TearDownSuite should have comment or be unexported (golint)
  • Line 111: warning: exported method DBusTest.SetUpTest should have comment or be unexported (golint)
  • Line 112: warning: exported method DBusTest.TearDownTest should have comment or be unexported (golint)
  • Line 114: warning: exported function DBusGetConnectionUnixProcessID should have comment or be unexported (golint)

• osutil/sys/syscall.go
  • Line 42: warning: comment on exported function Getuid should be of the form "Getuid ..." (golint)
  • Line 49: warning: exported function Geteuid should have comment or be unexported (golint)
  • Line 53: warning: exported function Getgid should have comment or be unexported (golint)
  • Line 57: warning: exported function Getegid should have comment or be unexported (golint)
  • Line 70: warning: exported function Chown should have comment or be unexported (golint)
  • Line 74: warning: exported function Fchown should have comment or be unexported (golint)
  • Line 82: warning: exported function ChownPath should have comment or be unexported (golint)
  • Line 87: warning: exported function FchownAt should have comment or be unexported (golint)
  • Line 99: warning: comment on exported const O_PATH should be of the form "O_PATH ..." (golint)
  • Line 103: warning: exported function FcntlGetFl should have comment or be unexported (golint)

• overlord/hookstate/hookmgr.go
  • Line 164: warning: exported method HookManager.RegisterHijack should have comment or be unexported (golint)
  • Line 289: warning: exported method HookManager.EphemeralRunHook should have comment or be unexported (golint)

• boot/boottest/model.go
  • Line 27: warning: exported function MakeMockModel should have comment or be unexported (golint)
  • Line 44: warning: exported function MakeMockUC20Model should have comment or be unexported (golint)

• spdx/scanner.go
  • Line 27: warning: exported type Scanner should have comment or be unexported (golint)
  • Line 65: warning: exported function NewScanner should have comment or be unexported (golint)

• snap/snapenv/snapenv_test.go
  • Line 83: warning: receiver name ts should be consistent with previous receiver name s for HTestSuite (golint)
  • Line 100: warning: receiver name ts should be consistent with previous receiver name s for HTestSuite (golint)
  • Line 111: warning: receiver name ts should be consistent with previous receiver name s for HTestSuite (golint)
  • Line 223: warning: receiver name ts should be consistent with previous receiver name s for HTestSuite (golint)
  • Line 237: warning: receiver name ts should be consistent with previous receiver name s for HTestSuite (golint)

• jsonutil/safejson/safejson.go
  • Line 40: warning: exported method String.UnmarshalJSON should have comment or be unexported (golint)
  • Line 59: warning: exported method Paragraph.UnmarshalJSON should have comment or be unexported (golint)

• sanity/check.go
  • Line 24: warning: exported function Check should have comment or be unexported (golint)

• overlord/state/task.go
  • Line 303: warning: exported method Task.DoingTime should have comment or be unexported (golint)
  • Line 308: warning: exported method Task.UndoingTime should have comment or be unexported (golint)
  • Line 314: warning: comment on exported const LogInfo should be of the form "LogInfo ..." (golint)
  • Line 318: warning: exported const LogError should have comment (or a comment on this block) or be unexported (golint)
  • Line 323: warning: exported function MockTime should have comment or be unexported (golint)

• interfaces/apparmor/backend.go
  • Line 598: warning: exported method Backend.RemoveLate should have comment or be unexported (golint)

• daemon/api_snap_conf.go
  • Line 77: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• asserts/sysdb/generic.go
  • Line 184: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• boot/initramfs.go
  • Line 114: warning: exported function MockInitramfsReboot should have comment or be unexported (golint)

• snap/snaptest/snaptest.go
  • Line 196: warning: exported function AssertedSnapID should have comment or be unexported (golint)

• store/store.go
  • Line 172: warning: exported var ErrTooManyRequests should have comment or be unexported (golint)
  • Line 501: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 764: warning: exported type SnapAdder should have comment or be unexported (golint)
  • Line 1145: warning: comment on exported method Store.SnapExists should be of the form "SnapExists ..." (golint)
  • Line 1697: warning: exported method Store.ConnectivityCheck should have comment or be unexported (golint)
  • Line 1714: warning: exported method Store.CreateCohorts should have comment or be unexported (golint)

• cmd/snap-seccomp/syscalls/syscalls.go
  • Line 22: warning: comment on exported var SeccompSyscalls should be of the form "SeccompSyscalls ..." (golint)

• overlord/patch/patch.go
  • Line 38: warning: exported type PatchFunc should have comment or be unexported (golint)

• overlord/state/warning.go
  • Line 34: warning: exported var DefaultRepeatAfter should have comment or be unexported (golint)
  • Line 53: warning: exported type Warning should have comment or be unexported (golint)
  • Line 72: warning: exported method Warning.MarshalJSON should have comment or be unexported (golint)
  • Line 87: warning: exported method Warning.UnmarshalJSON should have comment or be unexported (golint)
  • Line 134: warning: exported method Warning.ExpiredBefore should have comment or be unexported (golint)
  • Line 138: warning: exported method Warning.ShowAfter should have comment or be unexported (golint)

• tests/lib/fakestore/refresh/refresh.go
  • Line 57: warning: exported function MakeFakeRefreshForSnaps should have comment or be unexported (golint)

• snap/hooktypes.go
  • Line 72: warning: exported function MockSupportedHookTypes should have comment or be unexported (golint)
  • Line 78: warning: exported function MockAppendSupportedHookTypes should have comment or be unexported (golint)

• cmd/snap-preseed/main.go
  • Line 52: warning: exported var Stdout should have comment or be unexported (golint)
  • Line 58: warning: exported function Parser should have comment or be unexported (golint)

• polkit/authority.go
  • Line 28: warning: exported type CheckFlags should have comment or be unexported (golint)
  • Line 31: warning: exported const CheckNone should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported var ErrDismissed should have comment or be unexported (golint)

• tests/lib/fakestore/cmd/fakestore/main.go
  • Line 31: warning: exported type Options should have comment or be unexported (golint)

• interfaces/system_key.go
  • Line 313: warning: exported function MockSystemKey should have comment or be unexported (golint)

• boot/cmdline.go
  • Line 186: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• overlord/snapshotstate/backend/backend.go
  • Line 64: warning: error var Stop should have name of the form ErrFoo (golint)
  • Line 479: warning: exported var ErrCannotCancel should have comment or be unexported (golint)
  • Line 717: warning: exported type DuplicatedSnapshotImportError should have comment or be unexported (golint)
  • Line 850: warning: exported type SnapshotExport should have comment or be unexported (golint)
  • Line 943: warning: exported method SnapshotExport.Size should have comment or be unexported (golint)
  • Line 947: warning: exported method SnapshotExport.Close should have comment or be unexported (golint)
  • Line 958: warning: exported method SnapshotExport.StreamTo should have comment or be unexported (golint)

• store/cache.go
  • Line 66: warning: comment on exported type CacheManager should be of the form "CacheManager ..." (with optional leading article) (golint)

• seed/seed.go
  • Line 36: warning: exported var ErrNoAssertions should have comment or be unexported (golint)
  • Line 59: warning: exported method Snap.SnapName should have comment or be unexported (golint)
  • Line 63: warning: exported method Snap.ID should have comment or be unexported (golint)

• overlord/hookstate/hooks.go
  • Line 43: warning: exported function SetupInstallHook should have comment or be unexported (golint)
  • Line 56: warning: exported function SetupPostRefreshHook should have comment or be unexported (golint)
  • Line 67: warning: exported function SetupPreRefreshHook should have comment or be unexported (golint)
  • Line 155: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 263: warning: exported function NewGateAutoRefreshHookHandler should have comment or be unexported (golint)
  • Line 269: warning: exported function SetupGateAutoRefreshHook should have comment or be unexported (golint)
  • Line 295: warning: exported function SetupRemoveHook should have comment or be unexported (golint)

• daemon/api_apps.go
  • Line 159: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• daemon/api_users.go
  • Line 397: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• osutil/chattr.go
  • Line 29: warning: comment on exported const FS_SECRM_FL should be of the form "FS_SECRM_FL ..." (golint)
  • Line 31: warning: exported const FS_UNRM_FL should have comment (or a comment on this block) or be unexported (golint)

• overlord/devicestate/devicestatetest/state.go
  • Line 28: warning: exported function Device should have comment or be unexported (golint)
  • Line 32: warning: exported function SetDevice should have comment or be unexported (golint)

• desktop/notification/notify.go
  • Line 74: warning: exported type Priority should have comment or be unexported (golint)
  • Line 77: warning: exported const PriorityNormal should have comment (or a comment on this block) or be unexported (golint)

• overlord/storecontext/context.go
  • Line 66: warning: exported type DeviceSessionRequestSigner should have comment or be unexported (golint)
  • Line 71: warning: exported type ProxyStoreer should have comment or be unexported (golint)
  • Line 194: warning: exported type DeviceSessionRequestParams should have comment or be unexported (golint)

• client/cohort.go
  • Line 30: warning: exported type CohortAction should have comment or be unexported (golint)
  • Line 35: warning: exported method Client.CreateCohorts should have comment or be unexported (golint)

• interfaces/systemd/spec.go
  • Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• osutil/udev/netlink/uevent.go
  • Line 14: warning: exported const ADD should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported type KObjAction should have comment or be unexported (golint)
  • Line 33: warning: exported function ParseKObjAction should have comment or be unexported (golint)
  • Line 43: warning: exported type UEvent should have comment or be unexported (golint)
  • Line 57: warning: exported method UEvent.Bytes should have comment or be unexported (golint)
  • Line 61: warning: exported method UEvent.Equal should have comment or be unexported (golint)
  • Line 141: warning: exported function ParseUEvent should have comment or be unexported (golint)

• overlord/snapstate/autorefresh.go
  • Line 677: warning: comment on exported function MockRefreshCandidate should be of the form "MockRefreshCandidate ..." (golint)

• daemon/daemon.go
  • Line 55: warning: exported var ErrRestartSocket should have comment or be unexported (golint)

• client/systems.go
  • Line 43: warning: exported type System should have comment or be unexported (golint)
  • Line 57: warning: exported type SystemAction should have comment or be unexported (golint)

• strutil/shlex/shlex_test.go
  • Line 144: warning: error var nastyReaderErr should have name of the form errFoo (golint)

• strutil/quantity/quantity.go
  • Line 31: warning: exported function FormatAmount should have comment or be unexported (golint)
  • Line 84: warning: exported function FormatBPS should have comment or be unexported (golint)
  • Line 114: warning: comment on exported function FormatDuration should be of the form "FormatDuration ..." (golint)

• wrappers/icons.go
  • Line 94: warning: exported function AddSnapIcons should have comment or be unexported (golint)
  • Line 114: warning: exported function RemoveSnapIcons should have comment or be unexported (golint)

• interfaces/builtin/kernel_module_load.go
  • Line 48: warning: error var modulesAttrTypeError should have name of the form errFoo (golint)
  • Line 63: warning: exported type ModuleInfo should have comment or be unexported (golint)

• overlord/devicestate/handlers_install.go
  • Line 562: warning: exported const RebootHaltOp should have comment (or a comment on this block) or be unexported (golint)

• overlord/servicestate/servicestate.go
  • Line 42: warning: exported type Instruction should have comment or be unexported (golint)
  • Line 50: warning: exported type ServiceActionConflictError should have comment or be unexported (golint)

• asserts/model.go
  • Line 332: warning: exported const ModelGradeUnset should have comment (or a comment on this block) or be unexported (golint)
  • Line 347: warning: exported const StorageSafetyUnset should have comment (or a comment on this block) or be unexported (golint)

• sandbox/cgroup/tracking.go
  • Line 22: warning: exported var ErrCannotTrackProcess should have comment or be unexported (golint)

• image/options.go
  • Line 22: warning: exported type Options should have comment or be unexported (golint)
  • Line 46: warning: comment on exported type Customizations should be of the form "Customizations ..." (with optional leading article) (golint)

• overlord/ifacestate/ifacemgr.go
  • Line 252: warning: exported type ConnectionState should have comment or be unexported (golint)

• interfaces/builtin/utils.go
  • Line 35: warning: comment on exported const UsbMaxInterfaces should be of the form "UsbMaxInterfaces ..." (golint)

• asserts/membackstore.go
  • Line 178: warning: receiver name left should be consistent with previous receiver name leaf for memBSLeaf (golint)

• snap/validate.go
  • Line 1064: warning: exported function ValidateCommonIDs should have comment or be unexported (golint)
  • Line 1078: warning: exported function ValidateSystemUsernames should have comment or be unexported (golint)

• logger/logger.go
  • Line 122: warning: exported type Log should have comment or be unexported (golint)

• store/devicenauthctx.go
  • Line 53: warning: exported method DeviceSessionRequestParams.EncodedRequest should have comment or be unexported (golint)
  • Line 57: warning: exported method DeviceSessionRequestParams.EncodedSerial should have comment or be unexported (golint)
  • Line 61: warning: exported method DeviceSessionRequestParams.EncodedModel should have comment or be unexported (golint)

• systemd/systemd.go
  • Line 69: warning: comment on exported var Version should be of the form "Version ..." (golint)
  • Line 126: warning: exported function MockSystemdVersion should have comment or be unexported (golint)
  • Line 160: warning: exported function Available should have comment or be unexported (golint)
  • Line 256: warning: exported function MockJournalctl should have comment or be unexported (golint)
  • Line 264: warning: exported type MountUnitOptions should have comment or be unexported (golint)
  • Line 383: warning: comment on exported const ServicesTarget should be of the form "ServicesTarget ..." (golint)
  • Line 386: warning: comment on exported const PrerequisiteTarget should be of the form "PrerequisiteTarget ..." (golint)
  • Line 389: warning: comment on exported const SocketsTarget should be of the form "SocketsTarget ..." (golint)
  • Line 392: warning: comment on exported const TimersTarget should be of the form "TimersTarget ..." (golint)
  • Line 395: warning: comment on exported const UserServicesTarget should be of the form "UserServicesTarget ..." (golint)
  • Line 399: warning: exported type Reporter should have comment or be unexported (golint)
  • Line 448: warning: exported const SystemMode should have comment (or a comment on this block) or be unexported (golint)
  • Line 572: warning: exported type UnitStatus should have comment or be unexported (golint)
  • Line 1030: warning: exported method Error.Msg should have comment or be unexported (golint)
  • Line 1034: warning: exported method Error.ExitCode should have comment or be unexported (golint)
  • Line 1206: warning: exported type UnitLifetime should have comment or be unexported (golint)
  • Line 1209: warning: exported const Persistent should have comment (or a comment on this block) or be unexported (golint)

• usersession/userd/privileged_desktop_launcher.go
  • Line 58: warning: comment on exported method PrivilegedDesktopLauncher.Interface should be of the form "Interface ..." (golint)
  • Line 63: warning: comment on exported method PrivilegedDesktopLauncher.ObjectPath should be of the form "ObjectPath ..." (golint)

• overlord/snapstate/progress.go
  • Line 46: warning: comment on exported function NewTaskProgressAdapterLocked should be of the form "NewTaskProgressAdapterLocked ..." (golint)

• overlord/devicestate/handlers_serial.go
  • Line 843: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• overlord/snapstate/snapmgr.go
  • Line 117: warning: exported method SnapSetup.InstanceName should have comment or be unexported (golint)
  • Line 121: warning: exported method SnapSetup.SnapName should have comment or be unexported (golint)
  • Line 128: warning: exported method SnapSetup.Revision should have comment or be unexported (golint)
  • Line 136: warning: exported method SnapSetup.MountDir should have comment or be unexported (golint)
  • Line 140: warning: exported method SnapSetup.MountFile should have comment or be unexported (golint)
  • Line 150: warning: exported const DefaultStatus should have comment (or a comment on this block) or be unexported (golint)
  • Line 212: warning: exported method SnapState.SetTrackingChannel should have comment or be unexported (golint)
  • Line 316: warning: exported var ErrNoCurrent should have comment or be unexported (golint)
  • Line 329: warning: exported var AutomaticSnapshotExpiration should have comment or be unexported (golint)
  • Line 330: warning: exported var EstimateSnapshotSize should have comment or be unexported (golint)
  • Line 383: warning: exported method SnapState.InstanceName should have comment or be unexported (golint)
  • Line 527: warning: exported method SnapManager.CanStandby should have comment or be unexported (golint)

• overlord/snapstate/backend/mountns.go
  • Line 26: warning: comment on exported method Backend.DiscardSnapNamespace should be of the form "DiscardSnapNamespace ..." (golint)

• timings/state.go
  • Line 54: warning: comment on exported var MaxTimings should be of the form "MaxTimings ..." (golint)
  • Line 57: warning: comment on exported var DurationThreshold should be of the form "DurationThreshold ..." (golint)

• osutil/strace/strace.go
  • Line 47: warning: comment on exported var ExcludedSyscalls should be of the form "ExcludedSyscalls ..." (golint)

• overlord/snapstate/policy.go
  • Line 20: warning: exported var PolicyFor should have comment or be unexported (golint)

• httputil/retry.go
  • Line 39: warning: exported type PersistentNetworkError should have comment or be unexported (golint)
  • Line 47: warning: exported function MaybeLogRetryAttempt should have comment or be unexported (golint)
  • Line 65: warning: exported function ShouldRetryHttpResponse should have comment or be unexported (golint)
  • Line 94: warning: exported function ShouldRetryAttempt should have comment or be unexported (golint)

• osutil/udev/crawler/device.go
  • Line 16: warning: exported const BASE_DEVPATH should have comment (or a comment on this block) or be unexported (golint)
  • Line 19: warning: exported type Device should have comment or be unexported (golint)

• gadget/gadgettest/examples.go
  • Line 34: warning: comment on exported const RaspiSimplifiedYaml should be of the form "RaspiSimplifiedYaml ..." (golint)
  • Line 63: warning: exported var ExpectedRaspiDiskVolumeDeviceTraits should have comment or be unexported (golint)
  • Line 149: warning: exported var ExpectedRaspiMockDiskMapping should have comment or be unexported (golint)
  • Line 258: warning: exported const ExpectedRaspiDiskVolumeDeviceTraitsJSON should have comment or be unexported (golint)
  • Line 325: warning: exported const MockExtraVolumeYAML should have comment or be unexported (golint)
  • Line 343: warning: exported var MockExtraVolumeDiskMapping should have comment or be unexported (golint)
  • Line 389: warning: exported var MockExtraVolumeDeviceTraits should have comment or be unexported (golint)
  • Line 429: warning: exported const MultiVolumeUC20GadgetYaml should have comment or be unexported (golint)
  • Line 480: warning: exported var VMExtraVolumeDiskMapping should have comment or be unexported (golint)
  • Line 525: warning: exported var VMSystemVolumeDiskMapping should have comment or be unexported (golint)
  • Line 612: warning: exported var VMExtraVolumeDeviceTraits should have comment or be unexported (golint)
  • Line 650: warning: exported var VMSystemVolumeDeviceTraits should have comment or be unexported (golint)
  • Line 719: warning: exported const VMMultiVolumeUC20DiskTraitsJSON should have comment or be unexported (golint)
  • Line 832: warning: comment on exported const UC16YAMLImplicitSystemData should be of the form "UC16YAMLImplicitSystemData ..." (golint)
  • Line 853: warning: comment on exported var UC16DeviceLayout should be of the form "UC16DeviceLayout ..." (golint)
  • Line 912: warning: exported var UC16ImplicitSystemDataMockDiskMapping should have comment or be unexported (golint)
  • Line 971: warning: exported var UC16ImplicitSystemDataDeviceTraits should have comment or be unexported (golint)

• overlord/assertstate/validation_set_tracking.go
  • Line 40: warning: exported const Monitor should have comment (or a comment on this block) or be unexported (golint)

• gadget/quantity/size.go
  • Line 77: warning: exported method Size.UnmarshalYAML should have comment or be unexported (golint)

• asserts/internal/grouping.go
  • Line 70: warning: exported type Grouping should have comment or be unexported (golint)
  • Line 75: warning: exported method Grouping.Copy should have comment or be unexported (golint)

• gadget/ondisk.go
  • Line 88: warning: exported function OnDiskVolumeFromDisk should have comment or be unexported (golint)
  • Line 144: warning: exported function OnDiskStructureFromPartition should have comment or be unexported (golint)

• osutil/disk.go
  • Line 31: warning: exported type NotEnoughDiskSpaceError should have comment or be unexported (golint)

• osutil/io.go
  • Line 117: warning: exported method AtomicFile.Close should have comment or be unexported (golint)
  • Line 146: warning: exported const NoChown should have comment or be unexported (golint)
  • Line 211: warning: comment on exported function AtomicWrite should be of the form "AtomicWrite ..." (golint)
  • Line 227: warning: exported function AtomicWriteFile should have comment or be unexported (golint)
  • Line 231: warning: exported function AtomicWriteFileChown should have comment or be unexported (golint)
  • Line 235: warning: exported function AtomicWriteChown should have comment or be unexported (golint)

• interfaces/repo.go
  • Line 543: warning: exported type PolicyFunc should have comment or be unexported (golint)
  • Line 800: warning: exported method Repository.Connections should have comment or be unexported (golint)

• bootloader/lkenv/lkenv_v2.go
  • Line 40: warning: don't use underscores in Go names; type SnapBootSelect_v2_recovery should be SnapBootSelectV2Recovery (golint)
  • Line 40: warning: exported type SnapBootSelect_v2_recovery should have comment or be unexported (golint)
  • Line 49: warning: don't use underscores in Go names; struct field Snapd_recovery_mode should be SnapdRecoveryMode (golint)
  • Line 55: warning: don't use underscores in Go names; struct field Snapd_recovery_system should be SnapdRecoverySystem (golint)
  • Line 98: warning: don't use underscores in Go names; struct field Bootimg_matrix should be BootimgMatrix (golint)
  • Line 102: warning: don't use underscores in Go names; struct field Bootimg_file_name should be BootimgFileName (golint)
  • Line 108: warning: don't use underscores in Go names; struct field Try_recovery_system should be TryRecoverySystem (golint)
  • Line 115: warning: don't use underscores in Go names; struct field Recovery_system_status should be RecoverySystemStatus (golint)
  • Line 118: warning: don't use underscores in Go names; struct field Unused_key_01 should be UnusedKey01 (golint)
  • Line 119: warning: don't use underscores in Go names; struct field Unused_key_02 should be UnusedKey02 (golint)
  • Line 120: warning: don't use underscores in Go names; struct field Unused_key_03 should be UnusedKey03 (golint)
  • Line 121: warning: don't use underscores in Go names; struct field Unused_key_04 should be UnusedKey04 (golint)
  • Line 122: warning: don't use underscores in Go names; struct field Unused_key_05 should be UnusedKey05 (golint)
  • Line 123: warning: don't use underscores in Go names; struct field Unused_key_06 should be UnusedKey06 (golint)
  • Line 124: warning: don't use underscores in Go names; struct field Unused_key_07 should be UnusedKey07 (golint)
  • Line 125: warning: don't use underscores in Go names; struct field Unused_key_08 should be UnusedKey08 (golint)
  • Line 126: warning: don't use underscores in Go names; struct field Unused_key_09 should be UnusedKey09 (golint)
  • Line 127: warning: don't use underscores in Go names; struct field Unused_key_10 should be UnusedKey10 (golint)
  • Line 128: warning: don't use underscores in Go names; struct field Unused_key_11 should be UnusedKey11 (golint)
  • Line 129: warning: don't use underscores in Go names; struct field Unused_key_12 should be UnusedKey12 (golint)
  • Line 130: warning: don't use underscores in Go names; struct field Unused_key_13 should be UnusedKey13 (golint)
  • Line 131: warning: don't use underscores in Go names; struct field Unused_key_14 should be UnusedKey14 (golint)
  • Line 132: warning: don't use underscores in Go names; struct field Unused_key_15 should be UnusedKey15 (golint)
  • Line 133: warning: don't use underscores in Go names; struct field Unused_key_16 should be UnusedKey16 (golint)
  • Line 134: warning: don't use underscores in Go names; struct field Unused_key_17 should be UnusedKey17 (golint)
  • Line 135: warning: don't use underscores in Go names; struct field Unused_key_18 should be UnusedKey18 (golint)
  • Line 138: warning: don't use underscores in Go names; struct field Key_value_pairs should be KeyValuePairs (golint)
  • Line 194: warning: don't use underscores in Go names; type SnapBootSelect_v2_run should be SnapBootSelectV2Run (golint)
  • Line 194: warning: exported type SnapBootSelect_v2_run should have comment or be unexported (golint)
  • Line 201: warning: don't use underscores in Go names; struct field Kernel_status should be KernelStatus (golint)
  • Line 203: warning: don't use underscores in Go names; struct field Snap_kernel should be SnapKernel (golint)
  • Line 205: warning: don't use underscores in Go names; struct field Snap_try_kernel should be SnapTryKernel (golint)
  • Line 208: warning: don't use underscores in Go names; struct field Gadget_mode should be GadgetMode (golint)
  • Line 210: warning: don't use underscores in Go names; struct field Snap_gadget should be SnapGadget (golint)
  • Line 212: warning: don't use underscores in Go names; struct field Snap_try_gadget should be SnapTryGadget (golint)
  • Line 252: warning: don't use underscores in Go names; struct field Bootimg_matrix should be BootimgMatrix (golint)
  • Line 256: warning: don't use underscores in Go names; struct field Bootimg_file_name should be BootimgFileName (golint)
  • Line 270: warning: don't use underscores in Go names; struct field Gadget_asset_matrix should be GadgetAssetMatrix (golint)
  • Line 273: warning: don't use underscores in Go names; struct field Unused_key_01 should be UnusedKey01 (golint)
  • Line 274: warning: don't use underscores in Go names; struct field Unused_key_02 should be UnusedKey02 (golint)
  • Line 275: warning: don't use underscores in Go names; struct field Unused_key_03 should be UnusedKey03 (golint)
  • Line 276: warning: don't use underscores in Go names; struct field Unused_key_04 should be UnusedKey04 (golint)
  • Line 277: warning: don't use underscores in Go names; struct field Unused_key_05 should be UnusedKey05 (golint)
  • Line 278: warning: don't use underscores in Go names; struct field Unused_key_06 should be UnusedKey06 (golint)
  • Line 279: warning: don't use underscores in Go names; struct field Unused_key_07 should be UnusedKey07 (golint)
  • Line 280: warning: don't use underscores in Go names; struct field Unused_key_08 should be UnusedKey08 (golint)
  • Line 281: warning: don't use underscores in Go names; struct field Unused_key_09 should be UnusedKey09 (golint)
  • Line 282: warning: don't use underscores in Go names; struct field Unused_key_10 should be UnusedKey10 (golint)
  • Line 283: warning: don't use underscores in Go names; struct field Unused_key_11 should be UnusedKey11 (golint)
  • Line 284: warning: don't use underscores in Go names; struct field Unused_key_12 should be UnusedKey12 (golint)
  • Line 285: warning: don't use underscores in Go names; struct field Unused_key_13 should be UnusedKey13 (golint)
  • Line 286: warning: don't use underscores in Go names; struct field Unused_key_14 should be UnusedKey14 (golint)
  • Line 287: warning: don't use underscores in Go names; struct field Unused_key_15 should be UnusedKey15 (golint)
  • Line 288: warning: don't use underscores in Go names; struct field Unused_key_16 should be UnusedKey16 (golint)
  • Line 289: warning: don't use underscores in Go names; struct field Unused_key_17 should be UnusedKey17 (golint)
  • Line 290: warning: don't use underscores in Go names; struct field Unused_key_18 should be UnusedKey18 (golint)
  • Line 291: warning: don't use underscores in Go names; struct field Unused_key_19 should be UnusedKey19 (golint)
  • Line 292: warning: don't use underscores in Go names; struct field Unused_key_20 should be UnusedKey20 (golint)
  • Line 295: warning: don't use underscores in Go names; struct field Key_value_pairs should be KeyValuePairs (golint)

• boot/boot.go
  • Line 365: warning: exported var ErrUnsupportedSystemMode should have comment or be unexported (golint)

• asserts/validation_set.go
  • Line 36: warning: exported const PresenceRequired should have comment (or a comment on this block) or be unexported (golint)
  • Line 264: warning: exported function IsValidValidationSetName should have comment or be unexported (golint)

• overlord/snapstate/handlers.go
  • Line 67: warning: exported var EnsureSnapAbsentFromQuotaGroup should have comment or be unexported (golint)
  • Line 71: warning: exported var SecurityProfilesRemoveLate should have comment or be unexported (golint)
  • Line 778: warning: exported var ErrKernelGadgetUpdateTaskMissing should have comment or be unexported (golint)
  • Line 3594: warning: exported function InjectAutoConnect should have comment or be unexported (golint)

• dbusutil/netplantest/netplantest.go
  • Line 20: warning: package comment should be of the form "Package netplantest ..." (golint)
  • Line 42: warning: exported type NetplanServer should have comment or be unexported (golint)
  • Line 69: warning: exported function NewNetplanServer should have comment or be unexported (golint)
  • Line 94: warning: exported method NetplanServer.ExportApiV1 should have comment or be unexported (golint)
  • Line 100: warning: exported method NetplanServer.ExportApiV2 should have comment or be unexported (golint)
  • Line 106: warning: exported method NetplanServer.Stop should have comment or be unexported (golint)

• interfaces/udev/spec.go
  • Line 212: warning: exported method Specification.TriggeredSubsystems should have comment or be unexported (golint)

• wrappers/dbus.go
  • Line 101: warning: exported function AddSnapDBusActivationFiles should have comment or be unexported (golint)
  • Line 167: warning: exported function RemoveSnapDBusActivationFiles should have comment or be unexported (golint)

• asserts/snapasserts/snapasserts.go
  • Line 31: warning: exported type Finder should have comment or be unexported (golint)

• asserts/ifacedecls.go
  • Line 82: warning: exported var AlwaysMatchAttributes should have comment or be unexported (golint)
  • Line 92: warning: receiver name c should be consistent with previous receiver name ac for AttributeConstraints (golint)

• desktop/portal/document.go
  • Line 44: warning: exported type Document should have comment or be unexported (golint)
  • Line 63: warning: exported method Document.GetDefaultMountPoint should have comment or be unexported (golint)
  • Line 72: warning: exported method Document.GetMountPoint should have comment or be unexported (golint)

• overlord/configstate/proxyconf/proxy.go
  • Line 31: warning: exported type ProxySettings should have comment or be unexported (golint)
  • Line 35: warning: exported function New should have comment or be unexported (golint)
  • Line 39: warning: exported method ProxySettings.Conf should have comment or be unexported (golint)

• interfaces/ifacetest/backend.go
  • Line 79: warning: exported method TestSecurityBackend.NewSpecification should have comment or be unexported (golint)
  • Line 83: warning: exported method TestSecurityBackend.SandboxFeatures should have comment or be unexported (golint)
  • Line 107: warning: exported method TestSecurityBackendSetupMany.SetupMany should have comment or be unexported (golint)
  • Line 123: warning: exported method TestSecurityBackendDiscardingLate.RemoveLate should have comment or be unexported (golint)

• image/helpers.go
  • Line 198: warning: exported function NewToolingStoreFromModel should have comment or be unexported (golint)
  • Line 207: warning: exported function NewToolingStore should have comment or be unexported (golint)
  • Line 262: warning: exported type DownloadedSnap should have comment or be unexported (golint)
  • Line 363: warning: exported type SnapToDownload should have comment or be unexported (golint)
  • Line 369: warning: exported type CurrentSnap should have comment or be unexported (golint)
  • Line 377: warning: exported type DownloadManyOptions should have comment or be unexported (golint)

• osutil/mountinfo_linux.go
  • Line 92: warning: comment on exported function MockProcSelfMountInfoLocation should be of the form "MockProcSelfMountInfoLocation ..." (golint)
  • Line 99: warning: exported function MockMountInfo should have comment or be unexported (golint)

• overlord/snapshotstate/snapshotmgr.go
  • Line 96: warning: exported method SnapshotManager.StartUp should have comment or be unexported (golint)
  • Line 453: warning: exported function MockBackendSave should have comment or be unexported (golint)

• seed/internal/helpers.go
  • Line 27: warning: exported function MakeSystemSnap should have comment or be unexported (golint)

• snap/internal/file.go
  • Line 32: warning: exported function NewSizedFile should have comment or be unexported (golint)
  • Line 40: warning: exported method SizedFile.Size should have comment or be unexported (golint)

• snap/info.go
  • Line 534: warning: exported function DataHomeGlob should have comment or be unexported (golint)
  • Line 710: warning: exported type AttributeNotFoundError should have comment or be unexported (golint)
  • Line 716: warning: exported method AttributeNotFoundError.Is should have comment or be unexported (golint)
  • Line 763: warning: exported method PlugInfo.Attr should have comment or be unexported (golint)
  • Line 767: warning: exported method PlugInfo.Lookup should have comment or be unexported (golint)
  • Line 789: warning: exported method SlotInfo.Attr should have comment or be unexported (golint)
  • Line 793: warning: exported method SlotInfo.Lookup should have comment or be unexported (golint)
  • Line 965: warning: exported type MediaInfo should have comment or be unexported (golint)
  • Line 972: warning: exported type MediaInfos should have comment or be unexported (golint)
  • Line 974: warning: exported method MediaInfos.IconURL should have comment or be unexported (golint)
  • Line 1159: warning: exported type NotFoundError should have comment or be unexported (golint)
  • Line 1174: warning: exported method NotFoundError.Broken should have comment or be unexported (golint)
  • Line 1192: warning: exported function MockSanitizePlugsSlots should have comment or be unexported (golint)
  • Line 1198: warning: exported var SanitizePlugsSlots should have comment or be unexported (golint)

• cmd/snap/cmd_debug_timings.go
  • Line 57: warning: exported type Timing should have comment or be unexported (golint)

• desktop/notification/notificationtest/gtk.go
  • Line 38: warning: exported type GtkNotification should have comment or be unexported (golint)
  • Line 44: warning: exported type GtkServer should have comment or be unexported (golint)
  • Line 52: warning: exported function NewGtkServer should have comment or be unexported (golint)
  • Line 77: warning: exported method GtkServer.Get should have comment or be unexported (golint)
  • Line 84: warning: exported method GtkServer.GetAll should have comment or be unexported (golint)
  • Line 98: warning: exported method GtkServer.ReleaseName should have comment or be unexported (golint)
  • Line 105: warning: exported method GtkServer.Stop should have comment or be unexported (golint)
  • Line 120: warning: exported method GtkServer.Close should have comment or be unexported (golint)

• errtracker/errtracker.go
  • Line 49: warning: exported var CrashDbURLBase should have comment or be unexported (golint)

• daemon/api_interfaces.go
  • Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• store/errors.go
  • Line 196: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• gadget/device.go
  • Line 25: warning: exported var ErrDeviceNotFound should have comment or be unexported (golint)

• overlord/ifacestate/ifacestate.go
  • Line 48: warning: exported const ConnectTaskEdge should have comment (or a comment on this block) or be unexported (golint)
  • Line 541: warning: exported function MockConnectRetryTimeout should have comment or be unexported (golint)

• interfaces/builtin/mount_control.go
  • Line 53: warning: error var mountAttrTypeError should have name of the form errFoo (golint)
  • Line 186: warning: exported type MountInfo should have comment or be unexported (golint)

• bootloader/grubenv/grubenv.go
  • Line 31: warning: comment on exported type Env should be of the form "Env ..." (with optional leading article) (golint)
  • Line 39: warning: exported function NewEnv should have comment or be unexported (golint)
  • Line 46: warning: exported method Env.Get should have comment or be unexported (golint)
  • Line 50: warning: exported method Env.Set should have comment or be unexported (golint)
  • Line 58: warning: exported method Env.Load should have comment or be unexported (golint)
  • Line 85: warning: exported method Env.Save should have comment or be unexported (golint)

• progress/progress.go
  • Line 61: warning: exported method NullMeter.Start should have comment or be unexported (golint)
  • Line 62: warning: exported method NullMeter.Set should have comment or be unexported (golint)
  • Line 63: warning: exported method NullMeter.SetTotal should have comment or be unexported (golint)
  • Line 64: warning: exported method NullMeter.Finished should have comment or be unexported (golint)
  • Line 66: warning: exported method NullMeter.Notify should have comment or be unexported (golint)
  • Line 67: warning: exported method NullMeter.Spin should have comment or be unexported (golint)
  • Line 72: warning: exported method QuietMeter.Notify should have comment or be unexported (golint)
  • Line 79: warning: exported function MockMeter should have comment or be unexported (golint)

• timeutil/synchronized.go
  • Line 42: warning: exported type NoTimedate1Error should have comment or be unexported (golint)

• osutil/disks/mockdisk.go
  • Line 61: warning: comment on exported method MockDiskMapping.FindMatchingPartitionWithFsLabel should be of the form "FindMatchingPartitionWithFsLabel ..." (golint)
  • Line 79: warning: comment on exported method MockDiskMapping.FindMatchingPartitionWithPartLabel should be of the form "FindMatchingPartitionWithPartLabel ..." (golint)
  • Line 96: warning: exported method MockDiskMapping.FindMatchingPartitionUUIDWithFsLabel should have comment or be unexported (golint)
  • Line 104: warning: exported method MockDiskMapping.FindMatchingPartitionUUIDWithPartLabel should have comment or be unexported (golint)
  • Line 112: warning: exported method MockDiskMapping.Partitions should have comment or be unexported (golint)
  • Line 148: warning: exported method MockDiskMapping.KernelDeviceNode should have comment or be unexported (golint)
  • Line 152: warning: exported method MockDiskMapping.KernelDevicePath should have comment or be unexported (golint)
  • Line 156: warning: exported method MockDiskMapping.DiskID should have comment or be unexported (golint)
  • Line 160: warning: exported method MockDiskMapping.Schema should have comment or be unexported (golint)
  • Line 164: warning: exported method MockDiskMapping.SectorSize should have comment or be unexported (golint)
  • Line 168: warning: exported method MockDiskMapping.UsableSectorsEnd should have comment or be unexported (golint)
  • Line 172: warning: exported method MockDiskMapping.SizeInBytes should have comment or be unexported (golint)

• seed/internal/seed_yaml.go
  • Line 58: warning: exported type Seed16 should have comment or be unexported (golint)
  • Line 62: warning: exported function ReadSeedYaml should have comment or be unexported (golint)

• snap/channel/channel.go
  • Line 47: warning: exported function Full should have comment or be unexported (golint)
  • Line 270: warning: exported var ErrPinnedTrackSwitch should have comment or be unexported (golint)

• gadget/raw.go
  • Line 25: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• interfaces/builtin/all.go
  • Line 68: warning: exported function SanitizePlugsSlots should have comment or be unexported (golint)
  • Line 141: warning: exported function MockInterface should have comment or be unexported (golint)

• osutil/uname.go
  • Line 22: warning: exported var KernelVersion should have comment or be unexported (golint)
  • Line 53: warning: exported function MachineName should have comment or be unexported (golint)

• bootloader/bootloadertest/bootloadertest.go
  • Line 66: warning: exported function Mock should have comment or be unexported (golint)
  • Line 83: warning: exported method MockBootloader.SetBootVars should have comment or be unexported (golint)
  • Line 95: warning: exported method MockBootloader.GetBootVars should have comment or be unexported (golint)
  • Line 106: warning: exported method MockBootloader.Name should have comment or be unexported (golint)
  • Line 110: warning: exported method MockBootloader.Present should have comment or be unexported (golint)
  • Line 114: warning: exported method MockBootloader.ExtractKernelAssets should have comment or be unexported (golint)
  • Line 119: warning: exported method MockBootloader.RemoveKernelAssets should have comment or be unexported (golint)
  • Line 124: warning: exported method MockBootloader.SetEnabledKernel should have comment or be unexported (golint)
  • Line 135: warning: exported method MockBootloader.SetEnabledTryKernel should have comment or be unexported (golint)
  • Line 216: warning: exported type ExtractedRecoveryKernelCall should have comment or be unexported (golint)
  • Line 274: warning: exported method MockExtractedRunKernelImageBootloader.SetEnabledKernel should have comment or be unexported (golint)
  • Line 279: warning: exported method MockExtractedRunKernelImageBootloader.SetEnabledTryKernel should have comment or be unexported (golint)
  • Line 442: warning: exported method MockBootloader.WithTrustedAssets should have comment or be unexported (golint)
  • Line 448: warning: exported method MockTrustedAssetsMixin.ManagedAssets should have comment or be unexported (golint)
  • Line 452: warning: exported method MockTrustedAssetsMixin.UpdateBootConfig should have comment or be unexported (golint)
  • Line 476: warning: exported method MockTrustedAssetsMixin.CommandLine should have comment or be unexported (golint)
  • Line 483: warning: exported method MockTrustedAssetsMixin.CandidateCommandLine should have comment or be unexported (golint)
  • Line 490: warning: exported method MockTrustedAssetsMixin.TrustedAssets should have comment or be unexported (golint)
  • Line 495: warning: exported method MockTrustedAssetsMixin.RecoveryBootChain should have comment or be unexported (golint)
  • Line 500: warning: exported method MockTrustedAssetsMixin.BootChain should have comment or be unexported (golint)
  • Line 516: warning: exported method MockBootloader.WithRecoveryAwareTrustedAssets should have comment or be unexported (golint)

• boot/systems.go
  • Line 179: warning: exported function IsInconsistentRecoverySystemState should have comment or be unexported (golint)
  • Line 184: warning: comment on exported function InitramfsIsTryingRecoverySystem should be of the form "InitramfsIsTryingRecoverySystem ..." (golint)
  • Line 244: warning: exported type TryRecoverySystemOutcome should have comment or be unexported (golint)
  • Line 247: warning: exported const TryRecoverySystemOutcomeFailure should have comment (or a comment on this block) or be unexported (golint)
  • Line 258: warning: comment on exported function EnsureNextBootToRunModeWithTryRecoverySystemOutcome should be of the form "EnsureNextBootToRunModeWithTryRecoverySystemOutcome ..." (golint)

• client/snap_op.go
  • Line 33: warning: exported type SnapOptions should have comment or be unexported (golint)
  • Line 113: warning: exported method Client.InstallMany should have comment or be unexported (golint)
  • Line 122: warning: exported method Client.RemoveMany should have comment or be unexported (golint)
  • Line 132: warning: exported method Client.RefreshMany should have comment or be unexported (golint)
  • Line 136: warning: exported method Client.Enable should have comment or be unexported (golint)
  • Line 140: warning: exported method Client.Disable should have comment or be unexported (golint)
  • Line 172: warning: exported var ErrDangerousNotApplicable should have comment or be unexported (golint)
  • Line 279: warning: comment on exported method Client.Try should be of the form "Try ..." (golint)
  • Line 380: warning: exported type DownloadInfo should have comment or be unexported (golint)
  • Line 387: warning: exported type DownloadOptions should have comment or be unexported (golint)

• overlord/assertstate/assertmgr.go
  • Line 128: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seed/validate.go
  • Line 33: warning: exported type ValidationError should have comment or be unexported (golint)

• overlord/snapstate/snapstatetest/restart.go
  • Line 31: warning: exported method MockRestartHandler.HandleRestart should have comment or be unexported (golint)
  • Line 38: warning: exported method MockRestartHandler.RebootAsExpected should have comment or be unexported (golint)
  • Line 42: warning: exported method MockRestartHandler.RebootDidNotHappen should have comment or be unexported (golint)

• sandbox/selinux/selinux_linux.go
  • Line 40: warning: comment on exported function IsEnforcing should be of the form "IsEnforcing ..." (golint)

• client/aliases.go
  • Line 56: warning: comment on exported method Client.DisableAllAliases should be of the form "DisableAllAliases ..." (golint)

• snap/naming/validate.go
  • Line 158: warning: comment on exported function ValidateSocket should be of the form "ValidateSocket ..." (golint)

• snapdtool/version.go
  • Line 30: warning: exported function MockVersion should have comment or be unexported (golint)

• usersession/userd/userd.go
  • Line 39: warning: exported type Userd should have comment or be unexported (golint)
  • Line 53: warning: exported method Userd.Init should have comment or be unexported (golint)
  • Line 92: warning: exported method Userd.Start should have comment or be unexported (golint)
  • Line 109: warning: exported method Userd.Stop should have comment or be unexported (golint)
  • Line 114: warning: exported method Userd.Dying should have comment or be unexported (golint)

• kernel/fde/mapper.go
  • Line 29: warning: comment on exported function IsHardwareEncryptedDeviceMapperName should be of the form "IsHardwareEncryptedDeviceMapperName ..." (golint)

• gadget/edition/number.go
  • Line 33: warning: exported method Number.UnmarshalYAML should have comment or be unexported (golint)

• overlord/devicestate/devicestatetest/gadget.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 38: warning: exported type PrepareDeviceBehavior should have comment or be unexported (golint)
  • Line 45: warning: exported function MockGadget should have comment or be unexported (golint)

• overlord/snapstate/backend/mountunit.go
  • Line 48: warning: exported method Backend.RemoveSnapMountUnits should have comment or be unexported (golint)

• snap/naming/wellknown.go
  • Line 58: warning: exported function UseStagingIDs should have comment or be unexported (golint)

• overlord/assertstate/assertstate.go
  • Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 58: warning: exported type RefreshAssertionsOptions should have comment or be unexported (golint)

• osutil/stat.go
  • Line 94: warning: don't use underscores in Go names; const W_OK should be WOK (golint)

• seed/internal/validate.go
  • Line 34: warning: comment on exported function ValidateUC20SeedSystemLabel should be of the form "ValidateUC20SeedSystemLabel ..." (golint)

• overlord/configstate/configmgr.go
  • Line 35: warning: exported function MockConfigcoreRun should have comment or be unexported (golint)
  • Line 43: warning: exported function Init should have comment or be unexported (golint)

• store/store_download.go
  • Line 133: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 197: warning: exported type HashError should have comment or be unexported (golint)
  • Line 207: warning: exported type DownloadOptions should have comment or be unexported (golint)
  • Line 355: warning: comment on exported type TransferSpeedMonitoringWriter should be of the form "TransferSpeedMonitoringWriter ..." (with optional leading article) (golint)
  • Line 784: warning: exported method Store.CacheDownloads should have comment or be unexported (golint)
  • Line 788: warning: exported method Store.SetCacheDownloads should have comment or be unexported (golint)

• osutil/udev/netlink/matcher.go
  • Line 8: warning: exported type Matcher should have comment or be unexported (golint)
  • Line 16: warning: exported type RuleDefinition should have comment or be unexported (golint)
  • Line 93: warning: exported type Env should have comment or be unexported (golint)
  • Line 95: warning: exported method Env.Evaluate should have comment or be unexported (golint)
  • Line 121: warning: exported method RuleDefinitions.AddRule should have comment or be unexported (golint)
  • Line 125: warning: exported method RuleDefinitions.Compile should have comment or be unexported (golint)
  • Line 134: warning: exported method RuleDefinitions.Evaluate should have comment or be unexported (golint)

• overlord/ifacestate/udevmonitor/udevmon.go
  • Line 33: warning: exported type Interface should have comment or be unexported (golint)
  • Line 39: warning: exported type DeviceAddedFunc should have comment or be unexported (golint)
  • Line 40: warning: exported type DeviceRemovedFunc should have comment or be unexported (golint)
  • Line 41: warning: exported type EnumerationDoneFunc should have comment or be unexported (golint)
  • Line 65: warning: exported function New should have comment or be unexported (golint)
  • Line 80: warning: exported method Monitor.EventsChannel should have comment or be unexported (golint)
  • Line 84: warning: exported method Monitor.Connect should have comment or be unexported (golint)
  • Line 161: warning: exported method Monitor.Stop should have comment or be unexported (golint)

• cmd/snap/cmd_find.go
  • Line 82: warning: exported type SectionName should have comment or be unexported (golint)
  • Line 84: warning: exported method SectionName.Complete should have comment or be unexported (golint)

• snap/snapdir/snapdir.go
  • Line 34: warning: exported function IsSnapDir should have comment or be unexported (golint)
  • Line 58: warning: exported method SnapDir.Size should have comment or be unexported (golint)
  • Line 69: warning: exported method SnapDir.Install should have comment or be unexported (golint)
  • Line 75: warning: exported method SnapDir.RandomAccessFile should have comment or be unexported (golint)
  • Line 87: warning: exported method SnapDir.ReadFile should have comment or be unexported (golint)
  • Line 189: warning: exported method SnapDir.ListDir should have comment or be unexported (golint)
  • Line 203: warning: exported method SnapDir.Unpack should have comment or be unexported (golint)

• secboot/encrypt.go
  • Line 52: warning: exported function NewEncryptionKey should have comment or be unexported (golint)
  • Line 72: warning: exported function NewRecoveryKey should have comment or be unexported (golint)
  • Line 88: warning: exported function RecoveryKeyFromFile should have comment or be unexported (golint)
  • Line 112: warning: exported function NewAuxKey should have comment or be unexported (golint)
  • Line 124: warning: exported const EncryptionTypeNone should have comment (or a comment on this block) or be unexported (golint)

• asserts/pool.go
  • Line 33: warning: comment on exported type Pool should be of the form "Pool ..." (with optional leading article) (golint)
  • Line 749: warning: exported var ErrUnresolved should have comment or be unexported (golint)

• interfaces/udev/backend.go
  • Line 165: warning: exported method Backend.NewSpecification should have comment or be unexported (golint)

• cmd/snap-bootstrap/cmd_initramfs_mounts.go
  • Line 922: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• client/interfaces.go
  • Line 94: warning: exported method Client.Interfaces should have comment or be unexported (golint)

• asserts/account.go
  • Line 41: warning: exported function IsValidAccountID should have comment or be unexported (golint)

• gadget/install/partition.go
  • Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• interfaces/seccomp/backend.go
  • Line 71: warning: exported type Compiler should have comment or be unexported (golint)

• overlord/snapstate/storehelpers.go
  • Line 407: warning: exported var ErrMissingExpectedResult should have comment or be unexported (golint)

• cmd/snap/main.go
  • Line 59: warning: comment on exported var Stdin should be of the form "Stdin ..." (golint)
  • Line 61: warning: exported var Stdout should have comment or be unexported (golint)
  • Line 63: warning: comment on exported var ReadPassword should be of the form "ReadPassword ..." (golint)

• overlord/configstate/configcore/corecfg.go
  • Line 32: warning: exported var Stdout should have comment or be unexported (golint)

• overlord/snapstate/policy/policy.go
  • Line 35: warning: exported function For should have comment or be unexported (golint)

• client/buy.go
  • Line 39: warning: exported method Client.Buy should have comment or be unexported (golint)
  • Line 59: warning: exported method Client.ReadyToBuy should have comment or be unexported (golint)

• seed/seedtest/seedtest.go
  • Line 29: warning: should not use dot imports (golint)
  • Line 62: warning: exported method SeedSnaps.AssertedSnapID should have comment or be unexported (golint)
  • Line 77: warning: exported method SeedSnaps.SetSnapAssertionNow should have comment or be unexported (golint)
  • Line 81: warning: exported method SeedSnaps.MakeAssertedSnap should have comment or be unexported (golint)
  • Line 139: warning: exported method SeedSnaps.AssertedSnap should have comment or be unexported (golint)
  • Line 143: warning: exported method SeedSnaps.AssertedSnapInfo should have comment or be unexported (golint)
  • Line 147: warning: exported method SeedSnaps.AssertedSnapRevision should have comment or be unexported (golint)
  • Line 158: warning: exported method TestingSeed16.SnapsDir should have comment or be unexported (golint)
  • Line 162: warning: exported method TestingSeed16.AssertsDir should have comment or be unexported (golint)
  • Line 166: warning: exported method TestingSeed16.MakeAssertedSnap should have comment or be unexported (golint)
  • Line 179: warning: exported method TestingSeed16.MakeModelAssertionChain should have comment or be unexported (golint)
  • Line 192: warning: exported method TestingSeed16.WriteAssertions should have comment or be unexported (golint)
  • Line 197: warning: exported function WriteAssertions should have comment or be unexported (golint)
  • Line 212: warning: exported function ReadAssertions should have comment or be unexported (golint)
  • Line 349: warning: exported function ValidateSeed should have comment or be unexported (golint)

• asserts/extkeypairmgr.go
  • Line 37: warning: exported type ExternalKeyInfo should have comment or be unexported (golint)
  • Line 135: warning: exported method ExternalKeypairManager.Export should have comment or be unexported (golint)
  • Line 185: warning: exported method ExternalKeypairManager.GetByName should have comment or be unexported (golint)
  • Line 203: warning: exported method ExternalKeypairManager.Put should have comment or be unexported (golint)
  • Line 207: warning: exported method ExternalKeypairManager.Delete should have comment or be unexported (golint)
  • Line 211: warning: exported method ExternalKeypairManager.DeleteByName should have comment or be unexported (golint)
  • Line 215: warning: exported method ExternalKeypairManager.Generate should have comment or be unexported (golint)
  • Line 232: warning: exported method ExternalKeypairManager.Get should have comment or be unexported (golint)
  • Line 247: warning: exported method ExternalKeypairManager.List should have comment or be unexported (golint)

• osutil/user.go
  • Line 49: warning: exported type AddUserOptions should have comment or be unexported (golint)
  • Line 60: warning: comment on exported var IsValidUsername should be of the form "IsValidUsername ..." (golint)
  • Line 262: warning: exported type DelUserOptions should have comment or be unexported (golint)

• overlord/configstate/configcore/hostname.go
  • Line 46: warning: comment on exported const HOST_NAME_MAX should be of the form "HOST_NAME_MAX ..." (golint)

• sandbox/seccomp/seccomp.go
  • Line 37: warning: exported function SupportsAction should have comment or be unexported (golint)
  • Line 75: warning: exported function MockActions should have comment or be unexported (golint)

• strutil/limbuffer.go
  • Line 22: warning: exported type LimitedBuffer should have comment or be unexported (golint)
  • Line 28: warning: exported function NewLimitedBuffer should have comment or be unexported (golint)
  • Line 49: warning: exported method LimitedBuffer.Bytes should have comment or be unexported (golint)

• overlord/snapstate/check_snap.go
  • Line 128: warning: exported type SnapNeedsDevModeError should have comment or be unexported (golint)
  • Line 136: warning: exported type SnapNeedsClassicError should have comment or be unexported (golint)
  • Line 144: warning: exported type SnapNeedsClassicSystemError should have comment or be unexported (golint)
  • Line 152: warning: exported type SnapNotClassicError should have comment or be unexported (golint)
  • Line 286: warning: exported function MockCheckSnapCallbacks should have comment or be unexported (golint)

• interfaces/ifacetest/testiface.go
  • Line 138: warning: exported method TestInterface.StaticInfo should have comment or be unexported (golint)
  • Line 158: warning: exported method TestInterface.BeforeConnectPlug should have comment or be unexported (golint)
  • Line 165: warning: exported method TestInterface.BeforeConnectSlot should have comment or be unexported (golint)
  • Line 184: warning: exported method TestInterface.TestConnectedPlug should have comment or be unexported (golint)
  • Line 191: warning: exported method TestInterface.TestConnectedSlot should have comment or be unexported (golint)
  • Line 198: warning: exported method TestInterface.TestPermanentPlug should have comment or be unexported (golint)
  • Line 205: warning: exported method TestInterface.TestPermanentSlot should have comment or be unexported (golint)
  • Line 214: warning: exported method TestInterface.MountConnectedPlug should have comment or be unexported (golint)
  • Line 221: warning: exported method TestInterface.MountConnectedSlot should have comment or be unexported (golint)
  • Line 228: warning: exported method TestInterface.MountPermanentPlug should have comment or be unexported (golint)
  • Line 235: warning: exported method TestInterface.MountPermanentSlot should have comment or be unexported (golint)
  • Line 244: warning: exported method TestInterface.UDevConnectedPlug should have comment or be unexported (golint)
  • Line 251: warning: exported method TestInterface.UDevPermanentPlug should have comment or be unexported (golint)
  • Line 258: warning: exported method TestInterface.UDevPermanentSlot should have comment or be unexported (golint)
  • Line 265: warning: exported method TestInterface.UDevConnectedSlot should have comment or be unexported (golint)
  • Line 274: warning: exported method TestInterface.AppArmorConnectedPlug should have comment or be unexported (golint)
  • Line 281: warning: exported method TestInterface.AppArmorPermanentSlot should have comment or be unexported (golint)
  • Line 288: warning: exported method TestInterface.AppArmorConnectedSlot should have comment or be unexported (golint)
  • Line 296: warning: exported method TestInterface.AppArmorPermanentPlug should have comment or be unexported (golint)
  • Line 305: warning: exported method TestInterface.SecCompConnectedPlug should have comment or be unexported (golint)
  • Line 312: warning: exported method TestInterface.SecCompConnectedSlot should have comment or be unexported (golint)
  • Line 319: warning: exported method TestInterface.SecCompPermanentSlot should have comment or be unexported (golint)
  • Line 326: warning: exported method TestInterface.SecCompPermanentPlug should have comment or be unexported (golint)
  • Line 335: warning: exported method TestInterface.KModConnectedPlug should have comment or be unexported (golint)
  • Line 342: warning: exported method TestInterface.KModConnectedSlot should have comment or be unexported (golint)
  • Line 349: warning: exported method TestInterface.KModPermanentPlug should have comment or be unexported (golint)
  • Line 356: warning: exported method TestInterface.KModPermanentSlot should have comment or be unexported (golint)
  • Line 365: warning: exported method TestInterface.DBusConnectedPlug should have comment or be unexported (golint)
  • Line 372: warning: exported method TestInterface.DBusConnectedSlot should have comment or be unexported (golint)
  • Line 379: warning: exported method TestInterface.DBusPermanentSlot should have comment or be unexported (golint)
  • Line 386: warning: exported method TestInterface.DBusPermanentPlug should have comment or be unexported (golint)
  • Line 395: warning: exported method TestInterface.SystemdConnectedPlug should have comment or be unexported (golint)
  • Line 402: warning: exported method TestInterface.SystemdConnectedSlot should have comment or be unexported (golint)
  • Line 409: warning: exported method TestInterface.SystemdPermanentSlot should have comment or be unexported (golint)
  • Line 416: warning: exported method TestInterface.SystemdPermanentPlug should have comment or be unexported (golint)
  • Line 425: warning: exported method TestInterface.PolkitConnectedPlug should have comment or be unexported (golint)
  • Line 432: warning: exported method TestInterface.PolkitConnectedSlot should have comment or be unexported (golint)
  • Line 439: warning: exported method TestInterface.PolkitPermanentSlot should have comment or be unexported (golint)
  • Line 446: warning: exported method TestInterface.PolkitPermanentPlug should have comment or be unexported (golint)
  • Line 455: warning: exported method TestHotplugInterface.HotplugKey should have comment or be unexported (golint)
  • Line 462: warning: exported method TestHotplugInterface.HotplugDeviceDetected should have comment or be unexported (golint)
  • Line 469: warning: exported method TestHotplugInterface.HandledByGadget should have comment or be unexported (golint)

• secboot/secboot_tpm.go
  • Line 77: warning: exported function CheckTPMKeySealingSupported should have comment or be unexported (golint)

• gadget/install/params.go
  • Line 26: warning: exported type Options should have comment or be unexported (golint)

• secboot/secboot_sb.go
  • Line 111: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• asserts/batch.go
  • Line 123: warning: exported type CommitOptions should have comment or be unexported (golint)
  • Line 235: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• asserts/database.go
  • Line 618: warning: comment on exported method Database.FindManyPredefined should be of the form "FindManyPredefined ..." (golint)

• interfaces/kmod/backend.go
  • Line 215: warning: exported method Backend.NewSpecification should have comment or be unexported (golint)

• advisor/cmdfinder.go
  • Line 26: warning: exported type Command should have comment or be unexported (golint)
  • Line 32: warning: exported function FindCommand should have comment or be unexported (golint)
  • Line 85: warning: exported function FindMisspelledCommand should have comment or be unexported (golint)

• client/clientutil/snapinfo.go
  • Line 92: warning: exported function ClientAppInfoNotes should have comment or be unexported (golint)

• boot/assets.go
  • Line 31: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 342: warning: exported method TrustedAssetsInstallObserver.ChosenEncryptionKeys should have comment or be unexported (golint)

• snap/pack/pack.go
  • Line 197: warning: exported type Options should have comment or be unexported (golint)
  • Line 208: warning: exported var Defaults should have comment or be unexported (golint)

• snapdenv/snapdenv.go
  • Line 51: warning: exported function MockTesting should have comment or be unexported (golint)
  • Line 69: warning: exported function MockUseStagingStore should have comment or be unexported (golint)
  • Line 88: warning: exported function MockPreseeding should have comment or be unexported (golint)

• overlord/snapstate/backend/backend.go
  • Line 56: warning: exported function NewForPreseedMode should have comment or be unexported (golint)

• overlord/snapstate/backend/setup.go
  • Line 42: warning: exported type SetupSnapOptions should have comment or be unexported (golint)
  • Line 148: warning: exported method Backend.RemoveSnapDir should have comment or be unexported (golint)

• interfaces/hotplug/deviceinfo.go
  • Line 49: warning: comment on exported method HotplugDeviceInfo.Subsystem should be of the form "Subsystem ..." (golint)
  • Line 55: warning: comment on exported method HotplugDeviceInfo.DevicePath should be of the form "DevicePath ..." (golint)
  • Line 63: warning: comment on exported method HotplugDeviceInfo.Minor should be of the form "Minor ..." (golint)
  • Line 69: warning: comment on exported method HotplugDeviceInfo.Major should be of the form "Major ..." (golint)
  • Line 75: warning: comment on exported method HotplugDeviceInfo.DeviceName should be of the form "DeviceName ..." (golint)
  • Line 81: warning: comment on exported method HotplugDeviceInfo.DeviceType should be of the form "DeviceType ..." (golint)
  • Line 87: warning: comment on exported method HotplugDeviceInfo.Attribute should be of the form "Attribute ..." (golint)

• overlord/configstate/configstate.go
  • Line 45: warning: exported function ConfigureHookTimeout should have comment or be unexported (golint)

• overlord/devicestate/remodel.go
  • Line 64: warning: comment on exported const UpdateRemodel should be of the form "UpdateRemodel ..." (golint)
  • Line 66: warning: comment on exported const StoreSwitchRemodel should be of the form "StoreSwitchRemodel ..." (golint)
  • Line 68: warning: comment on exported const ReregRemodel should be of the form "ReregRemodel ..." (golint)

• bootloader/efi/efi.go
  • Line 38: warning: exported var ErrNoEFISystem should have comment or be unexported (golint)
  • Line 40: warning: exported type VariableAttr should have comment or be unexported (golint)

• advisor/finder.go
  • Line 24: warning: exported type Finder should have comment or be unexported (golint)
  • Line 30: warning: exported function ReplaceCommandsFinder should have comment or be unexported (golint)

• progress/ansimeter.go
  • Line 70: warning: exported method ANSIMeter.Start should have comment or be unexported (golint)
  • Line 94: warning: exported method ANSIMeter.SetTotal should have comment or be unexported (golint)
  • Line 111: warning: exported method ANSIMeter.Set should have comment or be unexported (golint)
  • Line 165: warning: exported method ANSIMeter.Spin should have comment or be unexported (golint)
  • Line 179: warning: exported method ANSIMeter.Finished should have comment or be unexported (golint)
  • Line 183: warning: exported method ANSIMeter.Notify should have comment or be unexported (golint)

• asserts/asserts.go
  • Line 70: warning: comment on exported method AssertionType.SequenceForming should be of the form "SequenceForming ..." (golint)
  • Line 165: warning: exported function MockMaxSupportedFormat should have comment or be unexported (golint)
  • Line 307: warning: exported const RevisionNotKnown should have comment or be unexported (golint)

• strutil/shlex/shlex.go
  • Line 138: warning: receiver name t should be consistent with previous receiver name typeMap for tokenClassifier (golint)
  • Line 380: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• cmd/snap/cmd_advise.go
  • Line 222: warning: exported type Snap should have comment or be unexported (golint)
  • Line 234: warning: don't use underscores in Go names; var commands_processed should be commandsProcessed (golint)

• asserts/systestkeys/trusted.go
  • Line 30: warning: exported const TestRootPrivKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 315: warning: exported var TestRootAccount should have comment or be unexported (golint)
  • Line 317: warning: comment on exported var TestStoreAccountKey should be of the form "TestStoreAccountKey ..." (golint)
  • Line 320: warning: comment on exported var Trusted should be of the form "Trusted ..." (golint)

• asserts/assertstest/assertstest.go
  • Line 241: warning: exported method SigningDB.Sign should have comment or be unexported (golint)
  • Line 257: warning: exported method SigningDB.PublicKey should have comment or be unexported (golint)
  • Line 523: warning: exported method SigningAccounts.Register should have comment or be unexported (golint)
  • Line 547: warning: exported method SigningAccounts.Account should have comment or be unexported (golint)
  • Line 554: warning: exported method SigningAccounts.AccountKey should have comment or be unexported (golint)
  • Line 561: warning: exported method SigningAccounts.PublicKey should have comment or be unexported (golint)
  • Line 569: warning: exported method SigningAccounts.Signing should have comment or be unexported (golint)

• overlord/restart/restart.go
  • Line 27: warning: exported type RestartType should have comment or be unexported (golint)
  • Line 30: warning: exported const RestartUnset should have comment (or a comment on this block) or be unexported (golint)
  • Line 38: warning: comment on exported const StopDaemon should be of the form "StopDaemon ..." (golint)
  • Line 143: warning: exported function MockPending should have comment or be unexported (golint)
  • Line 154: warning: exported function ReplaceBootID should have comment or be unexported (golint)

• cmd/snap-recovery-chooser/main.go
  • Line 60: warning: exported var Stdout should have comment or be unexported (golint)
  • Line 141: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• cmd/snap-bootstrap/triggerwatch/triggerwatch.go
  • Line 47: warning: exported var ErrTriggerNotDetected should have comment or be unexported (golint)

• image/image_linux.go
  • Line 51: warning: exported var Stdout should have comment or be unexported (golint)
  • Line 97: warning: exported function Prepare should have comment or be unexported (golint)
  • Line 223: warning: exported function MockTrusted should have comment or be unexported (golint)

• cmd/snap/notes.go
  • Line 68: warning: exported function NotesFromChannelSnapInfo should have comment or be unexported (golint)
  • Line 75: warning: exported function NotesFromRemote should have comment or be unexported (golint)
  • Line 89: warning: exported function NotesFromLocal should have comment or be unexported (golint)

• advisor/pkgfinder.go
  • Line 26: warning: exported type Package should have comment or be unexported (golint)
  • Line 32: warning: exported function FindPackage should have comment or be unexported (golint)

• seed/helpers.go
  • Line 36: warning: exported function MockTrusted should have comment or be unexported (golint)

• timings/timings.go
  • Line 71: warning: exported type Measurer should have comment or be unexported (golint)

• osutil/flock.go
  • Line 33: warning: exported var ErrAlreadyLocked should have comment or be unexported (golint)
  • Line 86: warning: comment on exported method FileLock.ReadLock should be of the form "ReadLock ..." (golint)

• snap/quota/quota.go
  • Line 97: warning: exported method Group.GetQuotaResources should have comment or be unexported (golint)

• asserts/constraint.go
  • Line 421: warning: exported type DeviceScopeConstraintCheckOptions should have comment or be unexported (golint)

• sysconfig/sysconfig.go
  • Line 82: warning: receiver name d should be consistent with previous receiver name di for configedDevice (golint)
  • Line 86: warning: receiver name d should be consistent with previous receiver name di for configedDevice (golint)
  • Line 90: warning: receiver name d should be consistent with previous receiver name di for configedDevice (golint)

• snap/revision.go
  • Line 29: warning: exported type Revision should have comment or be unexported (golint)
  • Line 43: warning: exported method Revision.Unset should have comment or be unexported (golint)
  • Line 47: warning: exported method Revision.Local should have comment or be unexported (golint)
  • Line 51: warning: exported method Revision.Store should have comment or be unexported (golint)
  • Line 55: warning: exported method Revision.MarshalJSON should have comment or be unexported (golint)
  • Line 59: warning: exported method Revision.UnmarshalYAML should have comment or be unexported (golint)
  • Line 67: warning: exported method Revision.MarshalYAML should have comment or be unexported (golint)
  • Line 71: warning: exported method Revision.UnmarshalJSON should have comment or be unexported (golint)
  • Line 88: warning: comment on exported function ParseRevision should be of the form "ParseRevision ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!