gofmt0%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

An error occurred while running this test (exit status 2)

go_vet0%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

An error occurred while running this test (exit status 2)

gocyclo0%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

An error occurred while running this test (exit status 2)

golint56%

Golint is a linter for Go source code.

• api/pkg/utils/urls/urls.go
  • Line 24: warning: exported const Etcd should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: don't use underscores in Go names; const etcd_prefix should be etcdPrefix (golint)
  • Line 30: warning: exported function GenerateHostURL should have comment or be unexported (golint)
  • Line 34: warning: exported function GenerateFileShareAclURL should have comment or be unexported (golint)
  • Line 38: warning: exported function GenerateFileShareURL should have comment or be unexported (golint)
  • Line 42: warning: exported function GenerateFileShareSnapshotURL should have comment or be unexported (golint)
  • Line 46: warning: exported function GenerateDockURL should have comment or be unexported (golint)
  • Line 50: warning: exported function GeneratePoolURL should have comment or be unexported (golint)
  • Line 54: warning: exported function GenerateProfileURL should have comment or be unexported (golint)
  • Line 58: warning: exported function GenerateVolumeURL should have comment or be unexported (golint)
  • Line 67: warning: exported function GenerateAttachmentURL should have comment or be unexported (golint)
  • Line 71: warning: exported function GenerateSnapshotURL should have comment or be unexported (golint)
  • Line 75: warning: exported function GenerateReplicationURL should have comment or be unexported (golint)
  • Line 79: warning: exported function GenerateVolumeGroupURL should have comment or be unexported (golint)
  • Line 108: warning: exported function CurrentVersion should have comment or be unexported (golint)

• api/pkg/utils/config/config.go
  • Line 33: warning: exported const ConfKeyName should have comment (or a comment on this block) or be unexported (golint)
  • Line 255: warning: comment on exported var CONF should be of the form "CONF ..." (golint)
  • Line 258: warning: comment on exported function GetDefaultConfig should be of the form "GetDefaultConfig ..." (golint)
  • Line 265: warning: exported function GetConfigPath should have comment or be unexported (golint)
  • Line 277: warning: exported method Config.Load should have comment or be unexported (golint)
  • Line 284: warning: exported function GetBackendsMap should have comment or be unexported (golint)

• api/pkg/api/controllers/dock.go
  • Line 32: warning: comment on exported type DockPortal should be of the form "DockPortal ..." (with optional leading article) (golint)
  • Line 37: warning: comment on exported method DockPortal.ListDocks should be of the form "ListDocks ..." (golint)
  • Line 68: warning: comment on exported method DockPortal.GetDock should be of the form "GetDock ..." (golint)

• api/pkg/utils/constants/constants.go
  • Line 18: warning: comment on exported const TimeFormat should be of the form "TimeFormat ..." (golint)
  • Line 22: warning: exported const DefaultOpensdsEndpoint should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: comment on exported const DefaultTenantId should be of the form "DefaultTenantId ..." (golint)
  • Line 27: warning: comment on exported const AuthTokenHeader should be of the form "AuthTokenHeader ..." (golint)
  • Line 34: warning: comment on exported const APIVersion should be of the form "APIVersion ..." (golint)
  • Line 54: warning: comment on exported const Block should be of the form "Block ..." (golint)
  • Line 58: warning: comment on exported const Read should be of the form "Read ..." (golint)
  • Line 63: warning: comment on exported const DefaultSortDir should be of the form "DefaultSortDir ..." (golint)

• api/pkg/model/dock.go
  • Line 23: warning: exported const DockTypeProvioner should have comment (or a comment on this block) or be unexported (golint)

• api/client/pool.go
  • Line 24: warning: comment on exported function NewPoolMgr should be of the form "NewPoolMgr ..." (golint)
  • Line 33: warning: comment on exported type PoolMgr should be of the form "PoolMgr ..." (with optional leading article) (golint)
  • Line 40: warning: comment on exported method PoolMgr.GetPool should be of the form "GetPool ..." (golint)
  • Line 54: warning: comment on exported method PoolMgr.ListPools should be of the form "ListPools ..." (golint)

• api/pkg/api/filter/context/context.go
  • Line 23: warning: exported function Factory should have comment or be unexported (golint)

• api/client/client.go
  • Line 29: warning: exported const OpensdsEndpoint should have comment (or a comment on this block) or be unexported (golint)

• api/pkg/api/controllers/version.go
  • Line 29: warning: comment on exported var KnownVersions should be of the form "KnownVersions ..." (golint)
  • Line 39: warning: comment on exported type VersionPortal should be of the form "VersionPortal ..." (with optional leading article) (golint)
  • Line 44: warning: comment on exported method VersionPortal.ListVersions should be of the form "ListVersions ..." (golint)
  • Line 57: warning: comment on exported method VersionPortal.GetVersion should be of the form "GetVersion ..." (golint)

• api/pkg/api/filter/auth/auth.go
  • Line 26: warning: exported type AuthBase should have comment or be unexported (golint)
  • Line 30: warning: exported function NewNoAuth should have comment or be unexported (golint)
  • Line 34: warning: exported type NoAuth should have comment or be unexported (golint)
  • Line 36: warning: exported method NoAuth.Filter should have comment or be unexported (golint)
  • Line 46: warning: exported function Factory should have comment or be unexported (golint)

• api/testutils/collection/data.go
  • Line 27: warning: exported var SampleProfiles should have comment or be unexported (golint)

• api/pkg/api/controllers/profile.go
  • Line 35: warning: exported type ProfilePortal should have comment or be unexported (golint)
  • Line 39: warning: exported method ProfilePortal.CreateProfile should have comment or be unexported (golint)
  • Line 98: warning: exported method ProfilePortal.ListProfiles should have comment or be unexported (golint)
  • Line 129: warning: exported method ProfilePortal.GetProfile should have comment or be unexported (golint)
  • Line 154: warning: exported method ProfilePortal.UpdateProfile should have comment or be unexported (golint)
  • Line 189: warning: exported method ProfilePortal.DeleteProfile should have comment or be unexported (golint)
  • Line 245: warning: exported method ProfilePortal.AddCustomProperty should have comment or be unexported (golint)
  • Line 278: warning: exported method ProfilePortal.ListCustomProperties should have comment or be unexported (golint)
  • Line 304: warning: exported method ProfilePortal.RemoveCustomProperty should have comment or be unexported (golint)

• api/pkg/db/db.go
  • Line 29: warning: should not use dot imports (golint)
  • Line 238: warning: exported function UpdateFileShareStatus should have comment or be unexported (golint)
  • Line 243: warning: exported function UpdateFileShareSnapshotStatus should have comment or be unexported (golint)
  • Line 248: warning: exported function UpdateFileShareAclStatus should have comment or be unexported (golint)
  • Line 253: warning: exported function UpdateVolumeStatus should have comment or be unexported (golint)
  • Line 258: warning: exported function UpdateVolumeAttachmentStatus should have comment or be unexported (golint)
  • Line 263: warning: exported function UpdateVolumeSnapshotStatus should have comment or be unexported (golint)
  • Line 268: warning: exported function UpdateReplicationStatus should have comment or be unexported (golint)
  • Line 273: warning: exported function UpdateVolumeGroupStatus should have comment or be unexported (golint)

• api/pkg/context/context.go
  • Line 30: warning: exported function NewAdminContext should have comment or be unexported (golint)
  • Line 36: warning: exported function NewInternalTenantContext should have comment or be unexported (golint)
  • Line 44: warning: exported function NewContextFromJson should have comment or be unexported (golint)
  • Line 53: warning: exported function GetContext should have comment or be unexported (golint)
  • Line 61: warning: exported function UpdateContext should have comment or be unexported (golint)
  • Line 83: warning: exported type Context should have comment or be unexported (golint)
  • Line 117: warning: exported method Context.ToPolicyValue should have comment or be unexported (golint)
  • Line 142: warning: exported method Context.ToJson should have comment or be unexported (golint)
  • Line 150: warning: exported function HttpError should have comment or be unexported (golint)

• api/pkg/api/filter/auth/keystone.go
  • Line 36: warning: exported function NewKeystone should have comment or be unexported (golint)
  • Line 45: warning: exported type Keystone should have comment or be unexported (golint)
  • Line 49: warning: exported method Keystone.SetUp should have comment or be unexported (golint)
  • Line 155: warning: exported method Keystone.Filter should have comment or be unexported (golint)

• api/pkg/model/volume.go
  • Line 86: warning: comment on exported type Identifier should be of the form "Identifier ..." (with optional leading article) (golint)
  • Line 136: warning: exported type VolumeGroupSpec should have comment or be unexported (golint)

• api/pkg/api/controllers/attachment.go
  • Line 39: warning: exported function NewVolumeAttachmentPortal should have comment or be unexported (golint)
  • Line 45: warning: exported type VolumeAttachmentPortal should have comment or be unexported (golint)
  • Line 51: warning: exported method VolumeAttachmentPortal.CreateVolumeAttachment should have comment or be unexported (golint)
  • Line 194: warning: exported method VolumeAttachmentPortal.ListVolumeAttachments should have comment or be unexported (golint)
  • Line 220: warning: exported method VolumeAttachmentPortal.GetVolumeAttachment should have comment or be unexported (golint)
  • Line 240: warning: exported method VolumeAttachmentPortal.UpdateVolumeAttachment should have comment or be unexported (golint)
  • Line 270: warning: exported method VolumeAttachmentPortal.DeleteVolumeAttachment should have comment or be unexported (golint)

• api/pkg/api/controllers/base.go
  • Line 28: warning: exported const StatusOK should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported type BasePortal should have comment or be unexported (golint)
  • Line 36: warning: exported method BasePortal.GetParameters should have comment or be unexported (golint)
  • Line 58: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 75: warning: exported method BasePortal.ErrorHandle should have comment or be unexported (golint)
  • Line 99: warning: exported method BasePortal.SuccessHandle should have comment or be unexported (golint)

• api/pkg/utils/pwd/aes.go
  • Line 26: warning: exported type AES should have comment or be unexported (golint)
  • Line 28: warning: exported function NewAES should have comment or be unexported (golint)
  • Line 36: warning: exported method AES.Encrypter should have comment or be unexported (golint)
  • Line 62: warning: exported method AES.Decrypter should have comment or be unexported (golint)

• api/pkg/db/drivers/mysql/mysql.go
  • Line 30: warning: comment on exported function Init should be of the form "Init ..." (golint)

• api/pkg/api/util/db.go
  • Line 38: warning: comment on exported function CreateFileShareAclDBEntry should be of the form "CreateFileShareAclDBEntry ..." (golint)
  • Line 115: warning: exported function DeleteFileShareAclDBEntry should have comment or be unexported (golint)
  • Line 146: warning: comment on exported function CreateFileShareDBEntry should be of the form "CreateFileShareDBEntry ..." (golint)
  • Line 242: warning: comment on exported function CreateFileShareSnapshotDBEntry should be of the form "CreateFileShareSnapshotDBEntry ..." (golint)
  • Line 267: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 311: warning: exported function DeleteFileShareSnapshotDBEntry should have comment or be unexported (golint)
  • Line 339: warning: exported function CreateVolumeDBEntry should have comment or be unexported (golint)
  • Line 803: warning: exported function ValidateAddVolumes should have comment or be unexported (golint)
  • Line 849: warning: exported function ValidateRemoveVolumes should have comment or be unexported (golint)

• api/client/replication.go
  • Line 24: warning: exported type ReplicationBuilder should have comment or be unexported (golint)
  • Line 25: warning: exported type FailoverReplicationBuilder should have comment or be unexported (golint)
  • Line 27: warning: comment on exported function NewReplicationMgr should be of the form "NewReplicationMgr ..." (golint)
  • Line 36: warning: comment on exported type ReplicationMgr should be of the form "ReplicationMgr ..." (with optional leading article) (golint)
  • Line 43: warning: comment on exported method ReplicationMgr.CreateReplication should be of the form "CreateReplication ..." (golint)
  • Line 57: warning: comment on exported method ReplicationMgr.GetReplication should be of the form "GetReplication ..." (golint)
  • Line 71: warning: comment on exported method ReplicationMgr.ListReplications should be of the form "ListReplications ..." (golint)
  • Line 95: warning: comment on exported method ReplicationMgr.DeleteReplication should be of the form "DeleteReplication ..." (golint)
  • Line 103: warning: comment on exported method ReplicationMgr.UpdateReplication should be of the form "UpdateReplication ..." (golint)
  • Line 116: warning: comment on exported method ReplicationMgr.EnableReplication should be of the form "EnableReplication ..." (golint)
  • Line 124: warning: comment on exported method ReplicationMgr.DisableReplication should be of the form "DisableReplication ..." (golint)
  • Line 132: warning: comment on exported method ReplicationMgr.FailoverReplication should be of the form "FailoverReplication ..." (golint)

• api/pkg/api/controllers/volumeGroup.go
  • Line 30: warning: should not use dot imports (golint)
  • Line 33: warning: exported function NewVolumeGroupPortal should have comment or be unexported (golint)
  • Line 39: warning: exported type VolumeGroupPortal should have comment or be unexported (golint)
  • Line 45: warning: exported method VolumeGroupPortal.CreateVolumeGroup should have comment or be unexported (golint)
  • Line 112: warning: exported method VolumeGroupPortal.UpdateVolumeGroup should have comment or be unexported (golint)
  • Line 191: warning: exported method VolumeGroupPortal.DeleteVolumeGroup should have comment or be unexported (golint)
  • Line 240: warning: exported method VolumeGroupPortal.GetVolumeGroup should have comment or be unexported (golint)
  • Line 266: warning: exported method VolumeGroupPortal.ListVolumeGroups should have comment or be unexported (golint)

• api/pkg/api/filter/accesslog/accesslog.go
  • Line 23: warning: exported function Factory should have comment or be unexported (golint)

• api/pkg/model/alert.go
  • Line 24: warning: exported type LabelSet should have comment or be unexported (golint)
  • Line 28: warning: exported type AlertSpec should have comment or be unexported (golint)

• api/pkg/utils/utils.go
  • Line 33: warning: exported function Contains should have comment or be unexported (golint)
  • Line 42: warning: comment on exported function RvRepElement should be of the form "RvRepElement ..." (golint)
  • Line 60: warning: exported function Contained should have comment or be unexported (golint)
  • Line 79: warning: exported function MergeGeneralMaps should have comment or be unexported (golint)
  • Line 89: warning: exported function MergeStringMaps should have comment or be unexported (golint)
  • Line 99: warning: exported function PathExists should have comment or be unexported (golint)
  • Line 110: warning: exported function Retry should have comment or be unexported (golint)
  • Line 143: warning: exported function CompareArray should have comment or be unexported (golint)
  • Line 260: warning: comment on exported function Sort should be of the form "Sort ..." (golint)
  • Line 285: warning: comment on exported function Slice should be of the form "Slice ..." (golint)
  • Line 297: warning: exported function RandSeqWithAlnum should have comment or be unexported (golint)
  • Line 302: warning: exported function RandSeq should have comment or be unexported (golint)
  • Line 310: warning: exported function WaitForCondition should have comment or be unexported (golint)
  • Line 331: warning: exported function ContainsIgnoreCase should have comment or be unexported (golint)

• api/pkg/api/controllers/fileshare.go
  • Line 31: warning: should not use dot imports (golint)
  • Line 35: warning: exported function NewFileSharePortal should have comment or be unexported (golint)
  • Line 41: warning: exported type FileSharePortal should have comment or be unexported (golint)
  • Line 47: warning: comment on exported method FileSharePortal.CreateFileShareAcl should be of the form "CreateFileShareAcl ..." (golint)
  • Line 133: warning: exported method FileSharePortal.ListFileSharesAcl should have comment or be unexported (golint)
  • Line 156: warning: comment on exported method FileSharePortal.CreateFileShare should be of the form "CreateFileShare ..." (golint)
  • Line 280: warning: exported method FileSharePortal.ListFileShares should have comment or be unexported (golint)
  • Line 303: warning: exported method FileSharePortal.GetFileShareAcl should have comment or be unexported (golint)
  • Line 330: warning: exported method FileSharePortal.GetFileShare should have comment or be unexported (golint)
  • Line 357: warning: exported method FileSharePortal.UpdateFileShare should have comment or be unexported (golint)
  • Line 387: warning: exported method FileSharePortal.DeleteFileShareAcl should have comment or be unexported (golint)
  • Line 456: warning: exported method FileSharePortal.DeleteFileShare should have comment or be unexported (golint)
  • Line 530: warning: exported function NewFileShareSnapshotPortal should have comment or be unexported (golint)
  • Line 536: warning: exported type FileShareSnapshotPortal should have comment or be unexported (golint)
  • Line 542: warning: exported method FileShareSnapshotPortal.CreateFileShareSnapshot should have comment or be unexported (golint)
  • Line 627: warning: exported method FileShareSnapshotPortal.ListFileShareSnapshots should have comment or be unexported (golint)
  • Line 651: warning: exported method FileShareSnapshotPortal.GetFileShareSnapshot should have comment or be unexported (golint)
  • Line 671: warning: exported method FileShareSnapshotPortal.UpdateFileShareSnapshot should have comment or be unexported (golint)
  • Line 701: warning: exported method FileShareSnapshotPortal.DeleteFileShareSnapshot should have comment or be unexported (golint)

• api/pkg/api/controllers/replication.go
  • Line 30: warning: should not use dot imports (golint)
  • Line 33: warning: exported function NewReplicationPortal should have comment or be unexported (golint)
  • Line 39: warning: exported type ReplicationPortal should have comment or be unexported (golint)
  • Line 50: warning: exported method ReplicationPortal.CreateReplication should have comment or be unexported (golint)
  • Line 114: warning: exported method ReplicationPortal.ListReplications should have comment or be unexported (golint)
  • Line 147: warning: exported method ReplicationPortal.ListReplicationsDetail should have comment or be unexported (golint)
  • Line 179: warning: exported method ReplicationPortal.GetReplication should have comment or be unexported (golint)
  • Line 205: warning: exported method ReplicationPortal.UpdateReplication should have comment or be unexported (golint)
  • Line 248: warning: exported method ReplicationPortal.DeleteReplication should have comment or be unexported (golint)
  • Line 299: warning: exported method ReplicationPortal.EnableReplication should have comment or be unexported (golint)
  • Line 351: warning: exported method ReplicationPortal.DisableReplication should have comment or be unexported (golint)
  • Line 403: warning: exported method ReplicationPortal.FailoverReplication should have comment or be unexported (golint)

• api/osdsctl/cli/table.go
  • Line 35: warning: exported type FormatterList should have comment or be unexported (golint)
  • Line 36: warning: exported type KeyList should have comment or be unexported (golint)
  • Line 37: warning: exported type StructElemCb should have comment or be unexported (golint)
  • Line 41: warning: exported function JsonFormatter should have comment or be unexported (golint)
  • Line 50: warning: comment on exported function PrintList should be of the form "PrintList ..." (golint)
  • Line 55: warning: exported function PrintDict should have comment or be unexported (golint)
  • Line 59: warning: comment on exported function TableList should be of the form "TableList ..." (golint)
  • Line 66: warning: comment on exported function TableDict should be of the form "TableDict ..." (golint)

• api/pkg/api/controllers/volume.go
  • Line 35: warning: should not use dot imports (golint)
  • Line 38: warning: exported function NewVolumePortal should have comment or be unexported (golint)
  • Line 44: warning: exported type VolumePortal should have comment or be unexported (golint)
  • Line 50: warning: exported method VolumePortal.CreateVolume should have comment or be unexported (golint)
  • Line 142: warning: exported method VolumePortal.ListVolumes should have comment or be unexported (golint)
  • Line 168: warning: exported method VolumePortal.GetVolume should have comment or be unexported (golint)
  • Line 189: warning: exported method VolumePortal.UpdateVolume should have comment or be unexported (golint)
  • Line 290: warning: exported method VolumePortal.DeleteVolume should have comment or be unexported (golint)
  • Line 366: warning: exported function NewVolumeSnapshotPortal should have comment or be unexported (golint)
  • Line 372: warning: exported type VolumeSnapshotPortal should have comment or be unexported (golint)
  • Line 378: warning: exported method VolumeSnapshotPortal.CreateVolumeSnapshot should have comment or be unexported (golint)
  • Line 456: warning: exported method VolumeSnapshotPortal.ListVolumeSnapshots should have comment or be unexported (golint)
  • Line 481: warning: exported method VolumeSnapshotPortal.GetVolumeSnapshot should have comment or be unexported (golint)
  • Line 501: warning: exported method VolumeSnapshotPortal.UpdateVolumeSnapshot should have comment or be unexported (golint)
  • Line 532: warning: exported method VolumeSnapshotPortal.DeleteVolumeSnapshot should have comment or be unexported (golint)

• api/cmd/osdsapiserver/osdsapiserver.go
  • Line 27: warning: should not use dot imports (golint)

• api/pkg/utils/pwd/pwd.go
  • Line 17: warning: exported type PwdEncrypter should have comment or be unexported (golint)
  • Line 22: warning: exported function NewPwdEncrypter should have comment or be unexported (golint)

• api/test/e2e/syncclient.go
  • Line 31: warning: exported type SyncClient should have comment or be unexported (golint)
  • Line 35: warning: exported function NewSyncClient should have comment or be unexported (golint)
  • Line 207: warning: exported method SyncClient.CreateVolume should have comment or be unexported (golint)
  • Line 218: warning: exported method SyncClient.ExtendVolume should have comment or be unexported (golint)
  • Line 229: warning: exported method SyncClient.DeleteVolume should have comment or be unexported (golint)
  • Line 236: warning: exported method SyncClient.CreateVolumeSnapshot should have comment or be unexported (golint)
  • Line 247: warning: exported method SyncClient.DeleteVolumeSnapshot should have comment or be unexported (golint)
  • Line 254: warning: exported method SyncClient.CreateVolumeAttachment should have comment or be unexported (golint)
  • Line 265: warning: exported method SyncClient.DeleteVolumeAttachment should have comment or be unexported (golint)
  • Line 272: warning: exported method SyncClient.CreateVolumeGroup should have comment or be unexported (golint)
  • Line 283: warning: exported method SyncClient.DeleteVolumeGroup should have comment or be unexported (golint)
  • Line 290: warning: exported method SyncClient.CreateFileShare should have comment or be unexported (golint)
  • Line 301: warning: exported method SyncClient.DeleteFileShare should have comment or be unexported (golint)

• api/pkg/utils/daemon/daemon.go
  • Line 38: warning: exported function CheckAndRunDaemon should have comment or be unexported (golint)

• api/pkg/model/fileshare.go
  • Line 15: warning: package comment should be of the form "Package model ..." (golint)
  • Line 20: warning: exported type FileShareAclSpec should have comment or be unexported (golint)
  • Line 57: warning: exported type FileShareSpec should have comment or be unexported (golint)

• api/pkg/model/metric.go
  • Line 22: warning: exported type CollectMetricSpec should have comment or be unexported (golint)
  • Line 29: warning: exported type GetMetricSpec should have comment or be unexported (golint)
  • Line 43: warning: exported type MetricSpec should have comment or be unexported (golint)
  • Line 81: warning: exported type Metric should have comment or be unexported (golint)
  • Line 86: warning: exported type NoParam should have comment or be unexported (golint)
  • Line 88: warning: exported type UrlSpec should have comment or be unexported (golint)
  • Line 94: warning: exported type UrlDesc should have comment or be unexported (golint)

• api/pkg/model/replication.go
  • Line 24: warning: exported const ReplicationModeSync should have comment (or a comment on this block) or be unexported (golint)
  • Line 86: warning: exported type FailoverReplicationSpec should have comment or be unexported (golint)

• api/pkg/api/controllers/host.go
  • Line 32: warning: exported type HostPortal should have comment or be unexported (golint)
  • Line 36: warning: exported function NewHostPortal should have comment or be unexported (golint)
  • Line 40: warning: exported method HostPortal.ListHosts should have comment or be unexported (golint)
  • Line 70: warning: exported method HostPortal.CreateHost should have comment or be unexported (golint)
  • Line 118: warning: exported method HostPortal.GetHost should have comment or be unexported (golint)
  • Line 142: warning: exported method HostPortal.UpdateHost should have comment or be unexported (golint)
  • Line 180: warning: exported method HostPortal.DeleteHost should have comment or be unexported (golint)

• api/pkg/utils/exec/exec.go
  • Line 25: warning: exported type Executer should have comment or be unexported (golint)
  • Line 29: warning: exported function Run should have comment or be unexported (golint)
  • Line 48: warning: exported function NewBaseExecuter should have comment or be unexported (golint)
  • Line 52: warning: exported type BaseExecuter should have comment or be unexported (golint)
  • Line 54: warning: exported method BaseExecuter.Run should have comment or be unexported (golint)
  • Line 58: warning: exported function NewRootExecuter should have comment or be unexported (golint)
  • Line 62: warning: exported type RootExeucter should have comment or be unexported (golint)
  • Line 64: warning: exported method RootExeucter.Run should have comment or be unexported (golint)

• api/pkg/model/profile.go
  • Line 30: warning: comment on exported type ProfileSpec should be of the form "ProfileSpec ..." (with optional leading article) (golint)
  • Line 74: warning: exported function NewProfileFromJson should have comment or be unexported (golint)
  • Line 83: warning: exported method ProfileSpec.ToJson should have comment or be unexported (golint)
  • Line 91: warning: exported type ProvisioningPropertiesSpec should have comment or be unexported (golint)
  • Line 98: warning: exported method ProvisioningPropertiesSpec.IsEmpty should have comment or be unexported (golint)
  • Line 103: warning: exported type ReplicationPropertiesSpec should have comment or be unexported (golint)
  • Line 132: warning: exported method ReplicationPropertiesSpec.IsEmpty should have comment or be unexported (golint)
  • Line 139: warning: exported type SnapshotPropertiesSpec should have comment or be unexported (golint)
  • Line 165: warning: exported method SnapshotPropertiesSpec.IsEmpty should have comment or be unexported (golint)
  • Line 172: warning: exported type DataProtectionPropertiesSpec should have comment or be unexported (golint)
  • Line 180: warning: exported method DataProtectionPropertiesSpec.IsEmpty should have comment or be unexported (golint)
  • Line 191: warning: exported method CustomPropertiesSpec.IsEmpty should have comment or be unexported (golint)
  • Line 198: warning: exported method CustomPropertiesSpec.Encode should have comment or be unexported (golint)
  • Line 203: warning: exported method CustomPropertiesSpec.GetCapabilitiesProperties should have comment or be unexported (golint)

• api/client/auth.go
  • Line 26: warning: comment on exported const OpensdsAuthStrategy should be of the form "OpensdsAuthStrategy ..." (golint)
  • Line 28: warning: exported const OpensdsTenantId should have comment (or a comment on this block) or be unexported (golint)
  • Line 30: warning: comment on exported const OsAuthUrl should be of the form "OsAuthUrl ..." (golint)
  • Line 43: warning: exported type AuthOptions should have comment or be unexported (golint)
  • Line 47: warning: exported function NewKeystoneAuthOptions should have comment or be unexported (golint)
  • Line 51: warning: exported type KeystoneAuthOptions should have comment or be unexported (golint)
  • Line 66: warning: exported method KeystoneAuthOptions.GetTenantId should have comment or be unexported (golint)
  • Line 70: warning: exported function NewNoauthOptions should have comment or be unexported (golint)
  • Line 74: warning: exported type NoAuthOptions should have comment or be unexported (golint)
  • Line 78: warning: exported method NoAuthOptions.GetTenantId should have comment or be unexported (golint)
  • Line 82: warning: exported function LoadKeystoneAuthOptionsFromEnv should have comment or be unexported (golint)
  • Line 120: warning: exported function LoadNoAuthOptionsFromEnv should have comment or be unexported (golint)

• api/client/fake.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 31: warning: exported var TestEp should have comment or be unexported (golint)
  • Line 34: warning: exported function NewFakeClient should have comment or be unexported (golint)
  • Line 75: warning: exported function NewFakeDockReceiver should have comment or be unexported (golint)
  • Line 109: warning: exported function NewFakePoolReceiver should have comment or be unexported (golint)
  • Line 143: warning: exported function NewFakeProfileReceiver should have comment or be unexported (golint)
  • Line 213: warning: exported function NewFakeVolumeReceiver should have comment or be unexported (golint)
  • Line 307: warning: exported function NewFakeReplicationReceiver should have comment or be unexported (golint)
  • Line 342: warning: exported function NewFakeVersionReceiver should have comment or be unexported (golint)
  • Line 380: warning: exported function NewFakeFileShareReceiver should have comment or be unexported (golint)
  • Line 448: warning: exported function NewFakeHostReceiver should have comment or be unexported (golint)

• api/client/volume.go
  • Line 49: warning: comment on exported function NewVolumeMgr should be of the form "NewVolumeMgr ..." (golint)
  • Line 58: warning: comment on exported type VolumeMgr should be of the form "VolumeMgr ..." (with optional leading article) (golint)
  • Line 65: warning: comment on exported method VolumeMgr.CreateVolume should be of the form "CreateVolume ..." (golint)
  • Line 79: warning: comment on exported method VolumeMgr.GetVolume should be of the form "GetVolume ..." (golint)
  • Line 93: warning: comment on exported method VolumeMgr.ListVolumes should be of the form "ListVolumes ..." (golint)
  • Line 115: warning: comment on exported method VolumeMgr.DeleteVolume should be of the form "DeleteVolume ..." (golint)
  • Line 124: warning: comment on exported method VolumeMgr.UpdateVolume should be of the form "UpdateVolume ..." (golint)
  • Line 152: warning: comment on exported method VolumeMgr.CreateVolumeAttachment should be of the form "CreateVolumeAttachment ..." (golint)
  • Line 166: warning: comment on exported method VolumeMgr.UpdateVolumeAttachment should be of the form "UpdateVolumeAttachment ..." (golint)
  • Line 180: warning: comment on exported method VolumeMgr.GetVolumeAttachment should be of the form "GetVolumeAttachment ..." (golint)
  • Line 194: warning: comment on exported method VolumeMgr.ListVolumeAttachments should be of the form "ListVolumeAttachments ..." (golint)
  • Line 215: warning: comment on exported method VolumeMgr.DeleteVolumeAttachment should be of the form "DeleteVolumeAttachment ..." (golint)
  • Line 224: warning: comment on exported method VolumeMgr.CreateVolumeSnapshot should be of the form "CreateVolumeSnapshot ..." (golint)
  • Line 238: warning: comment on exported method VolumeMgr.GetVolumeSnapshot should be of the form "GetVolumeSnapshot ..." (golint)
  • Line 252: warning: comment on exported method VolumeMgr.ListVolumeSnapshots should be of the form "ListVolumeSnapshots ..." (golint)
  • Line 276: warning: comment on exported method VolumeMgr.DeleteVolumeSnapshot should be of the form "DeleteVolumeSnapshot ..." (golint)
  • Line 285: warning: comment on exported method VolumeMgr.UpdateVolumeSnapshot should be of the form "UpdateVolumeSnapshot ..." (golint)
  • Line 299: warning: comment on exported method VolumeMgr.CreateVolumeGroup should be of the form "CreateVolumeGroup ..." (golint)
  • Line 313: warning: comment on exported method VolumeMgr.GetVolumeGroup should be of the form "GetVolumeGroup ..." (golint)
  • Line 327: warning: comment on exported method VolumeMgr.ListVolumeGroups should be of the form "ListVolumeGroups ..." (golint)
  • Line 350: warning: comment on exported method VolumeMgr.DeleteVolumeGroup should be of the form "DeleteVolumeGroup ..." (golint)
  • Line 359: warning: comment on exported method VolumeMgr.UpdateVolumeGroup should be of the form "UpdateVolumeGroup ..." (golint)

• api/pkg/api/controllers/alert.go
  • Line 33: warning: exported function NewAlertPortal should have comment or be unexported (golint)
  • Line 39: warning: exported type AlertPortal should have comment or be unexported (golint)
  • Line 45: warning: exported method AlertPortal.CreateAlert should have comment or be unexported (golint)

• api/osdsctl/cli/cli.go
  • Line 42: warning: exported var Debug should have comment or be unexported (golint)
  • Line 57: warning: exported type DummyWriter should have comment or be unexported (golint)
  • Line 64: warning: exported type DebugWriter should have comment or be unexported (golint)

• api/pkg/api/controllers/metrics.go
  • Line 37: warning: should not use dot imports (golint)
  • Line 40: warning: comment on exported var PrometheusConfHome should be of the form "PrometheusConfHome ..." (golint)
  • Line 42: warning: exported var PrometheusUrl should have comment or be unexported (golint)
  • Line 43: warning: exported var PrometheusConfFile should have comment or be unexported (golint)
  • Line 45: warning: comment on exported var AlertmgrConfHome should be of the form "AlertmgrConfHome ..." (golint)
  • Line 47: warning: exported var AlertmgrUrl should have comment or be unexported (golint)
  • Line 48: warning: exported var AlertmgrConfFile should have comment or be unexported (golint)
  • Line 50: warning: exported var GrafanaConfHome should have comment or be unexported (golint)
  • Line 51: warning: exported var GrafanaRestartCmd should have comment or be unexported (golint)
  • Line 52: warning: exported var GrafanaConfFile should have comment or be unexported (golint)
  • Line 54: warning: exported var ReloadPath should have comment or be unexported (golint)
  • Line 55: warning: exported var BackupExtension should have comment or be unexported (golint)
  • Line 75: warning: exported function NewMetricsPortal should have comment or be unexported (golint)
  • Line 81: warning: exported type MetricsPortal should have comment or be unexported (golint)
  • Line 87: warning: exported method MetricsPortal.GetMetrics should have comment or be unexported (golint)
  • Line 126: warning: exported method MetricsPortal.UploadConfFile should have comment or be unexported (golint)
  • Line 155: warning: exported function DoUpload should have comment or be unexported (golint)
  • Line 213: warning: exported method MetricsPortal.DownloadConfFile should have comment or be unexported (golint)
  • Line 231: warning: exported function DoDownload should have comment or be unexported (golint)
  • Line 245: warning: exported method MetricsPortal.CollectMetrics should have comment or be unexported (golint)
  • Line 285: warning: exported method MetricsPortal.GetUrls should have comment or be unexported (golint)

• api/pkg/api/controllerclient/client.go
  • Line 48: warning: exported function NewClient should have comment or be unexported (golint)

• api/testutils/driver/replication_sample.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 31: warning: comment on exported type ReplicationDriver should be of the form "ReplicationDriver ..." (with optional leading article) (golint)
  • Line 34: warning: comment on exported method ReplicationDriver.Setup should be of the form "Setup ..." (golint)
  • Line 37: warning: comment on exported method ReplicationDriver.Unset should be of the form "Unset ..." (golint)
  • Line 40: warning: comment on exported method ReplicationDriver.CreateReplication should be of the form "CreateReplication ..." (golint)
  • Line 45: warning: exported method ReplicationDriver.DeleteReplication should have comment or be unexported (golint)
  • Line 49: warning: exported method ReplicationDriver.EnableReplication should have comment or be unexported (golint)
  • Line 53: warning: exported method ReplicationDriver.DisableReplication should have comment or be unexported (golint)
  • Line 57: warning: exported method ReplicationDriver.FailoverReplication should have comment or be unexported (golint)

• api/testutils/driver/sample.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 31: warning: comment on exported type Driver should be of the form "Driver ..." (with optional leading article) (golint)
  • Line 34: warning: comment on exported method Driver.Setup should be of the form "Setup ..." (golint)
  • Line 37: warning: comment on exported method Driver.Unset should be of the form "Unset ..." (golint)
  • Line 40: warning: comment on exported method Driver.CreateVolume should be of the form "CreateVolume ..." (golint)
  • Line 45: warning: comment on exported method Driver.PullVolume should be of the form "PullVolume ..." (golint)
  • Line 56: warning: comment on exported method Driver.DeleteVolume should be of the form "DeleteVolume ..." (golint)
  • Line 66: warning: comment on exported method Driver.InitializeConnection should be of the form "InitializeConnection ..." (golint)
  • Line 71: warning: comment on exported method Driver.TerminateConnection should be of the form "TerminateConnection ..." (golint)
  • Line 74: warning: comment on exported method Driver.CreateSnapshot should be of the form "CreateSnapshot ..." (golint)
  • Line 79: warning: comment on exported method Driver.PullSnapshot should be of the form "PullSnapshot ..." (golint)
  • Line 90: warning: comment on exported method Driver.DeleteSnapshot should be of the form "DeleteSnapshot ..." (golint)
  • Line 95: warning: comment on exported method Driver.ListPools should be of the form "ListPools ..." (golint)
  • Line 105: warning: exported method Driver.InitializeSnapshotConnection should have comment or be unexported (golint)
  • Line 109: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
  • Line 113: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
  • Line 117: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
  • Line 121: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
  • Line 125: warning: exported method Driver.CreateFileShare should have comment or be unexported (golint)
  • Line 129: warning: exported method Driver.DeleteFileShare should have comment or be unexported (golint)
  • Line 133: warning: exported method Driver.CreateFileShareAcl should have comment or be unexported (golint)
  • Line 137: warning: exported method Driver.DeleteFileShareAcl should have comment or be unexported (golint)
  • Line 141: warning: comment on exported method Driver.CreateFileShareSnapshot should be of the form "CreateFileShareSnapshot ..." (golint)
  • Line 146: warning: comment on exported method Driver.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)

• api/pkg/api/main.go
  • Line 40: warning: exported const AddressIdx should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: exported function Run should have comment or be unexported (golint)

• api/pkg/utils/logs/logs.go
  • Line 30: warning: exported const DefaultLogDir should have comment or be unexported (golint)
  • Line 49: warning: exported type GlogWriter should have comment or be unexported (golint)
  • Line 68: warning: exported function InitLogs should have comment or be unexported (golint)
  • Line 80: warning: exported function FlushLogs should have comment or be unexported (golint)

• api/pkg/model/version.go
  • Line 29: warning: comment on exported type VersionSpec should be of the form "VersionSpec ..." (with optional leading article) (golint)
  • Line 48: warning: exported function Current should have comment or be unexported (golint)
  • Line 52: warning: exported function Supported should have comment or be unexported (golint)
  • Line 56: warning: exported function Deprecated should have comment or be unexported (golint)
  • Line 60: warning: exported function CurrentVersion should have comment or be unexported (golint)

• api/client/profile.go
  • Line 35: warning: comment on exported function NewProfileMgr should be of the form "NewProfileMgr ..." (golint)
  • Line 44: warning: comment on exported type ProfileMgr should be of the form "ProfileMgr ..." (with optional leading article) (golint)
  • Line 51: warning: comment on exported method ProfileMgr.CreateProfile should be of the form "CreateProfile ..." (golint)
  • Line 65: warning: comment on exported method ProfileMgr.GetProfile should be of the form "GetProfile ..." (golint)
  • Line 93: warning: comment on exported method ProfileMgr.ListProfiles should be of the form "ListProfiles ..." (golint)
  • Line 116: warning: comment on exported method ProfileMgr.DeleteProfile should be of the form "DeleteProfile ..." (golint)
  • Line 125: warning: comment on exported method ProfileMgr.AddCustomProperty should be of the form "AddCustomProperty ..." (golint)
  • Line 140: warning: comment on exported method ProfileMgr.ListCustomProperties should be of the form "ListCustomProperties ..." (golint)
  • Line 155: warning: comment on exported method ProfileMgr.RemoveCustomProperty should be of the form "RemoveCustomProperty ..." (golint)

• api/pkg/model/proto/response.go
  • Line 22: warning: exported function GenericResponseResult should have comment or be unexported (golint)
  • Line 45: warning: exported function GenericResponseError should have comment or be unexported (golint)

• api/pkg/utils/config/config_define.go
  • Line 19: warning: exported type Default should have comment or be unexported (golint)
  • Line 21: warning: exported type OsdsApiServer should have comment or be unexported (golint)
  • Line 50: warning: exported type OsdsLet should have comment or be unexported (golint)
  • Line 64: warning: exported type OsdsDock should have comment or be unexported (golint)
  • Line 75: warning: exported type Database should have comment or be unexported (golint)
  • Line 88: warning: exported type BackendProperties should have comment or be unexported (golint)
  • Line 96: warning: exported type Backends should have comment or be unexported (golint)
  • Line 113: warning: exported type KeystoneAuthToken should have comment or be unexported (golint)
  • Line 131: warning: exported type Config should have comment or be unexported (golint)

• api/pkg/model/base.go
  • Line 24: warning: exported type BaseModel should have comment or be unexported (golint)
  • Line 68: warning: exported method DataStorageLoS.IsEmptyStorageAccessCapability should have comment or be unexported (golint)
  • Line 73: warning: exported method DataStorageLoS.IsEmpty should have comment or be unexported (golint)
  • Line 109: warning: exported method IOConnectivityLoS.IsEmpty should have comment or be unexported (golint)
  • Line 180: warning: exported method DataProtectionLoS.IsEmpty should have comment or be unexported (golint)

• api/pkg/model/pool.go
  • Line 23: warning: exported const ReplicationTypeHost should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: comment on exported type StoragePoolSpec should be of the form "StoragePoolSpec ..." (with optional leading article) (golint)
  • Line 82: warning: exported type StoragePoolExtraSpec should have comment or be unexported (golint)

• api/pkg/api/controllers/pool.go
  • Line 32: warning: exported type PoolPortal should have comment or be unexported (golint)
  • Line 36: warning: exported method PoolPortal.ListAvailabilityZones should have comment or be unexported (golint)
  • Line 58: warning: exported method PoolPortal.ListPools should have comment or be unexported (golint)
  • Line 89: warning: exported method PoolPortal.GetPool should have comment or be unexported (golint)

• api/testutils/db/fake.go
  • Line 22: warning: should not use dot imports (golint)
  • Line 25: warning: comment on exported type FakeDbClient should be of the form "FakeDbClient ..." (with optional leading article) (golint)
  • Line 28: warning: comment on exported function NewFakeDbClient should be of the form "NewFakeDbClient ..." (golint)
  • Line 33: warning: comment on exported method FakeDbClient.CreateFileShareAcl should be of the form "CreateFileShareAcl ..." (golint)
  • Line 38: warning: comment on exported method FakeDbClient.UpdateFileShareAcl should be of the form "UpdateFileShareAcl ..." (golint)
  • Line 43: warning: comment on exported method FakeDbClient.ListFileSharesAcl should be of the form "ListFileSharesAcl ..." (golint)
  • Line 52: warning: exported method FakeDbClient.ListFileShareAclsByShareId should have comment or be unexported (golint)
  • Line 60: warning: comment on exported method FakeDbClient.CreateFileShare should be of the form "CreateFileShare ..." (golint)
  • Line 65: warning: comment on exported method FakeDbClient.GetFileShare should be of the form "GetFileShare ..." (golint)
  • Line 71: warning: comment on exported method FakeDbClient.GetFileShareAcl should be of the form "GetFileShareAcl ..." (golint)
  • Line 77: warning: comment on exported method FakeDbClient.ListFileSharesWithFilter should be of the form "ListFileSharesWithFilter ..." (golint)
  • Line 87: warning: comment on exported method FakeDbClient.ListFileSharesAclWithFilter should be of the form "ListFileSharesAclWithFilter ..." (golint)
  • Line 97: warning: exported method FakeDbClient.ListFileShares should have comment or be unexported (golint)
  • Line 106: warning: comment on exported method FakeDbClient.ListFileSharesByProfileId should be of the form "ListFileSharesByProfileId ..." (golint)
  • Line 111: warning: comment on exported method FakeDbClient.UpdateFileShare should be of the form "UpdateFileShare ..." (golint)
  • Line 116: warning: comment on exported method FakeDbClient.DeleteFileShare should be of the form "DeleteFileShare ..." (golint)
  • Line 121: warning: comment on exported method FakeDbClient.DeleteFileShareAcl should be of the form "DeleteFileShareAcl ..." (golint)
  • Line 126: warning: comment on exported method FakeDbClient.CreateFileShareSnapshot should be of the form "CreateFileShareSnapshot ..." (golint)
  • Line 131: warning: comment on exported method FakeDbClient.GetFileShareSnapshot should be of the form "GetFileShareSnapshot ..." (golint)
  • Line 137: warning: comment on exported method FakeDbClient.ListFileShareSnapshotsWithFilter should be of the form "ListFileShareSnapshotsWithFilter ..." (golint)
  • Line 147: warning: exported method FakeDbClient.ListFileShareSnapshots should have comment or be unexported (golint)
  • Line 156: warning: exported method FakeDbClient.ListSnapshotsByShareId should have comment or be unexported (golint)
  • Line 165: warning: comment on exported method FakeDbClient.UpdateFileShareSnapshot should be of the form "UpdateFileShareSnapshot ..." (golint)
  • Line 170: warning: comment on exported method FakeDbClient.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)
  • Line 175: warning: comment on exported method FakeDbClient.CreateDock should be of the form "CreateDock ..." (golint)
  • Line 180: warning: comment on exported method FakeDbClient.GetDock should be of the form "GetDock ..." (golint)
  • Line 191: warning: comment on exported method FakeDbClient.GetDockByPoolId should be of the form "GetDockByPoolId ..." (golint)
  • Line 205: warning: comment on exported method FakeDbClient.ListDocksWithFilter should be of the form "ListDocksWithFilter ..." (golint)
  • Line 214: warning: exported method FakeDbClient.ListDocks should have comment or be unexported (golint)
  • Line 223: warning: comment on exported method FakeDbClient.ListAvailabilityZones should be of the form "ListAvailabilityZones ..." (golint)
  • Line 233: warning: comment on exported method FakeDbClient.UpdateDock should be of the form "UpdateDock ..." (golint)
  • Line 238: warning: comment on exported method FakeDbClient.DeleteDock should be of the form "DeleteDock ..." (golint)
  • Line 243: warning: exported method FakeDbClient.CreatePool should have comment or be unexported (golint)
  • Line 247: warning: comment on exported method FakeDbClient.GetPool should be of the form "GetPool ..." (golint)
  • Line 258: warning: comment on exported method FakeDbClient.ListPoolsWithFilter should be of the form "ListPoolsWithFilter ..." (golint)
  • Line 267: warning: exported method FakeDbClient.ListPools should have comment or be unexported (golint)
  • Line 276: warning: comment on exported method FakeDbClient.UpdatePool should be of the form "UpdatePool ..." (golint)
  • Line 281: warning: comment on exported method FakeDbClient.DeletePool should be of the form "DeletePool ..." (golint)
  • Line 286: warning: comment on exported method FakeDbClient.CreateProfile should be of the form "CreateProfile ..." (golint)
  • Line 291: warning: comment on exported method FakeDbClient.GetProfile should be of the form "GetProfile ..." (golint)
  • Line 302: warning: comment on exported method FakeDbClient.GetDefaultProfile should be of the form "GetDefaultProfile ..." (golint)
  • Line 313: warning: comment on exported method FakeDbClient.GetDefaultProfileFileShare should be of the form "GetDefaultProfileFileShare ..." (golint)
  • Line 324: warning: comment on exported method FakeDbClient.ListProfilesWithFilter should be of the form "ListProfilesWithFilter ..." (golint)
  • Line 333: warning: exported method FakeDbClient.ListProfiles should have comment or be unexported (golint)
  • Line 342: warning: comment on exported method FakeDbClient.UpdateProfile should be of the form "UpdateProfile ..." (golint)
  • Line 347: warning: comment on exported method FakeDbClient.DeleteProfile should be of the form "DeleteProfile ..." (golint)
  • Line 352: warning: comment on exported method FakeDbClient.AddCustomProperty should be of the form "AddCustomProperty ..." (golint)
  • Line 358: warning: comment on exported method FakeDbClient.ListCustomProperties should be of the form "ListCustomProperties ..." (golint)
  • Line 364: warning: comment on exported method FakeDbClient.RemoveCustomProperty should be of the form "RemoveCustomProperty ..." (golint)
  • Line 369: warning: comment on exported method FakeDbClient.CreateVolume should be of the form "CreateVolume ..." (golint)
  • Line 374: warning: comment on exported method FakeDbClient.GetVolume should be of the form "GetVolume ..." (golint)
  • Line 380: warning: comment on exported method FakeDbClient.ListVolumesWithFilter should be of the form "ListVolumesWithFilter ..." (golint)
  • Line 389: warning: exported method FakeDbClient.ListVolumes should have comment or be unexported (golint)
  • Line 398: warning: comment on exported method FakeDbClient.ListVolumesByProfileId should be of the form "ListVolumesByProfileId ..." (golint)
  • Line 404: warning: comment on exported method FakeDbClient.UpdateVolume should be of the form "UpdateVolume ..." (golint)
  • Line 409: warning: comment on exported method FakeDbClient.DeleteVolume should be of the form "DeleteVolume ..." (golint)
  • Line 419: warning: comment on exported method FakeDbClient.CreateVolumeAttachment should be of the form "CreateVolumeAttachment ..." (golint)
  • Line 424: warning: comment on exported method FakeDbClient.GetVolumeAttachment should be of the form "GetVolumeAttachment ..." (golint)
  • Line 430: warning: comment on exported method FakeDbClient.ListVolumeAttachmentsWithFilter should be of the form "ListVolumeAttachmentsWithFilter ..." (golint)
  • Line 439: warning: exported method FakeDbClient.ListVolumeAttachments should have comment or be unexported (golint)
  • Line 448: warning: comment on exported method FakeDbClient.UpdateVolumeAttachment should be of the form "UpdateVolumeAttachment ..." (golint)
  • Line 453: warning: comment on exported method FakeDbClient.DeleteVolumeAttachment should be of the form "DeleteVolumeAttachment ..." (golint)
  • Line 459: warning: comment on exported method FakeDbClient.CreateVolumeSnapshot should be of the form "CreateVolumeSnapshot ..." (golint)
  • Line 464: warning: comment on exported method FakeDbClient.GetVolumeSnapshot should be of the form "GetVolumeSnapshot ..." (golint)
  • Line 470: warning: comment on exported method FakeDbClient.ListVolumeSnapshotsWithFilter should be of the form "ListVolumeSnapshotsWithFilter ..." (golint)
  • Line 479: warning: exported method FakeDbClient.ListVolumeSnapshots should have comment or be unexported (golint)
  • Line 488: warning: comment on exported method FakeDbClient.UpdateVolumeSnapshot should be of the form "UpdateVolumeSnapshot ..." (golint)
  • Line 493: warning: comment on exported method FakeDbClient.DeleteVolumeSnapshot should be of the form "DeleteVolumeSnapshot ..." (golint)
  • Line 498: warning: exported method FakeDbClient.CreateReplication should have comment or be unexported (golint)
  • Line 502: warning: exported method FakeDbClient.GetReplication should have comment or be unexported (golint)
  • Line 506: warning: exported method FakeDbClient.ListReplication should have comment or be unexported (golint)
  • Line 513: warning: exported method FakeDbClient.GetReplicationByVolumeId should have comment or be unexported (golint)
  • Line 517: warning: exported method FakeDbClient.ListReplicationWithFilter should have comment or be unexported (golint)
  • Line 524: warning: exported method FakeDbClient.DeleteReplication should have comment or be unexported (golint)
  • Line 528: warning: exported method FakeDbClient.UpdateReplication should have comment or be unexported (golint)
  • Line 532: warning: comment on exported method FakeDbClient.CreateVolumeGroup should be of the form "CreateVolumeGroup ..." (golint)
  • Line 537: warning: exported method FakeDbClient.UpdateVolumeGroup should have comment or be unexported (golint)
  • Line 541: warning: exported method FakeDbClient.GetVolumeGroup should have comment or be unexported (golint)
  • Line 545: warning: exported method FakeDbClient.UpdateStatus should have comment or be unexported (golint)
  • Line 549: warning: exported method FakeDbClient.ListVolumesByIds should have comment or be unexported (golint)
  • Line 553: warning: exported method FakeDbClient.ListVolumesByGroupId should have comment or be unexported (golint)
  • Line 557: warning: exported method FakeDbClient.ListSnapshotsByVolumeId should have comment or be unexported (golint)
  • Line 561: warning: exported method FakeDbClient.ListAttachmentsByVolumeId should have comment or be unexported (golint)
  • Line 565: warning: exported method FakeDbClient.DeleteVolumeGroup should have comment or be unexported (golint)
  • Line 569: warning: exported method FakeDbClient.ListVolumeGroupsWithFilter should have comment or be unexported (golint)
  • Line 576: warning: exported method FakeDbClient.ListVolumeGroups should have comment or be unexported (golint)
  • Line 583: warning: exported method FakeDbClient.VolumesToUpdate should have comment or be unexported (golint)
  • Line 587: warning: exported method FakeDbClient.ListHosts should have comment or be unexported (golint)
  • Line 587: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
  • Line 596: warning: exported method FakeDbClient.ListHostsByName should have comment or be unexported (golint)
  • Line 596: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
  • Line 605: warning: exported method FakeDbClient.CreateHost should have comment or be unexported (golint)
  • Line 605: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
  • Line 609: warning: exported method FakeDbClient.UpdateHost should have comment or be unexported (golint)
  • Line 609: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
  • Line 613: warning: exported method FakeDbClient.GetHost should have comment or be unexported (golint)
  • Line 613: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
  • Line 617: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
  • Line 621: warning: exported method FakeDbClient.DeleteHost should have comment or be unexported (golint)
  • Line 621: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)

• api/osdsctl/cli/common.go
  • Line 32: warning: exported function Printf should have comment or be unexported (golint)
  • Line 36: warning: exported function Debugf should have comment or be unexported (golint)
  • Line 43: warning: exported function Warnf should have comment or be unexported (golint)
  • Line 47: warning: exported function Errorf should have comment or be unexported (golint)
  • Line 51: warning: exported function Fatalf should have comment or be unexported (golint)
  • Line 56: warning: exported function Println should have comment or be unexported (golint)
  • Line 60: warning: exported function Debugln should have comment or be unexported (golint)
  • Line 68: warning: exported function Warnln should have comment or be unexported (golint)
  • Line 73: warning: exported function Errorln should have comment or be unexported (golint)
  • Line 78: warning: exported function Fatalln should have comment or be unexported (golint)
  • Line 84: warning: comment on exported function HttpErrStrip should be of the form "HttpErrStrip ..." (golint)
  • Line 96: warning: exported function ArgsNumCheck should have comment or be unexported (golint)

• api/client/receiver.go
  • Line 38: warning: exported function NewHttpError should have comment or be unexported (golint)
  • Line 42: warning: exported type HttpError should have comment or be unexported (golint)
  • Line 47: warning: exported method HttpError.Decode should have comment or be unexported (golint)
  • Line 60: warning: comment on exported type HeaderOption should be of the form "HeaderOption ..." (with optional leading article) (golint)
  • Line 63: warning: comment on exported type Receiver should be of the form "Receiver ..." (with optional leading article) (golint)
  • Line 68: warning: comment on exported function NewReceiver should be of the form "NewReceiver ..." (golint)
  • Line 160: warning: exported function NewKeystoneReceiver should have comment or be unexported (golint)
  • Line 169: warning: exported type KeystoneReceiver should have comment or be unexported (golint)
  • Line 173: warning: exported method KeystoneReceiver.GetToken should have comment or be unexported (golint)
  • Line 210: warning: exported method KeystoneReceiver.Recv should have comment or be unexported (golint)

• api/pkg/model/error.go
  • Line 28: warning: exported const ErrorBadRequest should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: comment on exported function ErrorBadRequestStatus should be of the form "ErrorBadRequestStatus ..." (golint)
  • Line 48: warning: comment on exported function ErrorForbiddenStatus should be of the form "ErrorForbiddenStatus ..." (golint)
  • Line 53: warning: comment on exported function ErrorUnauthorizedStatus should be of the form "ErrorUnauthorizedStatus ..." (golint)
  • Line 58: warning: comment on exported function ErrorNotFoundStatus should be of the form "ErrorNotFoundStatus ..." (golint)
  • Line 63: warning: comment on exported function ErrorInternalServerStatus should be of the form "ErrorInternalServerStatus ..." (golint)
  • Line 68: warning: comment on exported function ErrorNotImplementedStatus should be of the form "ErrorNotImplementedStatus ..." (golint)
  • Line 87: warning: comment on exported type NotImplementError should be of the form "NotImplementError ..." (with optional leading article) (golint)
  • Line 96: warning: exported type NotFoundError should have comment or be unexported (golint)
  • Line 100: warning: exported function NewNotFoundError should have comment or be unexported (golint)

• api/client/dock.go
  • Line 24: warning: exported function NewDockMgr should have comment or be unexported (golint)
  • Line 32: warning: exported type DockMgr should have comment or be unexported (golint)
  • Line 38: warning: exported method DockMgr.GetDock should have comment or be unexported (golint)
  • Line 51: warning: exported method DockMgr.ListDocks should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• api/pkg/utils/utils_test.go
  • Line 222: warning: ineffectual assignment to isEqual (ineffassign)

• api/pkg/api/policy/policy_test.go
  • Line 61: warning: ineffectual assignment to err (ineffassign)
  • Line 63: warning: ineffectual assignment to err (ineffassign)
  • Line 64: warning: ineffectual assignment to err (ineffassign)

• api/test/e2e/e2ef_test.go
  • Line 65: warning: ineffectual assignment to prfs (ineffassign)

misspell0%

Misspell Finds commonly misspelled English words

An error occurred while running this test (exit status 2)