Preparing report...

Report for github.com/sodafoundation/controller

A    Great!    Found 74 issues across 103 files

Tweet

gofmt81%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • controller/client/fake.go
    • Line 219: warning: cyclomatic complexity 31 of function (*fakeVolumeReceiver).Recv() is high (> 15) (gocyclo)
    • Line 386: warning: cyclomatic complexity 25 of function (*fakeFileShareReceiver).Recv() is high (> 15) (gocyclo)
    • Line 149: warning: cyclomatic complexity 21 of function (*fakeProfileReceiver).Recv() is high (> 15) (gocyclo)
    • controller/pkg/db/drivers/etcd/etcd.go
    • Line 2463: warning: cyclomatic complexity 20 of function (*Client).UpdateVolumeGroup() is high (> 15) (gocyclo)
    • Line 2510: warning: cyclomatic complexity 19 of function (*Client).UpdateStatus() is high (> 15) (gocyclo)
    • Line 1652: warning: cyclomatic complexity 18 of function (*Client).UpdateVolume() is high (> 15) (gocyclo)
    • Line 1575: warning: cyclomatic complexity 16 of function (*Client).FindVolumeValue() is high (> 15) (gocyclo)
    • controller/pkg/utils/config/config_test.go
    • Line 263: warning: cyclomatic complexity 35 of function TestOpensdsConfig() is high (> 15) (gocyclo)
    • Line 68: warning: cyclomatic complexity 33 of function TestFunctionAllType() is high (> 15) (gocyclo)
    • Line 169: warning: cyclomatic complexity 30 of function TestFunctionDefaultValue() is high (> 15) (gocyclo)

golint41%

Golint is a linter for Go source code.

    • controller/pkg/utils/config/config.go
    • Line 33: warning: exported const ConfKeyName should have comment (or a comment on this block) or be unexported (golint)
    • Line 255: warning: comment on exported var CONF should be of the form "CONF ..." (golint)
    • Line 258: warning: comment on exported function GetDefaultConfig should be of the form "GetDefaultConfig ..." (golint)
    • Line 265: warning: exported function GetConfigPath should have comment or be unexported (golint)
    • Line 277: warning: exported method Config.Load should have comment or be unexported (golint)
    • Line 284: warning: exported function GetBackendsMap should have comment or be unexported (golint)
    • controller/client/dock.go
    • Line 24: warning: exported function NewDockMgr should have comment or be unexported (golint)
    • Line 32: warning: exported type DockMgr should have comment or be unexported (golint)
    • Line 38: warning: exported method DockMgr.GetDock should have comment or be unexported (golint)
    • Line 51: warning: exported method DockMgr.ListDocks should have comment or be unexported (golint)
    • controller/pkg/controller/metrics/adapters/metrics_dispatcher.go
    • Line 1: warning: package comment should be of the form "Package adapters ..." (golint)
    • Line 21: warning: comment on exported var MetricsQueue should be of the form "MetricsQueue ..." (golint)
    • Line 24: warning: exported function SendMetricToRegisteredSenders should have comment or be unexported (golint)
    • Line 33: warning: exported function StartDispatcher should have comment or be unexported (golint)
    • controller/pkg/utils/logs/logs.go
    • Line 30: warning: exported const DefaultLogDir should have comment or be unexported (golint)
    • Line 49: warning: exported type GlogWriter should have comment or be unexported (golint)
    • Line 68: warning: exported function InitLogs should have comment or be unexported (golint)
    • Line 80: warning: exported function FlushLogs should have comment or be unexported (golint)
    • controller/pkg/utils/exec/exec.go
    • Line 25: warning: exported type Executer should have comment or be unexported (golint)
    • Line 29: warning: exported function Run should have comment or be unexported (golint)
    • Line 48: warning: exported function NewBaseExecuter should have comment or be unexported (golint)
    • Line 52: warning: exported type BaseExecuter should have comment or be unexported (golint)
    • Line 54: warning: exported method BaseExecuter.Run should have comment or be unexported (golint)
    • Line 58: warning: exported function NewRootExecuter should have comment or be unexported (golint)
    • Line 62: warning: exported type RootExeucter should have comment or be unexported (golint)
    • Line 64: warning: exported method RootExeucter.Run should have comment or be unexported (golint)
    • controller/pkg/model/fileshare.go
    • Line 15: warning: package comment should be of the form "Package model ..." (golint)
    • Line 20: warning: exported type FileShareAclSpec should have comment or be unexported (golint)
    • Line 57: warning: exported type FileShareSpec should have comment or be unexported (golint)
    • controller/pkg/db/db.go
    • Line 29: warning: should not use dot imports (golint)
    • Line 238: warning: exported function UpdateFileShareStatus should have comment or be unexported (golint)
    • Line 243: warning: exported function UpdateFileShareSnapshotStatus should have comment or be unexported (golint)
    • Line 248: warning: exported function UpdateFileShareAclStatus should have comment or be unexported (golint)
    • Line 253: warning: exported function UpdateVolumeStatus should have comment or be unexported (golint)
    • Line 258: warning: exported function UpdateVolumeAttachmentStatus should have comment or be unexported (golint)
    • Line 263: warning: exported function UpdateVolumeSnapshotStatus should have comment or be unexported (golint)
    • Line 268: warning: exported function UpdateReplicationStatus should have comment or be unexported (golint)
    • Line 273: warning: exported function UpdateVolumeGroupStatus should have comment or be unexported (golint)
    • controller/client/profile.go
    • Line 35: warning: comment on exported function NewProfileMgr should be of the form "NewProfileMgr ..." (golint)
    • Line 44: warning: comment on exported type ProfileMgr should be of the form "ProfileMgr ..." (with optional leading article) (golint)
    • Line 51: warning: comment on exported method ProfileMgr.CreateProfile should be of the form "CreateProfile ..." (golint)
    • Line 65: warning: comment on exported method ProfileMgr.GetProfile should be of the form "GetProfile ..." (golint)
    • Line 93: warning: comment on exported method ProfileMgr.ListProfiles should be of the form "ListProfiles ..." (golint)
    • Line 116: warning: comment on exported method ProfileMgr.DeleteProfile should be of the form "DeleteProfile ..." (golint)
    • Line 125: warning: comment on exported method ProfileMgr.AddCustomProperty should be of the form "AddCustomProperty ..." (golint)
    • Line 140: warning: comment on exported method ProfileMgr.ListCustomProperties should be of the form "ListCustomProperties ..." (golint)
    • Line 155: warning: comment on exported method ProfileMgr.RemoveCustomProperty should be of the form "RemoveCustomProperty ..." (golint)
    • controller/pkg/model/profile.go
    • Line 30: warning: comment on exported type ProfileSpec should be of the form "ProfileSpec ..." (with optional leading article) (golint)
    • Line 74: warning: exported function NewProfileFromJson should have comment or be unexported (golint)
    • Line 83: warning: exported method ProfileSpec.ToJson should have comment or be unexported (golint)
    • Line 91: warning: exported type ProvisioningPropertiesSpec should have comment or be unexported (golint)
    • Line 98: warning: exported method ProvisioningPropertiesSpec.IsEmpty should have comment or be unexported (golint)
    • Line 103: warning: exported type ReplicationPropertiesSpec should have comment or be unexported (golint)
    • Line 132: warning: exported method ReplicationPropertiesSpec.IsEmpty should have comment or be unexported (golint)
    • Line 139: warning: exported type SnapshotPropertiesSpec should have comment or be unexported (golint)
    • Line 165: warning: exported method SnapshotPropertiesSpec.IsEmpty should have comment or be unexported (golint)
    • Line 172: warning: exported type DataProtectionPropertiesSpec should have comment or be unexported (golint)
    • Line 180: warning: exported method DataProtectionPropertiesSpec.IsEmpty should have comment or be unexported (golint)
    • Line 191: warning: exported method CustomPropertiesSpec.IsEmpty should have comment or be unexported (golint)
    • Line 198: warning: exported method CustomPropertiesSpec.Encode should have comment or be unexported (golint)
    • Line 203: warning: exported method CustomPropertiesSpec.GetCapabilitiesProperties should have comment or be unexported (golint)
    • controller/pkg/controller/grpcserver.go
    • Line 28: warning: exported function NewGrpcServer should have comment or be unexported (golint)
    • Line 36: warning: exported type GrpcServer should have comment or be unexported (golint)
    • Line 96: warning: exported method GrpcServer.CreateVolume should have comment or be unexported (golint)
    • Line 197: warning: comment on exported method GrpcServer.CreateFileShareAcl should be of the form "CreateFileShareAcl ..." (golint)
    • Line 215: warning: comment on exported method GrpcServer.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)
    • controller/pkg/db/drivers/etcd/etcd.go
    • Line 76: warning: exported function IsAdminContext should have comment or be unexported (golint)
    • Line 80: warning: exported function AuthorizeProjectContext should have comment or be unexported (golint)
    • Line 84: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 91: warning: comment on exported type Client should be of the form "Client ..." (with optional leading article) (golint)
    • Line 96: warning: comment on exported type Parameter should be of the form "Parameter ..." (with optional leading article) (golint)
    • Line 102: warning: comment on exported method Client.IsInArray should be of the form "IsInArray ..." (golint)
    • Line 112: warning: exported method Client.SelectOrNot should have comment or be unexported (golint)
    • Line 121: warning: comment on exported method Client.GetLimit should be of the form "GetLimit ..." (golint)
    • Line 139: warning: comment on exported method Client.GetOffset should be of the form "GetOffset ..." (golint)
    • Line 166: warning: comment on exported method Client.GetSortDir should be of the form "GetSortDir ..." (golint)
    • Line 183: warning: comment on exported method Client.GetSortKey should be of the form "GetSortKey ..." (golint)
    • Line 201: warning: exported method Client.FilterAndSort should have comment or be unexported (golint)
    • Line 211: warning: comment on exported method Client.ParameterFilter should be of the form "ParameterFilter ..." (golint)
    • Line 233: warning: don't use underscores in Go names; var fileshare_sortKey should be fileshareSortKey (golint)
    • Line 235: warning: exported type FileShareSlice should have comment or be unexported (golint)
    • Line 268: warning: exported method Client.FindFileShareValue should have comment or be unexported (golint)
    • Line 298: warning: exported method Client.CreateFileShareAcl should have comment or be unexported (golint)
    • Line 332: warning: comment on exported method Client.UpdateFileShareAcl should be of the form "UpdateFileShareAcl ..." (golint)
    • Line 365: warning: exported method Client.CreateFileShare should have comment or be unexported (golint)
    • Line 385: warning: exported method Client.SortFileShares should have comment or be unexported (golint)
    • Line 397: warning: exported method Client.ListFileSharesAclWithFilter should have comment or be unexported (golint)
    • Line 406: warning: exported method Client.ListFileSharesAcl should have comment or be unexported (golint)
    • Line 437: warning: exported method Client.ListFileShareAclsByShareId should have comment or be unexported (golint)
    • Line 452: warning: exported method Client.ListSnapshotsByShareId should have comment or be unexported (golint)
    • Line 467: warning: exported method Client.ListFileSharesWithFilter should have comment or be unexported (golint)
    • Line 482: warning: comment on exported method Client.ListFileShares should be of the form "ListFileShares ..." (golint)
    • Line 514: warning: comment on exported method Client.ListFileSharesByProfileId should be of the form "ListFileSharesByProfileId ..." (golint)
    • Line 520: warning: don't use underscores in Go names; var res_fileshares should be resFileshares (golint)
    • Line 529: warning: comment on exported method Client.GetFileShareAcl should be of the form "GetFileShareAcl ..." (golint)
    • Line 565: warning: comment on exported method Client.GetFileShare should be of the form "GetFileShare ..." (golint)
    • Line 657: warning: comment on exported method Client.DeleteFileShareAcl should be of the form "DeleteFileShareAcl ..." (golint)
    • Line 681: warning: comment on exported method Client.DeleteFileShare should be of the form "DeleteFileShare ..." (golint)
    • Line 705: warning: comment on exported method Client.CreateFileShareSnapshot should be of the form "CreateFileShareSnapshot ..." (golint)
    • Line 726: warning: exported method Client.GetFileShareSnapshot should have comment or be unexported (golint)
    • Line 762: warning: comment on exported method Client.ListFileShareSnapshots should be of the form "ListFileShareSnapshots ..." (golint)
    • Line 791: warning: exported method Client.ListFileShareSnapshotsWithFilter should have comment or be unexported (golint)
    • Line 806: warning: comment on exported method Client.UpdateFileShareSnapshot should be of the form "UpdateFileShareSnapshot ..." (golint)
    • Line 853: warning: comment on exported method Client.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)
    • Line 879: warning: comment on exported method Client.CreateDock should be of the form "CreateDock ..." (golint)
    • Line 907: warning: comment on exported method Client.GetDock should be of the form "GetDock ..." (golint)
    • Line 926: warning: comment on exported method Client.GetDockByPoolId should be of the form "GetDockByPoolId ..." (golint)
    • Line 947: warning: comment on exported method Client.ListDocks should be of the form "ListDocks ..." (golint)
    • Line 973: warning: exported method Client.ListDocksWithFilter should have comment or be unexported (golint)
    • Line 988: warning: comment on exported method Client.UpdateDock should be of the form "UpdateDock ..." (golint)
    • Line 1019: warning: comment on exported method Client.DeleteDock should be of the form "DeleteDock ..." (golint)
    • Line 1032: warning: comment on exported method Client.CreatePool should be of the form "CreatePool ..." (golint)
    • Line 1059: warning: exported method Client.ListPoolsWithFilter should have comment or be unexported (golint)
    • Line 1074: warning: comment on exported method Client.GetPool should be of the form "GetPool ..." (golint)
    • Line 1093: warning: comment on exported method Client.ListAvailabilityZones should be of the form "ListAvailabilityZones ..." (golint)
    • Line 1120: warning: comment on exported method Client.ListPools should be of the form "ListPools ..." (golint)
    • Line 1146: warning: comment on exported method Client.UpdatePool should be of the form "UpdatePool ..." (golint)
    • Line 1177: warning: comment on exported method Client.DeletePool should be of the form "DeletePool ..." (golint)
    • Line 1190: warning: comment on exported method Client.CreateProfile should be of the form "CreateProfile ..." (golint)
    • Line 1222: warning: comment on exported method Client.GetProfile should be of the form "GetProfile ..." (golint)
    • Line 1273: warning: comment on exported method Client.GetDefaultProfile should be of the form "GetDefaultProfile ..." (golint)
    • Line 1278: warning: comment on exported method Client.GetDefaultProfileFileShare should be of the form "GetDefaultProfileFileShare ..." (golint)
    • Line 1283: warning: comment on exported method Client.ListProfiles should be of the form "ListProfiles ..." (golint)
    • Line 1310: warning: exported method Client.ListProfilesWithFilter should have comment or be unexported (golint)
    • Line 1325: warning: comment on exported method Client.UpdateProfile should be of the form "UpdateProfile ..." (golint)
    • Line 1367: warning: comment on exported method Client.DeleteProfile should be of the form "DeleteProfile ..." (golint)
    • Line 1380: warning: comment on exported method Client.AddCustomProperty should be of the form "AddCustomProperty ..." (golint)
    • Line 1403: warning: comment on exported method Client.ListCustomProperties should be of the form "ListCustomProperties ..." (golint)
    • Line 1412: warning: comment on exported method Client.RemoveCustomProperty should be of the form "RemoveCustomProperty ..." (golint)
    • Line 1426: warning: comment on exported method Client.CreateVolume should be of the form "CreateVolume ..." (golint)
    • Line 1454: warning: comment on exported method Client.GetVolume should be of the form "GetVolume ..." (golint)
    • Line 1490: warning: comment on exported method Client.ListVolumes should be of the form "ListVolumes ..." (golint)
    • Line 1522: warning: comment on exported method Client.ListVolumesByProfileId should be of the form "ListVolumesByProfileId ..." (golint)
    • Line 1539: warning: don't use underscores in Go names; var volume_sortKey should be volumeSortKey (golint)
    • Line 1541: warning: exported type VolumeSlice should have comment or be unexported (golint)
    • Line 1575: warning: exported method Client.FindVolumeValue should have comment or be unexported (golint)
    • Line 1611: warning: exported method Client.SortVolumes should have comment or be unexported (golint)
    • Line 1623: warning: exported method Client.ListVolumesWithFilter should have comment or be unexported (golint)
    • Line 1720: warning: comment on exported method Client.DeleteVolume should be of the form "DeleteVolume ..." (golint)
    • Line 1776: warning: comment on exported method Client.CreateVolumeAttachment should be of the form "CreateVolumeAttachment ..." (golint)
    • Line 1801: warning: exported method Client.GetVolumeAttachment should have comment or be unexported (golint)
    • Line 1837: warning: comment on exported method Client.ListVolumeAttachments should be of the form "ListVolumeAttachments ..." (golint)
    • Line 1867: warning: exported method Client.ListVolumeAttachmentsWithFilter should have comment or be unexported (golint)
    • Line 1886: warning: comment on exported method Client.UpdateVolumeAttachment should be of the form "UpdateVolumeAttachment ..." (golint)
    • Line 1943: warning: comment on exported method Client.DeleteVolumeAttachment should be of the form "DeleteVolumeAttachment ..." (golint)
    • Line 1967: warning: comment on exported method Client.CreateVolumeSnapshot should be of the form "CreateVolumeSnapshot ..." (golint)
    • Line 1988: warning: exported method Client.GetVolumeSnapshot should have comment or be unexported (golint)
    • Line 2024: warning: comment on exported method Client.ListVolumeSnapshots should be of the form "ListVolumeSnapshots ..." (golint)
    • Line 2053: warning: exported method Client.ListVolumeSnapshotsWithFilter should have comment or be unexported (golint)
    • Line 2068: warning: comment on exported method Client.UpdateVolumeSnapshot should be of the form "UpdateVolumeSnapshot ..." (golint)
    • Line 2118: warning: comment on exported method Client.DeleteVolumeSnapshot should be of the form "DeleteVolumeSnapshot ..." (golint)
    • Line 2142: warning: exported method Client.CreateReplication should have comment or be unexported (golint)
    • Line 2167: warning: exported method Client.GetReplication should have comment or be unexported (golint)
    • Line 2184: warning: exported method Client.GetReplicationByVolumeId should have comment or be unexported (golint)
    • Line 2216: warning: exported method Client.ListReplication should have comment or be unexported (golint)
    • Line 2279: warning: exported method Client.SelectReplication should have comment or be unexported (golint)
    • Line 2304: warning: exported type ReplicationsCompareFunc should have comment or be unexported (golint)
    • Line 2308: warning: exported type ReplicationSlice should have comment or be unexported (golint)
    • Line 2328: warning: exported method Client.SortReplications should have comment or be unexported (golint)
    • Line 2340: warning: exported method Client.ListReplicationWithFilter should have comment or be unexported (golint)
    • Line 2357: warning: exported method Client.DeleteReplication should have comment or be unexported (golint)
    • Line 2377: warning: exported method Client.UpdateReplication should have comment or be unexported (golint)
    • Line 2425: warning: exported method Client.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 2445: warning: exported method Client.GetVolumeGroup should have comment or be unexported (golint)
    • Line 2463: warning: exported method Client.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 2510: warning: exported method Client.UpdateStatus should have comment or be unexported (golint)
    • Line 2584: warning: exported method Client.ListVolumesByGroupId should have comment or be unexported (golint)
    • Line 2600: warning: exported method Client.VolumesToUpdate should have comment or be unexported (golint)
    • Line 2612: warning: comment on exported method Client.ListVolumeGroups should be of the form "ListVolumeGroups ..." (golint)
    • Line 2642: warning: exported method Client.DeleteVolumeGroup should have comment or be unexported (golint)
    • Line 2665: warning: exported method Client.ListSnapshotsByVolumeId should have comment or be unexported (golint)
    • Line 2680: warning: exported method Client.ListAttachmentsByVolumeId should have comment or be unexported (golint)
    • Line 2684: warning: exported method Client.ListVolumeGroupsWithFilter should have comment or be unexported (golint)
    • Line 2702: warning: exported type VolumeGroupCompareFunc should have comment or be unexported (golint)
    • Line 2706: warning: exported type VolumeGroupSlice should have comment or be unexported (golint)
    • Line 2725: warning: exported method Client.SortVolumeGroups should have comment or be unexported (golint)
    • Line 2737: warning: exported method Client.SelectVolumeGroup should have comment or be unexported (golint)
    • Line 2764: warning: exported method Client.ListHosts should have comment or be unexported (golint)
    • Line 2806: warning: exported method Client.ListHostsByName should have comment or be unexported (golint)
    • Line 2823: warning: exported method Client.CreateHost should have comment or be unexported (golint)
    • Line 2847: warning: exported method Client.UpdateHost should have comment or be unexported (golint)
    • Line 2904: warning: exported method Client.GetHost should have comment or be unexported (golint)
    • Line 2939: warning: exported method Client.DeleteHost should have comment or be unexported (golint)
    • controller/client/auth.go
    • Line 26: warning: comment on exported const OpensdsAuthStrategy should be of the form "OpensdsAuthStrategy ..." (golint)
    • Line 28: warning: exported const OpensdsTenantId should have comment (or a comment on this block) or be unexported (golint)
    • Line 30: warning: comment on exported const OsAuthUrl should be of the form "OsAuthUrl ..." (golint)
    • Line 43: warning: exported type AuthOptions should have comment or be unexported (golint)
    • Line 47: warning: exported function NewKeystoneAuthOptions should have comment or be unexported (golint)
    • Line 51: warning: exported type KeystoneAuthOptions should have comment or be unexported (golint)
    • Line 66: warning: exported method KeystoneAuthOptions.GetTenantId should have comment or be unexported (golint)
    • Line 70: warning: exported function NewNoauthOptions should have comment or be unexported (golint)
    • Line 74: warning: exported type NoAuthOptions should have comment or be unexported (golint)
    • Line 78: warning: exported method NoAuthOptions.GetTenantId should have comment or be unexported (golint)
    • Line 82: warning: exported function LoadKeystoneAuthOptionsFromEnv should have comment or be unexported (golint)
    • Line 120: warning: exported function LoadNoAuthOptionsFromEnv should have comment or be unexported (golint)
    • controller/client/fake.go
    • Line 25: warning: should not use dot imports (golint)
    • Line 31: warning: exported var TestEp should have comment or be unexported (golint)
    • Line 34: warning: exported function NewFakeClient should have comment or be unexported (golint)
    • Line 75: warning: exported function NewFakeDockReceiver should have comment or be unexported (golint)
    • Line 109: warning: exported function NewFakePoolReceiver should have comment or be unexported (golint)
    • Line 143: warning: exported function NewFakeProfileReceiver should have comment or be unexported (golint)
    • Line 213: warning: exported function NewFakeVolumeReceiver should have comment or be unexported (golint)
    • Line 307: warning: exported function NewFakeReplicationReceiver should have comment or be unexported (golint)
    • Line 342: warning: exported function NewFakeVersionReceiver should have comment or be unexported (golint)
    • Line 380: warning: exported function NewFakeFileShareReceiver should have comment or be unexported (golint)
    • Line 448: warning: exported function NewFakeHostReceiver should have comment or be unexported (golint)
    • controller/pkg/controller/policy/executor/executor.go
    • Line 31: warning: comment on exported type AsynchronizedExecutor should be of the form "AsynchronizedExecutor ..." (with optional leading article) (golint)
    • Line 37: warning: comment on exported type AsynchronizedWorkflow should be of the form "AsynchronizedWorkflow ..." (with optional leading article) (golint)
    • Line 40: warning: comment on exported function RegisterAsynchronizedWorkflow should be of the form "RegisterAsynchronizedWorkflow ..." (golint)
    • Line 82: warning: comment on exported function ExecuteAsynchronizedWorkflow should be of the form "ExecuteAsynchronizedWorkflow ..." (golint)
    • Line 93: warning: comment on exported type SynchronizedExecutor should be of the form "SynchronizedExecutor ..." (with optional leading article) (golint)
    • Line 99: warning: comment on exported type SynchronizedWorkflow should be of the form "SynchronizedWorkflow ..." (with optional leading article) (golint)
    • Line 102: warning: comment on exported function RegisterSynchronizedWorkflow should be of the form "RegisterSynchronizedWorkflow ..." (golint)
    • Line 107: warning: comment on exported function ExecuteSynchronizedWorkflow should be of the form "ExecuteSynchronizedWorkflow ..." (golint)
    • controller/pkg/controller/policy/storagetag.go
    • Line 33: warning: exported const POLICY_TYPE_MAPPING_TABLE should have comment (or a comment on this block) or be unexported (golint)
    • Line 48: warning: comment on exported var PolicyTypeMappingTable should be of the form "PolicyTypeMappingTable ..." (golint)
    • Line 51: warning: comment on exported var PolicyLifecircleTable should be of the form "PolicyLifecircleTable ..." (golint)
    • Line 59: warning: comment on exported function IsStorageTagSupported should be of the form "IsStorageTagSupported ..." (golint)
    • Line 69: warning: comment on exported function FindPolicyType should be of the form "FindPolicyType ..." (golint)
    • Line 78: warning: comment on exported type StorageTag should be of the form "StorageTag ..." (with optional leading article) (golint)
    • Line 84: warning: comment on exported function NewStorageTag should be of the form "NewStorageTag ..." (golint)
    • Line 113: warning: comment on exported method StorageTag.GetSyncTag should be of the form "GetSyncTag ..." (golint)
    • Line 118: warning: comment on exported method StorageTag.GetAsyncTag should be of the form "GetAsyncTag ..." (golint)
    • controller/pkg/model/metric.go
    • Line 22: warning: exported type CollectMetricSpec should have comment or be unexported (golint)
    • Line 29: warning: exported type GetMetricSpec should have comment or be unexported (golint)
    • Line 43: warning: exported type MetricSpec should have comment or be unexported (golint)
    • Line 81: warning: exported type Metric should have comment or be unexported (golint)
    • Line 86: warning: exported type NoParam should have comment or be unexported (golint)
    • Line 88: warning: exported type UrlSpec should have comment or be unexported (golint)
    • Line 94: warning: exported type UrlDesc should have comment or be unexported (golint)
    • controller/client/pool.go
    • Line 24: warning: comment on exported function NewPoolMgr should be of the form "NewPoolMgr ..." (golint)
    • Line 33: warning: comment on exported type PoolMgr should be of the form "PoolMgr ..." (with optional leading article) (golint)
    • Line 40: warning: comment on exported method PoolMgr.GetPool should be of the form "GetPool ..." (golint)
    • Line 54: warning: comment on exported method PoolMgr.ListPools should be of the form "ListPools ..." (golint)
    • controller/pkg/model/base.go
    • Line 24: warning: exported type BaseModel should have comment or be unexported (golint)
    • Line 68: warning: exported method DataStorageLoS.IsEmptyStorageAccessCapability should have comment or be unexported (golint)
    • Line 73: warning: exported method DataStorageLoS.IsEmpty should have comment or be unexported (golint)
    • Line 109: warning: exported method IOConnectivityLoS.IsEmpty should have comment or be unexported (golint)
    • Line 180: warning: exported method DataProtectionLoS.IsEmpty should have comment or be unexported (golint)
    • controller/pkg/controller/metrics/metrics_controller.go
    • Line 66: warning: comment on exported type InstantMetricReponseFromPrometheus should be of the form "InstantMetricReponseFromPrometheus ..." (with optional leading article) (golint)
    • Line 71: warning: exported type Metric should have comment or be unexported (golint)
    • Line 77: warning: exported type Result should have comment or be unexported (golint)
    • Line 81: warning: exported type Data should have comment or be unexported (golint)
    • Line 88: warning: comment on exported type RangeMetricReponseFromPrometheus should be of the form "RangeMetricReponseFromPrometheus ..." (with optional leading article) (golint)
    • Line 93: warning: exported type RangeMetric should have comment or be unexported (golint)
    • Line 99: warning: exported type RangeResult should have comment or be unexported (golint)
    • Line 103: warning: exported type RangeData should have comment or be unexported (golint)
    • Line 317: warning: exported function CheckServiceStatus should have comment or be unexported (golint)
    • controller/pkg/controller/metrics/adapters/metrics_sender_to_kafka.go
    • Line 1: warning: package comment should be of the form "Package adapters ..." (golint)
    • Line 22: warning: should not use dot imports (golint)
    • Line 26: warning: exported type KafkaMetricsSender should have comment or be unexported (golint)
    • Line 31: warning: exported method KafkaMetricsSender.GetMetricsSender should have comment or be unexported (golint)
    • Line 38: warning: exported method KafkaMetricsSender.Start should have comment or be unexported (golint)
    • Line 80: warning: exported method KafkaMetricsSender.Stop should have comment or be unexported (golint)
    • Line 86: warning: exported method KafkaMetricsSender.AssignMetricsToSend should have comment or be unexported (golint)
    • controller/pkg/utils/config/config_define.go
    • Line 19: warning: exported type Default should have comment or be unexported (golint)
    • Line 21: warning: exported type OsdsApiServer should have comment or be unexported (golint)
    • Line 50: warning: exported type OsdsLet should have comment or be unexported (golint)
    • Line 64: warning: exported type OsdsDock should have comment or be unexported (golint)
    • Line 75: warning: exported type Database should have comment or be unexported (golint)
    • Line 88: warning: exported type BackendProperties should have comment or be unexported (golint)
    • Line 96: warning: exported type Backends should have comment or be unexported (golint)
    • Line 113: warning: exported type KeystoneAuthToken should have comment or be unexported (golint)
    • Line 131: warning: exported type Config should have comment or be unexported (golint)
    • controller/pkg/utils/utils.go
    • Line 33: warning: exported function Contains should have comment or be unexported (golint)
    • Line 42: warning: comment on exported function RvRepElement should be of the form "RvRepElement ..." (golint)
    • Line 60: warning: exported function Contained should have comment or be unexported (golint)
    • Line 79: warning: exported function MergeGeneralMaps should have comment or be unexported (golint)
    • Line 89: warning: exported function MergeStringMaps should have comment or be unexported (golint)
    • Line 99: warning: exported function PathExists should have comment or be unexported (golint)
    • Line 110: warning: exported function Retry should have comment or be unexported (golint)
    • Line 143: warning: exported function CompareArray should have comment or be unexported (golint)
    • Line 260: warning: comment on exported function Sort should be of the form "Sort ..." (golint)
    • Line 285: warning: comment on exported function Slice should be of the form "Slice ..." (golint)
    • Line 297: warning: exported function RandSeqWithAlnum should have comment or be unexported (golint)
    • Line 302: warning: exported function RandSeq should have comment or be unexported (golint)
    • Line 310: warning: exported function WaitForCondition should have comment or be unexported (golint)
    • Line 331: warning: exported function ContainsIgnoreCase should have comment or be unexported (golint)
    • controller/client/replication.go
    • Line 24: warning: exported type ReplicationBuilder should have comment or be unexported (golint)
    • Line 25: warning: exported type FailoverReplicationBuilder should have comment or be unexported (golint)
    • Line 27: warning: comment on exported function NewReplicationMgr should be of the form "NewReplicationMgr ..." (golint)
    • Line 36: warning: comment on exported type ReplicationMgr should be of the form "ReplicationMgr ..." (with optional leading article) (golint)
    • Line 43: warning: comment on exported method ReplicationMgr.CreateReplication should be of the form "CreateReplication ..." (golint)
    • Line 57: warning: comment on exported method ReplicationMgr.GetReplication should be of the form "GetReplication ..." (golint)
    • Line 71: warning: comment on exported method ReplicationMgr.ListReplications should be of the form "ListReplications ..." (golint)
    • Line 95: warning: comment on exported method ReplicationMgr.DeleteReplication should be of the form "DeleteReplication ..." (golint)
    • Line 103: warning: comment on exported method ReplicationMgr.UpdateReplication should be of the form "UpdateReplication ..." (golint)
    • Line 116: warning: comment on exported method ReplicationMgr.EnableReplication should be of the form "EnableReplication ..." (golint)
    • Line 124: warning: comment on exported method ReplicationMgr.DisableReplication should be of the form "DisableReplication ..." (golint)
    • Line 132: warning: comment on exported method ReplicationMgr.FailoverReplication should be of the form "FailoverReplication ..." (golint)
    • controller/client/receiver.go
    • Line 38: warning: exported function NewHttpError should have comment or be unexported (golint)
    • Line 42: warning: exported type HttpError should have comment or be unexported (golint)
    • Line 47: warning: exported method HttpError.Decode should have comment or be unexported (golint)
    • Line 60: warning: comment on exported type HeaderOption should be of the form "HeaderOption ..." (with optional leading article) (golint)
    • Line 63: warning: comment on exported type Receiver should be of the form "Receiver ..." (with optional leading article) (golint)
    • Line 68: warning: comment on exported function NewReceiver should be of the form "NewReceiver ..." (golint)
    • Line 160: warning: exported function NewKeystoneReceiver should have comment or be unexported (golint)
    • Line 169: warning: exported type KeystoneReceiver should have comment or be unexported (golint)
    • Line 173: warning: exported method KeystoneReceiver.GetToken should have comment or be unexported (golint)
    • Line 210: warning: exported method KeystoneReceiver.Recv should have comment or be unexported (golint)
    • controller/pkg/context/context.go
    • Line 30: warning: exported function NewAdminContext should have comment or be unexported (golint)
    • Line 36: warning: exported function NewInternalTenantContext should have comment or be unexported (golint)
    • Line 44: warning: exported function NewContextFromJson should have comment or be unexported (golint)
    • Line 53: warning: exported function GetContext should have comment or be unexported (golint)
    • Line 61: warning: exported function UpdateContext should have comment or be unexported (golint)
    • Line 83: warning: exported type Context should have comment or be unexported (golint)
    • Line 117: warning: exported method Context.ToPolicyValue should have comment or be unexported (golint)
    • Line 142: warning: exported method Context.ToJson should have comment or be unexported (golint)
    • Line 150: warning: exported function HttpError should have comment or be unexported (golint)
    • controller/pkg/controller/dr/drcontroller.go
    • Line 27: warning: should not use dot imports (golint)
    • Line 33: warning: exported type Controller should have comment or be unexported (golint)
    • Line 41: warning: exported type DrController should have comment or be unexported (golint)
    • Line 69: warning: exported method DrController.LoadOperator should have comment or be unexported (golint)
    • Line 82: warning: exported method DrController.CreateReplication should have comment or be unexported (golint)
    • Line 152: warning: exported method DrController.DeleteReplication should have comment or be unexported (golint)
    • Line 192: warning: exported method DrController.EnableReplication should have comment or be unexported (golint)
    • Line 205: warning: exported method DrController.DisableReplication should have comment or be unexported (golint)
    • Line 218: warning: exported method DrController.FailoverReplication should have comment or be unexported (golint)
    • Line 232: warning: exported type ReplicationOperator should have comment or be unexported (golint)
    • Line 242: warning: exported type PairOperator should have comment or be unexported (golint)
    • Line 249: warning: exported function NewPairOperator should have comment or be unexported (golint)
    • Line 472: warning: exported method PairOperator.Attach should have comment or be unexported (golint)
    • Line 500: warning: exported method PairOperator.Detach should have comment or be unexported (golint)
    • Line 511: warning: exported method PairOperator.Create should have comment or be unexported (golint)
    • Line 535: warning: exported method PairOperator.Delete should have comment or be unexported (golint)
    • Line 556: warning: exported method PairOperator.Enable should have comment or be unexported (golint)
    • Line 576: warning: exported method PairOperator.Disable should have comment or be unexported (golint)
    • Line 596: warning: exported method PairOperator.Failover should have comment or be unexported (golint)
    • controller/test/e2e/syncclient.go
    • Line 31: warning: exported type SyncClient should have comment or be unexported (golint)
    • Line 35: warning: exported function NewSyncClient should have comment or be unexported (golint)
    • Line 207: warning: exported method SyncClient.CreateVolume should have comment or be unexported (golint)
    • Line 218: warning: exported method SyncClient.ExtendVolume should have comment or be unexported (golint)
    • Line 229: warning: exported method SyncClient.DeleteVolume should have comment or be unexported (golint)
    • Line 236: warning: exported method SyncClient.CreateVolumeSnapshot should have comment or be unexported (golint)
    • Line 247: warning: exported method SyncClient.DeleteVolumeSnapshot should have comment or be unexported (golint)
    • Line 254: warning: exported method SyncClient.CreateVolumeAttachment should have comment or be unexported (golint)
    • Line 265: warning: exported method SyncClient.DeleteVolumeAttachment should have comment or be unexported (golint)
    • Line 272: warning: exported method SyncClient.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 283: warning: exported method SyncClient.DeleteVolumeGroup should have comment or be unexported (golint)
    • Line 290: warning: exported method SyncClient.CreateFileShare should have comment or be unexported (golint)
    • Line 301: warning: exported method SyncClient.DeleteFileShare should have comment or be unexported (golint)
    • controller/testutils/driver/replication_sample.go
    • Line 28: warning: should not use dot imports (golint)
    • Line 31: warning: comment on exported type ReplicationDriver should be of the form "ReplicationDriver ..." (with optional leading article) (golint)
    • Line 34: warning: comment on exported method ReplicationDriver.Setup should be of the form "Setup ..." (golint)
    • Line 37: warning: comment on exported method ReplicationDriver.Unset should be of the form "Unset ..." (golint)
    • Line 40: warning: comment on exported method ReplicationDriver.CreateReplication should be of the form "CreateReplication ..." (golint)
    • Line 45: warning: exported method ReplicationDriver.DeleteReplication should have comment or be unexported (golint)
    • Line 49: warning: exported method ReplicationDriver.EnableReplication should have comment or be unexported (golint)
    • Line 53: warning: exported method ReplicationDriver.DisableReplication should have comment or be unexported (golint)
    • Line 57: warning: exported method ReplicationDriver.FailoverReplication should have comment or be unexported (golint)
    • controller/pkg/controller/controller.go
    • Line 42: warning: exported const CREATE_LIFECIRCLE_FLAG should have comment (or a comment on this block) or be unexported (golint)
    • Line 49: warning: exported function NewController should have comment or be unexported (golint)
    • Line 62: warning: exported type Controller should have comment or be unexported (golint)
    • Line 942: warning: comment on exported method Controller.CreateFileShareAcl should be of the form "CreateFileShareAcl ..." (golint)
    • Line 1054: warning: comment on exported method Controller.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)
    • Line 1090: warning: exported method Controller.GetMetrics should have comment or be unexported (golint)
    • Line 1116: warning: exported method Controller.CollectMetrics should have comment or be unexported (golint)
    • Line 1148: warning: exported method Controller.GetUrls should have comment or be unexported (golint)
    • controller/pkg/controller/controller_test.go
    • Line 733: warning: don't use underscores in Go names; var err_desc should be errDesc (golint)
    • Line 758: warning: don't use underscores in Go names; var err_desc2 should be errDesc2 (golint)
    • Line 785: warning: don't use underscores in Go names; var err_descd should be errDescd (golint)
    • Line 801: warning: don't use underscores in Go names; var profile_out should be profileOut (golint)
    • Line 844: warning: don't use underscores in Go names; var err_descd should be errDescd (golint)
    • Line 889: warning: don't use underscores in Go names; var err_desc should be errDesc (golint)
    • Line 907: warning: don't use underscores in Go names; var err_desc2 should be errDesc2 (golint)
    • Line 945: warning: don't use underscores in Go names; var err_desc should be errDesc (golint)
    • Line 963: warning: don't use underscores in Go names; var err_desc2 should be errDesc2 (golint)
    • Line 1006: warning: don't use underscores in Go names; var err_desc should be errDesc (golint)
    • Line 1025: warning: don't use underscores in Go names; var err_desc2 should be errDesc2 (golint)
    • Line 1066: warning: don't use underscores in Go names; var err_desc should be errDesc (golint)
    • Line 1085: warning: don't use underscores in Go names; var err_desc2 should be errDesc2 (golint)
    • controller/pkg/controller/policy/executor/executorintervalsnapshot.go
    • Line 37: warning: exported type IntervalSnapshotExecutor should have comment or be unexported (golint)
    • Line 46: warning: exported method IntervalSnapshotExecutor.Init should have comment or be unexported (golint)
    • Line 61: warning: exported method IntervalSnapshotExecutor.Asynchronized should have comment or be unexported (golint)
    • Line 84: warning: exported function ParseInterval should have comment or be unexported (golint)
    • controller/pkg/utils/constants/constants.go
    • Line 18: warning: comment on exported const TimeFormat should be of the form "TimeFormat ..." (golint)
    • Line 22: warning: exported const DefaultOpensdsEndpoint should have comment (or a comment on this block) or be unexported (golint)
    • Line 24: warning: comment on exported const DefaultTenantId should be of the form "DefaultTenantId ..." (golint)
    • Line 27: warning: comment on exported const AuthTokenHeader should be of the form "AuthTokenHeader ..." (golint)
    • Line 34: warning: comment on exported const APIVersion should be of the form "APIVersion ..." (golint)
    • Line 54: warning: comment on exported const Block should be of the form "Block ..." (golint)
    • Line 58: warning: comment on exported const Read should be of the form "Read ..." (golint)
    • Line 63: warning: comment on exported const DefaultSortDir should be of the form "DefaultSortDir ..." (golint)
    • controller/pkg/model/replication.go
    • Line 24: warning: exported const ReplicationModeSync should have comment (or a comment on this block) or be unexported (golint)
    • Line 86: warning: exported type FailoverReplicationSpec should have comment or be unexported (golint)
    • controller/pkg/db/drivers/etcd/client.go
    • Line 38: warning: comment on exported type Request should be of the form "Request ..." (with optional leading article) (golint)
    • Line 45: warning: comment on exported type Response should be of the form "Response ..." (with optional leading article) (golint)
    • Line 64: warning: comment on exported function Init should be of the form "Init ..." (golint)
    • controller/pkg/model/volume.go
    • Line 86: warning: comment on exported type Identifier should be of the form "Identifier ..." (with optional leading article) (golint)
    • Line 136: warning: exported type VolumeGroupSpec should have comment or be unexported (golint)
    • controller/client/volume.go
    • Line 49: warning: comment on exported function NewVolumeMgr should be of the form "NewVolumeMgr ..." (golint)
    • Line 58: warning: comment on exported type VolumeMgr should be of the form "VolumeMgr ..." (with optional leading article) (golint)
    • Line 65: warning: comment on exported method VolumeMgr.CreateVolume should be of the form "CreateVolume ..." (golint)
    • Line 79: warning: comment on exported method VolumeMgr.GetVolume should be of the form "GetVolume ..." (golint)
    • Line 93: warning: comment on exported method VolumeMgr.ListVolumes should be of the form "ListVolumes ..." (golint)
    • Line 115: warning: comment on exported method VolumeMgr.DeleteVolume should be of the form "DeleteVolume ..." (golint)
    • Line 124: warning: comment on exported method VolumeMgr.UpdateVolume should be of the form "UpdateVolume ..." (golint)
    • Line 152: warning: comment on exported method VolumeMgr.CreateVolumeAttachment should be of the form "CreateVolumeAttachment ..." (golint)
    • Line 166: warning: comment on exported method VolumeMgr.UpdateVolumeAttachment should be of the form "UpdateVolumeAttachment ..." (golint)
    • Line 180: warning: comment on exported method VolumeMgr.GetVolumeAttachment should be of the form "GetVolumeAttachment ..." (golint)
    • Line 194: warning: comment on exported method VolumeMgr.ListVolumeAttachments should be of the form "ListVolumeAttachments ..." (golint)
    • Line 215: warning: comment on exported method VolumeMgr.DeleteVolumeAttachment should be of the form "DeleteVolumeAttachment ..." (golint)
    • Line 224: warning: comment on exported method VolumeMgr.CreateVolumeSnapshot should be of the form "CreateVolumeSnapshot ..." (golint)
    • Line 238: warning: comment on exported method VolumeMgr.GetVolumeSnapshot should be of the form "GetVolumeSnapshot ..." (golint)
    • Line 252: warning: comment on exported method VolumeMgr.ListVolumeSnapshots should be of the form "ListVolumeSnapshots ..." (golint)
    • Line 276: warning: comment on exported method VolumeMgr.DeleteVolumeSnapshot should be of the form "DeleteVolumeSnapshot ..." (golint)
    • Line 285: warning: comment on exported method VolumeMgr.UpdateVolumeSnapshot should be of the form "UpdateVolumeSnapshot ..." (golint)
    • Line 299: warning: comment on exported method VolumeMgr.CreateVolumeGroup should be of the form "CreateVolumeGroup ..." (golint)
    • Line 313: warning: comment on exported method VolumeMgr.GetVolumeGroup should be of the form "GetVolumeGroup ..." (golint)
    • Line 327: warning: comment on exported method VolumeMgr.ListVolumeGroups should be of the form "ListVolumeGroups ..." (golint)
    • Line 350: warning: comment on exported method VolumeMgr.DeleteVolumeGroup should be of the form "DeleteVolumeGroup ..." (golint)
    • Line 359: warning: comment on exported method VolumeMgr.UpdateVolumeGroup should be of the form "UpdateVolumeGroup ..." (golint)
    • controller/pkg/driverconfig/constants.go
    • Line 42: warning: exported const NFSDriverType should have comment (or a comment on this block) or be unexported (golint)
    • Line 66: warning: exported const KMetricIOPS should have comment (or a comment on this block) or be unexported (golint)
    • controller/pkg/utils/pwd/aes.go
    • Line 26: warning: exported type AES should have comment or be unexported (golint)
    • Line 28: warning: exported function NewAES should have comment or be unexported (golint)
    • Line 36: warning: exported method AES.Encrypter should have comment or be unexported (golint)
    • Line 62: warning: exported method AES.Decrypter should have comment or be unexported (golint)
    • controller/testutils/driver/sample.go
    • Line 28: warning: should not use dot imports (golint)
    • Line 31: warning: comment on exported type Driver should be of the form "Driver ..." (with optional leading article) (golint)
    • Line 34: warning: comment on exported method Driver.Setup should be of the form "Setup ..." (golint)
    • Line 37: warning: comment on exported method Driver.Unset should be of the form "Unset ..." (golint)
    • Line 40: warning: comment on exported method Driver.CreateVolume should be of the form "CreateVolume ..." (golint)
    • Line 45: warning: comment on exported method Driver.PullVolume should be of the form "PullVolume ..." (golint)
    • Line 56: warning: comment on exported method Driver.DeleteVolume should be of the form "DeleteVolume ..." (golint)
    • Line 66: warning: comment on exported method Driver.InitializeConnection should be of the form "InitializeConnection ..." (golint)
    • Line 71: warning: comment on exported method Driver.TerminateConnection should be of the form "TerminateConnection ..." (golint)
    • Line 74: warning: comment on exported method Driver.CreateSnapshot should be of the form "CreateSnapshot ..." (golint)
    • Line 79: warning: comment on exported method Driver.PullSnapshot should be of the form "PullSnapshot ..." (golint)
    • Line 90: warning: comment on exported method Driver.DeleteSnapshot should be of the form "DeleteSnapshot ..." (golint)
    • Line 95: warning: comment on exported method Driver.ListPools should be of the form "ListPools ..." (golint)
    • Line 105: warning: exported method Driver.InitializeSnapshotConnection should have comment or be unexported (golint)
    • Line 109: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 113: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 117: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 121: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
    • Line 125: warning: exported method Driver.CreateFileShare should have comment or be unexported (golint)
    • Line 129: warning: exported method Driver.DeleteFileShare should have comment or be unexported (golint)
    • Line 133: warning: exported method Driver.CreateFileShareAcl should have comment or be unexported (golint)
    • Line 137: warning: exported method Driver.DeleteFileShareAcl should have comment or be unexported (golint)
    • Line 141: warning: comment on exported method Driver.CreateFileShareSnapshot should be of the form "CreateFileShareSnapshot ..." (golint)
    • Line 146: warning: comment on exported method Driver.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)
    • controller/pkg/model/version.go
    • Line 29: warning: comment on exported type VersionSpec should be of the form "VersionSpec ..." (with optional leading article) (golint)
    • Line 48: warning: exported function Current should have comment or be unexported (golint)
    • Line 52: warning: exported function Supported should have comment or be unexported (golint)
    • Line 56: warning: exported function Deprecated should have comment or be unexported (golint)
    • Line 60: warning: exported function CurrentVersion should have comment or be unexported (golint)
    • controller/pkg/controller/policy/executor/executordeletesnapshot.go
    • Line 37: warning: exported const RETRY_INTERVAL should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: exported type DeleteSnapshotExecutor should have comment or be unexported (golint)
    • Line 49: warning: exported method DeleteSnapshotExecutor.Init should have comment or be unexported (golint)
    • Line 61: warning: exported method DeleteSnapshotExecutor.Asynchronized should have comment or be unexported (golint)
    • Line 84: warning: exported function CheckSnapshotDeleted should have comment or be unexported (golint)
    • controller/pkg/controller/metrics/adapters/metrics_sender_to_prometheus.go
    • Line 1: warning: package comment should be of the form "Package adapters ..." (golint)
    • Line 23: warning: should not use dot imports (golint)
    • Line 30: warning: exported type PrometheusMetricsSender should have comment or be unexported (golint)
    • Line 35: warning: exported method PrometheusMetricsSender.GetMetricsSender should have comment or be unexported (golint)
    • Line 42: warning: exported method PrometheusMetricsSender.Start should have comment or be unexported (golint)
    • Line 67: warning: exported method PrometheusMetricsSender.Stop should have comment or be unexported (golint)
    • Line 73: warning: exported method PrometheusMetricsSender.AssignMetricsToSend should have comment or be unexported (golint)
    • controller/testutils/db/fake.go
    • Line 22: warning: should not use dot imports (golint)
    • Line 25: warning: comment on exported type FakeDbClient should be of the form "FakeDbClient ..." (with optional leading article) (golint)
    • Line 28: warning: comment on exported function NewFakeDbClient should be of the form "NewFakeDbClient ..." (golint)
    • Line 33: warning: comment on exported method FakeDbClient.CreateFileShareAcl should be of the form "CreateFileShareAcl ..." (golint)
    • Line 38: warning: comment on exported method FakeDbClient.UpdateFileShareAcl should be of the form "UpdateFileShareAcl ..." (golint)
    • Line 43: warning: comment on exported method FakeDbClient.ListFileSharesAcl should be of the form "ListFileSharesAcl ..." (golint)
    • Line 52: warning: exported method FakeDbClient.ListFileShareAclsByShareId should have comment or be unexported (golint)
    • Line 60: warning: comment on exported method FakeDbClient.CreateFileShare should be of the form "CreateFileShare ..." (golint)
    • Line 65: warning: comment on exported method FakeDbClient.GetFileShare should be of the form "GetFileShare ..." (golint)
    • Line 71: warning: comment on exported method FakeDbClient.GetFileShareAcl should be of the form "GetFileShareAcl ..." (golint)
    • Line 77: warning: comment on exported method FakeDbClient.ListFileSharesWithFilter should be of the form "ListFileSharesWithFilter ..." (golint)
    • Line 87: warning: comment on exported method FakeDbClient.ListFileSharesAclWithFilter should be of the form "ListFileSharesAclWithFilter ..." (golint)
    • Line 97: warning: exported method FakeDbClient.ListFileShares should have comment or be unexported (golint)
    • Line 106: warning: comment on exported method FakeDbClient.ListFileSharesByProfileId should be of the form "ListFileSharesByProfileId ..." (golint)
    • Line 111: warning: comment on exported method FakeDbClient.UpdateFileShare should be of the form "UpdateFileShare ..." (golint)
    • Line 116: warning: comment on exported method FakeDbClient.DeleteFileShare should be of the form "DeleteFileShare ..." (golint)
    • Line 121: warning: comment on exported method FakeDbClient.DeleteFileShareAcl should be of the form "DeleteFileShareAcl ..." (golint)
    • Line 126: warning: comment on exported method FakeDbClient.CreateFileShareSnapshot should be of the form "CreateFileShareSnapshot ..." (golint)
    • Line 131: warning: comment on exported method FakeDbClient.GetFileShareSnapshot should be of the form "GetFileShareSnapshot ..." (golint)
    • Line 137: warning: comment on exported method FakeDbClient.ListFileShareSnapshotsWithFilter should be of the form "ListFileShareSnapshotsWithFilter ..." (golint)
    • Line 147: warning: exported method FakeDbClient.ListFileShareSnapshots should have comment or be unexported (golint)
    • Line 156: warning: exported method FakeDbClient.ListSnapshotsByShareId should have comment or be unexported (golint)
    • Line 165: warning: comment on exported method FakeDbClient.UpdateFileShareSnapshot should be of the form "UpdateFileShareSnapshot ..." (golint)
    • Line 170: warning: comment on exported method FakeDbClient.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)
    • Line 175: warning: comment on exported method FakeDbClient.CreateDock should be of the form "CreateDock ..." (golint)
    • Line 180: warning: comment on exported method FakeDbClient.GetDock should be of the form "GetDock ..." (golint)
    • Line 191: warning: comment on exported method FakeDbClient.GetDockByPoolId should be of the form "GetDockByPoolId ..." (golint)
    • Line 205: warning: comment on exported method FakeDbClient.ListDocksWithFilter should be of the form "ListDocksWithFilter ..." (golint)
    • Line 214: warning: exported method FakeDbClient.ListDocks should have comment or be unexported (golint)
    • Line 223: warning: comment on exported method FakeDbClient.ListAvailabilityZones should be of the form "ListAvailabilityZones ..." (golint)
    • Line 233: warning: comment on exported method FakeDbClient.UpdateDock should be of the form "UpdateDock ..." (golint)
    • Line 238: warning: comment on exported method FakeDbClient.DeleteDock should be of the form "DeleteDock ..." (golint)
    • Line 243: warning: exported method FakeDbClient.CreatePool should have comment or be unexported (golint)
    • Line 247: warning: comment on exported method FakeDbClient.GetPool should be of the form "GetPool ..." (golint)
    • Line 258: warning: comment on exported method FakeDbClient.ListPoolsWithFilter should be of the form "ListPoolsWithFilter ..." (golint)
    • Line 267: warning: exported method FakeDbClient.ListPools should have comment or be unexported (golint)
    • Line 276: warning: comment on exported method FakeDbClient.UpdatePool should be of the form "UpdatePool ..." (golint)
    • Line 281: warning: comment on exported method FakeDbClient.DeletePool should be of the form "DeletePool ..." (golint)
    • Line 286: warning: comment on exported method FakeDbClient.CreateProfile should be of the form "CreateProfile ..." (golint)
    • Line 291: warning: comment on exported method FakeDbClient.GetProfile should be of the form "GetProfile ..." (golint)
    • Line 302: warning: comment on exported method FakeDbClient.GetDefaultProfile should be of the form "GetDefaultProfile ..." (golint)
    • Line 313: warning: comment on exported method FakeDbClient.GetDefaultProfileFileShare should be of the form "GetDefaultProfileFileShare ..." (golint)
    • Line 324: warning: comment on exported method FakeDbClient.ListProfilesWithFilter should be of the form "ListProfilesWithFilter ..." (golint)
    • Line 333: warning: exported method FakeDbClient.ListProfiles should have comment or be unexported (golint)
    • Line 342: warning: comment on exported method FakeDbClient.UpdateProfile should be of the form "UpdateProfile ..." (golint)
    • Line 347: warning: comment on exported method FakeDbClient.DeleteProfile should be of the form "DeleteProfile ..." (golint)
    • Line 352: warning: comment on exported method FakeDbClient.AddCustomProperty should be of the form "AddCustomProperty ..." (golint)
    • Line 358: warning: comment on exported method FakeDbClient.ListCustomProperties should be of the form "ListCustomProperties ..." (golint)
    • Line 364: warning: comment on exported method FakeDbClient.RemoveCustomProperty should be of the form "RemoveCustomProperty ..." (golint)
    • Line 369: warning: comment on exported method FakeDbClient.CreateVolume should be of the form "CreateVolume ..." (golint)
    • Line 374: warning: comment on exported method FakeDbClient.GetVolume should be of the form "GetVolume ..." (golint)
    • Line 380: warning: comment on exported method FakeDbClient.ListVolumesWithFilter should be of the form "ListVolumesWithFilter ..." (golint)
    • Line 389: warning: exported method FakeDbClient.ListVolumes should have comment or be unexported (golint)
    • Line 398: warning: comment on exported method FakeDbClient.ListVolumesByProfileId should be of the form "ListVolumesByProfileId ..." (golint)
    • Line 404: warning: comment on exported method FakeDbClient.UpdateVolume should be of the form "UpdateVolume ..." (golint)
    • Line 409: warning: comment on exported method FakeDbClient.DeleteVolume should be of the form "DeleteVolume ..." (golint)
    • Line 419: warning: comment on exported method FakeDbClient.CreateVolumeAttachment should be of the form "CreateVolumeAttachment ..." (golint)
    • Line 424: warning: comment on exported method FakeDbClient.GetVolumeAttachment should be of the form "GetVolumeAttachment ..." (golint)
    • Line 430: warning: comment on exported method FakeDbClient.ListVolumeAttachmentsWithFilter should be of the form "ListVolumeAttachmentsWithFilter ..." (golint)
    • Line 439: warning: exported method FakeDbClient.ListVolumeAttachments should have comment or be unexported (golint)
    • Line 448: warning: comment on exported method FakeDbClient.UpdateVolumeAttachment should be of the form "UpdateVolumeAttachment ..." (golint)
    • Line 453: warning: comment on exported method FakeDbClient.DeleteVolumeAttachment should be of the form "DeleteVolumeAttachment ..." (golint)
    • Line 459: warning: comment on exported method FakeDbClient.CreateVolumeSnapshot should be of the form "CreateVolumeSnapshot ..." (golint)
    • Line 464: warning: comment on exported method FakeDbClient.GetVolumeSnapshot should be of the form "GetVolumeSnapshot ..." (golint)
    • Line 470: warning: comment on exported method FakeDbClient.ListVolumeSnapshotsWithFilter should be of the form "ListVolumeSnapshotsWithFilter ..." (golint)
    • Line 479: warning: exported method FakeDbClient.ListVolumeSnapshots should have comment or be unexported (golint)
    • Line 488: warning: comment on exported method FakeDbClient.UpdateVolumeSnapshot should be of the form "UpdateVolumeSnapshot ..." (golint)
    • Line 493: warning: comment on exported method FakeDbClient.DeleteVolumeSnapshot should be of the form "DeleteVolumeSnapshot ..." (golint)
    • Line 498: warning: exported method FakeDbClient.CreateReplication should have comment or be unexported (golint)
    • Line 502: warning: exported method FakeDbClient.GetReplication should have comment or be unexported (golint)
    • Line 506: warning: exported method FakeDbClient.ListReplication should have comment or be unexported (golint)
    • Line 513: warning: exported method FakeDbClient.GetReplicationByVolumeId should have comment or be unexported (golint)
    • Line 517: warning: exported method FakeDbClient.ListReplicationWithFilter should have comment or be unexported (golint)
    • Line 524: warning: exported method FakeDbClient.DeleteReplication should have comment or be unexported (golint)
    • Line 528: warning: exported method FakeDbClient.UpdateReplication should have comment or be unexported (golint)
    • Line 532: warning: comment on exported method FakeDbClient.CreateVolumeGroup should be of the form "CreateVolumeGroup ..." (golint)
    • Line 537: warning: exported method FakeDbClient.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 541: warning: exported method FakeDbClient.GetVolumeGroup should have comment or be unexported (golint)
    • Line 545: warning: exported method FakeDbClient.UpdateStatus should have comment or be unexported (golint)
    • Line 549: warning: exported method FakeDbClient.ListVolumesByIds should have comment or be unexported (golint)
    • Line 553: warning: exported method FakeDbClient.ListVolumesByGroupId should have comment or be unexported (golint)
    • Line 557: warning: exported method FakeDbClient.ListSnapshotsByVolumeId should have comment or be unexported (golint)
    • Line 561: warning: exported method FakeDbClient.ListAttachmentsByVolumeId should have comment or be unexported (golint)
    • Line 565: warning: exported method FakeDbClient.DeleteVolumeGroup should have comment or be unexported (golint)
    • Line 569: warning: exported method FakeDbClient.ListVolumeGroupsWithFilter should have comment or be unexported (golint)
    • Line 576: warning: exported method FakeDbClient.ListVolumeGroups should have comment or be unexported (golint)
    • Line 583: warning: exported method FakeDbClient.VolumesToUpdate should have comment or be unexported (golint)
    • Line 587: warning: exported method FakeDbClient.ListHosts should have comment or be unexported (golint)
    • Line 587: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 596: warning: exported method FakeDbClient.ListHostsByName should have comment or be unexported (golint)
    • Line 596: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 605: warning: exported method FakeDbClient.CreateHost should have comment or be unexported (golint)
    • Line 605: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 609: warning: exported method FakeDbClient.UpdateHost should have comment or be unexported (golint)
    • Line 609: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 613: warning: exported method FakeDbClient.GetHost should have comment or be unexported (golint)
    • Line 613: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 617: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 621: warning: exported method FakeDbClient.DeleteHost should have comment or be unexported (golint)
    • Line 621: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • controller/pkg/model/error.go
    • Line 28: warning: exported const ErrorBadRequest should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: comment on exported function ErrorBadRequestStatus should be of the form "ErrorBadRequestStatus ..." (golint)
    • Line 48: warning: comment on exported function ErrorForbiddenStatus should be of the form "ErrorForbiddenStatus ..." (golint)
    • Line 53: warning: comment on exported function ErrorUnauthorizedStatus should be of the form "ErrorUnauthorizedStatus ..." (golint)
    • Line 58: warning: comment on exported function ErrorNotFoundStatus should be of the form "ErrorNotFoundStatus ..." (golint)
    • Line 63: warning: comment on exported function ErrorInternalServerStatus should be of the form "ErrorInternalServerStatus ..." (golint)
    • Line 68: warning: comment on exported function ErrorNotImplementedStatus should be of the form "ErrorNotImplementedStatus ..." (golint)
    • Line 87: warning: comment on exported type NotImplementError should be of the form "NotImplementError ..." (with optional leading article) (golint)
    • Line 96: warning: exported type NotFoundError should have comment or be unexported (golint)
    • Line 100: warning: exported function NewNotFoundError should have comment or be unexported (golint)
    • controller/pkg/utils/urls/urls.go
    • Line 24: warning: exported const Etcd should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: don't use underscores in Go names; const etcd_prefix should be etcdPrefix (golint)
    • Line 30: warning: exported function GenerateHostURL should have comment or be unexported (golint)
    • Line 34: warning: exported function GenerateFileShareAclURL should have comment or be unexported (golint)
    • Line 38: warning: exported function GenerateFileShareURL should have comment or be unexported (golint)
    • Line 42: warning: exported function GenerateFileShareSnapshotURL should have comment or be unexported (golint)
    • Line 46: warning: exported function GenerateDockURL should have comment or be unexported (golint)
    • Line 50: warning: exported function GeneratePoolURL should have comment or be unexported (golint)
    • Line 54: warning: exported function GenerateProfileURL should have comment or be unexported (golint)
    • Line 58: warning: exported function GenerateVolumeURL should have comment or be unexported (golint)
    • Line 67: warning: exported function GenerateAttachmentURL should have comment or be unexported (golint)
    • Line 71: warning: exported function GenerateSnapshotURL should have comment or be unexported (golint)
    • Line 75: warning: exported function GenerateReplicationURL should have comment or be unexported (golint)
    • Line 79: warning: exported function GenerateVolumeGroupURL should have comment or be unexported (golint)
    • Line 108: warning: exported function CurrentVersion should have comment or be unexported (golint)
    • controller/pkg/model/pool.go
    • Line 23: warning: exported const ReplicationTypeHost should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: comment on exported type StoragePoolSpec should be of the form "StoragePoolSpec ..." (with optional leading article) (golint)
    • Line 82: warning: exported type StoragePoolExtraSpec should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign97%

IneffAssign detects ineffectual assignments in Go code.


misspell96%

Misspell Finds commonly misspelled English words