Preparing report...

Report for github.com/sodafoundation/dock

A    Great!    Found 119 issues across 142 files

Tweet

gofmt75%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo89%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • dock/pkg/utils/config/config_test.go
    • Line 68: warning: cyclomatic complexity 33 of function TestFunctionAllType() is high (> 15) (gocyclo)
    • Line 263: warning: cyclomatic complexity 31 of function TestOpensdsConfig() is high (> 15) (gocyclo)
    • Line 169: warning: cyclomatic complexity 30 of function TestFunctionDefaultValue() is high (> 15) (gocyclo)
    • dock/contrib/drivers/huawei/oceanstor/oceanstor.go
    • Line 343: warning: cyclomatic complexity 33 of function (*Driver).TerminateConnectionIscsi() is high (> 15) (gocyclo)
    • Line 586: warning: cyclomatic complexity 21 of function (*Driver).connectFCUseNoSwitch() is high (> 15) (gocyclo)
    • Line 768: warning: cyclomatic complexity 17 of function (*Driver).clearHostRelatedResource() is high (> 15) (gocyclo)
    • dock/pkg/db/drivers/etcd/etcd.go
    • Line 744: warning: cyclomatic complexity 20 of function (*Client).UpdateVolumeGroup() is high (> 15) (gocyclo)
    • Line 583: warning: cyclomatic complexity 17 of function (*Client).UpdateVolume() is high (> 15) (gocyclo)

golint28%

Golint is a linter for Go source code.

    • dock/pkg/model/alert.go
    • Line 24: warning: exported type LabelSet should have comment or be unexported (golint)
    • Line 28: warning: exported type AlertSpec should have comment or be unexported (golint)
    • dock/pkg/utils/pwd/pwd.go
    • Line 17: warning: exported type PwdEncrypter should have comment or be unexported (golint)
    • Line 22: warning: exported function NewPwdEncrypter should have comment or be unexported (golint)
    • dock/contrib/backup/multicloud/driver.go
    • Line 30: warning: exported const ConfFile should have comment (or a comment on this block) or be unexported (golint)
    • Line 38: warning: exported function NewMultiCloud should have comment or be unexported (golint)
    • Line 42: warning: exported type AuthOptions should have comment or be unexported (golint)
    • Line 53: warning: exported type MultiCloudConf should have comment or be unexported (golint)
    • Line 59: warning: exported type MultiCloud should have comment or be unexported (golint)
    • Line 81: warning: exported method MultiCloud.SetUp should have comment or be unexported (golint)
    • Line 96: warning: exported method MultiCloud.CleanUp should have comment or be unexported (golint)
    • Line 101: warning: exported method MultiCloud.Backup should have comment or be unexported (golint)
    • Line 153: warning: exported method MultiCloud.Restore should have comment or be unexported (golint)
    • Line 189: warning: exported method MultiCloud.Delete should have comment or be unexported (golint)
    • dock/contrib/drivers/ceph/ceph_metrics_test.go
    • Line 28: warning: don't use underscores in Go names; var pool_Label should be poolLabel (golint)
    • Line 29: warning: don't use underscores in Go names; var osd_label should be osdLabel (golint)
    • Line 30: warning: don't use underscores in Go names; var cluster_label should be clusterLabel (golint)
    • Line 31: warning: don't use underscores in Go names; var health_label should be healthLabel (golint)
    • Line 32: warning: don't use underscores in Go names; var volume_label should be volumeLabel (golint)
    • Line 34: warning: don't use underscores in Go names; var expected_data should be expectedData (golint)
    • Line 117: warning: don't use underscores in Go names; var fake_fsid should be fakeFsid (golint)
    • Line 197: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • dock/contrib/drivers/lvm/cli.go
    • Line 29: warning: exported type Cli should have comment or be unexported (golint)
    • Line 36: warning: exported function NewCli should have comment or be unexported (golint)
    • Line 51: warning: exported method Cli.CreateVolume should have comment or be unexported (golint)
    • Line 64: warning: exported method Cli.Exists should have comment or be unexported (golint)
    • Line 83: warning: comment on exported method Cli.Delete should be of the form "Delete ..." (golint)
    • Line 121: warning: exported method Cli.LvHasSnapshot should have comment or be unexported (golint)
    • Line 138: warning: exported method Cli.LvIsActivate should have comment or be unexported (golint)
    • Line 155: warning: exported method Cli.DeactivateLv should have comment or be unexported (golint)
    • Line 173: warning: exported method Cli.ActivateLv should have comment or be unexported (golint)
    • Line 187: warning: exported method Cli.ExtendVolume should have comment or be unexported (golint)
    • Line 207: warning: exported method Cli.CreateLvSnapshot should have comment or be unexported (golint)
    • Line 222: warning: exported type VolumeGroup should have comment or be unexported (golint)
    • Line 229: warning: exported method Cli.ListVgs should have comment or be unexported (golint)
    • Line 262: warning: exported method Cli.CopyVolume should have comment or be unexported (golint)
    • dock/pkg/utils/config/config.go
    • Line 33: warning: exported const ConfKeyName should have comment (or a comment on this block) or be unexported (golint)
    • Line 255: warning: comment on exported var CONF should be of the form "CONF ..." (golint)
    • Line 258: warning: comment on exported function GetDefaultConfig should be of the form "GetDefaultConfig ..." (golint)
    • Line 265: warning: exported function GetConfigPath should have comment or be unexported (golint)
    • Line 277: warning: exported method Config.Load should have comment or be unexported (golint)
    • Line 284: warning: exported function GetBackendsMap should have comment or be unexported (golint)
    • dock/contrib/drivers/replication_drivers.go
    • Line 52: warning: exported function IsSupportArrayBasedReplication should have comment or be unexported (golint)
    • Line 65: warning: comment on exported function InitReplicationDriver should be of the form "InitReplicationDriver ..." (golint)
    • Line 85: warning: comment on exported function CleanReplicationDriver should be of the form "CleanReplicationDriver ..." (golint)
    • dock/pkg/dock/discovery/discovery.go
    • Line 34: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 41: warning: should not use dot imports (golint)
    • Line 49: warning: exported type Context should have comment or be unexported (golint)
    • Line 55: warning: exported function DiscoveryAndReport should have comment or be unexported (golint)
    • Line 74: warning: exported type DockDiscoverer should have comment or be unexported (golint)
    • Line 317: warning: exported function NewDockRegister should have comment or be unexported (golint)
    • Line 321: warning: exported type DockRegister should have comment or be unexported (golint)
    • Line 325: warning: exported method DockRegister.Register should have comment or be unexported (golint)
    • Line 352: warning: exported method DockRegister.Unregister should have comment or be unexported (golint)
    • dock/pkg/dock/client/client.go
    • Line 49: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 51: warning: exported method DockClient.Connect should have comment or be unexported (golint)
    • dock/contrib/drivers/hpe/nimble/model.go
    • Line 17: warning: exported type AuthRespBody should have comment or be unexported (golint)
    • Line 21: warning: exported type AuthRespData should have comment or be unexported (golint)
    • Line 31: warning: exported type ClinetErrors should have comment or be unexported (golint)
    • Line 35: warning: exported type ArrayInnerErrorBody should have comment or be unexported (golint)
    • Line 39: warning: exported type ArrayInnerErrorResp should have comment or be unexported (golint)
    • Line 45: warning: exported type StoragePoolsRespBody should have comment or be unexported (golint)
    • Line 52: warning: exported type StoragePoolRespData should have comment or be unexported (golint)
    • Line 63: warning: exported type ArrayList should have comment or be unexported (golint)
    • Line 78: warning: exported type AuthOptions should have comment or be unexported (golint)
    • Line 85: warning: exported type NimbleClient should have comment or be unexported (golint)
    • Line 93: warning: exported type VolumeRespBody should have comment or be unexported (golint)
    • Line 97: warning: exported type AllVolumeRespBody should have comment or be unexported (golint)
    • Line 104: warning: exported type VolumeRespData should have comment or be unexported (golint)
    • Line 198: warning: exported type SnapshotRespBody should have comment or be unexported (golint)
    • Line 202: warning: exported type AllSnapshotRespBody should have comment or be unexported (golint)
    • Line 209: warning: exported type SnapshotRespData should have comment or be unexported (golint)
    • Line 243: warning: exported type LoginReqBody should have comment or be unexported (golint)
    • Line 246: warning: exported type LoginReqData should have comment or be unexported (golint)
    • Line 251: warning: exported type CreateVolumeReqBody should have comment or be unexported (golint)
    • Line 255: warning: exported type CreateVolumeReqData should have comment or be unexported (golint)
    • Line 287: warning: exported type ExtendVolumeReqBody should have comment or be unexported (golint)
    • Line 290: warning: exported type ExtendVolumeReqData should have comment or be unexported (golint)
    • Line 319: warning: exported type ExtendVolumeRespBody should have comment or be unexported (golint)
    • Line 323: warning: exported type CreateSnapshotReqBody should have comment or be unexported (golint)
    • Line 327: warning: exported type CreateSnapshotReqData should have comment or be unexported (golint)
    • Line 338: warning: exported type OfflineVolumeReqBody should have comment or be unexported (golint)
    • Line 342: warning: exported type OfflineVolumeReqData should have comment or be unexported (golint)
    • Line 347: warning: exported type AllInitiatorRespBody should have comment or be unexported (golint)
    • Line 354: warning: exported type InitiatorRespBody should have comment or be unexported (golint)
    • Line 358: warning: exported type InitiatorRespData should have comment or be unexported (golint)
    • Line 372: warning: exported type CreateInitiatorReqBody should have comment or be unexported (golint)
    • Line 376: warning: exported type CreateInitiatorReqData should have comment or be unexported (golint)
    • Line 386: warning: exported type AllInitiatorGrpRespBody should have comment or be unexported (golint)
    • Line 393: warning: exported type InitiatorGrpRespBody should have comment or be unexported (golint)
    • Line 397: warning: exported type InitiatorGrpRespData should have comment or be unexported (golint)
    • Line 416: warning: exported type CreateInitiatorGrpReqBody should have comment or be unexported (golint)
    • Line 420: warning: exported type CreateInitiatorGrpReqData should have comment or be unexported (golint)
    • Line 431: warning: exported type CreateAccessControlReqBody should have comment or be unexported (golint)
    • Line 435: warning: exported type CreateAccessControlReqData should have comment or be unexported (golint)
    • Line 446: warning: exported type AllAccessControlRespBody should have comment or be unexported (golint)
    • Line 453: warning: exported type AccessControlRespBody should have comment or be unexported (golint)
    • Line 457: warning: exported type AccessControlRespData should have comment or be unexported (golint)
    • dock/contrib/drivers/netapp/ontap/model.go
    • Line 19: warning: should not use dot imports (golint)
    • Line 22: warning: exported type BackendOptions should have comment or be unexported (golint)
    • Line 33: warning: exported type ONTAPConfig should have comment or be unexported (golint)
    • Line 38: warning: exported type SANDriver should have comment or be unexported (golint)
    • Line 43: warning: exported type Pool should have comment or be unexported (golint)
    • dock/contrib/drivers/ceph/metrics_cli.go
    • Line 1: warning: package comment should be of the form "Package ceph ..." (golint)
    • Line 26: warning: exported type MetricCli should have comment or be unexported (golint)
    • Line 31: warning: exported type Conn should have comment or be unexported (golint)
    • Line 42: warning: exported function NewMetricCli should have comment or be unexported (golint)
    • Line 68: warning: exported type CephMetricStats should have comment or be unexported (golint)
    • Line 72: warning: don't use underscores in Go names; struct field Const_Label should be ConstLabel (golint)
    • Line 74: warning: don't use underscores in Go names; struct field Var_Label should be VarLabel (golint)
    • Line 227: warning: exported method MetricCli.CollectPoolMetrics should have comment or be unexported (golint)
    • Line 229: warning: don't use underscores in Go names; var const_label should be constLabel (golint)
    • Line 247: warning: don't use underscores in Go names; var pool_stats should be poolStats (golint)
    • Line 254: warning: don't use underscores in Go names; var var_label should be varLabel (golint)
    • Line 332: warning: exported method MetricCli.CollectClusterMetrics should have comment or be unexported (golint)
    • Line 335: warning: don't use underscores in Go names; var const_label should be constLabel (golint)
    • Line 351: warning: don't use underscores in Go names; var cluster_stats should be clusterStats (golint)
    • Line 391: warning: exported method MetricCli.CollectPerfMetrics should have comment or be unexported (golint)
    • Line 394: warning: don't use underscores in Go names; var const_label should be constLabel (golint)
    • Line 415: warning: don't use underscores in Go names; var var_label should be varLabel (golint)
    • Line 441: warning: exported method MetricCli.CollectOsddfMetrics should have comment or be unexported (golint)
    • Line 444: warning: don't use underscores in Go names; var const_label should be constLabel (golint)
    • Line 464: warning: don't use underscores in Go names; range var osd_df should be osdDf (golint)
    • Line 465: warning: don't use underscores in Go names; var var_label should be varLabel (golint)
    • Line 488: warning: don't use underscores in Go names; var osd_df_kb should be osdDfKb (golint)
    • Line 489: warning: don't use underscores in Go names; var osd_df_bytes should be osdDfBytes (golint)
    • Line 496: warning: don't use underscores in Go names; var osd_df_kb_used should be osdDfKbUsed (golint)
    • Line 497: warning: don't use underscores in Go names; var osd_df_bytes_used should be osdDfBytesUsed (golint)
    • Line 504: warning: don't use underscores in Go names; var osd_df_kb_avail should be osdDfKbAvail (golint)
    • Line 505: warning: don't use underscores in Go names; var osd_df_bytes_avail should be osdDfBytesAvail (golint)
    • Line 531: warning: don't use underscores in Go names; var total_kb should be totalKb (golint)
    • Line 532: warning: don't use underscores in Go names; var total_bytes should be totalBytes (golint)
    • Line 541: warning: don't use underscores in Go names; var total_used_kb should be totalUsedKb (golint)
    • Line 542: warning: don't use underscores in Go names; var total_used_bytes should be totalUsedBytes (golint)
    • Line 551: warning: don't use underscores in Go names; var total_avail_kb should be totalAvailKb (golint)
    • Line 552: warning: don't use underscores in Go names; var total_avail_bytes should be totalAvailBytes (golint)
    • Line 571: warning: exported method MetricCli.CollectOsddumpMetrics should have comment or be unexported (golint)
    • Line 574: warning: don't use underscores in Go names; var const_label should be constLabel (golint)
    • Line 589: warning: don't use underscores in Go names; var osd_dump should be osdDump (golint)
    • Line 594: warning: don't use underscores in Go names; var var_label should be varLabel (golint)
    • Line 620: warning: exported method MetricCli.CollectHealthMetrics should have comment or be unexported (golint)
    • Line 624: warning: don't use underscores in Go names; var health_cmd should be healthCmd (golint)
    • Line 637: warning: don't use underscores in Go names; var health_stats should be healthStats (golint)
    • Line 764: warning: exported method MetricCli.CollectMonitorsMetrics should have comment or be unexported (golint)
    • Line 767: warning: don't use underscores in Go names; var const_label should be constLabel (golint)
    • Line 785: warning: don't use underscores in Go names; var mon_stats should be monStats (golint)
    • Line 793: warning: don't use underscores in Go names; var var_label should be varLabel (golint)
    • Line 796: warning: don't use underscores in Go names; var bytesTotal_val should be bytesTotalVal (golint)
    • Line 805: warning: don't use underscores in Go names; var bytesUsed_val should be bytesUsedVal (golint)
    • Line 814: warning: don't use underscores in Go names; var bytesAvail_val should be bytesAvailVal (golint)
    • Line 882: warning: don't use underscores in Go names; var var_label should be varLabel (golint)
    • Line 911: warning: receiver name c should be consistent with previous receiver name cli for MetricCli (golint)
    • Line 914: warning: exported method MetricCli.CollectVolumeMetrics should have comment or be unexported (golint)
    • Line 917: warning: don't use underscores in Go names; var const_label should be constLabel (golint)
    • Line 931: warning: don't use underscores in Go names; var command_out should be commandOut (golint)
    • Line 932: warning: don't use underscores in Go names; var command_output should be commandOutput (golint)
    • Line 966: warning: exported method MetricCli.CollectMetrics should have comment or be unexported (golint)
    • Line 974: warning: don't use underscores in Go names; var pool_metric should be poolMetric (golint)
    • Line 979: warning: don't use underscores in Go names; var cluster_metric should be clusterMetric (golint)
    • Line 984: warning: don't use underscores in Go names; var perf_metric should be perfMetric (golint)
    • Line 989: warning: don't use underscores in Go names; var osd_df_metric should be osdDfMetric (golint)
    • Line 994: warning: don't use underscores in Go names; var osd_dump_metric should be osdDumpMetric (golint)
    • Line 999: warning: don't use underscores in Go names; var health_metrics should be healthMetrics (golint)
    • Line 1004: warning: don't use underscores in Go names; var monitor_metrics should be monitorMetrics (golint)
    • Line 1009: warning: don't use underscores in Go names; var volume_metrics should be volumeMetrics (golint)
    • dock/contrib/drivers/hpe/nimble/nimble.go
    • Line 22: warning: should not use dot imports (golint)
    • Line 30: warning: exported const DefaultConfPath should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: exported type Config should have comment or be unexported (golint)
    • Line 39: warning: exported type Driver should have comment or be unexported (golint)
    • Line 44: warning: exported method Driver.Setup should have comment or be unexported (golint)
    • Line 63: warning: exported method Driver.Unset should have comment or be unexported (golint)
    • Line 67: warning: exported method Driver.CreateVolume should have comment or be unexported (golint)
    • Line 97: warning: exported method Driver.DeleteVolume should have comment or be unexported (golint)
    • Line 109: warning: exported method Driver.ExtendVolume should have comment or be unexported (golint)
    • Line 130: warning: exported method Driver.CreateSnapshot should have comment or be unexported (golint)
    • Line 153: warning: exported method Driver.DeleteSnapshot should have comment or be unexported (golint)
    • Line 165: warning: exported method Driver.ListPools should have comment or be unexported (golint)
    • Line 176: warning: should omit 2nd value from range; this loop is equivalent to `for grpName := range ...` (golint)
    • Line 205: warning: exported method Driver.InitializeConnection should have comment or be unexported (golint)
    • Line 302: warning: exported method Driver.TerminateConnection should have comment or be unexported (golint)
    • Line 316: warning: exported method Driver.CopyVolume should have comment or be unexported (golint)
    • Line 320: warning: exported method Driver.PullSnapshot should have comment or be unexported (golint)
    • Line 324: warning: exported method Driver.PullVolume should have comment or be unexported (golint)
    • Line 329: warning: comment on exported method Driver.InitializeSnapshotConnection should be of the form "InitializeSnapshotConnection ..." (golint)
    • Line 334: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 338: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 342: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 346: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
    • dock/contrib/connector/iscsi/iscsi.go
    • Line 21: warning: exported type Iscsi should have comment or be unexported (golint)
    • Line 27: warning: exported method Iscsi.Attach should have comment or be unexported (golint)
    • Line 31: warning: exported method Iscsi.Detach should have comment or be unexported (golint)
    • dock/contrib/drivers/filesharedrivers/oceanstor/model.go
    • Line 18: warning: should not use dot imports (golint)
    • Line 21: warning: exported type Client should have comment or be unexported (golint)
    • Line 31: warning: exported type Driver should have comment or be unexported (golint)
    • Line 36: warning: exported type AuthOptions should have comment or be unexported (golint)
    • Line 44: warning: exported type Config should have comment or be unexported (golint)
    • Line 49: warning: exported type Error should have comment or be unexported (golint)
    • Line 54: warning: exported type DeleteError should have comment or be unexported (golint)
    • Line 58: warning: exported type AuthData should have comment or be unexported (golint)
    • Line 72: warning: exported type Auth should have comment or be unexported (golint)
    • Line 77: warning: exported type StoragePool should have comment or be unexported (golint)
    • Line 85: warning: exported type StoragePoolList should have comment or be unexported (golint)
    • Line 90: warning: exported type FileSystem should have comment or be unexported (golint)
    • Line 95: warning: exported type FileSystemList should have comment or be unexported (golint)
    • Line 100: warning: exported type FileSystemData should have comment or be unexported (golint)
    • Line 110: warning: exported type NFSShare should have comment or be unexported (golint)
    • Line 115: warning: exported type NFSShareData should have comment or be unexported (golint)
    • Line 125: warning: exported type CIFSShare should have comment or be unexported (golint)
    • Line 130: warning: exported type CIFSShareData should have comment or be unexported (golint)
    • Line 146: warning: exported type NFSShareList should have comment or be unexported (golint)
    • Line 151: warning: exported type CIFSShareList should have comment or be unexported (golint)
    • Line 156: warning: comment on exported type FSSnapshotData should be of the form "FSSnapshotData ..." (with optional leading article) (golint)
    • Line 169: warning: exported type FSSnapshot should have comment or be unexported (golint)
    • Line 174: warning: exported type FSSnapshotList should have comment or be unexported (golint)
    • Line 185: warning: exported type LogicalPortData should have comment or be unexported (golint)
    • Line 190: warning: exported type ShareAuthClientData should have comment or be unexported (golint)
    • Line 196: warning: exported type ShareAuthClientList should have comment or be unexported (golint)
    • Line 201: warning: exported type NFSShareClient should have comment or be unexported (golint)
    • Line 205: warning: exported type CIFSShareClient should have comment or be unexported (golint)
    • Line 210: warning: exported type CIFSShareClientData should have comment or be unexported (golint)
    • Line 222: warning: exported type Count should have comment or be unexported (golint)
    • dock/pkg/model/volume.go
    • Line 83: warning: comment on exported type Identifier should be of the form "Identifier ..." (with optional leading article) (golint)
    • Line 130: warning: exported type VolumeGroupSpec should have comment or be unexported (golint)
    • dock/contrib/drivers/drivers.go
    • Line 87: warning: comment on exported function Init should be of the form "Init ..." (golint)
    • Line 125: warning: comment on exported function Clean should be of the form "Clean ..." (golint)
    • Line 156: warning: exported function CleanMetricDriver should have comment or be unexported (golint)
    • Line 170: warning: exported type MetricDriver should have comment or be unexported (golint)
    • Line 179: warning: comment on exported function InitMetricDriver should be of the form "InitMetricDriver ..." (golint)
    • dock/contrib/connector/rbd/rbd.go
    • Line 37: warning: exported type RBD should have comment or be unexported (golint)
    • Line 62: warning: exported method RBD.Attach should have comment or be unexported (golint)
    • Line 90: warning: exported method RBD.Detach should have comment or be unexported (golint)
    • dock/contrib/drivers/filesharedrivers/netapp/ontap_nas.go
    • Line 32: warning: should not use dot imports (golint)
    • Line 38: warning: exported method NASDriver.GetVolumeConfig should have comment or be unexported (golint)
    • Line 51: warning: comment on exported method NASDriver.Setup should be of the form "Setup ..." (golint)
    • Line 121: warning: exported method NASDriver.Unset should have comment or be unexported (golint)
    • Line 127: warning: comment on exported method NASDriver.CreateFileShare should be of the form "CreateFileShare ..." (golint)
    • Line 168: warning: comment on exported method NASDriver.ListPools should be of the form "ListPools ..." (golint)
    • Line 213: warning: comment on exported method NASDriver.DeleteFileShare should be of the form "DeleteFileShare ..." (golint)
    • Line 229: warning: comment on exported method NASDriver.CreateFileShareSnapshot should be of the form "CreateFileShareSnapshot ..." (golint)
    • Line 266: warning: comment on exported method NASDriver.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)
    • Line 289: warning: exported method NASDriver.CreateFileShareAcl should have comment or be unexported (golint)
    • Line 293: warning: exported method NASDriver.DeleteFileShareAcl should have comment or be unexported (golint)
    • dock/pkg/utils/urls/urls.go
    • Line 24: warning: exported const Etcd should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: don't use underscores in Go names; const etcd_prefix should be etcdPrefix (golint)
    • Line 30: warning: exported function GenerateHostURL should have comment or be unexported (golint)
    • Line 34: warning: exported function GenerateFileShareAclURL should have comment or be unexported (golint)
    • Line 38: warning: exported function GenerateFileShareURL should have comment or be unexported (golint)
    • Line 42: warning: exported function GenerateFileShareSnapshotURL should have comment or be unexported (golint)
    • Line 46: warning: exported function GenerateDockURL should have comment or be unexported (golint)
    • Line 50: warning: exported function GeneratePoolURL should have comment or be unexported (golint)
    • Line 54: warning: exported function GenerateProfileURL should have comment or be unexported (golint)
    • Line 58: warning: exported function GenerateVolumeURL should have comment or be unexported (golint)
    • Line 67: warning: exported function GenerateAttachmentURL should have comment or be unexported (golint)
    • Line 71: warning: exported function GenerateSnapshotURL should have comment or be unexported (golint)
    • Line 75: warning: exported function GenerateReplicationURL should have comment or be unexported (golint)
    • Line 79: warning: exported function GenerateVolumeGroupURL should have comment or be unexported (golint)
    • Line 108: warning: exported function CurrentVersion should have comment or be unexported (golint)
    • dock/pkg/db/db.go
    • Line 29: warning: should not use dot imports (golint)
    • Line 95: warning: exported function UpdateVolumeStatus should have comment or be unexported (golint)
    • Line 100: warning: exported function UpdateVolumeGroupStatus should have comment or be unexported (golint)
    • dock/pkg/db/drivers/etcd/etcd.go
    • Line 75: warning: exported function IsAdminContext should have comment or be unexported (golint)
    • Line 79: warning: exported function AuthorizeProjectContext should have comment or be unexported (golint)
    • Line 83: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 90: warning: comment on exported type Client should be of the form "Client ..." (with optional leading article) (golint)
    • Line 95: warning: comment on exported type Parameter should be of the form "Parameter ..." (with optional leading article) (golint)
    • Line 101: warning: comment on exported method Client.IsInArray should be of the form "IsInArray ..." (golint)
    • Line 111: warning: exported method Client.SelectOrNot should have comment or be unexported (golint)
    • Line 120: warning: comment on exported method Client.GetLimit should be of the form "GetLimit ..." (golint)
    • Line 138: warning: comment on exported method Client.GetOffset should be of the form "GetOffset ..." (golint)
    • Line 165: warning: comment on exported method Client.GetSortDir should be of the form "GetSortDir ..." (golint)
    • Line 182: warning: comment on exported method Client.GetSortKey should be of the form "GetSortKey ..." (golint)
    • Line 200: warning: exported method Client.FilterAndSort should have comment or be unexported (golint)
    • Line 210: warning: comment on exported method Client.ParameterFilter should be of the form "ParameterFilter ..." (golint)
    • Line 230: warning: comment on exported method Client.CreateDock should be of the form "CreateDock ..." (golint)
    • Line 258: warning: comment on exported method Client.GetDock should be of the form "GetDock ..." (golint)
    • Line 277: warning: comment on exported method Client.GetDockByPoolId should be of the form "GetDockByPoolId ..." (golint)
    • Line 298: warning: comment on exported method Client.ListDocks should be of the form "ListDocks ..." (golint)
    • Line 324: warning: exported method Client.ListDocksWithFilter should have comment or be unexported (golint)
    • Line 339: warning: comment on exported method Client.UpdateDock should be of the form "UpdateDock ..." (golint)
    • Line 370: warning: comment on exported method Client.DeleteDock should be of the form "DeleteDock ..." (golint)
    • Line 383: warning: comment on exported method Client.CreatePool should be of the form "CreatePool ..." (golint)
    • Line 410: warning: exported method Client.ListPoolsWithFilter should have comment or be unexported (golint)
    • Line 425: warning: comment on exported method Client.GetPool should be of the form "GetPool ..." (golint)
    • Line 444: warning: comment on exported method Client.ListPools should be of the form "ListPools ..." (golint)
    • Line 470: warning: comment on exported method Client.UpdatePool should be of the form "UpdatePool ..." (golint)
    • Line 501: warning: comment on exported method Client.DeletePool should be of the form "DeletePool ..." (golint)
    • Line 514: warning: comment on exported method Client.GetVolume should be of the form "GetVolume ..." (golint)
    • Line 550: warning: comment on exported method Client.ListVolumes should be of the form "ListVolumes ..." (golint)
    • Line 648: warning: comment on exported method Client.DeleteVolume should be of the form "DeleteVolume ..." (golint)
    • Line 706: warning: exported method Client.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 726: warning: exported method Client.GetVolumeGroup should have comment or be unexported (golint)
    • Line 744: warning: exported method Client.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 791: warning: exported method Client.UpdateStatus should have comment or be unexported (golint)
    • Line 818: warning: exported method Client.ListVolumesByGroupId should have comment or be unexported (golint)
    • Line 834: warning: exported method Client.VolumesToUpdate should have comment or be unexported (golint)
    • dock/contrib/drivers/huawei/oceanstor/model.go
    • Line 17: warning: exported type Error should have comment or be unexported (golint)
    • Line 22: warning: exported type GenericResult should have comment or be unexported (golint)
    • Line 27: warning: exported type Auth should have comment or be unexported (golint)
    • Line 40: warning: exported type AuthResp should have comment or be unexported (golint)
    • Line 45: warning: exported type StoragePool should have comment or be unexported (golint)
    • Line 52: warning: exported type StoragePoolsResp should have comment or be unexported (golint)
    • Line 57: warning: exported type Lun should have comment or be unexported (golint)
    • Line 101: warning: exported type LunResp should have comment or be unexported (golint)
    • Line 106: warning: exported type LunsResp should have comment or be unexported (golint)
    • Line 111: warning: exported type Snapshot should have comment or be unexported (golint)
    • Line 144: warning: exported type SnapshotResp should have comment or be unexported (golint)
    • Line 149: warning: exported type SnapshotsResp should have comment or be unexported (golint)
    • Line 154: warning: exported type Initiator should have comment or be unexported (golint)
    • Line 162: warning: exported type InitiatorResp should have comment or be unexported (golint)
    • Line 167: warning: exported type InitiatorsResp should have comment or be unexported (golint)
    • Line 172: warning: exported type Host should have comment or be unexported (golint)
    • Line 180: warning: exported type HostResp should have comment or be unexported (golint)
    • Line 185: warning: exported type HostsResp should have comment or be unexported (golint)
    • Line 190: warning: exported type HostGroup should have comment or be unexported (golint)
    • Line 197: warning: exported type HostGroupResp should have comment or be unexported (golint)
    • Line 202: warning: exported type HostGroupsResp should have comment or be unexported (golint)
    • Line 207: warning: exported type LunGroup should have comment or be unexported (golint)
    • Line 214: warning: exported type LunGroupResp should have comment or be unexported (golint)
    • Line 219: warning: exported type LunGroupsResp should have comment or be unexported (golint)
    • Line 224: warning: exported type MappingView should have comment or be unexported (golint)
    • Line 230: warning: exported type MappingViewResp should have comment or be unexported (golint)
    • Line 235: warning: exported type MappingViewsResp should have comment or be unexported (golint)
    • Line 240: warning: exported type IscsiTgtPort should have comment or be unexported (golint)
    • Line 247: warning: exported type IscsiTgtPortsResp should have comment or be unexported (golint)
    • Line 252: warning: exported type HostAssociateLun should have comment or be unexported (golint)
    • Line 257: warning: exported type HostAssociateLunsResp should have comment or be unexported (golint)
    • Line 262: warning: exported type System should have comment or be unexported (golint)
    • Line 270: warning: exported type SystemResp should have comment or be unexported (golint)
    • Line 275: warning: exported type RemoteDevice should have comment or be unexported (golint)
    • Line 284: warning: exported type RemoteDevicesResp should have comment or be unexported (golint)
    • Line 289: warning: exported type ReplicationPair should have comment or be unexported (golint)
    • Line 322: warning: exported type ReplicationPairResp should have comment or be unexported (golint)
    • Line 327: warning: exported type SimpleStruct should have comment or be unexported (golint)
    • Line 332: warning: exported type SimpleResp should have comment or be unexported (golint)
    • Line 337: warning: exported type FCInitiatorsResp should have comment or be unexported (golint)
    • Line 342: warning: exported type FCInitiator should have comment or be unexported (golint)
    • Line 351: warning: exported type FCTargWWPNResp should have comment or be unexported (golint)
    • Line 356: warning: exported type FCTargWWPN should have comment or be unexported (golint)
    • Line 361: warning: exported type ObjCountResp should have comment or be unexported (golint)
    • Line 366: warning: exported type Count should have comment or be unexported (golint)
    • Line 370: warning: exported type Performance should have comment or be unexported (golint)
    • Line 377: warning: exported type PerformancesResp should have comment or be unexported (golint)
    • dock/contrib/drivers/scutech/cms/scmsutils.go
    • Line 23: warning: exported const CMS_ADM should have comment or be unexported (golint)
    • Line 26: warning: exported const CMS_CREATE should have comment (or a comment on this block) or be unexported (golint)
    • Line 33: warning: exported type CmsAdm should have comment or be unexported (golint)
    • Line 36: warning: exported function NewCmsAdm should have comment or be unexported (golint)
    • Line 40: warning: exported method CmsAdm.CreateTask should have comment or be unexported (golint)
    • Line 64: warning: exported method CmsAdm.DeleteTask should have comment or be unexported (golint)
    • Line 69: warning: exported method CmsAdm.Up should have comment or be unexported (golint)
    • Line 74: warning: exported method CmsAdm.Down should have comment or be unexported (golint)
    • Line 79: warning: exported method CmsAdm.Query should have comment or be unexported (golint)
    • dock/contrib/drivers/huawei/oceanstor/replication.go
    • Line 24: warning: should not use dot imports (golint)
    • Line 31: warning: comment on exported type ReplicationDriver should be of the form "ReplicationDriver ..." (with optional leading article) (golint)
    • Line 37: warning: comment on exported method ReplicationDriver.Setup should be of the form "Setup ..." (golint)
    • Line 55: warning: comment on exported method ReplicationDriver.Unset should be of the form "Unset ..." (golint)
    • Line 58: warning: comment on exported method ReplicationDriver.CreateReplication should be of the form "CreateReplication ..." (golint)
    • Line 87: warning: exported method ReplicationDriver.DeleteReplication should have comment or be unexported (golint)
    • Line 104: warning: exported method ReplicationDriver.EnableReplication should have comment or be unexported (golint)
    • Line 117: warning: exported method ReplicationDriver.DisableReplication should have comment or be unexported (golint)
    • Line 130: warning: exported method ReplicationDriver.FailoverReplication should have comment or be unexported (golint)
    • Line 146: warning: exported function NewReplicaPairMgr should have comment or be unexported (golint)
    • Line 167: warning: exported type ReplicaPairMgr should have comment or be unexported (golint)
    • Line 177: warning: exported method ReplicaPairMgr.TryGetRemoteWwn should have comment or be unexported (golint)
    • Line 182: warning: exported method ReplicaPairMgr.TryGetRemoteDevByWwn should have comment or be unexported (golint)
    • Line 193: warning: exported method ReplicaPairMgr.CheckRemoteAvailable should have comment or be unexported (golint)
    • Line 206: warning: exported method ReplicaPairMgr.GetRemoteDevInfo should have comment or be unexported (golint)
    • Line 218: warning: exported method ReplicaPairMgr.WaitVolumeOnline should have comment or be unexported (golint)
    • Line 243: warning: exported method ReplicaPairMgr.DeletePair should have comment or be unexported (golint)
    • Line 255: warning: exported method ReplicaPairMgr.CreateReplication should have comment or be unexported (golint)
    • Line 289: warning: exported method ReplicaPairMgr.DeleteReplication should have comment or be unexported (golint)
    • Line 305: warning: exported method ReplicaPairMgr.Failback should have comment or be unexported (golint)
    • Line 312: warning: exported method ReplicaPairMgr.Failover should have comment or be unexported (golint)
    • Line 316: warning: exported function NewReplicaCommonDriver should have comment or be unexported (golint)
    • Line 320: warning: exported type ReplicaCommonDriver should have comment or be unexported (golint)
    • Line 325: warning: exported method ReplicaCommonDriver.ProtectSecond should have comment or be unexported (golint)
    • Line 338: warning: exported method ReplicaCommonDriver.UnprotectSecond should have comment or be unexported (golint)
    • Line 351: warning: exported method ReplicaCommonDriver.Sync should have comment or be unexported (golint)
    • Line 375: warning: exported method ReplicaCommonDriver.Split should have comment or be unexported (golint)
    • Line 401: warning: exported method ReplicaCommonDriver.Enable should have comment or be unexported (golint)
    • Line 412: warning: exported method ReplicaCommonDriver.Switch should have comment or be unexported (golint)
    • Line 437: warning: exported method ReplicaCommonDriver.Failover should have comment or be unexported (golint)
    • Line 464: warning: exported method ReplicaCommonDriver.WaitReplicaReady should have comment or be unexported (golint)
    • Line 495: warning: exported method ReplicaCommonDriver.WaitSecondAccess should have comment or be unexported (golint)
    • Line 507: warning: exported method ReplicaCommonDriver.WaitExpectState should have comment or be unexported (golint)
    • Line 524: warning: exported function NewPairOperation should have comment or be unexported (golint)
    • Line 528: warning: exported type PairOperation should have comment or be unexported (golint)
    • Line 544: warning: exported method PairOperation.Create should have comment or be unexported (golint)
    • Line 575: warning: exported method PairOperation.Split should have comment or be unexported (golint)
    • Line 579: warning: exported method PairOperation.Delete should have comment or be unexported (golint)
    • Line 583: warning: exported method PairOperation.ProtectSecond should have comment or be unexported (golint)
    • Line 587: warning: exported method PairOperation.UnprotectSecond should have comment or be unexported (golint)
    • Line 592: warning: exported method PairOperation.Sync should have comment or be unexported (golint)
    • Line 596: warning: exported method PairOperation.Switch should have comment or be unexported (golint)
    • Line 600: warning: exported method PairOperation.GetReplicationInfo should have comment or be unexported (golint)
    • dock/contrib/drivers/scutech/cms/replication.go
    • Line 25: warning: comment on exported type ReplicationDriver should be of the form "ReplicationDriver ..." (with optional leading article) (golint)
    • Line 28: warning: comment on exported method ReplicationDriver.Setup should be of the form "Setup ..." (golint)
    • Line 31: warning: comment on exported method ReplicationDriver.Unset should be of the form "Unset ..." (golint)
    • Line 34: warning: comment on exported method ReplicationDriver.CreateReplication should be of the form "CreateReplication ..." (golint)
    • Line 81: warning: comment on exported method ReplicationDriver.DeleteReplication should be of the form "DeleteReplication ..." (golint)
    • Line 95: warning: comment on exported method ReplicationDriver.EnableReplication should be of the form "EnableReplication ..." (golint)
    • Line 109: warning: comment on exported method ReplicationDriver.DisableReplication should be of the form "DisableReplication ..." (golint)
    • Line 124: warning: comment on exported method ReplicationDriver.FailoverReplication should be of the form "FailoverReplication ..." (golint)
    • dock/contrib/backup/driver.go
    • Line 22: warning: exported type BackupSpec should have comment or be unexported (golint)
    • Line 28: warning: exported type BackupDriver should have comment or be unexported (golint)
    • Line 40: warning: exported function NewBackup should have comment or be unexported (golint)
    • Line 53: warning: exported function RegisterBackupCtor should have comment or be unexported (golint)
    • Line 61: warning: exported function UnregisterBackupCtor should have comment or be unexported (golint)
    • dock/pkg/utils/logs/logs.go
    • Line 30: warning: exported const DefaultLogDir should have comment or be unexported (golint)
    • Line 49: warning: exported type GlogWriter should have comment or be unexported (golint)
    • Line 68: warning: exported function InitLogs should have comment or be unexported (golint)
    • Line 80: warning: exported function FlushLogs should have comment or be unexported (golint)
    • dock/contrib/drivers/filesharedrivers/nfs/nfs.go
    • Line 23: warning: should not use dot imports (golint)
    • Line 35: warning: exported const FileSharePrefix should have comment (or a comment on this block) or be unexported (golint)
    • Line 45: warning: exported const KLvPath should have comment (or a comment on this block) or be unexported (golint)
    • Line 56: warning: exported type NFSConfig should have comment or be unexported (golint)
    • Line 63: warning: exported type Driver should have comment or be unexported (golint)
    • Line 68: warning: exported method Driver.Setup should have comment or be unexported (golint)
    • Line 87: warning: exported method Driver.Unset should have comment or be unexported (golint)
    • Line 89: warning: exported method Driver.CreateFileShareAcl should have comment or be unexported (golint)
    • Line 135: warning: exported method Driver.DeleteFileShareAcl should have comment or be unexported (golint)
    • Line 149: warning: exported method Driver.CreateFileShare should have comment or be unexported (golint)
    • Line 257: warning: comment on exported method Driver.ListPools should be of the form "ListPools ..." (golint)
    • Line 288: warning: comment on exported method Driver.DeleteFileShare should be of the form "DeleteFileShare ..." (golint)
    • Line 319: warning: comment on exported method Driver.CreateFileShareSnapshot should be of the form "CreateFileShareSnapshot ..." (golint)
    • Line 351: warning: comment on exported method Driver.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)
    • dock/contrib/drivers/hpe/nimble/client.go
    • Line 27: warning: should not use dot imports (golint)
    • Line 33: warning: exported const FcInitiatorDefaultGrpName should have comment (or a comment on this block) or be unexported (golint)
    • Line 82: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 174: warning: exported method NimbleClient.ListStoragePools should have comment or be unexported (golint)
    • Line 191: warning: should omit 2nd value from range; this loop is equivalent to `for j := range ...` (golint)
    • Line 247: warning: exported method NimbleClient.GetPoolIdByName should have comment or be unexported (golint)
    • Line 260: warning: exported method NimbleClient.GetTokenByPoolId should have comment or be unexported (golint)
    • Line 273: warning: exported method NimbleClient.CreateVolume should have comment or be unexported (golint)
    • Line 322: warning: exported method NimbleClient.ListVolume should have comment or be unexported (golint)
    • Line 333: warning: exported method NimbleClient.GetStorageVolumeId should have comment or be unexported (golint)
    • Line 350: warning: exported method NimbleClient.GetStorageSnapshotId should have comment or be unexported (golint)
    • Line 383: warning: exported method NimbleClient.DeleteVolume should have comment or be unexported (golint)
    • Line 399: warning: exported method NimbleClient.OfflineVolume should have comment or be unexported (golint)
    • Line 414: warning: exported method NimbleClient.ExtendVolume should have comment or be unexported (golint)
    • Line 441: warning: exported method NimbleClient.CreateSnapshot should have comment or be unexported (golint)
    • Line 470: warning: exported method NimbleClient.DeleteSnapshot should have comment or be unexported (golint)
    • Line 479: warning: exported method NimbleClient.ListInitiator should have comment or be unexported (golint)
    • Line 490: warning: exported method NimbleClient.GetStorageInitiatorGrpId should have comment or be unexported (golint)
    • Line 506: warning: exported method NimbleClient.RegisterInitiatorIntoDefaultGrp should have comment or be unexported (golint)
    • Line 534: warning: exported method NimbleClient.GetDefaultInitiatorGrpId should have comment or be unexported (golint)
    • Line 564: warning: exported method NimbleClient.ListInitiatorGrp should have comment or be unexported (golint)
    • Line 575: warning: exported method NimbleClient.CreateInitiatorDefaultGrp should have comment or be unexported (golint)
    • Line 601: warning: exported method NimbleClient.AttachVolume should have comment or be unexported (golint)
    • Line 622: warning: exported method NimbleClient.DetachVolume should have comment or be unexported (golint)
    • Line 633: warning: exported method NimbleClient.GetTargetVolumeInfo should have comment or be unexported (golint)
    • dock/contrib/drivers/netapp/ontap/ontap_san.go
    • Line 36: warning: should not use dot imports (golint)
    • Line 67: warning: exported method SANDriver.GetVolumeConfig should have comment or be unexported (golint)
    • Line 81: warning: exported method SANDriver.GetSnapshotConfig should have comment or be unexported (golint)
    • Line 92: warning: exported method SANDriver.Setup should have comment or be unexported (golint)
    • Line 160: warning: exported method SANDriver.Unset should have comment or be unexported (golint)
    • Line 166: warning: exported method SANDriver.CreateVolume should have comment or be unexported (golint)
    • Line 255: warning: exported method SANDriver.PullVolume should have comment or be unexported (golint)
    • Line 260: warning: exported method SANDriver.DeleteVolume should have comment or be unexported (golint)
    • Line 295: warning: exported method SANDriver.InitializeConnection should have comment or be unexported (golint)
    • Line 337: warning: exported method SANDriver.TerminateConnection should have comment or be unexported (golint)
    • Line 363: warning: exported method SANDriver.CreateSnapshot should have comment or be unexported (golint)
    • Line 396: warning: exported method SANDriver.PullSnapshot should have comment or be unexported (golint)
    • Line 401: warning: exported method SANDriver.DeleteSnapshot should have comment or be unexported (golint)
    • Line 419: warning: exported method SANDriver.ListPools should have comment or be unexported (golint)
    • Line 462: warning: exported method SANDriver.InitializeSnapshotConnection should have comment or be unexported (golint)
    • Line 467: warning: exported method SANDriver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 473: warning: exported method SANDriver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 477: warning: exported method SANDriver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 481: warning: exported method SANDriver.DeleteVolumeGroup should have comment or be unexported (golint)
    • dock/pkg/context/context.go
    • Line 30: warning: exported function NewAdminContext should have comment or be unexported (golint)
    • Line 36: warning: exported function NewInternalTenantContext should have comment or be unexported (golint)
    • Line 44: warning: exported function NewContextFromJson should have comment or be unexported (golint)
    • Line 53: warning: exported function GetContext should have comment or be unexported (golint)
    • Line 61: warning: exported function UpdateContext should have comment or be unexported (golint)
    • Line 83: warning: exported type Context should have comment or be unexported (golint)
    • Line 117: warning: exported method Context.ToPolicyValue should have comment or be unexported (golint)
    • Line 142: warning: exported method Context.ToJson should have comment or be unexported (golint)
    • Line 150: warning: exported function HttpError should have comment or be unexported (golint)
    • dock/contrib/drivers/filesharedrivers/chubaofs/util.go
    • Line 22: warning: exported type RequestType should have comment or be unexported (golint)
    • Line 116: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 162: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 178: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 197: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 206: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 217: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 228: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 296: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 302: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 320: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 324: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • dock/pkg/utils/exec/exec.go
    • Line 25: warning: exported type Executer should have comment or be unexported (golint)
    • Line 29: warning: exported function Run should have comment or be unexported (golint)
    • Line 48: warning: exported function NewBaseExecuter should have comment or be unexported (golint)
    • Line 52: warning: exported type BaseExecuter should have comment or be unexported (golint)
    • Line 54: warning: exported method BaseExecuter.Run should have comment or be unexported (golint)
    • Line 58: warning: exported function NewRootExecuter should have comment or be unexported (golint)
    • Line 62: warning: exported type RootExeucter should have comment or be unexported (golint)
    • Line 64: warning: exported method RootExeucter.Run should have comment or be unexported (golint)
    • dock/pkg/model/fileshare.go
    • Line 15: warning: package comment should be of the form "Package model ..." (golint)
    • Line 20: warning: exported type FileShareAclSpec should have comment or be unexported (golint)
    • Line 54: warning: exported type FileShareSpec should have comment or be unexported (golint)
    • dock/pkg/model/pool.go
    • Line 23: warning: exported const ReplicationTypeHost should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: comment on exported type StoragePoolSpec should be of the form "StoragePoolSpec ..." (with optional leading article) (golint)
    • Line 82: warning: exported type StoragePoolExtraSpec should have comment or be unexported (golint)
    • dock/pkg/utils/utils.go
    • Line 33: warning: exported function Contains should have comment or be unexported (golint)
    • Line 42: warning: comment on exported function RvRepElement should be of the form "RvRepElement ..." (golint)
    • Line 60: warning: exported function Contained should have comment or be unexported (golint)
    • Line 79: warning: exported function MergeGeneralMaps should have comment or be unexported (golint)
    • Line 89: warning: exported function MergeStringMaps should have comment or be unexported (golint)
    • Line 99: warning: exported function PathExists should have comment or be unexported (golint)
    • Line 110: warning: exported function Retry should have comment or be unexported (golint)
    • Line 143: warning: exported function CompareArray should have comment or be unexported (golint)
    • Line 260: warning: comment on exported function Sort should be of the form "Sort ..." (golint)
    • Line 285: warning: comment on exported function Slice should be of the form "Slice ..." (golint)
    • Line 297: warning: exported function RandSeqWithAlnum should have comment or be unexported (golint)
    • Line 302: warning: exported function RandSeq should have comment or be unexported (golint)
    • Line 310: warning: exported function WaitForCondition should have comment or be unexported (golint)
    • Line 331: warning: exported function ContainsIgnoreCase should have comment or be unexported (golint)
    • dock/pkg/utils/pwd/aes.go
    • Line 26: warning: exported type AES should have comment or be unexported (golint)
    • Line 28: warning: exported function NewAES should have comment or be unexported (golint)
    • Line 36: warning: exported method AES.Encrypter should have comment or be unexported (golint)
    • Line 62: warning: exported method AES.Decrypter should have comment or be unexported (golint)
    • dock/contrib/drivers/ibm/spectrumscale/spectrumscale.go
    • Line 22: warning: should not use dot imports (golint)
    • Line 48: warning: exported const KLvIdFormat should have comment (or a comment on this block) or be unexported (golint)
    • Line 53: warning: exported type IBMConfig should have comment or be unexported (golint)
    • Line 63: warning: exported type Driver should have comment or be unexported (golint)
    • Line 68: warning: exported method Driver.Setup should have comment or be unexported (golint)
    • Line 92: warning: exported method Driver.Unset should have comment or be unexported (golint)
    • Line 94: warning: comment on exported method Driver.CreateVolume should be of the form "CreateVolume ..." (golint)
    • Line 136: warning: comment on exported method Driver.ListPools should be of the form "ListPools ..." (golint)
    • Line 173: warning: comment on exported method Driver.DeleteVolume should be of the form "DeleteVolume ..." (golint)
    • Line 186: warning: comment on exported method Driver.ExtendVolume should be of the form "ExtendVolume ..." (golint)
    • Line 208: warning: comment on exported method Driver.CreateSnapshot should be of the form "CreateSnapshot ..." (golint)
    • Line 233: warning: comment on exported method Driver.DeleteSnapshot should be of the form "DeleteSnapshot ..." (golint)
    • Line 246: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 250: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 254: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
    • Line 258: warning: exported method Driver.PullVolume should have comment or be unexported (golint)
    • Line 262: warning: exported method Driver.PullSnapshot should have comment or be unexported (golint)
    • Line 266: warning: exported method Driver.InitializeSnapshotConnection should have comment or be unexported (golint)
    • Line 270: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 274: warning: exported method Driver.InitializeConnection should have comment or be unexported (golint)
    • Line 278: warning: exported method Driver.TerminateConnection should have comment or be unexported (golint)
    • dock/contrib/drivers/lvm/targets/iscsi.go
    • Line 36: warning: exported type ISCSITarget should have comment or be unexported (golint)
    • Line 43: warning: exported function NewISCSITarget should have comment or be unexported (golint)
    • Line 89: warning: exported function CreateScsiIDFromVolID should have comment or be unexported (golint)
    • Line 91: warning: don't use underscores in Go names; var scsi_id should be scsiID (golint)
    • Line 304: warning: exported function IsExist should have comment or be unexported (golint)
    • dock/pkg/model/error.go
    • Line 28: warning: exported const ErrorBadRequest should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: comment on exported function ErrorBadRequestStatus should be of the form "ErrorBadRequestStatus ..." (golint)
    • Line 48: warning: comment on exported function ErrorForbiddenStatus should be of the form "ErrorForbiddenStatus ..." (golint)
    • Line 53: warning: comment on exported function ErrorUnauthorizedStatus should be of the form "ErrorUnauthorizedStatus ..." (golint)
    • Line 58: warning: comment on exported function ErrorNotFoundStatus should be of the form "ErrorNotFoundStatus ..." (golint)
    • Line 63: warning: comment on exported function ErrorInternalServerStatus should be of the form "ErrorInternalServerStatus ..." (golint)
    • Line 68: warning: comment on exported function ErrorNotImplementedStatus should be of the form "ErrorNotImplementedStatus ..." (golint)
    • Line 87: warning: comment on exported type NotImplementError should be of the form "NotImplementError ..." (with optional leading article) (golint)
    • Line 96: warning: exported type NotFoundError should have comment or be unexported (golint)
    • Line 100: warning: exported function NewNotFoundError should have comment or be unexported (golint)
    • dock/contrib/drivers/ceph/ceph_metrics.go
    • Line 1: warning: package comment should be of the form "Package ceph ..." (golint)
    • Line 136: warning: exported type MetricDriver should have comment or be unexported (golint)
    • Line 146: warning: exported method MetricDriver.CollectMetrics should have comment or be unexported (golint)
    • Line 184: warning: exported method MetricDriver.Setup should have comment or be unexported (golint)
    • Line 193: warning: exported method MetricDriver.Teardown should have comment or be unexported (golint)
    • dock/contrib/drivers/fujitsu/eternus/eternus.go
    • Line 25: warning: should not use dot imports (golint)
    • Line 33: warning: comment on exported type Driver should be of the form "Driver ..." (with optional leading article) (golint)
    • Line 617: warning: exported method Driver.InitializeSnapshotConnection should have comment or be unexported (golint)
    • Line 621: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 625: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 629: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 633: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
    • dock/contrib/drivers/ceph/ceph.go
    • Line 34: warning: should not use dot imports (golint)
    • Line 50: warning: exported const KPoolName should have comment (or a comment on this block) or be unexported (golint)
    • Line 55: warning: exported type CephConfig should have comment or be unexported (golint)
    • Line 60: warning: exported function EncodeName should have comment or be unexported (golint)
    • Line 64: warning: exported function NewSrcMgr should have comment or be unexported (golint)
    • Line 68: warning: exported type SrcMgr should have comment or be unexported (golint)
    • Line 75: warning: exported method SrcMgr.GetConn should have comment or be unexported (golint)
    • Line 97: warning: exported method SrcMgr.GetIoctx should have comment or be unexported (golint)
    • Line 115: warning: comment on exported method SrcMgr.GetOriginImage should be of the form "GetOriginImage ..." (golint)
    • Line 148: warning: exported type Driver should have comment or be unexported (golint)
    • Line 152: warning: exported method Driver.Setup should have comment or be unexported (golint)
    • Line 162: warning: exported method Driver.Unset should have comment or be unexported (golint)
    • Line 247: warning: exported method Driver.CreateVolume should have comment or be unexported (golint)
    • Line 300: warning: exported method Driver.PullVolume should have comment or be unexported (golint)
    • Line 327: warning: exported method Driver.DeleteVolume should have comment or be unexported (golint)
    • Line 331: warning: exported method Driver.InitializeConnection should have comment or be unexported (golint)
    • Line 352: warning: exported method Driver.TerminateConnection should have comment or be unexported (golint)
    • Line 503: warning: exported method Driver.CreateSnapshot should have comment or be unexported (golint)
    • Line 550: warning: exported method Driver.PullSnapshot should have comment or be unexported (golint)
    • Line 587: warning: exported method Driver.DeleteSnapshot should have comment or be unexported (golint)
    • Line 605: warning: exported type TotalStats should have comment or be unexported (golint)
    • Line 611: warning: exported type PoolStats should have comment or be unexported (golint)
    • Line 623: warning: exported type DfInfo should have comment or be unexported (golint)
    • Line 628: warning: exported method Driver.ListPools should have comment or be unexported (golint)
    • Line 670: warning: exported method Driver.InitializeSnapshotConnection should have comment or be unexported (golint)
    • Line 699: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 703: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 707: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 711: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
    • dock/contrib/drivers/huawei/oceanstor/metrics.go
    • Line 22: warning: should not use dot imports (golint)
    • Line 72: warning: exported type Config should have comment or be unexported (golint)
    • Line 78: warning: exported type Configs should have comment or be unexported (golint)
    • Line 81: warning: exported type MetricDriver should have comment or be unexported (golint)
    • Line 113: warning: comment on exported method MetricDriver.GetMetricList should be of the form "GetMetricList ..." (golint)
    • Line 137: warning: exported method MetricDriver.CollectPerformanceMetrics should have comment or be unexported (golint)
    • Line 167: warning: exported method MetricDriver.CollectControllerMetrics should have comment or be unexported (golint)
    • Line 215: warning: exported method MetricDriver.CollectPoolMetrics should have comment or be unexported (golint)
    • Line 272: warning: comment on exported method MetricDriver.CollectMetrics should be of the form "CollectMetrics ..." (golint)
    • Line 292: warning: exported method MetricDriver.Setup should have comment or be unexported (golint)
    • Line 311: warning: exported method MetricDriver.Teardown should have comment or be unexported (golint)
    • dock/contrib/drivers/hpe/nimble/common.go
    • Line 23: warning: exported const UnitGi should have comment or be unexported (golint)
    • Line 24: warning: exported const UnitMebi should have comment or be unexported (golint)
    • Line 26: warning: exported function EncodeName should have comment or be unexported (golint)
    • Line 35: warning: exported function TruncateDescription should have comment or be unexported (golint)
    • Line 42: warning: exported function Byte2Gib should have comment or be unexported (golint)
    • Line 46: warning: exported function Gib2Mebi should have comment or be unexported (golint)
    • dock/pkg/model/base.go
    • Line 24: warning: exported type BaseModel should have comment or be unexported (golint)
    • Line 68: warning: exported method DataStorageLoS.IsEmptyStorageAccessCapability should have comment or be unexported (golint)
    • Line 73: warning: exported method DataStorageLoS.IsEmpty should have comment or be unexported (golint)
    • Line 109: warning: exported method IOConnectivityLoS.IsEmpty should have comment or be unexported (golint)
    • Line 180: warning: exported method DataProtectionLoS.IsEmpty should have comment or be unexported (golint)
    • dock/contrib/drivers/drbd/replication.go
    • Line 28: warning: comment on exported type ReplicationDriver should be of the form "ReplicationDriver ..." (with optional leading article) (golint)
    • Line 31: warning: comment on exported method ReplicationDriver.Setup should be of the form "Setup ..." (golint)
    • Line 34: warning: comment on exported method ReplicationDriver.Unset should be of the form "Unset ..." (golint)
    • Line 37: warning: comment on exported method ReplicationDriver.CreateReplication should be of the form "CreateReplication ..." (golint)
    • Line 198: warning: exported method ReplicationDriver.DeleteReplication should have comment or be unexported (golint)
    • Line 216: warning: exported method ReplicationDriver.EnableReplication should have comment or be unexported (golint)
    • Line 224: warning: exported method ReplicationDriver.DisableReplication should have comment or be unexported (golint)
    • Line 232: warning: exported method ReplicationDriver.FailoverReplication should have comment or be unexported (golint)
    • dock/contrib/drivers/fujitsu/eternus/client.go
    • Line 43: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 65: warning: exported function NewClientForAdmin should have comment or be unexported (golint)
    • Line 87: warning: exported method EternusClient.Destroy should have comment or be unexported (golint)
    • Line 600: warning: comment on exported method EternusClient.DeleteIscsiHostByName should be of the form "DeleteIscsiHostByName ..." (golint)
    • Line 711: warning: comment on exported method EternusClient.DeleteLunGroupByName should be of the form "DeleteLunGroupByName ..." (golint)
    • Line 894: warning: comment on exported method EternusClient.DeleteFcHostByName should be of the form "DeleteFcHostByName ..." (golint)
    • dock/contrib/drivers/filesharedrivers/oceanstor/oceanstor.go
    • Line 25: warning: should not use dot imports (golint)
    • Line 33: warning: exported method Driver.Setup should have comment or be unexported (golint)
    • Line 54: warning: exported method Driver.InitConf should have comment or be unexported (golint)
    • Line 65: warning: exported method Driver.Unset should have comment or be unexported (golint)
    • Line 76: warning: exported method Driver.CreateFileShare should have comment or be unexported (golint)
    • Line 253: warning: exported method Driver.ListPools should have comment or be unexported (golint)
    • Line 314: warning: exported method Driver.DeleteFileShare should have comment or be unexported (golint)
    • Line 349: warning: exported method Driver.DeleteFileSystem should have comment or be unexported (golint)
    • Line 364: warning: exported method Driver.CreateFileShareSnapshot should have comment or be unexported (golint)
    • Line 417: warning: exported method Driver.DeleteFileShareSnapshot should have comment or be unexported (golint)
    • Line 466: warning: exported method Driver.CreateFileShareAclParamCheck should have comment or be unexported (golint)
    • Line 518: warning: comment on exported method Driver.CreateFileShareAcl should be of the form "CreateFileShareAcl ..." (golint)
    • Line 580: warning: exported method Driver.DeleteFileShareAcl should have comment or be unexported (golint)
    • Line 627: warning: exported method Driver.DeleteFileShareAclParamCheck should have comment or be unexported (golint)
    • dock/contrib/drivers/huawei/fusionstorage/model.go
    • Line 18: warning: should not use dot imports (golint)
    • Line 21: warning: exported type Driver should have comment or be unexported (golint)
    • Line 26: warning: exported type AuthOptions should have comment or be unexported (golint)
    • Line 37: warning: exported type Config should have comment or be unexported (golint)
    • Line 42: warning: exported type RequesData should have comment or be unexported (golint)
    • Line 47: warning: exported type ResponseResult should have comment or be unexported (golint)
    • Line 52: warning: exported type Detail should have comment or be unexported (golint)
    • Line 57: warning: exported type Version should have comment or be unexported (golint)
    • Line 61: warning: exported type PoolResp should have comment or be unexported (golint)
    • Line 65: warning: exported type Pool should have comment or be unexported (golint)
    • Line 72: warning: exported type HostList should have comment or be unexported (golint)
    • Line 76: warning: exported type Host should have comment or be unexported (golint)
    • Line 80: warning: exported type PortHostMap should have comment or be unexported (golint)
    • Line 84: warning: exported type HostLunList should have comment or be unexported (golint)
    • Line 88: warning: exported type LunList should have comment or be unexported (golint)
    • Line 93: warning: exported type IscsiPortal should have comment or be unexported (golint)
    • Line 97: warning: exported type NodeResult should have comment or be unexported (golint)
    • Line 101: warning: exported type Portal should have comment or be unexported (golint)
    • Line 106: warning: exported type DeviceVersion should have comment or be unexported (golint)
    • dock/pkg/utils/constants/constants.go
    • Line 18: warning: comment on exported const TimeFormat should be of the form "TimeFormat ..." (golint)
    • Line 22: warning: comment on exported const APIVersion should be of the form "APIVersion ..." (golint)
    • Line 33: warning: comment on exported const Block should be of the form "Block ..." (golint)
    • Line 35: warning: exported const File should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: comment on exported const Read should be of the form "Read ..." (golint)
    • Line 42: warning: comment on exported const DefaultSortDir should be of the form "DefaultSortDir ..." (golint)
    • dock/contrib/drivers/huawei/oceanstor/client.go
    • Line 33: warning: exported type ArrayInnerError should have comment or be unexported (golint)
    • Line 43: warning: exported type NotFoundError should have comment or be unexported (golint)
    • Line 51: warning: exported function IsNotFoundError should have comment or be unexported (golint)
    • Line 59: warning: exported type OceanStorClient should have comment or be unexported (golint)
    • Line 71: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 96: warning: exported method OceanStorClient.Destroy should have comment or be unexported (golint)
    • Line 225: warning: exported method OceanStorClient.CreateVolume should have comment or be unexported (golint)
    • Line 244: warning: exported method OceanStorClient.CreateLunCopy should have comment or be unexported (golint)
    • Line 267: warning: exported method OceanStorClient.GetLunInfo should have comment or be unexported (golint)
    • Line 276: warning: exported method OceanStorClient.StartLunCopy should have comment or be unexported (golint)
    • Line 286: warning: exported method OceanStorClient.DeleteLunCopy should have comment or be unexported (golint)
    • Line 292: warning: exported method OceanStorClient.GetVolume should have comment or be unexported (golint)
    • Line 301: warning: exported method OceanStorClient.GetVolumeByName should have comment or be unexported (golint)
    • Line 309: warning: exported method OceanStorClient.DeleteVolume should have comment or be unexported (golint)
    • Line 329: warning: exported method OceanStorClient.CheckLunExist should have comment or be unexported (golint)
    • Line 342: warning: exported method OceanStorClient.CreateSnapshot should have comment or be unexported (golint)
    • Line 354: warning: exported method OceanStorClient.GetSnapshot should have comment or be unexported (golint)
    • Line 360: warning: exported method OceanStorClient.GetSnapshotByName should have comment or be unexported (golint)
    • Line 366: warning: exported method OceanStorClient.DeleteSnapshot should have comment or be unexported (golint)
    • Line 370: warning: exported method OceanStorClient.ListStoragePools should have comment or be unexported (golint)
    • Line 376: warning: exported method OceanStorClient.ListAllStoragePools should have comment or be unexported (golint)
    • Line 382: warning: exported method OceanStorClient.GetPoolIdByName should have comment or be unexported (golint)
    • Line 395: warning: exported method OceanStorClient.AddHostWithCheck should have comment or be unexported (golint)
    • Line 429: warning: exported method OceanStorClient.GetHostIdByName should have comment or be unexported (golint)
    • Line 447: warning: exported method OceanStorClient.AddInitiatorToHostWithCheck should have comment or be unexported (golint)
    • Line 462: warning: exported method OceanStorClient.IsArrayContainInitiator should have comment or be unexported (golint)
    • Line 479: warning: exported method OceanStorClient.IsHostContainInitiator should have comment or be unexported (golint)
    • Line 498: warning: exported method OceanStorClient.AddInitiatorToArray should have comment or be unexported (golint)
    • Line 521: warning: exported method OceanStorClient.AddInitiatorToHost should have comment or be unexported (golint)
    • Line 545: warning: exported method OceanStorClient.AddHostToHostGroup should have comment or be unexported (golint)
    • Line 567: warning: exported method OceanStorClient.CreateHostGroupWithCheck should have comment or be unexported (golint)
    • Line 582: warning: exported method OceanStorClient.FindHostGroup should have comment or be unexported (golint)
    • Line 605: warning: exported method OceanStorClient.CreateHostGroup should have comment or be unexported (golint)
    • Line 631: warning: exported method OceanStorClient.IsHostGroupContainHost should have comment or be unexported (golint)
    • Line 650: warning: exported method OceanStorClient.AssociateHostToHostGroup should have comment or be unexported (golint)
    • Line 678: warning: exported method OceanStorClient.DoMapping should have comment or be unexported (golint)
    • Line 730: warning: exported method OceanStorClient.FindLunGroup should have comment or be unexported (golint)
    • Line 753: warning: exported method OceanStorClient.FindMappingView should have comment or be unexported (golint)
    • Line 777: warning: exported method OceanStorClient.CreateLunGroup should have comment or be unexported (golint)
    • Line 805: warning: exported method OceanStorClient.CreateMappingView should have comment or be unexported (golint)
    • Line 831: warning: exported method OceanStorClient.IsLunGroupContainLun should have comment or be unexported (golint)
    • Line 850: warning: exported method OceanStorClient.AssociateLunToLunGroup should have comment or be unexported (golint)
    • Line 878: warning: exported method OceanStorClient.IsMappingViewContainHostGroup should have comment or be unexported (golint)
    • Line 896: warning: exported method OceanStorClient.AssocateHostGroupToMappingView should have comment or be unexported (golint)
    • Line 924: warning: exported method OceanStorClient.IsMappingViewContainLunGroup should have comment or be unexported (golint)
    • Line 942: warning: exported method OceanStorClient.AssocateLunGroupToMappingView should have comment or be unexported (golint)
    • Line 970: warning: exported method OceanStorClient.ListTgtPort should have comment or be unexported (golint)
    • Line 985: warning: exported method OceanStorClient.ListHostAssociateLuns should have comment or be unexported (golint)
    • Line 994: warning: exported method OceanStorClient.GetHostLunId should have comment or be unexported (golint)
    • Line 1021: warning: exported method OceanStorClient.RemoveLunFromLunGroup should have comment or be unexported (golint)
    • Line 1031: warning: exported method OceanStorClient.RemoveLunGroupFromMappingView should have comment or be unexported (golint)
    • Line 1050: warning: exported method OceanStorClient.RemoveHostGroupFromMappingView should have comment or be unexported (golint)
    • Line 1069: warning: exported method OceanStorClient.RemoveHostFromHostGroup should have comment or be unexported (golint)
    • Line 1081: warning: exported method OceanStorClient.RemoveIscsiFromHost should have comment or be unexported (golint)
    • Line 1093: warning: exported method OceanStorClient.DeleteHostGroup should have comment or be unexported (golint)
    • Line 1097: warning: exported method OceanStorClient.DeleteLunGroup should have comment or be unexported (golint)
    • Line 1101: warning: exported method OceanStorClient.DeleteHost should have comment or be unexported (golint)
    • Line 1105: warning: exported method OceanStorClient.DeleteMappingView should have comment or be unexported (golint)
    • Line 1109: warning: exported method OceanStorClient.GetArrayInfo should have comment or be unexported (golint)
    • Line 1119: warning: exported method OceanStorClient.ListRemoteDevices should have comment or be unexported (golint)
    • Line 1129: warning: exported method OceanStorClient.CreatePair should have comment or be unexported (golint)
    • Line 1135: warning: exported method OceanStorClient.GetPair should have comment or be unexported (golint)
    • Line 1145: warning: exported method OceanStorClient.SwitchPair should have comment or be unexported (golint)
    • Line 1154: warning: exported method OceanStorClient.SplitPair should have comment or be unexported (golint)
    • Line 1163: warning: exported method OceanStorClient.SyncPair should have comment or be unexported (golint)
    • Line 1172: warning: exported method OceanStorClient.SetPairSecondAccess should have comment or be unexported (golint)
    • Line 1181: warning: exported method OceanStorClient.DeletePair should have comment or be unexported (golint)
    • Line 1185: warning: exported method OceanStorClient.CheckPairExist should have comment or be unexported (golint)
    • Line 1191: warning: exported method OceanStorClient.GetHostOnlineFCInitiators should have comment or be unexported (golint)
    • Line 1211: warning: exported method OceanStorClient.GetOnlineFreeWWNs should have comment or be unexported (golint)
    • Line 1232: warning: exported method OceanStorClient.GetOnlineFCInitiatorOnArray should have comment or be unexported (golint)
    • Line 1251: warning: exported method OceanStorClient.GetHostFCInitiators should have comment or be unexported (golint)
    • Line 1270: warning: exported method OceanStorClient.GetHostIscsiInitiators should have comment or be unexported (golint)
    • Line 1291: warning: exported method OceanStorClient.IsHostAssociatedToHostgroup should have comment or be unexported (golint)
    • Line 1306: warning: exported method OceanStorClient.RemoveHost should have comment or be unexported (golint)
    • Line 1310: warning: exported method OceanStorClient.AddFCPortTohost should have comment or be unexported (golint)
    • Line 1327: warning: exported method OceanStorClient.GetIniTargMap should have comment or be unexported (golint)
    • Line 1498: warning: exported method OceanStorClient.ListControllers should have comment or be unexported (golint)
    • Line 1504: warning: exported method OceanStorClient.GetPerformance should have comment or be unexported (golint)
    • dock/testutils/driver/sample.go
    • Line 28: warning: should not use dot imports (golint)
    • Line 31: warning: comment on exported type Driver should be of the form "Driver ..." (with optional leading article) (golint)
    • Line 34: warning: comment on exported method Driver.Setup should be of the form "Setup ..." (golint)
    • Line 37: warning: comment on exported method Driver.Unset should be of the form "Unset ..." (golint)
    • Line 40: warning: comment on exported method Driver.CreateVolume should be of the form "CreateVolume ..." (golint)
    • Line 45: warning: comment on exported method Driver.PullVolume should be of the form "PullVolume ..." (golint)
    • Line 56: warning: comment on exported method Driver.DeleteVolume should be of the form "DeleteVolume ..." (golint)
    • Line 66: warning: comment on exported method Driver.InitializeConnection should be of the form "InitializeConnection ..." (golint)
    • Line 71: warning: comment on exported method Driver.TerminateConnection should be of the form "TerminateConnection ..." (golint)
    • Line 74: warning: comment on exported method Driver.CreateSnapshot should be of the form "CreateSnapshot ..." (golint)
    • Line 79: warning: comment on exported method Driver.PullSnapshot should be of the form "PullSnapshot ..." (golint)
    • Line 90: warning: comment on exported method Driver.DeleteSnapshot should be of the form "DeleteSnapshot ..." (golint)
    • Line 95: warning: comment on exported method Driver.ListPools should be of the form "ListPools ..." (golint)
    • Line 105: warning: exported method Driver.InitializeSnapshotConnection should have comment or be unexported (golint)
    • Line 109: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 113: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 117: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 121: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
    • Line 125: warning: exported method Driver.CreateFileShare should have comment or be unexported (golint)
    • Line 129: warning: exported method Driver.DeleteFileShare should have comment or be unexported (golint)
    • Line 133: warning: exported method Driver.CreateFileShareAcl should have comment or be unexported (golint)
    • Line 137: warning: exported method Driver.DeleteFileShareAcl should have comment or be unexported (golint)
    • Line 141: warning: comment on exported method Driver.CreateFileShareSnapshot should be of the form "CreateFileShareSnapshot ..." (golint)
    • Line 146: warning: comment on exported method Driver.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)
    • dock/contrib/drivers/lvm/targets/nvmeof.go
    • Line 31: warning: exported const NvmetDir should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: exported type NvmeofTarget should have comment or be unexported (golint)
    • Line 43: warning: exported function NewNvmeofTarget should have comment or be unexported (golint)
    • Line 50: warning: exported type NvmeoftgtTarget should have comment or be unexported (golint)
    • Line 80: warning: exported method NvmeoftgtTarget.AddNvmeofSubsystem should have comment or be unexported (golint)
    • Line 153: warning: exported method NvmeoftgtTarget.GetNvmeofSubsystem should have comment or be unexported (golint)
    • Line 168: warning: exported method NvmeoftgtTarget.CreateNvmeofTarget should have comment or be unexported (golint)
    • Line 273: warning: exported method NvmeoftgtTarget.GetNvmeofTarget should have comment or be unexported (golint)
    • Line 290: warning: exported method NvmeoftgtTarget.RemoveNvmeofSubsystem should have comment or be unexported (golint)
    • Line 331: warning: exported method NvmeoftgtTarget.RemoveNvmeofPort should have comment or be unexported (golint)
    • Line 353: warning: exported method NvmeoftgtTarget.RemoveNvmeofTarget should have comment or be unexported (golint)
    • Line 399: warning: exported method NvmeoftgtTarget.WriteWithIo should have comment or be unexported (golint)
    • Line 412: warning: exported method NvmeoftgtTarget.Getnamespaceid should have comment or be unexported (golint)
    • dock/contrib/drivers/lvm/lvm.go
    • Line 29: warning: should not use dot imports (golint)
    • Line 30: warning: should not use dot imports (golint)
    • Line 52: warning: exported const KLvPath should have comment (or a comment on this block) or be unexported (golint)
    • Line 57: warning: exported type LVMConfig should have comment or be unexported (golint)
    • Line 64: warning: exported type Driver should have comment or be unexported (golint)
    • Line 69: warning: exported method Driver.Setup should have comment or be unexported (golint)
    • Line 88: warning: exported method Driver.Unset should have comment or be unexported (golint)
    • Line 123: warning: exported method Driver.CreateVolume should have comment or be unexported (golint)
    • Line 183: warning: exported method Driver.PullVolume should have comment or be unexported (golint)
    • Line 188: warning: exported method Driver.DeleteVolume should have comment or be unexported (golint)
    • Line 237: warning: exported method Driver.InitializeConnection should have comment or be unexported (golint)
    • Line 278: warning: exported method Driver.TerminateConnection should have comment or be unexported (golint)
    • Line 289: warning: exported method Driver.AttachSnapshot should have comment or be unexported (golint)
    • Line 327: warning: exported method Driver.DetachSnapshot should have comment or be unexported (golint)
    • Line 402: warning: exported method Driver.CreateSnapshot should have comment or be unexported (golint)
    • Line 457: warning: exported method Driver.PullSnapshot should have comment or be unexported (golint)
    • Line 462: warning: exported method Driver.DeleteSnapshot should have comment or be unexported (golint)
    • Line 492: warning: exported method Driver.ListPools should have comment or be unexported (golint)
    • Line 525: warning: exported method Driver.InitializeSnapshotConnection should have comment or be unexported (golint)
    • Line 565: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 582: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 586: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 590: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
    • dock/contrib/drivers/huawei/fusionstorage/fsclient.go
    • Line 36: warning: exported var CliErrorMap should have comment or be unexported (golint)
    • Line 69: warning: exported function NewCliError should have comment or be unexported (golint)
    • Line 76: warning: exported type CliError should have comment or be unexported (golint)
    • Line 85: warning: exported function NewCliErrorBase should have comment or be unexported (golint)
    • Line 89: warning: exported type FsClient should have comment or be unexported (golint)
    • Line 524: warning: exported function StartServer should have comment or be unexported (golint)
    • Line 533: warning: exported method FsClient.RunCmd should have comment or be unexported (golint)
    • dock/contrib/drivers/huawei/oceanstor/common.go
    • Line 11: warning: should not use dot imports (golint)
    • Line 14: warning: exported type AuthOptions should have comment or be unexported (golint)
    • Line 24: warning: exported type Replication should have comment or be unexported (golint)
    • Line 28: warning: exported type OceanStorConfig should have comment or be unexported (golint)
    • Line 35: warning: exported const UnitGi should have comment or be unexported (golint)
    • Line 37: warning: exported function EncodeName should have comment or be unexported (golint)
    • Line 46: warning: exported function EncodeHostName should have comment or be unexported (golint)
    • Line 57: warning: exported function TruncateDescription should have comment or be unexported (golint)
    • Line 64: warning: exported function Sector2Gb should have comment or be unexported (golint)
    • Line 73: warning: exported function Gb2Sector should have comment or be unexported (golint)
    • dock/contrib/connector/nvmeof/nvmeof.go
    • Line 21: warning: exported type Nvmeof should have comment or be unexported (golint)
    • Line 28: warning: exported method Nvmeof.Attach should have comment or be unexported (golint)
    • Line 32: warning: exported method Nvmeof.Detach should have comment or be unexported (golint)
    • dock/contrib/drivers/huawei/oceanstor/constants.go
    • Line 87: warning: exported var LunCopySpeedTypes should have comment or be unexported (golint)
    • Line 90: warning: exported const LunReadyWaitInterval should have comment (or a comment on this block) or be unexported (golint)
    • Line 154: warning: exported const DefaultReplicaWaitInterval should have comment (or a comment on this block) or be unexported (golint)
    • dock/testutils/driver/replication_sample.go
    • Line 28: warning: should not use dot imports (golint)
    • Line 31: warning: comment on exported type ReplicationDriver should be of the form "ReplicationDriver ..." (with optional leading article) (golint)
    • Line 34: warning: comment on exported method ReplicationDriver.Setup should be of the form "Setup ..." (golint)
    • Line 37: warning: comment on exported method ReplicationDriver.Unset should be of the form "Unset ..." (golint)
    • Line 40: warning: comment on exported method ReplicationDriver.CreateReplication should be of the form "CreateReplication ..." (golint)
    • Line 45: warning: exported method ReplicationDriver.DeleteReplication should have comment or be unexported (golint)
    • Line 49: warning: exported method ReplicationDriver.EnableReplication should have comment or be unexported (golint)
    • Line 53: warning: exported method ReplicationDriver.DisableReplication should have comment or be unexported (golint)
    • Line 57: warning: exported method ReplicationDriver.FailoverReplication should have comment or be unexported (golint)
    • dock/contrib/drivers/filesharedrivers/nfs/cli.go
    • Line 28: warning: exported type Cli should have comment or be unexported (golint)
    • Line 35: warning: exported function NewCli should have comment or be unexported (golint)
    • Line 50: warning: exported method Cli.GetExportLocation should have comment or be unexported (golint)
    • Line 50: warning: don't use underscores in Go names; method parameter share_name should be shareName (golint)
    • Line 62: warning: exported method Cli.CreateAccess should have comment or be unexported (golint)
    • Line 78: warning: exported method Cli.DeleteAccess should have comment or be unexported (golint)
    • Line 93: warning: exported method Cli.UnMount should have comment or be unexported (golint)
    • Line 108: warning: exported method Cli.Mount should have comment or be unexported (golint)
    • Line 119: warning: exported method Cli.CreateDirectory should have comment or be unexported (golint)
    • Line 129: warning: exported method Cli.DeleteDirectory should have comment or be unexported (golint)
    • Line 139: warning: exported method Cli.SetPermission should have comment or be unexported (golint)
    • Line 150: warning: exported method Cli.CreateFileShare should have comment or be unexported (golint)
    • Line 163: warning: exported method Cli.CreateFileShareFromSnapshot should have comment or be unexported (golint)
    • Line 178: warning: exported method Cli.CreateVolume should have comment or be unexported (golint)
    • Line 196: warning: exported method Cli.Exists should have comment or be unexported (golint)
    • Line 215: warning: exported method Cli.LvIsActivate should have comment or be unexported (golint)
    • Line 232: warning: comment on exported method Cli.Delete should be of the form "Delete ..." (golint)
    • Line 270: warning: exported type VolumeGroup should have comment or be unexported (golint)
    • Line 277: warning: exported method Cli.ListVgs should have comment or be unexported (golint)
    • Line 310: warning: exported method Cli.CreateLvSnapshot should have comment or be unexported (golint)
    • Line 326: warning: comment on exported method Cli.DeleteFileShareSnapshots should be of the form "DeleteFileShareSnapshots ..." (golint)
    • dock/contrib/drivers/lvm/lvm_metrics.go
    • Line 61: warning: exported type Config should have comment or be unexported (golint)
    • Line 67: warning: exported type Configs should have comment or be unexported (golint)
    • Line 70: warning: exported type MetricDriver should have comment or be unexported (golint)
    • Line 106: warning: comment on exported method MetricDriver.GetMetricList should be of the form "GetMetricList ..." (golint)
    • Line 133: warning: comment on exported method MetricDriver.CollectMetrics should be of the form "CollectMetrics ..." (golint)
    • Line 229: warning: exported method MetricDriver.Setup should have comment or be unexported (golint)
    • Line 239: warning: exported method MetricDriver.Teardown should have comment or be unexported (golint)
    • dock/contrib/drivers/lvm/metrics_cli.go
    • Line 32: warning: exported type MetricCli should have comment or be unexported (golint)
    • Line 39: warning: exported function NewMetricCli should have comment or be unexported (golint)
    • Line 98: warning: receiver name cli should be consistent with previous receiver name c for MetricCli (golint)
    • Line 146: warning: comment on exported method MetricCli.DiscoverVolumes should be of the form "DiscoverVolumes ..." (golint)
    • Line 171: warning: comment on exported method MetricCli.DiscoverDisks should be of the form "DiscoverDisks ..." (golint)
    • dock/contrib/drivers/scutech/cms/scmstask.go
    • Line 21: warning: exported type CmsVolume should have comment or be unexported (golint)
    • Line 26: warning: exported type CmsTask should have comment or be unexported (golint)
    • Line 33: warning: exported function NewCmsTask should have comment or be unexported (golint)
    • Line 48: warning: exported method CmsTask.AddVolume should have comment or be unexported (golint)
    • dock/contrib/connector/nfs/nfs.go
    • Line 21: warning: exported type NFS should have comment or be unexported (golint)
    • Line 27: warning: exported method NFS.Attach should have comment or be unexported (golint)
    • Line 31: warning: exported method NFS.Detach should have comment or be unexported (golint)
    • dock/pkg/model/dock.go
    • Line 23: warning: exported const DockTypeProvioner should have comment (or a comment on this block) or be unexported (golint)
    • dock/testutils/db/fake.go
    • Line 22: warning: should not use dot imports (golint)
    • Line 25: warning: comment on exported type FakeDbClient should be of the form "FakeDbClient ..." (with optional leading article) (golint)
    • Line 28: warning: comment on exported function NewFakeDbClient should be of the form "NewFakeDbClient ..." (golint)
    • Line 33: warning: comment on exported method FakeDbClient.CreateFileShareAcl should be of the form "CreateFileShareAcl ..." (golint)
    • Line 38: warning: comment on exported method FakeDbClient.UpdateFileShareAcl should be of the form "UpdateFileShareAcl ..." (golint)
    • Line 43: warning: comment on exported method FakeDbClient.ListFileSharesAcl should be of the form "ListFileSharesAcl ..." (golint)
    • Line 52: warning: exported method FakeDbClient.ListFileShareAclsByShareId should have comment or be unexported (golint)
    • Line 60: warning: comment on exported method FakeDbClient.CreateFileShare should be of the form "CreateFileShare ..." (golint)
    • Line 65: warning: comment on exported method FakeDbClient.GetFileShare should be of the form "GetFileShare ..." (golint)
    • Line 71: warning: comment on exported method FakeDbClient.GetFileShareAcl should be of the form "GetFileShareAcl ..." (golint)
    • Line 77: warning: comment on exported method FakeDbClient.ListFileSharesWithFilter should be of the form "ListFileSharesWithFilter ..." (golint)
    • Line 87: warning: comment on exported method FakeDbClient.ListFileSharesAclWithFilter should be of the form "ListFileSharesAclWithFilter ..." (golint)
    • Line 97: warning: exported method FakeDbClient.ListFileShares should have comment or be unexported (golint)
    • Line 106: warning: comment on exported method FakeDbClient.UpdateFileShare should be of the form "UpdateFileShare ..." (golint)
    • Line 111: warning: comment on exported method FakeDbClient.DeleteFileShare should be of the form "DeleteFileShare ..." (golint)
    • Line 116: warning: comment on exported method FakeDbClient.DeleteFileShareAcl should be of the form "DeleteFileShareAcl ..." (golint)
    • Line 121: warning: comment on exported method FakeDbClient.CreateFileShareSnapshot should be of the form "CreateFileShareSnapshot ..." (golint)
    • Line 126: warning: comment on exported method FakeDbClient.GetFileShareSnapshot should be of the form "GetFileShareSnapshot ..." (golint)
    • Line 132: warning: comment on exported method FakeDbClient.ListFileShareSnapshotsWithFilter should be of the form "ListFileShareSnapshotsWithFilter ..." (golint)
    • Line 142: warning: exported method FakeDbClient.ListFileShareSnapshots should have comment or be unexported (golint)
    • Line 151: warning: exported method FakeDbClient.ListSnapshotsByShareId should have comment or be unexported (golint)
    • Line 160: warning: comment on exported method FakeDbClient.UpdateFileShareSnapshot should be of the form "UpdateFileShareSnapshot ..." (golint)
    • Line 165: warning: comment on exported method FakeDbClient.DeleteFileShareSnapshot should be of the form "DeleteFileShareSnapshot ..." (golint)
    • Line 170: warning: comment on exported method FakeDbClient.CreateDock should be of the form "CreateDock ..." (golint)
    • Line 175: warning: comment on exported method FakeDbClient.GetDock should be of the form "GetDock ..." (golint)
    • Line 186: warning: comment on exported method FakeDbClient.GetDockByPoolId should be of the form "GetDockByPoolId ..." (golint)
    • Line 200: warning: comment on exported method FakeDbClient.ListDocksWithFilter should be of the form "ListDocksWithFilter ..." (golint)
    • Line 209: warning: exported method FakeDbClient.ListDocks should have comment or be unexported (golint)
    • Line 218: warning: comment on exported method FakeDbClient.ListAvailabilityZones should be of the form "ListAvailabilityZones ..." (golint)
    • Line 228: warning: comment on exported method FakeDbClient.UpdateDock should be of the form "UpdateDock ..." (golint)
    • Line 233: warning: comment on exported method FakeDbClient.DeleteDock should be of the form "DeleteDock ..." (golint)
    • Line 238: warning: exported method FakeDbClient.CreatePool should have comment or be unexported (golint)
    • Line 242: warning: comment on exported method FakeDbClient.GetPool should be of the form "GetPool ..." (golint)
    • Line 253: warning: comment on exported method FakeDbClient.ListPoolsWithFilter should be of the form "ListPoolsWithFilter ..." (golint)
    • Line 262: warning: exported method FakeDbClient.ListPools should have comment or be unexported (golint)
    • Line 271: warning: comment on exported method FakeDbClient.UpdatePool should be of the form "UpdatePool ..." (golint)
    • Line 276: warning: comment on exported method FakeDbClient.DeletePool should be of the form "DeletePool ..." (golint)
    • Line 281: warning: comment on exported method FakeDbClient.CreateVolume should be of the form "CreateVolume ..." (golint)
    • Line 286: warning: comment on exported method FakeDbClient.GetVolume should be of the form "GetVolume ..." (golint)
    • Line 292: warning: comment on exported method FakeDbClient.ListVolumesWithFilter should be of the form "ListVolumesWithFilter ..." (golint)
    • Line 301: warning: exported method FakeDbClient.ListVolumes should have comment or be unexported (golint)
    • Line 310: warning: comment on exported method FakeDbClient.UpdateVolume should be of the form "UpdateVolume ..." (golint)
    • Line 315: warning: comment on exported method FakeDbClient.DeleteVolume should be of the form "DeleteVolume ..." (golint)
    • Line 325: warning: comment on exported method FakeDbClient.CreateVolumeAttachment should be of the form "CreateVolumeAttachment ..." (golint)
    • Line 330: warning: comment on exported method FakeDbClient.GetVolumeAttachment should be of the form "GetVolumeAttachment ..." (golint)
    • Line 336: warning: comment on exported method FakeDbClient.ListVolumeAttachmentsWithFilter should be of the form "ListVolumeAttachmentsWithFilter ..." (golint)
    • Line 345: warning: exported method FakeDbClient.ListVolumeAttachments should have comment or be unexported (golint)
    • Line 354: warning: comment on exported method FakeDbClient.UpdateVolumeAttachment should be of the form "UpdateVolumeAttachment ..." (golint)
    • Line 359: warning: comment on exported method FakeDbClient.DeleteVolumeAttachment should be of the form "DeleteVolumeAttachment ..." (golint)
    • Line 365: warning: comment on exported method FakeDbClient.CreateVolumeSnapshot should be of the form "CreateVolumeSnapshot ..." (golint)
    • Line 370: warning: comment on exported method FakeDbClient.GetVolumeSnapshot should be of the form "GetVolumeSnapshot ..." (golint)
    • Line 376: warning: comment on exported method FakeDbClient.ListVolumeSnapshotsWithFilter should be of the form "ListVolumeSnapshotsWithFilter ..." (golint)
    • Line 385: warning: exported method FakeDbClient.ListVolumeSnapshots should have comment or be unexported (golint)
    • Line 394: warning: comment on exported method FakeDbClient.UpdateVolumeSnapshot should be of the form "UpdateVolumeSnapshot ..." (golint)
    • Line 399: warning: comment on exported method FakeDbClient.DeleteVolumeSnapshot should be of the form "DeleteVolumeSnapshot ..." (golint)
    • Line 404: warning: exported method FakeDbClient.CreateReplication should have comment or be unexported (golint)
    • Line 408: warning: exported method FakeDbClient.GetReplication should have comment or be unexported (golint)
    • Line 412: warning: exported method FakeDbClient.ListReplication should have comment or be unexported (golint)
    • Line 419: warning: exported method FakeDbClient.GetReplicationByVolumeId should have comment or be unexported (golint)
    • Line 423: warning: exported method FakeDbClient.ListReplicationWithFilter should have comment or be unexported (golint)
    • Line 430: warning: exported method FakeDbClient.DeleteReplication should have comment or be unexported (golint)
    • Line 434: warning: exported method FakeDbClient.UpdateReplication should have comment or be unexported (golint)
    • Line 438: warning: comment on exported method FakeDbClient.CreateVolumeGroup should be of the form "CreateVolumeGroup ..." (golint)
    • Line 443: warning: exported method FakeDbClient.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 447: warning: exported method FakeDbClient.GetVolumeGroup should have comment or be unexported (golint)
    • Line 451: warning: exported method FakeDbClient.UpdateStatus should have comment or be unexported (golint)
    • Line 455: warning: exported method FakeDbClient.ListVolumesByIds should have comment or be unexported (golint)
    • Line 459: warning: exported method FakeDbClient.ListVolumesByGroupId should have comment or be unexported (golint)
    • Line 463: warning: exported method FakeDbClient.ListSnapshotsByVolumeId should have comment or be unexported (golint)
    • Line 467: warning: exported method FakeDbClient.ListAttachmentsByVolumeId should have comment or be unexported (golint)
    • Line 471: warning: exported method FakeDbClient.DeleteVolumeGroup should have comment or be unexported (golint)
    • Line 475: warning: exported method FakeDbClient.ListVolumeGroupsWithFilter should have comment or be unexported (golint)
    • Line 482: warning: exported method FakeDbClient.ListVolumeGroups should have comment or be unexported (golint)
    • Line 489: warning: exported method FakeDbClient.VolumesToUpdate should have comment or be unexported (golint)
    • Line 493: warning: exported method FakeDbClient.ListHosts should have comment or be unexported (golint)
    • Line 493: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 502: warning: exported method FakeDbClient.ListHostsByName should have comment or be unexported (golint)
    • Line 502: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 511: warning: exported method FakeDbClient.CreateHost should have comment or be unexported (golint)
    • Line 511: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 515: warning: exported method FakeDbClient.UpdateHost should have comment or be unexported (golint)
    • Line 515: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 519: warning: exported method FakeDbClient.GetHost should have comment or be unexported (golint)
    • Line 519: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 523: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • Line 527: warning: exported method FakeDbClient.DeleteHost should have comment or be unexported (golint)
    • Line 527: warning: receiver name c should be consistent with previous receiver name fc for FakeDbClient (golint)
    • dock/contrib/drivers/openstack/cinder/cinder.go
    • Line 37: warning: should not use dot imports (golint)
    • Line 47: warning: exported const KCinderVolumeId should have comment (or a comment on this block) or be unexported (golint)
    • Line 61: warning: comment on exported type AuthOptions should be of the form "AuthOptions ..." (with optional leading article) (golint)
    • Line 76: warning: comment on exported type CinderConfig should be of the form "CinderConfig ..." (with optional leading article) (golint)
    • Line 82: warning: comment on exported type ListPoolOpts should be of the form "ListPoolOpts ..." (with optional leading article) (golint)
    • Line 92: warning: comment on exported type PoolArray should be of the form "PoolArray ..." (with optional leading article) (golint)
    • Line 97: warning: exported type StoragePool should have comment or be unexported (golint)
    • Line 102: warning: exported type Capabilities should have comment or be unexported (golint)
    • Line 107: warning: exported method ListPoolOpts.ToStoragePoolsListQuery should have comment or be unexported (golint)
    • Line 112: warning: comment on exported method Driver.Setup should be of the form "Setup ..." (golint)
    • Line 175: warning: comment on exported method Driver.Unset should be of the form "Unset ..." (golint)
    • Line 178: warning: comment on exported method Driver.CreateVolume should be of the form "CreateVolume ..." (golint)
    • Line 234: warning: comment on exported method Driver.PullVolume should be of the form "PullVolume ..." (golint)
    • Line 253: warning: comment on exported method Driver.DeleteVolume should be of the form "DeleteVolume ..." (golint)
    • Line 288: warning: comment on exported method Driver.InitializeConnection should be of the form "InitializeConnection ..." (golint)
    • Line 329: warning: comment on exported method Driver.TerminateConnection should be of the form "TerminateConnection ..." (golint)
    • Line 342: warning: comment on exported method Driver.CreateSnapshot should be of the form "CreateSnapshot ..." (golint)
    • Line 398: warning: comment on exported method Driver.PullSnapshot should be of the form "PullSnapshot ..." (golint)
    • Line 417: warning: comment on exported method Driver.DeleteSnapshot should be of the form "DeleteSnapshot ..." (golint)
    • Line 427: warning: exported function ExtractStoragePools should have comment or be unexported (golint)
    • Line 435: warning: comment on exported method Driver.ListPools should be of the form "ListPools ..." (golint)
    • Line 474: warning: exported method Driver.InitializeSnapshotConnection should have comment or be unexported (golint)
    • Line 478: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 482: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 486: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 490: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
    • dock/pkg/model/proto/response.go
    • Line 22: warning: exported function GenericResponseResult should have comment or be unexported (golint)
    • Line 45: warning: exported function GenericResponseError should have comment or be unexported (golint)
    • dock/pkg/model/replication.go
    • Line 24: warning: exported const ReplicationModeSync should have comment (or a comment on this block) or be unexported (golint)
    • Line 84: warning: exported type FailoverReplicationSpec should have comment or be unexported (golint)
    • dock/contrib/drivers/ibm/spectrumscale/cli.go
    • Line 27: warning: exported type MakeConfig should have comment or be unexported (golint)
    • Line 35: warning: exported function Executer should have comment or be unexported (golint)
    • Line 46: warning: exported type Cli should have comment or be unexported (golint)
    • Line 63: warning: exported function NewCli should have comment or be unexported (golint)
    • Line 74: warning: comment on exported method Cli.GetSpectrumScaleStatus should be of the form "GetSpectrumScaleStatus ..." (golint)
    • Line 96: warning: comment on exported method Cli.GetSpectrumScaleMountPoint should be of the form "GetSpectrumScaleMountPoint ..." (golint)
    • Line 126: warning: comment on exported method Cli.CreateVolume should be of the form "CreateVolume ..." (golint)
    • Line 158: warning: comment on exported method Cli.Delete should be of the form "Delete ..." (golint)
    • Line 180: warning: comment on exported method Cli.ExtendVolume should be of the form "ExtendVolume ..." (golint)
    • Line 193: warning: comment on exported method Cli.CreateSnapshot should be of the form "CreateSnapshot ..." (golint)
    • Line 206: warning: comment on exported method Cli.DeleteSnapshot should be of the form "DeleteSnapshot ..." (golint)
    • Line 220: warning: exported type Pools should have comment or be unexported (golint)
    • Line 227: warning: comment on exported method Cli.ListPools should be of the form "ListPools ..." (golint)
    • dock/contrib/backup/multicloud/client.go
    • Line 36: warning: exported const DefaultTenantId should have comment (or a comment on this block) or be unexported (golint)
    • Line 42: warning: exported type Client should have comment or be unexported (golint)
    • Line 53: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 79: warning: exported type ReqSettingCB should have comment or be unexported (golint)
    • Line 118: warning: exported method Client.UpdateToken should have comment or be unexported (golint)
    • Line 214: warning: exported type Object should have comment or be unexported (golint)
    • Line 220: warning: exported type ListObjectResponse should have comment or be unexported (golint)
    • Line 224: warning: exported type InitiateMultipartUploadResult should have comment or be unexported (golint)
    • Line 231: warning: exported type UploadPartResult should have comment or be unexported (golint)
    • Line 237: warning: exported type Part should have comment or be unexported (golint)
    • Line 242: warning: exported type CompleteMultipartUpload should have comment or be unexported (golint)
    • Line 247: warning: exported type CompleteMultipartUploadResult should have comment or be unexported (golint)
    • Line 255: warning: exported method Client.UploadObject should have comment or be unexported (golint)
    • Line 261: warning: exported method Client.ListObject should have comment or be unexported (golint)
    • Line 270: warning: exported method Client.RemoveObject should have comment or be unexported (golint)
    • Line 276: warning: exported method Client.InitMultiPartUpload should have comment or be unexported (golint)
    • Line 286: warning: exported method Client.UploadPart should have comment or be unexported (golint)
    • Line 302: warning: exported method Client.CompleteMultipartUpload should have comment or be unexported (golint)
    • Line 317: warning: exported method Client.AbortMultipartUpload should have comment or be unexported (golint)
    • Line 326: warning: exported method Client.DownloadPart should have comment or be unexported (golint)
    • dock/contrib/drivers/filesharedrivers/chubaofs/chubaofs.go
    • Line 24: warning: should not use dot imports (golint)
    • Line 25: warning: should not use dot imports (golint)
    • Line 32: warning: exported const DefaultConfPath should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: exported const KMountPoint should have comment (or a comment on this block) or be unexported (golint)
    • Line 48: warning: exported const KClientPath should have comment (or a comment on this block) or be unexported (golint)
    • Line 64: warning: exported type ClusterInfo should have comment or be unexported (golint)
    • Line 70: warning: exported type RuntimeEnv should have comment or be unexported (golint)
    • Line 78: warning: exported type Config should have comment or be unexported (golint)
    • Line 85: warning: exported type Driver should have comment or be unexported (golint)
    • Line 89: warning: exported method Driver.Setup should have comment or be unexported (golint)
    • Line 101: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 112: warning: exported method Driver.Unset should have comment or be unexported (golint)
    • Line 116: warning: exported method Driver.CreateFileShare should have comment or be unexported (golint)
    • Line 169: warning: exported method Driver.DeleteFileShare should have comment or be unexported (golint)
    • Line 190: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 199: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 213: warning: exported method Driver.CreateFileShareSnapshot should have comment or be unexported (golint)
    • Line 217: warning: exported method Driver.DeleteFileShareSnapshot should have comment or be unexported (golint)
    • Line 221: warning: exported method Driver.CreateFileShareAcl should have comment or be unexported (golint)
    • Line 225: warning: exported method Driver.DeleteFileShareAcl should have comment or be unexported (golint)
    • Line 229: warning: exported method Driver.ListPools should have comment or be unexported (golint)
    • dock/pkg/db/drivers/etcd/client.go
    • Line 38: warning: comment on exported type Request should be of the form "Request ..." (with optional leading article) (golint)
    • Line 45: warning: comment on exported type Response should be of the form "Response ..." (with optional leading article) (golint)
    • Line 64: warning: comment on exported function Init should be of the form "Init ..." (golint)
    • dock/contrib/drivers/fujitsu/eternus/common.go
    • Line 23: warning: should not use dot imports (golint)
    • Line 26: warning: exported type AuthOptions should have comment or be unexported (golint)
    • Line 37: warning: exported type Replication should have comment or be unexported (golint)
    • Line 41: warning: exported type EternusConfig should have comment or be unexported (golint)
    • Line 49: warning: exported function IsIPv4 should have comment or be unexported (golint)
    • Line 53: warning: comment on exported function GetPortNumber should be of the form "GetPortNumber ..." (golint)
    • Line 65: warning: comment on exported function GetPortNumberV2 should be of the form "GetPortNumberV2 ..." (golint)
    • dock/pkg/utils/config/config_define.go
    • Line 19: warning: exported type Default should have comment or be unexported (golint)
    • Line 21: warning: exported type OsdsDock should have comment or be unexported (golint)
    • Line 32: warning: exported type Database should have comment or be unexported (golint)
    • Line 45: warning: exported type BackendProperties should have comment or be unexported (golint)
    • Line 53: warning: exported type Backends should have comment or be unexported (golint)
    • Line 71: warning: exported type KeystoneAuthToken should have comment or be unexported (golint)
    • Line 89: warning: exported type Config should have comment or be unexported (golint)
    • dock/contrib/drivers/fujitsu/eternus/model.go
    • Line 17: warning: exported type System should have comment or be unexported (golint)
    • Line 77: warning: comment on exported type Mapping should be of the form "Mapping ..." (with optional leading article) (golint)
    • Line 87: warning: comment on exported type SnapShot should be of the form "SnapShot ..." (with optional leading article) (golint)
    • dock/contrib/drivers/huawei/fusionstorage/fusionstorage.go
    • Line 26: warning: should not use dot imports (golint)
    • Line 27: warning: should not use dot imports (golint)
    • Line 33: warning: exported method Driver.Setup should have comment or be unexported (golint)
    • Line 58: warning: exported method Driver.Unset should have comment or be unexported (golint)
    • Line 65: warning: exported function EncodeName should have comment or be unexported (golint)
    • Line 69: warning: exported method Driver.CreateVolume should have comment or be unexported (golint)
    • Line 93: warning: exported method Driver.DeleteVolume should have comment or be unexported (golint)
    • Line 105: warning: exported method Driver.ListPools should have comment or be unexported (golint)
    • Line 145: warning: exported method Driver.InitializeConnection should have comment or be unexported (golint)
    • Line 223: warning: exported method Driver.GetTgtLunID should have comment or be unexported (golint)
    • Line 239: warning: exported method Driver.AddPortToHost should have comment or be unexported (golint)
    • Line 260: warning: exported method Driver.CreateHostIfNotExist should have comment or be unexported (golint)
    • Line 276: warning: exported method Driver.CreatePortIfNotExist should have comment or be unexported (golint)
    • Line 292: warning: exported method Driver.GetTargetPortal should have comment or be unexported (golint)
    • Line 303: warning: exported method Driver.GeTgtPortalAndIQNVersion6_3 should have comment or be unexported (golint)
    • Line 323: warning: exported method Driver.GeTgtPortalAndIQNVersion8_0 should have comment or be unexported (golint)
    • Line 348: warning: exported method Driver.TerminateConnection should have comment or be unexported (golint)
    • Line 403: warning: exported method Driver.CheckVolAttachToHost should have comment or be unexported (golint)
    • Line 428: warning: exported method Driver.CheckHostIsExist should have comment or be unexported (golint)
    • Line 444: warning: exported method Driver.PullVolume should have comment or be unexported (golint)
    • Line 449: warning: exported method Driver.ExtendVolume should have comment or be unexported (golint)
    • Line 468: warning: exported method Driver.CreateSnapshot should have comment or be unexported (golint)
    • Line 490: warning: exported method Driver.PullSnapshot should have comment or be unexported (golint)
    • Line 494: warning: exported method Driver.DeleteSnapshot should have comment or be unexported (golint)
    • Line 505: warning: exported method Driver.InitializeSnapshotConnection should have comment or be unexported (golint)
    • Line 509: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 513: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 517: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 521: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
    • dock/contrib/drivers/huawei/oceanstor/oceanstor.go
    • Line 24: warning: should not use dot imports (golint)
    • Line 25: warning: should not use dot imports (golint)
    • Line 33: warning: exported type Driver should have comment or be unexported (golint)
    • Line 38: warning: exported method Driver.Setup should have comment or be unexported (golint)
    • Line 56: warning: exported method Driver.Unset should have comment or be unexported (golint)
    • Line 165: warning: exported method Driver.CreateVolume should have comment or be unexported (golint)
    • Line 200: warning: exported method Driver.PullVolume should have comment or be unexported (golint)
    • Line 217: warning: exported method Driver.DeleteVolume should have comment or be unexported (golint)
    • Line 268: warning: exported method Driver.InitializeConnection should have comment or be unexported (golint)
    • Line 278: warning: exported method Driver.InitializeConnectionIscsi should have comment or be unexported (golint)
    • Line 333: warning: exported method Driver.TerminateConnection should have comment or be unexported (golint)
    • Line 343: warning: exported method Driver.TerminateConnectionIscsi should have comment or be unexported (golint)
    • Line 451: warning: exported method Driver.CreateSnapshot should have comment or be unexported (golint)
    • Line 473: warning: exported method Driver.PullSnapshot should have comment or be unexported (golint)
    • Line 490: warning: exported method Driver.DeleteSnapshot should have comment or be unexported (golint)
    • Line 501: warning: exported method Driver.ListPools should have comment or be unexported (golint)
    • Line 534: warning: exported method Driver.InitializeConnectionFC should have comment or be unexported (golint)
    • Line 667: warning: exported method Driver.TerminateConnectionFC should have comment or be unexported (golint)
    • Line 824: warning: exported method Driver.InitializeSnapshotConnection should have comment or be unexported (golint)
    • Line 828: warning: exported method Driver.TerminateSnapshotConnection should have comment or be unexported (golint)
    • Line 832: warning: exported method Driver.CreateVolumeGroup should have comment or be unexported (golint)
    • Line 836: warning: exported method Driver.UpdateVolumeGroup should have comment or be unexported (golint)
    • Line 840: warning: exported method Driver.DeleteVolumeGroup should have comment or be unexported (golint)
    • dock/pkg/model/metric.go
    • Line 22: warning: exported type CollectMetricSpec should have comment or be unexported (golint)
    • Line 29: warning: exported type GetMetricSpec should have comment or be unexported (golint)
    • Line 43: warning: exported type MetricSpec should have comment or be unexported (golint)
    • Line 81: warning: exported type Metric should have comment or be unexported (golint)
    • Line 86: warning: exported type NoParam should have comment or be unexported (golint)
    • Line 88: warning: exported type UrlSpec should have comment or be unexported (golint)
    • Line 94: warning: exported type UrlDesc should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign92%

IneffAssign detects ineffectual assignments in Go code.


misspell90%

Misspell Finds commonly misspelled English words