Preparing report...

Report for github.com/square/spincycle

A    Great!    Found 94 issues across 118 files

Tweet

gofmt78%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo84%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint38%

Golint is a linter for Go source code.

    • spincycle/test/mock/status.go
    • Line 9: warning: exported type JRStatus should have comment or be unexported (golint)
    • Line 13: warning: exported method JRStatus.Running should have comment or be unexported (golint)
    • Line 22: warning: exported type RMStatus should have comment or be unexported (golint)
    • Line 27: warning: exported method RMStatus.Running should have comment or be unexported (golint)
    • Line 34: warning: exported method RMStatus.UpdateProgress should have comment or be unexported (golint)
    • spincycle/job-runner/runner/runner.go
    • Line 20: warning: comment on exported const JOB_LOG_TRIES should be of the form "JOB_LOG_TRIES ..." (golint)
    • Line 22: warning: comment on exported const JOB_LOG_RETRY_WAIT should be of the form "JOB_LOG_RETRY_WAIT ..." (golint)
    • Line 26: warning: exported type Return should have comment or be unexported (golint)
    • Line 31: warning: exported type Status should have comment or be unexported (golint)
    • spincycle/request-manager/request/resumer.go
    • Line 23: warning: exported var ErrNotUpdated should have comment or be unexported (golint)
    • Line 27: warning: exported type Resumer should have comment or be unexported (golint)
    • Line 93: warning: exported type ResumerConfig should have comment or be unexported (golint)
    • Line 103: warning: exported function NewResumer should have comment or be unexported (golint)
    • spincycle/spinc/config/config.go
    • Line 20: warning: exported const DEFAULT_CONFIG_FILES should have comment (or a comment on this block) or be unexported (golint)
    • Line 80: warning: exported function ParseConfigFiles should have comment or be unexported (golint)
    • spincycle/spinc/cmd/stop.go
    • Line 11: warning: exported type Stop should have comment or be unexported (golint)
    • Line 16: warning: exported function NewStop should have comment or be unexported (golint)
    • Line 22: warning: exported method Stop.Prepare should have comment or be unexported (golint)
    • Line 30: warning: exported method Stop.Run should have comment or be unexported (golint)
    • Line 38: warning: exported method Stop.Cmd should have comment or be unexported (golint)
    • Line 42: warning: exported method Stop.Help should have comment or be unexported (golint)
    • spincycle/test/util.go
    • Line 51: warning: comment on exported function InitJobsWithSequenceRetry should be of the form "InitJobsWithSequenceRetry ..." (golint)
    • Line 76: warning: exported function Dump should have comment or be unexported (golint)
    • Line 83: warning: exported function RandSeq should have comment or be unexported (golint)
    • spincycle/test/mock/jobchain.go
    • Line 12: warning: exported var ErrJCStore should have comment or be unexported (golint)
    • Line 15: warning: exported type JCStore should have comment or be unexported (golint)
    • Line 19: warning: exported method JCStore.Get should have comment or be unexported (golint)
    • spincycle/request-manager/request/manager.go
    • Line 30: warning: exported const DB_TRIES should have comment (or a comment on this block) or be unexported (golint)
    • Line 87: warning: exported type ManagerConfig should have comment or be unexported (golint)
    • Line 96: warning: exported function NewManager should have comment or be unexported (golint)
    • spincycle/request-manager/spec/spec.go
    • Line 18: warning: comment on exported type Node should be of the form "Node ..." (with optional leading article) (golint)
    • Line 34: warning: comment on exported type NodeArg should be of the form "NodeArg ..." (with optional leading article) (golint)
    • Line 40: warning: comment on exported type NodeSet should be of the form "NodeSet ..." (with optional leading article) (golint)
    • Line 46: warning: comment on exported type Sequence should be of the form "Sequence ..." (with optional leading article) (golint)
    • Line 56: warning: comment on exported type SequenceArgs should be of the form "SequenceArgs ..." (with optional leading article) (golint)
    • Line 68: warning: comment on exported type Arg should be of the form "Arg ..." (with optional leading article) (golint)
    • Line 75: warning: comment on exported type ACL should be of the form "ACL ..." (with optional leading article) (golint)
    • Line 85: warning: comment on exported type Specs should be of the form "Specs ..." (with optional leading article) (golint)
    • Line 92: warning: exported method Node.IsJob should have comment or be unexported (golint)
    • Line 96: warning: exported method Node.IsSequence should have comment or be unexported (golint)
    • Line 100: warning: exported method Node.IsConditional should have comment or be unexported (golint)
    • spincycle/spinc/cmd/cmd.go
    • Line 15: warning: exported var ErrNotExist should have comment or be unexported (golint)
    • Line 18: warning: exported type ErrUnknownArgs should have comment or be unexported (golint)
    • Line 27: warning: exported type DefaultFactory should have comment or be unexported (golint)
    • Line 30: warning: exported method DefaultFactory.Make should have comment or be unexported (golint)
    • Line 79: warning: exported function QuoteArgValue should have comment or be unexported (golint)
    • spincycle/test/mock/resolver.go
    • Line 10: warning: exported type ResolverFactory should have comment or be unexported (golint)
    • Line 14: warning: exported method ResolverFactory.Make should have comment or be unexported (golint)
    • Line 21: warning: exported type Resolver should have comment or be unexported (golint)
    • Line 26: warning: exported method Resolver.RequestArgs should have comment or be unexported (golint)
    • Line 32: warning: exported method Resolver.BuildRequestGraph should have comment or be unexported (golint)
    • spincycle/job-runner/status/status.go
    • Line 16: warning: exported type Manager should have comment or be unexported (golint)
    • Line 24: warning: exported function NewManager should have comment or be unexported (golint)
    • Line 70: warning: exported method FinishedJobs.Update should have comment or be unexported (golint)
    • spincycle/errors/errors.go
    • Line 17: warning: exported type RequestNotFound should have comment or be unexported (golint)
    • Line 29: warning: exported type JobNotFound should have comment or be unexported (golint)
    • Line 42: warning: comment on exported type DbError should be of the form "DbError ..." (with optional leading article) (golint)
    • Line 50: warning: exported function NewDbError should have comment or be unexported (golint)
    • Line 62: warning: exported type ErrInvalidCreateRequest should have comment or be unexported (golint)
    • Line 74: warning: exported type ErrInvalidState should have comment or be unexported (golint)
    • Line 79: warning: exported function NewErrInvalidState should have comment or be unexported (golint)
    • Line 94: warning: exported type ValidationError should have comment or be unexported (golint)
    • spincycle/job-runner/app/app.go
    • Line 14: warning: exported type Context should have comment or be unexported (golint)
    • Line 21: warning: exported type Factories should have comment or be unexported (golint)
    • Line 25: warning: exported type Hooks should have comment or be unexported (golint)
    • Line 48: warning: exported function Defaults should have comment or be unexported (golint)
    • Line 60: warning: exported function LoadConfig should have comment or be unexported (golint)
    • Line 68: warning: comment on exported function ServerURL should be of the form "ServerURL ..." (golint)
    • Line 89: warning: exported function MakeRequestManagerClient should have comment or be unexported (golint)
    • spincycle/test/mock/joblog.go
    • Line 12: warning: exported var ErrJLStore should have comment or be unexported (golint)
    • Line 15: warning: exported type JLStore should have comment or be unexported (golint)
    • Line 21: warning: exported method JLStore.Create should have comment or be unexported (golint)
    • Line 28: warning: exported method JLStore.Get should have comment or be unexported (golint)
    • Line 35: warning: exported method JLStore.GetFull should have comment or be unexported (golint)
    • spincycle/retry/retry.go
    • Line 7: warning: exported type TryFunc should have comment or be unexported (golint)
    • Line 8: warning: exported type LogFunc should have comment or be unexported (golint)
    • Line 10: warning: comment on exported function Do should be of the form "Do ..." (golint)
    • spincycle/dev/jobs/factory.go
    • Line 3: warning: package comment should be of the form "Package jobs ..." (golint)
    • Line 141: warning: comment on exported method ShellCommand.Id should be of the form "Id ..." (golint)
    • Line 253: warning: exported function NewNop should have comment or be unexported (golint)
    • Line 260: warning: exported method Nop.Create should have comment or be unexported (golint)
    • Line 264: warning: exported method Nop.Serialize should have comment or be unexported (golint)
    • Line 268: warning: exported method Nop.Deserialize should have comment or be unexported (golint)
    • Line 272: warning: exported method Nop.Run should have comment or be unexported (golint)
    • Line 283: warning: exported method Nop.Status should have comment or be unexported (golint)
    • Line 287: warning: exported method Nop.Stop should have comment or be unexported (golint)
    • Line 291: warning: exported method Nop.Id should have comment or be unexported (golint)
    • spincycle/request-manager/spec/node-check.go
    • Line 11: warning: exported type NodeCheck should have comment or be unexported (golint)
    • Line 15: warning: comment on exported type HasCategoryNodeCheck should be of the form "HasCategoryNodeCheck ..." (with optional leading article) (golint)
    • Line 18: warning: comment on exported method HasCategoryNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 31: warning: comment on exported type ValidCategoryNodeCheck should be of the form "ValidCategoryNodeCheck ..." (with optional leading article) (golint)
    • Line 34: warning: comment on exported method ValidCategoryNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 51: warning: comment on exported type ValidEachNodeCheck should be of the form "ValidEachNodeCheck ..." (with optional leading article) (golint)
    • Line 54: warning: comment on exported method ValidEachNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 76: warning: comment on exported type EachElementUniqueNodeCheck should be of the form "EachElementUniqueNodeCheck ..." (with optional leading article) (golint)
    • Line 79: warning: comment on exported method EachElementUniqueNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 107: warning: comment on exported type EachNotRenamedTwiceNodeCheck should be of the form "EachNotRenamedTwiceNodeCheck ..." (with optional leading article) (golint)
    • Line 110: warning: comment on exported method EachNotRenamedTwiceNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 139: warning: comment on exported type ArgsNotNilNodeCheck should be of the form "ArgsNotNilNodeCheck ..." (with optional leading article) (golint)
    • Line 142: warning: comment on exported method ArgsNotNilNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 158: warning: comment on exported type ArgsAreNamedNodeCheck should be of the form "ArgsAreNamedNodeCheck ..." (with optional leading article) (golint)
    • Line 161: warning: comment on exported method ArgsAreNamedNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 176: warning: comment on exported type ArgsExpectedUniqueNodeCheck should be of the form "ArgsExpectedUniqueNodeCheck ..." (with optional leading article) (golint)
    • Line 179: warning: comment on exported method ArgsExpectedUniqueNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 205: warning: comment on exported type ArgsNotRenamedTwiceNodeCheck should be of the form "ArgsNotRenamedTwiceNodeCheck ..." (with optional leading article) (golint)
    • Line 208: warning: comment on exported method ArgsNotRenamedTwiceNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 239: warning: comment on exported type EachElementDoesNotDuplicateArgsExpectedNodeCheck should be of the form "EachElementDoesNotDuplicateArgsExpectedNodeCheck ..." (with optional leading article) (golint)
    • Line 242: warning: comment on exported method EachElementDoesNotDuplicateArgsExpectedNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 276: warning: comment on exported type EachListDoesNotDuplicateArgsGivenNodeCheck should be of the form "EachListDoesNotDuplicateArgsGivenNodeCheck ..." (with optional leading article) (golint)
    • Line 279: warning: comment on exported method EachListDoesNotDuplicateArgsGivenNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 313: warning: comment on exported type SetsNotNilNodeCheck should be of the form "SetsNotNilNodeCheck ..." (with optional leading article) (golint)
    • Line 316: warning: comment on exported method SetsNotNilNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 332: warning: comment on exported type SetsAreNamedNodeCheck should be of the form "SetsAreNamedNodeCheck ..." (with optional leading article) (golint)
    • Line 335: warning: comment on exported method SetsAreNamedNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 350: warning: comment on exported type SetsAsUniqueNodeCheck should be of the form "SetsAsUniqueNodeCheck ..." (with optional leading article) (golint)
    • Line 353: warning: comment on exported method SetsAsUniqueNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 379: warning: comment on exported type SetsNotRenamedTwiceNodeCheck should be of the form "SetsNotRenamedTwiceNodeCheck ..." (with optional leading article) (golint)
    • Line 382: warning: comment on exported method SetsNotRenamedTwiceNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 408: warning: comment on exported type EachIfParallelNodeCheck should be of the form "EachIfParallelNodeCheck ..." (with optional leading article) (golint)
    • Line 411: warning: comment on exported method EachIfParallelNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 426: warning: comment on exported type ValidParallelNodeCheck should be of the form "ValidParallelNodeCheck ..." (with optional leading article) (golint)
    • Line 429: warning: comment on exported method ValidParallelNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 445: warning: comment on exported type ConditionalNoTypeNodeCheck should be of the form "ConditionalNoTypeNodeCheck ..." (with optional leading article) (golint)
    • Line 448: warning: comment on exported method ConditionalNoTypeNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 464: warning: comment on exported type ConditionalHasIfNodeCheck should be of the form "ConditionalHasIfNodeCheck ..." (with optional leading article) (golint)
    • Line 467: warning: comment on exported method ConditionalHasIfNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 482: warning: comment on exported type ConditionalHasEqNodeCheck should be of the form "ConditionalHasEqNodeCheck ..." (with optional leading article) (golint)
    • Line 485: warning: comment on exported method ConditionalHasEqNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 500: warning: comment on exported type NonconditionalHasTypeNodeCheck should be of the form "NonconditionalHasTypeNodeCheck ..." (with optional leading article) (golint)
    • Line 503: warning: comment on exported method NonconditionalHasTypeNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 518: warning: comment on exported type NonconditionalNoIfNodeCheck should be of the form "NonconditionalNoIfNodeCheck ..." (with optional leading article) (golint)
    • Line 521: warning: comment on exported method NonconditionalNoIfNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 537: warning: comment on exported type NonconditionalNoEqNodeCheck should be of the form "NonconditionalNoEqNodeCheck ..." (with optional leading article) (golint)
    • Line 540: warning: comment on exported method NonconditionalNoEqNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 557: warning: comment on exported type RetryIfRetryWaitNodeCheck should be of the form "RetryIfRetryWaitNodeCheck ..." (with optional leading article) (golint)
    • Line 560: warning: comment on exported method RetryIfRetryWaitNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 573: warning: comment on exported type ValidRetryWaitNodeCheck should be of the form "ValidRetryWaitNodeCheck ..." (with optional leading article) (golint)
    • Line 576: warning: comment on exported method ValidRetryWaitNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 592: warning: comment on exported type RequiredArgsProvidedNodeCheck should be of the form "RequiredArgsProvidedNodeCheck ..." (with optional leading article) (golint)
    • Line 597: warning: comment on exported method RequiredArgsProvidedNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 650: warning: comment on exported type NoExtraSequenceArgsProvidedNodeCheck should be of the form "NoExtraSequenceArgsProvidedNodeCheck ..." (with optional leading article) (golint)
    • Line 655: warning: comment on exported method NoExtraSequenceArgsProvidedNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • Line 700: warning: comment on exported type SubsequencesExistNodeCheck should be of the form "SubsequencesExistNodeCheck ..." (with optional leading article) (golint)
    • Line 705: warning: comment on exported method SubsequencesExistNodeCheck.CheckNode should be of the form "CheckNode ..." (golint)
    • spincycle/spinc/cmd/start.go
    • Line 14: warning: exported type Start should have comment or be unexported (golint)
    • Line 25: warning: exported function NewStart should have comment or be unexported (golint)
    • Line 32: warning: exported method Start.Prepare should have comment or be unexported (golint)
    • Line 154: warning: exported method Start.Run should have comment or be unexported (golint)
    • Line 196: warning: exported method Start.Cmd should have comment or be unexported (golint)
    • Line 219: warning: exported method Start.Help should have comment or be unexported (golint)
    • spincycle/request-manager/server/server.go
    • Line 31: warning: comment on exported var ResumerInterval should be of the form "ResumerInterval ..." (golint)
    • Line 34: warning: comment on exported var SJCTTL should be of the form "SJCTTL ..." (golint)
    • Line 38: warning: exported type Server should have comment or be unexported (golint)
    • Line 49: warning: exported function NewServer should have comment or be unexported (golint)
    • spincycle/spinc/cmd/log.go
    • Line 15: warning: exported const RECORD_SEPARATOR should have comment (or a comment on this block) or be unexported (golint)
    • Line 24: warning: exported type Log should have comment or be unexported (golint)
    • Line 29: warning: exported function NewLog should have comment or be unexported (golint)
    • Line 35: warning: exported method Log.Prepare should have comment or be unexported (golint)
    • Line 43: warning: exported method Log.Run should have comment or be unexported (golint)
    • Line 91: warning: exported method Log.Cmd should have comment or be unexported (golint)
    • Line 95: warning: exported method Log.Help should have comment or be unexported (golint)
    • spincycle/spinc/cmd/find.go
    • Line 33: warning: exported type Find should have comment or be unexported (golint)
    • Line 40: warning: exported function NewFind should have comment or be unexported (golint)
    • Line 46: warning: exported method Find.Prepare should have comment or be unexported (golint)
    • Line 165: warning: exported method Find.Run should have comment or be unexported (golint)
    • Line 229: warning: exported method Find.Cmd should have comment or be unexported (golint)
    • Line 236: warning: exported method Find.Help should have comment or be unexported (golint)
    • Line 270: warning: should omit 2nd value from range; this loop is equivalent to `for state := range ...` (golint)
    • spincycle/spinc/cmd/help.go
    • Line 13: warning: exported type Help should have comment or be unexported (golint)
    • Line 18: warning: exported function NewHelp should have comment or be unexported (golint)
    • Line 24: warning: exported method Help.Prepare should have comment or be unexported (golint)
    • Line 28: warning: exported method Help.Run should have comment or be unexported (golint)
    • Line 68: warning: exported method Help.Cmd should have comment or be unexported (golint)
    • Line 72: warning: exported method Help.Help should have comment or be unexported (golint)
    • Line 78: warning: exported method Help.Usage should have comment or be unexported (golint)
    • Line 103: warning: exported method Help.QuickHelp should have comment or be unexported (golint)
    • Line 123: warning: exported method Help.RequestHelp should have comment or be unexported (golint)
    • spincycle/spinc/cmd/info.go
    • Line 18: warning: exported type Info should have comment or be unexported (golint)
    • Line 23: warning: exported function NewInfo should have comment or be unexported (golint)
    • Line 29: warning: exported method Info.Prepare should have comment or be unexported (golint)
    • Line 37: warning: exported method Info.Run should have comment or be unexported (golint)
    • Line 85: warning: exported method Info.Cmd should have comment or be unexported (golint)
    • Line 89: warning: exported method Info.Help should have comment or be unexported (golint)
    • spincycle/test/mock/idgen.go
    • Line 12: warning: exported var ErrIdGenerator should have comment or be unexported (golint)
    • Line 15: warning: exported type IDGenerator should have comment or be unexported (golint)
    • Line 20: warning: exported method IDGenerator.UID should have comment or be unexported (golint)
    • Line 27: warning: exported method IDGenerator.ID should have comment or be unexported (golint)
    • Line 34: warning: exported type IDGeneratorFactory should have comment or be unexported (golint)
    • Line 38: warning: exported method IDGeneratorFactory.Make should have comment or be unexported (golint)
    • spincycle/job/errors.go
    • Line 70: warning: exported function NewErrWrongDataType should have comment or be unexported (golint)
    • Line 99: warning: exported function NewErrWrongArgType should have comment or be unexported (golint)
    • spincycle/config/config.go
    • Line 122: warning: comment on exported type RequestManager should be of the form "RequestManager ..." (with optional leading article) (golint)
    • Line 180: warning: comment on exported type Auth should be of the form "Auth ..." (with optional leading article) (golint)
    • Line 193: warning: comment on exported type Specs should be of the form "Specs ..." (with optional leading article) (golint)
    • Line 201: warning: comment on exported type Server should be of the form "Server ..." (with optional leading article) (golint)
    • Line 242: warning: comment on exported type MySQL should be of the form "MySQL ..." (with optional leading article) (golint)
    • spincycle/request-manager/spec/check-result.go
    • Line 5: warning: exported type CheckResult should have comment or be unexported (golint)
    • Line 10: warning: exported type CheckResults should have comment or be unexported (golint)
    • Line 16: warning: exported function NewCheckResults should have comment or be unexported (golint)
    • Line 22: warning: exported method CheckResults.AddResult should have comment or be unexported (golint)
    • Line 34: warning: exported method CheckResults.AddError should have comment or be unexported (golint)
    • Line 42: warning: exported method CheckResults.AddWarning should have comment or be unexported (golint)
    • Line 50: warning: exported method CheckResults.Union should have comment or be unexported (golint)
    • Line 62: warning: exported method CheckResults.Get should have comment or be unexported (golint)
    • spincycle/test/mock/reaper.go
    • Line 12: warning: exported var ErrJobReaper should have comment or be unexported (golint)
    • Line 15: warning: exported type JobReaper should have comment or be unexported (golint)
    • Line 21: warning: exported method JobReaper.Run should have comment or be unexported (golint)
    • Line 27: warning: exported method JobReaper.Stop should have comment or be unexported (golint)
    • Line 33: warning: exported method JobReaper.Finalize should have comment or be unexported (golint)
    • Line 39: warning: exported type ReaperFactory should have comment or be unexported (golint)
    • Line 45: warning: exported method ReaperFactory.Make should have comment or be unexported (golint)
    • Line 53: warning: exported method ReaperFactory.MakeRunning should have comment or be unexported (golint)
    • Line 57: warning: exported method ReaperFactory.MakeSuspended should have comment or be unexported (golint)
    • Line 61: warning: exported method ReaperFactory.MakeStopped should have comment or be unexported (golint)
    • spincycle/test/mock/request.go
    • Line 14: warning: exported var ErrRequestManager should have comment or be unexported (golint)
    • Line 18: warning: exported type RequestManager should have comment or be unexported (golint)
    • Line 31: warning: exported method RequestManager.Create should have comment or be unexported (golint)
    • Line 38: warning: exported method RequestManager.Get should have comment or be unexported (golint)
    • Line 45: warning: exported method RequestManager.GetWithJC should have comment or be unexported (golint)
    • Line 52: warning: exported method RequestManager.Start should have comment or be unexported (golint)
    • Line 59: warning: exported method RequestManager.Finish should have comment or be unexported (golint)
    • Line 66: warning: exported method RequestManager.FailPending should have comment or be unexported (golint)
    • Line 73: warning: exported method RequestManager.Stop should have comment or be unexported (golint)
    • Line 80: warning: exported method RequestManager.Specs should have comment or be unexported (golint)
    • Line 87: warning: exported method RequestManager.JobChain should have comment or be unexported (golint)
    • Line 94: warning: exported method RequestManager.Find should have comment or be unexported (golint)
    • Line 103: warning: exported type RequestResumer should have comment or be unexported (golint)
    • Line 110: warning: exported method RequestResumer.ResumeAll should have comment or be unexported (golint)
    • Line 117: warning: exported method RequestResumer.Cleanup should have comment or be unexported (golint)
    • Line 124: warning: exported method RequestResumer.Resume should have comment or be unexported (golint)
    • Line 131: warning: exported method RequestResumer.Suspend should have comment or be unexported (golint)
    • Line 140: warning: exported type AuthPlugin should have comment or be unexported (golint)
    • Line 145: warning: exported method AuthPlugin.Authenticate should have comment or be unexported (golint)
    • Line 152: warning: exported method AuthPlugin.Authorize should have comment or be unexported (golint)
    • spincycle/request-manager/spec/checker.go
    • Line 5: warning: comment on exported type Checker should be of the form "Checker ..." (with optional leading article) (golint)
    • Line 14: warning: comment on exported function NewChecker should be of the form "NewChecker ..." (golint)
    • Line 52: warning: comment on exported method Checker.RunChecks should be of the form "RunChecks ..." (golint)
    • spincycle/request-manager/spec/errors.go
    • Line 12: warning: should omit 2nd value from range; this loop is equivalent to `for v := range ...` (golint)
    • Line 22: warning: exported type InvalidValueError should have comment or be unexported (golint)
    • Line 50: warning: exported type MissingValueError should have comment or be unexported (golint)
    • Line 77: warning: exported type DuplicateValueError should have comment or be unexported (golint)
    • spincycle/test/mock/runner.go
    • Line 14: warning: exported var ErrRunner should have comment or be unexported (golint)
    • Line 17: warning: exported type RunnerFactory should have comment or be unexported (golint)
    • Line 23: warning: exported method RunnerFactory.Make should have comment or be unexported (golint)
    • Line 30: warning: exported type Runner should have comment or be unexported (golint)
    • Line 43: warning: exported method Runner.Run should have comment or be unexported (golint)
    • Line 70: warning: exported method Runner.Stop should have comment or be unexported (golint)
    • Line 78: warning: exported method Runner.Status should have comment or be unexported (golint)
    • Line 87: warning: exported type RunnerRepo should have comment or be unexported (golint)
    • Line 95: warning: exported method RunnerRepo.Set should have comment or be unexported (golint)
    • Line 102: warning: exported method RunnerRepo.Get should have comment or be unexported (golint)
    • Line 109: warning: exported method RunnerRepo.Remove should have comment or be unexported (golint)
    • Line 116: warning: exported method RunnerRepo.Items should have comment or be unexported (golint)
    • Line 123: warning: exported method RunnerRepo.Count should have comment or be unexported (golint)
    • spincycle/spinc/cmd/version.go
    • Line 12: warning: exported type Version should have comment or be unexported (golint)
    • Line 15: warning: exported function NewVersion should have comment or be unexported (golint)
    • Line 19: warning: exported method Version.Prepare should have comment or be unexported (golint)
    • Line 23: warning: exported method Version.Run should have comment or be unexported (golint)
    • Line 28: warning: exported method Version.Cmd should have comment or be unexported (golint)
    • Line 32: warning: exported method Version.Help should have comment or be unexported (golint)
    • spincycle/proto/proto.go
    • Line 18: warning: exported const STATE_UNKNOWN should have comment (or a comment on this block) or be unexported (golint)
    • Line 20: warning: comment on exported const STATE_PENDING should be of the form "STATE_PENDING ..." (golint)
    • Line 29: warning: comment on exported const STATE_SUSPENDED should be of the form "STATE_SUSPENDED ..." (golint)
    • Line 34: warning: exported var StateName should have comment or be unexported (golint)
    • Line 45: warning: exported var StateValue should have comment or be unexported (golint)
    • Line 57: warning: exported const REQUEST_OP_START should have comment (or a comment on this block) or be unexported (golint)
    • Line 146: warning: exported const ARG_TYPE_REQUIRED should have comment (or a comment on this block) or be unexported (golint)
    • Line 170: warning: exported type JobLogById should have comment or be unexported (golint)
    • Line 315: warning: exported function NewError should have comment or be unexported (golint)
    • spincycle/request-manager/spec/check-factory.go
    • Line 5: warning: comment on exported type CheckFactory should be of the form "CheckFactory ..." (with optional leading article) (golint)
    • Line 24: warning: comment on exported type BaseCheckFactory should be of the form "BaseCheckFactory ..." (with optional leading article) (golint)
    • Line 29: warning: exported method BaseCheckFactory.MakeSequenceErrorChecks should have comment or be unexported (golint)
    • Line 44: warning: exported method BaseCheckFactory.MakeSequenceWarningChecks should have comment or be unexported (golint)
    • Line 48: warning: exported method BaseCheckFactory.MakeNodeErrorChecks should have comment or be unexported (golint)
    • Line 73: warning: exported method BaseCheckFactory.MakeNodeWarningChecks should have comment or be unexported (golint)
    • Line 77: warning: comment on exported type DefaultCheckFactory should be of the form "DefaultCheckFactory ..." (with optional leading article) (golint)
    • Line 82: warning: exported method DefaultCheckFactory.MakeSequenceErrorChecks should have comment or be unexported (golint)
    • Line 90: warning: exported method DefaultCheckFactory.MakeSequenceWarningChecks should have comment or be unexported (golint)
    • Line 96: warning: exported method DefaultCheckFactory.MakeNodeErrorChecks should have comment or be unexported (golint)
    • Line 113: warning: exported method DefaultCheckFactory.MakeNodeWarningChecks should have comment or be unexported (golint)
    • spincycle/spinc/app/app.go
    • Line 17: warning: exported var ErrHelp should have comment or be unexported (golint)
    • Line 39: warning: exported type Command should have comment or be unexported (golint)
    • Line 46: warning: exported type CommandFactory should have comment or be unexported (golint)
    • Line 50: warning: exported type HTTPClientFactory should have comment or be unexported (golint)
    • Line 54: warning: exported type Factories should have comment or be unexported (golint)
    • Line 59: warning: exported type Hooks should have comment or be unexported (golint)
    • Line 69: warning: exported function Debug should have comment or be unexported (golint)
    • spincycle/request-manager/spec/parser.go
    • Line 14: warning: comment on exported function ParseSpec should be of the form "ParseSpec ..." (golint)
    • Line 40: warning: comment on exported function ParseSpecsDir should be of the form "ParseSpecsDir ..." (golint)
    • Line 92: warning: comment on exported function ProcessSpecs should be of the form "ProcessSpecs ..." (golint)
    • spincycle/test/mock/job.go
    • Line 12: warning: exported var ErrJob should have comment or be unexported (golint)
    • Line 15: warning: exported type JobFactory should have comment or be unexported (golint)
    • Line 22: warning: exported method JobFactory.Make should have comment or be unexported (golint)
    • Line 40: warning: exported type Job should have comment or be unexported (golint)
    • Line 56: warning: exported method Job.Create should have comment or be unexported (golint)
    • Line 69: warning: exported method Job.Serialize should have comment or be unexported (golint)
    • Line 73: warning: exported method Job.Deserialize should have comment or be unexported (golint)
    • Line 77: warning: exported method Job.Run should have comment or be unexported (golint)
    • Line 84: warning: exported method Job.Stop should have comment or be unexported (golint)
    • Line 91: warning: exported method Job.Status should have comment or be unexported (golint)
    • Line 95: warning: exported method Job.Id should have comment or be unexported (golint)
    • spincycle/test/mock/jrclient.go
    • Line 13: warning: exported var ErrJRClient should have comment or be unexported (golint)
    • Line 16: warning: exported type JRClient should have comment or be unexported (golint)
    • Line 24: warning: exported method JRClient.NewJobChain should have comment or be unexported (golint)
    • Line 31: warning: exported method JRClient.ResumeJobChain should have comment or be unexported (golint)
    • Line 38: warning: exported method JRClient.StartRequest should have comment or be unexported (golint)
    • Line 45: warning: exported method JRClient.StopRequest should have comment or be unexported (golint)
    • Line 52: warning: exported method JRClient.Running should have comment or be unexported (golint)
    • spincycle/request-manager/status/manager.go
    • Line 25: warning: exported const DB_TRIES should have comment (or a comment on this block) or be unexported (golint)
    • Line 29: warning: exported type Manager should have comment or be unexported (golint)
    • Line 39: warning: exported function NewManager should have comment or be unexported (golint)
    • spincycle/job-runner/chain/traverser.go
    • Line 20: warning: comment on exported var ErrShuttingDown should be of the form "ErrShuttingDown ..." (golint)
    • Line 73: warning: exported function NewTraverserFactory should have comment or be unexported (golint)
    • Line 178: warning: exported type TraverserConfig should have comment or be unexported (golint)
    • Line 188: warning: exported function NewTraverser should have comment or be unexported (golint)
    • spincycle/job-runner/api/api.go
    • Line 25: warning: exported const API_ROOT should have comment (or a comment on this block) or be unexported (golint)
    • Line 29: warning: comment on exported var ErrDuplicateTraverser should be of the form "ErrDuplicateTraverser ..." (golint)
    • Line 31: warning: exported var ErrTraverserNotFound should have comment or be unexported (golint)
    • Line 34: warning: comment on exported var ErrShuttingDown should be of the form "ErrShuttingDown ..." (golint)
    • Line 38: warning: comment on exported type API should be of the form "API ..." (with optional leading article) (golint)
    • Line 50: warning: exported type Config should have comment or be unexported (golint)
    • spincycle/spinc/cmd/ps.go
    • Line 19: warning: exported type Ps should have comment or be unexported (golint)
    • Line 24: warning: exported function NewPs should have comment or be unexported (golint)
    • Line 30: warning: exported method Ps.Prepare should have comment or be unexported (golint)
    • Line 42: warning: exported method Ps.Run should have comment or be unexported (golint)
    • Line 95: warning: exported method Ps.Cmd should have comment or be unexported (golint)
    • Line 102: warning: exported method Ps.Help should have comment or be unexported (golint)
    • spincycle/spinc/cmd/running.go
    • Line 13: warning: exported type Running should have comment or be unexported (golint)
    • Line 18: warning: exported function NewRunning should have comment or be unexported (golint)
    • Line 24: warning: exported method Running.Prepare should have comment or be unexported (golint)
    • Line 32: warning: exported method Running.Run should have comment or be unexported (golint)
    • Line 55: warning: exported method Running.Cmd should have comment or be unexported (golint)
    • Line 59: warning: exported method Running.Help should have comment or be unexported (golint)
    • spincycle/request-manager/api/api.go
    • Line 33: warning: exported const API_ROOT should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: comment on exported var ErrShuttingDown should be of the form "ErrShuttingDown ..." (golint)
    • Line 131: warning: exported method API.Router should have comment or be unexported (golint)
    • spincycle/spinc/cmd/status.go
    • Line 14: warning: exported type Status should have comment or be unexported (golint)
    • Line 19: warning: exported function NewStatus should have comment or be unexported (golint)
    • Line 25: warning: exported method Status.Prepare should have comment or be unexported (golint)
    • Line 33: warning: exported method Status.Run should have comment or be unexported (golint)
    • Line 78: warning: exported method Status.Cmd should have comment or be unexported (golint)
    • Line 82: warning: exported method Status.Help should have comment or be unexported (golint)
    • spincycle/job-runner/chain/reaper.go
    • Line 75: warning: comment on exported type ChainReaperFactory should be of the form "ChainReaperFactory ..." (with optional leading article) (golint)
    • Line 89: warning: comment on exported method ChainReaperFactory.MakeRunning should be of the form "MakeRunning ..." (golint)
    • Line 107: warning: comment on exported method ChainReaperFactory.MakeSuspended should be of the form "MakeSuspended ..." (golint)
    • Line 125: warning: comment on exported method ChainReaperFactory.MakeStopped should be of the form "MakeStopped ..." (golint)
    • Line 145: warning: comment on exported type RunningChainReaper should be of the form "RunningChainReaper ..." (with optional leading article) (golint)
    • Line 199: warning: comment on exported method RunningChainReaper.Reap should be of the form "Reap ..." (golint)
    • Line 263: warning: comment on exported type SuspendedChainReaper should be of the form "SuspendedChainReaper ..." (with optional leading article) (golint)
    • Line 336: warning: comment on exported method SuspendedChainReaper.Reap should be of the form "Reap ..." (golint)
    • Line 422: warning: comment on exported type StoppedChainReaper should be of the form "StoppedChainReaper ..." (with optional leading article) (golint)
    • Line 488: warning: comment on exported method StoppedChainReaper.Reap should be of the form "Reap ..." (golint)
    • spincycle/spinc/prompt/prompt.go
    • Line 3: warning: package comment should be of the form "Package prompt ..." (golint)
    • Line 14: warning: exported var ErrNack should have comment or be unexported (golint)
    • Line 17: warning: exported var InputBufferSize should have comment or be unexported (golint)
    • Line 19: warning: exported type Prompter should have comment or be unexported (golint)
    • Line 23: warning: exported type Item should have comment or be unexported (golint)
    • Line 35: warning: exported type GuidedPrompt should have comment or be unexported (golint)
    • Line 41: warning: exported function NewGuidedPrompt should have comment or be unexported (golint)
    • Line 50: warning: exported method GuidedPrompt.Prompt should have comment or be unexported (golint)
    • Line 119: warning: exported type ConfirmationPrompt should have comment or be unexported (golint)
    • Line 126: warning: exported function NewConfirmationPrompt should have comment or be unexported (golint)
    • Line 136: warning: exported method ConfirmationPrompt.Prompt should have comment or be unexported (golint)
    • spincycle/linter/linter.go
    • Line 20: warning: comment on exported type Linter should be of the form "Linter ..." (with optional leading article) (golint)
    • Line 38: warning: exported method Linter.Version should have comment or be unexported (golint)
    • Line 42: warning: exported function Run should have comment or be unexported (golint)
    • Line 104: warning: should omit 2nd value from range; this loop is equivalent to `for seq := range ...` (golint)
    • spincycle/job-runner/chain/chain.go
    • Line 14: warning: comment on exported type Chain should be of the form "Chain ..." (with optional leading article) (golint)
    • Line 160: warning: exported method Chain.SequenceStartJob should have comment or be unexported (golint)
    • Line 166: warning: exported method Chain.IsSequenceStartJob should have comment or be unexported (golint)
    • Line 172: warning: exported method Chain.CanRetrySequence should have comment or be unexported (golint)
    • Line 179: warning: exported method Chain.IncrementJobTries should have comment or be unexported (golint)
    • Line 195: warning: exported method Chain.JobTries should have comment or be unexported (golint)
    • Line 201: warning: exported method Chain.IncrementSequenceTries should have comment or be unexported (golint)
    • Line 211: warning: exported method Chain.SequenceTries should have comment or be unexported (golint)
    • Line 235: warning: exported method Chain.FinishedJobs should have comment or be unexported (golint)
    • Line 241: warning: exported method Chain.ToSuspended should have comment or be unexported (golint)
    • Line 280: warning: comment on exported method Chain.SetJobState should be of the form "SetJobState ..." (golint)
    • spincycle/test/mock/rmclient.go
    • Line 12: warning: exported var ErrRMClient should have comment or be unexported (golint)
    • Line 15: warning: exported type RMClient should have comment or be unexported (golint)
    • Line 31: warning: exported method RMClient.CreateRequest should have comment or be unexported (golint)
    • Line 38: warning: exported method RMClient.GetRequest should have comment or be unexported (golint)
    • Line 45: warning: exported method RMClient.FindRequests should have comment or be unexported (golint)
    • Line 52: warning: exported method RMClient.StartRequest should have comment or be unexported (golint)
    • Line 59: warning: exported method RMClient.FinishRequest should have comment or be unexported (golint)
    • Line 66: warning: exported method RMClient.StopRequest should have comment or be unexported (golint)
    • Line 73: warning: exported method RMClient.SuspendRequest should have comment or be unexported (golint)
    • Line 80: warning: exported method RMClient.GetJobChain should have comment or be unexported (golint)
    • Line 87: warning: exported method RMClient.GetJL should have comment or be unexported (golint)
    • Line 94: warning: exported method RMClient.CreateJL should have comment or be unexported (golint)
    • Line 101: warning: exported method RMClient.RequestList should have comment or be unexported (golint)
    • Line 108: warning: exported method RMClient.Running should have comment or be unexported (golint)
    • Line 115: warning: exported method RMClient.UpdateProgress should have comment or be unexported (golint)
    • spincycle/test/mock/traverser.go
    • Line 13: warning: exported var ErrTraverser should have comment or be unexported (golint)
    • Line 16: warning: exported type Traverser should have comment or be unexported (golint)
    • Line 23: warning: exported method Traverser.Run should have comment or be unexported (golint)
    • Line 27: warning: exported method Traverser.Stop should have comment or be unexported (golint)
    • Line 31: warning: exported method Traverser.Running should have comment or be unexported (golint)
    • Line 38: warning: exported type TraverserFactory should have comment or be unexported (golint)
    • Line 43: warning: exported method TraverserFactory.Make should have comment or be unexported (golint)
    • Line 50: warning: exported method TraverserFactory.MakeFromSJC should have comment or be unexported (golint)
    • spincycle/request-manager/graph/grapher.go
    • Line 25: warning: comment on exported function NewGrapher should be of the form "NewGrapher ..." (golint)
    • Line 80: warning: should omit 2nd value from range; this loop is equivalent to `for seqName := range ...` (golint)
    • Line 93: warning: should omit 2nd value from range; this loop is equivalent to `for s := range ...` (golint)
    • Line 158: warning: should omit 2nd value from range; this loop is equivalent to `for seqName := range ...` (golint)
    • Line 162: warning: should omit 2nd value from range; this loop is equivalent to `for seqName := range ...` (golint)
    • Line 219: warning: should omit 2nd value from range; this loop is equivalent to `for arg := range ...` (golint)
    • Line 377: warning: should omit 2nd value from range; this loop is equivalent to `for n := range ...` (golint)
    • spincycle/request-manager/spec/sequence-check.go
    • Line 10: warning: exported type SequenceCheck should have comment or be unexported (golint)
    • Line 14: warning: comment on exported type RequiredArgsNamedSequenceCheck should be of the form "RequiredArgsNamedSequenceCheck ..." (with optional leading article) (golint)
    • Line 17: warning: comment on exported method RequiredArgsNamedSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 32: warning: comment on exported type OptionalArgsNamedSequenceCheck should be of the form "OptionalArgsNamedSequenceCheck ..." (with optional leading article) (golint)
    • Line 35: warning: comment on exported method OptionalArgsNamedSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 50: warning: comment on exported type StaticArgsNamedSequenceCheck should be of the form "StaticArgsNamedSequenceCheck ..." (with optional leading article) (golint)
    • Line 53: warning: comment on exported method StaticArgsNamedSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 68: warning: comment on exported type RequiredArgsHaveNoDefaultsSequenceCheck should be of the form "RequiredArgsHaveNoDefaultsSequenceCheck ..." (with optional leading article) (golint)
    • Line 71: warning: comment on exported method RequiredArgsHaveNoDefaultsSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 98: warning: comment on exported type OptionalArgsHaveDefaultsSequenceCheck should be of the form "OptionalArgsHaveDefaultsSequenceCheck ..." (with optional leading article) (golint)
    • Line 101: warning: comment on exported method OptionalArgsHaveDefaultsSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 116: warning: comment on exported type StaticArgsHaveDefaultsSequenceCheck should be of the form "StaticArgsHaveDefaultsSequenceCheck ..." (with optional leading article) (golint)
    • Line 119: warning: comment on exported method StaticArgsHaveDefaultsSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 134: warning: comment on exported type NoDuplicateArgsSequenceCheck should be of the form "NoDuplicateArgsSequenceCheck ..." (with optional leading article) (golint)
    • Line 137: warning: comment on exported method NoDuplicateArgsSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 164: warning: comment on exported type HasNodesSequenceCheck should be of the form "HasNodesSequenceCheck ..." (with optional leading article) (golint)
    • Line 167: warning: comment on exported method HasNodesSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 180: warning: comment on exported type NodesSetsUniqueSequenceCheck should be of the form "NodesSetsUniqueSequenceCheck ..." (with optional leading article) (golint)
    • Line 183: warning: comment on exported method NodesSetsUniqueSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 206: warning: should omit 2nd value from range; this loop is equivalent to `for arg := range ...` (golint)
    • Line 233: warning: comment on exported type ACLAdminXorOpsSequenceCheck should be of the form "ACLAdminXorOpsSequenceCheck ..." (with optional leading article) (golint)
    • Line 236: warning: comment on exported method ACLAdminXorOpsSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 252: warning: comment on exported type ACLsHaveRolesSequenceCheck should be of the form "ACLsHaveRolesSequenceCheck ..." (with optional leading article) (golint)
    • Line 255: warning: comment on exported method ACLsHaveRolesSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)
    • Line 270: warning: comment on exported type NoDuplicateACLRolesSequenceCheck should be of the form "NoDuplicateACLRolesSequenceCheck ..." (with optional leading article) (golint)
    • Line 273: warning: comment on exported method NoDuplicateACLRolesSequenceCheck.CheckSequence should be of the form "CheckSequence ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign98%

IneffAssign detects ineffectual assignments in Go code.


misspell92%

Misspell Finds commonly misspelled English words