Report for github.com/srerickson/bago
A Great! Found 14 issues across 18 files
gofmt88%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
bago/tagfile_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
bago/manifest_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo94%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
bago/bag_create.go
- Line 31: warning: cyclomatic complexity 23 of function CreateBag() is high (> 15) (gocyclo)
golint33%
Golint is a linter for Go source code.
-
-
bago/backend/fs.go
- Line 14: warning: exported method FS.Stat should have comment or be unexported (golint)
- Line 18: warning: exported method FS.Open should have comment or be unexported (golint)
- Line 22: warning: exported method FS.Create should have comment or be unexported (golint)
- Line 26: warning: exported method FS.Walk should have comment or be unexported (golint)
-
-
bago/checksum/checksum.go
- Line 30: warning: exported type Checksumer should have comment or be unexported (golint)
- Line 38: warning: exported type Job should have comment or be unexported (golint)
- Line 46: warning: exported type JobPusher should have comment or be unexported (golint)
- Line 48: warning: exported method Job.SumIsExpected should have comment or be unexported (golint)
- Line 52: warning: exported method Job.SumString should have comment or be unexported (golint)
- Line 56: warning: exported method Job.ExpectedString should have comment or be unexported (golint)
- Line 60: warning: exported function New should have comment or be unexported (golint)
- Line 96: warning: exported method Checksumer.Check should have comment or be unexported (golint)
- Line 116: warning: exported method Checksumer.Results should have comment or be unexported (golint)
- Line 120: warning: exported method Checksumer.PushError should have comment or be unexported (golint)
- Line 124: warning: exported method Checksumer.Cancel should have comment or be unexported (golint)
- Line 133: warning: exported method Checksumer.Canceled should have comment or be unexported (golint)
- Line 142: warning: exported function NormalizeAlgName should have comment or be unexported (golint)
-
-
bago/manifest.go
- Line 28: warning: exported type ManifestEntry should have comment or be unexported (golint)
-
-
bago/profile.go
- Line 5: warning: exported type Profile should have comment or be unexported (golint)
- Line 18: warning: exported type ProfileInfo should have comment or be unexported (golint)
- Line 28: warning: exported type TagOption should have comment or be unexported (golint)
- Line 35: warning: exported method TagOption.UnmarshalJSON should have comment or be unexported (golint)
- Line 45: warning: exported method Profile.UnmarshalJSON should have comment or be unexported (golint)
-
-
bago/bag.go
- Line 36: warning: exported type Payload should have comment or be unexported (golint)
- Line 38: warning: exported type PayloadEntry should have comment or be unexported (golint)
- Line 43: warning: comment on exported method Bag.Hydrate should be of the form "Hydrate ..." (golint)
- Line 70: warning: receiver name b should be consistent with previous receiver name bag for Bag (golint)
- Line 98: warning: comment on exported method Bag.IsValidConcurrent should be of the form "IsValidConcurrent ..." (golint)
- Line 100: warning: receiver name b should be consistent with previous receiver name bag for Bag (golint)
- Line 110: warning: exported method Bag.IsValid should have comment or be unexported (golint)
- Line 110: warning: receiver name b should be consistent with previous receiver name bag for Bag (golint)
- Line 114: warning: exported method Bag.ValidateManifests should have comment or be unexported (golint)
- Line 114: warning: receiver name b should be consistent with previous receiver name bag for Bag (golint)
- Line 152: warning: receiver name b should be consistent with previous receiver name bag for Bag (golint)
- Line 166: warning: receiver name b should be consistent with previous receiver name bag for Bag (golint)
- Line 299: warning: exported method Bag.WritePayloadManifests should have comment or be unexported (golint)
- Line 308: warning: exported method Bag.WriteTagManifests should have comment or be unexported (golint)
- Line 318: warning: exported method Bag.WriteBagitTxt should have comment or be unexported (golint)
- Line 322: warning: exported method Bag.WriteBagInfo should have comment or be unexported (golint)
-
-
bago/bag_create.go
- Line 25: warning: exported function OpenBag should have comment or be unexported (golint)
- Line 30: warning: comment on exported function CreateBag should be of the form "CreateBag ..." (golint)
- Line 130: warning: comment on exported function ManfifestsForDir should be of the form "ManfifestsForDir ..." (golint)
-
-
bago/encoding.go
- Line 15: warning: exported type EncPath should have comment or be unexported (golint)
- Line 16: warning: exported type NormPath should have comment or be unexported (golint)
- Line 28: warning: exported method EncPath.Decode should have comment or be unexported (golint)
- Line 39: warning: exported method EncPath.Norm should have comment or be unexported (golint)
- Line 39: warning: receiver name s should be consistent with previous receiver name p for EncPath (golint)
-
-
bago/tagfile.go
- Line 13: warning: exported type TagSet should have comment or be unexported (golint)
- Line 15: warning: exported type TagFile should have comment or be unexported (golint)
- Line 39: warning: exported method TagFile.Append should have comment or be unexported (golint)
- Line 50: warning: exported method TagFile.Set should have comment or be unexported (golint)
- Line 58: warning: exported function ParseTagFileLine should have comment or be unexported (golint)
-
-
bago/backend/backend.go
- Line 9: warning: exported type Backend should have comment or be unexported (golint)
-
-
bago/cmd/tagflags.go
- Line 9: warning: exported type TagFlags should have comment or be unexported (golint)
-
-
bago/checksum/checksum_test.go
- Line 12: warning: don't use underscores in Go names; var test_path should be testPath (golint)
-
-
bago/test/test.go
- Line 37: warning: comment on exported function Path should be of the form "Path ..." (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell94%
Misspell Finds commonly misspelled English words
-
-
bago/test/test.go
- Line 11: warning: "retuns" is a misspelling of "returns" (misspell)