Preparing report...

Report for github.com/submariner-io/shipyard

A    Great!    Found 21 issues across 23 files

Tweet

gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint8%

Golint is a linter for Go source code.

    • shipyard/test/e2e/e2e.go
    • Line 1: warning: package comment should be of the form "Package e2e ..." (golint)
    • Line 68: warning: exported function RunE2ETests should have comment or be unexported (golint)
    • shipyard/test/e2e/framework/framework.go
    • Line 1: warning: package comment should be of the form "Package framework ..." (golint)
    • Line 27: warning: should not use dot imports (golint)
    • Line 48: warning: comment on exported const PollInterval should be of the form "PollInterval ..." (golint)
    • Line 52: warning: exported type ClusterIndex should have comment or be unexported (golint)
    • Line 55: warning: exported const ClusterA should have comment (or a comment on this block) or be unexported (golint)
    • Line 61: warning: exported const SubmarinerGateway should have comment (or a comment on this block) or be unexported (golint)
    • Line 66: warning: exported type PatchFunc should have comment or be unexported (golint)
    • Line 68: warning: exported type PatchStringValue should have comment or be unexported (golint)
    • Line 74: warning: exported type PatchUInt32Value should have comment or be unexported (golint)
    • Line 80: warning: exported type DoOperationFunc should have comment or be unexported (golint)
    • Line 81: warning: exported type CheckResultFunc should have comment or be unexported (golint)
    • Line 106: warning: exported var RestConfigs should have comment or be unexported (golint)
    • Line 120: warning: exported function AddBeforeSuite should have comment or be unexported (golint)
    • Line 124: warning: exported var By should have comment or be unexported (golint)
    • Line 125: warning: exported var Fail should have comment or be unexported (golint)
    • Line 128: warning: exported function SetStatusFunction should have comment or be unexported (golint)
    • Line 131: warning: exported function SetFailFunction should have comment or be unexported (golint)
    • Line 135: warning: exported function SetUserAgentFunction should have comment or be unexported (golint)
    • Line 151: warning: exported function BeforeSuite should have comment or be unexported (golint)
    • Line 191: warning: exported method Framework.BeforeEach should have comment or be unexported (golint)
    • Line 222: warning: exported function DetectGlobalnet should have comment or be unexported (golint)
    • Line 409: warning: exported method Framework.AddNamespacesToDelete should have comment or be unexported (golint)
    • Line 481: warning: exported function NoopCheckResult should have comment or be unexported (golint)
    • Line 493: warning: exported function AwaitResultOrError should have comment or be unexported (golint)
    • Line 530: warning: exported function NestedString should have comment or be unexported (golint)
    • shipyard/test/e2e/framework/logging.go
    • Line 1: warning: package comment should be of the form "Package framework ..." (golint)
    • Line 36: warning: exported function Errorf should have comment or be unexported (golint)
    • Line 40: warning: exported function Logf should have comment or be unexported (golint)
    • Line 44: warning: exported function Failf should have comment or be unexported (golint)
    • Line 56: warning: exported function Skipf should have comment or be unexported (golint)
    • shipyard/test/e2e/framework/services.go
    • Line 1: warning: package comment should be of the form "Package framework ..." (golint)
    • Line 33: warning: exported const TestAppLabel should have comment (or a comment on this block) or be unexported (golint)
    • Line 36: warning: exported method Framework.CreateTCPService should have comment or be unexported (golint)
    • Line 71: warning: exported method Framework.NewNginxService should have comment or be unexported (golint)
    • Line 117: warning: exported method Framework.DeleteService should have comment or be unexported (golint)
    • shipyard/test/e2e/framework/util.go
    • Line 1: warning: package comment should be of the form "Package framework ..." (golint)
    • Line 23: warning: should not use dot imports (golint)
    • Line 24: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 41: warning: exported function ExpectNoError should have comment or be unexported (golint)
    • shipyard/test/e2e/framework/test_context.go
    • Line 1: warning: package comment should be of the form "Package framework ..." (golint)
    • Line 31: warning: exported type TestContextType should have comment or be unexported (golint)
    • Line 57: warning: exported var TestContext should have comment or be unexported (golint)
    • Line 75: warning: exported function ValidateFlags should have comment or be unexported (golint)
    • shipyard/test/e2e/tcp/connectivity.go
    • Line 1: warning: package comment should be of the form "Package tcp ..." (golint)
    • Line 23: warning: should not use dot imports (golint)
    • Line 24: warning: should not use dot imports (golint)
    • Line 31: warning: exported type EndpointType should have comment or be unexported (golint)
    • Line 34: warning: exported const PodIP should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: exported type ConnectivityTestParams should have comment or be unexported (golint)
    • Line 51: warning: exported function RunConnectivityTest should have comment or be unexported (golint)
    • Line 95: warning: exported function RunNoConnectivityTest should have comment or be unexported (golint)
    • shipyard/test/e2e/framework/deployments.go
    • Line 1: warning: package comment should be of the form "Package framework ..." (golint)
    • Line 24: warning: should not use dot imports (golint)
    • Line 30: warning: exported method Framework.FindDeployment should have comment or be unexported (golint)
    • Line 42: warning: exported method Framework.NewNetShootDeployment should have comment or be unexported (golint)
    • Line 84: warning: exported method Framework.NewNginxDeployment should have comment or be unexported (golint)
    • shipyard/test/e2e/framework/docker.go
    • Line 27: warning: should not use dot imports (golint)
    • Line 30: warning: exported type Docker should have comment or be unexported (golint)
    • Line 34: warning: exported function New should have comment or be unexported (golint)
    • Line 38: warning: exported method Docker.GetIP should have comment or be unexported (golint)
    • Line 53: warning: exported method Docker.GetLog should have comment or be unexported (golint)
    • Line 67: warning: exported method Docker.RunCommand should have comment or be unexported (golint)
    • shipyard/test/e2e/framework/gateways.go
    • Line 1: warning: package comment should be of the form "Package framework ..." (golint)
    • Line 25: warning: should not use dot imports (golint)
    • Line 39: warning: exported method Framework.AwaitGatewayWithStatus should have comment or be unexported (golint)
    • Line 70: warning: exported method Framework.AwaitGatewaysWithStatus should have comment or be unexported (golint)
    • Line 87: warning: exported method Framework.AwaitGatewayRemoved should have comment or be unexported (golint)
    • Line 103: warning: exported method Framework.AwaitGatewayFullyConnected should have comment or be unexported (golint)
    • Line 145: warning: exported method Framework.GetGatewaysWithHAStatus should have comment or be unexported (golint)
    • Line 169: warning: exported method Framework.DeleteGateway should have comment or be unexported (golint)
    • shipyard/test/e2e/framework/network_pods.go
    • Line 1: warning: package comment should be of the form "Package framework ..." (golint)
    • Line 34: warning: should not use dot imports (golint)
    • Line 37: warning: exported type NetworkingType should have comment or be unexported (golint)
    • Line 40: warning: exported const HostNetworking should have comment (or a comment on this block) or be unexported (golint)
    • Line 44: warning: exported type NetworkPodType should have comment or be unexported (golint)
    • Line 47: warning: exported const InvalidPodType should have comment (or a comment on this block) or be unexported (golint)
    • Line 57: warning: exported type NetworkPodScheduling should have comment or be unexported (golint)
    • Line 60: warning: exported const InvalidScheduling should have comment (or a comment on this block) or be unexported (golint)
    • Line 65: warning: exported type NetworkPodConfig should have comment or be unexported (golint)
    • Line 81: warning: exported type NetworkPod should have comment or be unexported (golint)
    • Line 92: warning: exported const TestPort should have comment (or a comment on this block) or be unexported (golint)
    • Line 95: warning: exported method Framework.NewNetworkPod should have comment or be unexported (golint)
    • Line 132: warning: exported method NetworkPod.AwaitReady should have comment or be unexported (golint)
    • Line 150: warning: exported method NetworkPod.AwaitFinish should have comment or be unexported (golint)
    • Line 154: warning: exported method NetworkPod.AwaitFinishVerbose should have comment or be unexported (golint)
    • Line 183: warning: exported method NetworkPod.CheckSuccessfulFinish should have comment or be unexported (golint)
    • Line 188: warning: exported method NetworkPod.CreateService should have comment or be unexported (golint)
    • shipyard/test/e2e/framework/service_exports.go
    • Line 1: warning: package comment should be of the form "Package framework ..." (golint)
    • Line 37: warning: exported method Framework.CreateServiceExport should have comment or be unexported (golint)
    • Line 55: warning: exported method Framework.DeleteServiceExport should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!