gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• tdex-daemon/cmd/tdex/fragmentmarket.go
  • Line 70: warning: cyclomatic complexity 21 of function fragmentMarketAction() is high (> 15) (gocyclo)
  • Line 396: warning: cyclomatic complexity 17 of function craftTransaction() is high (> 15) (gocyclo)

• tdex-daemon/cmd/tdex/fragmentfee.go
  • Line 43: warning: cyclomatic complexity 19 of function fragmentFeeAction() is high (> 15) (gocyclo)

• tdex-daemon/test/e2e/main.go
  • Line 49: warning: cyclomatic complexity 23 of function main() is high (> 15) (gocyclo)

• tdex-daemon/internal/core/application/trade_service.go
  • Line 283: warning: cyclomatic complexity 22 of function (*tradeService).TradePropose() is high (> 15) (gocyclo)

• tdex-daemon/internal/core/application/operator_service.go
  • Line 707: warning: cyclomatic complexity 21 of function (*operatorService).WithdrawMarketFunds() is high (> 15) (gocyclo)
  • Line 136: warning: cyclomatic complexity 16 of function (*operatorService).DepositMarket() is high (> 15) (gocyclo)
  • Line 1008: warning: cyclomatic complexity 16 of function (*operatorService).claimDeposit() is high (> 15) (gocyclo)

• tdex-daemon/internal/core/application/wallet_service.go
  • Line 160: warning: cyclomatic complexity 19 of function (*walletService).InitWallet() is high (> 15) (gocyclo)
  • Line 400: warning: cyclomatic complexity 18 of function (*walletService).SendToMany() is high (> 15) (gocyclo)

• tdex-daemon/pkg/wallet/transaction.go
  • Line 295: warning: cyclomatic complexity 22 of function (*Wallet).UpdateTx() is high (> 15) (gocyclo)
  • Line 36: warning: cyclomatic complexity 21 of function (UpdateSwapTxOpts).validate() is high (> 15) (gocyclo)

• tdex-daemon/pkg/wallet/util.go
  • Line 164: warning: cyclomatic complexity 16 of function extractScriptTypesFromPset() is high (> 15) (gocyclo)

golint77%

Golint is a linter for Go source code.

• tdex-daemon/pkg/crawler/observable.go
  • Line 16: warning: exported const New should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported type Status should have comment or be unexported (golint)
  • Line 28: warning: exported function NewObservableStatus should have comment or be unexported (golint)
  • Line 46: warning: exported type AddressObservable should have comment or be unexported (golint)
  • Line 97: warning: exported type TransactionObservable should have comment or be unexported (golint)

• tdex-daemon/pkg/explorer/esplora/client.go
  • Line 12: warning: exported type Client should have comment or be unexported (golint)
  • Line 16: warning: exported function NewHTTPClient should have comment or be unexported (golint)

• tdex-daemon/pkg/wallet/blind.go
  • Line 193: warning: exported type BlindingData should have comment or be unexported (golint)
  • Line 214: warning: exported method BlindingData.ToBlindingData should have comment or be unexported (golint)

• tdex-daemon/pkg/wallet/estimation.go
  • Line 4: warning: exported const P2PK should have comment (or a comment on this block) or be unexported (golint)

• tdex-daemon/pkg/wallet/mnemonic.go
  • Line 3: warning: exported type NewMnemonicOpts should have comment or be unexported (golint)

• tdex-daemon/pkg/crawler/event.go
  • Line 6: warning: exported const CloseSignal should have comment (or a comment on this block) or be unexported (golint)
  • Line 13: warning: exported type EventType should have comment or be unexported (golint)
  • Line 32: warning: exported type CloseEvent should have comment or be unexported (golint)
  • Line 34: warning: exported method CloseEvent.Type should have comment or be unexported (golint)
  • Line 38: warning: exported type AddressEvent should have comment or be unexported (golint)
  • Line 45: warning: exported method AddressEvent.Type should have comment or be unexported (golint)
  • Line 49: warning: exported type TransactionEvent should have comment or be unexported (golint)
  • Line 57: warning: exported method TransactionEvent.Type should have comment or be unexported (golint)

• tdex-daemon/cmd/tdex/fragmentmarket.go
  • Line 26: warning: exported const MinMilliSatPerByte should have comment (or a comment on this block) or be unexported (golint)
  • Line 56: warning: exported type AssetValuePair should have comment or be unexported (golint)
  • Line 518: warning: exported type TxOut should have comment or be unexported (golint)

• tdex-daemon/internal/core/application/types.go
  • Line 27: warning: exported type SwapFailInfo should have comment or be unexported (golint)
  • Line 58: warning: exported type Market should have comment or be unexported (golint)
  • Line 63: warning: exported type Fee should have comment or be unexported (golint)
  • Line 69: warning: exported type MarketWithFee should have comment or be unexported (golint)
  • Line 74: warning: exported type MarketWithPrice should have comment or be unexported (golint)
  • Line 79: warning: exported type Price should have comment or be unexported (golint)
  • Line 84: warning: exported type PriceWithFee should have comment or be unexported (golint)
  • Line 92: warning: exported type MarketStrategy should have comment or be unexported (golint)
  • Line 97: warning: exported type Balance should have comment or be unexported (golint)
  • Line 102: warning: exported type BalanceWithFee should have comment or be unexported (golint)
  • Line 107: warning: exported type BalanceInfo should have comment or be unexported (golint)
  • Line 113: warning: exported type WithdrawMarketReq should have comment or be unexported (golint)
  • Line 121: warning: exported type ReportMarketFee should have comment or be unexported (golint)
  • Line 126: warning: exported type AddressAndBlindingKey should have comment or be unexported (golint)
  • Line 131: warning: exported type FeeInfo should have comment or be unexported (golint)
  • Line 139: warning: exported type TxOutpoint should have comment or be unexported (golint)
  • Line 144: warning: exported type UtxoInfoList should have comment or be unexported (golint)
  • Line 150: warning: exported type UtxoInfo should have comment or be unexported (golint)
  • Line 156: warning: exported type Unspents should have comment or be unexported (golint)
  • Line 158: warning: exported method Unspents.ToUtxos should have comment or be unexported (golint)
  • Line 166: warning: exported type UnblindedResult should have comment or be unexported (golint)
  • Line 167: warning: exported type BlindingData should have comment or be unexported (golint)
  • Line 169: warning: exported type Blinder should have comment or be unexported (golint)
  • Line 173: warning: exported type FillProposalOpts should have comment or be unexported (golint)
  • Line 186: warning: exported type FillProposalResult should have comment or be unexported (golint)
  • Line 192: warning: exported type TradeHandler should have comment or be unexported (golint)
  • Line 196: warning: exported type TransactionHandler should have comment or be unexported (golint)
  • Line 209: warning: exported var BlinderManager should have comment or be unexported (golint)

• tdex-daemon/internal/interfaces/grpc/handler/wallet.go
  • Line 20: warning: exported function NewWalletHandler should have comment or be unexported (golint)

• tdex-daemon/internal/interfaces/grpc/handler/trade.go
  • Line 18: warning: exported const ErrCannotServeRequest should have comment or be unexported (golint)
  • Line 25: warning: exported function NewTraderHandler should have comment or be unexported (golint)

• tdex-daemon/internal/infrastructure/storage/db/badger/db_manager.go
  • Line 119: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 138: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 158: warning: should not use basic type string as key in context.WithValue (golint)

• tdex-daemon/pkg/trade/type/type.go
  • Line 21: warning: exported type TradeType should have comment or be unexported (golint)

• tdex-daemon/internal/infrastructure/storage/db/badger/trade_repository_impl.go
  • Line 13: warning: exported const TradeBadgerholdKeyPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported function NewTradeRepositoryImpl should have comment or be unexported (golint)

• tdex-daemon/pkg/swap/fail.go
  • Line 11: warning: exported type ErrCode should have comment or be unexported (golint)
  • Line 14: warning: exported const ErrCodeInvalidSwapRequest should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported type FailOpts should have comment or be unexported (golint)
  • Line 31: warning: exported function Fail should have comment or be unexported (golint)

• tdex-daemon/pkg/stats/stats.go
  • Line 16: warning: exported const BYTE should have comment (or a comment on this block) or be unexported (golint)

• tdex-daemon/pkg/explorer/esplora/types.go
  • Line 37: warning: exported function NewTxFromHex should have comment or be unexported (golint)

• tdex-daemon/internal/core/application/wallet_service.go
  • Line 37: warning: exported type WalletService should have comment or be unexported (golint)
  • Line 81: warning: exported function NewWalletService should have comment or be unexported (golint)
  • Line 153: warning: exported type InitWalletReply should have comment or be unexported (golint)
  • Line 388: warning: exported type SendToManyRequest should have comment or be unexported (golint)
  • Line 394: warning: exported type TxOut should have comment or be unexported (golint)

• tdex-daemon/pkg/trade/market/market.go
  • Line 8: warning: exported type Market should have comment or be unexported (golint)

• tdex-daemon/pkg/marketmaking/formula/balanced_reserves.go
  • Line 15: warning: exported const BalancedReservesType should have comment (or a comment on this block) or be unexported (golint)
  • Line 111: warning: exported method BalancedReserves.FormulaType should have comment or be unexported (golint)

• tdex-daemon/internal/infrastructure/storage/db/inmemory/db_manager.go
  • Line 36: warning: exported type RepoManager should have comment or be unexported (golint)
  • Line 48: warning: exported type InmemoryTx should have comment or be unexported (golint)
  • Line 53: warning: exported method InmemoryTx.Commit should have comment or be unexported (golint)
  • Line 61: warning: exported method InmemoryTx.Discard should have comment or be unexported (golint)
  • Line 65: warning: exported function NewRepoManager should have comment or be unexported (golint)
  • Line 103: warning: exported method RepoManager.MarketRepository should have comment or be unexported (golint)
  • Line 107: warning: exported method RepoManager.UnspentRepository should have comment or be unexported (golint)
  • Line 111: warning: exported method RepoManager.TradeRepository should have comment or be unexported (golint)
  • Line 115: warning: exported method RepoManager.VaultRepository should have comment or be unexported (golint)
  • Line 119: warning: exported method RepoManager.Close should have comment or be unexported (golint)
  • Line 121: warning: exported method RepoManager.NewTransaction should have comment or be unexported (golint)
  • Line 121: warning: receiver name db should be consistent with previous receiver name d for RepoManager (golint)
  • Line 128: warning: exported method RepoManager.NewUnspentsTransaction should have comment or be unexported (golint)
  • Line 128: warning: receiver name db should be consistent with previous receiver name d for RepoManager (golint)
  • Line 132: warning: exported method RepoManager.NewPricesTransaction should have comment or be unexported (golint)
  • Line 132: warning: receiver name db should be consistent with previous receiver name d for RepoManager (golint)
  • Line 136: warning: exported method RepoManager.RunTransaction should have comment or be unexported (golint)
  • Line 136: warning: receiver name db should be consistent with previous receiver name d for RepoManager (golint)
  • Line 144: warning: exported method RepoManager.RunUnspentsTransaction should have comment or be unexported (golint)
  • Line 144: warning: receiver name db should be consistent with previous receiver name d for RepoManager (golint)
  • Line 152: warning: exported method RepoManager.RunPricesTransaction should have comment or be unexported (golint)
  • Line 152: warning: receiver name db should be consistent with previous receiver name d for RepoManager (golint)
  • Line 160: warning: receiver name db should be consistent with previous receiver name d for RepoManager (golint)

• tdex-daemon/internal/infrastructure/storage/db/inmemory/market_memory_repository_impl.go
  • Line 160: warning: exported method MarketRepositoryImpl.UpdatePrices should have comment or be unexported (golint)
  • Line 182: warning: exported method MarketRepositoryImpl.DeleteMarket should have comment or be unexported (golint)

• tdex-daemon/internal/core/domain/unspent_service.go
  • Line 70: warning: exported method Unspent.ToOutpointWithAsset should have comment or be unexported (golint)

• tdex-daemon/pkg/trade/wallet.go
  • Line 17: warning: exported function NewSwapTx should have comment or be unexported (golint)
  • Line 67: warning: exported type Wallet should have comment or be unexported (golint)
  • Line 73: warning: exported function NewRandomWallet should have comment or be unexported (golint)
  • Line 86: warning: exported function NewWalletFromKey should have comment or be unexported (golint)
  • Line 93: warning: exported method Wallet.Address should have comment or be unexported (golint)
  • Line 99: warning: exported method Wallet.Script should have comment or be unexported (golint)
  • Line 104: warning: exported method Wallet.Sign should have comment or be unexported (golint)
  • Line 150: warning: exported method Wallet.PrivateKey should have comment or be unexported (golint)
  • Line 154: warning: exported method Wallet.BlindingKey should have comment or be unexported (golint)

• tdex-daemon/pkg/bufferutil/bufferutil.go
  • Line 9: warning: exported function AssetHashFromBytes should have comment or be unexported (golint)
  • Line 14: warning: exported function AssetHashToBytes should have comment or be unexported (golint)
  • Line 24: warning: exported function ValueFromBytes should have comment or be unexported (golint)
  • Line 29: warning: exported function ValueToBytes should have comment or be unexported (golint)
  • Line 33: warning: exported function TxIDFromBytes should have comment or be unexported (golint)
  • Line 37: warning: exported function TxIDToBytes should have comment or be unexported (golint)
  • Line 45: warning: exported function CommitmentFromBytes should have comment or be unexported (golint)
  • Line 49: warning: exported function CommitmentToBytes should have comment or be unexported (golint)

• tdex-daemon/pkg/transactionutil/transactionutil.go
  • Line 15: warning: exported type UnblindedResult should have comment or be unexported (golint)
  • Line 22: warning: exported function UnblindOutput should have comment or be unexported (golint)
  • Line 47: warning: exported function NewFeeOutput should have comment or be unexported (golint)
  • Line 56: warning: exported function GetTxIdFromPset should have comment or be unexported (golint)

• tdex-daemon/internal/core/domain/market_model.go
  • Line 9: warning: exported type FixedFee should have comment or be unexported (golint)

• tdex-daemon/internal/core/application/constants.go
  • Line 4: warning: exported const TradeBuy should have comment (or a comment on this block) or be unexported (golint)
  • Line 9: warning: exported const Processing should have comment (or a comment on this block) or be unexported (golint)

• tdex-daemon/pkg/explorer/elements/types.go
  • Line 25: warning: exported function NewTxFromHex should have comment or be unexported (golint)
  • Line 43: warning: exported function NewTxFromJSON should have comment or be unexported (golint)

• tdex-daemon/internal/infrastructure/storage/db/inmemory/vault_memory_implementation.go
  • Line 21: warning: exported method VaultRepositoryImpl.GetOrCreateVault should have comment or be unexported (golint)
  • Line 33: warning: exported method VaultRepositoryImpl.GetAllDerivedExternalAddressesInfoForAccount should have comment or be unexported (golint)
  • Line 71: warning: exported method VaultRepositoryImpl.GetAccountByIndex should have comment or be unexported (golint)
  • Line 79: warning: exported method VaultRepositoryImpl.GetAccountByAddress should have comment or be unexported (golint)
  • Line 89: warning: exported method VaultRepositoryImpl.GetAllDerivedAddressesInfoForAccount should have comment or be unexported (golint)
  • Line 99: warning: exported method VaultRepositoryImpl.GetDerivationPathByScript should have comment or be unexported (golint)

• tdex-daemon/cmd/tdex/fragmentfee.go
  • Line 26: warning: exported const MinFee should have comment (or a comment on this block) or be unexported (golint)

• tdex-daemon/internal/core/application/trade_service.go
  • Line 25: warning: exported type TradeService should have comment or be unexported (golint)
  • Line 61: warning: exported function NewTradeService should have comment or be unexported (golint)

• tdex-daemon/pkg/trade/trade.go
  • Line 26: warning: exported type Trade should have comment or be unexported (golint)

• tdex-daemon/internal/infrastructure/storage/db/badger/vault_repository_impl.go
  • Line 23: warning: exported function NewVaultRepositoryImpl should have comment or be unexported (golint)

• tdex-daemon/internal/core/domain/constants.go
  • Line 4: warning: exported const FeeAccount should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported const Empty should have comment (or a comment on this block) or be unexported (golint)

• tdex-daemon/internal/core/domain/vault_model.go
  • Line 12: warning: exported type AccountAndKey should have comment or be unexported (golint)
  • Line 17: warning: exported type Vault should have comment or be unexported (golint)
  • Line 34: warning: exported type AddressInfo should have comment or be unexported (golint)
  • Line 42: warning: exported type AddressesInfo should have comment or be unexported (golint)
  • Line 44: warning: exported method AddressesInfo.Addresses should have comment or be unexported (golint)
  • Line 52: warning: exported method AddressesInfo.AddressesAndKeys should have comment or be unexported (golint)

• tdex-daemon/internal/infrastructure/storage/db/badger/unspent_repository_impl.go
  • Line 13: warning: exported const UnspentBadgerholdKeyPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported function NewUnspentRepositoryImpl should have comment or be unexported (golint)
  • Line 468: warning: exported type LockedUnspent should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign94%

IneffAssign detects ineffectual assignments in Go code.

• tdex-daemon/pkg/trade/buy.go
  • Line 191: warning: ineffectual assignment to err (ineffassign)

• tdex-daemon/pkg/wallet/cypher_test.go
  • Line 30: warning: ineffectual assignment to err (ineffassign)

• tdex-daemon/internal/infrastructure/storage/db/inmemory/market_memory_repository_impl.go
  • Line 199: warning: ineffectual assignment to err (ineffassign)

• tdex-daemon/pkg/trade/wallet.go
  • Line 137: warning: ineffectual assignment to err (ineffassign)

• tdex-daemon/pkg/swap/complete.go
  • Line 110: warning: ineffectual assignment to err (ineffassign)

• tdex-daemon/pkg/swap/swap.go
  • Line 66: warning: ineffectual assignment to err (ineffassign)

• tdex-daemon/pkg/explorer/esplora/types.go
  • Line 110: warning: ineffectual assignment to asset (ineffassign)
  • Line 117: warning: ineffectual assignment to value (ineffassign)

• tdex-daemon/pkg/explorer/elements/unspents_test.go
  • Line 68: warning: ineffectual assignment to err (ineffassign)

• tdex-daemon/pkg/wallet/wallet.go
  • Line 91: warning: ineffectual assignment to blindingSeed (ineffassign)
  • Line 92: warning: ineffectual assignment to blindingMasterKey (ineffassign)

misspell92%

Misspell Finds commonly misspelled English words

• tdex-daemon/internal/infrastructure/storage/db/badger/db_manager.go
  • Line 202: warning: "occured" is a misspelling of "occurred" (misspell)
  • Line 202: warning: "commiting" is a misspelling of "committing" (misspell)

• tdex-daemon/internal/infrastructure/storage/db/badger/market_repository_impl.go
  • Line 285: warning: "wich" is a misspelling of "which" (misspell)
  • Line 286: warning: "beacuse" is a misspelling of "because" (misspell)
  • Line 327: warning: "startegy" is a misspelling of "strategy" (misspell)

• tdex-daemon/internal/core/application/trade_service.go
  • Line 661: warning: "occured" is a misspelling of "occurred" (misspell)

• tdex-daemon/pkg/wallet/derivation_path.go
  • Line 58: warning: "convertion" is a misspelling of "conversion" (misspell)

• tdex-daemon/pkg/swap/swap.go
  • Line 95: warning: "criterias" is a misspelling of "criteria" (misspell)

• tdex-daemon/internal/infrastructure/storage/db/test/market_repository_impl_test.go
  • Line 316: warning: "somehting" is a misspelling of "something" (misspell)

• tdex-daemon/pkg/crawler/service.go
  • Line 40: warning: "activites" is a misspelling of "activities" (misspell)

• tdex-daemon/cmd/tdex/fragmentfee.go
  • Line 104: warning: "occured" is a misspelling of "occurred" (misspell)

• tdex-daemon/cmd/tdex/fragmentmarket.go
  • Line 130: warning: "occured" is a misspelling of "occurred" (misspell)
  • Line 192: warning: "braodcast" is a misspelling of "broadcast" (misspell)

• tdex-daemon/internal/infrastructure/storage/db/inmemory/market_memory_repository_impl.go
  • Line 233: warning: "becuase" is a misspelling of "because" (misspell)

• tdex-daemon/internal/core/application/wallet_service.go
  • Line 183: warning: "availble" is a misspelling of "available" (misspell)
  • Line 1197: warning: "occured" is a misspelling of "occurred" (misspell)
  • Line 1212: warning: "occured" is a misspelling of "occurred" (misspell)

• tdex-daemon/pkg/wallet/blind.go
  • Line 147: warning: "transaciton" is a misspelling of "transactions" (misspell)