gofmt91%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• rsk-core/core/block_validator_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/bloom_indexer.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/genesis_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/tx_pool.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/state_transition.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/blockchain_repair_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/blockchain_sethead_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/chain_makers_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/headerchain_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/state_processor_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/bench_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/blockchain_snapshot_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/dao_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/rlp_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/miner/stress_clique.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/miner/worker_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/chain_indexer_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/chain_makers.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/crypto/bls12381/bls12_381.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/block_validator.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/evm.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/genesis.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/headerchain.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/miner/stress_ethash.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/blockchain_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/chain_indexer.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/tx_pool_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/types.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/miner/worker.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/blockchain.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/core/state_prefetcher.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/crypto/bls12381/isogeny.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/miner/miner.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rsk-core/miner/miner_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo85%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• rsk-core/consensus/clique/snapshot.go
  • Line 185: warning: cyclomatic complexity 28 of function (*Snapshot).apply() is high (> 15) (gocyclo)

• rsk-core/ethdb/dbtest/testsuite.go
  • Line 30: warning: cyclomatic complexity 45 of function TestDatabaseSuite() is high (> 15) (gocyclo)

• rsk-core/core/state/snapshot/snapshot.go
  • Line 449: warning: cyclomatic complexity 22 of function diffToDisk() is high (> 15) (gocyclo)

• rsk-core/eth/filters/filter_system.go
  • Line 443: warning: cyclomatic complexity 16 of function (*EventSystem).eventLoop() is high (> 15) (gocyclo)

• rsk-core/eth/protocols/eth/handler_test.go
  • Line 357: warning: cyclomatic complexity 22 of function testGetNodeData() is high (> 15) (gocyclo)

• rsk-core/core/dao_test.go
  • Line 31: warning: cyclomatic complexity 22 of function TestDAOForkRangeExtradata() is high (> 15) (gocyclo)

• rsk-core/core/blockchain_sethead_test.go
  • Line 56: warning: cyclomatic complexity 20 of function (*rewindTest).dump() is high (> 15) (gocyclo)
  • Line 1952: warning: cyclomatic complexity 20 of function testSetHead() is high (> 15) (gocyclo)
  • Line 2062: warning: cyclomatic complexity 19 of function verifyNoGaps() is high (> 15) (gocyclo)

• rsk-core/core/state/state_test.go
  • Line 206: warning: cyclomatic complexity 17 of function compareStateObjects() is high (> 15) (gocyclo)

• rsk-core/core/state/snapshot/iterator_test.go
  • Line 402: warning: cyclomatic complexity 17 of function TestStorageIteratorTraversalValues() is high (> 15) (gocyclo)
  • Line 308: warning: cyclomatic complexity 17 of function TestAccountIteratorTraversalValues() is high (> 15) (gocyclo)

• rsk-core/eth/filters/api_test.go
  • Line 28: warning: cyclomatic complexity 40 of function TestUnmarshalJSONNewFilterArgs() is high (> 15) (gocyclo)

• rsk-core/eth/filters/filter_test.go
  • Line 98: warning: cyclomatic complexity 18 of function TestFilters() is high (> 15) (gocyclo)

• rsk-core/core/blockchain_test.go
  • Line 2072: warning: cyclomatic complexity 28 of function TestTransactionIndices() is high (> 15) (gocyclo)
  • Line 591: warning: cyclomatic complexity 28 of function TestFastVsFullChains() is high (> 15) (gocyclo)
  • Line 2199: warning: cyclomatic complexity 21 of function TestSkipStaleTxIndicesInFastSync() is high (> 15) (gocyclo)
  • Line 2725: warning: cyclomatic complexity 19 of function TestDeleteRecreateSlotsAcrossManyBlocks() is high (> 15) (gocyclo)
  • Line 1831: warning: cyclomatic complexity 18 of function testInsertKnownChainData() is high (> 15) (gocyclo)
  • Line 377: warning: cyclomatic complexity 17 of function testReorg() is high (> 15) (gocyclo)
  • Line 823: warning: cyclomatic complexity 17 of function TestChainTxReorgs() is high (> 15) (gocyclo)
  • Line 1258: warning: cyclomatic complexity 17 of function TestEIP155Transition() is high (> 15) (gocyclo)

• rsk-core/core/state/pruner/pruner.go
  • Line 216: warning: cyclomatic complexity 19 of function (*Pruner).Prune() is high (> 15) (gocyclo)
  • Line 116: warning: cyclomatic complexity 16 of function prune() is high (> 15) (gocyclo)

• rsk-core/core/vm/interpreter.go
  • Line 140: warning: cyclomatic complexity 33 of function (*EVMInterpreter).Run() is high (> 15) (gocyclo)

• rsk-core/internal/jsre/jsre.go
  • Line 106: warning: cyclomatic complexity 19 of function (*JSRE).runEventLoop() is high (> 15) (gocyclo)

• rsk-core/internal/jsre/pretty.go
  • Line 122: warning: cyclomatic complexity 18 of function (ppctx).printObject() is high (> 15) (gocyclo)

• rsk-core/core/bloombits/matcher.go
  • Line 259: warning: cyclomatic complexity 30 of function (*Matcher).subMatch() is high (> 15) (gocyclo)
  • Line 381: warning: cyclomatic complexity 24 of function (*Matcher).distributor() is high (> 15) (gocyclo)

• rsk-core/eth/tracers/api.go
  • Line 228: warning: cyclomatic complexity 27 of function (*API).traceChain() is high (> 15) (gocyclo)
  • Line 546: warning: cyclomatic complexity 22 of function (*API).standardTraceBlockToFile() is high (> 15) (gocyclo)

• rsk-core/core/tx_pool.go
  • Line 1279: warning: cyclomatic complexity 21 of function (*TxPool).truncatePending() is high (> 15) (gocyclo)
  • Line 579: warning: cyclomatic complexity 18 of function (*TxPool).add() is high (> 15) (gocyclo)
  • Line 320: warning: cyclomatic complexity 17 of function (*TxPool).loop() is high (> 15) (gocyclo)

• rsk-core/core/blockchain_repair_test.go
  • Line 1753: warning: cyclomatic complexity 20 of function testRepair() is high (> 15) (gocyclo)

• rsk-core/core/state/snapshot/wipe_test.go
  • Line 30: warning: cyclomatic complexity 21 of function TestWipe() is high (> 15) (gocyclo)

• rsk-core/core/vm/evm.go
  • Line 436: warning: cyclomatic complexity 25 of function (*EVM).create() is high (> 15) (gocyclo)
  • Line 223: warning: cyclomatic complexity 18 of function (*EVM).Call() is high (> 15) (gocyclo)

• rsk-core/eth/downloader/downloader.go
  • Line 1349: warning: cyclomatic complexity 44 of function (*Downloader).fetchParts() is high (> 15) (gocyclo)
  • Line 1524: warning: cyclomatic complexity 44 of function (*Downloader).processHeaders() is high (> 15) (gocyclo)
  • Line 1011: warning: cyclomatic complexity 42 of function (*Downloader).fetchHeaders() is high (> 15) (gocyclo)
  • Line 451: warning: cyclomatic complexity 26 of function (*Downloader).syncWithPeer() is high (> 15) (gocyclo)
  • Line 1751: warning: cyclomatic complexity 23 of function (*Downloader).processFastSyncContent() is high (> 15) (gocyclo)
  • Line 836: warning: cyclomatic complexity 20 of function (*Downloader).findAncestorSpanSearch() is high (> 15) (gocyclo)
  • Line 369: warning: cyclomatic complexity 19 of function (*Downloader).synchronise() is high (> 15) (gocyclo)
  • Line 650: warning: cyclomatic complexity 18 of function (*Downloader).fetchHead() is high (> 15) (gocyclo)
  • Line 920: warning: cyclomatic complexity 17 of function (*Downloader).findAncestorBinarySearch() is high (> 15) (gocyclo)

• rsk-core/core/blockchain.go
  • Line 1134: warning: cyclomatic complexity 65 of function (*BlockChain).InsertReceiptChain() is high (> 15) (gocyclo)
  • Line 1704: warning: cyclomatic complexity 49 of function (*BlockChain).insertChain() is high (> 15) (gocyclo)
  • Line 218: warning: cyclomatic complexity 35 of function NewBlockChain() is high (> 15) (gocyclo)
  • Line 2128: warning: cyclomatic complexity 33 of function (*BlockChain).reorg() is high (> 15) (gocyclo)
  • Line 1503: warning: cyclomatic complexity 29 of function (*BlockChain).writeBlockWithState() is high (> 15) (gocyclo)
  • Line 492: warning: cyclomatic complexity 23 of function (*BlockChain).SetHeadBeyondRoot() is high (> 15) (gocyclo)
  • Line 2008: warning: cyclomatic complexity 21 of function (*BlockChain).insertSideChain() is high (> 15) (gocyclo)
  • Line 2316: warning: cyclomatic complexity 18 of function (*BlockChain).maintainTxIndex() is high (> 15) (gocyclo)

• rsk-core/core/state/snapshot/conversion.go
  • Line 245: warning: cyclomatic complexity 22 of function generateTrieRoot() is high (> 15) (gocyclo)

• rsk-core/miner/worker_test.go
  • Line 434: warning: cyclomatic complexity 16 of function testAdjustInterval() is high (> 15) (gocyclo)

• rsk-core/eth/downloader/statesync.go
  • Line 522: warning: cyclomatic complexity 16 of function (*stateSync).process() is high (> 15) (gocyclo)

• rsk-core/core/rawdb/database.go
  • Line 278: warning: cyclomatic complexity 47 of function InspectDatabase() is high (> 15) (gocyclo)

• rsk-core/ethdb/leveldb/leveldb.go
  • Line 260: warning: cyclomatic complexity 41 of function (*Database).meter() is high (> 15) (gocyclo)

• rsk-core/eth/fetcher/tx_fetcher_test.go
  • Line 1253: warning: cyclomatic complexity 87 of function testTransactionFetcher() is high (> 15) (gocyclo)

• rsk-core/internal/ethapi/api.go
  • Line 944: warning: cyclomatic complexity 27 of function DoEstimateGas() is high (> 15) (gocyclo)
  • Line 1505: warning: cyclomatic complexity 17 of function (*SendTxArgs).setDefaults() is high (> 15) (gocyclo)
  • Line 1780: warning: cyclomatic complexity 17 of function (*PublicTransactionPoolAPI).Resend() is high (> 15) (gocyclo)
  • Line 815: warning: cyclomatic complexity 17 of function DoCall() is high (> 15) (gocyclo)

• rsk-core/core/state/statedb.go
  • Line 913: warning: cyclomatic complexity 19 of function (*StateDB).Commit() is high (> 15) (gocyclo)
  • Line 661: warning: cyclomatic complexity 16 of function (*StateDB).Copy() is high (> 15) (gocyclo)

• rsk-core/core/state/state_object.go
  • Line 195: warning: cyclomatic complexity 16 of function (*stateObject).GetCommittedState() is high (> 15) (gocyclo)

• rsk-core/core/state/snapshot/generate.go
  • Line 166: warning: cyclomatic complexity 32 of function (*diskLayer).generate() is high (> 15) (gocyclo)

• rsk-core/eth/downloader/downloader_test.go
  • Line 1049: warning: cyclomatic complexity 16 of function testInvalidHeaderRollback() is high (> 15) (gocyclo)

• rsk-core/rpc/subscription_test.go
  • Line 49: warning: cyclomatic complexity 16 of function TestSubscriptions() is high (> 15) (gocyclo)

• rsk-core/core/state/sync_test.go
  • Line 401: warning: cyclomatic complexity 17 of function TestIncompleteStateSync() is high (> 15) (gocyclo)
  • Line 163: warning: cyclomatic complexity 17 of function testIterativeStateSync() is high (> 15) (gocyclo)

• rsk-core/core/rawdb/freezer_table.go
  • Line 204: warning: cyclomatic complexity 19 of function (*freezerTable).repair() is high (> 15) (gocyclo)

• rsk-core/core/state/snapshot/disklayer_test.go
  • Line 221: warning: cyclomatic complexity 23 of function TestDiskPartialMerge() is high (> 15) (gocyclo)

• rsk-core/eth/filters/api.go
  • Line 467: warning: cyclomatic complexity 26 of function (*FilterCriteria).UnmarshalJSON() is high (> 15) (gocyclo)

• rsk-core/eth/downloader/queue_test.go
  • Line 99: warning: cyclomatic complexity 21 of function TestBasics() is high (> 15) (gocyclo)

• rsk-core/eth/fetcher/block_fetcher.go
  • Line 332: warning: cyclomatic complexity 86 of function (*BlockFetcher).loop() is high (> 15) (gocyclo)

• rsk-core/miner/worker.go
  • Line 869: warning: cyclomatic complexity 30 of function (*worker).commitNewWork() is high (> 15) (gocyclo)
  • Line 433: warning: cyclomatic complexity 28 of function (*worker).mainLoop() is high (> 15) (gocyclo)
  • Line 750: warning: cyclomatic complexity 22 of function (*worker).commitTransactions() is high (> 15) (gocyclo)
  • Line 336: warning: cyclomatic complexity 21 of function (*worker).newWorkLoop() is high (> 15) (gocyclo)

• rsk-core/crypto/blake2b/blake2b_test.go
  • Line 154: warning: cyclomatic complexity 18 of function testHashes2X() is high (> 15) (gocyclo)

• rsk-core/core/rawdb/freezer.go
  • Line 279: warning: cyclomatic complexity 39 of function (*freezer).freeze() is high (> 15) (gocyclo)

• rsk-core/ethclient/ethclient.go
  • Line 103: warning: cyclomatic complexity 21 of function (*Client).getBlock() is high (> 15) (gocyclo)

• rsk-core/eth/protocols/eth/handlers.go
  • Line 52: warning: cyclomatic complexity 21 of function answerGetBlockHeadersQuery() is high (> 15) (gocyclo)

• rsk-core/eth/protocols/snap/sync.go
  • Line 1686: warning: cyclomatic complexity 34 of function (*Syncer).processStorageResponse() is high (> 15) (gocyclo)
  • Line 2219: warning: cyclomatic complexity 26 of function (*Syncer).OnStorage() is high (> 15) (gocyclo)
  • Line 945: warning: cyclomatic complexity 24 of function (*Syncer).assignStorageTasks() is high (> 15) (gocyclo)
  • Line 541: warning: cyclomatic complexity 23 of function (*Syncer).Sync() is high (> 15) (gocyclo)
  • Line 1998: warning: cyclomatic complexity 21 of function (*Syncer).OnAccounts() is high (> 15) (gocyclo)
  • Line 1913: warning: cyclomatic complexity 17 of function (*Syncer).forwardAccountTask() is high (> 15) (gocyclo)
  • Line 1184: warning: cyclomatic complexity 17 of function (*Syncer).assignBytecodeHealTasks() is high (> 15) (gocyclo)
  • Line 1078: warning: cyclomatic complexity 17 of function (*Syncer).assignTrienodeHealTasks() is high (> 15) (gocyclo)
  • Line 1546: warning: cyclomatic complexity 17 of function (*Syncer).processAccountResponse() is high (> 15) (gocyclo)
  • Line 1282: warning: cyclomatic complexity 16 of function (*Syncer).revertRequests() is high (> 15) (gocyclo)

• rsk-core/rlp/encode.go
  • Line 330: warning: cyclomatic complexity 18 of function makeWriter() is high (> 15) (gocyclo)

• rsk-core/core/headerchain.go
  • Line 149: warning: cyclomatic complexity 22 of function (*HeaderChain).writeHeaders() is high (> 15) (gocyclo)

• rsk-core/core/genesis.go
  • Line 159: warning: cyclomatic complexity 21 of function SetupGenesisBlockWithOverride() is high (> 15) (gocyclo)

• rsk-core/consensus/clique/clique.go
  • Line 245: warning: cyclomatic complexity 22 of function (*Clique).verifyHeader() is high (> 15) (gocyclo)
  • Line 348: warning: cyclomatic complexity 21 of function (*Clique).snapshot() is high (> 15) (gocyclo)
  • Line 577: warning: cyclomatic complexity 16 of function (*Clique).Seal() is high (> 15) (gocyclo)

• rsk-core/core/vm/gas_table.go
  • Line 96: warning: cyclomatic complexity 17 of function gasSStore() is high (> 15) (gocyclo)

• rsk-core/eth/fetcher/tx_fetcher.go
  • Line 346: warning: cyclomatic complexity 76 of function (*TxFetcher).loop() is high (> 15) (gocyclo)

• rsk-core/eth/protocols/snap/handler.go
  • Line 120: warning: cyclomatic complexity 75 of function handleMessage() is high (> 15) (gocyclo)

• rsk-core/core/chain_indexer.go
  • Line 304: warning: cyclomatic complexity 20 of function (*ChainIndexer).updateLoop() is high (> 15) (gocyclo)

• rsk-core/consensus/clique/snapshot_test.go
  • Line 99: warning: cyclomatic complexity 27 of function TestClique() is high (> 15) (gocyclo)

• rsk-core/core/state/statedb_test.go
  • Line 745: warning: cyclomatic complexity 28 of function TestStateDBAccessList() is high (> 15) (gocyclo)
  • Line 582: warning: cyclomatic complexity 21 of function TestCopyCopyCommitCopy() is high (> 15) (gocyclo)
  • Line 510: warning: cyclomatic complexity 17 of function TestCopyCommitCopy() is high (> 15) (gocyclo)

• rsk-core/eth/downloader/queue.go
  • Line 689: warning: cyclomatic complexity 18 of function (*queue).DeliverHeaders() is high (> 15) (gocyclo)

• rsk-core/core/tx_pool_test.go
  • Line 880: warning: cyclomatic complexity 29 of function testTransactionQueueTimeLimiting() is high (> 15) (gocyclo)
  • Line 577: warning: cyclomatic complexity 28 of function TestTransactionPostponing() is high (> 15) (gocyclo)
  • Line 1251: warning: cyclomatic complexity 24 of function TestTransactionPoolRepricing() is high (> 15) (gocyclo)
  • Line 1434: warning: cyclomatic complexity 20 of function TestTransactionPoolUnderpricing() is high (> 15) (gocyclo)
  • Line 1754: warning: cyclomatic complexity 19 of function testTransactionJournaling() is high (> 15) (gocyclo)
  • Line 473: warning: cyclomatic complexity 19 of function TestTransactionDropping() is high (> 15) (gocyclo)
  • Line 1605: warning: cyclomatic complexity 17 of function TestTransactionDeduplication() is high (> 15) (gocyclo)
  • Line 1671: warning: cyclomatic complexity 17 of function TestTransactionReplacement() is high (> 15) (gocyclo)

golint80%

Golint is a linter for Go source code.

• rsk-core/crypto/bls12381/fp_test.go
  • Line 67: warning: don't use underscores in Go names; var big_a should be bigA (golint)
  • Line 68: warning: don't use underscores in Go names; var big_b should be bigB (golint)
  • Line 69: warning: don't use underscores in Go names; var big_c should be bigC (golint)
  • Line 71: warning: don't use underscores in Go names; var out_1 should be out1 (golint)
  • Line 72: warning: don't use underscores in Go names; var out_2 should be out2 (golint)
  • Line 101: warning: don't use underscores in Go names; var big_a should be bigA (golint)
  • Line 101: warning: don't use underscores in Go names; var big_b should be bigB (golint)
  • Line 103: warning: don't use underscores in Go names; var out_1 should be out1 (golint)
  • Line 104: warning: don't use underscores in Go names; var out_2 should be out2 (golint)
  • Line 133: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 133: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 171: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 223: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 223: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 306: warning: don't use underscores in Go names; var big_a should be bigA (golint)
  • Line 307: warning: don't use underscores in Go names; var big_b should be bigB (golint)
  • Line 308: warning: don't use underscores in Go names; var big_c should be bigC (golint)
  • Line 310: warning: don't use underscores in Go names; var out_1 should be out1 (golint)
  • Line 311: warning: don't use underscores in Go names; var out_2 should be out2 (golint)
  • Line 323: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 323: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 337: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 491: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 492: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 530: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 583: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 583: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 657: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 657: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 671: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 874: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 875: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 913: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 966: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 966: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 1042: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 1042: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 1056: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 1183: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 1184: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 1222: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 1247: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 1247: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 1261: warning: don't use underscores in Go names; var c_x should be cX (golint)

• rsk-core/crypto/bls12381/g1.go
  • Line 30: warning: exported method PointG1.Set should have comment or be unexported (golint)
  • Line 231: warning: comment on exported method G1.Affine should be of the form "Affine ..." (golint)

• rsk-core/eth/protocols/snap/protocol.go
  • Line 49: warning: exported const GetAccountRangeMsg should have comment (or a comment on this block) or be unexported (golint)
  • Line 196: warning: exported method GetAccountRangePacket.Name should have comment or be unexported (golint)
  • Line 197: warning: exported method GetAccountRangePacket.Kind should have comment or be unexported (golint)
  • Line 199: warning: exported method AccountRangePacket.Name should have comment or be unexported (golint)
  • Line 200: warning: exported method AccountRangePacket.Kind should have comment or be unexported (golint)
  • Line 202: warning: exported method GetStorageRangesPacket.Name should have comment or be unexported (golint)
  • Line 203: warning: exported method GetStorageRangesPacket.Kind should have comment or be unexported (golint)
  • Line 205: warning: exported method StorageRangesPacket.Name should have comment or be unexported (golint)
  • Line 206: warning: exported method StorageRangesPacket.Kind should have comment or be unexported (golint)
  • Line 208: warning: exported method GetByteCodesPacket.Name should have comment or be unexported (golint)
  • Line 209: warning: exported method GetByteCodesPacket.Kind should have comment or be unexported (golint)
  • Line 211: warning: exported method ByteCodesPacket.Name should have comment or be unexported (golint)
  • Line 212: warning: exported method ByteCodesPacket.Kind should have comment or be unexported (golint)
  • Line 214: warning: exported method GetTrieNodesPacket.Name should have comment or be unexported (golint)
  • Line 215: warning: exported method GetTrieNodesPacket.Kind should have comment or be unexported (golint)
  • Line 217: warning: exported method TrieNodesPacket.Name should have comment or be unexported (golint)
  • Line 218: warning: exported method TrieNodesPacket.Kind should have comment or be unexported (golint)

• rsk-core/eth/downloader/downloader.go
  • Line 42: warning: exported var MaxBlockFetch should have comment or be unexported (golint)
  • Line 96: warning: exported type Downloader should have comment or be unexported (golint)

• rsk-core/rpc/client.go
  • Line 35: warning: exported var ErrClientQuit should have comment or be unexported (golint)
  • Line 188: warning: comment on exported function ClientFromContext should be of the form "ClientFromContext ..." (golint)
  • Line 335: warning: comment on exported method Client.BatchCallContext should be of the form "BatchCallContext ..." (golint)

• rsk-core/rpc/types.go
  • Line 69: warning: exported type BlockNumber should have comment or be unexported (golint)
  • Line 72: warning: exported const PendingBlockNumber should have comment (or a comment on this block) or be unexported (golint)
  • Line 112: warning: exported method BlockNumber.Int64 should have comment or be unexported (golint)
  • Line 116: warning: exported type BlockNumberOrHash should have comment or be unexported (golint)
  • Line 122: warning: exported method BlockNumberOrHash.UnmarshalJSON should have comment or be unexported (golint)
  • Line 162: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 177: warning: exported method BlockNumberOrHash.Number should have comment or be unexported (golint)
  • Line 184: warning: exported method BlockNumberOrHash.Hash should have comment or be unexported (golint)
  • Line 191: warning: exported function BlockNumberOrHashWithNumber should have comment or be unexported (golint)
  • Line 199: warning: exported function BlockNumberOrHashWithHash should have comment or be unexported (golint)

• rsk-core/crypto/ecies/params.go
  • Line 49: warning: exported var DefaultCurve should have comment or be unexported (golint)
  • Line 60: warning: exported type ECIESParams should have comment or be unexported (golint)
  • Line 75: warning: exported var ECIES_AES128_SHA256 should have comment or be unexported (golint)
  • Line 115: warning: exported function AddParamsForCurve should have comment or be unexported (golint)

• rsk-core/core/vm/runtime/runtime_test.go
  • Line 159: warning: don't use underscores in Go names; func benchmarkEVM_Create should be benchmarkEVMCreate (golint)

• rsk-core/eth/filters/filter.go
  • Line 33: warning: exported type Backend should have comment or be unexported (golint)

• rsk-core/eth/backend.go
  • Line 340: warning: exported method Ethereum.ResetWithGenesisBlock should have comment or be unexported (golint)
  • Line 344: warning: exported method Ethereum.Etherbase should have comment or be unexported (golint)
  • Line 490: warning: exported method Ethereum.IsMining should have comment or be unexported (golint)
  • Line 491: warning: exported method Ethereum.Miner should have comment or be unexported (golint)
  • Line 493: warning: exported method Ethereum.AccountManager should have comment or be unexported (golint)
  • Line 494: warning: exported method Ethereum.BlockChain should have comment or be unexported (golint)
  • Line 495: warning: exported method Ethereum.TxPool should have comment or be unexported (golint)
  • Line 496: warning: exported method Ethereum.EventMux should have comment or be unexported (golint)
  • Line 497: warning: exported method Ethereum.Engine should have comment or be unexported (golint)
  • Line 498: warning: exported method Ethereum.ChainDb should have comment or be unexported (golint)
  • Line 499: warning: exported method Ethereum.IsListening should have comment or be unexported (golint)
  • Line 500: warning: exported method Ethereum.Downloader should have comment or be unexported (golint)
  • Line 501: warning: exported method Ethereum.Synced should have comment or be unexported (golint)
  • Line 502: warning: exported method Ethereum.ArchiveMode should have comment or be unexported (golint)
  • Line 503: warning: exported method Ethereum.BloomIndexer should have comment or be unexported (golint)

• rsk-core/rlp/encode.go
  • Line 28: warning: comment on exported var EmptyString should be of the form "EmptyString ..." (golint)
  • Line 31: warning: exported var EmptyList should have comment or be unexported (golint)

• rsk-core/internal/build/util.go
  • Line 37: warning: exported var DryRunFlag should have comment or be unexported (golint)
  • Line 52: warning: exported function MustRunCommand should have comment or be unexported (golint)

• rsk-core/core/vm/runtime/env.go
  • Line 24: warning: exported function NewEnv should have comment or be unexported (golint)

• rsk-core/crypto/blake2b/blake2b.go
  • Line 26: warning: comment on exported const BlockSize should be of the form "BlockSize ..." (golint)
  • Line 28: warning: comment on exported const Size should be of the form "Size ..." (golint)
  • Line 30: warning: comment on exported const Size384 should be of the form "Size384 ..." (golint)
  • Line 32: warning: comment on exported const Size256 should be of the form "Size256 ..." (golint)

• rsk-core/crypto/bn256/google/gfp2.go
  • Line 105: warning: receiver name c should be consistent with previous receiver name e for gfP2 (golint)

• rsk-core/core/state/dump.go
  • Line 114: warning: exported method StateDB.DumpToCollector should have comment or be unexported (golint)

• rsk-core/eth/api_backend.go
  • Line 55: warning: exported method EthAPIBackend.CurrentBlock should have comment or be unexported (golint)
  • Line 59: warning: exported method EthAPIBackend.SetHead should have comment or be unexported (golint)
  • Line 64: warning: exported method EthAPIBackend.HeaderByNumber should have comment or be unexported (golint)
  • Line 77: warning: exported method EthAPIBackend.HeaderByNumberOrHash should have comment or be unexported (golint)
  • Line 94: warning: exported method EthAPIBackend.HeaderByHash should have comment or be unexported (golint)
  • Line 98: warning: exported method EthAPIBackend.BlockByNumber should have comment or be unexported (golint)
  • Line 111: warning: exported method EthAPIBackend.BlockByHash should have comment or be unexported (golint)
  • Line 115: warning: exported method EthAPIBackend.BlockByNumberOrHash should have comment or be unexported (golint)
  • Line 136: warning: exported method EthAPIBackend.StateAndHeaderByNumber should have comment or be unexported (golint)
  • Line 154: warning: exported method EthAPIBackend.StateAndHeaderByNumberOrHash should have comment or be unexported (golint)
  • Line 175: warning: exported method EthAPIBackend.GetReceipts should have comment or be unexported (golint)
  • Line 179: warning: exported method EthAPIBackend.GetLogs should have comment or be unexported (golint)
  • Line 191: warning: exported method EthAPIBackend.GetTd should have comment or be unexported (golint)
  • Line 195: warning: exported method EthAPIBackend.GetEVM should have comment or be unexported (golint)
  • Line 203: warning: exported method EthAPIBackend.SubscribeRemovedLogsEvent should have comment or be unexported (golint)
  • Line 207: warning: exported method EthAPIBackend.SubscribePendingLogsEvent should have comment or be unexported (golint)
  • Line 211: warning: exported method EthAPIBackend.SubscribeChainEvent should have comment or be unexported (golint)
  • Line 215: warning: exported method EthAPIBackend.SubscribeChainHeadEvent should have comment or be unexported (golint)
  • Line 219: warning: exported method EthAPIBackend.SubscribeChainSideEvent should have comment or be unexported (golint)
  • Line 223: warning: exported method EthAPIBackend.SubscribeLogsEvent should have comment or be unexported (golint)
  • Line 227: warning: exported method EthAPIBackend.SendTx should have comment or be unexported (golint)
  • Line 231: warning: exported method EthAPIBackend.GetPoolTransactions should have comment or be unexported (golint)
  • Line 243: warning: exported method EthAPIBackend.GetPoolTransaction should have comment or be unexported (golint)
  • Line 247: warning: exported method EthAPIBackend.GetTransaction should have comment or be unexported (golint)
  • Line 252: warning: exported method EthAPIBackend.GetPoolNonce should have comment or be unexported (golint)
  • Line 256: warning: exported method EthAPIBackend.Stats should have comment or be unexported (golint)
  • Line 260: warning: exported method EthAPIBackend.TxPoolContent should have comment or be unexported (golint)
  • Line 264: warning: exported method EthAPIBackend.TxPool should have comment or be unexported (golint)
  • Line 268: warning: exported method EthAPIBackend.SubscribeNewTxsEvent should have comment or be unexported (golint)
  • Line 272: warning: exported method EthAPIBackend.Downloader should have comment or be unexported (golint)
  • Line 276: warning: exported method EthAPIBackend.SuggestPrice should have comment or be unexported (golint)
  • Line 280: warning: exported method EthAPIBackend.ChainDb should have comment or be unexported (golint)
  • Line 284: warning: exported method EthAPIBackend.EventMux should have comment or be unexported (golint)
  • Line 288: warning: exported method EthAPIBackend.AccountManager should have comment or be unexported (golint)
  • Line 292: warning: exported method EthAPIBackend.ExtRPCEnabled should have comment or be unexported (golint)
  • Line 296: warning: exported method EthAPIBackend.UnprotectedAllowed should have comment or be unexported (golint)
  • Line 300: warning: exported method EthAPIBackend.RPCGasCap should have comment or be unexported (golint)
  • Line 304: warning: exported method EthAPIBackend.RPCTxFeeCap should have comment or be unexported (golint)
  • Line 308: warning: exported method EthAPIBackend.BloomStatus should have comment or be unexported (golint)
  • Line 313: warning: exported method EthAPIBackend.ServiceFilter should have comment or be unexported (golint)
  • Line 319: warning: exported method EthAPIBackend.Engine should have comment or be unexported (golint)
  • Line 323: warning: exported method EthAPIBackend.CurrentHeader should have comment or be unexported (golint)
  • Line 327: warning: exported method EthAPIBackend.Miner should have comment or be unexported (golint)
  • Line 331: warning: exported method EthAPIBackend.StartMining should have comment or be unexported (golint)
  • Line 335: warning: exported method EthAPIBackend.StateAtBlock should have comment or be unexported (golint)
  • Line 339: warning: exported method EthAPIBackend.StatesInRange should have comment or be unexported (golint)
  • Line 343: warning: exported method EthAPIBackend.StateAtTransaction should have comment or be unexported (golint)

• rsk-core/eth/downloader/events.go
  • Line 21: warning: exported type DoneEvent should have comment or be unexported (golint)
  • Line 24: warning: exported type StartEvent should have comment or be unexported (golint)
  • Line 25: warning: exported type FailedEvent should have comment or be unexported (golint)

• rsk-core/rpc/http.go
  • Line 241: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 242: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 243: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 245: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 248: warning: should not use basic type string as key in context.WithValue (golint)

• rsk-core/rpc/testservice_test.go
  • Line 97: warning: error should be the last type when returning multiple items (golint)

• rsk-core/ethclient/ethclient.go
  • Line 44: warning: exported function DialContext should have comment or be unexported (golint)
  • Line 57: warning: exported method Client.Close should have comment or be unexported (golint)
  • Line 63: warning: comment on exported method Client.ChainID should be of the form "ChainID ..." (golint)

• rsk-core/core/state/snapshot/snapshot.go
  • Line 155: warning: comment on exported type Tree should be of the form "Tree ..." (with optional leading article) (golint)
  • Line 783: warning: comment on exported method Tree.DiskRoot should be of the form "DiskRoot ..." (golint)

• rsk-core/eth/protocols/snap/peer.go
  • Line 77: warning: comment on exported method Peer.RequestStorageRanges should be of the form "RequestStorageRanges ..." (golint)

• rsk-core/internal/ethapi/addrlock.go
  • Line 25: warning: exported type AddrLocker should have comment or be unexported (golint)

• rsk-core/rlp/decode.go
  • Line 36: warning: error var EOL should have name of the form ErrFoo (golint)
  • Line 39: warning: exported var ErrExpectedString should have comment or be unexported (golint)
  • Line 510: warning: exported const Byte should have comment (or a comment on this block) or be unexported (golint)

• rsk-core/crypto/secp256k1/curve.go
  • Line 89: warning: exported method BitCurve.Params should have comment or be unexported (golint)
  • Line 245: warning: exported method BitCurve.ScalarMult should have comment or be unexported (golint)

• rsk-core/core/blockchain.go
  • Line 92: warning: exported const TriesInMemory should have comment (or a comment on this block) or be unexported (golint)
  • Line 1089: warning: exported const NonStatTy should have comment (or a comment on this block) or be unexported (golint)

• rsk-core/crypto/ecies/ecies.go
  • Line 46: warning: exported var ErrImport should have comment or be unexported (golint)
  • Line 61: warning: comment on exported method PublicKey.ExportECDSA should be of the form "ExportECDSA ..." (golint)
  • Line 66: warning: comment on exported function ImportECDSAPublic should be of the form "ImportECDSAPublic ..." (golint)
  • Line 82: warning: comment on exported method PrivateKey.ExportECDSA should be of the form "ExportECDSA ..." (golint)
  • Line 89: warning: comment on exported function ImportECDSA should be of the form "ImportECDSA ..." (golint)
  • Line 95: warning: comment on exported function GenerateKey should be of the form "GenerateKey ..." (golint)
  • Line 120: warning: comment on exported method PrivateKey.GenerateShared should be of the form "GenerateShared ..." (golint)
  • Line 141: warning: exported var ErrSharedTooLong should have comment or be unexported (golint)

• rsk-core/core/state/statedb.go
  • Line 185: warning: exported method StateDB.AddLog should have comment or be unexported (golint)
  • Line 196: warning: exported method StateDB.GetLogs should have comment or be unexported (golint)
  • Line 200: warning: exported method StateDB.Logs should have comment or be unexported (golint)
  • Line 261: warning: exported method StateDB.GetNonce should have comment or be unexported (golint)
  • Line 280: warning: exported method StateDB.GetCode should have comment or be unexported (golint)
  • Line 288: warning: exported method StateDB.GetCodeSize should have comment or be unexported (golint)
  • Line 296: warning: exported method StateDB.GetCodeHash should have comment or be unexported (golint)
  • Line 373: warning: exported method StateDB.HasSuicided should have comment or be unexported (golint)
  • Line 401: warning: exported method StateDB.SetBalance should have comment or be unexported (golint)
  • Line 408: warning: exported method StateDB.SetNonce should have comment or be unexported (golint)
  • Line 415: warning: exported method StateDB.SetCode should have comment or be unexported (golint)
  • Line 422: warning: exported method StateDB.SetState should have comment or be unexported (golint)
  • Line 630: warning: exported method StateDB.ForEachStorage should have comment or be unexported (golint)
  • Line 630: warning: receiver name db should be consistent with previous receiver name s for StateDB (golint)

• rsk-core/core/vm/logger_json.go
  • Line 29: warning: exported type JSONLogger should have comment or be unexported (golint)
  • Line 44: warning: exported method JSONLogger.CaptureStart should have comment or be unexported (golint)
  • Line 47: warning: exported method JSONLogger.CaptureFault should have comment or be unexported (golint)

• rsk-core/eth/downloader/modes.go
  • Line 26: warning: exported const FullSync should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported method SyncMode.IsValid should have comment or be unexported (golint)
  • Line 52: warning: exported method SyncMode.MarshalText should have comment or be unexported (golint)
  • Line 67: warning: exported method SyncMode.UnmarshalText should have comment or be unexported (golint)

• rsk-core/core/state_transition.go
  • Line 30: warning: comment on exported type StateTransition should be of the form "StateTransition ..." (with optional leading article) (golint)

• rsk-core/internal/build/archive.go
  • Line 30: warning: exported type Archive should have comment or be unexported (golint)
  • Line 44: warning: exported function NewArchive should have comment or be unexported (golint)
  • Line 107: warning: exported type ZipArchive should have comment or be unexported (golint)
  • Line 113: warning: exported function NewZipArchive should have comment or be unexported (golint)
  • Line 117: warning: exported method ZipArchive.Directory should have comment or be unexported (golint)
  • Line 122: warning: exported method ZipArchive.Header should have comment or be unexported (golint)
  • Line 136: warning: exported method ZipArchive.Close should have comment or be unexported (golint)
  • Line 143: warning: exported type TarballArchive should have comment or be unexported (golint)
  • Line 150: warning: exported function NewTarballArchive should have comment or be unexported (golint)
  • Line 156: warning: exported method TarballArchive.Directory should have comment or be unexported (golint)
  • Line 165: warning: exported method TarballArchive.Header should have comment or be unexported (golint)
  • Line 177: warning: exported method TarballArchive.Close should have comment or be unexported (golint)

• rsk-core/core/events.go
  • Line 33: warning: exported type ChainEvent should have comment or be unexported (golint)
  • Line 39: warning: exported type ChainSideEvent should have comment or be unexported (golint)
  • Line 43: warning: exported type ChainHeadEvent should have comment or be unexported (golint)

• rsk-core/interfaces.go
  • Line 30: warning: error var NotFound should have name of the form ErrFoo (golint)

• rsk-core/core/vm/contracts.go
  • Line 110: warning: exported var PrecompiledAddressesBerlin should have comment or be unexported (golint)

• rsk-core/core/vm/memory.go
  • Line 71: warning: comment on exported method Memory.GetCopy should be of the form "GetCopy ..." (golint)

• rsk-core/consensus/ethash/api.go
  • Line 86: warning: comment on exported method API.SubmitHashRate should be of the form "SubmitHashRate ..." (golint)

• rsk-core/internal/debug/trace.go
  • Line 50: warning: comment on exported method HandlerT.StopGoTrace should be of the form "StopGoTrace ..." (golint)

• rsk-core/eth/protocols/eth/peer.go
  • Line 377: warning: comment on exported method Peer.SendNodeData should be of the form "SendNodeData ..." (golint)

• rsk-core/internal/flags/helpers.go
  • Line 28: warning: exported var CommandHelpTemplate should have comment or be unexported (golint)
  • Line 110: warning: comment on exported type ByCategory should be of the form "ByCategory ..." (with optional leading article) (golint)
  • Line 132: warning: exported function FlagCategory should have comment or be unexported (golint)

• rsk-core/internal/web3ext/web3ext.go
  • Line 17: warning: package comment should be of the form "Package web3ext ..." (golint)
  • Line 20: warning: exported var Modules should have comment or be unexported (golint)
  • Line 39: warning: exported const ChequebookJs should have comment or be unexported (golint)
  • Line 70: warning: exported const CliqueJs should have comment or be unexported (golint)
  • Line 121: warning: exported const EthashJs should have comment or be unexported (golint)
  • Line 149: warning: exported const AdminJs should have comment or be unexported (golint)
  • Line 239: warning: exported const DebugJs should have comment or be unexported (golint)
  • Line 490: warning: exported const EthJs should have comment or be unexported (golint)
  • Line 596: warning: exported const MinerJs should have comment or be unexported (golint)
  • Line 641: warning: exported const NetJs should have comment or be unexported (golint)
  • Line 654: warning: exported const PersonalJs should have comment or be unexported (golint)
  • Line 710: warning: exported const RpcJs should have comment or be unexported (golint)
  • Line 723: warning: exported const ShhJs should have comment or be unexported (golint)
  • Line 743: warning: exported const SwarmfsJs should have comment or be unexported (golint)
  • Line 767: warning: exported const TxpoolJs should have comment or be unexported (golint)
  • Line 794: warning: exported const AccountingJs should have comment or be unexported (golint)
  • Line 838: warning: exported const LESJs should have comment or be unexported (golint)
  • Line 892: warning: exported const VfluxJs should have comment or be unexported (golint)

• rsk-core/internal/ethapi/backend.go
  • Line 93: warning: exported function GetAPIs should have comment or be unexported (golint)

• rsk-core/consensus/ethash/ethash.go
  • Line 44: warning: exported var ErrInvalidDumpMagic should have comment or be unexported (golint)
  • Line 395: warning: exported const ModeNormal should have comment (or a comment on this block) or be unexported (golint)

• rsk-core/core/rawdb/accessors_chain.go
  • Line 842: warning: comment on exported function ReadHeadBlock should be of the form "ReadHeadBlock ..." (golint)

• rsk-core/internal/cmdtest/test_cmd.go
  • Line 39: warning: exported function NewTestCmd should have comment or be unexported (golint)
  • Line 43: warning: exported type TestCmd should have comment or be unexported (golint)
  • Line 93: warning: exported method TestCmd.SetTemplateFunc should have comment or be unexported (golint)
  • Line 191: warning: exported method TestCmd.WaitExit should have comment or be unexported (golint)
  • Line 195: warning: exported method TestCmd.Interrupt should have comment or be unexported (golint)
  • Line 222: warning: exported method TestCmd.CloseStdin should have comment or be unexported (golint)
  • Line 226: warning: exported method TestCmd.Kill should have comment or be unexported (golint)

• rsk-core/rpc/subscription.go
  • Line 37: warning: comment on exported var ErrSubscriptionNotFound should be of the form "ErrSubscriptionNotFound ..." (golint)

• rsk-core/core/headerchain.go
  • Line 299: warning: exported method HeaderChain.ValidateHeaderChain should have comment or be unexported (golint)
  • Line 527: warning: exported method HeaderChain.GetCanonicalHash should have comment or be unexported (golint)

• rsk-core/core/tx_pool.go
  • Line 124: warning: exported const TxStatusUnknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 781: warning: comment on exported method TxPool.AddRemotesSync should be of the form "AddRemotesSync ..." (golint)

• rsk-core/crypto/secp256k1/secp256.go
  • Line 52: warning: exported var ErrInvalidMsgLen should have comment or be unexported (golint)

• rsk-core/crypto/bn256/cloudflare/gfp12.go
  • Line 113: warning: receiver name c should be consistent with previous receiver name e for gfP12 (golint)

• rsk-core/eth/protocols/eth/protocol.go
  • Line 54: warning: comment on exported const StatusMsg should be of the form "StatusMsg ..." (golint)
  • Line 56: warning: exported const NewBlockHashesMsg should have comment (or a comment on this block) or be unexported (golint)
  • Line 68: warning: comment on exported const NewPooledTransactionHashesMsg should be of the form "NewPooledTransactionHashesMsg ..." (golint)
  • Line 132: warning: comment on exported type GetBlockHeadersPacket66 should be of the form "GetBlockHeadersPacket66 ..." (with optional leading article) (golint)
  • Line 177: warning: comment on exported type BlockHeadersPacket66 should be of the form "BlockHeadersPacket66 ..." (with optional leading article) (golint)
  • Line 205: warning: comment on exported type GetBlockBodiesPacket66 should be of the form "GetBlockBodiesPacket66 ..." (with optional leading article) (golint)
  • Line 214: warning: comment on exported type BlockBodiesPacket66 should be of the form "BlockBodiesPacket66 ..." (with optional leading article) (golint)
  • Line 253: warning: comment on exported type GetNodeDataPacket66 should be of the form "GetNodeDataPacket66 ..." (with optional leading article) (golint)
  • Line 262: warning: comment on exported type NodeDataPacket66 should be of the form "NodeDataPacket66 ..." (with optional leading article) (golint)
  • Line 271: warning: comment on exported type GetReceiptsPacket66 should be of the form "GetReceiptsPacket66 ..." (with optional leading article) (golint)
  • Line 280: warning: comment on exported type ReceiptsPacket66 should be of the form "ReceiptsPacket66 ..." (with optional leading article) (golint)
  • Line 289: warning: comment on exported type ReceiptsRLPPacket66 should be of the form "ReceiptsRLPPacket66 ..." (with optional leading article) (golint)
  • Line 301: warning: exported type GetPooledTransactionsPacket66 should have comment or be unexported (golint)
  • Line 309: warning: comment on exported type PooledTransactionsPacket66 should be of the form "PooledTransactionsPacket66 ..." (with optional leading article) (golint)
  • Line 315: warning: comment on exported type PooledTransactionsRLPPacket should be of the form "PooledTransactionsRLPPacket ..." (with optional leading article) (golint)
  • Line 325: warning: exported method StatusPacket.Name should have comment or be unexported (golint)
  • Line 326: warning: exported method StatusPacket.Kind should have comment or be unexported (golint)
  • Line 328: warning: exported method NewBlockHashesPacket.Name should have comment or be unexported (golint)
  • Line 329: warning: exported method NewBlockHashesPacket.Kind should have comment or be unexported (golint)
  • Line 331: warning: exported method TransactionsPacket.Name should have comment or be unexported (golint)
  • Line 332: warning: exported method TransactionsPacket.Kind should have comment or be unexported (golint)
  • Line 334: warning: exported method GetBlockHeadersPacket.Name should have comment or be unexported (golint)
  • Line 335: warning: exported method GetBlockHeadersPacket.Kind should have comment or be unexported (golint)
  • Line 337: warning: exported method BlockHeadersPacket.Name should have comment or be unexported (golint)
  • Line 338: warning: exported method BlockHeadersPacket.Kind should have comment or be unexported (golint)
  • Line 340: warning: exported method GetBlockBodiesPacket.Name should have comment or be unexported (golint)
  • Line 341: warning: exported method GetBlockBodiesPacket.Kind should have comment or be unexported (golint)
  • Line 343: warning: exported method BlockBodiesPacket.Name should have comment or be unexported (golint)
  • Line 344: warning: exported method BlockBodiesPacket.Kind should have comment or be unexported (golint)
  • Line 346: warning: exported method NewBlockPacket.Name should have comment or be unexported (golint)
  • Line 347: warning: exported method NewBlockPacket.Kind should have comment or be unexported (golint)
  • Line 349: warning: exported method GetNodeDataPacket.Name should have comment or be unexported (golint)
  • Line 350: warning: exported method GetNodeDataPacket.Kind should have comment or be unexported (golint)
  • Line 352: warning: exported method NodeDataPacket.Name should have comment or be unexported (golint)
  • Line 353: warning: exported method NodeDataPacket.Kind should have comment or be unexported (golint)
  • Line 355: warning: exported method GetReceiptsPacket.Name should have comment or be unexported (golint)
  • Line 356: warning: exported method GetReceiptsPacket.Kind should have comment or be unexported (golint)
  • Line 358: warning: exported method ReceiptsPacket.Name should have comment or be unexported (golint)
  • Line 359: warning: exported method ReceiptsPacket.Kind should have comment or be unexported (golint)
  • Line 361: warning: exported method NewPooledTransactionHashesPacket.Name should have comment or be unexported (golint)
  • Line 362: warning: exported method NewPooledTransactionHashesPacket.Kind should have comment or be unexported (golint)
  • Line 364: warning: exported method GetPooledTransactionsPacket.Name should have comment or be unexported (golint)
  • Line 365: warning: exported method GetPooledTransactionsPacket.Kind should have comment or be unexported (golint)
  • Line 367: warning: exported method PooledTransactionsPacket.Name should have comment or be unexported (golint)
  • Line 368: warning: exported method PooledTransactionsPacket.Kind should have comment or be unexported (golint)

• rsk-core/internal/debug/flags.go
  • Line 23: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 36: warning: exported var Memsize should have comment or be unexported (golint)
  • Line 165: warning: exported function StartPProf should have comment or be unexported (golint)

• rsk-core/internal/ethapi/api.go
  • Line 206: warning: comment on exported method PrivateAccountAPI.ListAccounts should be of the form "ListAccounts ..." (golint)
  • Line 554: warning: comment on exported type AccountResult should be of the form "AccountResult ..." (with optional leading article) (golint)
  • Line 564: warning: exported type StorageResult should have comment or be unexported (golint)
  • Line 815: warning: exported function DoCall should have comment or be unexported (golint)
  • Line 944: warning: exported function DoEstimateGas should have comment or be unexported (golint)

• rsk-core/core/asm/asm.go
  • Line 17: warning: package comment should be of the form "Package asm ..." (golint)
  • Line 37: warning: comment on exported function NewInstructionIterator should be of the form "NewInstructionIterator ..." (golint)
  • Line 102: warning: comment on exported function PrintDisassembled should be of the form "PrintDisassembled ..." (golint)
  • Line 120: warning: comment on exported function Disassemble should be of the form "Disassemble ..." (golint)

• rsk-core/eth/gasprice/gasprice.go
  • Line 34: warning: exported var DefaultMaxPrice should have comment or be unexported (golint)
  • Line 36: warning: exported type Config should have comment or be unexported (golint)

• rsk-core/eth/protocols/eth/handler.go
  • Line 168: warning: exported type Decoder should have comment or be unexported (golint)

• rsk-core/internal/jsre/jsre.go
  • Line 69: warning: comment on exported function New should be of the form "New ..." (golint)
  • Line 230: warning: comment on exported method JSRE.Stop should be of the form "Stop ..." (golint)
  • Line 239: warning: comment on exported method JSRE.Exec should be of the form "Exec ..." (golint)

• rsk-core/core/genesis.go
  • Line 70: warning: exported method GenesisAlloc.UnmarshalJSON should have comment or be unexported (golint)
  • Line 159: warning: exported function SetupGenesisBlockWithOverride should have comment or be unexported (golint)
  • Line 386: warning: exported function DefaultYoloV3GenesisBlock should have comment or be unexported (golint)

• rsk-core/core/vm/operations_acl.go
  • Line 28: warning: exported const ColdAccountAccessCostEIP2929 should have comment (or a comment on this block) or be unexported (golint)

• rsk-core/core/asm/lexer.go
  • Line 56: warning: exported const Numbers should have comment (or a comment on this block) or be unexported (golint)
  • Line 96: warning: comment on exported function Lex should be of the form "Lex ..." (golint)

• rsk-core/crypto/crypto.go
  • Line 176: warning: exported function FromECDSAPub should have comment or be unexported (golint)
  • Line 276: warning: exported function PubkeyToAddress should have comment or be unexported (golint)

• rsk-core/crypto/bn256/google/bn256.go
  • Line 169: warning: comment on exported function RandomG2 should be of the form "RandomG2 ..." (golint)
  • Line 227: warning: receiver name n should be consistent with previous receiver name e for G2 (golint)
  • Line 310: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 319: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 328: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 337: warning: receiver name n should be consistent with previous receiver name g for GT (golint)
  • Line 375: warning: receiver name e should be consistent with previous receiver name g for GT (golint)

• rsk-core/crypto/bls12381/field_element.go
  • Line 173: warning: receiver name e should be consistent with previous receiver name fe for fe (golint)

• rsk-core/core/vm/eips.go
  • Line 46: warning: exported function ValidEip should have comment or be unexported (golint)
  • Line 50: warning: exported function ActivateableEips should have comment or be unexported (golint)

• rsk-core/consensus/ethash/consensus.go
  • Line 486: warning: comment on exported var FrontierDifficultyCalulator should be of the form "FrontierDifficultyCalulator ..." (golint)
  • Line 488: warning: exported var HomesteadDifficultyCalulator should have comment or be unexported (golint)
  • Line 489: warning: exported var DynamicDifficultyCalculator should have comment or be unexported (golint)

• rsk-core/eth/filters/filter_system.go
  • Line 55: warning: comment on exported const LastIndexSubscription should be of the form "LastIndexSubscription ..." (golint)

• rsk-core/internal/build/env.go
  • Line 30: warning: comment on exported var GitCommitFlag should be of the form "GitCommitFlag ..." (golint)
  • Line 32: warning: exported var GitBranchFlag should have comment or be unexported (golint)

• rsk-core/crypto/bn256/google/gfp12.go
  • Line 133: warning: receiver name c should be consistent with previous receiver name e for gfP12 (golint)

• rsk-core/crypto/bn256/cloudflare/bn256.go
  • Line 59: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 68: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 77: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 86: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 95: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 104: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 129: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 347: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 356: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 365: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 374: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 383: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 390: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 432: warning: receiver name e should be consistent with previous receiver name g for GT (golint)

• rsk-core/core/state/access_list.go
  • Line 58: warning: receiver name a should be consistent with previous receiver name al for accessList (golint)

• rsk-core/core/state/state_object.go
  • Line 34: warning: exported type Code should have comment or be unexported (golint)
  • Line 40: warning: exported type Storage should have comment or be unexported (golint)
  • Line 50: warning: exported method Storage.Copy should have comment or be unexported (golint)

• rsk-core/crypto/bls12381/gt.go
  • Line 32: warning: exported method E.Set should have comment or be unexported (golint)
  • Line 48: warning: receiver name g should be consistent with previous receiver name e for E (golint)

• rsk-core/rpc/constants_unix.go
  • Line 32: warning: don't use underscores in Go names; var max_path_size should be maxPathSize (golint)

• rsk-core/core/asm/compiler.go
  • Line 42: warning: comment on exported function NewCompiler should be of the form "NewCompiler ..." (golint)

• rsk-core/internal/jsre/pretty.go
  • Line 37: warning: exported var FunctionColor should have comment or be unexported (golint)

• rsk-core/miner/miner.go
  • Line 67: warning: exported function New should have comment or be unexported (golint)
  • Line 146: warning: exported method Miner.Start should have comment or be unexported (golint)
  • Line 150: warning: exported method Miner.Stop should have comment or be unexported (golint)
  • Line 154: warning: exported method Miner.Close should have comment or be unexported (golint)
  • Line 158: warning: exported method Miner.Mining should have comment or be unexported (golint)
  • Line 162: warning: exported method Miner.HashRate should have comment or be unexported (golint)
  • Line 169: warning: exported method Miner.SetExtra should have comment or be unexported (golint)
  • Line 196: warning: exported method Miner.SetEtherbase should have comment or be unexported (golint)

• rsk-core/rpc/server.go
  • Line 28: warning: exported const MetadataApi should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign0%

IneffAssign detects ineffectual assignments in Go code.

An error occurred while running this test (exit status 2)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!