Go Report Card

Preparing report...

Report for github.com/theodesp/go-hipchat

A    Great!    Found 10 issues across 11 files

Tweet
Last refresh:

Refresh now

gofmt81%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint54%

Golint is a linter for Go source code.

    • go-hipchat/hipchat/hipchat.go
    • Line 222: warning: comment on exported method Client.Get should be of the form "Get ..." (golint)
    • Line 227: warning: comment on exported method Client.Post should be of the form "Post ..." (golint)
    • Line 232: warning: comment on exported method Client.Put should be of the form "Put ..." (golint)
    • Line 237: warning: comment on exported method Client.Delete should be of the form "Delete ..." (golint)
    • Line 248: warning: comment on exported method Client.Do should be of the form "Do ..." (golint)
    • Line 304: warning: comment on exported method Client.SetApiVersion should be of the form "SetApiVersion ..." (golint)
    • go-hipchat/hipchat/roomsService.go
    • Line 13: warning: comment on exported const RoomPrivacyPublic should be of the form "RoomPrivacyPublic ..." (golint)
    • Line 16: warning: comment on exported const RoomPrivacyPrivate should be of the form "RoomPrivacyPrivate ..." (golint)
    • Line 58: warning: exported type RoomLinks should have comment or be unexported (golint)
    • Line 154: warning: comment on exported method RoomsService.ListRooms should be of the form "ListRooms ..." (golint)
    • Line 178: warning: comment on exported method RoomsService.GetRoom should be of the form "GetRoom ..." (golint)
    • Line 202: warning: comment on exported method RoomsService.UpdateRoom should be of the form "UpdateRoom ..." (golint)
    • Line 225: warning: comment on exported method RoomsService.DeleteRoom should be of the form "DeleteRoom ..." (golint)
    • Line 248: warning: comment on exported method RoomsService.CreateRoom should be of the form "CreateRoom ..." (golint)
    • Line 270: warning: comment on exported method RoomsService.SetRoomTopic should be of the form "SetRoomTopic ..." (golint)
    • Line 293: warning: comment on exported method RoomsService.GetRoomStatistics should be of the form "GetRoomStatistics ..." (golint)
    • Line 317: warning: comment on exported method RoomsService.ShareLinkWithRoom should be of the form "ShareLinkWithRoom ..." (golint)
    • Line 340: warning: comment on exported method RoomsService.GetRoomParticipants should be of the form "GetRoomParticipants ..." (golint)
    • Line 369: warning: comment on exported method RoomsService.ReplyToRoomMessage should be of the form "ReplyToRoomMessage ..." (golint)
    • Line 392: warning: comment on exported method RoomsService.InviteUser should be of the form "InviteUser ..." (golint)
    • Line 424: warning: comment on exported method RoomsService.SendRoomMessage should be of the form "SendRoomMessage ..." (golint)
    • Line 448: warning: comment on exported method RoomsService.GetRoomMembers should be of the form "GetRoomMembers ..." (golint)
    • Line 472: warning: comment on exported method RoomsService.AddRoomMember should be of the form "AddRoomMember ..." (golint)
    • Line 502: warning: comment on exported method RoomsService.RemoveRoomMember should be of the form "RemoveRoomMember ..." (golint)
    • Line 530: warning: comment on exported method RoomsService.ShareFile should be of the form "ShareFile ..." (golint)
    • Line 567: warning: comment on exported function NewRoom should be of the form "NewRoom ..." (golint)
    • Line 582: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • go-hipchat/hipchat/errors.go
    • Line 5: warning: error var invalidSetApiVersion should have name of the form errFoo (golint)
    • Line 6: warning: error var emptyParam should have name of the form errFoo (golint)
    • Line 7: warning: error var invalidFileUpload should have name of the form errFoo (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign45%

IneffAssign detects ineffectual assignments in Go code.

    • go-hipchat/hipchat/roomsService_test.go
    • Line 13: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 31: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 50: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 67: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 82: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 108: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 130: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 147: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 169: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 198: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 217: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 239: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 263: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 279: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 298: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 313: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 328: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • go-hipchat/hipchat/utils_test.go
    • Line 18: warning: suite.T undefined (type *HipChatUtilsTestSuite has no field or method T) (ineffassign)
    • Line 37: warning: suite.T undefined (type *HipChatUtilsTestSuite has no field or method T) (ineffassign)
    • go-hipchat/examples/simple_oauth/main.go
    • Line 5: warning: cannot find package "." in: (ineffassign)
    • Line 6: warning: cannot find package "." in: (ineffassign)
    • Line 5: warning: could not import go-hipchat/hipchat (invalid package name: "") (ineffassign)
    • Line 6: warning: could not import golang.org/x/oauth2 (invalid package name: "") (ineffassign)
    • go-hipchat/hipchat/utils.go
    • Line 4: warning: cannot find package "." in: (ineffassign)
    • Line 4: warning: could not import github.com/google/go-querystring/query (invalid package name: "") (ineffassign)
    • Line 4: warning: could not import github.com/google/go-querystring/query (invalid package name: "") (ineffassign)
    • go-hipchat/hipchat/hipchat.go
    • Line 9: warning: cannot find package "." in: (ineffassign)
    • Line 9: warning: could not import github.com/philippfranke/multipart-related/related (invalid package name: "") (ineffassign)
    • Line 9: warning: could not import github.com/philippfranke/multipart-related/related (invalid package name: "") (ineffassign)
    • go-hipchat/hipchat/hipchat_test.go
    • Line 8: warning: cannot find package "." in: (ineffassign)
    • Line 9: warning: cannot find package "." in: (ineffassign)
    • Line 8: warning: could not import github.com/stretchr/testify/assert (invalid package name: "") (ineffassign)
    • Line 9: warning: could not import github.com/stretchr/testify/suite (invalid package name: "") (ineffassign)
    • Line 49: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 55: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 70: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 89: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 112: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 122: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 138: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 154: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)
    • Line 173: warning: suite.T undefined (type *HipChatClientTestSuite has no field or method T) (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!