Go Report Card

Preparing report...

Report for github.com/tkiraly/lorawan

A+    Excellent!    Found 17 issues across 47 files

Tweet
Last refresh:

Refresh now

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint68%

Golint is a linter for Go source code.

    • lorawan/commands/commands.go
    • Line 3: warning: exported type Fopter should have comment or be unexported (golint)
    • Line 22: warning: comment on exported const RxTimingSetupAnsCommand should be of the form "RxTimingSetupAnsCommand ..." (golint)
    • lorawan/commands/dlchannel/dlchannel.go
    • Line 10: warning: exported const Reqlen should have comment or be unexported (golint)
    • Line 12: warning: exported type DlChannelReq should have comment or be unexported (golint)
    • Line 34: warning: exported function ParseReq should have comment or be unexported (golint)
    • Line 40: warning: exported function NewReq should have comment or be unexported (golint)
    • Line 58: warning: exported const Anslen should have comment or be unexported (golint)
    • Line 60: warning: exported type DlChannelAns should have comment or be unexported (golint)
    • Line 83: warning: exported function ParseAns should have comment or be unexported (golint)
    • Line 89: warning: exported function NewAns should have comment or be unexported (golint)
    • lorawan/commands/dutycycle/dutycycle.go
    • Line 9: warning: exported const Reqlen should have comment or be unexported (golint)
    • Line 11: warning: exported type DutyCycleReq should have comment or be unexported (golint)
    • Line 31: warning: exported function ParseReq should have comment or be unexported (golint)
    • Line 37: warning: exported function NewReq should have comment or be unexported (golint)
    • Line 47: warning: exported const Anslen should have comment or be unexported (golint)
    • Line 49: warning: exported type DutyCycleAns should have comment or be unexported (golint)
    • Line 68: warning: exported function ParseAns should have comment or be unexported (golint)
    • Line 74: warning: exported function NewAns should have comment or be unexported (golint)
    • lorawan/commands/txparamsetup/txparamsetup.go
    • Line 9: warning: exported const Reqlen should have comment or be unexported (golint)
    • Line 11: warning: exported type TxParamSetupReq should have comment or be unexported (golint)
    • Line 36: warning: exported function ParseReq should have comment or be unexported (golint)
    • Line 42: warning: exported function NewReq should have comment or be unexported (golint)
    • Line 61: warning: exported const Anslen should have comment or be unexported (golint)
    • Line 63: warning: exported type TxParamSetupAns should have comment or be unexported (golint)
    • Line 81: warning: exported function ParseAns should have comment or be unexported (golint)
    • Line 87: warning: exported function NewAns should have comment or be unexported (golint)
    • lorawan/commands/linkadr/linkadr.go
    • Line 11: warning: exported const Reqlen should have comment or be unexported (golint)
    • Line 13: warning: exported type LinkADRReq should have comment or be unexported (golint)
    • Line 38: warning: exported function ParseReq should have comment or be unexported (golint)
    • Line 44: warning: exported function NewReq should have comment or be unexported (golint)
    • Line 62: warning: don't use underscores in Go names; method Redundancy_ChMaskCntl should be RedundancyChMaskCntl (golint)
    • Line 65: warning: don't use underscores in Go names; method Redundancy_NbTrans should be RedundancyNbTrans (golint)
    • Line 69: warning: exported const Anslen should have comment or be unexported (golint)
    • Line 71: warning: exported type LinkADRAns should have comment or be unexported (golint)
    • Line 104: warning: exported function ParseAns should have comment or be unexported (golint)
    • Line 110: warning: exported function NewAns should have comment or be unexported (golint)
    • lorawan/fhdr/down.go
    • Line 21: warning: exported type FHDRDown should have comment or be unexported (golint)
    • Line 26: warning: exported type FCtrlDown should have comment or be unexported (golint)
    • Line 59: warning: exported function NewDown should have comment or be unexported (golint)
    • Line 91: warning: exported function ParseDown should have comment or be unexported (golint)
    • lorawan/fhdr/up.go
    • Line 21: warning: exported type FHDRUp should have comment or be unexported (golint)
    • Line 26: warning: exported type FCtrlUp should have comment or be unexported (golint)
    • Line 59: warning: exported function NewUp should have comment or be unexported (golint)
    • Line 90: warning: exported function ParseUp should have comment or be unexported (golint)
    • lorawan/commands/rxtimingsetup/rxtimingsetup.go
    • Line 9: warning: exported const Reqlen should have comment or be unexported (golint)
    • Line 11: warning: exported type RxTimingSetupReq should have comment or be unexported (golint)
    • Line 31: warning: exported function ParseReq should have comment or be unexported (golint)
    • Line 37: warning: exported function NewReq should have comment or be unexported (golint)
    • Line 46: warning: exported const Anslen should have comment or be unexported (golint)
    • Line 48: warning: exported type RxTimingSetupAns should have comment or be unexported (golint)
    • Line 67: warning: exported function ParseAns should have comment or be unexported (golint)
    • Line 73: warning: exported function NewAns should have comment or be unexported (golint)
    • lorawan/commands/rxparamsetup/rxparamsetup.go
    • Line 10: warning: exported const Reqlen should have comment or be unexported (golint)
    • Line 12: warning: exported type RXParamSetupReq should have comment or be unexported (golint)
    • Line 48: warning: exported function ParseReq should have comment or be unexported (golint)
    • Line 54: warning: exported function NewReq should have comment or be unexported (golint)
    • Line 65: warning: exported const Anslen should have comment or be unexported (golint)
    • Line 67: warning: exported type RXParamSetupAns should have comment or be unexported (golint)
    • Line 90: warning: exported function ParseAns should have comment or be unexported (golint)
    • Line 96: warning: exported function NewAns should have comment or be unexported (golint)
    • lorawan/macpayload/down.go
    • Line 15: warning: exported type DataDown should have comment or be unexported (golint)
    • Line 54: warning: receiver name d should be consistent with previous receiver name m for dataDown (golint)
    • Line 63: warning: receiver name d should be consistent with previous receiver name m for dataDown (golint)
    • Line 72: warning: receiver name d should be consistent with previous receiver name m for dataDown (golint)
    • Line 76: warning: receiver name du should be consistent with previous receiver name m for dataDown (golint)
    • Line 88: warning: receiver name du should be consistent with previous receiver name m for dataDown (golint)
    • Line 92: warning: receiver name du should be consistent with previous receiver name m for dataDown (golint)
    • Line 96: warning: receiver name du should be consistent with previous receiver name m for dataDown (golint)
    • Line 100: warning: receiver name du should be consistent with previous receiver name m for dataDown (golint)
    • Line 104: warning: receiver name du should be consistent with previous receiver name m for dataDown (golint)
    • Line 108: warning: receiver name du should be consistent with previous receiver name m for dataDown (golint)
    • Line 112: warning: receiver name du should be consistent with previous receiver name m for dataDown (golint)
    • Line 117: warning: exported function NewDown should have comment or be unexported (golint)
    • Line 167: warning: exported function ParseDown should have comment or be unexported (golint)
    • lorawan/commands/linkcheck/linkcheck.go
    • Line 9: warning: exported const Reqlen should have comment or be unexported (golint)
    • Line 11: warning: exported type LinkCheckReq should have comment or be unexported (golint)
    • Line 30: warning: exported function ParseReq should have comment or be unexported (golint)
    • Line 36: warning: exported function NewReq should have comment or be unexported (golint)
    • Line 40: warning: exported const Anslen should have comment or be unexported (golint)
    • Line 42: warning: exported type LinkCheckAns should have comment or be unexported (golint)
    • Line 71: warning: exported function ParseAns should have comment or be unexported (golint)
    • Line 77: warning: exported function NewAns should have comment or be unexported (golint)
    • lorawan/commands/newchannel/newchannel.go
    • Line 10: warning: exported const Reqlen should have comment or be unexported (golint)
    • Line 12: warning: exported type NewChannelReq should have comment or be unexported (golint)
    • Line 36: warning: exported function ParseReq should have comment or be unexported (golint)
    • Line 42: warning: exported function NewReq should have comment or be unexported (golint)
    • Line 67: warning: exported const Anslen should have comment or be unexported (golint)
    • Line 69: warning: exported type NewChannelAns should have comment or be unexported (golint)
    • Line 90: warning: exported function ParseAns should have comment or be unexported (golint)
    • Line 96: warning: exported function NewAns should have comment or be unexported (golint)
    • lorawan/fhdr/fhdr.go
    • Line 7: warning: exported type FHDR should have comment or be unexported (golint)
    • Line 17: warning: exported type FCtrl should have comment or be unexported (golint)
    • lorawan/macpayload/up.go
    • Line 16: warning: exported type DataUp should have comment or be unexported (golint)
    • Line 44: warning: receiver name m should be consistent with previous receiver name du for dataUp (golint)
    • Line 49: warning: receiver name m should be consistent with previous receiver name du for dataUp (golint)
    • Line 54: warning: receiver name d should be consistent with previous receiver name du for dataUp (golint)
    • Line 63: warning: receiver name d should be consistent with previous receiver name du for dataUp (golint)
    • Line 72: warning: receiver name d should be consistent with previous receiver name du for dataUp (golint)
    • Line 117: warning: exported function NewUp should have comment or be unexported (golint)
    • Line 161: warning: exported function ParseUp should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign95%

IneffAssign detects ineffectual assignments in Go code.

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!