gofmt93%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• go-make/pkg/mk/dag.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• go-make/pkg/mk/dag.go
  • Line 89: warning: cyclomatic complexity 25 of function (*DAG).WalkDown() is high (> 15) (gocyclo)

golint40%

Golint is a linter for Go source code.

• go-make/pkg/mk/dag.go
  • Line 9: warning: exported type DAG should have comment or be unexported (golint)
  • Line 14: warning: exported function NewDAG should have comment or be unexported (golint)
  • Line 18: warning: exported method DAG.AddTarget should have comment or be unexported (golint)
  • Line 45: warning: exported method DAG.TopographicalSort should have comment or be unexported (golint)
  • Line 85: warning: exported method DAG.WalkUp should have comment or be unexported (golint)
  • Line 89: warning: exported method DAG.WalkDown should have comment or be unexported (golint)
  • Line 151: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)

• go-make/pkg/mk/targets.go
  • Line 23: warning: exported function RegisterTarget should have comment or be unexported (golint)

• go-make/pkg/mk/shell/shell.go
  • Line 11: warning: exported var DefaultShell should have comment or be unexported (golint)
  • Line 13: warning: exported type ShellExecutor should have comment or be unexported (golint)
  • Line 26: warning: exported method ShellExecutor.RunShell should have comment or be unexported (golint)

• go-make/cmd/go-make/main.go
  • Line 67: warning: exported function Makefile should have comment or be unexported (golint)

• go-make/pkg/mk/frontends/yamlfe/frontend.go
  • Line 11: warning: exported type Makefile should have comment or be unexported (golint)
  • Line 31: warning: exported method Makefile.Parse should have comment or be unexported (golint)
  • Line 35: warning: exported method Makefile.BuildRules should have comment or be unexported (golint)

• go-make/pkg/mk/frontends/yamlfe/rule.go
  • Line 36: warning: context.Context should be the first parameter of a function (golint)

• go-make/pkg/mk/file.go
  • Line 15: warning: comment on exported type FileTarget should be of the form "FileTarget ..." (with optional leading article) (golint)
  • Line 27: warning: exported method FileTarget.Name should have comment or be unexported (golint)
  • Line 31: warning: exported method FileTarget.Check should have comment or be unexported (golint)
  • Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-make/pkg/mk/make.go
  • Line 12: warning: exported type MatchQuality should have comment or be unexported (golint)
  • Line 15: warning: exported const NoMatch should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported var ErrTargetNotExists should have comment or be unexported (golint)
  • Line 21: warning: exported var ErrNoRule should have comment or be unexported (golint)
  • Line 23: warning: exported type Rule should have comment or be unexported (golint)
  • Line 28: warning: exported type Invocation should have comment or be unexported (golint)
  • Line 33: warning: exported type Executor should have comment or be unexported (golint)
  • Line 36: warning: exported type Make should have comment or be unexported (golint)
  • Line 42: warning: exported type TargetStatus should have comment or be unexported (golint)
  • Line 59: warning: context.Context should be the first parameter of a function (golint)

• go-make/pkg/mk/sum.go
  • Line 14: warning: exported type YamlSumStorageFile should have comment or be unexported (golint)
  • Line 76: warning: exported method YamlSumStorageFile.ReadOnly should have comment or be unexported (golint)
  • Line 84: warning: exported method YamlSumStorageFile.ReadWrite should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!