Go Report Card

Preparing report...

Report for github.com/tobycroft/gorose-pro

A    Great!    Found 19 issues across 39 files

Tweet
Last refresh:

Refresh now

gofmt87%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo82%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • gorose-pro/builder_default.go
    • Line 428: warning: cyclomatic complexity 28 of function (*BuilderDefault).parseWhere() is high (> 15) (gocyclo)
    • Line 179: warning: cyclomatic complexity 16 of function (*BuilderDefault).BuildData2() is high (> 15) (gocyclo)

golint69%

Golint is a linter for Go source code.

    • gorose-pro/orm.go
    • Line 8: warning: comment on exported type Orm should be of the form "Orm ..." (with optional leading article) (golint)
    • Line 29: warning: exported function NewOrmBuilder should have comment or be unexported (golint)
    • Line 85: warning: comment on exported method Orm.Table should be of the form "Table ..." (golint)
    • Line 178: warning: comment on exported method Orm.OrWhere should be of the form "OrWhere ..." (golint)
    • Line 329: warning: comment on exported method Orm.BuildSql should be of the form "BuildSql ..." (golint)
    • Line 397: warning: comment on exported method Orm.LockForUpdate should be of the form "LockForUpdate ..." (golint)
    • gorose-pro/session.go
    • Line 29: warning: don't use underscores in Go names; struct field tx_index should be txIndex (golint)
    • Line 51: warning: exported method Session.Close should have comment or be unexported (golint)
    • Line 61: warning: comment on exported method Session.SetIEngin should be of the form "SetIEngin ..." (golint)
    • Line 76: warning: comment on exported method Session.GetErr should be of the form "GetErr ..." (golint)
    • Line 81: warning: comment on exported method Session.SetIBinder should be of the form "SetIBinder ..." (golint)
    • Line 86: warning: comment on exported method Session.GetIBinder should be of the form "GetIBinder ..." (golint)
    • Line 91: warning: comment on exported method Session.ResetBinderResult should be of the form "ResetBinderResult ..." (golint)
    • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 136: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 156: warning: exported method Session.SavePoint should have comment or be unexported (golint)
    • Line 408: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • gorose-pro/builder_interface.go
    • Line 22: warning: exported type FieldQuotesDefault should have comment or be unexported (golint)
    • Line 26: warning: exported method FieldQuotesDefault.AddFieldQuotes should have comment or be unexported (golint)
    • gorose-pro/builder_postgres.go
    • Line 43: warning: comment on exported method BuilderPostgres.BuildExecute should be of the form "BuildExecute ..." (golint)
    • Line 48: warning: exported method BuilderPostgres.AddFieldQuotes should have comment or be unexported (golint)
    • gorose-pro/builder_oracle.go
    • Line 458: warning: comment on exported method BuilderOracle.BuildQuery should be of the form "BuildQuery ..." (golint)
    • Line 464: warning: comment on exported method BuilderOracle.BuildExecute should be of the form "BuildExecute ..." (golint)
    • gorose-pro/orm_query.go
    • Line 164: warning: don't use underscores in Go names; method Pluck_bak should be PluckBak (golint)
    • Line 234: warning: comment on exported method Orm.Value should be of the form "Value ..." (golint)
    • Line 244: warning: don't use underscores in Go names; method Value_bak should be ValueBak (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign87%

IneffAssign detects ineffectual assignments in Go code.

    • gorose-pro/builder_default.go
    • Line 193: warning: sliceData[0].MapStringT undefined (type t.T has no field or method MapStringT) (ineffassign)
    • Line 199: warning: itemt.MapStringT undefined (type t.T has no field or method MapStringT) (ineffassign)
    • Line 213: warning: t.New(data).MapStringT undefined (type t.Type has no field or method MapStringT) (ineffassign)
    • Line 193: warning: sliceData[0].MapStringT undefined (type t.T has no field or method MapStringT) (ineffassign)
    • Line 199: warning: itemt.MapStringT undefined (type t.T has no field or method MapStringT) (ineffassign)
    • Line 213: warning: t.New(data).MapStringT undefined (type t.Type has no field or method MapStringT) (ineffassign)
    • gorose-pro/orm_query.go
    • Line 195: warning: item.MapInterfaceT undefined (type t.T has no field or method MapInterfaceT) (ineffassign)
    • Line 195: warning: item.MapInterfaceT undefined (type t.T has no field or method MapInterfaceT) (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!