Go Report Card

Preparing report...

Report for github.com/vCloud-DFTBA/faythe

A+    Excellent!    Found 29 issues across 61 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • faythe/pkg/autohealer/healer.go
    • Line 74: warning: cyclomatic complexity 41 of function (*Healer).run() is high (> 15) (gocyclo)
    • Line 437: warning: cyclomatic complexity 27 of function (*Healer).syncSilencesFromBackend() is high (> 15) (gocyclo)
    • Line 255: warning: cyclomatic complexity 19 of function (*Healer).do() is high (> 15) (gocyclo)

golint62%

Golint is a linter for Go source code.

    • faythe/pkg/alert/alert.go
    • Line 23: warning: exported type Alert should have comment or be unexported (golint)
    • Line 28: warning: exported method Alert.ShouldFire should have comment or be unexported (golint)
    • Line 32: warning: exported method Alert.IsCoolingDown should have comment or be unexported (golint)
    • Line 37: warning: exported method Alert.Start should have comment or be unexported (golint)
    • Line 42: warning: exported method Alert.Fire should have comment or be unexported (golint)
    • Line 48: warning: exported method Alert.Reset should have comment or be unexported (golint)
    • Line 54: warning: exported method Alert.IsActive should have comment or be unexported (golint)
    • faythe/pkg/model/nresolver.go
    • Line 17: warning: exported type NResolver should have comment or be unexported (golint)
    • Line 24: warning: exported method NResolver.Validate should have comment or be unexported (golint)
    • faythe/pkg/common/registry.go
    • Line 21: warning: exported type Registry should have comment or be unexported (golint)
    • Line 26: warning: exported type RegistryItem should have comment or be unexported (golint)
    • Line 31: warning: exported type Worker should have comment or be unexported (golint)
    • Line 35: warning: exported method Registry.Get should have comment or be unexported (golint)
    • Line 43: warning: exported method Registry.Delete should have comment or be unexported (golint)
    • Line 50: warning: exported method Registry.Set should have comment or be unexported (golint)
    • Line 57: warning: exported method Registry.Iter should have comment or be unexported (golint)
    • faythe/pkg/exporter/cluster.go
    • Line 47: warning: exported function RegisterMemberInfo should have comment or be unexported (golint)
    • Line 63: warning: exported function ReportClusterJoin should have comment or be unexported (golint)
    • Line 67: warning: exported function ReportClusterLeave should have comment or be unexported (golint)
    • faythe/pkg/exporter/autohealer.go
    • Line 55: warning: exported function ReportNumberOfHealers should have comment or be unexported (golint)
    • Line 59: warning: exported function ReportSuccessHealerActionCounter should have comment or be unexported (golint)
    • Line 63: warning: exported function ReportFailureHealerActionCounter should have comment or be unexported (golint)
    • faythe/pkg/exporter/autoscaler.go
    • Line 55: warning: exported function ReportNumScalers should have comment or be unexported (golint)
    • Line 59: warning: exported function ReportSuccessScalerActionCounter should have comment or be unexported (golint)
    • Line 63: warning: exported function ReportFailureScalerActionCounter should have comment or be unexported (golint)
    • faythe/pkg/model/const.go
    • Line 16: warning: exported const FixedDelay should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: comment on exported const DefaultUsersPrefix should be of the form "DefaultUsersPrefix ..." (golint)
    • Line 49: warning: exported const DefaultMaxNumberOfInstances should have comment or be unexported (golint)
    • faythe/pkg/model/openstack.go
    • Line 90: warning: exported method OpenStack.BaseClient should have comment or be unexported (golint)
    • Line 111: warning: exported method OpenStack.NewWorkflowClient should have comment or be unexported (golint)
    • faythe/pkg/model/policy.go
    • Line 19: warning: exported type Policy should have comment or be unexported (golint)
    • Line 24: warning: exported type Polices should have comment or be unexported (golint)
    • Line 26: warning: exported method Policy.Validate should have comment or be unexported (golint)
    • faythe/pkg/model/silence.go
    • Line 28: warning: exported type Silence should have comment or be unexported (golint)
    • Line 41: warning: exported method Silence.Validate should have comment or be unexported (golint)
    • faythe/pkg/metrics/registry.go
    • Line 21: warning: exported type Registry should have comment or be unexported (golint)
    • Line 26: warning: exported type RegistryItem should have comment or be unexported (golint)
    • Line 50: warning: comment on exported method Registry.Set should be of the form "Set ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell96%

Misspell Finds commonly misspelled English words