Preparing report...

Report for github.com/varlink/go

A+    Excellent!    Found 10 issues across 24 files

Tweet

gofmt87%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo83%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint70%

Golint is a linter for Go source code.

    • go/varlink/bridge.go
    • Line 13: warning: exported type PipeCon should have comment or be unexported (golint)
    • Line 27: warning: exported method PipeCon.LocalAddr should have comment or be unexported (golint)
    • Line 31: warning: exported method PipeCon.RemoteAddr should have comment or be unexported (golint)
    • Line 35: warning: exported method PipeCon.SetDeadline should have comment or be unexported (golint)
    • Line 39: warning: exported method PipeCon.SetReadDeadline should have comment or be unexported (golint)
    • Line 43: warning: exported method PipeCon.SetWriteDeadline should have comment or be unexported (golint)
    • Line 47: warning: exported method PipeCon.Close should have comment or be unexported (golint)
    • go/varlink/orgvarlinkservice.go
    • Line 5: warning: comment on exported type InterfaceNotFound should be of the form "InterfaceNotFound ..." (with optional leading article) (golint)
    • Line 14: warning: comment on exported type MethodNotFound should be of the form "MethodNotFound ..." (with optional leading article) (golint)
    • Line 23: warning: comment on exported type MethodNotImplemented should be of the form "MethodNotImplemented ..." (with optional leading article) (golint)
    • Line 33: warning: comment on exported type InvalidParameter should be of the form "InvalidParameter ..." (with optional leading article) (golint)
    • go/varlink/service.go
    • Line 79: warning: exported method Service.HandleMessage should have comment or be unexported (golint)
    • Line 185: warning: exported method Service.GetListener should have comment or be unexported (golint)
    • go/cmd/varlink-go-certification/main.go
    • Line 20: warning: don't use underscores in Go names; func run_client should be runClient (golint)
    • Line 30: warning: don't use underscores in Go names; var client_id should be clientID (golint)
    • Line 198: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 206: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 206: warning: don't use underscores in Go names; method parameter bool_ should be bool (golint)
    • Line 218: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 218: warning: don't use underscores in Go names; method parameter int_ should be int (golint)
    • Line 230: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 230: warning: don't use underscores in Go names; method parameter float_ should be float (golint)
    • Line 241: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 241: warning: don't use underscores in Go names; method parameter string_ should be string (golint)
    • Line 253: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 253: warning: don't use underscores in Go names; method parameter bool_ should be bool (golint)
    • Line 253: warning: don't use underscores in Go names; method parameter int_ should be int (golint)
    • Line 253: warning: don't use underscores in Go names; method parameter float_ should be float (golint)
    • Line 253: warning: don't use underscores in Go names; method parameter string_ should be string (golint)
    • Line 288: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 288: warning: don't use underscores in Go names; method parameter struct_ should be struct (golint)
    • Line 321: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 321: warning: don't use underscores in Go names; method parameter map_ should be map (golint)
    • Line 346: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 346: warning: don't use underscores in Go names; method parameter set_ should be set (golint)
    • Line 398: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 398: warning: don't use underscores in Go names; method parameter mytype_ should be mytype (golint)
    • Line 549: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 549: warning: don't use underscores in Go names; method parameter last_more_replies_ should be lastMoreReplies (golint)
    • Line 571: warning: don't use underscores in Go names; method parameter client_id_ should be clientID (golint)
    • Line 580: warning: don't use underscores in Go names; func run_server should be runServer (golint)
    • go/cmd/varlink-go-type-generator/main.go
    • Line 14: warning: exported function IsBasicGoType should have comment or be unexported (golint)
    • Line 27: warning: exported function GoToVarlinkType should have comment or be unexported (golint)
    • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 93: warning: exported function PrintDefsUses should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!