Report for github.com/vkuznet/WorkQueue
A Great! Found 13 issues across 20 files
gofmt90%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
WorkQueue/core/business.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
WorkQueue/core/utils.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint65%
Golint is a linter for Go source code.
-
-
WorkQueue/core/montecarlo.go
- Line 24: warning: comment on exported method MonteCarloPolicy.Validate should be of the form "Validate ..." (golint)
-
-
WorkQueue/core/resubmit.go
- Line 24: warning: comment on exported method ResubmitBlockPolicy.Validate should be of the form "Validate ..." (golint)
-
-
WorkQueue/core/utils.go
- Line 142: warning: should omit 2nd value from range; this loop is equivalent to `for name := range ...` (golint)
-
-
WorkQueue/utils/regexp.go
- Line 11: warning: exported var PatternNumber should have comment or be unexported (golint)
- Line 12: warning: exported var PatternUrl should have comment or be unexported (golint)
-
-
WorkQueue/services/services.go
- Line 26: warning: comment on exported function Unmarshal should be of the form "Unmarshal ..." (golint)
-
-
WorkQueue/core/block.go
- Line 104: warning: comment on exported method BlockPolicy.Validate should be of the form "Validate ..." (golint)
-
-
WorkQueue/core/business.go
- Line 208: warning: should omit 2nd value from range; this loop is equivalent to `for rname := range ...` (golint)
ineffassign55%
IneffAssign detects ineffectual assignments in Go code.
-
-
WorkQueue/core/business.go
- Line 13: warning: cannot find package "." in: (ineffassign)
- Line 13: warning: could not import github.com/rcrowley/go-metrics (invalid package name: "") (ineffassign)
- Line 95: warning: undeclared name: metrics (ineffassign)
- Line 96: warning: undeclared name: metrics (ineffassign)
- Line 98: warning: undeclared name: metrics (ineffassign)
- Line 13: warning: "github.com/rcrowley/go-metrics" imported but not used (ineffassign)
-
-
WorkQueue/test/dbs_test.go
- Line 7: warning: cannot find package "." in: (ineffassign)
- Line 7: warning: could not import github.com/vkuznet/WorkQueue/services (invalid package name: "") (ineffassign)
-
-
WorkQueue/utils/fetch.go
- Line 19: warning: cannot find package "." in: (ineffassign)
- Line 21: warning: cannot find package "." in: (ineffassign)
- Line 19: warning: could not import github.com/sirupsen/logrus (invalid package name: "") (ineffassign)
- Line 21: warning: could not import github.com/vkuznet/x509proxy (invalid package name: "") (ineffassign)
-
-
WorkQueue/test/core_business_test.go
- Line 11: warning: cannot find package "." in: (ineffassign)
- Line 12: warning: cannot find package "." in: (ineffassign)
- Line 11: warning: could not import github.com/vkuznet/WorkQueue/core (invalid package name: "") (ineffassign)
- Line 12: warning: could not import github.com/vkuznet/WorkQueue/utils (invalid package name: "") (ineffassign)
-
-
WorkQueue/server/handlers.go
- Line 17: warning: cannot find package "." in: (ineffassign)
- Line 15: warning: cannot find package "." in: (ineffassign)
- Line 18: warning: cannot find package "." in: (ineffassign)
- Line 19: warning: cannot find package "." in: (ineffassign)
- Line 20: warning: cannot find package "." in: (ineffassign)
- Line 21: warning: cannot find package "." in: (ineffassign)
- Line 15: warning: could not import github.com/sirupsen/logrus (invalid package name: "") (ineffassign)
- Line 17: warning: could not import github.com/segmentio/pointer (invalid package name: "") (ineffassign)
- Line 18: warning: could not import github.com/vkuznet/WorkQueue/core (invalid package name: "") (ineffassign)
- Line 19: warning: could not import github.com/vkuznet/WorkQueue/services (invalid package name: "") (ineffassign)
- Line 20: warning: could not import github.com/vkuznet/WorkQueue/utils (invalid package name: "") (ineffassign)
- Line 21: warning: could not import github.com/zemirco/couchdb (invalid package name: "") (ineffassign)
-
-
WorkQueue/services/dbs.go
- Line 12: warning: cannot find package "." in: (ineffassign)
- Line 13: warning: cannot find package "." in: (ineffassign)
- Line 12: warning: could not import github.com/sirupsen/logrus (invalid package name: "") (ineffassign)
- Line 13: warning: could not import github.com/vkuznet/WorkQueue/utils (invalid package name: "") (ineffassign)
- Line 171: warning: blockInfo declared but not used (ineffassign)
-
-
WorkQueue/core/utils.go
- Line 11: warning: cannot find package "." in: (ineffassign)
- Line 11: warning: could not import github.com/segmentio/pointer (invalid package name: "") (ineffassign)
- Line 27: warning: undeclared name: metrics (ineffassign)
- Line 15: warning: "github.com/rcrowley/go-metrics" imported but not used (ineffassign)
-
-
WorkQueue/core/block.go
- Line 7: warning: cannot find package "." in: (ineffassign)
- Line 8: warning: cannot find package "." in: (ineffassign)
- Line 9: warning: cannot find package "." in: (ineffassign)
- Line 10: warning: cannot find package "." in: (ineffassign)
- Line 7: warning: could not import github.com/sirupsen/logrus (invalid package name: "") (ineffassign)
- Line 8: warning: could not import github.com/vkuznet/WorkQueue/services (invalid package name: "") (ineffassign)
- Line 9: warning: could not import github.com/vkuznet/WorkQueue/utils (invalid package name: "") (ineffassign)
- Line 10: warning: could not import github.com/zemirco/couchdb (invalid package name: "") (ineffassign)
- Line 23: warning: inputBlocks declared but not used (ineffassign)
- Line 23: warning: parentData declared but not used (ineffassign)
- Line 23: warning: pileupData declared but not used (ineffassign)
- Line 24: warning: numberOfLumis declared but not used (ineffassign)
- Line 24: warning: numberOfFiles declared but not used (ineffassign)
- Line 24: warning: numberOfEvents declared but not used (ineffassign)
- Line 24: warning: jobs declared but not used (ineffassign)
- Line 24: warning: blowupFactor declared but not used (ineffassign)
- Line 24: warning: priority declared but not used (ineffassign)
- Line 24: warning: filesProcessed declared but not used (ineffassign)
- Line 25: warning: parentFlag declared but not used (ineffassign)
- Line 25: warning: openForNewData declared but not used (ineffassign)
- Line 25: warning: noInputUpdate declared but not used (ineffassign)
- Line 25: warning: noPileupUpdate declared but not used (ineffassign)
- Line 26: warning: mask declared but not used (ineffassign)
- Line 27: warning: acdc declared but not used (ineffassign)
- Line 27: warning: requestName declared but not used (ineffassign)
- Line 27: warning: taskName declared but not used (ineffassign)
- Line 27: warning: dbs declared but not used (ineffassign)
- Line 27: warning: wmSpec declared but not used (ineffassign)
- Line 27: warning: parentQueueUrl declared but not used (ineffassign)
- Line 27: warning: childQueueUrl declared but not used (ineffassign)
- Line 27: warning: wmbsUrl declared but not used (ineffassign)
- Line 27: warning: sPolicy declared but not used (ineffassign)
- Line 27: warning: ePolicy declared but not used (ineffassign)
- Line 28: warning: siteWhiteList declared but not used (ineffassign)
- Line 28: warning: siteBlackList declared but not used (ineffassign)
- Line 29: warning: percentSuccess declared but not used (ineffassign)
- Line 29: warning: percentComplete declared but not used (ineffassign)
- Line 7: warning: "github.com/sirupsen/logrus" imported but not used as log (ineffassign)
- Line 8: warning: "github.com/vkuznet/WorkQueue/services" imported but not used (ineffassign)
-
-
WorkQueue/main.go
- Line 15: warning: cannot find package "." in: (ineffassign)
- Line 16: warning: cannot find package "." in: (ineffassign)
- Line 18: warning: cannot find package "." in: (ineffassign)
- Line 19: warning: cannot find package "." in: (ineffassign)
- Line 15: warning: could not import github.com/pkg/profile (invalid package name: "") (ineffassign)
- Line 16: warning: could not import github.com/sirupsen/logrus (invalid package name: "") (ineffassign)
- Line 18: warning: could not import github.com/vkuznet/WorkQueue/server (invalid package name: "") (ineffassign)
- Line 19: warning: could not import github.com/vkuznet/WorkQueue/utils (invalid package name: "") (ineffassign)