Go Report Card

Preparing report...

Report for github.com/vmware-labs/reconciler-runtime

A    Great!    Found 34 issues across 46 files

Tweet
Last refresh:

Refresh now

gofmt93%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint28%

Golint is a linter for Go source code.

    • reconciler-runtime/reconcilers/reconcilers.go
    • Line 79: warning: exported method ParentReconciler.SetupWithManager should have comment or be unexported (golint)
    • Line 89: warning: exported method ParentReconciler.Reconcile should have comment or be unexported (golint)
    • Line 174: warning: exported function StashParentType should have comment or be unexported (golint)
    • Line 178: warning: exported function StashCastParentType should have comment or be unexported (golint)
    • Line 182: warning: exported function RetrieveParentType should have comment or be unexported (golint)
    • Line 190: warning: exported function RetrieveCastParentType should have comment or be unexported (golint)
    • Line 232: warning: exported method SyncReconciler.SetupWithManager should have comment or be unexported (golint)
    • Line 248: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 275: warning: exported method SyncReconciler.Reconcile should have comment or be unexported (golint)
    • Line 308: warning: error var OnlyReconcileChildStatus should have name of the form ErrFoo (golint)
    • Line 308: warning: exported var OnlyReconcileChildStatus should have comment or be unexported (golint)
    • Line 417: warning: exported method ChildReconciler.SetupWithManager should have comment or be unexported (golint)
    • Line 447: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 462: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 488: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 501: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 537: warning: exported method ChildReconciler.Reconcile should have comment or be unexported (golint)
    • Line 802: warning: exported method Sequence.SetupWithManager should have comment or be unexported (golint)
    • Line 812: warning: exported method Sequence.Reconcile should have comment or be unexported (golint)
    • Line 854: warning: exported method CastParent.SetupWithManager should have comment or be unexported (golint)
    • Line 875: warning: exported method CastParent.Reconcile should have comment or be unexported (golint)
    • reconciler-runtime/validation/fielderrors.go
    • Line 16: warning: exported const CurrentField should have comment or be unexported (golint)
    • Line 18: warning: exported type FieldValidator should have comment or be unexported (golint)
    • Line 22: warning: exported type FieldErrors should have comment or be unexported (golint)
    • Line 24: warning: exported method FieldErrors.Also should have comment or be unexported (golint)
    • Line 32: warning: exported method FieldErrors.ViaField should have comment or be unexported (golint)
    • Line 52: warning: exported method FieldErrors.ViaIndex should have comment or be unexported (golint)
    • Line 72: warning: exported method FieldErrors.ViaFieldIndex should have comment or be unexported (golint)
    • Line 76: warning: exported method FieldErrors.ErrorList should have comment or be unexported (golint)
    • Line 84: warning: exported method FieldErrors.ToAggregate should have comment or be unexported (golint)
    • Line 88: warning: exported type Validatable should have comment or be unexported (golint)
    • Line 92: warning: exported function ErrDisallowedFields should have comment or be unexported (golint)
    • Line 98: warning: exported function ErrInvalidArrayValue should have comment or be unexported (golint)
    • Line 104: warning: exported function ErrInvalidValue should have comment or be unexported (golint)
    • Line 110: warning: exported function ErrDuplicateValue should have comment or be unexported (golint)
    • Line 120: warning: exported function ErrMissingField should have comment or be unexported (golint)
    • Line 126: warning: exported function ErrMissingOneOf should have comment or be unexported (golint)
    • Line 132: warning: exported function ErrMultipleOneOf should have comment or be unexported (golint)
    • reconciler-runtime/testing/resource.go
    • Line 26: warning: exported type TestResource should have comment or be unexported (golint)
    • Line 34: warning: exported method TestResource.Default should have comment or be unexported (golint)
    • Line 41: warning: comment on exported type TestResourceSpec should be of the form "TestResourceSpec ..." (with optional leading article) (golint)
    • Line 50: warning: exported method TestResourceSpec.MarshalJSON should have comment or be unexported (golint)
    • Line 67: warning: exported method TestResourceSpec.UnmarshalJSON should have comment or be unexported (golint)
    • Line 88: warning: comment on exported type TestResourceStatus should be of the form "TestResourceStatus ..." (with optional leading article) (golint)
    • Line 94: warning: exported method TestResourceStatus.InitializeConditions should have comment or be unexported (golint)
    • Line 99: warning: exported method TestResourceStatus.MarkReady should have comment or be unexported (golint)
    • Line 109: warning: exported method TestResourceStatus.MarkNotReady should have comment or be unexported (golint)
    • Line 125: warning: exported type TestResourceList should have comment or be unexported (golint)
    • Line 143: warning: comment on exported var SchemeGroupVersion should be of the form "SchemeGroupVersion ..." (golint)
    • reconciler-runtime/reconcilers/patch.go
    • Line 17: warning: exported function NewPatch should have comment or be unexported (golint)
    • Line 41: warning: exported type Patch should have comment or be unexported (golint)
    • Line 46: warning: error var PatchGenerationMismatch should have name of the form ErrFoo (golint)
    • Line 46: warning: exported var PatchGenerationMismatch should have comment or be unexported (golint)
    • Line 48: warning: exported method Patch.Apply should have comment or be unexported (golint)
    • reconciler-runtime/testing/reconciler.go
    • Line 89: warning: comment on exported method ReconcilerTestCase.Test should be of the form "Test ..." (golint)
    • Line 262: warning: exported var IgnoreLastTransitionTime should have comment or be unexported (golint)
    • Line 282: warning: comment on exported method ReconcilerTestSuite.Test should be of the form "Test ..." (golint)
    • Line 319: warning: exported type DeleteRef should have comment or be unexported (golint)
    • Line 326: warning: exported function NewDeleteRef should have comment or be unexported (golint)
    • reconciler-runtime/testing/aliases.go
    • Line 12: warning: exported type Reactor should have comment or be unexported (golint)
    • Line 14: warning: exported type ReactionFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type Action should have comment or be unexported (golint)
    • Line 16: warning: exported type GetAction should have comment or be unexported (golint)
    • Line 17: warning: exported type ListAction should have comment or be unexported (golint)
    • Line 18: warning: exported type CreateAction should have comment or be unexported (golint)
    • Line 19: warning: exported type UpdateAction should have comment or be unexported (golint)
    • Line 20: warning: exported type PatchAction should have comment or be unexported (golint)
    • Line 21: warning: exported type DeleteAction should have comment or be unexported (golint)
    • Line 22: warning: exported type DeleteCollectionAction should have comment or be unexported (golint)
    • reconciler-runtime/reconcilers/stash.go
    • Line 17: warning: exported function WithStash should have comment or be unexported (golint)
    • Line 18: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 21: warning: exported type StashKey should have comment or be unexported (golint)
    • Line 23: warning: exported function StashValue should have comment or be unexported (golint)
    • Line 31: warning: exported function RetrieveValue should have comment or be unexported (golint)
    • reconciler-runtime/testing/ptr.go
    • Line 8: warning: exported function StringPtr should have comment or be unexported (golint)
    • Line 12: warning: exported function BoolPtr should have comment or be unexported (golint)
    • Line 16: warning: exported function Int32Ptr should have comment or be unexported (golint)
    • Line 20: warning: exported function Int64Ptr should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!