Go Report Card

Preparing report...

Report for github.com/vmware-labs/service-bindings

A+    Excellent!    Found 29 issues across 126 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint80%

Golint is a linter for Go source code.

    • service-bindings/pkg/apis/servicebinding/v1alpha2/servicebinding_lifecycle.go
    • Line 17: warning: exported const ServiceBindingConditionReady should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: exported method ServiceBinding.GetStatus should have comment or be unexported (golint)
    • Line 31: warning: exported method ServiceBinding.GetConditionSet should have comment or be unexported (golint)
    • Line 35: warning: exported method ServiceBindingStatus.InitializeConditions should have comment or be unexported (golint)
    • Line 39: warning: exported method ServiceBindingStatus.PropagateServiceBindingProjectionStatus should have comment or be unexported (golint)
    • Line 57: warning: exported method ServiceBindingStatus.MarkServiceAvailable should have comment or be unexported (golint)
    • Line 61: warning: exported method ServiceBindingStatus.MarkServiceUnavailable should have comment or be unexported (golint)
    • service-bindings/pkg/apis/labsinternal/v1alpha1/servicebindingprojection_types.go
    • Line 25: warning: exported const ServiceBindingProjectionAnnotationKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: comment on exported type ServiceBindingProjection should be of the form "ServiceBindingProjection ..." (with optional leading article) (golint)
    • Line 51: warning: exported type ServiceBindingProjectionSpec should have comment or be unexported (golint)
    • Line 66: warning: exported type ApplicationReference should have comment or be unexported (golint)
    • Line 75: warning: exported type EnvVar should have comment or be unexported (golint)
    • Line 80: warning: exported type ServiceBindingProjectionStatus should have comment or be unexported (golint)
    • Line 86: warning: exported type ServiceBindingProjectionList should have comment or be unexported (golint)
    • Line 92: warning: exported method ServiceBindingProjection.Validate should have comment or be unexported (golint)
    • Line 148: warning: exported method EnvVar.Validate should have comment or be unexported (golint)
    • Line 163: warning: exported method ServiceBindingProjection.SetDefaults should have comment or be unexported (golint)
    • Line 167: warning: exported method ServiceBindingProjection.GetGroupVersionKind should have comment or be unexported (golint)
    • service-bindings/pkg/resolver/serviceable_resolver.go
    • Line 23: warning: comment on exported type ServiceableResolver should be of the form "ServiceableResolver ..." (with optional leading article) (golint)
    • Line 44: warning: exported method ServiceableResolver.ServiceableFromObjectReference should have comment or be unexported (golint)
    • service-bindings/pkg/reconciler/testing/listers.go
    • Line 32: warning: exported type Listers should have comment or be unexported (golint)
    • Line 36: warning: exported function NewListers should have comment or be unexported (golint)
    • Line 48: warning: exported function NewScheme should have comment or be unexported (golint)
    • Line 57: warning: exported method Listers.NewScheme should have comment or be unexported (golint)
    • Line 61: warning: exported method Listers.IndexerFor should have comment or be unexported (golint)
    • Line 65: warning: exported method Listers.GetKubeObjects should have comment or be unexported (golint)
    • Line 69: warning: exported method Listers.GetServiceBindingsObjects should have comment or be unexported (golint)
    • Line 73: warning: exported method Listers.GetNamespaceLister should have comment or be unexported (golint)
    • Line 77: warning: exported method Listers.GetSecretLister should have comment or be unexported (golint)
    • Line 81: warning: exported method Listers.GetServiceBindingLister should have comment or be unexported (golint)
    • Line 85: warning: exported method Listers.GetServiceBindingProjectionLister should have comment or be unexported (golint)
    • Line 89: warning: exported method Listers.GetProvisionedServiceLister should have comment or be unexported (golint)
    • service-bindings/pkg/reconciler/servicebinding/servicebinding.go
    • Line 130: warning: receiver name c should be consistent with previous receiver name r for Reconciler (golint)
    • Line 145: warning: receiver name c should be consistent with previous receiver name r for Reconciler (golint)
    • Line 195: warning: receiver name c should be consistent with previous receiver name r for Reconciler (golint)
    • Line 209: warning: receiver name c should be consistent with previous receiver name r for Reconciler (golint)
    • service-bindings/pkg/apis/duck/v1alpha2/serviceable_types.go
    • Line 18: warning: exported type Serviceable should have comment or be unexported (golint)
    • Line 24: warning: comment on exported type ServiceableType should be of the form "ServiceableType ..." (with optional leading article) (golint)
    • Line 35: warning: exported method ServiceableType.GetListType should have comment or be unexported (golint)
    • Line 39: warning: exported method ServiceableType.Populate should have comment or be unexported (golint)
    • Line 51: warning: exported method Serviceable.GetFullType should have comment or be unexported (golint)
    • Line 63: warning: comment on exported type ServiceableTypeList should be of the form "ServiceableTypeList ..." (with optional leading article) (golint)
    • service-bindings/pkg/apis/labs/v1alpha1/provisionedservice_lifecycle.go
    • Line 14: warning: exported const ProvisionedServiceConditionReady should have comment (or a comment on this block) or be unexported (golint)
    • Line 19: warning: exported method ProvisionedService.GetStatus should have comment or be unexported (golint)
    • Line 23: warning: exported method ProvisionedService.GetConditionSet should have comment or be unexported (golint)
    • Line 27: warning: exported method ProvisionedServiceStatus.MarkReady should have comment or be unexported (golint)
    • Line 31: warning: exported method ProvisionedServiceStatus.InitializeConditions should have comment or be unexported (golint)
    • service-bindings/pkg/apis/servicebinding/v1alpha2/servicebinding_types.go
    • Line 24: warning: exported const ServiceBindingAnnotationKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: comment on exported type ServiceBinding should be of the form "ServiceBinding ..." (with optional leading article) (golint)
    • Line 46: warning: exported type ServiceBindingSpec should have comment or be unexported (golint)
    • Line 72: warning: exported type ApplicationReference should have comment or be unexported (golint)
    • Line 74: warning: exported type EnvVar should have comment or be unexported (golint)
    • Line 76: warning: exported type Mapping should have comment or be unexported (golint)
    • Line 81: warning: exported type ServiceBindingStatus should have comment or be unexported (golint)
    • Line 88: warning: exported type ServiceBindingList should have comment or be unexported (golint)
    • Line 94: warning: exported method ServiceBinding.Validate should have comment or be unexported (golint)
    • Line 191: warning: exported method Mapping.Validate should have comment or be unexported (golint)
    • Line 201: warning: exported method ServiceBinding.SetDefaults should have comment or be unexported (golint)
    • Line 207: warning: exported method ServiceBinding.GetGroupVersionKind should have comment or be unexported (golint)
    • service-bindings/pkg/apis/labs/v1alpha1/provisionedservice_types.go
    • Line 20: warning: exported const ProvisionedServiceAnnotationKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 23: warning: comment on exported type ProvisionedService should be of the form "ProvisionedService ..." (with optional leading article) (golint)
    • Line 42: warning: exported type ProvisionedServiceSpec should have comment or be unexported (golint)
    • Line 46: warning: exported type ProvisionedServiceStatus should have comment or be unexported (golint)
    • Line 53: warning: exported type ProvisionedServiceList should have comment or be unexported (golint)
    • Line 59: warning: exported method ProvisionedService.Validate should have comment or be unexported (golint)
    • Line 69: warning: exported method ProvisionedService.SetDefaults should have comment or be unexported (golint)
    • Line 73: warning: exported method ProvisionedService.GetGroupVersionKind should have comment or be unexported (golint)
    • service-bindings/cmd/labs-service-bindings-manager/main.go
    • Line 40: warning: comment on exported var BindingExcludeLabel should be of the form "BindingExcludeLabel ..." (golint)
    • Line 48: warning: exported var ExclusionSelector should have comment or be unexported (golint)
    • Line 69: warning: exported function NewDefaultingAdmissionController should have comment or be unexported (golint)
    • Line 90: warning: exported function NewValidationAdmissionController should have comment or be unexported (golint)
    • Line 111: warning: exported function NewConfigValidationController should have comment or be unexported (golint)
    • Line 128: warning: exported function NewBindingWebhook should have comment or be unexported (golint)
    • Line 179: warning: exported type WithContextFactory should have comment or be unexported (golint)
    • service-bindings/pkg/apis/labsinternal/v1alpha1/servicebindingprojection_lifecycle.go
    • Line 25: warning: exported const ServiceBindingProjectionConditionReady should have comment (or a comment on this block) or be unexported (golint)
    • Line 36: warning: exported method ServiceBindingProjection.GetStatus should have comment or be unexported (golint)
    • Line 40: warning: exported method ServiceBindingProjection.GetConditionSet should have comment or be unexported (golint)
    • Line 44: warning: exported method ServiceBindingProjection.GetSubject should have comment or be unexported (golint)
    • Line 51: warning: exported method ServiceBindingProjection.GetBindingStatus should have comment or be unexported (golint)
    • Line 55: warning: exported method ServiceBindingProjection.Do should have comment or be unexported (golint)
    • Line 182: warning: exported method ServiceBindingProjection.Undo should have comment or be unexported (golint)
    • Line 248: warning: exported method ServiceBindingProjectionStatus.InitializeConditions should have comment or be unexported (golint)
    • Line 252: warning: exported method ServiceBindingProjectionStatus.MarkBindingAvailable should have comment or be unexported (golint)
    • Line 256: warning: exported method ServiceBindingProjectionStatus.MarkBindingUnavailable should have comment or be unexported (golint)
    • Line 265: warning: exported method ServiceBindingProjectionStatus.SetObservedGeneration should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell99%

Misspell Finds commonly misspelled English words