Preparing report...

Report for github.com/volcano-sh/volcano

A+    Excellent!    Found 54 issues across 276 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint87%

Golint is a linter for Go source code.

    • volcano/test/e2e/util/queue.go
    • Line 23: warning: should not use dot imports (golint)
    • Line 24: warning: should not use dot imports (golint)
    • Line 30: warning: exported function CreateQueues should have comment or be unexported (golint)
    • Line 71: warning: exported function SetQueueReclaimable should have comment or be unexported (golint)
    • Line 84: warning: exported function WaitQueueStatus should have comment or be unexported (golint)
    • volcano/pkg/scheduler/actions/preempt/preempt.go
    • Line 29: warning: exported type Action should have comment or be unexported (golint)
    • Line 31: warning: exported function New should have comment or be unexported (golint)
    • Line 35: warning: exported method Action.Name should have comment or be unexported (golint)
    • Line 39: warning: exported method Action.Initialize should have comment or be unexported (golint)
    • Line 41: warning: exported method Action.Execute should have comment or be unexported (golint)
    • Line 190: warning: exported method Action.UnInitialize should have comment or be unexported (golint)
    • volcano/pkg/scheduler/actions/allocate/allocate.go
    • Line 30: warning: exported type Action should have comment or be unexported (golint)
    • Line 32: warning: exported function New should have comment or be unexported (golint)
    • Line 36: warning: exported method Action.Name should have comment or be unexported (golint)
    • Line 40: warning: exported method Action.Initialize should have comment or be unexported (golint)
    • Line 42: warning: exported method Action.Execute should have comment or be unexported (golint)
    • Line 277: warning: exported method Action.UnInitialize should have comment or be unexported (golint)
    • volcano/pkg/webhooks/router/admission.go
    • Line 25: warning: exported type AdmissionHandler should have comment or be unexported (golint)
    • Line 30: warning: exported function RegisterAdmission should have comment or be unexported (golint)
    • Line 48: warning: exported function ForEachAdmission should have comment or be unexported (golint)
    • volcano/test/e2e/util/util.go
    • Line 28: warning: should not use dot imports (golint)
    • Line 29: warning: should not use dot imports (golint)
    • Line 47: warning: exported var OneMinute should have comment or be unexported (golint)
    • Line 61: warning: exported const TimeOutMessage should have comment (or a comment on this block) or be unexported (golint)
    • Line 73: warning: exported const DefaultBusyBoxImage should have comment (or a comment on this block) or be unexported (golint)
    • Line 79: warning: exported function CpuResource should have comment or be unexported (golint)
    • Line 83: warning: exported function HomeDir should have comment or be unexported (golint)
    • Line 90: warning: exported function MasterURL should have comment or be unexported (golint)
    • Line 97: warning: exported function KubeconfigPath should have comment or be unexported (golint)
    • Line 112: warning: exported type TestContext should have comment or be unexported (golint)
    • Line 122: warning: exported type Options should have comment or be unexported (golint)
    • Line 130: warning: exported var VcClient should have comment or be unexported (golint)
    • Line 131: warning: exported var KubeClient should have comment or be unexported (golint)
    • Line 133: warning: exported function InitTestContext should have comment or be unexported (golint)
    • Line 169: warning: exported function NamespaceNotExist should have comment or be unexported (golint)
    • Line 173: warning: exported function NamespaceNotExistWithName should have comment or be unexported (golint)
    • Line 183: warning: exported function FileExist should have comment or be unexported (golint)
    • Line 192: warning: exported function CleanupTestContext should have comment or be unexported (golint)
    • volcano/pkg/scheduler/actions/backfill/backfill.go
    • Line 28: warning: exported type Action should have comment or be unexported (golint)
    • Line 30: warning: exported function New should have comment or be unexported (golint)
    • Line 34: warning: exported method Action.Name should have comment or be unexported (golint)
    • Line 38: warning: exported method Action.Initialize should have comment or be unexported (golint)
    • Line 40: warning: exported method Action.Execute should have comment or be unexported (golint)
    • Line 93: warning: exported method Action.UnInitialize should have comment or be unexported (golint)
    • volcano/test/e2e/util/node.go
    • Line 24: warning: should not use dot imports (golint)
    • Line 34: warning: exported function ClusterSize should have comment or be unexported (golint)
    • Line 105: warning: exported function ComputeNode should have comment or be unexported (golint)
    • Line 197: warning: exported function RemoveTaintsFromAllNodes should have comment or be unexported (golint)
    • volcano/test/e2e/util/replicaset.go
    • Line 23: warning: should not use dot imports (golint)
    • Line 97: warning: exported function WaitReplicaSetReady should have comment or be unexported (golint)
    • Line 101: warning: exported function DeleteReplicaSet should have comment or be unexported (golint)
    • volcano/pkg/scheduler/actions/reclaim/reclaim.go
    • Line 28: warning: exported type Action should have comment or be unexported (golint)
    • Line 30: warning: exported function New should have comment or be unexported (golint)
    • Line 34: warning: exported method Action.Name should have comment or be unexported (golint)
    • Line 38: warning: exported method Action.Initialize should have comment or be unexported (golint)
    • Line 40: warning: exported method Action.Execute should have comment or be unexported (golint)
    • Line 191: warning: exported method Action.UnInitialize should have comment or be unexported (golint)
    • volcano/pkg/scheduler/actions/enqueue/enqueue.go
    • Line 31: warning: exported type Action should have comment or be unexported (golint)
    • Line 33: warning: exported function New should have comment or be unexported (golint)
    • Line 37: warning: exported method Action.Name should have comment or be unexported (golint)
    • Line 41: warning: exported method Action.Initialize should have comment or be unexported (golint)
    • Line 43: warning: exported method Action.Execute should have comment or be unexported (golint)
    • Line 104: warning: exported method Action.UnInitialize should have comment or be unexported (golint)
    • volcano/test/e2e/util/job.go
    • Line 27: warning: should not use dot imports (golint)
    • Line 39: warning: exported type TaskSpec should have comment or be unexported (golint)
    • Line 57: warning: exported type JobSpec should have comment or be unexported (golint)
    • Line 73: warning: exported function Namespace should have comment or be unexported (golint)
    • Line 81: warning: exported function CreateJob should have comment or be unexported (golint)
    • Line 87: warning: exported function CreateJobWithPodGroup should have comment or be unexported (golint)
    • Line 172: warning: exported function UpdateJob should have comment or be unexported (golint)
    • Line 184: warning: exported function CreateJobInner should have comment or be unexported (golint)
    • Line 264: warning: exported function WaitTaskPhase should have comment or be unexported (golint)
    • Line 368: warning: exported function JobEvicted should have comment or be unexported (golint)
    • Line 389: warning: exported function WaitJobPhases should have comment or be unexported (golint)
    • Line 462: warning: exported function WaitJobStates should have comment or be unexported (golint)
    • Line 494: warning: exported function WaitTasksReadyEx should have comment or be unexported (golint)
    • Line 562: warning: exported function WaitJobPhaseReady should have comment or be unexported (golint)
    • Line 582: warning: exported function WaitJobUnschedulable should have comment or be unexported (golint)
    • Line 587: warning: exported function CreateContainers should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign0%

IneffAssign detects ineffectual assignments in Go code.

An error occurred while running this test (exit status 2)


misspell0%

Misspell Finds commonly misspelled English words

An error occurred while running this test (exit status 2)