gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• direktiv/pkg/direktiv/ingress.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• direktiv/pkg/direktiv/timer.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• direktiv/pkg/direktiv/wfserver.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint56%

Golint is a linter for Go source code.

• direktiv/pkg/secrets/handler/db.go
  • Line 12: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• direktiv/pkg/model/start-common.go
  • Line 7: warning: exported type StartDefinition should have comment or be unexported (golint)
  • Line 14: warning: exported method Workflow.GetStartDefinition should have comment or be unexported (golint)
  • Line 24: warning: comment on exported type StartEventDefinition should be of the form "StartEventDefinition ..." (with optional leading article) (golint)
  • Line 30: warning: exported method StartEventDefinition.Validate should have comment or be unexported (golint)
  • Line 38: warning: exported type StartCommon should have comment or be unexported (golint)
  • Line 50: warning: exported method StartCommon.GetType should have comment or be unexported (golint)
  • Line 60: warning: exported method StartCommon.GetState should have comment or be unexported (golint)

• direktiv/pkg/model/workflow.go
  • Line 14: warning: exported type Workflow should have comment or be unexported (golint)
  • Line 212: warning: exported method Workflow.GetStates should have comment or be unexported (golint)
  • Line 260: warning: exported method Workflow.GetSchemas should have comment or be unexported (golint)
  • Line 268: warning: exported method Workflow.GetFunctions should have comment or be unexported (golint)
  • Line 276: warning: exported method Workflow.GetFunction should have comment or be unexported (golint)
  • Line 288: warning: exported method Workflow.UnmarshalYAML should have comment or be unexported (golint)
  • Line 305: warning: exported method Workflow.Load should have comment or be unexported (golint)
  • Line 309: warning: exported method Workflow.GetStartState should have comment or be unexported (golint)

• direktiv/pkg/direktiv/grpc_util.go
  • Line 30: warning: exported function AddGlobalGRPCDialOption should have comment or be unexported (golint)
  • Line 36: warning: exported function AddGlobalGRPCServerOption should have comment or be unexported (golint)

• direktiv/pkg/direktiv/state-logic-action.go
  • Line 224: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 262: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• direktiv/pkg/dlog/dummy/logger.go
  • Line 10: warning: exported type DummyLogger should have comment or be unexported (golint)
  • Line 13: warning: exported function NewLogger should have comment or be unexported (golint)
  • Line 26: warning: exported method DummyLogger.NamespaceLogger should have comment or be unexported (golint)
  • Line 31: warning: exported method DummyLogger.LoggerFunc should have comment or be unexported (golint)
  • Line 37: warning: exported method DummyLogger.QueryNamespaceLogs should have comment or be unexported (golint)
  • Line 45: warning: exported method DummyLogger.QueryLogs should have comment or be unexported (golint)
  • Line 53: warning: exported method DummyLogger.QueryAllLogs should have comment or be unexported (golint)
  • Line 61: warning: exported method DummyLogger.DeleteNamespaceLogs should have comment or be unexported (golint)
  • Line 65: warning: exported method DummyLogger.DeleteInstanceLogs should have comment or be unexported (golint)

• direktiv/pkg/model/common-structures.go
  • Line 16: warning: exported const CommonNameRegex should have comment or be unexported (golint)
  • Line 18: warning: exported type TimeoutDefinition should have comment or be unexported (golint)
  • Line 23: warning: exported method TimeoutDefinition.Validate should have comment or be unexported (golint)
  • Line 38: warning: exported type FunctionFileDefinition should have comment or be unexported (golint)
  • Line 45: warning: exported method FunctionFileDefinition.Validate should have comment or be unexported (golint)
  • Line 74: warning: exported type FunctionDefinition should have comment or be unexported (golint)
  • Line 83: warning: exported method FunctionDefinition.Validate should have comment or be unexported (golint)
  • Line 116: warning: exported type SchemaDefinition should have comment or be unexported (golint)
  • Line 121: warning: exported method SchemaDefinition.Validate should have comment or be unexported (golint)
  • Line 138: warning: exported type ActionDefinition should have comment or be unexported (golint)
  • Line 145: warning: exported method ActionDefinition.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/start-events-and.go
  • Line 7: warning: exported type EventsAndStart should have comment or be unexported (golint)
  • Line 14: warning: exported method EventsAndStart.GetEvents should have comment or be unexported (golint)
  • Line 24: warning: exported method EventsAndStart.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-action.go
  • Line 9: warning: exported type ActionState should have comment or be unexported (golint)
  • Line 18: warning: exported method ActionState.GetID should have comment or be unexported (golint)
  • Line 37: warning: exported method ActionState.GetTransitions should have comment or be unexported (golint)
  • Line 52: warning: exported method ActionState.Validate should have comment or be unexported (golint)

• direktiv/cmd/sidecar/network-server.go
  • Line 16: warning: exported type NetworkServer should have comment or be unexported (golint)
  • Line 24: warning: exported method NetworkServer.Start should have comment or be unexported (golint)

• direktiv/pkg/direktiv/errors.go
  • Line 75: warning: exported type UncatchableError should have comment or be unexported (golint)
  • Line 80: warning: exported function NewUncatchableError should have comment or be unexported (golint)
  • Line 91: warning: exported type CatchableError should have comment or be unexported (golint)
  • Line 96: warning: exported function NewCatchableError should have comment or be unexported (golint)
  • Line 107: warning: exported function WrapCatchableError should have comment or be unexported (golint)
  • Line 114: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 120: warning: exported type InternalError should have comment or be unexported (golint)
  • Line 127: warning: exported function NewInternalError should have comment or be unexported (golint)
  • Line 146: warning: exported function NewInternalErrorWithDepth should have comment or be unexported (golint)
  • Line 168: warning: exported const DirektivError should have comment (or a comment on this block) or be unexported (golint)
  • Line 169: warning: comment on exported const ValidationError should be of the form "ValidationError ..." (golint)

• direktiv/pkg/dlog/db/logger.go
  • Line 13: warning: exported type Logger should have comment or be unexported (golint)
  • Line 17: warning: exported method Logger.Connect should have comment or be unexported (golint)
  • Line 37: warning: exported method Logger.CloseConnection should have comment or be unexported (golint)
  • Line 41: warning: exported function NewLogger should have comment or be unexported (golint)
  • Line 56: warning: exported method Logger.NamespaceLogger should have comment or be unexported (golint)
  • Line 74: warning: exported method Logger.LoggerFunc should have comment or be unexported (golint)
  • Line 96: warning: exported method Logger.QueryNamespaceLogs should have comment or be unexported (golint)
  • Line 145: warning: exported method Logger.QueryLogs should have comment or be unexported (golint)
  • Line 204: warning: exported method Logger.DeleteNamespaceLogs should have comment or be unexported (golint)
  • Line 220: warning: exported method Logger.DeleteInstanceLogs should have comment or be unexported (golint)

• direktiv/pkg/varstore/varstore.go
  • Line 8: warning: exported type VarStorage should have comment or be unexported (golint)
  • Line 17: warning: exported type VarReader should have comment or be unexported (golint)
  • Line 23: warning: exported type VarInfo should have comment or be unexported (golint)

• direktiv/pkg/model/state-validate.go
  • Line 8: warning: exported type ValidateState should have comment or be unexported (golint)
  • Line 16: warning: exported method ValidateState.GetID should have comment or be unexported (golint)
  • Line 35: warning: exported method ValidateState.GetTransitions should have comment or be unexported (golint)
  • Line 50: warning: exported method ValidateState.Validate should have comment or be unexported (golint)

• direktiv/cmd/sidecar/local-server.go
  • Line 35: warning: exported type LocalServer should have comment or be unexported (golint)
  • Line 116: warning: exported method LocalServer.Start should have comment or be unexported (golint)
  • Line 325: warning: context.Context should be the first parameter of a function (golint)

• direktiv/pkg/dlog/db/handler.go
  • Line 15: warning: exported type Handler should have comment or be unexported (golint)
  • Line 24: warning: exported type HandlerArgs should have comment or be unexported (golint)
  • Line 31: warning: exported function NewHandler should have comment or be unexported (golint)
  • Line 177: warning: exported method Handler.Log should have comment or be unexported (golint)
  • Line 182: warning: exported method Handler.Close should have comment or be unexported (golint)

• direktiv/pkg/varstore/postgres.go
  • Line 29: warning: exported function NewPostgresVarStorage should have comment or be unexported (golint)

• direktiv/pkg/model/start-default.go
  • Line 3: warning: exported type DefaultStart should have comment or be unexported (golint)
  • Line 7: warning: exported method DefaultStart.GetEvents should have comment or be unexported (golint)
  • Line 11: warning: exported method DefaultStart.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-common.go
  • Line 10: warning: exported type RetryDefinition should have comment or be unexported (golint)
  • Line 17: warning: exported method RetryDefinition.Validate should have comment or be unexported (golint)
  • Line 33: warning: exported type ErrorDefinition should have comment or be unexported (golint)
  • Line 38: warning: exported method ErrorDefinition.Validate should have comment or be unexported (golint)
  • Line 46: warning: exported type State should have comment or be unexported (golint)
  • Line 55: warning: exported type ConsumeEventDefinition should have comment or be unexported (golint)
  • Line 60: warning: exported method ConsumeEventDefinition.Validate should have comment or be unexported (golint)
  • Line 69: warning: exported type ProduceEventDefinition should have comment or be unexported (golint)
  • Line 76: warning: exported method ProduceEventDefinition.Validate should have comment or be unexported (golint)
  • Line 89: warning: exported type StateCommon should have comment or be unexported (golint)
  • Line 97: warning: exported method StateCommon.GetType should have comment or be unexported (golint)
  • Line 101: warning: exported method StateCommon.ErrorDefinitions should have comment or be unexported (golint)
  • Line 109: warning: exported method StateCommon.RetryDefinition should have comment or be unexported (golint)

• direktiv/pkg/model/state-consume.go
  • Line 8: warning: exported type ConsumeEventState should have comment or be unexported (golint)
  • Line 16: warning: exported method ConsumeEventState.GetID should have comment or be unexported (golint)
  • Line 35: warning: exported method ConsumeEventState.GetTransitions should have comment or be unexported (golint)
  • Line 50: warning: exported method ConsumeEventState.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-events-xor.go
  • Line 8: warning: exported type EventConditionDefinition should have comment or be unexported (golint)
  • Line 14: warning: exported type EventsXorState should have comment or be unexported (golint)
  • Line 20: warning: exported method EventsXorState.GetID should have comment or be unexported (golint)
  • Line 42: warning: exported method EventsXorState.GetTransitions should have comment or be unexported (golint)
  • Line 60: warning: exported method EventsXorState.GetEvents should have comment or be unexported (golint)
  • Line 68: warning: exported method EventsXorState.Validate should have comment or be unexported (golint)

• direktiv/pkg/api/routes.go
  • Line 5: warning: don't use underscores in Go names; const RN_Preflight should be RNPreflight (golint)
  • Line 6: warning: don't use underscores in Go names; const RN_ListNamespaces should be RNListNamespaces (golint)
  • Line 7: warning: don't use underscores in Go names; const RN_AddNamespace should be RNAddNamespace (golint)
  • Line 8: warning: don't use underscores in Go names; const RN_DeleteNamespace should be RNDeleteNamespace (golint)
  • Line 9: warning: don't use underscores in Go names; const RN_NamespaceEvent should be RNNamespaceEvent (golint)
  • Line 10: warning: don't use underscores in Go names; const RN_ListSecrets should be RNListSecrets (golint)
  • Line 11: warning: don't use underscores in Go names; const RN_CreateSecret should be RNCreateSecret (golint)
  • Line 12: warning: don't use underscores in Go names; const RN_DeleteSecret should be RNDeleteSecret (golint)
  • Line 13: warning: don't use underscores in Go names; const RN_ListRegistries should be RNListRegistries (golint)
  • Line 14: warning: don't use underscores in Go names; const RN_CreateRegistry should be RNCreateRegistry (golint)
  • Line 15: warning: don't use underscores in Go names; const RN_DeleteRegistry should be RNDeleteRegistry (golint)
  • Line 16: warning: don't use underscores in Go names; const RN_GetWorkflowMetrics should be RNGetWorkflowMetrics (golint)
  • Line 17: warning: don't use underscores in Go names; const RN_ListWorkflows should be RNListWorkflows (golint)
  • Line 18: warning: don't use underscores in Go names; const RN_GetWorkflow should be RNGetWorkflow (golint)
  • Line 19: warning: don't use underscores in Go names; const RN_UpdateWorkflow should be RNUpdateWorkflow (golint)
  • Line 20: warning: don't use underscores in Go names; const RN_ToggleWorkflow should be RNToggleWorkflow (golint)
  • Line 21: warning: don't use underscores in Go names; const RN_CreateWorkflow should be RNCreateWorkflow (golint)
  • Line 22: warning: don't use underscores in Go names; const RN_DeleteWorkflow should be RNDeleteWorkflow (golint)
  • Line 23: warning: don't use underscores in Go names; const RN_DownloadWorkflow should be RNDownloadWorkflow (golint)
  • Line 24: warning: don't use underscores in Go names; const RN_ExecuteWorkflow should be RNExecuteWorkflow (golint)
  • Line 25: warning: don't use underscores in Go names; const RN_ListWorkflowInstances should be RNListWorkflowInstances (golint)
  • Line 26: warning: don't use underscores in Go names; const RN_ListInstances should be RNListInstances (golint)
  • Line 27: warning: don't use underscores in Go names; const RN_GetInstance should be RNGetInstance (golint)
  • Line 28: warning: don't use underscores in Go names; const RN_CancelInstance should be RNCancelInstance (golint)
  • Line 29: warning: don't use underscores in Go names; const RN_GetInstanceLogs should be RNGetInstanceLogs (golint)
  • Line 30: warning: don't use underscores in Go names; const RN_ListActionTemplateFolders should be RNListActionTemplateFolders (golint)
  • Line 31: warning: don't use underscores in Go names; const RN_ListActionTemplates should be RNListActionTemplates (golint)
  • Line 32: warning: don't use underscores in Go names; const RN_GetActionTemplate should be RNGetActionTemplate (golint)
  • Line 33: warning: don't use underscores in Go names; const RN_ListWorkflowTemplateFolders should be RNListWorkflowTemplateFolders (golint)
  • Line 34: warning: don't use underscores in Go names; const RN_ListWorkflowTemplates should be RNListWorkflowTemplates (golint)
  • Line 35: warning: don't use underscores in Go names; const RN_GetWorkflowTemplate should be RNGetWorkflowTemplate (golint)
  • Line 36: warning: don't use underscores in Go names; const RN_ListWorkflowVariables should be RNListWorkflowVariables (golint)
  • Line 37: warning: don't use underscores in Go names; const RN_GetWorkflowVariable should be RNGetWorkflowVariable (golint)
  • Line 38: warning: don't use underscores in Go names; const RN_SetWorkflowVariable should be RNSetWorkflowVariable (golint)
  • Line 39: warning: don't use underscores in Go names; const RN_ListNamespaceVariables should be RNListNamespaceVariables (golint)
  • Line 40: warning: don't use underscores in Go names; const RN_GetNamespaceVariable should be RNGetNamespaceVariable (golint)
  • Line 41: warning: don't use underscores in Go names; const RN_GetNamespaceLogs should be RNGetNamespaceLogs (golint)
  • Line 42: warning: don't use underscores in Go names; const RN_SetNamespaceVariable should be RNSetNamespaceVariable (golint)
  • Line 43: warning: don't use underscores in Go names; const RN_JQPlayground should be RNJQPlayground (golint)
  • Line 46: warning: exported var RouteNames should have comment or be unexported (golint)

• direktiv/pkg/direktiv/wli.go
  • Line 824: warning: exported function InstanceMemory should have comment or be unexported (golint)

• direktiv/pkg/secrets/handler/handlers.go
  • Line 8: warning: exported type SecretType should have comment or be unexported (golint)
  • Line 11: warning: exported const DBSecretType should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported type SecretsHandlerInstantiator should have comment or be unexported (golint)
  • Line 22: warning: exported type SecretsHandler should have comment or be unexported (golint)
  • Line 30: warning: exported method SecretType.Setup should have comment or be unexported (golint)
  • Line 34: warning: exported function ParseType should have comment or be unexported (golint)
  • Line 48: warning: exported function ListRegisteredTypes should have comment or be unexported (golint)
  • Line 57: warning: exported function ListRegisteredTypesString should have comment or be unexported (golint)
  • Line 71: warning: exported function RegisterNewSecretType should have comment or be unexported (golint)

• direktiv/pkg/model/state-noop.go
  • Line 7: warning: exported type NoopState should have comment or be unexported (golint)
  • Line 13: warning: exported method NoopState.GetID should have comment or be unexported (golint)
  • Line 32: warning: exported method NoopState.GetTransitions should have comment or be unexported (golint)
  • Line 47: warning: exported method NoopState.Validate should have comment or be unexported (golint)

• direktiv/cmd/sidecar/threads.go
  • Line 20: warning: exported type Threads should have comment or be unexported (golint)
  • Line 30: warning: exported method Threads.Wait should have comment or be unexported (golint)
  • Line 35: warning: exported method Threads.Register should have comment or be unexported (golint)
  • Line 64: warning: exported method Threads.Stop should have comment or be unexported (golint)
  • Line 88: warning: exported method Threads.ExitStatus should have comment or be unexported (golint)

• direktiv/pkg/api/handlers.go
  • Line 24: warning: exported type Handler should have comment or be unexported (golint)

• direktiv/pkg/direktiv/engine.go
  • Line 1082: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1157: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 1345: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• direktiv/pkg/metrics/metrics.go
  • Line 39: warning: exported method Client.InsertRecord should have comment or be unexported (golint)
  • Line 58: warning: exported method Client.GetMetrics should have comment or be unexported (golint)

• direktiv/pkg/dlog/common.go
  • Line 10: warning: exported type Logger should have comment or be unexported (golint)
  • Line 15: warning: exported type Log should have comment or be unexported (golint)
  • Line 24: warning: exported type LogEntry should have comment or be unexported (golint)
  • Line 31: warning: exported type QueryReponse should have comment or be unexported (golint)

• direktiv/pkg/model/start-events-xor.go
  • Line 5: warning: exported type EventsXorStart should have comment or be unexported (golint)
  • Line 10: warning: exported method EventsXorStart.GetEvents should have comment or be unexported (golint)
  • Line 20: warning: exported method EventsXorStart.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-events-and.go
  • Line 8: warning: exported type EventsAndState should have comment or be unexported (golint)
  • Line 16: warning: exported method EventsAndState.GetID should have comment or be unexported (golint)
  • Line 35: warning: exported method EventsAndState.GetTransitions should have comment or be unexported (golint)
  • Line 50: warning: exported method EventsAndState.GetEvents should have comment or be unexported (golint)
  • Line 58: warning: exported method EventsAndState.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-getter.go
  • Line 8: warning: exported type GetterState should have comment or be unexported (golint)
  • Line 15: warning: exported type GetterDefinition should have comment or be unexported (golint)
  • Line 20: warning: exported method GetterDefinition.Validate should have comment or be unexported (golint)
  • Line 34: warning: exported method GetterState.GetID should have comment or be unexported (golint)
  • Line 53: warning: exported method GetterState.GetTransitions should have comment or be unexported (golint)
  • Line 68: warning: exported method GetterState.Validate should have comment or be unexported (golint)

• direktiv/cmd/sidecar/signal.go
  • Line 12: warning: exported type SignalListener should have comment or be unexported (golint)
  • Line 17: warning: exported method SignalListener.Start should have comment or be unexported (golint)

• direktiv/pkg/model/state-foreach.go
  • Line 8: warning: exported type ForEachState should have comment or be unexported (golint)
  • Line 17: warning: exported method ForEachState.GetID should have comment or be unexported (golint)
  • Line 36: warning: exported method ForEachState.GetTransitions should have comment or be unexported (golint)
  • Line 51: warning: exported method ForEachState.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-parallel.go
  • Line 8: warning: exported type ParallelState should have comment or be unexported (golint)
  • Line 17: warning: exported method ParallelState.GetID should have comment or be unexported (golint)
  • Line 36: warning: exported method ParallelState.GetTransitions should have comment or be unexported (golint)
  • Line 51: warning: exported method ParallelState.GetActions should have comment or be unexported (golint)
  • Line 59: warning: exported method ParallelState.Validate should have comment or be unexported (golint)

• direktiv/pkg/metrics/types.go
  • Line 5: warning: exported type NextEnum should have comment or be unexported (golint)
  • Line 8: warning: exported const NextEnd should have comment (or a comment on this block) or be unexported (golint)
  • Line 13: warning: exported var NextEnums should have comment or be unexported (golint)
  • Line 17: warning: exported type InvokerEnum should have comment or be unexported (golint)
  • Line 20: warning: exported const InvokerUnknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported var InvokerEnumLabels should have comment or be unexported (golint)

• direktiv/pkg/model/enums.go
  • Line 10: warning: exported type BranchMode should have comment or be unexported (golint)
  • Line 13: warning: exported const BranchModeAnd should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported function ParseBranchMode should have comment or be unexported (golint)
  • Line 42: warning: exported method BranchMode.MarshalJSON should have comment or be unexported (golint)
  • Line 46: warning: exported method BranchMode.UnmarshalJSON should have comment or be unexported (golint)
  • Line 66: warning: exported method BranchMode.MarshalYAML should have comment or be unexported (golint)
  • Line 70: warning: exported method BranchMode.UnmarshalYAML should have comment or be unexported (golint)
  • Line 96: warning: exported const SmallSize should have comment (or a comment on this block) or be unexported (golint)
  • Line 107: warning: exported function ParseSize should have comment or be unexported (golint)
  • Line 127: warning: exported method Size.MarshalJSON should have comment or be unexported (golint)
  • Line 131: warning: exported method Size.UnmarshalJSON should have comment or be unexported (golint)
  • Line 151: warning: exported method Size.MarshalYAML should have comment or be unexported (golint)
  • Line 155: warning: exported method Size.UnmarshalYAML should have comment or be unexported (golint)
  • Line 177: warning: exported type StateType should have comment or be unexported (golint)
  • Line 180: warning: exported const StateTypeAction should have comment (or a comment on this block) or be unexported (golint)
  • Line 217: warning: exported function ParseStateType should have comment or be unexported (golint)
  • Line 237: warning: exported method StateType.MarshalJSON should have comment or be unexported (golint)
  • Line 241: warning: exported method StateType.UnmarshalJSON should have comment or be unexported (golint)
  • Line 261: warning: exported method StateType.MarshalYAML should have comment or be unexported (golint)
  • Line 265: warning: exported method StateType.UnmarshalYAML should have comment or be unexported (golint)
  • Line 287: warning: exported type StartType should have comment or be unexported (golint)
  • Line 290: warning: exported const StartTypeDefault should have comment (or a comment on this block) or be unexported (golint)
  • Line 305: warning: exported function ParseStartType should have comment or be unexported (golint)
  • Line 325: warning: exported method StartType.MarshalJSON should have comment or be unexported (golint)
  • Line 329: warning: exported method StartType.UnmarshalJSON should have comment or be unexported (golint)
  • Line 349: warning: exported method StartType.MarshalYAML should have comment or be unexported (golint)
  • Line 353: warning: exported method StartType.UnmarshalYAML should have comment or be unexported (golint)

• direktiv/pkg/model/start-event.go
  • Line 5: warning: exported type EventStart should have comment or be unexported (golint)
  • Line 10: warning: exported method EventStart.GetEvents should have comment or be unexported (golint)
  • Line 18: warning: exported method EventStart.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/start-scheduled.go
  • Line 3: warning: exported type ScheduledStart should have comment or be unexported (golint)
  • Line 8: warning: exported method ScheduledStart.GetEvents should have comment or be unexported (golint)
  • Line 12: warning: exported method ScheduledStart.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-callback.go
  • Line 8: warning: exported type CallbackState should have comment or be unexported (golint)
  • Line 17: warning: exported method CallbackState.GetID should have comment or be unexported (golint)
  • Line 36: warning: exported method CallbackState.GetTransitions should have comment or be unexported (golint)
  • Line 51: warning: exported method CallbackState.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-delay.go
  • Line 8: warning: exported type DelayState should have comment or be unexported (golint)
  • Line 15: warning: exported method DelayState.GetID should have comment or be unexported (golint)
  • Line 34: warning: exported method DelayState.GetTransitions should have comment or be unexported (golint)
  • Line 49: warning: exported method DelayState.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-setter.go
  • Line 8: warning: exported type SetterState should have comment or be unexported (golint)
  • Line 15: warning: exported type SetterDefinition should have comment or be unexported (golint)
  • Line 21: warning: exported method SetterDefinition.Validate should have comment or be unexported (golint)
  • Line 43: warning: exported method SetterState.GetID should have comment or be unexported (golint)
  • Line 62: warning: exported method SetterState.GetTransitions should have comment or be unexported (golint)
  • Line 77: warning: exported method SetterState.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-switch.go
  • Line 8: warning: exported type SwitchConditionDefinition should have comment or be unexported (golint)
  • Line 14: warning: exported method SwitchConditionDefinition.Validate should have comment or be unexported (golint)
  • Line 26: warning: exported type SwitchState should have comment or be unexported (golint)
  • Line 33: warning: exported method SwitchState.GetID should have comment or be unexported (golint)
  • Line 57: warning: exported method SwitchState.GetTransitions should have comment or be unexported (golint)
  • Line 77: warning: exported method SwitchState.GetConditions should have comment or be unexported (golint)
  • Line 85: warning: exported method SwitchState.Validate should have comment or be unexported (golint)

• direktiv/pkg/api/types.go
  • Line 3: warning: exported type NameDataTuple should have comment or be unexported (golint)
  • Line 8: warning: exported type RequestStatus should have comment or be unexported (golint)
  • Line 13: warning: exported type JQQuery should have comment or be unexported (golint)
  • Line 18: warning: comment on exported type GithubFileInfo should be of the form "GithubFileInfo ..." (with optional leading article) (golint)
  • Line 36: warning: exported type NamedDirectory should have comment or be unexported (golint)

• direktiv/pkg/direktiv/sync.go
  • Line 27: warning: exported const ApiSync should have comment or be unexported (golint)

• direktiv/pkg/model/state-error.go
  • Line 7: warning: exported type ErrorState should have comment or be unexported (golint)
  • Line 16: warning: exported method ErrorState.GetID should have comment or be unexported (golint)
  • Line 29: warning: exported method ErrorState.GetTransitions should have comment or be unexported (golint)
  • Line 38: warning: exported method ErrorState.GetArgs should have comment or be unexported (golint)
  • Line 46: warning: exported method ErrorState.Validate should have comment or be unexported (golint)

• direktiv/pkg/model/state-generate-event.go
  • Line 8: warning: exported type GenerateEventDefinition should have comment or be unexported (golint)
  • Line 16: warning: exported method GenerateEventDefinition.Validate should have comment or be unexported (golint)
  • Line 28: warning: exported type GenerateEventState should have comment or be unexported (golint)
  • Line 35: warning: exported method GenerateEventState.GetID should have comment or be unexported (golint)
  • Line 54: warning: exported method GenerateEventState.GetTransitions should have comment or be unexported (golint)
  • Line 69: warning: exported method GenerateEventState.Validate should have comment or be unexported (golint)

• direktiv/cmd/sidecar/main.go
  • Line 37: warning: exported const SUCCESS should have comment (or a comment on this block) or be unexported (golint)
  • Line 41: warning: exported function Shutdown should have comment or be unexported (golint)
  • Line 46: warning: exported function ForceQuit should have comment or be unexported (golint)

• direktiv/pkg/direktiv/wfserver.go
  • Line 145: warning: exported method WorkflowServer.SetVariableStorage should have comment or be unexported (golint)

gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• direktiv/cmd/sidecar/local-server.go
  • Line 859: warning: cyclomatic complexity 19 of function (*inboundWorker).fileWriter() is high (> 15) (gocyclo)
  • Line 1014: warning: cyclomatic complexity 16 of function (*LocalServer).setVar() is high (> 15) (gocyclo)

• direktiv/pkg/api/error.go
  • Line 10: warning: cyclomatic complexity 17 of function convertGRPCStatusCodeToHTTPCode() is high (> 15) (gocyclo)

• direktiv/pkg/direktiv/state-logic-parallel.go
  • Line 211: warning: cyclomatic complexity 24 of function (*parallelStateLogic).Run() is high (> 15) (gocyclo)

• direktiv/pkg/direktiv/events.go
  • Line 141: warning: cyclomatic complexity 17 of function (*WorkflowServer).handleEvent() is high (> 15) (gocyclo)

• direktiv/pkg/direktiv/sync.go
  • Line 128: warning: cyclomatic complexity 27 of function (*WorkflowServer).startDatabaseListener() is high (> 15) (gocyclo)

• direktiv/pkg/direktiv/state-logic-action.go
  • Line 121: warning: cyclomatic complexity 27 of function (*actionStateLogic).Run() is high (> 15) (gocyclo)

• direktiv/pkg/direktiv/engine.go
  • Line 971: warning: cyclomatic complexity 23 of function (*workflowEngine).runState() is high (> 15) (gocyclo)
  • Line 324: warning: cyclomatic complexity 19 of function (*workflowEngine).doHTTPRequest() is high (> 15) (gocyclo)
  • Line 667: warning: cyclomatic complexity 18 of function (*workflowEngine).cancelInstance() is high (> 15) (gocyclo)
  • Line 1407: warning: cyclomatic complexity 16 of function (*workflowEngine).listenForEvents() is high (> 15) (gocyclo)
  • Line 1222: warning: cyclomatic complexity 16 of function (*workflowEngine).EventsInvoke() is high (> 15) (gocyclo)

• direktiv/pkg/metrics/metrics.go
  • Line 76: warning: cyclomatic complexity 25 of function generateDataset() is high (> 15) (gocyclo)

• direktiv/pkg/model/workflow.go
  • Line 124: warning: cyclomatic complexity 21 of function (*Workflow).validate() is high (> 15) (gocyclo)

• direktiv/pkg/model/state-common.go
  • Line 138: warning: cyclomatic complexity 18 of function getStateFromType() is high (> 15) (gocyclo)

• direktiv/pkg/direktiv/state-logic-foreach.go
  • Line 86: warning: cyclomatic complexity 33 of function (*foreachStateLogic).Run() is high (> 15) (gocyclo)

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

• direktiv/cmd/sidecar/local-server.go
  • Line 1028: warning: ineffectual assignment to err (ineffassign)
  • Line 1042: warning: ineffectual assignment to err (ineffassign)
  • Line 1059: warning: ineffectual assignment to err (ineffassign)

• direktiv/pkg/model/workflow.go
  • Line 87: warning: ineffectual assignment to err (ineffassign)
  • Line 107: warning: ineffectual assignment to err (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell99%

Misspell Finds commonly misspelled English words

• direktiv/pkg/api/server.go
  • Line 172: warning: "Varaibles" is a misspelling of "Variables" (misspell)