Preparing report...

Report for github.com/vouv/srun

A    Great!    Found 13 issues across 14 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint7%

Golint is a linter for Go source code.

    • srun/cmd/srun/cli.go
    • Line 18: warning: exported function Login should have comment or be unexported (golint)
    • Line 25: warning: exported function LoginE should have comment or be unexported (golint)
    • Line 40: warning: exported function Logout should have comment or be unexported (golint)
    • Line 47: warning: exported function LogoutE should have comment or be unexported (golint)
    • Line 61: warning: exported function Info should have comment or be unexported (golint)
    • Line 68: warning: exported function InfoE should have comment or be unexported (golint)
    • Line 77: warning: exported function Config should have comment or be unexported (golint)
    • Line 84: warning: exported function ConfigE should have comment or be unexported (golint)
    • Line 125: warning: exported function VersionString should have comment or be unexported (golint)
    • Line 133: warning: exported function Update should have comment or be unexported (golint)
    • srun/model/request.go
    • Line 8: warning: exported function Challenge should have comment or be unexported (golint)
    • Line 15: warning: exported function Login should have comment or be unexported (golint)
    • Line 29: warning: exported function Logout should have comment or be unexported (golint)
    • srun/store/store.go
    • Line 15: warning: exported var RootPath should have comment or be unexported (golint)
    • Line 17: warning: exported function SetAccount should have comment or be unexported (golint)
    • Line 24: warning: exported function ReadAccount should have comment or be unexported (golint)
    • Line 36: warning: exported function OpenAccountFile should have comment or be unexported (golint)
    • Line 44: warning: exported function WriteAccount should have comment or be unexported (golint)
    • srun/hash/hash.go
    • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 60: warning: comment on exported function XEncode should be of the form "XEncode ..." (golint)
    • Line 97: warning: comment on exported function PwdHmd5 should be of the form "PwdHmd5 ..." (golint)
    • Line 105: warning: comment on exported function Checksum should be of the form "Checksum ..." (golint)
    • Line 125: warning: comment on exported function GenInfo should be of the form "GenInfo ..." (golint)
    • srun/utils/format.go
    • Line 8: warning: exported function FormatFlux should have comment or be unexported (golint)
    • Line 28: warning: exported function FormatTime should have comment or be unexported (golint)
    • srun/utils/request.go
    • Line 22: warning: comment on exported function DoRequest should be of the form "DoRequest ..." (golint)
    • Line 43: warning: exported function GetJson should have comment or be unexported (golint)
    • srun/core/core.go
    • Line 25: warning: comment on exported function Prepare should be of the form "Prepare ..." (golint)
    • Line 40: warning: comment on exported function Login should be of the form "Login ..." (golint)
    • Line 97: warning: comment on exported function Info should be of the form "Info ..." (golint)
    • Line 108: warning: comment on exported function Logout should be of the form "Logout ..." (golint)
    • srun/core/errors.go
    • Line 5: warning: exported var ErrFailed should have comment or be unexported (golint)
    • Line 6: warning: exported var ErrConnected should have comment or be unexported (golint)
    • Line 7: warning: exported var ErrRequest should have comment or be unexported (golint)
    • Line 8: warning: exported var ErrAcid should have comment or be unexported (golint)
    • Line 10: warning: exported var PortalError should have comment or be unexported (golint)
    • srun/resp/resp.go
    • Line 3: warning: exported type ChallengeResp should have comment or be unexported (golint)
    • Line 8: warning: exported type ActionResp should have comment or be unexported (golint)
    • srun/model/account.go
    • Line 8: warning: exported type Account should have comment or be unexported (golint)
    • Line 15: warning: exported method Account.JSONString should have comment or be unexported (golint)
    • Line 24: warning: exported method Account.JSONBytes should have comment or be unexported (golint)
    • srun/model/response.go
    • Line 10: warning: exported type ChallengeResp should have comment or be unexported (golint)
    • Line 15: warning: exported type ActionResp should have comment or be unexported (golint)
    • Line 23: warning: exported type InfoResp should have comment or be unexported (golint)
    • Line 60: warning: exported type InfoResult should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign92%

IneffAssign detects ineffectual assignments in Go code.

    • srun/hash/hash.go
    • Line 69: warning: ineffectual assignment to y (ineffassign)
    • Line 71: warning: ineffectual assignment to m (ineffassign)
    • Line 72: warning: ineffectual assignment to e (ineffassign)
    • Line 73: warning: ineffectual assignment to p (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!